)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"87a9acc2e13999e838701c3b9a59273bf4954523","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e98fe423_2c6b81ae","updated":"2022-07-20 16:26:56.000000000","message":"Thanks for the patch. Although I am still reviewing, please find few comments.","commit_id":"abe0d48d15bda91454ef00a77d941339a75a1a94"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0162485478748d5ecb3e98076256f08f417c26cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f59bbb50_e7ab54af","updated":"2022-07-22 01:47:45.000000000","message":"LGTM","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"64fbd656fc5c103fff2138d5f378d0d836913a5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"64ff6fb9_59e56a18","updated":"2022-07-22 01:50:25.000000000","message":"Thanks for rework. LGTM!","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a985940f1dff5f5d08495ff012d4fd71ecb3f283","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa7da680_7ce6eb9e","updated":"2022-07-25 06:14:34.000000000","message":"LGTM","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"24210f77a14fb34e2c1679361b21e5b7f118fed1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"de69fe8e_3b34d2aa","updated":"2022-07-26 14:58:29.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9ce78a351ae9d685698944ef73267563261bba3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2a50999e_5bb279ee","updated":"2022-07-27 02:43:11.000000000","message":"Thanks for your quick rework! LGTM.","commit_id":"07b9a0112cc81af631c6b4654fd86ab5a29b178d"}],"specs/zed/code-refactoring.rst":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"87a9acc2e13999e838701c3b9a59273bf4954523","unresolved":true,"context_lines":[{"line_number":281,"context_line":"    }"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"  .. note::"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    Since the http-related library (Python library) automatically sends"},{"line_number":287,"context_line":"    the redirection request containing the ``\"stack_id\"`` parameter,"},{"line_number":288,"context_line":"    the ``\"stack_id\"`` is not recognized"},{"line_number":289,"context_line":"    by the Tacker-conductor at the sending stage of this redirection."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"+ For Scale"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"79331279_da62e557","line":290,"range":{"start_line":284,"start_character":0,"end_line":290,"end_character":0},"updated":"2022-07-20 16:26:56.000000000","message":"As the \"Note\" is the same for Terminate, Heal, and Scale operations, would suggest removing repitive occurrences.WDYT?","commit_id":"abe0d48d15bda91454ef00a77d941339a75a1a94"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"64fbd656fc5c103fff2138d5f378d0d836913a5e","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    }"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"  .. note::"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    Since the http-related library (Python library) automatically sends"},{"line_number":287,"context_line":"    the redirection request containing the ``\"stack_id\"`` parameter,"},{"line_number":288,"context_line":"    the ``\"stack_id\"`` is not recognized"},{"line_number":289,"context_line":"    by the Tacker-conductor at the sending stage of this redirection."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"+ For Scale"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e938a36e_fc3a2a3e","line":290,"range":{"start_line":284,"start_character":0,"end_line":290,"end_character":0},"in_reply_to":"14dd8a0f_e6438068","updated":"2022-07-22 01:50:25.000000000","message":"Ack","commit_id":"abe0d48d15bda91454ef00a77d941339a75a1a94"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"5647515ee65164fa7462944361eea824b0f5da76","unresolved":true,"context_lines":[{"line_number":281,"context_line":"    }"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"  .. note::"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    Since the http-related library (Python library) automatically sends"},{"line_number":287,"context_line":"    the redirection request containing the ``\"stack_id\"`` parameter,"},{"line_number":288,"context_line":"    the ``\"stack_id\"`` is not recognized"},{"line_number":289,"context_line":"    by the Tacker-conductor at the sending stage of this redirection."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"+ For Scale"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"14dd8a0f_e6438068","line":290,"range":{"start_line":284,"start_character":0,"end_line":290,"end_character":0},"in_reply_to":"79331279_da62e557","updated":"2022-07-21 06:50:25.000000000","message":"I agree with you.\nI moved the note to the #L48 and deleted same notes in the document.","commit_id":"abe0d48d15bda91454ef00a77d941339a75a1a94"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"87a9acc2e13999e838701c3b9a59273bf4954523","unresolved":true,"context_lines":[{"line_number":953,"context_line":"  It reduces the number of HEAT request, which improves"},{"line_number":954,"context_line":"  performance when running LCM concurrently."},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"* Supprot subscription filter (vnfdId) (for Tacker v1 API)"},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"  It reduces Notifications to user-specified ones,"},{"line_number":959,"context_line":"  which improves the performance."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ce94e3a_b2f10e6e","line":956,"range":{"start_line":956,"start_character":2,"end_line":956,"end_character":9},"updated":"2022-07-20 16:26:56.000000000","message":"Misspell word, Support","commit_id":"abe0d48d15bda91454ef00a77d941339a75a1a94"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"64fbd656fc5c103fff2138d5f378d0d836913a5e","unresolved":false,"context_lines":[{"line_number":953,"context_line":"  It reduces the number of HEAT request, which improves"},{"line_number":954,"context_line":"  performance when running LCM concurrently."},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"* Supprot subscription filter (vnfdId) (for Tacker v1 API)"},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"  It reduces Notifications to user-specified ones,"},{"line_number":959,"context_line":"  which improves the performance."}],"source_content_type":"text/x-rst","patch_set":1,"id":"6b1f9096_765dabab","line":956,"range":{"start_line":956,"start_character":2,"end_line":956,"end_character":9},"in_reply_to":"1cb86934_d13317a4","updated":"2022-07-22 01:50:25.000000000","message":"Ack","commit_id":"abe0d48d15bda91454ef00a77d941339a75a1a94"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"5647515ee65164fa7462944361eea824b0f5da76","unresolved":true,"context_lines":[{"line_number":953,"context_line":"  It reduces the number of HEAT request, which improves"},{"line_number":954,"context_line":"  performance when running LCM concurrently."},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"* Supprot subscription filter (vnfdId) (for Tacker v1 API)"},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"  It reduces Notifications to user-specified ones,"},{"line_number":959,"context_line":"  which improves the performance."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1cb86934_d13317a4","line":956,"range":{"start_line":956,"start_character":2,"end_line":956,"end_character":9},"in_reply_to":"3ce94e3a_b2f10e6e","updated":"2022-07-21 06:50:25.000000000","message":"I fixed it in PS2.","commit_id":"abe0d48d15bda91454ef00a77d941339a75a1a94"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"96895a0f3d556f7538c758834cc6b3945eebf331","unresolved":true,"context_lines":[{"line_number":733,"context_line":""},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"2. Supprot subscription filter (vnfdId) (for Tacker v1 API)"},{"line_number":736,"context_line":"-----------------------------------------------------------"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"The Tacker v1 API has not supported Subscription filter of vnfdId."},{"line_number":739,"context_line":"It causes large log sizes and communication delays by sending"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d194a09e_2f9352be","line":736,"updated":"2022-07-22 06:03:34.000000000","message":"typo: Supprot -\u003e Support","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a985940f1dff5f5d08495ff012d4fd71ecb3f283","unresolved":false,"context_lines":[{"line_number":733,"context_line":""},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"2. Supprot subscription filter (vnfdId) (for Tacker v1 API)"},{"line_number":736,"context_line":"-----------------------------------------------------------"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"The Tacker v1 API has not supported Subscription filter of vnfdId."},{"line_number":739,"context_line":"It causes large log sizes and communication delays by sending"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3c33901d_cafc896d","line":736,"in_reply_to":"5bea4cf1_d65d967b","updated":"2022-07-25 06:14:34.000000000","message":"Done","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"4f7455c007a7f7e804a355a9ae030384ec7fd686","unresolved":true,"context_lines":[{"line_number":733,"context_line":""},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"2. Supprot subscription filter (vnfdId) (for Tacker v1 API)"},{"line_number":736,"context_line":"-----------------------------------------------------------"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"The Tacker v1 API has not supported Subscription filter of vnfdId."},{"line_number":739,"context_line":"It causes large log sizes and communication delays by sending"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5bea4cf1_d65d967b","line":736,"in_reply_to":"d194a09e_2f9352be","updated":"2022-07-22 08:36:31.000000000","message":"I fixed it.","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"96895a0f3d556f7538c758834cc6b3945eebf331","unresolved":true,"context_lines":[{"line_number":867,"context_line":""},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"Indicators of log levels"},{"line_number":870,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":871,"context_line":"Indicators of log levels to output are shown below."},{"line_number":872,"context_line":""},{"line_number":873,"context_line":".. list-table:: Log Levels"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7195d856_9f593695","line":870,"range":{"start_line":870,"start_character":24,"end_line":870,"end_character":26},"updated":"2022-07-22 06:03:34.000000000","message":"This is unnecessary.","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a985940f1dff5f5d08495ff012d4fd71ecb3f283","unresolved":false,"context_lines":[{"line_number":867,"context_line":""},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"Indicators of log levels"},{"line_number":870,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":871,"context_line":"Indicators of log levels to output are shown below."},{"line_number":872,"context_line":""},{"line_number":873,"context_line":".. list-table:: Log Levels"}],"source_content_type":"text/x-rst","patch_set":2,"id":"13db09ed_afe82b2a","line":870,"range":{"start_line":870,"start_character":24,"end_line":870,"end_character":26},"in_reply_to":"1fd8ef60_aaa4f5a1","updated":"2022-07-25 06:14:34.000000000","message":"Done","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"4f7455c007a7f7e804a355a9ae030384ec7fd686","unresolved":true,"context_lines":[{"line_number":867,"context_line":""},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"Indicators of log levels"},{"line_number":870,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":871,"context_line":"Indicators of log levels to output are shown below."},{"line_number":872,"context_line":""},{"line_number":873,"context_line":".. list-table:: Log Levels"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1fd8ef60_aaa4f5a1","line":870,"range":{"start_line":870,"start_character":24,"end_line":870,"end_character":26},"in_reply_to":"7195d856_9f593695","updated":"2022-07-22 08:36:31.000000000","message":"I fixed it.","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"96895a0f3d556f7538c758834cc6b3945eebf331","unresolved":true,"context_lines":[{"line_number":886,"context_line":"    * - error"},{"line_number":887,"context_line":"      - Unexpected runtime error or cause of error."},{"line_number":888,"context_line":"    * - critical"},{"line_number":889,"context_line":"      - Fatal error information.Information that should be addressed if it occurs."},{"line_number":890,"context_line":""},{"line_number":891,"context_line":"Data model impact"},{"line_number":892,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"74f2283e_001be7ec","line":889,"range":{"start_line":889,"start_character":20,"end_line":889,"end_character":44},"updated":"2022-07-22 06:03:34.000000000","message":"It is better to put a space after the period.","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"4f7455c007a7f7e804a355a9ae030384ec7fd686","unresolved":true,"context_lines":[{"line_number":886,"context_line":"    * - error"},{"line_number":887,"context_line":"      - Unexpected runtime error or cause of error."},{"line_number":888,"context_line":"    * - critical"},{"line_number":889,"context_line":"      - Fatal error information.Information that should be addressed if it occurs."},{"line_number":890,"context_line":""},{"line_number":891,"context_line":"Data model impact"},{"line_number":892,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d8ab6854_e0db0d4b","line":889,"range":{"start_line":889,"start_character":20,"end_line":889,"end_character":44},"in_reply_to":"74f2283e_001be7ec","updated":"2022-07-22 08:36:31.000000000","message":"I fixed it.","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a985940f1dff5f5d08495ff012d4fd71ecb3f283","unresolved":false,"context_lines":[{"line_number":886,"context_line":"    * - error"},{"line_number":887,"context_line":"      - Unexpected runtime error or cause of error."},{"line_number":888,"context_line":"    * - critical"},{"line_number":889,"context_line":"      - Fatal error information.Information that should be addressed if it occurs."},{"line_number":890,"context_line":""},{"line_number":891,"context_line":"Data model impact"},{"line_number":892,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b13163a3_8784a2c5","line":889,"range":{"start_line":889,"start_character":20,"end_line":889,"end_character":44},"in_reply_to":"d8ab6854_e0db0d4b","updated":"2022-07-25 06:14:34.000000000","message":"Done","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"96895a0f3d556f7538c758834cc6b3945eebf331","unresolved":true,"context_lines":[{"line_number":909,"context_line":"None"},{"line_number":910,"context_line":""},{"line_number":911,"context_line":"Security impact"},{"line_number":912,"context_line":"-----------------"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"None"},{"line_number":915,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"a216e289_42f10776","line":912,"range":{"start_line":912,"start_character":15,"end_line":912,"end_character":17},"updated":"2022-07-22 06:03:34.000000000","message":"This is unnecessary.","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a985940f1dff5f5d08495ff012d4fd71ecb3f283","unresolved":false,"context_lines":[{"line_number":909,"context_line":"None"},{"line_number":910,"context_line":""},{"line_number":911,"context_line":"Security impact"},{"line_number":912,"context_line":"-----------------"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"None"},{"line_number":915,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"50f9c095_b4ead490","line":912,"range":{"start_line":912,"start_character":15,"end_line":912,"end_character":17},"in_reply_to":"6fadc3b8_8810f3d5","updated":"2022-07-25 06:14:34.000000000","message":"Done","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"4f7455c007a7f7e804a355a9ae030384ec7fd686","unresolved":true,"context_lines":[{"line_number":909,"context_line":"None"},{"line_number":910,"context_line":""},{"line_number":911,"context_line":"Security impact"},{"line_number":912,"context_line":"-----------------"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"None"},{"line_number":915,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"6fadc3b8_8810f3d5","line":912,"range":{"start_line":912,"start_character":15,"end_line":912,"end_character":17},"in_reply_to":"a216e289_42f10776","updated":"2022-07-22 08:36:31.000000000","message":"I fixed it.","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"96895a0f3d556f7538c758834cc6b3945eebf331","unresolved":true,"context_lines":[{"line_number":924,"context_line":"None"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"Performance impact"},{"line_number":927,"context_line":"-------------------"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"* Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":930,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7c7202b6_8f883395","line":927,"range":{"start_line":927,"start_character":18,"end_line":927,"end_character":19},"updated":"2022-07-22 06:03:34.000000000","message":"ditto","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"4f7455c007a7f7e804a355a9ae030384ec7fd686","unresolved":true,"context_lines":[{"line_number":924,"context_line":"None"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"Performance impact"},{"line_number":927,"context_line":"-------------------"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"* Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":930,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9e36955c_8e726f0d","line":927,"range":{"start_line":927,"start_character":18,"end_line":927,"end_character":19},"in_reply_to":"7c7202b6_8f883395","updated":"2022-07-22 08:36:31.000000000","message":"I fixed it.","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a985940f1dff5f5d08495ff012d4fd71ecb3f283","unresolved":false,"context_lines":[{"line_number":924,"context_line":"None"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"Performance impact"},{"line_number":927,"context_line":"-------------------"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"* Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":930,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"aebdaf69_82ed33e5","line":927,"range":{"start_line":927,"start_character":18,"end_line":927,"end_character":19},"in_reply_to":"9e36955c_8e726f0d","updated":"2022-07-25 06:14:34.000000000","message":"Done","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"96895a0f3d556f7538c758834cc6b3945eebf331","unresolved":true,"context_lines":[{"line_number":941,"context_line":"  Prevent log bloat and suppress performance degradation under heavy load."},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"Other developer impact"},{"line_number":944,"context_line":"-----------------------"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"None"},{"line_number":947,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"b0b3250d_0e36d544","line":944,"range":{"start_line":944,"start_character":22,"end_line":944,"end_character":23},"updated":"2022-07-22 06:03:34.000000000","message":"ditto","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a985940f1dff5f5d08495ff012d4fd71ecb3f283","unresolved":false,"context_lines":[{"line_number":941,"context_line":"  Prevent log bloat and suppress performance degradation under heavy load."},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"Other developer impact"},{"line_number":944,"context_line":"-----------------------"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"None"},{"line_number":947,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"eba2d4d6_247a5533","line":944,"range":{"start_line":944,"start_character":22,"end_line":944,"end_character":23},"in_reply_to":"4714df2a_5577a7da","updated":"2022-07-25 06:14:34.000000000","message":"Done","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"4f7455c007a7f7e804a355a9ae030384ec7fd686","unresolved":true,"context_lines":[{"line_number":941,"context_line":"  Prevent log bloat and suppress performance degradation under heavy load."},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"Other developer impact"},{"line_number":944,"context_line":"-----------------------"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"None"},{"line_number":947,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"4714df2a_5577a7da","line":944,"range":{"start_line":944,"start_character":22,"end_line":944,"end_character":23},"in_reply_to":"b0b3250d_0e36d544","updated":"2022-07-22 08:36:31.000000000","message":"I fixed it.","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"96895a0f3d556f7538c758834cc6b3945eebf331","unresolved":true,"context_lines":[{"line_number":946,"context_line":"None"},{"line_number":947,"context_line":""},{"line_number":948,"context_line":"Developer impact"},{"line_number":949,"context_line":"-----------------"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"Developers will be able to use appropriate log levels"},{"line_number":952,"context_line":"to prevent log bloat and analyze the cause of errors."}],"source_content_type":"text/x-rst","patch_set":2,"id":"2bf4eed6_af68671a","line":949,"range":{"start_line":949,"start_character":16,"end_line":949,"end_character":17},"updated":"2022-07-22 06:03:34.000000000","message":"ditto","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"4f7455c007a7f7e804a355a9ae030384ec7fd686","unresolved":true,"context_lines":[{"line_number":946,"context_line":"None"},{"line_number":947,"context_line":""},{"line_number":948,"context_line":"Developer impact"},{"line_number":949,"context_line":"-----------------"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"Developers will be able to use appropriate log levels"},{"line_number":952,"context_line":"to prevent log bloat and analyze the cause of errors."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfbcc6d7_c91ff8de","line":949,"range":{"start_line":949,"start_character":16,"end_line":949,"end_character":17},"in_reply_to":"2bf4eed6_af68671a","updated":"2022-07-22 08:36:31.000000000","message":"I fixed it.","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a985940f1dff5f5d08495ff012d4fd71ecb3f283","unresolved":false,"context_lines":[{"line_number":946,"context_line":"None"},{"line_number":947,"context_line":""},{"line_number":948,"context_line":"Developer impact"},{"line_number":949,"context_line":"-----------------"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"Developers will be able to use appropriate log levels"},{"line_number":952,"context_line":"to prevent log bloat and analyze the cause of errors."}],"source_content_type":"text/x-rst","patch_set":2,"id":"8a4bc932_ebb4405c","line":949,"range":{"start_line":949,"start_character":16,"end_line":949,"end_character":17},"in_reply_to":"bfbcc6d7_c91ff8de","updated":"2022-07-25 06:14:34.000000000","message":"Done","commit_id":"bd8596f89b8865af586d01f72014264869cf7641"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"24210f77a14fb34e2c1679361b21e5b7f118fed1","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This specification proposes the following code refactoring."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"#. Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":22,"context_line":"#. Support subscription filter (vnfdId) (for Tacker v1 API)"},{"line_number":23,"context_line":"#. Refactor the Log Levels of Tacker Output Logs (for Tacker v1/v2 API)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"0f355c80_e5c6ed74","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":83},"updated":"2022-07-26 14:58:29.000000000","message":"nit: 79 char/line over, \nCould you shorten this sentence a little more because it is also the chapter name below?","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"d6e4e830f90494b60f8192be6b0cbb9c8cbd36cf","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This specification proposes the following code refactoring."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"#. Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":22,"context_line":"#. Support subscription filter (vnfdId) (for Tacker v1 API)"},{"line_number":23,"context_line":"#. Refactor the Log Levels of Tacker Output Logs (for Tacker v1/v2 API)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"a4e27886_326bbe62","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":83},"in_reply_to":"0f355c80_e5c6ed74","updated":"2022-07-27 01:38:24.000000000","message":"I revised the sentence.","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9ce78a351ae9d685698944ef73267563261bba3a","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This specification proposes the following code refactoring."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"#. Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":22,"context_line":"#. Support subscription filter (vnfdId) (for Tacker v1 API)"},{"line_number":23,"context_line":"#. Refactor the Log Levels of Tacker Output Logs (for Tacker v1/v2 API)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"627b0b45_abcc9b44","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":83},"in_reply_to":"a4e27886_326bbe62","updated":"2022-07-27 02:43:11.000000000","message":"Ack","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"24210f77a14fb34e2c1679361b21e5b7f118fed1","unresolved":true,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"1. Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":30,"context_line":"-----------------------------------------------------------------------------------"},{"line_number":31,"context_line":"When executing VNF LCM operation"},{"line_number":32,"context_line":"such as ``Instantiate``, ``Terminate``, ``Scale``, and ``Heal``,"},{"line_number":33,"context_line":"current implementation uses ``\"Find stack\"`` API [#HEAT-V1]_"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e5ee0ff2_5e7512df","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":83},"updated":"2022-07-26 14:58:29.000000000","message":"ditto.","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9ce78a351ae9d685698944ef73267563261bba3a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"1. Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":30,"context_line":"-----------------------------------------------------------------------------------"},{"line_number":31,"context_line":"When executing VNF LCM operation"},{"line_number":32,"context_line":"such as ``Instantiate``, ``Terminate``, ``Scale``, and ``Heal``,"},{"line_number":33,"context_line":"current implementation uses ``\"Find stack\"`` API [#HEAT-V1]_"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1cf9ac08_cb93380b","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":83},"in_reply_to":"c621501f_69bb6535","updated":"2022-07-27 02:43:11.000000000","message":"Ack","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"d6e4e830f90494b60f8192be6b0cbb9c8cbd36cf","unresolved":true,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"1. Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":30,"context_line":"-----------------------------------------------------------------------------------"},{"line_number":31,"context_line":"When executing VNF LCM operation"},{"line_number":32,"context_line":"such as ``Instantiate``, ``Terminate``, ``Scale``, and ``Heal``,"},{"line_number":33,"context_line":"current implementation uses ``\"Find stack\"`` API [#HEAT-V1]_"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c621501f_69bb6535","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":83},"in_reply_to":"e5ee0ff2_5e7512df","updated":"2022-07-27 01:38:24.000000000","message":"ditto.","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"24210f77a14fb34e2c1679361b21e5b7f118fed1","unresolved":true,"context_lines":[{"line_number":705,"context_line":""},{"line_number":706,"context_line":"  + | Similar performance improvements can be made during other LCM operations."},{"line_number":707,"context_line":"    | For example, in the \"Rollback\" process for Instantiate,"},{"line_number":708,"context_line":"      the \"DELETE stack\" can use the \"stack_id\" as described above to improve performance."},{"line_number":709,"context_line":""},{"line_number":710,"context_line":".. note::"},{"line_number":711,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"e2b69867_dc251c1e","line":708,"range":{"start_line":708,"start_character":77,"end_line":708,"end_character":78},"updated":"2022-07-26 14:58:29.000000000","message":"nit: 79 char/line over, could you start a new line here?","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9ce78a351ae9d685698944ef73267563261bba3a","unresolved":false,"context_lines":[{"line_number":705,"context_line":""},{"line_number":706,"context_line":"  + | Similar performance improvements can be made during other LCM operations."},{"line_number":707,"context_line":"    | For example, in the \"Rollback\" process for Instantiate,"},{"line_number":708,"context_line":"      the \"DELETE stack\" can use the \"stack_id\" as described above to improve performance."},{"line_number":709,"context_line":""},{"line_number":710,"context_line":".. note::"},{"line_number":711,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5539ae48_e2ead81c","line":708,"range":{"start_line":708,"start_character":77,"end_line":708,"end_character":78},"in_reply_to":"b3bb9003_838792f4","updated":"2022-07-27 02:43:11.000000000","message":"Ack","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"d6e4e830f90494b60f8192be6b0cbb9c8cbd36cf","unresolved":true,"context_lines":[{"line_number":705,"context_line":""},{"line_number":706,"context_line":"  + | Similar performance improvements can be made during other LCM operations."},{"line_number":707,"context_line":"    | For example, in the \"Rollback\" process for Instantiate,"},{"line_number":708,"context_line":"      the \"DELETE stack\" can use the \"stack_id\" as described above to improve performance."},{"line_number":709,"context_line":""},{"line_number":710,"context_line":".. note::"},{"line_number":711,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"b3bb9003_838792f4","line":708,"range":{"start_line":708,"start_character":77,"end_line":708,"end_character":78},"in_reply_to":"e2b69867_dc251c1e","updated":"2022-07-27 01:38:24.000000000","message":"ditto.","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"24210f77a14fb34e2c1679361b21e5b7f118fed1","unresolved":true,"context_lines":[{"line_number":798,"context_line":""},{"line_number":799,"context_line":"* Performance perspective"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"  * From a performance perspective, frequent info level logging in a double loop,"},{"line_number":802,"context_line":"    such as the following, is undesirable."},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"    .. code-block::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"cc4b669d_e46f8168","line":801,"range":{"start_line":801,"start_character":75,"end_line":801,"end_character":76},"updated":"2022-07-26 14:58:29.000000000","message":"nit: 79 char/line over, could you change to a new line here?","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9ce78a351ae9d685698944ef73267563261bba3a","unresolved":false,"context_lines":[{"line_number":798,"context_line":""},{"line_number":799,"context_line":"* Performance perspective"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"  * From a performance perspective, frequent info level logging in a double loop,"},{"line_number":802,"context_line":"    such as the following, is undesirable."},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"    .. code-block::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"512bdb07_29a9ad3a","line":801,"range":{"start_line":801,"start_character":75,"end_line":801,"end_character":76},"in_reply_to":"3008ef57_f77ff77e","updated":"2022-07-27 02:43:11.000000000","message":"Ack","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"d6e4e830f90494b60f8192be6b0cbb9c8cbd36cf","unresolved":true,"context_lines":[{"line_number":798,"context_line":""},{"line_number":799,"context_line":"* Performance perspective"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"  * From a performance perspective, frequent info level logging in a double loop,"},{"line_number":802,"context_line":"    such as the following, is undesirable."},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"    .. code-block::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3008ef57_f77ff77e","line":801,"range":{"start_line":801,"start_character":75,"end_line":801,"end_character":76},"in_reply_to":"cc4b669d_e46f8168","updated":"2022-07-27 01:38:24.000000000","message":"ditto.","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"24210f77a14fb34e2c1679361b21e5b7f118fed1","unresolved":true,"context_lines":[{"line_number":891,"context_line":"Data model impact"},{"line_number":892,"context_line":"-----------------"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"* Modify below tables in \u0027tacker\u0027 database. The corresponding schemas are detailed below:"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"  * Option 2 of \"Change getting OpenStack resource process to one transaction\""},{"line_number":897,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"4508b2ff_09d095cd","line":894,"range":{"start_line":894,"start_character":73,"end_line":894,"end_character":74},"updated":"2022-07-26 14:58:29.000000000","message":"nit: 79 char/line over, could you start a new line here?","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"d6e4e830f90494b60f8192be6b0cbb9c8cbd36cf","unresolved":true,"context_lines":[{"line_number":891,"context_line":"Data model impact"},{"line_number":892,"context_line":"-----------------"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"* Modify below tables in \u0027tacker\u0027 database. The corresponding schemas are detailed below:"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"  * Option 2 of \"Change getting OpenStack resource process to one transaction\""},{"line_number":897,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"6c10875b_e31d0cb4","line":894,"range":{"start_line":894,"start_character":73,"end_line":894,"end_character":74},"in_reply_to":"4508b2ff_09d095cd","updated":"2022-07-27 01:38:24.000000000","message":"ditto.","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9ce78a351ae9d685698944ef73267563261bba3a","unresolved":false,"context_lines":[{"line_number":891,"context_line":"Data model impact"},{"line_number":892,"context_line":"-----------------"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"* Modify below tables in \u0027tacker\u0027 database. The corresponding schemas are detailed below:"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"  * Option 2 of \"Change getting OpenStack resource process to one transaction\""},{"line_number":897,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"cbb96a75_a423316b","line":894,"range":{"start_line":894,"start_character":73,"end_line":894,"end_character":74},"in_reply_to":"6c10875b_e31d0cb4","updated":"2022-07-27 02:43:11.000000000","message":"Ack","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"24210f77a14fb34e2c1679361b21e5b7f118fed1","unresolved":true,"context_lines":[{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    * Data Format Image"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"      \"instantiatedVnfInfo\" : { \"metadata\": { \"stack_id\": \"cb9d8959-ab17-4270-a4c9-257d267ca9f1\" } }"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"efbd1c74_96d973bb","line":903,"range":{"start_line":903,"start_character":6,"end_line":903,"end_character":100},"updated":"2022-07-26 14:58:29.000000000","message":"How about you this line into `.. code-block:: json`?","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9ce78a351ae9d685698944ef73267563261bba3a","unresolved":false,"context_lines":[{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    * Data Format Image"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"      \"instantiatedVnfInfo\" : { \"metadata\": { \"stack_id\": \"cb9d8959-ab17-4270-a4c9-257d267ca9f1\" } }"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"cfa9356a_c8116f61","line":903,"range":{"start_line":903,"start_character":6,"end_line":903,"end_character":100},"in_reply_to":"7e22ccd4_3a2da198","updated":"2022-07-27 02:43:11.000000000","message":"Ack","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"d6e4e830f90494b60f8192be6b0cbb9c8cbd36cf","unresolved":true,"context_lines":[{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    * Data Format Image"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"      \"instantiatedVnfInfo\" : { \"metadata\": { \"stack_id\": \"cb9d8959-ab17-4270-a4c9-257d267ca9f1\" } }"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7e22ccd4_3a2da198","line":903,"range":{"start_line":903,"start_character":6,"end_line":903,"end_character":100},"in_reply_to":"efbd1c74_96d973bb","updated":"2022-07-27 01:38:24.000000000","message":"ditto.","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"24210f77a14fb34e2c1679361b21e5b7f118fed1","unresolved":true,"context_lines":[{"line_number":926,"context_line":"Performance impact"},{"line_number":927,"context_line":"------------------"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"* Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"  It reduces the number of HEAT request, which improves"},{"line_number":932,"context_line":"  performance when running LCM concurrently."}],"source_content_type":"text/x-rst","patch_set":3,"id":"afd5bd7a_96728934","line":929,"range":{"start_line":929,"start_character":2,"end_line":929,"end_character":82},"updated":"2022-07-26 14:58:29.000000000","message":"Same comment as pointed out in \"Problem description\".","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"d6e4e830f90494b60f8192be6b0cbb9c8cbd36cf","unresolved":true,"context_lines":[{"line_number":926,"context_line":"Performance impact"},{"line_number":927,"context_line":"------------------"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"* Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"  It reduces the number of HEAT request, which improves"},{"line_number":932,"context_line":"  performance when running LCM concurrently."}],"source_content_type":"text/x-rst","patch_set":3,"id":"c2c1ec33_42a7f530","line":929,"range":{"start_line":929,"start_character":2,"end_line":929,"end_character":82},"in_reply_to":"afd5bd7a_96728934","updated":"2022-07-27 01:38:24.000000000","message":"ditto.","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9ce78a351ae9d685698944ef73267563261bba3a","unresolved":false,"context_lines":[{"line_number":926,"context_line":"Performance impact"},{"line_number":927,"context_line":"------------------"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"* Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"  It reduces the number of HEAT request, which improves"},{"line_number":932,"context_line":"  performance when running LCM concurrently."}],"source_content_type":"text/x-rst","patch_set":3,"id":"430add46_cd87bda1","line":929,"range":{"start_line":929,"start_character":2,"end_line":929,"end_character":82},"in_reply_to":"c2c1ec33_42a7f530","updated":"2022-07-27 02:43:11.000000000","message":"Ack","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"24210f77a14fb34e2c1679361b21e5b7f118fed1","unresolved":true,"context_lines":[{"line_number":971,"context_line":"----------"},{"line_number":972,"context_line":"* \"Tacker-conductor\" will be modified to implement the following features."},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"  * Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    * Handle \"stack_id\"."},{"line_number":977,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"4c91f55a_adc92327","line":974,"range":{"start_line":974,"start_character":4,"end_line":974,"end_character":84},"updated":"2022-07-26 14:58:29.000000000","message":"ditto.","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"d6e4e830f90494b60f8192be6b0cbb9c8cbd36cf","unresolved":true,"context_lines":[{"line_number":971,"context_line":"----------"},{"line_number":972,"context_line":"* \"Tacker-conductor\" will be modified to implement the following features."},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"  * Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    * Handle \"stack_id\"."},{"line_number":977,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"a2e64e31_2c974472","line":974,"range":{"start_line":974,"start_character":4,"end_line":974,"end_character":84},"in_reply_to":"4c91f55a_adc92327","updated":"2022-07-27 01:38:24.000000000","message":"ditto.","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9ce78a351ae9d685698944ef73267563261bba3a","unresolved":false,"context_lines":[{"line_number":971,"context_line":"----------"},{"line_number":972,"context_line":"* \"Tacker-conductor\" will be modified to implement the following features."},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"  * Change getting OpenStack resource process to one transaction (for Tacker v2 API)"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    * Handle \"stack_id\"."},{"line_number":977,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7afdda5d_26680824","line":974,"range":{"start_line":974,"start_character":4,"end_line":974,"end_character":84},"in_reply_to":"a2e64e31_2c974472","updated":"2022-07-27 02:43:11.000000000","message":"Ack","commit_id":"dcce00b63c6a4dc5be5b770f2c6b410ae8131f1b"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fb1a34c82a69d028bb5463553666c444858f1409","unresolved":true,"context_lines":[{"line_number":832,"context_line":""},{"line_number":833,"context_line":"* Analysis perspective"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"  * This is the cause of the error,"},{"line_number":836,"context_line":"    but it is difficult to analyze because the log is output at the info level."},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"    .. code-block::"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"       def _get_vnfd_id(context, id):"},{"line_number":841,"context_line":"           try:"},{"line_number":842,"context_line":"               vnf_package_vnfd \u003d \\"},{"line_number":843,"context_line":"                   api.model_query(context, models.VnfPackageVnfd).\\"},{"line_number":844,"context_line":"                   filter_by(package_uuid\u003did).first()"},{"line_number":845,"context_line":"           except Exception:"},{"line_number":846,"context_line":"               LOG.info(\"select vnf_package_vnfd failed\")"},{"line_number":847,"context_line":"           if vnf_package_vnfd:"},{"line_number":848,"context_line":"               return vnf_package_vnfd.vnfd_id"},{"line_number":849,"context_line":"           else:"},{"line_number":850,"context_line":"               return None"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"  * This is necessary for analysis, but you do not need to log dict,"},{"line_number":853,"context_line":"    so modify info to debug output."},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    .. code-block::"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"        def create_vdu_image_dict(grant_info):"},{"line_number":858,"context_line":"            \"\"\"Create a dict containing information about VDU\u0027s image."},{"line_number":859,"context_line":"            :param grant_info: dict(Grant information format)"},{"line_number":860,"context_line":"            :return: dict(VDU name, Glance-image uuid)"},{"line_number":861,"context_line":"            \"\"\""},{"line_number":862,"context_line":"            vdu_image_dict \u003d {}"},{"line_number":863,"context_line":"            for vdu_name, resources in grant_info.items():"},{"line_number":864,"context_line":"                for vnf_resource in resources:"},{"line_number":865,"context_line":"                    vdu_image_dict[vdu_name] \u003d vnf_resource.resource_identifier"},{"line_number":866,"context_line":"            LOG.info(\u0027vdu_image_dict: %s\u0027, vdu_image_dict)"},{"line_number":867,"context_line":"            return vdu_image_dict"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"Indicators of log levels"},{"line_number":871,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"2e5c3a26_aa2be311","line":868,"range":{"start_line":835,"start_character":0,"end_line":868,"end_character":0},"updated":"2022-07-27 04:25:48.000000000","message":"Why don\u0027t you add suggestions which loglevel is appropriate for these three examples to make it clear the point of your proposal?","commit_id":"07b9a0112cc81af631c6b4654fd86ab5a29b178d"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"afa788700a2a62f62d59f145849e7878f08c886e","unresolved":true,"context_lines":[{"line_number":832,"context_line":""},{"line_number":833,"context_line":"* Analysis perspective"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"  * This is the cause of the error,"},{"line_number":836,"context_line":"    but it is difficult to analyze because the log is output at the info level."},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"    .. code-block::"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"       def _get_vnfd_id(context, id):"},{"line_number":841,"context_line":"           try:"},{"line_number":842,"context_line":"               vnf_package_vnfd \u003d \\"},{"line_number":843,"context_line":"                   api.model_query(context, models.VnfPackageVnfd).\\"},{"line_number":844,"context_line":"                   filter_by(package_uuid\u003did).first()"},{"line_number":845,"context_line":"           except Exception:"},{"line_number":846,"context_line":"               LOG.info(\"select vnf_package_vnfd failed\")"},{"line_number":847,"context_line":"           if vnf_package_vnfd:"},{"line_number":848,"context_line":"               return vnf_package_vnfd.vnfd_id"},{"line_number":849,"context_line":"           else:"},{"line_number":850,"context_line":"               return None"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"  * This is necessary for analysis, but you do not need to log dict,"},{"line_number":853,"context_line":"    so modify info to debug output."},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    .. code-block::"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"        def create_vdu_image_dict(grant_info):"},{"line_number":858,"context_line":"            \"\"\"Create a dict containing information about VDU\u0027s image."},{"line_number":859,"context_line":"            :param grant_info: dict(Grant information format)"},{"line_number":860,"context_line":"            :return: dict(VDU name, Glance-image uuid)"},{"line_number":861,"context_line":"            \"\"\""},{"line_number":862,"context_line":"            vdu_image_dict \u003d {}"},{"line_number":863,"context_line":"            for vdu_name, resources in grant_info.items():"},{"line_number":864,"context_line":"                for vnf_resource in resources:"},{"line_number":865,"context_line":"                    vdu_image_dict[vdu_name] \u003d vnf_resource.resource_identifier"},{"line_number":866,"context_line":"            LOG.info(\u0027vdu_image_dict: %s\u0027, vdu_image_dict)"},{"line_number":867,"context_line":"            return vdu_image_dict"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"Indicators of log levels"},{"line_number":871,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"24835646_1c9f73a5","line":868,"range":{"start_line":835,"start_character":0,"end_line":868,"end_character":0},"in_reply_to":"2e5c3a26_aa2be311","updated":"2022-07-27 12:11:48.000000000","message":"There are three log examples, but the first one is for the issue of implementation in a double loop. Therefore, I revised description to show appropriate log level for two examples.","commit_id":"07b9a0112cc81af631c6b4654fd86ab5a29b178d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fb1a34c82a69d028bb5463553666c444858f1409","unresolved":true,"context_lines":[{"line_number":875,"context_line":"    :header-rows: 1"},{"line_number":876,"context_line":"    :widths: 10 25"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"    * - Log Level"},{"line_number":879,"context_line":"      - Description"},{"line_number":880,"context_line":"    * - debug"},{"line_number":881,"context_line":"      - Detailed information about system activity."},{"line_number":882,"context_line":"    * - info"},{"line_number":883,"context_line":"      - Generally useful information to log (service start/stop, configuration assumptions, etc)."},{"line_number":884,"context_line":"    * - warning"},{"line_number":885,"context_line":"      - Incorrect use of the API, near error, etc."},{"line_number":886,"context_line":"        any unexpected problem that is not necessarily abnormal but is not normal at runtime."},{"line_number":887,"context_line":"    * - error"},{"line_number":888,"context_line":"      - Unexpected runtime error or cause of error."},{"line_number":889,"context_line":"    * - critical"},{"line_number":890,"context_line":"      - Fatal error information. Information that should be addressed if it occurs."},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"Data model impact"},{"line_number":893,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"34d29326_dd8686ea","line":890,"range":{"start_line":878,"start_character":0,"end_line":890,"end_character":83},"updated":"2022-07-27 04:25:48.000000000","message":"Just a question because I was not at the PTG discussion for the topic and cannot find the conclusion on [1]. Is there any agreement for the list at that time? IMO, it doesn\u0027t make sense for these description for warning, error and critical without any example.\n\n[1]https://etherpad.opendev.org/p/tacker-zed-ptg","commit_id":"07b9a0112cc81af631c6b4654fd86ab5a29b178d"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"afa788700a2a62f62d59f145849e7878f08c886e","unresolved":true,"context_lines":[{"line_number":875,"context_line":"    :header-rows: 1"},{"line_number":876,"context_line":"    :widths: 10 25"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"    * - Log Level"},{"line_number":879,"context_line":"      - Description"},{"line_number":880,"context_line":"    * - debug"},{"line_number":881,"context_line":"      - Detailed information about system activity."},{"line_number":882,"context_line":"    * - info"},{"line_number":883,"context_line":"      - Generally useful information to log (service start/stop, configuration assumptions, etc)."},{"line_number":884,"context_line":"    * - warning"},{"line_number":885,"context_line":"      - Incorrect use of the API, near error, etc."},{"line_number":886,"context_line":"        any unexpected problem that is not necessarily abnormal but is not normal at runtime."},{"line_number":887,"context_line":"    * - error"},{"line_number":888,"context_line":"      - Unexpected runtime error or cause of error."},{"line_number":889,"context_line":"    * - critical"},{"line_number":890,"context_line":"      - Fatal error information. Information that should be addressed if it occurs."},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"Data model impact"},{"line_number":893,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"6dcb9798_bdc57a60","line":890,"range":{"start_line":878,"start_character":0,"end_line":890,"end_character":83},"in_reply_to":"34d29326_dd8686ea","updated":"2022-07-27 12:11:48.000000000","message":"There is no comment in PTG on this topic.\nI understood your comment, but appropriate logging levels vary from case to case.\nIt is difficult to explain individual cases in the SPEC.\n\nInstead, I reorganized the SPEC to make current issues more readable in PS5.\nI separated the two issues: implemented in double loop and inappropriate logging level. Also, I added the note from #L891, which mentions the appropriate log level.","commit_id":"07b9a0112cc81af631c6b4654fd86ab5a29b178d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fb1a34c82a69d028bb5463553666c444858f1409","unresolved":true,"context_lines":[{"line_number":892,"context_line":"Data model impact"},{"line_number":893,"context_line":"-----------------"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"* Modify below tables in \u0027tacker\u0027 database. The corresponding schemas"},{"line_number":896,"context_line":"  are detailed below:"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"  * Option 2 of \"Reduce transactions of getting OpenStack resource\""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9bba37a2_b6e3b36f","line":895,"range":{"start_line":895,"start_character":25,"end_line":895,"end_character":26},"updated":"2022-07-27 04:25:48.000000000","message":"nit: double backquotes correctly?","commit_id":"07b9a0112cc81af631c6b4654fd86ab5a29b178d"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"afa788700a2a62f62d59f145849e7878f08c886e","unresolved":true,"context_lines":[{"line_number":892,"context_line":"Data model impact"},{"line_number":893,"context_line":"-----------------"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"* Modify below tables in \u0027tacker\u0027 database. The corresponding schemas"},{"line_number":896,"context_line":"  are detailed below:"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"  * Option 2 of \"Reduce transactions of getting OpenStack resource\""}],"source_content_type":"text/x-rst","patch_set":4,"id":"a22bf2a1_099643da","line":895,"range":{"start_line":895,"start_character":25,"end_line":895,"end_character":26},"in_reply_to":"9bba37a2_b6e3b36f","updated":"2022-07-27 12:11:48.000000000","message":"I removed this quote to unify the description with others.","commit_id":"07b9a0112cc81af631c6b4654fd86ab5a29b178d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fb1a34c82a69d028bb5463553666c444858f1409","unresolved":true,"context_lines":[{"line_number":939,"context_line":"  It reduces Notifications to user-specified ones,"},{"line_number":940,"context_line":"  which improves the performance."},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"* Refactor the Log Levels of Tacker Output Logs (for Tacker v1/v2 API)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"  Prevent log bloat and suppress performance degradation under heavy load."},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"Other developer impact"},{"line_number":947,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"a01315c8_6702de8f","line":944,"range":{"start_line":942,"start_character":0,"end_line":944,"end_character":74},"updated":"2022-07-27 04:25:48.000000000","message":"I don\u0027t agree to this one to have an impact for performance so much actually.","commit_id":"07b9a0112cc81af631c6b4654fd86ab5a29b178d"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"afa788700a2a62f62d59f145849e7878f08c886e","unresolved":true,"context_lines":[{"line_number":939,"context_line":"  It reduces Notifications to user-specified ones,"},{"line_number":940,"context_line":"  which improves the performance."},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"* Refactor the Log Levels of Tacker Output Logs (for Tacker v1/v2 API)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"  Prevent log bloat and suppress performance degradation under heavy load."},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"Other developer impact"},{"line_number":947,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"13c23f39_471ed1a3","line":944,"range":{"start_line":942,"start_character":0,"end_line":944,"end_character":74},"in_reply_to":"a01315c8_6702de8f","updated":"2022-07-27 12:11:48.000000000","message":"As I mention in other comment, I separated the two issues: implemented in double loop and inappropriate logging level. I think the former one affects the performance. I revised the description of Performance impact to limit the former one.","commit_id":"07b9a0112cc81af631c6b4654fd86ab5a29b178d"}]}