)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2816329f634c9c90b41af6e1a32631b1409937d9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cca90264_9a5896c6","updated":"2022-07-26 07:06:00.000000000","message":"Thanks for the patch. Please find comments.","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a91b343c29c2edba138ed57ac1b0694904a01b38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3016a000_812e1cc7","updated":"2022-07-21 05:57:00.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3cfd8646038f2d91c36f14d969451b4634475ca3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ba8621c1_7308d092","updated":"2022-07-28 12:30:54.000000000","message":"Thanks for your rework, but I have additional comments. Please kindly find my comments.","commit_id":"cc6716bd322f35edc595872b11997a7db851be68"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"71e22a507bd80cd82d0f84b4240d3971a467bd64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3800f834_4833c93d","updated":"2022-07-29 05:38:57.000000000","message":"Thanks for rework. LGTM!!","commit_id":"7555ec76b7df1c574d44a98cc2e64b3b23606f7f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"db5af986450c3e15687807b5732d180f3e44db8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f6d907e2_28383c13","updated":"2022-07-29 05:20:03.000000000","message":"Thanks for your rework, LGTM.","commit_id":"7555ec76b7df1c574d44a98cc2e64b3b23606f7f"}],"specs/zed/support-openid-k8s-vim.rst":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a91b343c29c2edba138ed57ac1b0694904a01b38","unresolved":true,"context_lines":[{"line_number":26,"context_line":"             |      User      |   2.setup Kubernetes                                           |"},{"line_number":27,"context_line":"             |                +----------------------------------------+                       |"},{"line_number":28,"context_line":"             +-----+------+---+                                        |                       |"},{"line_number":29,"context_line":"     6.CNF LCM     |      | 3.register vim                             |                       |"},{"line_number":30,"context_line":" (e.g. instantiate)|      |                                            |                       |"},{"line_number":31,"context_line":"                   |      |                                            |                       |"},{"line_number":32,"context_line":"         +-----------------------------------------------------+   +---v---------+    +--------v--------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8daec94d_c42cc275","line":29,"range":{"start_line":29,"start_character":28,"end_line":29,"end_character":42},"updated":"2022-07-21 05:57:00.000000000","message":"Is `register vim` surely required to use authentication with OpenID?\nIn V2 API, can we instantiate CNF using InstantiateVnfRequest.vimConnectionInfo with auth info without registered VIM?\n\nIf so, could you write it clearly and sample parameter for InstantiateVnfRequest to the below section?","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3cfd8646038f2d91c36f14d969451b4634475ca3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"             |      User      |   2.setup Kubernetes                                           |"},{"line_number":27,"context_line":"             |                +----------------------------------------+                       |"},{"line_number":28,"context_line":"             +-----+------+---+                                        |                       |"},{"line_number":29,"context_line":"     6.CNF LCM     |      | 3.register vim                             |                       |"},{"line_number":30,"context_line":" (e.g. instantiate)|      |                                            |                       |"},{"line_number":31,"context_line":"                   |      |                                            |                       |"},{"line_number":32,"context_line":"         +-----------------------------------------------------+   +---v---------+    +--------v--------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9003f8ed_5417812d","line":29,"range":{"start_line":29,"start_character":28,"end_line":29,"end_character":42},"in_reply_to":"5b0bd433_e8b2696f","updated":"2022-07-28 12:30:54.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":26,"context_line":"             |      User      |   2.setup Kubernetes                                           |"},{"line_number":27,"context_line":"             |                +----------------------------------------+                       |"},{"line_number":28,"context_line":"             +-----+------+---+                                        |                       |"},{"line_number":29,"context_line":"     6.CNF LCM     |      | 3.register vim                             |                       |"},{"line_number":30,"context_line":" (e.g. instantiate)|      |                                            |                       |"},{"line_number":31,"context_line":"                   |      |                                            |                       |"},{"line_number":32,"context_line":"         +-----------------------------------------------------+   +---v---------+    +--------v--------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5b0bd433_e8b2696f","line":29,"range":{"start_line":29,"start_character":28,"end_line":29,"end_character":42},"in_reply_to":"8daec94d_c42cc275","updated":"2022-07-28 08:31:19.000000000","message":"I think V2 LCM does not require this step because as you mentioned. I\u0027ve added those descriptions as note, and added sample parameters of V1/V2 LCM operations.","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2816329f634c9c90b41af6e1a32631b1409937d9","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":".. note::"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  The IdP has investigated with Keycloak. Whether there is a difference using another IdP requires additional investigation."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The following changes are required to support OIDC authentication:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e01a5cb4_4e3a69d6","line":81,"range":{"start_line":81,"start_character":32,"end_line":81,"end_character":40},"updated":"2022-07-26 07:06:00.000000000","message":"Could you please add a reference URL for \"Keycloak\".","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a91b343c29c2edba138ed57ac1b0694904a01b38","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":".. note::"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  The IdP has investigated with Keycloak. Whether there is a difference using another IdP requires additional investigation."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The following changes are required to support OIDC authentication:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3d531be9_1808de69","line":81,"range":{"start_line":81,"start_character":77,"end_line":81,"end_character":78},"updated":"2022-07-21 05:57:00.000000000","message":"nit: Could you break the line here?","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":".. note::"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  The IdP has investigated with Keycloak. Whether there is a difference using another IdP requires additional investigation."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The following changes are required to support OIDC authentication:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa4b99c1_6dc95fc5","line":81,"range":{"start_line":81,"start_character":77,"end_line":81,"end_character":78},"in_reply_to":"3d531be9_1808de69","updated":"2022-07-28 08:31:19.000000000","message":"I\u0027ve fixed it in PS4.","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"71e22a507bd80cd82d0f84b4240d3971a467bd64","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":".. note::"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  The IdP has investigated with Keycloak. Whether there is a difference using another IdP requires additional investigation."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The following changes are required to support OIDC authentication:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"77409f07_8f324125","line":81,"range":{"start_line":81,"start_character":32,"end_line":81,"end_character":40},"in_reply_to":"deabba82_209b3633","updated":"2022-07-29 05:38:57.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":".. note::"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  The IdP has investigated with Keycloak. Whether there is a difference using another IdP requires additional investigation."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The following changes are required to support OIDC authentication:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"deabba82_209b3633","line":81,"range":{"start_line":81,"start_character":32,"end_line":81,"end_character":40},"in_reply_to":"e01a5cb4_4e3a69d6","updated":"2022-07-28 08:31:19.000000000","message":"I\u0027ve added the reference in PS4.","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3cfd8646038f2d91c36f14d969451b4634475ca3","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":".. note::"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  The IdP has investigated with Keycloak. Whether there is a difference using another IdP requires additional investigation."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The following changes are required to support OIDC authentication:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa660928_ccda08bc","line":81,"range":{"start_line":81,"start_character":77,"end_line":81,"end_character":78},"in_reply_to":"fa4b99c1_6dc95fc5","updated":"2022-07-28 12:30:54.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2816329f634c9c90b41af6e1a32631b1409937d9","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The following changes are required to support OIDC authentication:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"+ changes of VIM APIs"},{"line_number":87,"context_line":"+ changes of Kubernetes Infra Driver"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"1) Changes of VIM APIs"},{"line_number":90,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f83f84a9_c4d13b03","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":36},"updated":"2022-07-26 07:06:00.000000000","message":"Suggestion: This could be reframed as \"Changes in VIM APIs\" and \"Changes in Kubernetes Infra Driver\".","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"71e22a507bd80cd82d0f84b4240d3971a467bd64","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The following changes are required to support OIDC authentication:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"+ changes of VIM APIs"},{"line_number":87,"context_line":"+ changes of Kubernetes Infra Driver"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"1) Changes of VIM APIs"},{"line_number":90,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"2811fd43_49182faf","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":36},"in_reply_to":"243457ba_517255f5","updated":"2022-07-29 05:38:57.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The following changes are required to support OIDC authentication:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"+ changes of VIM APIs"},{"line_number":87,"context_line":"+ changes of Kubernetes Infra Driver"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"1) Changes of VIM APIs"},{"line_number":90,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"243457ba_517255f5","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":36},"in_reply_to":"f83f84a9_c4d13b03","updated":"2022-07-28 08:31:19.000000000","message":"I\u0027ve fixed the expression in PS4.","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2816329f634c9c90b41af6e1a32631b1409937d9","unresolved":true,"context_lines":[{"line_number":86,"context_line":"+ changes of VIM APIs"},{"line_number":87,"context_line":"+ changes of Kubernetes Infra Driver"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"1) Changes of VIM APIs"},{"line_number":90,"context_line":"----------------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"As mentioned above, Tacker\u0027s support for OIDC authentication requires"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c1888a98_beeb831d","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":22},"updated":"2022-07-26 07:06:00.000000000","message":"ditto","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"71e22a507bd80cd82d0f84b4240d3971a467bd64","unresolved":false,"context_lines":[{"line_number":86,"context_line":"+ changes of VIM APIs"},{"line_number":87,"context_line":"+ changes of Kubernetes Infra Driver"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"1) Changes of VIM APIs"},{"line_number":90,"context_line":"----------------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"As mentioned above, Tacker\u0027s support for OIDC authentication requires"}],"source_content_type":"text/x-rst","patch_set":3,"id":"243a699d_0888883f","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":22},"in_reply_to":"c13d97fc_378d917b","updated":"2022-07-29 05:38:57.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":86,"context_line":"+ changes of VIM APIs"},{"line_number":87,"context_line":"+ changes of Kubernetes Infra Driver"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"1) Changes of VIM APIs"},{"line_number":90,"context_line":"----------------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"As mentioned above, Tacker\u0027s support for OIDC authentication requires"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c13d97fc_378d917b","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":22},"in_reply_to":"c1888a98_beeb831d","updated":"2022-07-28 08:31:19.000000000","message":"ditto","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a91b343c29c2edba138ed57ac1b0694904a01b38","unresolved":true,"context_lines":[{"line_number":104,"context_line":"  + The client_id is a identifier of Tacker(OIDC client) at the IdP."},{"line_number":105,"context_line":"  + The username is a identifier of a user at the IdP."},{"line_number":106,"context_line":"  + The username will be included in id_token(A JSON Web Token)."},{"line_number":107,"context_line":"  + The username in id_token will be verified what permissions it has to Kubernetes when calling Kubernetes APIs."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The request parameters of Register VIM API [#register_vim_api]_"},{"line_number":110,"context_line":"should be set as below:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e7e9e576_464d28fc","line":107,"range":{"start_line":107,"start_character":72,"end_line":107,"end_character":73},"updated":"2022-07-21 05:57:00.000000000","message":"nit: ditto.","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3cfd8646038f2d91c36f14d969451b4634475ca3","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  + The client_id is a identifier of Tacker(OIDC client) at the IdP."},{"line_number":105,"context_line":"  + The username is a identifier of a user at the IdP."},{"line_number":106,"context_line":"  + The username will be included in id_token(A JSON Web Token)."},{"line_number":107,"context_line":"  + The username in id_token will be verified what permissions it has to Kubernetes when calling Kubernetes APIs."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The request parameters of Register VIM API [#register_vim_api]_"},{"line_number":110,"context_line":"should be set as below:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e815a12d_699749d3","line":107,"range":{"start_line":107,"start_character":72,"end_line":107,"end_character":73},"in_reply_to":"08b6630e_1206b203","updated":"2022-07-28 12:30:54.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":104,"context_line":"  + The client_id is a identifier of Tacker(OIDC client) at the IdP."},{"line_number":105,"context_line":"  + The username is a identifier of a user at the IdP."},{"line_number":106,"context_line":"  + The username will be included in id_token(A JSON Web Token)."},{"line_number":107,"context_line":"  + The username in id_token will be verified what permissions it has to Kubernetes when calling Kubernetes APIs."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The request parameters of Register VIM API [#register_vim_api]_"},{"line_number":110,"context_line":"should be set as below:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"08b6630e_1206b203","line":107,"range":{"start_line":107,"start_character":72,"end_line":107,"end_character":73},"in_reply_to":"e7e9e576_464d28fc","updated":"2022-07-28 08:31:19.000000000","message":"ditto","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a91b343c29c2edba138ed57ac1b0694904a01b38","unresolved":true,"context_lines":[{"line_number":182,"context_line":"    type: \"kubernetes\""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":".. Note::"},{"line_number":185,"context_line":"    The parameter ``auth_cred.ssl_ca_cert`` contains 2 certificates. One for VIM and one for IdP."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"2) Changes of Kubernetes Infra Driver"},{"line_number":188,"context_line":"-------------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"37a37ea5_fc7f31b6","line":185,"range":{"start_line":185,"start_character":76,"end_line":185,"end_character":77},"updated":"2022-07-21 05:57:00.000000000","message":"nit: Could you break the line here?","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":182,"context_line":"    type: \"kubernetes\""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":".. Note::"},{"line_number":185,"context_line":"    The parameter ``auth_cred.ssl_ca_cert`` contains 2 certificates. One for VIM and one for IdP."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"2) Changes of Kubernetes Infra Driver"},{"line_number":188,"context_line":"-------------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6c52d04a_47e346bb","line":185,"range":{"start_line":185,"start_character":76,"end_line":185,"end_character":77},"in_reply_to":"37a37ea5_fc7f31b6","updated":"2022-07-28 08:31:19.000000000","message":"ditto","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3cfd8646038f2d91c36f14d969451b4634475ca3","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    type: \"kubernetes\""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":".. Note::"},{"line_number":185,"context_line":"    The parameter ``auth_cred.ssl_ca_cert`` contains 2 certificates. One for VIM and one for IdP."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"2) Changes of Kubernetes Infra Driver"},{"line_number":188,"context_line":"-------------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"de92f8d0_cd1cbb89","line":185,"range":{"start_line":185,"start_character":76,"end_line":185,"end_character":77},"in_reply_to":"6c52d04a_47e346bb","updated":"2022-07-28 12:30:54.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2816329f634c9c90b41af6e1a32631b1409937d9","unresolved":true,"context_lines":[{"line_number":184,"context_line":".. Note::"},{"line_number":185,"context_line":"    The parameter ``auth_cred.ssl_ca_cert`` contains 2 certificates. One for VIM and one for IdP."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"2) Changes of Kubernetes Infra Driver"},{"line_number":188,"context_line":"-------------------------------------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"The flow of calling the Kubernetes APIs is shown as below"}],"source_content_type":"text/x-rst","patch_set":3,"id":"358c9829_1e384d15","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":37},"updated":"2022-07-26 07:06:00.000000000","message":"Suggestion: This could be reframed as \"Changes in Kubernetes Infra Driver\".","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":184,"context_line":".. Note::"},{"line_number":185,"context_line":"    The parameter ``auth_cred.ssl_ca_cert`` contains 2 certificates. One for VIM and one for IdP."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"2) Changes of Kubernetes Infra Driver"},{"line_number":188,"context_line":"-------------------------------------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"The flow of calling the Kubernetes APIs is shown as below"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dc34955b_dc6846f2","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":37},"in_reply_to":"358c9829_1e384d15","updated":"2022-07-28 08:31:19.000000000","message":"ditto","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"71e22a507bd80cd82d0f84b4240d3971a467bd64","unresolved":false,"context_lines":[{"line_number":184,"context_line":".. Note::"},{"line_number":185,"context_line":"    The parameter ``auth_cred.ssl_ca_cert`` contains 2 certificates. One for VIM and one for IdP."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"2) Changes of Kubernetes Infra Driver"},{"line_number":188,"context_line":"-------------------------------------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"The flow of calling the Kubernetes APIs is shown as below"}],"source_content_type":"text/x-rst","patch_set":3,"id":"66686896_7e58725c","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":37},"in_reply_to":"dc34955b_dc6846f2","updated":"2022-07-29 05:38:57.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a91b343c29c2edba138ed57ac1b0694904a01b38","unresolved":true,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"#. The Client sends a request to Tacker-server to instantiate a vnf."},{"line_number":230,"context_line":"#. Tacker-server gets the ``vimAuth`` from TakerDB, and calls"},{"line_number":231,"context_line":"   the instantiate rpc-api of Tacker-conductor."},{"line_number":232,"context_line":"#. Tacker-conductor calls the instantiate_vnf method of VnfLcmDriver."},{"line_number":233,"context_line":"#. VnfLcmDriver calls the instantiate_vnf of InfraDriver(Kubernetes)."}],"source_content_type":"text/x-rst","patch_set":3,"id":"6d834576_934f047f","line":230,"range":{"start_line":230,"start_character":43,"end_line":230,"end_character":50},"updated":"2022-07-21 05:57:00.000000000","message":"typo: TackerDB","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"#. The Client sends a request to Tacker-server to instantiate a vnf."},{"line_number":230,"context_line":"#. Tacker-server gets the ``vimAuth`` from TakerDB, and calls"},{"line_number":231,"context_line":"   the instantiate rpc-api of Tacker-conductor."},{"line_number":232,"context_line":"#. Tacker-conductor calls the instantiate_vnf method of VnfLcmDriver."},{"line_number":233,"context_line":"#. VnfLcmDriver calls the instantiate_vnf of InfraDriver(Kubernetes)."}],"source_content_type":"text/x-rst","patch_set":3,"id":"c4f31a64_b94e86cc","line":230,"range":{"start_line":230,"start_character":43,"end_line":230,"end_character":50},"in_reply_to":"6d834576_934f047f","updated":"2022-07-28 08:31:19.000000000","message":"I\u0027ve fixed the typo in PS4.","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3cfd8646038f2d91c36f14d969451b4634475ca3","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"#. The Client sends a request to Tacker-server to instantiate a vnf."},{"line_number":230,"context_line":"#. Tacker-server gets the ``vimAuth`` from TakerDB, and calls"},{"line_number":231,"context_line":"   the instantiate rpc-api of Tacker-conductor."},{"line_number":232,"context_line":"#. Tacker-conductor calls the instantiate_vnf method of VnfLcmDriver."},{"line_number":233,"context_line":"#. VnfLcmDriver calls the instantiate_vnf of InfraDriver(Kubernetes)."}],"source_content_type":"text/x-rst","patch_set":3,"id":"87339bc9_57f8c1a8","line":230,"range":{"start_line":230,"start_character":43,"end_line":230,"end_character":50},"in_reply_to":"c4f31a64_b94e86cc","updated":"2022-07-28 12:30:54.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a91b343c29c2edba138ed57ac1b0694904a01b38","unresolved":true,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":".. Note::"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"  Each LCM operation(instantiate, terminate, etc) will get a individual token from IdP,"},{"line_number":241,"context_line":"  and the token will be used in all API calls to the Kubernetes VIM in one LCM processing."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Get token from IdP"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a14a105_37daa7bc","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":90},"updated":"2022-07-21 05:57:00.000000000","message":"nit: How about you change the position of the line break?\n\n```\n  Each LCM operation(instantiate, terminate, etc) will get a individual token\n  from IdP, and the token will be used in all API calls to the Kubernetes VIM\n  in one LCM processing.\n```","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":".. Note::"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"  Each LCM operation(instantiate, terminate, etc) will get a individual token from IdP,"},{"line_number":241,"context_line":"  and the token will be used in all API calls to the Kubernetes VIM in one LCM processing."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Get token from IdP"}],"source_content_type":"text/x-rst","patch_set":3,"id":"619c4d28_77801596","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":90},"in_reply_to":"3a14a105_37daa7bc","updated":"2022-07-28 08:31:19.000000000","message":"I\u0027ve changed the line break in PS4","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3cfd8646038f2d91c36f14d969451b4634475ca3","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":".. Note::"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"  Each LCM operation(instantiate, terminate, etc) will get a individual token from IdP,"},{"line_number":241,"context_line":"  and the token will be used in all API calls to the Kubernetes VIM in one LCM processing."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Get token from IdP"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f375bbf8_94d86084","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":90},"in_reply_to":"619c4d28_77801596","updated":"2022-07-28 12:30:54.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a91b343c29c2edba138ed57ac1b0694904a01b38","unresolved":true,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":".. code-block::"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"  curl --cacert cacert.crt -d \"grant_type\u003dpassword\" -d \"scope\u003dopenid\" -d \"client_id\u003dkubernetes\" -d \"client_secret\u003dE3xaNpB8reiUuEyrD8y6wQ1obPJAtbbU\" -d \"username\u003dtacker\" -d \"password\u003dtacker\" https://keycloakserver:8443/realms/kubenetes/protocol/openid-connect/token"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0e26a35a_d512f6eb","line":262,"range":{"start_line":262,"start_character":2,"end_line":262,"end_character":264},"updated":"2022-07-21 05:57:00.000000000","message":"nit: How about you use backslash to make it easier to read?\n```\ncurl --cacert cacert.crt -d \"grant_type\u003dpassword\" -d \"scope\u003dopenid\" \\\n  -d  \"client_id\u003dkubernetes\" -d \"client_secret\u003dE3xaNpB8reiUuEyrD8y6wQ1obPJAtbbU\" \\\n  -d \"username\u003dtacker\" -d \"password\u003dtacker\" \\\n  https://keycloakserver:8443/realms/kubenetes/protocol/openid-connect/token\n```","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3cfd8646038f2d91c36f14d969451b4634475ca3","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":".. code-block::"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"  curl --cacert cacert.crt -d \"grant_type\u003dpassword\" -d \"scope\u003dopenid\" -d \"client_id\u003dkubernetes\" -d \"client_secret\u003dE3xaNpB8reiUuEyrD8y6wQ1obPJAtbbU\" -d \"username\u003dtacker\" -d \"password\u003dtacker\" https://keycloakserver:8443/realms/kubenetes/protocol/openid-connect/token"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"69f14fa2_606e77d2","line":262,"range":{"start_line":262,"start_character":2,"end_line":262,"end_character":264},"in_reply_to":"0dcfb7d8_a169e94b","updated":"2022-07-28 12:30:54.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":".. code-block::"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"  curl --cacert cacert.crt -d \"grant_type\u003dpassword\" -d \"scope\u003dopenid\" -d \"client_id\u003dkubernetes\" -d \"client_secret\u003dE3xaNpB8reiUuEyrD8y6wQ1obPJAtbbU\" -d \"username\u003dtacker\" -d \"password\u003dtacker\" https://keycloakserver:8443/realms/kubenetes/protocol/openid-connect/token"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0dcfb7d8_a169e94b","line":262,"range":{"start_line":262,"start_character":2,"end_line":262,"end_character":264},"in_reply_to":"0e26a35a_d512f6eb","updated":"2022-07-28 08:31:19.000000000","message":"I\u0027ve fixed it in PS4.","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2816329f634c9c90b41af6e1a32631b1409937d9","unresolved":true,"context_lines":[{"line_number":270,"context_line":"Data model impact"},{"line_number":271,"context_line":"-----------------"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"As mentioned above, OIDC authenticate requires the client_id, client_secret,"},{"line_number":274,"context_line":"username, password, token_url, ssl_ca_cert."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"The following fields will not change:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"65f22d24_2362b313","line":273,"range":{"start_line":273,"start_character":25,"end_line":273,"end_character":37},"updated":"2022-07-26 07:06:00.000000000","message":"Please replace to \"authentication\" for more consistent statement.","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":270,"context_line":"Data model impact"},{"line_number":271,"context_line":"-----------------"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"As mentioned above, OIDC authenticate requires the client_id, client_secret,"},{"line_number":274,"context_line":"username, password, token_url, ssl_ca_cert."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"The following fields will not change:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"72b6c831_90c4c15e","line":273,"range":{"start_line":273,"start_character":25,"end_line":273,"end_character":37},"in_reply_to":"65f22d24_2362b313","updated":"2022-07-28 08:31:19.000000000","message":"ditto","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"71e22a507bd80cd82d0f84b4240d3971a467bd64","unresolved":false,"context_lines":[{"line_number":270,"context_line":"Data model impact"},{"line_number":271,"context_line":"-----------------"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"As mentioned above, OIDC authenticate requires the client_id, client_secret,"},{"line_number":274,"context_line":"username, password, token_url, ssl_ca_cert."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"The following fields will not change:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5941406d_d18811ae","line":273,"range":{"start_line":273,"start_character":25,"end_line":273,"end_character":37},"in_reply_to":"72b6c831_90c4c15e","updated":"2022-07-29 05:38:57.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a91b343c29c2edba138ed57ac1b0694904a01b38","unresolved":true,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":".. note::"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"   For security, client_secret may also need to be encrypted with fernet the same as password."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6990f5c8_211c767e","line":294,"range":{"start_line":294,"start_character":76,"end_line":294,"end_character":77},"updated":"2022-07-21 05:57:00.000000000","message":"nit: Could you break the line here?","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"565c4dae92f483faae019fd3faa3f64376e5de4c","unresolved":true,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":".. note::"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"   For security, client_secret may also need to be encrypted with fernet the same as password."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"eeb96b05_cdf22ef7","line":294,"range":{"start_line":294,"start_character":76,"end_line":294,"end_character":77},"in_reply_to":"6990f5c8_211c767e","updated":"2022-07-28 08:31:19.000000000","message":"I\u0027ve fixed it in PS4.","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3cfd8646038f2d91c36f14d969451b4634475ca3","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":".. note::"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"   For security, client_secret may also need to be encrypted with fernet the same as password."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0c394d1d_adc7afcd","line":294,"range":{"start_line":294,"start_character":76,"end_line":294,"end_character":77},"in_reply_to":"eeb96b05_cdf22ef7","updated":"2022-07-28 12:30:54.000000000","message":"Ack","commit_id":"3c4308901a7a0652edce8bc6434e73f109c8830b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3cfd8646038f2d91c36f14d969451b4634475ca3","unresolved":true,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"#. Register VIM using command or API."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  This step is only required for V1 LCM operations."},{"line_number":65,"context_line":"  In V2 LCM operations, authentication parameters can be passed by"},{"line_number":66,"context_line":"  VimConnectionInfo in each LCM requests, thus this step is no longer"},{"line_number":67,"context_line":"  required."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"#. Call the create vim method of class NFVOPlugin."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"#. Store the client_id, client_secret, username, password, token_url,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"26d4048f_f90bf7a2","line":68,"range":{"start_line":62,"start_character":0,"end_line":68,"end_character":0},"updated":"2022-07-28 12:30:54.000000000","message":"nit: How about indenting this note to right?","commit_id":"cc6716bd322f35edc595872b11997a7db851be68"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ffcbf58a61ba1823391981a5eea40b5c2d52e4e6","unresolved":true,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"#. Register VIM using command or API."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  This step is only required for V1 LCM operations."},{"line_number":65,"context_line":"  In V2 LCM operations, authentication parameters can be passed by"},{"line_number":66,"context_line":"  VimConnectionInfo in each LCM requests, thus this step is no longer"},{"line_number":67,"context_line":"  required."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"#. Call the create vim method of class NFVOPlugin."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"#. Store the client_id, client_secret, username, password, token_url,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"8716710c_6abade4a","line":68,"range":{"start_line":62,"start_character":0,"end_line":68,"end_character":0},"in_reply_to":"26d4048f_f90bf7a2","updated":"2022-07-29 04:37:05.000000000","message":"Thanks. As Yasufumi mentioned his comment[1], this should be described as a single topic because of its importance. I\u0027ve removed note-block, and replaced it with bullet list in PS5.\n\n[1] https://review.opendev.org/c/openstack/tacker-specs/+/850437/comments/1605c5ff_3350ce91","commit_id":"cc6716bd322f35edc595872b11997a7db851be68"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"db5af986450c3e15687807b5732d180f3e44db8d","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"#. Register VIM using command or API."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  This step is only required for V1 LCM operations."},{"line_number":65,"context_line":"  In V2 LCM operations, authentication parameters can be passed by"},{"line_number":66,"context_line":"  VimConnectionInfo in each LCM requests, thus this step is no longer"},{"line_number":67,"context_line":"  required."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"#. Call the create vim method of class NFVOPlugin."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"#. Store the client_id, client_secret, username, password, token_url,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fcb7a92_5ba418e2","line":68,"range":{"start_line":62,"start_character":0,"end_line":68,"end_character":0},"in_reply_to":"8716710c_6abade4a","updated":"2022-07-29 05:20:03.000000000","message":"Ack","commit_id":"cc6716bd322f35edc595872b11997a7db851be68"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bf2780ec53fd6ea8ad920e4c91630296c1800356","unresolved":true,"context_lines":[{"line_number":57,"context_line":"#. Configure the Kubernetes API server to enable the OpenID Connect(OIDC)"},{"line_number":58,"context_line":"   plugin."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"#. Register VIM using command or API."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  This step is only required for V1 LCM operations."},{"line_number":65,"context_line":"  In V2 LCM operations, authentication parameters can be passed by"},{"line_number":66,"context_line":"  VimConnectionInfo in each LCM requests, thus this step is no longer"},{"line_number":67,"context_line":"  required."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"#. Call the create vim method of class NFVOPlugin."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"#. Store the client_id, client_secret, username, password, token_url,"},{"line_number":72,"context_line":"   ssl_ca_cert to TackerDB."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1605c5ff_3350ce91","line":69,"range":{"start_line":60,"start_character":0,"end_line":69,"end_character":50},"updated":"2022-07-29 00:28:28.000000000","message":"Count of items is cleared at the 4th one for the inserted note on compiled doc. IMO, it\u0027s better to use note block only for topic really described as a note. It\u0027s enough this explanation is added to the statement before without using note block.","commit_id":"cc6716bd322f35edc595872b11997a7db851be68"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ffcbf58a61ba1823391981a5eea40b5c2d52e4e6","unresolved":true,"context_lines":[{"line_number":57,"context_line":"#. Configure the Kubernetes API server to enable the OpenID Connect(OIDC)"},{"line_number":58,"context_line":"   plugin."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"#. Register VIM using command or API."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  This step is only required for V1 LCM operations."},{"line_number":65,"context_line":"  In V2 LCM operations, authentication parameters can be passed by"},{"line_number":66,"context_line":"  VimConnectionInfo in each LCM requests, thus this step is no longer"},{"line_number":67,"context_line":"  required."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"#. Call the create vim method of class NFVOPlugin."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"#. Store the client_id, client_secret, username, password, token_url,"},{"line_number":72,"context_line":"   ssl_ca_cert to TackerDB."}],"source_content_type":"text/x-rst","patch_set":4,"id":"01c1a368_89a2aaf2","line":69,"range":{"start_line":60,"start_character":0,"end_line":69,"end_character":50},"in_reply_to":"1605c5ff_3350ce91","updated":"2022-07-29 04:37:05.000000000","message":"Thanks. I\u0027ve replaced it with bullet list in PS5.","commit_id":"cc6716bd322f35edc595872b11997a7db851be68"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3cfd8646038f2d91c36f14d969451b4634475ca3","unresolved":true,"context_lines":[{"line_number":237,"context_line":"    },"},{"line_number":238,"context_line":"    \"vimConnectionInfo\": {"},{"line_number":239,"context_line":"      \"vim1\": {"},{"line_number":240,"context_line":"        \"id\": \"8a3adb69-0784-43c7-833e-aab0b6ab4470\","},{"line_number":241,"context_line":"        \"vimType\": \"kubernetes\","},{"line_number":242,"context_line":"        \"accessInfo\": {"},{"line_number":243,"context_line":"          \"oidc_token_url\": \"https://keycloak.example.com:8443/realms/sample-realm/protocol/openid-connect/token\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"b5613e60_139f6fef","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":53},"updated":"2022-07-28 12:30:54.000000000","message":"In the V2 API (SOL003v 3.3.1), isn\u0027t \"id\" unnecessary for VimConnectionInfo?","commit_id":"cc6716bd322f35edc595872b11997a7db851be68"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"db5af986450c3e15687807b5732d180f3e44db8d","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    },"},{"line_number":238,"context_line":"    \"vimConnectionInfo\": {"},{"line_number":239,"context_line":"      \"vim1\": {"},{"line_number":240,"context_line":"        \"id\": \"8a3adb69-0784-43c7-833e-aab0b6ab4470\","},{"line_number":241,"context_line":"        \"vimType\": \"kubernetes\","},{"line_number":242,"context_line":"        \"accessInfo\": {"},{"line_number":243,"context_line":"          \"oidc_token_url\": \"https://keycloak.example.com:8443/realms/sample-realm/protocol/openid-connect/token\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"f7dd0cd1_21480211","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":53},"in_reply_to":"8f4f01a2_52a96462","updated":"2022-07-29 05:20:03.000000000","message":"Ack","commit_id":"cc6716bd322f35edc595872b11997a7db851be68"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ffcbf58a61ba1823391981a5eea40b5c2d52e4e6","unresolved":true,"context_lines":[{"line_number":237,"context_line":"    },"},{"line_number":238,"context_line":"    \"vimConnectionInfo\": {"},{"line_number":239,"context_line":"      \"vim1\": {"},{"line_number":240,"context_line":"        \"id\": \"8a3adb69-0784-43c7-833e-aab0b6ab4470\","},{"line_number":241,"context_line":"        \"vimType\": \"kubernetes\","},{"line_number":242,"context_line":"        \"accessInfo\": {"},{"line_number":243,"context_line":"          \"oidc_token_url\": \"https://keycloak.example.com:8443/realms/sample-realm/protocol/openid-connect/token\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"8f4f01a2_52a96462","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":53},"in_reply_to":"b5613e60_139f6fef","updated":"2022-07-29 04:37:05.000000000","message":"Oops, I forgot removing the field. It is omitted in PS5.","commit_id":"cc6716bd322f35edc595872b11997a7db851be68"}]}