)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"4e2fbb1185bfc6d0a527538c9faea786c83b322e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f2631a8f_3aaaffec","updated":"2022-12-22 08:45:43.000000000","message":"Please kindly review this spec.","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"ce60d3202b1ec45d7890d4fbe588e1bc98fd216c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b7639dd0_b3208077","updated":"2022-12-26 08:48:22.000000000","message":"Thank you for the proposal!","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"49103be1dce41403b84c15fba1f102f24fafdc59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"62e6ba0a_d9ba2501","updated":"2022-12-26 03:36:35.000000000","message":"Thank you for your comments.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"5da5831e1a3bc185d1e0b33ba78acddf2c976bd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa14d506_ed40da61","updated":"2022-12-26 06:08:20.000000000","message":"Thanks for your patch. Please find few comments.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"21843df7ccda529e196e7f650e90a9b6b12d1dbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f14ecab2_8584756c","updated":"2022-12-27 00:55:46.000000000","message":"Sorry for the late review, please kindly find my comments.","commit_id":"2047fde40776a61860aff520d14840de13bae5ac"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"566398c3b62f9b417ab97c45fe7522cf2df0215f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"09a61a07_49105aa3","updated":"2022-12-26 11:07:10.000000000","message":"Thank you for your comments.","commit_id":"2047fde40776a61860aff520d14840de13bae5ac"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d3bd93d073cde31e7dc0a06605f53e097ef4b608","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6329c401_2e5e360f","updated":"2022-12-26 10:59:09.000000000","message":"Thank you for your comments.","commit_id":"2047fde40776a61860aff520d14840de13bae5ac"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"855720aedb613c800ead6335d278ef9b0e47d681","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"504d0843_edc1d428","updated":"2022-12-27 04:28:37.000000000","message":"Thank you for your comments","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"f597e10bae2a827a2d91cba4add53c372f302da3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"16376c1b_6d19027a","updated":"2022-12-27 08:59:03.000000000","message":"Thank you reply!","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1f18757f93369cdbe2e7e4a1029c513279468412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"436025b5_c13595bd","updated":"2022-12-28 02:09:03.000000000","message":"Thanks for rework.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0613943ee2712f48667101b56f478215258a32cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9e47ba17_e38c06a1","updated":"2022-12-28 02:03:35.000000000","message":"Thanks for your rework! LGTM.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"22f5844a3692388b91ca411da420ac97a795da2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4ce41fde_638fc1f9","updated":"2022-12-27 04:32:45.000000000","message":"Thanks, I have no additional comments.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"e9080a2c9dad749948e4a8ba050bdbf0c7732b4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dae6f83f_377bb4f1","updated":"2022-12-28 07:04:54.000000000","message":"Thank you for your comments.","commit_id":"94ad32885b26ca7ff2b0dbf4dd9188092642b14f"}],"specs/2023.1/improving-mgmt-driver-log.rst":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"0f6b6cb548230e12ea75c8215f6312fac08f6103","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Improve Mgmt Driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/tacker/+spec/improving-mgmt-driver-log"}],"source_content_type":"text/x-rst","patch_set":2,"id":"49fec4f2_3870ffb0","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":19},"updated":"2022-12-22 18:38:05.000000000","message":"It would be better to put \"Improvement of error message\" in the title.","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"21843df7ccda529e196e7f650e90a9b6b12d1dbd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Improve Mgmt Driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/tacker/+spec/improving-mgmt-driver-log"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c20882ed_ab00a526","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":19},"in_reply_to":"057d7623_21e8d85a","updated":"2022-12-27 00:55:46.000000000","message":"I think it would be better to clarify that it is the error log of MgmtDriver.\nWhat do you think?","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"49103be1dce41403b84c15fba1f102f24fafdc59","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Improve Mgmt Driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/tacker/+spec/improving-mgmt-driver-log"}],"source_content_type":"text/x-rst","patch_set":2,"id":"057d7623_21e8d85a","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":19},"in_reply_to":"49fec4f2_3870ffb0","updated":"2022-12-26 03:36:35.000000000","message":"I fixed it.","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"855720aedb613c800ead6335d278ef9b0e47d681","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Improve Mgmt Driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/tacker/+spec/improving-mgmt-driver-log"}],"source_content_type":"text/x-rst","patch_set":2,"id":"881bad70_66b757d3","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":19},"in_reply_to":"c20882ed_ab00a526","updated":"2022-12-27 04:28:37.000000000","message":"To: Takahashi-san\nSorry, I said this was fixed in Patchset 2 but couldn\u0027t.\n\nConsidering Takahashi-san and Ueha-san\u0027s opinion,\nI fixed it as \"Improvement of Error Message of Mgmt Driver\".","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"22f5844a3692388b91ca411da420ac97a795da2b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Improve Mgmt Driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/tacker/+spec/improving-mgmt-driver-log"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d642b811_837a93ad","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":19},"in_reply_to":"c20882ed_ab00a526","updated":"2022-12-27 04:32:45.000000000","message":"confirmed","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0613943ee2712f48667101b56f478215258a32cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Improve Mgmt Driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/tacker/+spec/improving-mgmt-driver-log"}],"source_content_type":"text/x-rst","patch_set":2,"id":"23aa1f3b_79922e50","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":19},"in_reply_to":"d642b811_837a93ad","updated":"2022-12-28 02:03:35.000000000","message":"Ack","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"0f6b6cb548230e12ea75c8215f6312fac08f6103","unresolved":true,"context_lines":[{"line_number":45,"context_line":"and users can only check this message by CLI \"vnflcm op show\"."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The ``tacker-conductor.log`` includes more information about the error."},{"line_number":48,"context_line":"But in general, an administrator of Tacker only has the authority"},{"line_number":49,"context_line":"to access the log, and so there is no way for users to debug the error."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Therefore, it is necessary to improve the error users see through CLI command."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a84d1a1_84f5558e","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":65},"updated":"2022-12-22 18:38:05.000000000","message":"Does it mean that non administrator users do not have the autority?\nIf so, \"only an administrator has the authority\" would be better.","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"49103be1dce41403b84c15fba1f102f24fafdc59","unresolved":true,"context_lines":[{"line_number":45,"context_line":"and users can only check this message by CLI \"vnflcm op show\"."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The ``tacker-conductor.log`` includes more information about the error."},{"line_number":48,"context_line":"But in general, an administrator of Tacker only has the authority"},{"line_number":49,"context_line":"to access the log, and so there is no way for users to debug the error."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Therefore, it is necessary to improve the error users see through CLI command."}],"source_content_type":"text/x-rst","patch_set":2,"id":"a9c433f5_1ad5c26f","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":65},"in_reply_to":"3a84d1a1_84f5558e","updated":"2022-12-26 03:36:35.000000000","message":"Your understanding is right.\nI fixed it.","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"22f5844a3692388b91ca411da420ac97a795da2b","unresolved":true,"context_lines":[{"line_number":45,"context_line":"and users can only check this message by CLI \"vnflcm op show\"."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The ``tacker-conductor.log`` includes more information about the error."},{"line_number":48,"context_line":"But in general, an administrator of Tacker only has the authority"},{"line_number":49,"context_line":"to access the log, and so there is no way for users to debug the error."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Therefore, it is necessary to improve the error users see through CLI command."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1112db8c_156dc8b8","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":65},"in_reply_to":"a9c433f5_1ad5c26f","updated":"2022-12-27 04:32:45.000000000","message":"confirmed","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"21843df7ccda529e196e7f650e90a9b6b12d1dbd","unresolved":true,"context_lines":[{"line_number":171,"context_line":"Primary assignee:"},{"line_number":172,"context_line":"  Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":173,"context_line":"Other contributors:"},{"line_number":174,"context_line":"  Yukihiro Kinjo \u003cyu-kinjou@kddi.com\u003e"},{"line_number":175,"context_line":"  Xu Hongjin \u003cho-xu@kddi.com\u003e"},{"line_number":176,"context_line":"  Hitomi Koba \u003chi-koba@kddi.com\u003e"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Work Items"},{"line_number":179,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"787f73ec_8464c633","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":32},"updated":"2022-12-27 00:55:46.000000000","message":"Could you insert a blank line between each contributor?","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0613943ee2712f48667101b56f478215258a32cf","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Primary assignee:"},{"line_number":172,"context_line":"  Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":173,"context_line":"Other contributors:"},{"line_number":174,"context_line":"  Yukihiro Kinjo \u003cyu-kinjou@kddi.com\u003e"},{"line_number":175,"context_line":"  Xu Hongjin \u003cho-xu@kddi.com\u003e"},{"line_number":176,"context_line":"  Hitomi Koba \u003chi-koba@kddi.com\u003e"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Work Items"},{"line_number":179,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0c271aba_11a2d88f","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":32},"in_reply_to":"4c07c546_f53544d1","updated":"2022-12-28 02:03:35.000000000","message":"Ack","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"855720aedb613c800ead6335d278ef9b0e47d681","unresolved":true,"context_lines":[{"line_number":171,"context_line":"Primary assignee:"},{"line_number":172,"context_line":"  Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":173,"context_line":"Other contributors:"},{"line_number":174,"context_line":"  Yukihiro Kinjo \u003cyu-kinjou@kddi.com\u003e"},{"line_number":175,"context_line":"  Xu Hongjin \u003cho-xu@kddi.com\u003e"},{"line_number":176,"context_line":"  Hitomi Koba \u003chi-koba@kddi.com\u003e"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Work Items"},{"line_number":179,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4c07c546_f53544d1","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":32},"in_reply_to":"787f73ec_8464c633","updated":"2022-12-27 04:28:37.000000000","message":"I fixed it.","commit_id":"5daea4ab9e247f0b2f855bc34f709df098813ced"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"5da5831e1a3bc185d1e0b33ba78acddf2c976bd1","unresolved":true,"context_lines":[{"line_number":62,"context_line":"between Tacker-conductor and Mgmt Driver."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- The exception raised from Mgmt Driver must conform to the format"},{"line_number":65,"context_line":"  of ``ProblemDetails`` defined in ETSI GS NFV-SOL 013 specification."},{"line_number":66,"context_line":"- Tacker-conductor must be able to catch the type of exception."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":".. note:: For backward compatibility reasons, exceptions of any type"}],"source_content_type":"text/x-rst","patch_set":3,"id":"27d63d25_9153e103","line":65,"range":{"start_line":65,"start_character":35,"end_line":65,"end_character":54},"updated":"2022-12-26 06:08:20.000000000","message":"Please add reference link.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1f18757f93369cdbe2e7e4a1029c513279468412","unresolved":false,"context_lines":[{"line_number":62,"context_line":"between Tacker-conductor and Mgmt Driver."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- The exception raised from Mgmt Driver must conform to the format"},{"line_number":65,"context_line":"  of ``ProblemDetails`` defined in ETSI GS NFV-SOL 013 specification."},{"line_number":66,"context_line":"- Tacker-conductor must be able to catch the type of exception."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":".. note:: For backward compatibility reasons, exceptions of any type"}],"source_content_type":"text/x-rst","patch_set":3,"id":"b1c2ebbd_a262709e","line":65,"range":{"start_line":65,"start_character":35,"end_line":65,"end_character":54},"in_reply_to":"0b4cef0c_5a877b46","updated":"2022-12-28 02:09:03.000000000","message":"Ack","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d3bd93d073cde31e7dc0a06605f53e097ef4b608","unresolved":true,"context_lines":[{"line_number":62,"context_line":"between Tacker-conductor and Mgmt Driver."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- The exception raised from Mgmt Driver must conform to the format"},{"line_number":65,"context_line":"  of ``ProblemDetails`` defined in ETSI GS NFV-SOL 013 specification."},{"line_number":66,"context_line":"- Tacker-conductor must be able to catch the type of exception."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":".. note:: For backward compatibility reasons, exceptions of any type"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0b4cef0c_5a877b46","line":65,"range":{"start_line":65,"start_character":35,"end_line":65,"end_character":54},"in_reply_to":"27d63d25_9153e103","updated":"2022-12-26 10:59:09.000000000","message":"I added the link.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"5da5831e1a3bc185d1e0b33ba78acddf2c976bd1","unresolved":true,"context_lines":[{"line_number":75,"context_line":".. csv-table::  Table 6.3-1: Definition of the ``ProblemDetails`` data type [#ETSI-GS-NFV-SOL013-v2.6.1]_"},{"line_number":76,"context_line":"    :header: Attribute name, Data type, Cardinality, Description"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    type,Uri,0..1, \"A URI reference according to IETF RFC 3986 that identifies"},{"line_number":79,"context_line":"    the problem type. It is encouraged that the URI provides"},{"line_number":80,"context_line":"    human-readable documentation for the problem (e.g. using"},{"line_number":81,"context_line":"    HTML) when dereferenced. When this member is not present,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"19d4c52a_b68e346f","line":78,"range":{"start_line":78,"start_character":49,"end_line":78,"end_character":62},"updated":"2022-12-26 06:08:20.000000000","message":"Please add reference link.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d3bd93d073cde31e7dc0a06605f53e097ef4b608","unresolved":true,"context_lines":[{"line_number":75,"context_line":".. csv-table::  Table 6.3-1: Definition of the ``ProblemDetails`` data type [#ETSI-GS-NFV-SOL013-v2.6.1]_"},{"line_number":76,"context_line":"    :header: Attribute name, Data type, Cardinality, Description"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    type,Uri,0..1, \"A URI reference according to IETF RFC 3986 that identifies"},{"line_number":79,"context_line":"    the problem type. It is encouraged that the URI provides"},{"line_number":80,"context_line":"    human-readable documentation for the problem (e.g. using"},{"line_number":81,"context_line":"    HTML) when dereferenced. When this member is not present,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"70030762_f1744469","line":78,"range":{"start_line":78,"start_character":49,"end_line":78,"end_character":62},"in_reply_to":"19d4c52a_b68e346f","updated":"2022-12-26 10:59:09.000000000","message":"Added the link.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1f18757f93369cdbe2e7e4a1029c513279468412","unresolved":false,"context_lines":[{"line_number":75,"context_line":".. csv-table::  Table 6.3-1: Definition of the ``ProblemDetails`` data type [#ETSI-GS-NFV-SOL013-v2.6.1]_"},{"line_number":76,"context_line":"    :header: Attribute name, Data type, Cardinality, Description"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    type,Uri,0..1, \"A URI reference according to IETF RFC 3986 that identifies"},{"line_number":79,"context_line":"    the problem type. It is encouraged that the URI provides"},{"line_number":80,"context_line":"    human-readable documentation for the problem (e.g. using"},{"line_number":81,"context_line":"    HTML) when dereferenced. When this member is not present,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a472ef9_87caa36e","line":78,"range":{"start_line":78,"start_character":49,"end_line":78,"end_character":62},"in_reply_to":"70030762_f1744469","updated":"2022-12-28 02:09:03.000000000","message":"Ack","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"ce60d3202b1ec45d7890d4fbe588e1bc98fd216c","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    (additional attributes),Not specified.,0..N, \"Any number of additional"},{"line_number":95,"context_line":"    attributes, as defined in a specification or by an implementation.\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"To implement this rule, there should be the base exception class"},{"line_number":98,"context_line":"complied with ``ProblemDetails`` in Tacker side."},{"line_number":99,"context_line":"And developers of Mgmt Driver use it to make exceptions in their Mgmt Driver"},{"line_number":100,"context_line":"compatible with ``ProblemDetails``."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"a22cda00_b41e409b","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":48},"updated":"2022-12-26 08:48:22.000000000","message":"ProblemDetails is saved with an error String passed as argument in _send_lcm_op_occ_notification function.\nThis action is the same for the Infra Driver as well as the Mgmt Driver.\nIf we use MgmtDriverException, how do we pass the data to _send_lcm_op_occ_notification?","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"f597e10bae2a827a2d91cba4add53c372f302da3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    (additional attributes),Not specified.,0..N, \"Any number of additional"},{"line_number":95,"context_line":"    attributes, as defined in a specification or by an implementation.\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"To implement this rule, there should be the base exception class"},{"line_number":98,"context_line":"complied with ``ProblemDetails`` in Tacker side."},{"line_number":99,"context_line":"And developers of Mgmt Driver use it to make exceptions in their Mgmt Driver"},{"line_number":100,"context_line":"compatible with ``ProblemDetails``."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"4464d3df_d2da178e","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":48},"in_reply_to":"0aa93e06_c9adfc9b","updated":"2022-12-27 08:59:03.000000000","message":"I understood your plan.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"566398c3b62f9b417ab97c45fe7522cf2df0215f","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    (additional attributes),Not specified.,0..N, \"Any number of additional"},{"line_number":95,"context_line":"    attributes, as defined in a specification or by an implementation.\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"To implement this rule, there should be the base exception class"},{"line_number":98,"context_line":"complied with ``ProblemDetails`` in Tacker side."},{"line_number":99,"context_line":"And developers of Mgmt Driver use it to make exceptions in their Mgmt Driver"},{"line_number":100,"context_line":"compatible with ``ProblemDetails``."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"0aa93e06_c9adfc9b","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":48},"in_reply_to":"a22cda00_b41e409b","updated":"2022-12-26 11:07:10.000000000","message":"Any error is passed to the _send_lcm_op_occ_notification function as it is.\nThen, type of the error is checked in the function.\nIf the type is not ProblemDetails, the error is stored as same as current implementation.\nSo we need to implement such a process in the _send_lcm_op_occ_notification function.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"5da5831e1a3bc185d1e0b33ba78acddf2c976bd1","unresolved":true,"context_lines":[{"line_number":112,"context_line":"          self.detail \u003d detail"},{"line_number":113,"context_line":"          self.instance \u003d instance"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"The exceptions in Mgmt Driver must inherit the base class to comply to"},{"line_number":116,"context_line":"``ProblemDetails`` like this."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":3,"id":"671ca384_a1848fb1","line":115,"range":{"start_line":115,"start_character":68,"end_line":115,"end_character":70},"updated":"2022-12-26 06:08:20.000000000","message":"Change to \"with\".","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1f18757f93369cdbe2e7e4a1029c513279468412","unresolved":false,"context_lines":[{"line_number":112,"context_line":"          self.detail \u003d detail"},{"line_number":113,"context_line":"          self.instance \u003d instance"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"The exceptions in Mgmt Driver must inherit the base class to comply to"},{"line_number":116,"context_line":"``ProblemDetails`` like this."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7af57d0c_ed0cafb1","line":115,"range":{"start_line":115,"start_character":68,"end_line":115,"end_character":70},"in_reply_to":"495b6fc5_8d934760","updated":"2022-12-28 02:09:03.000000000","message":"Ack","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d3bd93d073cde31e7dc0a06605f53e097ef4b608","unresolved":true,"context_lines":[{"line_number":112,"context_line":"          self.detail \u003d detail"},{"line_number":113,"context_line":"          self.instance \u003d instance"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"The exceptions in Mgmt Driver must inherit the base class to comply to"},{"line_number":116,"context_line":"``ProblemDetails`` like this."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":3,"id":"495b6fc5_8d934760","line":115,"range":{"start_line":115,"start_character":68,"end_line":115,"end_character":70},"in_reply_to":"671ca384_a1848fb1","updated":"2022-12-26 10:59:09.000000000","message":"Fixed it.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"5da5831e1a3bc185d1e0b33ba78acddf2c976bd1","unresolved":true,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- VDU name to be configured"},{"line_number":132,"context_line":"- failed task name"},{"line_number":133,"context_line":"- stdout of failed task"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Data model impact"},{"line_number":136,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8ffb0395_b1f86883","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":23},"updated":"2022-12-26 06:08:20.000000000","message":"Could you elaborate on the point, what do we expect here?","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1f18757f93369cdbe2e7e4a1029c513279468412","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- VDU name to be configured"},{"line_number":132,"context_line":"- failed task name"},{"line_number":133,"context_line":"- stdout of failed task"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Data model impact"},{"line_number":136,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d03c187e_8b937cfb","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":23},"in_reply_to":"62b177ce_3609ee88","updated":"2022-12-28 02:09:03.000000000","message":"Ack","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d3bd93d073cde31e7dc0a06605f53e097ef4b608","unresolved":true,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- VDU name to be configured"},{"line_number":132,"context_line":"- failed task name"},{"line_number":133,"context_line":"- stdout of failed task"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Data model impact"},{"line_number":136,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"62b177ce_3609ee88","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":23},"in_reply_to":"8ffb0395_b1f86883","updated":"2022-12-26 10:59:09.000000000","message":"Fixed it.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"5da5831e1a3bc185d1e0b33ba78acddf2c976bd1","unresolved":true,"context_lines":[{"line_number":171,"context_line":"Primary assignee:"},{"line_number":172,"context_line":"  Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":173,"context_line":"Other contributors:"},{"line_number":174,"context_line":"  Yukihiro Kinjo \u003cyu-kinjou@kddi.com\u003e"},{"line_number":175,"context_line":"  Xu Hongjin \u003cho-xu@kddi.com\u003e"},{"line_number":176,"context_line":"  Hitomi Koba \u003chi-koba@kddi.com\u003e"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Work Items"},{"line_number":179,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"51afe4db_78c70bec","line":176,"range":{"start_line":174,"start_character":2,"end_line":176,"end_character":32},"updated":"2022-12-26 06:08:20.000000000","message":"Please add a line break.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1f18757f93369cdbe2e7e4a1029c513279468412","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Primary assignee:"},{"line_number":172,"context_line":"  Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":173,"context_line":"Other contributors:"},{"line_number":174,"context_line":"  Yukihiro Kinjo \u003cyu-kinjou@kddi.com\u003e"},{"line_number":175,"context_line":"  Xu Hongjin \u003cho-xu@kddi.com\u003e"},{"line_number":176,"context_line":"  Hitomi Koba \u003chi-koba@kddi.com\u003e"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Work Items"},{"line_number":179,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"915c2db6_605de60d","line":176,"range":{"start_line":174,"start_character":2,"end_line":176,"end_character":32},"in_reply_to":"0c66ff80_c7f6cd95","updated":"2022-12-28 02:09:03.000000000","message":"Ack","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d3bd93d073cde31e7dc0a06605f53e097ef4b608","unresolved":true,"context_lines":[{"line_number":171,"context_line":"Primary assignee:"},{"line_number":172,"context_line":"  Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":173,"context_line":"Other contributors:"},{"line_number":174,"context_line":"  Yukihiro Kinjo \u003cyu-kinjou@kddi.com\u003e"},{"line_number":175,"context_line":"  Xu Hongjin \u003cho-xu@kddi.com\u003e"},{"line_number":176,"context_line":"  Hitomi Koba \u003chi-koba@kddi.com\u003e"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Work Items"},{"line_number":179,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0c66ff80_c7f6cd95","line":176,"range":{"start_line":174,"start_character":2,"end_line":176,"end_character":32},"in_reply_to":"51afe4db_78c70bec","updated":"2022-12-26 10:59:09.000000000","message":"Fixed it.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"5da5831e1a3bc185d1e0b33ba78acddf2c976bd1","unresolved":true,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Work Items"},{"line_number":179,"context_line":"----------"},{"line_number":180,"context_line":"- implement interface of error handling between Tacker and Mgmt Driver"},{"line_number":181,"context_line":"- improving the message of exception raised when Ansible playbook fails"},{"line_number":182,"context_line":"- Add unittest for the interface"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"2671a488_3e401e97","line":180,"range":{"start_line":180,"start_character":2,"end_line":180,"end_character":11},"updated":"2022-12-26 06:08:20.000000000","message":"Change to upper case \"Implement\".","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d3bd93d073cde31e7dc0a06605f53e097ef4b608","unresolved":true,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Work Items"},{"line_number":179,"context_line":"----------"},{"line_number":180,"context_line":"- implement interface of error handling between Tacker and Mgmt Driver"},{"line_number":181,"context_line":"- improving the message of exception raised when Ansible playbook fails"},{"line_number":182,"context_line":"- Add unittest for the interface"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"b212e9bd_7b31b025","line":180,"range":{"start_line":180,"start_character":2,"end_line":180,"end_character":11},"in_reply_to":"2671a488_3e401e97","updated":"2022-12-26 10:59:09.000000000","message":"Fixed it.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1f18757f93369cdbe2e7e4a1029c513279468412","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Work Items"},{"line_number":179,"context_line":"----------"},{"line_number":180,"context_line":"- implement interface of error handling between Tacker and Mgmt Driver"},{"line_number":181,"context_line":"- improving the message of exception raised when Ansible playbook fails"},{"line_number":182,"context_line":"- Add unittest for the interface"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"98ed30cd_4e9449bb","line":180,"range":{"start_line":180,"start_character":2,"end_line":180,"end_character":11},"in_reply_to":"b212e9bd_7b31b025","updated":"2022-12-28 02:09:03.000000000","message":"Ack","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"5da5831e1a3bc185d1e0b33ba78acddf2c976bd1","unresolved":true,"context_lines":[{"line_number":178,"context_line":"Work Items"},{"line_number":179,"context_line":"----------"},{"line_number":180,"context_line":"- implement interface of error handling between Tacker and Mgmt Driver"},{"line_number":181,"context_line":"- improving the message of exception raised when Ansible playbook fails"},{"line_number":182,"context_line":"- Add unittest for the interface"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"05822f97_0bb82c3a","line":181,"range":{"start_line":181,"start_character":2,"end_line":181,"end_character":11},"updated":"2022-12-26 06:08:20.000000000","message":"ditto \"Improving\"","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d3bd93d073cde31e7dc0a06605f53e097ef4b608","unresolved":true,"context_lines":[{"line_number":178,"context_line":"Work Items"},{"line_number":179,"context_line":"----------"},{"line_number":180,"context_line":"- implement interface of error handling between Tacker and Mgmt Driver"},{"line_number":181,"context_line":"- improving the message of exception raised when Ansible playbook fails"},{"line_number":182,"context_line":"- Add unittest for the interface"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d7f3f5a1_81304fd9","line":181,"range":{"start_line":181,"start_character":2,"end_line":181,"end_character":11},"in_reply_to":"05822f97_0bb82c3a","updated":"2022-12-26 10:59:09.000000000","message":"Fixed it.","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1f18757f93369cdbe2e7e4a1029c513279468412","unresolved":false,"context_lines":[{"line_number":178,"context_line":"Work Items"},{"line_number":179,"context_line":"----------"},{"line_number":180,"context_line":"- implement interface of error handling between Tacker and Mgmt Driver"},{"line_number":181,"context_line":"- improving the message of exception raised when Ansible playbook fails"},{"line_number":182,"context_line":"- Add unittest for the interface"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a634d51b_c018b8bd","line":181,"range":{"start_line":181,"start_character":2,"end_line":181,"end_character":11},"in_reply_to":"d7f3f5a1_81304fd9","updated":"2022-12-28 02:09:03.000000000","message":"Ack","commit_id":"1f6ac8e29b1ddb39f97ea4c4a73337753f129bea"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"21843df7ccda529e196e7f650e90a9b6b12d1dbd","unresolved":true,"context_lines":[{"line_number":100,"context_line":"And developers of Mgmt Driver use it to make exceptions in their Mgmt Driver"},{"line_number":101,"context_line":"compatible with ``ProblemDetails``."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The base class is defined in `tacker/common/exceptions.py`."},{"line_number":104,"context_line":"The format is like this."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d37b45ec_13bc0102","line":103,"range":{"start_line":103,"start_character":30,"end_line":103,"end_character":57},"updated":"2022-12-27 00:55:46.000000000","message":"Just a question,\nIt seems that \"tacker/common/exceptions.py\" already defines an Exception for MgmtDriver.\nDo you leave this definition as it is?\nIf so, is it necessary to unify them?","commit_id":"2047fde40776a61860aff520d14840de13bae5ac"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"e9080a2c9dad749948e4a8ba050bdbf0c7732b4d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"And developers of Mgmt Driver use it to make exceptions in their Mgmt Driver"},{"line_number":101,"context_line":"compatible with ``ProblemDetails``."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The base class is defined in `tacker/common/exceptions.py`."},{"line_number":104,"context_line":"The format is like this."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":4,"id":"faaa2e97_07eac662","line":103,"range":{"start_line":103,"start_character":30,"end_line":103,"end_character":57},"in_reply_to":"1e20ff2f_a10cbaa2","updated":"2022-12-28 07:04:54.000000000","message":"I mean the exceptions related to MgmtDriver, for example MgmtDriverException, should be replaced.","commit_id":"2047fde40776a61860aff520d14840de13bae5ac"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7849c0d392bc5663b4a525c79d9baa12a2183afc","unresolved":false,"context_lines":[{"line_number":100,"context_line":"And developers of Mgmt Driver use it to make exceptions in their Mgmt Driver"},{"line_number":101,"context_line":"compatible with ``ProblemDetails``."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The base class is defined in `tacker/common/exceptions.py`."},{"line_number":104,"context_line":"The format is like this."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1e20ff2f_a10cbaa2","line":103,"range":{"start_line":103,"start_character":30,"end_line":103,"end_character":57},"in_reply_to":"40ee2742_d668865f","updated":"2022-12-28 06:14:44.000000000","message":"I\u0027m not still sure how it should be modified, for example, TackerException will be replaced with Exception or so from this example.","commit_id":"2047fde40776a61860aff520d14840de13bae5ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0613943ee2712f48667101b56f478215258a32cf","unresolved":false,"context_lines":[{"line_number":100,"context_line":"And developers of Mgmt Driver use it to make exceptions in their Mgmt Driver"},{"line_number":101,"context_line":"compatible with ``ProblemDetails``."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The base class is defined in `tacker/common/exceptions.py`."},{"line_number":104,"context_line":"The format is like this."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":4,"id":"40ee2742_d668865f","line":103,"range":{"start_line":103,"start_character":30,"end_line":103,"end_character":57},"in_reply_to":"d0e03d4b_234cdf02","updated":"2022-12-28 02:03:35.000000000","message":"Thanks for your answer, I understood that you will develop this improvement to all existing MgmtDrivers,","commit_id":"2047fde40776a61860aff520d14840de13bae5ac"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"855720aedb613c800ead6335d278ef9b0e47d681","unresolved":true,"context_lines":[{"line_number":100,"context_line":"And developers of Mgmt Driver use it to make exceptions in their Mgmt Driver"},{"line_number":101,"context_line":"compatible with ``ProblemDetails``."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The base class is defined in `tacker/common/exceptions.py`."},{"line_number":104,"context_line":"The format is like this."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d0e03d4b_234cdf02","line":103,"range":{"start_line":103,"start_character":30,"end_line":103,"end_character":57},"in_reply_to":"d37b45ec_13bc0102","updated":"2022-12-27 04:28:37.000000000","message":"I think existing exceptions for MgmtDriver should be modified to follow the rule described in this spec.","commit_id":"2047fde40776a61860aff520d14840de13bae5ac"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7849c0d392bc5663b4a525c79d9baa12a2183afc","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"}],"source_content_type":"text/x-rst","patch_set":5,"id":"50c1c9aa_adf1a1e6","line":108,"range":{"start_line":108,"start_character":30,"end_line":108,"end_character":39},"updated":"2022-12-28 06:14:44.000000000","message":"Could I confirm why you use `Exception` instead of `TackerException`?","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7849c0d392bc5663b4a525c79d9baa12a2183afc","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5231340f_2551ab43","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":29},"updated":"2022-12-28 06:14:44.000000000","message":"I strongly suggest to make an agreement of the name of class in this spec to avoid changing the name after proposing actual code changes.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9bcc7ebc8e4a1fa5b3b77e16badb96763ca9959a","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4b7e7962_c8b8420b","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":29},"in_reply_to":"0baa5c0b_5688977c","updated":"2022-12-28 15:29:38.000000000","message":"It seems there are no other suggestion for the name, so we can fix it. Thanks!","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"72c65942780958096065e4974012e4dd92407112","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa2d1947_58b32248","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":29},"in_reply_to":"3d2ed4ca_01aef56e","updated":"2022-12-28 07:29:35.000000000","message":"Before the answer, we have to clear what do you mean by the previous comment. Do you use both of `ManagementDriverError` and `MgmtDriverError`? Anyway, I don\u0027t agree to use `ManagementDriverError` but `MgmtDriverError` for the exception if you just replace all the related exception at least. Moreover, `MgmtDriverException` is better than `MgmtDriverError` for me.\n\n\u003e I mean the exceptions related to MgmtDriver, for example MgmtDriverException, should be replaced.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"e9080a2c9dad749948e4a8ba050bdbf0c7732b4d","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"}],"source_content_type":"text/x-rst","patch_set":5,"id":"b25ce1bf_540bec99","line":108,"range":{"start_line":108,"start_character":30,"end_line":108,"end_character":39},"in_reply_to":"50c1c9aa_adf1a1e6","updated":"2022-12-28 07:04:54.000000000","message":"Sorry, I fixed it to be `TackerException`.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"e9080a2c9dad749948e4a8ba050bdbf0c7732b4d","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3d2ed4ca_01aef56e","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":29},"in_reply_to":"5231340f_2551ab43","updated":"2022-12-28 07:04:54.000000000","message":"Sure. Is it OK this name?","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"72c65942780958096065e4974012e4dd92407112","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fd92b9e3_81f65781","line":108,"range":{"start_line":108,"start_character":30,"end_line":108,"end_character":39},"in_reply_to":"b25ce1bf_540bec99","updated":"2022-12-28 07:29:35.000000000","message":"Ack","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cdb38d93bb8a1e07d9b6d13aa04ab31446ca89dd","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"}],"source_content_type":"text/x-rst","patch_set":5,"id":"0baa5c0b_5688977c","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":29},"in_reply_to":"f0809601_f8dfe5bb","updated":"2022-12-28 09:30:32.000000000","message":"Thanks. I\u0027d give +2 after getting feedback from team.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"6d498acc1d2acf5203e3e7cddf93ad2c9b1fa567","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"}],"source_content_type":"text/x-rst","patch_set":5,"id":"f0809601_f8dfe5bb","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":29},"in_reply_to":"fa2d1947_58b32248","updated":"2022-12-28 08:06:20.000000000","message":"Sorry, I understood your opinion.\nI also feel `MgmtDriverException` is better to be used and so `ManagementDriverError` or `MgmtDriverError` is not needed.\nI fixed it to be `MgmtDriverException`.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7849c0d392bc5663b4a525c79d9baa12a2183afc","unresolved":true,"context_lines":[{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"},{"line_number":112,"context_line":"          self.status \u003d status"},{"line_number":113,"context_line":"          self.detail \u003d detail"},{"line_number":114,"context_line":"          self.instance \u003d instance"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The exceptions in Mgmt Driver must inherit the base class to comply with"}],"source_content_type":"text/x-rst","patch_set":5,"id":"b9bb42b3_36d45132","line":113,"range":{"start_line":111,"start_character":10,"end_line":113,"end_character":30},"updated":"2022-12-28 06:14:44.000000000","message":"Why don\u0027t you separate attributes of `ProblemDetails` from others by moving them under a dict or instance of an inner class has a name such as `ProblemDetailsAttr`? Or, we might not be able to understand these attributes are of ProblemDetails without any additional explanation.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"6d498acc1d2acf5203e3e7cddf93ad2c9b1fa567","unresolved":true,"context_lines":[{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"},{"line_number":112,"context_line":"          self.status \u003d status"},{"line_number":113,"context_line":"          self.detail \u003d detail"},{"line_number":114,"context_line":"          self.instance \u003d instance"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The exceptions in Mgmt Driver must inherit the base class to comply with"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3314c184_a1930442","line":113,"range":{"start_line":111,"start_character":10,"end_line":113,"end_character":30},"in_reply_to":"2f27f3cb_387e09c7","updated":"2022-12-28 08:06:20.000000000","message":"Sure. So I left the attributes as they are.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cdb38d93bb8a1e07d9b6d13aa04ab31446ca89dd","unresolved":true,"context_lines":[{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"},{"line_number":112,"context_line":"          self.status \u003d status"},{"line_number":113,"context_line":"          self.detail \u003d detail"},{"line_number":114,"context_line":"          self.instance \u003d instance"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The exceptions in Mgmt Driver must inherit the base class to comply with"}],"source_content_type":"text/x-rst","patch_set":5,"id":"8c7a2b7b_c5853a2f","line":113,"range":{"start_line":111,"start_character":10,"end_line":113,"end_character":30},"in_reply_to":"3314c184_a1930442","updated":"2022-12-28 09:30:32.000000000","message":"I\u0027d remind you should add an explanation, docstring or so, that the members of the class is for `ProblemDetails` if nothing changes on the code. Thanks.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"72c65942780958096065e4974012e4dd92407112","unresolved":true,"context_lines":[{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"},{"line_number":112,"context_line":"          self.status \u003d status"},{"line_number":113,"context_line":"          self.detail \u003d detail"},{"line_number":114,"context_line":"          self.instance \u003d instance"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The exceptions in Mgmt Driver must inherit the base class to comply with"}],"source_content_type":"text/x-rst","patch_set":5,"id":"2f27f3cb_387e09c7","line":113,"range":{"start_line":111,"start_character":10,"end_line":113,"end_character":30},"in_reply_to":"76ecb472_911da4cb","updated":"2022-12-28 07:29:35.000000000","message":"I understand. IMO, it\u0027s OK to not consider the attributes are of ProblemDetails or not if no other attributes will be added in the class.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"cc935dcfb1d84446f19234bc4980679073325e30","unresolved":true,"context_lines":[{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"},{"line_number":112,"context_line":"          self.status \u003d status"},{"line_number":113,"context_line":"          self.detail \u003d detail"},{"line_number":114,"context_line":"          self.instance \u003d instance"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The exceptions in Mgmt Driver must inherit the base class to comply with"}],"source_content_type":"text/x-rst","patch_set":5,"id":"a9ca0c68_abaadcb8","line":113,"range":{"start_line":111,"start_character":10,"end_line":113,"end_character":30},"in_reply_to":"8c7a2b7b_c5853a2f","updated":"2022-12-28 09:47:35.000000000","message":"Thanks. So I will add the docstring when implementing.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9bcc7ebc8e4a1fa5b3b77e16badb96763ca9959a","unresolved":false,"context_lines":[{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"},{"line_number":112,"context_line":"          self.status \u003d status"},{"line_number":113,"context_line":"          self.detail \u003d detail"},{"line_number":114,"context_line":"          self.instance \u003d instance"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The exceptions in Mgmt Driver must inherit the base class to comply with"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1b1ab0a4_d0ee8060","line":113,"range":{"start_line":111,"start_character":10,"end_line":113,"end_character":30},"in_reply_to":"a9ca0c68_abaadcb8","updated":"2022-12-28 15:29:38.000000000","message":"Ack","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"e9080a2c9dad749948e4a8ba050bdbf0c7732b4d","unresolved":true,"context_lines":[{"line_number":108,"context_line":"  class ManagementDriverError(Exception):"},{"line_number":109,"context_line":"      def __init__(self, type\u003dNone, title\u003dNone, status, detail, instance\u003dNone)"},{"line_number":110,"context_line":"          self.type \u003d type"},{"line_number":111,"context_line":"          self.title \u003d title"},{"line_number":112,"context_line":"          self.status \u003d status"},{"line_number":113,"context_line":"          self.detail \u003d detail"},{"line_number":114,"context_line":"          self.instance \u003d instance"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The exceptions in Mgmt Driver must inherit the base class to comply with"}],"source_content_type":"text/x-rst","patch_set":5,"id":"76ecb472_911da4cb","line":113,"range":{"start_line":111,"start_character":10,"end_line":113,"end_character":30},"in_reply_to":"b9bb42b3_36d45132","updated":"2022-12-28 07:04:54.000000000","message":"All of attributes written here are defined as an attribute of `ProblemDetails` in ETSI GS NFV-SOL 013 v2.6.1.\nBut it looks that `type` and `instance` are not being used in current Tacker\u0027s implementation, so is it better to remove `type` and `instance`?\nAnd is it better to put `title`, `status` and `detail` into a dict or instance of innner class?","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7849c0d392bc5663b4a525c79d9baa12a2183afc","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":".. code-block:: python"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  class SampleException(ManagementDriverError):"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"2) Improving the message of exception raised when Ansible playbook fails"}],"source_content_type":"text/x-rst","patch_set":5,"id":"058d832a_969fadcc","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":23},"updated":"2022-12-28 06:14:44.000000000","message":"nit: It\u0027s not a good example name. Please use more specific name even though it\u0027s just an example.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"e9080a2c9dad749948e4a8ba050bdbf0c7732b4d","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":".. code-block:: python"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  class SampleException(ManagementDriverError):"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"2) Improving the message of exception raised when Ansible playbook fails"}],"source_content_type":"text/x-rst","patch_set":5,"id":"a9426a7b_1409a25c","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":23},"in_reply_to":"058d832a_969fadcc","updated":"2022-12-28 07:04:54.000000000","message":"I fixed it.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7849c0d392bc5663b4a525c79d9baa12a2183afc","unresolved":true,"context_lines":[{"line_number":124,"context_line":"2) Improving the message of exception raised when Ansible playbook fails"},{"line_number":125,"context_line":"------------------------------------------------------------------------"},{"line_number":126,"context_line":"In Ansible Mgmt Driver sample,"},{"line_number":127,"context_line":"CommandExecutionError is raised when Ansible playbook fails."},{"line_number":128,"context_line":"This error always outputs the same message regardless of what task fails."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"In this spec, it is modified to include following 3 points."}],"source_content_type":"text/x-rst","patch_set":5,"id":"e1c46eb9_f24af770","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":21},"updated":"2022-12-28 06:14:44.000000000","message":"nit: It\u0027s better to make it as a keyword with double backquotes.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"e9080a2c9dad749948e4a8ba050bdbf0c7732b4d","unresolved":true,"context_lines":[{"line_number":124,"context_line":"2) Improving the message of exception raised when Ansible playbook fails"},{"line_number":125,"context_line":"------------------------------------------------------------------------"},{"line_number":126,"context_line":"In Ansible Mgmt Driver sample,"},{"line_number":127,"context_line":"CommandExecutionError is raised when Ansible playbook fails."},{"line_number":128,"context_line":"This error always outputs the same message regardless of what task fails."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"In this spec, it is modified to include following 3 points."}],"source_content_type":"text/x-rst","patch_set":5,"id":"fca3f009_46c7c03d","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":21},"in_reply_to":"e1c46eb9_f24af770","updated":"2022-12-28 07:04:54.000000000","message":"Fixed.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7849c0d392bc5663b4a525c79d9baa12a2183afc","unresolved":true,"context_lines":[{"line_number":130,"context_line":"In this spec, it is modified to include following 3 points."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"- VDU name to be configured"},{"line_number":133,"context_line":"- failed task name"},{"line_number":134,"context_line":"- extracted stdout message of the ansible-playbook command"},{"line_number":135,"context_line":"  related to the failed task"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Data model impact"},{"line_number":138,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"06cd393d_09421e37","line":135,"range":{"start_line":133,"start_character":0,"end_line":135,"end_character":28},"updated":"2022-12-28 06:14:44.000000000","message":"nit: Please start from capital letter for such a general statements to avoid annoying reviewers that it\u0027s a typo or not.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"e9080a2c9dad749948e4a8ba050bdbf0c7732b4d","unresolved":true,"context_lines":[{"line_number":130,"context_line":"In this spec, it is modified to include following 3 points."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"- VDU name to be configured"},{"line_number":133,"context_line":"- failed task name"},{"line_number":134,"context_line":"- extracted stdout message of the ansible-playbook command"},{"line_number":135,"context_line":"  related to the failed task"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Data model impact"},{"line_number":138,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fe19fc4_5ab20a6f","line":135,"range":{"start_line":133,"start_character":0,"end_line":135,"end_character":28},"in_reply_to":"06cd393d_09421e37","updated":"2022-12-28 07:04:54.000000000","message":"Fixed.","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7849c0d392bc5663b4a525c79d9baa12a2183afc","unresolved":true,"context_lines":[{"line_number":133,"context_line":"- failed task name"},{"line_number":134,"context_line":"- extracted stdout message of the ansible-playbook command"},{"line_number":135,"context_line":"  related to the failed task"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Data model impact"},{"line_number":138,"context_line":"-----------------"},{"line_number":139,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff27ec39_a937be51","line":136,"updated":"2022-12-28 06:14:44.000000000","message":"Could you give us an example of extracted message here if you have any idea for that?","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"e9080a2c9dad749948e4a8ba050bdbf0c7732b4d","unresolved":true,"context_lines":[{"line_number":133,"context_line":"- failed task name"},{"line_number":134,"context_line":"- extracted stdout message of the ansible-playbook command"},{"line_number":135,"context_line":"  related to the failed task"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Data model impact"},{"line_number":138,"context_line":"-----------------"},{"line_number":139,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":5,"id":"64d117cb_fac760b3","line":136,"in_reply_to":"ff27ec39_a937be51","updated":"2022-12-28 07:04:54.000000000","message":"It is a stdout message of failed task.\nLike this.\n```\nTASK [some task] ***********************************************************************************************************************************************\nfatal: [node1]: FAILED! \u003d\u003e {some message}\n```","commit_id":"f1b1f26b9ded0fa40d261dbb8d3dec615c97eb60"}]}