)]}'
{"tacker/vm/infra_drivers/heat/heat.py":[{"author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"change_message_id":"39a304c8c6d9afbedffaf353e30d5380a5e70595","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                heat_template_yaml \u003d toscautils.post_process_heat_template("},{"line_number":309,"context_line":"                    heat_template_yaml, mgmt_ports)"},{"line_number":310,"context_line":"                heat_template_yaml \u003d \\"},{"line_number":311,"context_line":"                    self._add_resources_tpl(heat_template_yaml, res_tpl)"},{"line_number":312,"context_line":"            else:"},{"line_number":313,"context_line":"                assert \u0027template\u0027 not in fields"},{"line_number":314,"context_line":"                assert \u0027template_url\u0027 not in fields"}],"source_content_type":"text/x-python","patch_set":21,"id":"da0c15f0_59f716f5","line":311,"range":{"start_line":311,"start_character":25,"end_line":311,"end_character":43},"updated":"2016-03-27 03:50:53.000000000","message":"I put the same comment in the flavor patchset - it might be better to put this method call in post_process_heat_template and pass res_tpl to that function.","commit_id":"fc0b4cab913bda3f0d48acc101b901f6bd91030b"}],"tacker/vm/tosca/lib/tacker_defs.yaml":[{"author":{"_account_id":12455,"name":"bharaththiruveedula","email":"bharath_ves@hotmail.com","username":"bharaththiruveedula"},"change_message_id":"1bae2a3e8ed8c618ffa56be81498a8800bce9342","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        entry_schema:"},{"line_number":46,"context_line":"          type: tosca.datatype.numa_node_map"},{"line_number":47,"context_line":"      cpu_allocation:"},{"line_number":48,"context_line":"        type: tosca.datatypes.cpu_settings"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  tosca.datatypes.cpu_settings:"},{"line_number":51,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1af94dfe_f5ed25f0","line":48,"updated":"2016-03-17 09:02:57.000000000","message":"But in this part, I am getting validation error","commit_id":"5b728d0114c59140651b618fabecde3f46de8e28"},{"author":{"_account_id":12525,"name":"vishwanath jayaraman","email":"vishwanathj@hotmail.com","username":"vish"},"change_message_id":"23078491b799f76a37fd4e0ca5c5075ab34dbd9f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        entry_schema:"},{"line_number":46,"context_line":"          type: tosca.datatype.numa_node_map"},{"line_number":47,"context_line":"      cpu_allocation:"},{"line_number":48,"context_line":"        type: tosca.datatypes.cpu_settings"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  tosca.datatypes.cpu_settings:"},{"line_number":51,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1af94dfe_9d3772fe","line":48,"in_reply_to":"1af94dfe_f5ed25f0","updated":"2016-03-18 05:07:34.000000000","message":"Yes, there is an error. Bob is trying to help out.","commit_id":"5b728d0114c59140651b618fabecde3f46de8e28"}],"tacker/vm/tosca/utils.py":[{"author":{"_account_id":12455,"name":"bharaththiruveedula","email":"bharath_ves@hotmail.com","username":"bharaththiruveedula"},"change_message_id":"59f4c1b86c839db90414d3719337de2372e8eb8f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                 (\u0027hw:cpu_sockets\u0027, \u0027socket_count\u0027),"},{"line_number":40,"context_line":"                 (\u0027hw:cpu_threads\u0027, \u0027thread_count\u0027),"},{"line_number":41,"context_line":"                 (\u0027hw:cpu_cores\u0027, \u0027core_count\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"FLAVOR_EXTRA_SPECS_LIST \u003d (cpu_allocation,"},{"line_number":44,"context_line":"                           mem_page_size,"},{"line_number":45,"context_line":"                           numa_node_count,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_e5c9217a","line":42,"updated":"2016-03-14 10:35:55.000000000","message":"We need to add this details in tacker_defs.yaml. Otherwise tosca-parser will raise validation error.","commit_id":"463eb54c6a353e7763ffe09cf69ff861af2278aa"},{"author":{"_account_id":12455,"name":"bharaththiruveedula","email":"bharath_ves@hotmail.com","username":"bharaththiruveedula"},"change_message_id":"4c39483da8ec8c5006e0f71f4205d5edf46a42cf","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                if \u0027mem_page_size\u0027 in properties:"},{"line_number":164,"context_line":"                    mval \u003d properties[\u0027mem_page_size\u0027]"},{"line_number":165,"context_line":"                    if str(mval).isdigit():"},{"line_number":166,"context_line":"                        mval \u003d mval * 1024"},{"line_number":167,"context_line":"                    es_dict[\u0027mem_page_size\u0027][\u0027hw:mem_page_size\u0027] \u003d mval"},{"line_number":168,"context_line":"                numa_processed \u003d False"},{"line_number":169,"context_line":"                if \u0027numa_node_count\u0027 in properties:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1af94dfe_cc0fcd2c","line":166,"range":{"start_line":166,"start_character":28,"end_line":166,"end_character":29},"updated":"2016-03-17 03:56:07.000000000","message":"Vishwanath, I didn\u0027t understand why we need to multiply \"mem_page_size\" with 1024, if it is a number. Can you clarify on this?","commit_id":"5b728d0114c59140651b618fabecde3f46de8e28"},{"author":{"_account_id":12455,"name":"bharaththiruveedula","email":"bharath_ves@hotmail.com","username":"bharaththiruveedula"},"change_message_id":"b8f4721dde4b924ba9adb1b2af5dbbdedd8994cd","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                if \u0027mem_page_size\u0027 in properties:"},{"line_number":164,"context_line":"                    mval \u003d properties[\u0027mem_page_size\u0027]"},{"line_number":165,"context_line":"                    if str(mval).isdigit():"},{"line_number":166,"context_line":"                        mval \u003d mval * 1024"},{"line_number":167,"context_line":"                    es_dict[\u0027mem_page_size\u0027][\u0027hw:mem_page_size\u0027] \u003d mval"},{"line_number":168,"context_line":"                numa_processed \u003d False"},{"line_number":169,"context_line":"                if \u0027numa_node_count\u0027 in properties:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1af94dfe_acb521ef","line":166,"range":{"start_line":166,"start_character":28,"end_line":166,"end_character":29},"in_reply_to":"1af94dfe_0c8d357b","updated":"2016-03-17 04:19:26.000000000","message":"It is assumed that the user will give only MB values. Is there no way that the user can give KB values directly?","commit_id":"5b728d0114c59140651b618fabecde3f46de8e28"},{"author":{"_account_id":12525,"name":"vishwanath jayaraman","email":"vishwanathj@hotmail.com","username":"vish"},"change_message_id":"2ac418309566869d55e638c73d84a4df731d2b1f","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                if \u0027mem_page_size\u0027 in properties:"},{"line_number":164,"context_line":"                    mval \u003d properties[\u0027mem_page_size\u0027]"},{"line_number":165,"context_line":"                    if str(mval).isdigit():"},{"line_number":166,"context_line":"                        mval \u003d mval * 1024"},{"line_number":167,"context_line":"                    es_dict[\u0027mem_page_size\u0027][\u0027hw:mem_page_size\u0027] \u003d mval"},{"line_number":168,"context_line":"                numa_processed \u003d False"},{"line_number":169,"context_line":"                if \u0027numa_node_count\u0027 in properties:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1af94dfe_af599300","line":166,"range":{"start_line":166,"start_character":28,"end_line":166,"end_character":29},"in_reply_to":"1af94dfe_acb521ef","updated":"2016-03-17 05:14:05.000000000","message":"At this the documentation will mention that the values are accepted only in MB. Most OS support either 2MB huge pages or 1GB huge pages, so if an admin has both the huge pages configured, the choice he has is either 2 or 1024. Trying to provide these as KB values does not provide much user advantage in mu opinion.","commit_id":"5b728d0114c59140651b618fabecde3f46de8e28"},{"author":{"_account_id":12525,"name":"vishwanath jayaraman","email":"vishwanathj@hotmail.com","username":"vish"},"change_message_id":"a1faeb2aaca24975999643e032e4768d1bec71bc","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                if \u0027mem_page_size\u0027 in properties:"},{"line_number":164,"context_line":"                    mval \u003d properties[\u0027mem_page_size\u0027]"},{"line_number":165,"context_line":"                    if str(mval).isdigit():"},{"line_number":166,"context_line":"                        mval \u003d mval * 1024"},{"line_number":167,"context_line":"                    es_dict[\u0027mem_page_size\u0027][\u0027hw:mem_page_size\u0027] \u003d mval"},{"line_number":168,"context_line":"                numa_processed \u003d False"},{"line_number":169,"context_line":"                if \u0027numa_node_count\u0027 in properties:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1af94dfe_0c8d357b","line":166,"range":{"start_line":166,"start_character":28,"end_line":166,"end_character":29},"in_reply_to":"1af94dfe_cc0fcd2c","updated":"2016-03-17 04:02:33.000000000","message":"The default value provided by end user will be accepted as in MB. The underlying API expects the value in KB, hence the multiplication to convert to KB.","commit_id":"5b728d0114c59140651b618fabecde3f46de8e28"}]}