)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"1a88893d17ada35e37fff4204d2367aff229699a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Janki Chhatbar \u003cjankihchhatbar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-13 23:44:33 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Openwrt image failure handled in fresh tacker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Idb037a459b34f049f54bf1c88f161f9eeb24f9f9"},{"line_number":10,"context_line":"Signed-off-by: Janki Chhatbar \u003cjankihchhatbar@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a18252c_5e5fd7e4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":45},"updated":"2016-04-13 19:29:59.000000000","message":"This title is not helpful. Can you retain the original commit message/description.\nPlease do not forget Closes-Bug","commit_id":"0793f271f5c5697bf6bb91c06fa9377e8bca76b3"}],"devstack/lib/tacker":[{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"1786065143cbcda105bed05c57df18a69d9ddac6","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    image_fname\u003d`basename \"$image_url\"`"},{"line_number":359,"context_line":"    if [[ $image_url !\u003d file* ]]; then"},{"line_number":360,"context_line":"        if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":361,"context_line":"            set -o xtrace"},{"line_number":362,"context_line":"            {"},{"line_number":363,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname \u0026\u0026 openstack_image_create_openwrt $FILES/$image_fname"},{"line_number":364,"context_line":"            }||{"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa0719c6_ac22f7a0","line":361,"updated":"2016-03-24 06:16:52.000000000","message":"Do you really need this ? It is already taken care in L33 in this file.","commit_id":"ffb48c1a15b2680f2a2b368e5ea4ee44a5f0dd4c"},{"author":{"_account_id":20866,"name":"Janki Chhatbar","email":"jchhatba@redhat.com","username":"janki"},"change_message_id":"29f64840bc12c02e587bd04b128bcd3d7a2d2320","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    image_fname\u003d`basename \"$image_url\"`"},{"line_number":359,"context_line":"    if [[ $image_url !\u003d file* ]]; then"},{"line_number":360,"context_line":"        if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":361,"context_line":"            set -o xtrace"},{"line_number":362,"context_line":"            {"},{"line_number":363,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname \u0026\u0026 openstack_image_create_openwrt $FILES/$image_fname"},{"line_number":364,"context_line":"            }||{"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa0719c6_c38571cf","line":361,"in_reply_to":"fa0719c6_ac22f7a0","updated":"2016-03-24 09:57:06.000000000","message":"Done","commit_id":"ffb48c1a15b2680f2a2b368e5ea4ee44a5f0dd4c"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"1786065143cbcda105bed05c57df18a69d9ddac6","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":361,"context_line":"            set -o xtrace"},{"line_number":362,"context_line":"            {"},{"line_number":363,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname \u0026\u0026 openstack_image_create_openwrt $FILES/$image_fname"},{"line_number":364,"context_line":"            }||{"},{"line_number":365,"context_line":"                rm $FILES/$image_fname"},{"line_number":366,"context_line":"                echo \"WARNING: openwrt image not downloaded\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa0719c6_2cb42733","line":363,"updated":"2016-03-24 06:16:52.000000000","message":"nit: break this into multiple lines. Line length exceeds typical 79 char limit. OpenStack following code guidelines specified in [1].\n\n[1] http://docs.openstack.org/developer/hacking/","commit_id":"ffb48c1a15b2680f2a2b368e5ea4ee44a5f0dd4c"},{"author":{"_account_id":20866,"name":"Janki Chhatbar","email":"jchhatba@redhat.com","username":"janki"},"change_message_id":"29f64840bc12c02e587bd04b128bcd3d7a2d2320","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":361,"context_line":"            set -o xtrace"},{"line_number":362,"context_line":"            {"},{"line_number":363,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname \u0026\u0026 openstack_image_create_openwrt $FILES/$image_fname"},{"line_number":364,"context_line":"            }||{"},{"line_number":365,"context_line":"                rm $FILES/$image_fname"},{"line_number":366,"context_line":"                echo \"WARNING: openwrt image not downloaded\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa0719c6_e38235c7","line":363,"in_reply_to":"fa0719c6_2cb42733","updated":"2016-03-24 09:57:06.000000000","message":"Done","commit_id":"ffb48c1a15b2680f2a2b368e5ea4ee44a5f0dd4c"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"1786065143cbcda105bed05c57df18a69d9ddac6","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            {"},{"line_number":363,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname \u0026\u0026 openstack_image_create_openwrt $FILES/$image_fname"},{"line_number":364,"context_line":"            }||{"},{"line_number":365,"context_line":"                rm $FILES/$image_fname"},{"line_number":366,"context_line":"                echo \"WARNING: openwrt image not downloaded\""},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa0719c6_ec94ef8b","line":365,"updated":"2016-03-24 06:16:52.000000000","message":"Probably safe to do \"rm -f\" in case the file is not created at all ?","commit_id":"ffb48c1a15b2680f2a2b368e5ea4ee44a5f0dd4c"},{"author":{"_account_id":20866,"name":"Janki Chhatbar","email":"jchhatba@redhat.com","username":"janki"},"change_message_id":"29f64840bc12c02e587bd04b128bcd3d7a2d2320","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            {"},{"line_number":363,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname \u0026\u0026 openstack_image_create_openwrt $FILES/$image_fname"},{"line_number":364,"context_line":"            }||{"},{"line_number":365,"context_line":"                rm $FILES/$image_fname"},{"line_number":366,"context_line":"                echo \"WARNING: openwrt image not downloaded\""},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa0719c6_6320e5f7","line":365,"in_reply_to":"fa0719c6_ec94ef8b","updated":"2016-03-24 09:57:06.000000000","message":"Done","commit_id":"ffb48c1a15b2680f2a2b368e5ea4ee44a5f0dd4c"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"1786065143cbcda105bed05c57df18a69d9ddac6","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                echo \"WARNING: openwrt image not downloaded\""},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"        fi"},{"line_number":369,"context_line":"    fi"},{"line_number":370,"context_line":"}"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"function tacker_create_initial_network {"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa0719c6_4c6cfb9b","line":369,"updated":"2016-03-24 06:16:52.000000000","message":"can you explicitly return the outcome of this function ? This will be useful in follow on efforts to upload OpenWRT VNFD into the catalog.","commit_id":"ffb48c1a15b2680f2a2b368e5ea4ee44a5f0dd4c"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"a8e0b8f0943d8c1682a18065974453eec7d70417","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                echo \"WARNING: openwrt image not downloaded\""},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"        fi"},{"line_number":369,"context_line":"    fi"},{"line_number":370,"context_line":"}"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"function tacker_create_initial_network {"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da0c15f0_d1033f0c","line":369,"in_reply_to":"fa0719c6_434961b6","updated":"2016-03-24 21:20:17.000000000","message":"Yes, with the value 0 - for success and 1 for the failure condition at L366.","commit_id":"ffb48c1a15b2680f2a2b368e5ea4ee44a5f0dd4c"},{"author":{"_account_id":20866,"name":"Janki Chhatbar","email":"jchhatba@redhat.com","username":"janki"},"change_message_id":"29f64840bc12c02e587bd04b128bcd3d7a2d2320","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                echo \"WARNING: openwrt image not downloaded\""},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"        fi"},{"line_number":369,"context_line":"    fi"},{"line_number":370,"context_line":"}"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"function tacker_create_initial_network {"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa0719c6_434961b6","line":369,"in_reply_to":"fa0719c6_4c6cfb9b","updated":"2016-03-24 09:57:06.000000000","message":"Could you please elaborate on \"explicitly return the outcome of the function\"? Does this mean adding a \"return\" line?","commit_id":"ffb48c1a15b2680f2a2b368e5ea4ee44a5f0dd4c"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"fef890609b66cc12ea6da223814fda11e68548c3","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    local image_url\u003dhttps://downloads.openwrt.org/chaos_calmer/15.05/x86/kvm_guest/openwrt-15.05-x86-kvm_guest-combined-ext4.img.gz"},{"line_number":357,"context_line":"    local image image_fname image_name"},{"line_number":358,"context_line":"    image_fname\u003d`basename \"$image_url\"`"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    if [[ $image_url !\u003d file* ]]; then"},{"line_number":361,"context_line":"        if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":362,"context_line":"            {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba0121b8_98824393","line":359,"updated":"2016-03-30 00:32:00.000000000","message":"Initialize return value (to failure),\n\nret_val\u003d1","commit_id":"0733c7a5e1c4e1570d70976cb0eef7949817b1b8"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"fef890609b66cc12ea6da223814fda11e68548c3","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":362,"context_line":"            {"},{"line_number":363,"context_line":"               wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname \\"},{"line_number":364,"context_line":"                   \u0026\u0026 openstack_image_create_openwrt $FILES/$image_fname"},{"line_number":365,"context_line":"            }||{"},{"line_number":366,"context_line":"                rm -f $FILES/$image_fname"},{"line_number":367,"context_line":"                echo \"WARNING: openwrt image $image_fname not downloaded\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba0121b8_b8662727","line":364,"updated":"2016-03-30 00:32:00.000000000","message":"Add something like below here (to grab the outcome of L364),\n\nret_val \u003d $?","commit_id":"0733c7a5e1c4e1570d70976cb0eef7949817b1b8"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"fef890609b66cc12ea6da223814fda11e68548c3","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            }"},{"line_number":369,"context_line":"        fi"},{"line_number":370,"context_line":"    fi"},{"line_number":371,"context_line":"    return"},{"line_number":372,"context_line":"}"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"function tacker_create_initial_network {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba0121b8_385a1751","line":371,"range":{"start_line":371,"start_character":4,"end_line":371,"end_character":10},"updated":"2016-03-30 00:32:00.000000000","message":"Change this t,\n\nreturn $ret_val","commit_id":"0733c7a5e1c4e1570d70976cb0eef7949817b1b8"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"354d24a14ca09355f45a4a5c88182325282e6abf","unresolved":false,"context_lines":[{"line_number":362,"context_line":"               wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname \\"},{"line_number":363,"context_line":"                   \u0026\u0026 openstack_image_create_openwrt $FILES/$image_fname"},{"line_number":364,"context_line":"            }||{"},{"line_number":365,"context_line":"                rm -f $FILES/$image_fname"},{"line_number":366,"context_line":"                echo \"WARNING: openwrt image $image_fname not downloaded\""},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5a18252c_95ece5c8","line":365,"range":{"start_line":365,"start_character":20,"end_line":365,"end_character":21},"updated":"2016-04-13 00:25:46.000000000","message":"this is a directory path. it should be -rf","commit_id":"069ca7e909d8327f5c6679d38ad9706a03ce7ad5"},{"author":{"_account_id":20866,"name":"Janki Chhatbar","email":"jchhatba@redhat.com","username":"janki"},"change_message_id":"798791409b9271ee2624f765c3063824d2812ecd","unresolved":false,"context_lines":[{"line_number":362,"context_line":"               wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname \\"},{"line_number":363,"context_line":"                   \u0026\u0026 openstack_image_create_openwrt $FILES/$image_fname"},{"line_number":364,"context_line":"            }||{"},{"line_number":365,"context_line":"                rm -f $FILES/$image_fname"},{"line_number":366,"context_line":"                echo \"WARNING: openwrt image $image_fname not downloaded\""},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5a18252c_31d520b9","line":365,"range":{"start_line":365,"start_character":20,"end_line":365,"end_character":21},"in_reply_to":"5a18252c_95ece5c8","updated":"2016-04-13 04:32:48.000000000","message":"It removes the image file under files directory. -r is not necessary","commit_id":"069ca7e909d8327f5c6679d38ad9706a03ce7ad5"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"354d24a14ca09355f45a4a5c88182325282e6abf","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                   \u0026\u0026 openstack_image_create_openwrt $FILES/$image_fname"},{"line_number":364,"context_line":"            }||{"},{"line_number":365,"context_line":"                rm -f $FILES/$image_fname"},{"line_number":366,"context_line":"                echo \"WARNING: openwrt image $image_fname not downloaded\""},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"        fi"},{"line_number":369,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5a18252c_35aeb185","line":366,"range":{"start_line":366,"start_character":22,"end_line":366,"end_character":72},"updated":"2016-04-13 00:25:46.000000000","message":"openwrt image not downloaded error message for both failures (wget failure/glance image create failure) is misleading. you can keep it generic as \"WARNING: openwrt image create for $image_fname failed\"","commit_id":"069ca7e909d8327f5c6679d38ad9706a03ce7ad5"},{"author":{"_account_id":20866,"name":"Janki Chhatbar","email":"jchhatba@redhat.com","username":"janki"},"change_message_id":"798791409b9271ee2624f765c3063824d2812ecd","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                   \u0026\u0026 openstack_image_create_openwrt $FILES/$image_fname"},{"line_number":364,"context_line":"            }||{"},{"line_number":365,"context_line":"                rm -f $FILES/$image_fname"},{"line_number":366,"context_line":"                echo \"WARNING: openwrt image $image_fname not downloaded\""},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"        fi"},{"line_number":369,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5a18252c_110624ce","line":366,"range":{"start_line":366,"start_character":22,"end_line":366,"end_character":72},"in_reply_to":"5a18252c_35aeb185","updated":"2016-04-13 04:32:48.000000000","message":"Done","commit_id":"069ca7e909d8327f5c6679d38ad9706a03ce7ad5"}]}