)]}'
{"tacker/vm/plugin.py":[{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"78cf1c6c4986513fc253fea3ef18a81e17c34a2b","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            self.mgmt_call(context, device_dict, kwargs)"},{"line_number":386,"context_line":"            self._device_manager.invoke(driver_name, \u0027delete\u0027, plugin\u003dself,"},{"line_number":387,"context_line":"                                        context\u003dcontext,"},{"line_number":388,"context_line":"                                        device_id\u003dinstance_id,"},{"line_number":389,"context_line":"                                        auth_attr\u003dvim_auth,"},{"line_number":390,"context_line":"                                        region_name\u003dregion_name)"},{"line_number":391,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_16b7e0f5","line":388,"range":{"start_line":388,"start_character":50,"end_line":388,"end_character":61},"updated":"2016-06-08 04:47:41.000000000","message":"instance_id check needs to be handled here along with _delete_device_id. Here we are passing a None stack id for deletion for which stack trace error is thrown.","commit_id":"82baf4ed07990ce3e9ad86990df0cdad73bb56c6"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"d473d3b86f20fdb01895392f550b33dc285630d2","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            self.mgmt_call(context, device_dict, kwargs)"},{"line_number":386,"context_line":"            self._device_manager.invoke(driver_name, \u0027delete\u0027, plugin\u003dself,"},{"line_number":387,"context_line":"                                        context\u003dcontext,"},{"line_number":388,"context_line":"                                        device_id\u003dinstance_id,"},{"line_number":389,"context_line":"                                        auth_attr\u003dvim_auth,"},{"line_number":390,"context_line":"                                        region_name\u003dregion_name)"},{"line_number":391,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_7a052244","line":388,"range":{"start_line":388,"start_character":50,"end_line":388,"end_character":61},"in_reply_to":"7aa08908_05ce722d","updated":"2016-06-08 22:55:00.000000000","message":"we need to check instance_id not None here also similar to L349","commit_id":"82baf4ed07990ce3e9ad86990df0cdad73bb56c6"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"a552463980e3285c13a431d455b4b0224182ea47","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            self.mgmt_call(context, device_dict, kwargs)"},{"line_number":386,"context_line":"            self._device_manager.invoke(driver_name, \u0027delete\u0027, plugin\u003dself,"},{"line_number":387,"context_line":"                                        context\u003dcontext,"},{"line_number":388,"context_line":"                                        device_id\u003dinstance_id,"},{"line_number":389,"context_line":"                                        auth_attr\u003dvim_auth,"},{"line_number":390,"context_line":"                                        region_name\u003dregion_name)"},{"line_number":391,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_05ce722d","line":388,"range":{"start_line":388,"start_character":50,"end_line":388,"end_character":61},"in_reply_to":"7aa08908_16b7e0f5","updated":"2016-06-08 09:34:11.000000000","message":"not sure I got the point. will ping in IRC.","commit_id":"82baf4ed07990ce3e9ad86990df0cdad73bb56c6"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"570a9a097e49644d1af7cb5ff17f831ed0e82106","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            self.mgmt_call(context, device_dict, kwargs)"},{"line_number":386,"context_line":"            self._device_manager.invoke(driver_name, \u0027delete\u0027, plugin\u003dself,"},{"line_number":387,"context_line":"                                        context\u003dcontext,"},{"line_number":388,"context_line":"                                        device_id\u003dinstance_id,"},{"line_number":389,"context_line":"                                        auth_attr\u003dvim_auth,"},{"line_number":390,"context_line":"                                        region_name\u003dregion_name)"},{"line_number":391,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_ae8f4573","line":388,"range":{"start_line":388,"start_character":50,"end_line":388,"end_character":61},"in_reply_to":"7aa08908_7a052244","updated":"2016-06-09 03:33:32.000000000","message":"you mean, when instance_id is None, then don\u0027t invoke driver manager at tline 386. also let me know what is _delete_device_id. thanks","commit_id":"82baf4ed07990ce3e9ad86990df0cdad73bb56c6"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"61a800c108f9d6114576912e11735bd1b0790683","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            self.mgmt_call(context, device_dict, kwargs)"},{"line_number":386,"context_line":"            self._device_manager.invoke(driver_name, \u0027delete\u0027, plugin\u003dself,"},{"line_number":387,"context_line":"                                        context\u003dcontext,"},{"line_number":388,"context_line":"                                        device_id\u003dinstance_id,"},{"line_number":389,"context_line":"                                        auth_attr\u003dvim_auth,"},{"line_number":390,"context_line":"                                        region_name\u003dregion_name)"},{"line_number":391,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_91170c44","line":388,"range":{"start_line":388,"start_character":50,"end_line":388,"end_character":61},"in_reply_to":"7aa08908_ae8f4573","updated":"2016-06-09 04:17:47.000000000","message":"that is correct.\n\ni meant _delete_device_wait :P not sure why i wrote _device_wait_id","commit_id":"82baf4ed07990ce3e9ad86990df0cdad73bb56c6"}]}