)]}'
{"tacker/tests/unit/vm/infra_drivers/heat/data/hot_openwrt_params.yaml":[{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"64f0743d6f77293d66c7c8536cd844a6575e24fb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      config_drive: true"},{"line_number":13,"context_line":"      flavor: m1.tiny"},{"line_number":14,"context_line":"      image: cirros-0.3.4-x86_64-uec"},{"line_number":15,"context_line":"      key_name: keyName"},{"line_number":16,"context_line":"      metadata: {param0: key0, param1: key1}"},{"line_number":17,"context_line":"      networks:"},{"line_number":18,"context_line":"      - port: {get_resource: vdu1-net_mgmt-port}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a9d85d2_81d15cfe","side":"PARENT","line":15,"updated":"2016-06-20 07:52:23.000000000","message":"Why remove the \u0027key_name\u0027?","commit_id":"8fd2e960f77580e26702fd323c6d6992eac21894"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"7b147224f4a950f44f120c3967a5722f9f72d5da","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      config_drive: true"},{"line_number":13,"context_line":"      flavor: m1.tiny"},{"line_number":14,"context_line":"      image: cirros-0.3.4-x86_64-uec"},{"line_number":15,"context_line":"      key_name: keyName"},{"line_number":16,"context_line":"      metadata: {param0: key0, param1: key1}"},{"line_number":17,"context_line":"      networks:"},{"line_number":18,"context_line":"      - port: {get_resource: vdu1-net_mgmt-port}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a9d85d2_affc3f3f","side":"PARENT","line":15,"in_reply_to":"5a9d85d2_81d15cfe","updated":"2016-06-20 09:03:33.000000000","message":"as its not mandatory property of vdu, removed it and its being tested with one of the other templates and find its redundant. so i have removed it. It also helped scale test cases, but this should not be part of this patch. i will move out from this. thanks.","commit_id":"8fd2e960f77580e26702fd323c6d6992eac21894"}],"tacker/vm/infra_drivers/heat/heat.py":[{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"64f0743d6f77293d66c7c8536cd844a6575e24fb","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.IntOpt(\u0027scale_cooldown\u0027,"},{"line_number":51,"context_line":"               default\u003d60,"},{"line_number":52,"context_line":"               help\u003d_(\"Wait time (in seconds) between consecutive scaling\""},{"line_number":53,"context_line":"                      \"operations. During the cooldown period, scaling action\""},{"line_number":54,"context_line":"                      \" will be ignored by tacker\")),"},{"line_number":55,"context_line":"]"},{"line_number":56,"context_line":"CONF.register_opts(OPTS, group\u003d\u0027tacker_heat\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_e164a04a","line":53,"updated":"2016-06-20 07:52:23.000000000","message":"Need a space at the head of this line.\n\nI still think \u0027scale_cooldown\u0027 should be configured in template file, since it is not a definite value.","commit_id":"c026445619ea8102a51c59e246c373f1daf12b5a"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"7b147224f4a950f44f120c3967a5722f9f72d5da","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.IntOpt(\u0027scale_cooldown\u0027,"},{"line_number":51,"context_line":"               default\u003d60,"},{"line_number":52,"context_line":"               help\u003d_(\"Wait time (in seconds) between consecutive scaling\""},{"line_number":53,"context_line":"                      \"operations. During the cooldown period, scaling action\""},{"line_number":54,"context_line":"                      \" will be ignored by tacker\")),"},{"line_number":55,"context_line":"]"},{"line_number":56,"context_line":"CONF.register_opts(OPTS, group\u003d\u0027tacker_heat\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_0f5f5373","line":53,"in_reply_to":"5a9d85d2_e164a04a","updated":"2016-06-20 09:03:33.000000000","message":"sure i will fix the space. And i felt its ok to keep it as configurable now and in future if need arise, we could move this to tosca def.","commit_id":"c026445619ea8102a51c59e246c373f1daf12b5a"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"82296e8c780cf05c5870e65f87b28deae42a48ba","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        attributes \u003d device[\u0027device_template\u0027][\u0027attributes\u0027].copy()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        vnfd_yaml \u003d attributes.pop(\u0027vnfd\u0027, None)"},{"line_number":259,"context_line":"        if vnfd_yaml is None:"},{"line_number":260,"context_line":"            # TODO(kangaraj-manickam) raise user level exception"},{"line_number":261,"context_line":"            LOG.info(_(\"VNFD is not provided, so no device is created !!\"))"},{"line_number":262,"context_line":"            return"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        LOG.debug(\u0027vnfd_yaml %s\u0027, vnfd_yaml)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        def update_fields():"},{"line_number":267,"context_line":"            fields \u003d dict((key, attributes.pop(key)) for key"}],"source_content_type":"text/x-python","patch_set":13,"id":"1aa78d24_2f281c33","line":264,"range":{"start_line":259,"start_character":8,"end_line":264,"end_character":44},"updated":"2016-07-14 23:30:58.000000000","message":"better to handle this case in vnfd workflow than validating during vnf create","commit_id":"e1ee2ac9d73e5b5f0e0e284065a29d6bf66dee69"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"c18a1fae32572afd2978f36636b19cdf7d989f97","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        attributes \u003d device[\u0027device_template\u0027][\u0027attributes\u0027].copy()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        vnfd_yaml \u003d attributes.pop(\u0027vnfd\u0027, None)"},{"line_number":259,"context_line":"        if vnfd_yaml is None:"},{"line_number":260,"context_line":"            # TODO(kangaraj-manickam) raise user level exception"},{"line_number":261,"context_line":"            LOG.info(_(\"VNFD is not provided, so no device is created !!\"))"},{"line_number":262,"context_line":"            return"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        LOG.debug(\u0027vnfd_yaml %s\u0027, vnfd_yaml)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        def update_fields():"},{"line_number":267,"context_line":"            fields \u003d dict((key, attributes.pop(key)) for key"}],"source_content_type":"text/x-python","patch_set":13,"id":"1aa78d24_b17bcbbd","line":264,"range":{"start_line":259,"start_character":8,"end_line":264,"end_character":44},"in_reply_to":"1aa78d24_2f281c33","updated":"2016-07-15 02:27:29.000000000","message":"Its an refactored code and nothing new i have added here.\nand its ok check for this case in driver as well, because driver should make sure the required things are in place before starting the action.\n\nin the workflow, this thing would have been taken care already. on the other words, this situation would never occur, i believe.\n\nso i feel its ok to go with this patch.","commit_id":"e1ee2ac9d73e5b5f0e0e284065a29d6bf66dee69"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"c23c5f6a29063f75ff98f9ebd7bc62ef4ad9b318","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        attributes \u003d device[\u0027device_template\u0027][\u0027attributes\u0027].copy()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        vnfd_yaml \u003d attributes.pop(\u0027vnfd\u0027, None)"},{"line_number":259,"context_line":"        if vnfd_yaml is None:"},{"line_number":260,"context_line":"            # TODO(kangaraj-manickam) raise user level exception"},{"line_number":261,"context_line":"            LOG.info(_(\"VNFD is not provided, so no device is created !!\"))"},{"line_number":262,"context_line":"            return"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        LOG.debug(\u0027vnfd_yaml %s\u0027, vnfd_yaml)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        def update_fields():"},{"line_number":267,"context_line":"            fields \u003d dict((key, attributes.pop(key)) for key"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_f83434df","line":264,"range":{"start_line":259,"start_character":8,"end_line":264,"end_character":44},"in_reply_to":"1aa78d24_b17bcbbd","updated":"2016-07-18 17:23:36.000000000","message":"yes this would never occur, as the info is read from the db using vnfd id.  we can keep this for now as this is refactoring existing code. but we should handle this in vnfd create and validate it in that operation.","commit_id":"e1ee2ac9d73e5b5f0e0e284065a29d6bf66dee69"}]}