)]}'
{"tacker/db/nfvo/nfvo_db.py":[{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"9a6f426dff0b9f5c2fe23985c38b11ab224eb8e6","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        res[\u0027vim_project\u0027] \u003d vim_auth_db[0].vim_project"},{"line_number":74,"context_line":"        res[\u0027auth_cred\u0027] \u003d vim_auth_db[0].auth_cred"},{"line_number":75,"context_line":"        res[\u0027auth_cred\u0027][\u0027password\u0027] \u003d vim_auth_db[0].password"},{"line_number":76,"context_line":"        res \u003d strutils.mask_dict_password(res)"},{"line_number":77,"context_line":"        return self._fields(res, fields)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _fields(self, resource, fields):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_96815792","line":76,"range":{"start_line":76,"start_character":14,"end_line":76,"end_character":41},"updated":"2016-06-28 19:06:06.000000000","message":"get_vim and get_vim_by_name are invoked by tacker plugin to fetch vim info. so we shouldn\u0027t be masking the password for internal calls.","commit_id":"d082cb8d056edaf11251eb4ca1f56679ebc45148"},{"author":{"_account_id":12455,"name":"bharaththiruveedula","email":"bharath_ves@hotmail.com","username":"bharaththiruveedula"},"change_message_id":"4cc3815bf8beef5dfd553405179b0091b4e855a3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        res[\u0027auth_cred\u0027] \u003d vim_auth_db[0].auth_cred"},{"line_number":75,"context_line":"        res[\u0027auth_cred\u0027][\u0027password\u0027] \u003d vim_auth_db[0].password"},{"line_number":76,"context_line":"        if mask_password:"},{"line_number":77,"context_line":"            res \u003d strutils.mask_dict_password(res)"},{"line_number":78,"context_line":"        return self._fields(res, fields)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _fields(self, resource, fields):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_bcc4765f","line":77,"range":{"start_line":77,"start_character":12,"end_line":77,"end_character":50},"updated":"2016-07-08 10:10:37.000000000","message":"Can you please change the above line to \"res[\u0027auth_cred\u0027] \u003d  strutils.mask_dict_password(res[\u0027auth_cred\u0027])\". Because if you use make_dict_password(res), it will remove None value keys like \"placement_attr\". But we are asserting for \"placement_attr\" value in create_vim unit test.Thanks","commit_id":"b02d89b0694c874c797e13a1bea0b1272bbeb911"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"c72ebdc05dafee29804d6765ad90f36e5e3fd16e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        res[\u0027auth_cred\u0027] \u003d vim_auth_db[0].auth_cred"},{"line_number":75,"context_line":"        res[\u0027auth_cred\u0027][\u0027password\u0027] \u003d vim_auth_db[0].password"},{"line_number":76,"context_line":"        if mask_password:"},{"line_number":77,"context_line":"            res \u003d strutils.mask_dict_password(res)"},{"line_number":78,"context_line":"        return self._fields(res, fields)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _fields(self, resource, fields):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_ba30f6e9","line":77,"range":{"start_line":77,"start_character":12,"end_line":77,"end_character":50},"in_reply_to":"1aa78d24_bcc4765f","updated":"2016-07-08 10:36:36.000000000","message":"Yes right,\nSo it failing as oslo has bug in mask_dict_password which remove the key with value other than string and dict or password related.\n\nI have logged bug [1] and pushed patch for that fix [2]\n\neither we should make this patch depends on that or wait till oslo fix gets merged\n\nbut also we should wait till new oslo release so that it would fail with old oslo on our requirement.txt\n\n[1]: https://bugs.launchpad.net/oslo.utils/+bug/1600168\n\n[2]: https://review.openstack.org/#/c/339450/","commit_id":"b02d89b0694c874c797e13a1bea0b1272bbeb911"}],"tacker/tests/unit/vm/nfvo/test_nfvo_plugin.py":[{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"2db8db3d772eb9e3618f257e76deda7abfe76d1b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.assertIn(\u0027placement_attr\u0027, res)"},{"line_number":117,"context_line":"        self.assertEqual(vim_project, res[\u0027vim_project\u0027])"},{"line_number":118,"context_line":"        self.assertEqual(vim_auth_username, res[\u0027auth_cred\u0027][\u0027username\u0027])"},{"line_number":119,"context_line":"        self.assertNotEqual(vim_auth_password, res[\u0027auth_cred\u0027][\u0027password\u0027])"},{"line_number":120,"context_line":"        self.assertEqual(SECRET_PASSWORD, res[\u0027auth_cred\u0027][\u0027password\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_9fb9c3ce","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":76},"updated":"2016-07-07 22:37:17.000000000","message":"this is redundant","commit_id":"1e56714a187032fc87805092f60cd6eab7c142f3"},{"author":{"_account_id":22369,"name":"Anshu Kumar","email":"anshu.choubey@imaginea.com","username":"anshu.kch"},"change_message_id":"90a83e93ab889b997a636a450f3dfff3ce4b9b65","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.assertIn(\u0027placement_attr\u0027, res)"},{"line_number":117,"context_line":"        self.assertEqual(vim_project, res[\u0027vim_project\u0027])"},{"line_number":118,"context_line":"        self.assertEqual(vim_auth_username, res[\u0027auth_cred\u0027][\u0027username\u0027])"},{"line_number":119,"context_line":"        self.assertNotEqual(vim_auth_password, res[\u0027auth_cred\u0027][\u0027password\u0027])"},{"line_number":120,"context_line":"        self.assertEqual(SECRET_PASSWORD, res[\u0027auth_cred\u0027][\u0027password\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e3102dae","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":76},"in_reply_to":"1aa78d24_9fb9c3ce","updated":"2016-07-08 04:35:20.000000000","message":"Done. I retained it for the sake of thought flow that the password is not equal to the original password but it\u0027s a secret. Will remove it.","commit_id":"1e56714a187032fc87805092f60cd6eab7c142f3"}],"tacker/vm/vim_client.py":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"e5c878bac921e52e40c7e366da42504e6887d2cf","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                raise nfvo.VimDefaultNameNotDefined()"},{"line_number":52,"context_line":"            try:"},{"line_number":53,"context_line":"                vim_info \u003d nfvo_plugin.get_vim_by_name(context, vim_name,"},{"line_number":54,"context_line":"                                                       mask_password\u003dFalse)"},{"line_number":55,"context_line":"            except Exception:"},{"line_number":56,"context_line":"                    raise nfvo.VimDefaultIdException("},{"line_number":57,"context_line":"                        vim_name\u003dvim_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_209fd051","line":54,"range":{"start_line":54,"start_character":55,"end_line":54,"end_character":74},"updated":"2016-07-08 00:17:56.000000000","message":"Why default mask_password is False?\nCan we make it True?","commit_id":"1e56714a187032fc87805092f60cd6eab7c142f3"},{"author":{"_account_id":22369,"name":"Anshu Kumar","email":"anshu.choubey@imaginea.com","username":"anshu.kch"},"change_message_id":"90a83e93ab889b997a636a450f3dfff3ce4b9b65","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                raise nfvo.VimDefaultNameNotDefined()"},{"line_number":52,"context_line":"            try:"},{"line_number":53,"context_line":"                vim_info \u003d nfvo_plugin.get_vim_by_name(context, vim_name,"},{"line_number":54,"context_line":"                                                       mask_password\u003dFalse)"},{"line_number":55,"context_line":"            except Exception:"},{"line_number":56,"context_line":"                    raise nfvo.VimDefaultIdException("},{"line_number":57,"context_line":"                        vim_name\u003dvim_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_03ec598e","line":54,"range":{"start_line":54,"start_character":55,"end_line":54,"end_character":74},"in_reply_to":"1aa78d24_209fd051","updated":"2016-07-08 04:35:20.000000000","message":"These calls are used internally by tacker to get vim information. We shouldn\u0027t mask passwords then. Thus the invocation requires the flag to be False. Thanks.","commit_id":"1e56714a187032fc87805092f60cd6eab7c142f3"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"e5c878bac921e52e40c7e366da42504e6887d2cf","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            try:"},{"line_number":60,"context_line":"                vim_info \u003d nfvo_plugin.get_vim(context, vim_id,"},{"line_number":61,"context_line":"                                               mask_password\u003dFalse)"},{"line_number":62,"context_line":"            except Exception:"},{"line_number":63,"context_line":"                raise nfvo.VimNotFoundException(vim_id\u003dvim_id)"},{"line_number":64,"context_line":"        LOG.debug(_(\u0027VIM info found for vim id %s\u0027), vim_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_60a9d87b","line":61,"range":{"start_line":61,"start_character":47,"end_line":61,"end_character":67},"updated":"2016-07-08 00:17:56.000000000","message":"same","commit_id":"1e56714a187032fc87805092f60cd6eab7c142f3"},{"author":{"_account_id":22369,"name":"Anshu Kumar","email":"anshu.choubey@imaginea.com","username":"anshu.kch"},"change_message_id":"90a83e93ab889b997a636a450f3dfff3ce4b9b65","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            try:"},{"line_number":60,"context_line":"                vim_info \u003d nfvo_plugin.get_vim(context, vim_id,"},{"line_number":61,"context_line":"                                               mask_password\u003dFalse)"},{"line_number":62,"context_line":"            except Exception:"},{"line_number":63,"context_line":"                raise nfvo.VimNotFoundException(vim_id\u003dvim_id)"},{"line_number":64,"context_line":"        LOG.debug(_(\u0027VIM info found for vim id %s\u0027), vim_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_43fe6139","line":61,"range":{"start_line":61,"start_character":47,"end_line":61,"end_character":67},"in_reply_to":"1aa78d24_60a9d87b","updated":"2016-07-08 04:35:20.000000000","message":"same","commit_id":"1e56714a187032fc87805092f60cd6eab7c142f3"}]}