)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"3facebdbc39266b7b86c170d5766129d3c1bdad1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sridhar Ramaswamy \u003csrics.r@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-05 02:19:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add python-tackerclient to requirements.txt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-tackerclient is now available in global"},{"line_number":10,"context_line":"requirements [1]. Moving to use pip dependency"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_8297678f","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":43},"updated":"2016-07-05 03:28:33.000000000","message":"requirements.txt --\u003e test-requirements.txt","commit_id":"3f9c64f9e385764d8a9b1193bff421c9799101b8"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"3715325e459f232e153fce6b5299fa6c87b02374","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sridhar Ramaswamy \u003csrics.r@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-05 02:19:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add python-tackerclient to requirements.txt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-tackerclient is now available in global"},{"line_number":10,"context_line":"requirements [1]. Moving to use pip dependency"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_9b550e52","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":43},"in_reply_to":"1aa78d24_8297678f","updated":"2016-07-05 06:07:01.000000000","message":"Done","commit_id":"3f9c64f9e385764d8a9b1193bff421c9799101b8"}],"devstack/lib/tacker":[{"author":{"_account_id":18225,"name":"Shaik Apsar","email":"sa709c@intl.att.com","username":"sa709c"},"change_message_id":"3a02bb8446b2217fb278abddd5e03a445267ae1b","unresolved":false,"context_lines":[{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"# install_tackerclient() - Collect source and prepare"},{"line_number":155,"context_line":"function install_tackerclient {"},{"line_number":156,"context_line":"    if use_library_from_git \"python-tackerclient\"; then"},{"line_number":157,"context_line":"        git_clone_by_name \"python-tackerclient\""},{"line_number":158,"context_line":"        setup_dev_lib \"python-tackerclient\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1aa78d24_7bc5bd3a","side":"PARENT","line":155,"updated":"2016-07-05 08:04:08.000000000","message":"I think we should not remove the tackerclient since it\u0027s not part of tacker. We are adding tackerclient to test-requirement. P","commit_id":"c3fd989eff488f9171a9a805877ab48cf187747e"}],"requirements.txt":[{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"437a83fefd3fdc826a436664dd8f31d13ff6931d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"WebOb\u003e\u003d1.2.3 # MIT"},{"line_number":22,"context_line":"python-heatclient\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":23,"context_line":"python-keystoneclient!\u003d1.8.0,!\u003d2.1.0,\u003e\u003d1.7.0 # Apache-2.0"},{"line_number":24,"context_line":"python-tackerclient\u003e\u003d0.4.0 # Apache-2.0"},{"line_number":25,"context_line":"alembic\u003e\u003d0.8.4 # MIT"},{"line_number":26,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":27,"context_line":"stevedore\u003e\u003d1.10.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"3aaa91ec_1db2f406","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":39},"updated":"2016-07-01 17:40:15.000000000","message":"shouldn\u0027t we add this to test-requirements.txt?","commit_id":"a37986715170c60c880e3e9cc4b1b8cb8a188599"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"5b7563ef89915d2c6091561726f9f51c96011303","unresolved":false,"context_lines":[{"line_number":21,"context_line":"WebOb\u003e\u003d1.2.3 # MIT"},{"line_number":22,"context_line":"python-heatclient\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":23,"context_line":"python-keystoneclient!\u003d1.8.0,!\u003d2.1.0,\u003e\u003d1.7.0 # Apache-2.0"},{"line_number":24,"context_line":"python-tackerclient\u003e\u003d0.4.0 # Apache-2.0"},{"line_number":25,"context_line":"alembic\u003e\u003d0.8.4 # MIT"},{"line_number":26,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":27,"context_line":"stevedore\u003e\u003d1.10.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"1aa78d24_6bd882f0","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":39},"in_reply_to":"1aa78d24_2e77c7d5","updated":"2016-07-04 07:06:02.000000000","message":"Sridhar, I also think that tackerclient should be in test-requirements.txt as tacker server does not use the tackerclient. But its not an blocker as you have mentioned test already picking it.","commit_id":"a37986715170c60c880e3e9cc4b1b8cb8a188599"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"98ed7ed4f5a4bc730a0e5f228f364ada7b615e8b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"WebOb\u003e\u003d1.2.3 # MIT"},{"line_number":22,"context_line":"python-heatclient\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":23,"context_line":"python-keystoneclient!\u003d1.8.0,!\u003d2.1.0,\u003e\u003d1.7.0 # Apache-2.0"},{"line_number":24,"context_line":"python-tackerclient\u003e\u003d0.4.0 # Apache-2.0"},{"line_number":25,"context_line":"alembic\u003e\u003d0.8.4 # MIT"},{"line_number":26,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":27,"context_line":"stevedore\u003e\u003d1.10.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"1aa78d24_9efec569","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":39},"in_reply_to":"1aa78d24_6bd882f0","updated":"2016-07-04 09:04:17.000000000","message":"Yes, it should be only in test_requirement.txt \n\ntests env always copy requirement.txt to test_requirement.txt so no issue in current changes and can be fixed in follow up patch.\n\nAgree to merge this as it fix gate issue.","commit_id":"a37986715170c60c880e3e9cc4b1b8cb8a188599"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"79cadbee315a121fd2ce25e9d56d9dc24414f762","unresolved":false,"context_lines":[{"line_number":21,"context_line":"WebOb\u003e\u003d1.2.3 # MIT"},{"line_number":22,"context_line":"python-heatclient\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":23,"context_line":"python-keystoneclient!\u003d1.8.0,!\u003d2.1.0,\u003e\u003d1.7.0 # Apache-2.0"},{"line_number":24,"context_line":"python-tackerclient\u003e\u003d0.4.0 # Apache-2.0"},{"line_number":25,"context_line":"alembic\u003e\u003d0.8.4 # MIT"},{"line_number":26,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":27,"context_line":"stevedore\u003e\u003d1.10.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"1aa78d24_2e77c7d5","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":39},"in_reply_to":"3aaa91ec_1db2f406","updated":"2016-07-01 23:20:58.000000000","message":"No, this needs to go into the main requirements.txt, as seen in [1]. Tests pull in both requirements.txt and test-requirements.txt, so they are covered.\n\n[1] https://github.com/openstack/neutron/blob/master/requirements.txt","commit_id":"a37986715170c60c880e3e9cc4b1b8cb8a188599"}]}