)]}'
{"tacker/db/nfvo/nfvo_db.py":[{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"af027bf86569618518241a98ebde8d2359763b3e","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        except orm_exc.NoResultFound:"},{"line_number":162,"context_line":"            if issubclass(model, Vim):"},{"line_number":163,"context_line":"                raise"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def create_vnffg(self, context, vnffg):"},{"line_number":166,"context_line":"        raise NotImplementedError"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_a36c4ed1","line":164,"updated":"2016-07-14 09:52:06.000000000","message":"Now, that nfvo is branching out beyond vim, can we move these vnffg / sfc methods to a separate base class, say nfvo_vnffg_db.py, and derive it in NfvoPluginDb at L59 above ?","commit_id":"eaba5fb1386fc6ef3b4db65e1214067ef3250652"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"967e427e017d944a293774a9783d1d9aadd1d84c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        except orm_exc.NoResultFound:"},{"line_number":162,"context_line":"            if issubclass(model, Vim):"},{"line_number":163,"context_line":"                raise"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def create_vnffg(self, context, vnffg):"},{"line_number":166,"context_line":"        raise NotImplementedError"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_54070781","line":164,"in_reply_to":"1aa78d24_276cdc35","updated":"2016-07-14 18:17:02.000000000","message":"yes, vim definitions need to go out of nfvo, but i think we should retain vnffg in nfvo_db itself, since vnffg is part of nfvo\u0027s life cycle mangement unlike vim. what do you think?","commit_id":"eaba5fb1386fc6ef3b4db65e1214067ef3250652"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"98f446237f4549970201248e4269f6dfd71bc3bc","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        except orm_exc.NoResultFound:"},{"line_number":162,"context_line":"            if issubclass(model, Vim):"},{"line_number":163,"context_line":"                raise"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def create_vnffg(self, context, vnffg):"},{"line_number":166,"context_line":"        raise NotImplementedError"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_a9e6d141","line":164,"in_reply_to":"1aa78d24_54070781","updated":"2016-07-14 19:41:04.000000000","message":"Yes this makes perfect sense to me!","commit_id":"eaba5fb1386fc6ef3b4db65e1214067ef3250652"},{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"fc0d805f572b4994b433cc359aaed6fe3a3308a2","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        except orm_exc.NoResultFound:"},{"line_number":162,"context_line":"            if issubclass(model, Vim):"},{"line_number":163,"context_line":"                raise"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def create_vnffg(self, context, vnffg):"},{"line_number":166,"context_line":"        raise NotImplementedError"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_1b5d9eec","line":164,"in_reply_to":"1aa78d24_54070781","updated":"2016-07-15 01:05:24.000000000","message":"Yes, vim needs to go out in a refactoring patchset (that is out of scope for this patchset). \n\nNow, what I\u0027m suggesting is to leave some good precedence for rest of the NFVO features to slide in as they come in. For e.g. when NSD or future ResourceReservation features comes in, they need not bloat this class / file. Instead, each of them can just slide in. Essentially I\u0027m advocating a \"MixIn\" like approach for both here in the DB and in the Plugin area.","commit_id":"eaba5fb1386fc6ef3b4db65e1214067ef3250652"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"b6cd4d73d036e7151bbb75df7bd7fce128bc41ca","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        except orm_exc.NoResultFound:"},{"line_number":162,"context_line":"            if issubclass(model, Vim):"},{"line_number":163,"context_line":"                raise"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def create_vnffg(self, context, vnffg):"},{"line_number":166,"context_line":"        raise NotImplementedError"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_5b560607","line":164,"in_reply_to":"1aa78d24_a36c4ed1","updated":"2016-07-15 00:45:38.000000000","message":"+1 with Sridhar, to move these methods in separate class. I think it would be clean approach to make life easy.","commit_id":"eaba5fb1386fc6ef3b4db65e1214067ef3250652"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"d3844512294bf0efb2a6e8f84da4e32699346c8a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        except orm_exc.NoResultFound:"},{"line_number":162,"context_line":"            if issubclass(model, Vim):"},{"line_number":163,"context_line":"                raise"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def create_vnffg(self, context, vnffg):"},{"line_number":166,"context_line":"        raise NotImplementedError"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_276cdc35","line":164,"in_reply_to":"1aa78d24_a36c4ed1","updated":"2016-07-14 14:37:38.000000000","message":"That makes sense to me, but then why is VIM still here?","commit_id":"eaba5fb1386fc6ef3b4db65e1214067ef3250652"}],"tacker/extensions/nfvo.py":[{"author":{"_account_id":13380,"name":"Sridhar Ramaswamy","email":"srics.r@gmail.com","username":"srics-r"},"change_message_id":"fc0d805f572b4994b433cc359aaed6fe3a3308a2","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def get_vim_by_name(self, context, vim_name, fields\u003dNone):"},{"line_number":212,"context_line":"        raise NotImplementedError()"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @abc.abstractmethod"},{"line_number":215,"context_line":"    def create_vnffgd(self, context, vnffgd):"},{"line_number":216,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_3b117a05","line":213,"updated":"2016-07-15 01:05:24.000000000","message":"Again, as mentioned for the DB I would suggest you to move these methods off into a separate base class and derive it in L185.","commit_id":"eaba5fb1386fc6ef3b4db65e1214067ef3250652"}]}