)]}'
{"tacker/nfvo/drivers/vnffg/abstract_driver.py":[{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"0b3acd83913e3006eed04a56056eead3c5800d8b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        pass"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def create_chain(self, fc_id, vnfs, auth_attr\u003dNone):"},{"line_number":39,"context_line":"        \"\"\"Create service function chain and returns an ID\"\"\""},{"line_number":40,"context_line":"        pass"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_a81d6568","line":38,"range":{"start_line":38,"start_character":27,"end_line":38,"end_character":32},"updated":"2016-08-08 14:48:18.000000000","message":"Why do you need to have the fc_id here when creating a chain?  It seems like this means that the classifier must be created before the chain is created, which seems backwards to me.  Chain should just need to be created, then a classifier when it is created needs the chain id that it applies to.","commit_id":"de8946edbf8be7c1e62c1486d55a4747e78e872f"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"cfdb15b01b7b8a11c62273d43f72d42c0c6e313b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        pass"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def create_chain(self, fc_id, vnfs, auth_attr\u003dNone):"},{"line_number":39,"context_line":"        \"\"\"Create service function chain and returns an ID\"\"\""},{"line_number":40,"context_line":"        pass"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_b10029ac","line":38,"range":{"start_line":38,"start_character":27,"end_line":38,"end_character":32},"in_reply_to":"9ad45d7e_a81d6568","updated":"2016-08-08 17:27:54.000000000","message":"This should be a list of fc_ids as in update_chain. It could be an empty list.","commit_id":"de8946edbf8be7c1e62c1486d55a4747e78e872f"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"ec7974b93b9e44a1aa2219bf3bfd090cb124c2ff","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        pass"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def create_chain(self, fc_id, vnfs, auth_attr\u003dNone):"},{"line_number":39,"context_line":"        \"\"\"Create service function chain and returns an ID\"\"\""},{"line_number":40,"context_line":"        pass"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_59434f42","line":38,"range":{"start_line":38,"start_character":27,"end_line":38,"end_character":32},"in_reply_to":"9ad45d7e_aa087dda","updated":"2016-08-10 20:03:11.000000000","message":"in networking-sfc the reference is from the port-chain to the classifier. A port-chain can have multiple classifiers as long as they are not used by any other port-chain.","commit_id":"de8946edbf8be7c1e62c1486d55a4747e78e872f"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"23cbd3052133ae96505efe0326dc32edb3e04a70","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        pass"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def create_chain(self, fc_id, vnfs, auth_attr\u003dNone):"},{"line_number":39,"context_line":"        \"\"\"Create service function chain and returns an ID\"\"\""},{"line_number":40,"context_line":"        pass"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_aa087dda","line":38,"range":{"start_line":38,"start_character":27,"end_line":38,"end_character":32},"in_reply_to":"9ad45d7e_b10029ac","updated":"2016-08-09 14:59:10.000000000","message":"I see.  My question is more geared to the design.  In networking-sfc it appears that the model is chain is created and mapped to classifier(s).  Rather than the other way around(when a classifier is create it is associated to a chain).  Is this correct?  The latter is the way ODL does it.  It\u0027s fine if we keep things this way, I just want to make sure I understand this correctly and we will need to keep it in mind when writing the networking-odl driver.","commit_id":"de8946edbf8be7c1e62c1486d55a4747e78e872f"}],"tacker/nfvo/drivers/vnffg/sfc_drivers/abstract_driver.py":[{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"fad263af775dcad7a8e9489ed010129f6d33d163","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        pass"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def create_chain(self, fc_id, vnfs, auth_attr\u003dNone):"},{"line_number":39,"context_line":"        \"\"\"Create service function chain and returns an ID\"\"\""},{"line_number":40,"context_line":"        pass"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_8e83ff55","line":38,"range":{"start_line":38,"start_character":27,"end_line":38,"end_character":32},"updated":"2016-08-09 18:58:47.000000000","message":"should this be fc_ids?","commit_id":"1129abd0c34e4f3bf8f51a4cd60bec81e0a8d617"}]}