)]}'
{"tacker/vm/infra_drivers/heat/heat.py":[{"author":{"_account_id":12455,"name":"bharaththiruveedula","email":"bharath_ves@hotmail.com","username":"bharaththiruveedula"},"change_message_id":"02bcb959b86002f7d5b49d24edf7f0119405d396","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                name, mon_policy_dict \u003d mon_policy.items()[0]"},{"line_number":459,"context_line":"                tpl_trigger_name \u003d \\"},{"line_number":460,"context_line":"                    mon_policy_dict[\u0027triggers\u0027][\u0027resize_compute\u0027]"},{"line_number":461,"context_line":"                tpl_condition \u003d tpl_trigger_name[\u0027condition\u0027]"},{"line_number":462,"context_line":"                properties \u003d {}"},{"line_number":463,"context_line":"                properties[\u0027meter_name\u0027] \u003d tpl_trigger_name[\u0027metrics\u0027]"},{"line_number":464,"context_line":"                properties[\u0027comparison_operator\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_caf34d09","line":461,"updated":"2016-08-09 14:06:06.000000000","message":"As \"condition\" is not a required property according to https://review.openstack.org/#/c/351189/4/tacker/vm/tosca/lib/tacker_defs.yaml, so we need validation for this?","commit_id":"c3b7ce114bf731a2050ee95b6bef0d9a20e112f7"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"653002934873055d166204e2c227791d13578b4c","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                name, mon_policy_dict \u003d mon_policy.items()[0]"},{"line_number":459,"context_line":"                tpl_trigger_name \u003d \\"},{"line_number":460,"context_line":"                    mon_policy_dict[\u0027triggers\u0027][\u0027resize_compute\u0027]"},{"line_number":461,"context_line":"                tpl_condition \u003d tpl_trigger_name[\u0027condition\u0027]"},{"line_number":462,"context_line":"                properties \u003d {}"},{"line_number":463,"context_line":"                properties[\u0027meter_name\u0027] \u003d tpl_trigger_name[\u0027metrics\u0027]"},{"line_number":464,"context_line":"                properties[\u0027comparison_operator\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_05ad2c31","line":461,"in_reply_to":"9ad45d7e_caf34d09","updated":"2016-08-16 14:46:21.000000000","message":"will do. Thanks","commit_id":"c3b7ce114bf731a2050ee95b6bef0d9a20e112f7"},{"author":{"_account_id":12455,"name":"bharaththiruveedula","email":"bharath_ves@hotmail.com","username":"bharaththiruveedula"},"change_message_id":"02bcb959b86002f7d5b49d24edf7f0119405d396","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                properties[\u0027meter_name\u0027] \u003d tpl_trigger_name[\u0027metrics\u0027]"},{"line_number":464,"context_line":"                properties[\u0027comparison_operator\u0027] \u003d \\"},{"line_number":465,"context_line":"                    tpl_condition[\u0027comparison_operator\u0027]"},{"line_number":466,"context_line":"                properties[\u0027period\u0027] \u003d tpl_condition[\u0027period\u0027]"},{"line_number":467,"context_line":"                properties[\u0027evaluation_periods\u0027] \u003d tpl_condition[\u0027evaluations\u0027]"},{"line_number":468,"context_line":"                properties[\u0027statistic\u0027] \u003d tpl_condition[\u0027method\u0027]"},{"line_number":469,"context_line":"                properties[\u0027description\u0027] \u003d tpl_condition[\u0027constraint\u0027]"},{"line_number":470,"context_line":"                properties[\u0027threshold\u0027] \u003d tpl_condition[\u0027threshold\u0027]"},{"line_number":471,"context_line":"                # alarm url process here"},{"line_number":472,"context_line":"                mon_driver \u003d \\"},{"line_number":473,"context_line":"                    tpl_trigger_name[\u0027event_type\u0027][\u0027implementation\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_6ad50142","line":470,"range":{"start_line":466,"start_character":16,"end_line":470,"end_character":68},"updated":"2016-08-09 14:06:06.000000000","message":"how do we make sure what are the allowed values for \"condition\"?","commit_id":"c3b7ce114bf731a2050ee95b6bef0d9a20e112f7"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"653002934873055d166204e2c227791d13578b4c","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                properties[\u0027meter_name\u0027] \u003d tpl_trigger_name[\u0027metrics\u0027]"},{"line_number":464,"context_line":"                properties[\u0027comparison_operator\u0027] \u003d \\"},{"line_number":465,"context_line":"                    tpl_condition[\u0027comparison_operator\u0027]"},{"line_number":466,"context_line":"                properties[\u0027period\u0027] \u003d tpl_condition[\u0027period\u0027]"},{"line_number":467,"context_line":"                properties[\u0027evaluation_periods\u0027] \u003d tpl_condition[\u0027evaluations\u0027]"},{"line_number":468,"context_line":"                properties[\u0027statistic\u0027] \u003d tpl_condition[\u0027method\u0027]"},{"line_number":469,"context_line":"                properties[\u0027description\u0027] \u003d tpl_condition[\u0027constraint\u0027]"},{"line_number":470,"context_line":"                properties[\u0027threshold\u0027] \u003d tpl_condition[\u0027threshold\u0027]"},{"line_number":471,"context_line":"                # alarm url process here"},{"line_number":472,"context_line":"                mon_driver \u003d \\"},{"line_number":473,"context_line":"                    tpl_trigger_name[\u0027event_type\u0027][\u0027implementation\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_45f9e44c","line":470,"range":{"start_line":466,"start_character":16,"end_line":470,"end_character":68},"in_reply_to":"9ad45d7e_6ad50142","updated":"2016-08-16 14:46:21.000000000","message":"they should be validated. I will fix. Thanks","commit_id":"c3b7ce114bf731a2050ee95b6bef0d9a20e112f7"},{"author":{"_account_id":12455,"name":"bharaththiruveedula","email":"bharath_ves@hotmail.com","username":"bharaththiruveedula"},"change_message_id":"02bcb959b86002f7d5b49d24edf7f0119405d396","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                mon_driver \u003d \\"},{"line_number":473,"context_line":"                    tpl_trigger_name[\u0027event_type\u0027][\u0027implementation\u0027]"},{"line_number":474,"context_line":"                # TODO(anyone) extend to support any low level design."},{"line_number":475,"context_line":"                whook \u003d Webhook(mon_driver)"},{"line_number":476,"context_line":"                alarm_url \u003d whook.create_alarm_url(name,"},{"line_number":477,"context_line":"                                                   mon_policy_dict, device)"},{"line_number":478,"context_line":"                if alarm_url:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_ddc93e7a","line":475,"updated":"2016-08-09 14:06:06.000000000","message":"qq: Is it the only driver possible?","commit_id":"c3b7ce114bf731a2050ee95b6bef0d9a20e112f7"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"653002934873055d166204e2c227791d13578b4c","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                mon_driver \u003d \\"},{"line_number":473,"context_line":"                    tpl_trigger_name[\u0027event_type\u0027][\u0027implementation\u0027]"},{"line_number":474,"context_line":"                # TODO(anyone) extend to support any low level design."},{"line_number":475,"context_line":"                whook \u003d Webhook(mon_driver)"},{"line_number":476,"context_line":"                alarm_url \u003d whook.create_alarm_url(name,"},{"line_number":477,"context_line":"                                                   mon_policy_dict, device)"},{"line_number":478,"context_line":"                if alarm_url:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_85f2bc6d","line":475,"in_reply_to":"9ad45d7e_ddc93e7a","updated":"2016-08-16 14:46:21.000000000","message":"That\u0027s something I want to do in the future. At the beginning, it will be supported for drivers. The reason is that we can validate the url once driver is used.","commit_id":"c3b7ce114bf731a2050ee95b6bef0d9a20e112f7"},{"author":{"_account_id":12455,"name":"bharaththiruveedula","email":"bharath_ves@hotmail.com","username":"bharaththiruveedula"},"change_message_id":"02bcb959b86002f7d5b49d24edf7f0119405d396","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                        is_enabled_alarm \u003d True"},{"line_number":495,"context_line":"                        heat_dict[\u0027resources\u0027][name] \u003d \\"},{"line_number":496,"context_line":"                            _convert_to_heat_monitoring_resource(policy_dict)"},{"line_number":497,"context_line":"                        break"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"            heat_tpl_yaml \u003d yaml.dump(heat_dict)"},{"line_number":500,"context_line":"            return (is_enabled_alarm,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_4f592f5a","line":497,"range":{"start_line":497,"start_character":23,"end_line":497,"end_character":29},"updated":"2016-08-09 14:06:06.000000000","message":"can\u0027t we have more than one policy of type \"tosca.policies.tacker.Alarming\" ?","commit_id":"c3b7ce114bf731a2050ee95b6bef0d9a20e112f7"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"653002934873055d166204e2c227791d13578b4c","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                        is_enabled_alarm \u003d True"},{"line_number":495,"context_line":"                        heat_dict[\u0027resources\u0027][name] \u003d \\"},{"line_number":496,"context_line":"                            _convert_to_heat_monitoring_resource(policy_dict)"},{"line_number":497,"context_line":"                        break"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"            heat_tpl_yaml \u003d yaml.dump(heat_dict)"},{"line_number":500,"context_line":"            return (is_enabled_alarm,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_2a92cd9f","line":497,"range":{"start_line":497,"start_character":23,"end_line":497,"end_character":29},"in_reply_to":"9ad45d7e_4f592f5a","updated":"2016-08-16 14:46:21.000000000","message":"Totally agree.\nWill fix in the next patchset. Thanks","commit_id":"c3b7ce114bf731a2050ee95b6bef0d9a20e112f7"}]}