)]}'
{"tacker/vm/plugin.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"e0f5d633c45edaf961f5156d90c4ce217717f901","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            yaml.add_representer(collections.OrderedDict,"},{"line_number":151,"context_line":"                                 self.represent_ordereddict,"},{"line_number":152,"context_line":"                                 Dumper\u003dyaml.SafeDumper)"},{"line_number":153,"context_line":"            yaml.add_representer(dict, self.represent_ordereddict,"},{"line_number":154,"context_line":"                                 Dumper\u003dyaml.SafeDumper)"},{"line_number":155,"context_line":"            vnfd_data[\u0027attributes\u0027][\u0027vnfd\u0027] \u003d yaml.dump("},{"line_number":156,"context_line":"                collections.OrderedDict(template), Dumper\u003dyaml.SafeDumper)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_8272e40f","line":153,"range":{"start_line":153,"start_character":37,"end_line":153,"end_character":38},"updated":"2016-09-01 05:16:21.000000000","message":"no need for the dict since we will OrderedDict it at line 156.","commit_id":"60beb53c6d658c7422275dfe95c73782a88a7842"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"58e1ebe88db1f080d82673dfa14d7be870b17b2a","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            yaml.add_representer(dict, self.represent_ordereddict,"},{"line_number":154,"context_line":"                                 Dumper\u003dyaml.SafeDumper)"},{"line_number":155,"context_line":"            vnfd_data[\u0027attributes\u0027][\u0027vnfd\u0027] \u003d yaml.dump("},{"line_number":156,"context_line":"                collections.OrderedDict(template), Dumper\u003dyaml.SafeDumper)"},{"line_number":157,"context_line":"        elif isinstance(template, str):"},{"line_number":158,"context_line":"            self._report_deprecated_yaml_str()"},{"line_number":159,"context_line":"        if \"tosca_definitions_version\" not in template:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_2b773bd5","line":156,"range":{"start_line":156,"start_character":48,"end_line":156,"end_character":50},"updated":"2016-09-01 02:24:00.000000000","message":"if we have https://review.openstack.org/#/c/363352/, do we still need this?\n\nwe had better to put the ordered stuff into one, and have some test cases.","commit_id":"60beb53c6d658c7422275dfe95c73782a88a7842"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"ba776fe3512624e471b51b708227d4074c12f468","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            yaml.add_representer(dict, self.represent_ordereddict,"},{"line_number":154,"context_line":"                                 Dumper\u003dyaml.SafeDumper)"},{"line_number":155,"context_line":"            vnfd_data[\u0027attributes\u0027][\u0027vnfd\u0027] \u003d yaml.dump("},{"line_number":156,"context_line":"                collections.OrderedDict(template), Dumper\u003dyaml.SafeDumper)"},{"line_number":157,"context_line":"        elif isinstance(template, str):"},{"line_number":158,"context_line":"            self._report_deprecated_yaml_str()"},{"line_number":159,"context_line":"        if \"tosca_definitions_version\" not in template:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_576c209c","line":156,"range":{"start_line":156,"start_character":48,"end_line":156,"end_character":50},"in_reply_to":"fa7ab95a_2b773bd5","updated":"2016-09-01 04:23:11.000000000","message":"https://review.openstack.org/#/c/363352/ is fixing the ordering of ports on the instance by introducing a new feature that allows user to provide the interfaces order for the VNF. this patch is fixing the user side of template view which is mangled up but does not break functionality. IMO, let us not merge the 2 since they are fixing separate things and also easier to revert if it is breaking any current functionality. will add test case.","commit_id":"60beb53c6d658c7422275dfe95c73782a88a7842"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"e0f5d633c45edaf961f5156d90c4ce217717f901","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            yaml.add_representer(dict, self.represent_ordereddict,"},{"line_number":154,"context_line":"                                 Dumper\u003dyaml.SafeDumper)"},{"line_number":155,"context_line":"            vnfd_data[\u0027attributes\u0027][\u0027vnfd\u0027] \u003d yaml.dump("},{"line_number":156,"context_line":"                collections.OrderedDict(template), Dumper\u003dyaml.SafeDumper)"},{"line_number":157,"context_line":"        elif isinstance(template, str):"},{"line_number":158,"context_line":"            self._report_deprecated_yaml_str()"},{"line_number":159,"context_line":"        if \"tosca_definitions_version\" not in template:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_624ec0c2","line":156,"range":{"start_line":156,"start_character":48,"end_line":156,"end_character":50},"in_reply_to":"fa7ab95a_576c209c","updated":"2016-09-01 05:16:21.000000000","message":"template should be sorted according to CP order introduced by https://review.openstack.org/#/c/363352/","commit_id":"60beb53c6d658c7422275dfe95c73782a88a7842"}]}