)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"dbbe3bd2b48faf10f399eec51edd0e3501fb821f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"2. Add functional test for alarm monitor"},{"line_number":12,"context_line":"3. Refactor tosca template for alarm monitor"},{"line_number":13,"context_line":"4. Support scaling in/out at the same time"},{"line_number":14,"context_line":"5. Support multiple policies"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-bug: #1630614"},{"line_number":17,"context_line":"Change-Id: Ic5d0046d0dc0b4381713bda01c485cecae17abea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa6399be_70691f25","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":10},"updated":"2016-10-12 14:45:00.000000000","message":"Depends-On: I141128d8d1079d61820b48a5dde4af24a6ee4654\nsince it is a cross project dependency","commit_id":"47b543edad81a4eb9b38f668458251ecc0b01474"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"02bcf9adb4ebb54d4608162f371930740fc8e9f3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"2. Add functional test for alarm monitor"},{"line_number":12,"context_line":"3. Refactor tosca template for alarm monitor"},{"line_number":13,"context_line":"4. Support scaling in/out at the same time"},{"line_number":14,"context_line":"5. Support multiple policies"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-bug: #1630614"},{"line_number":17,"context_line":"Change-Id: Ic5d0046d0dc0b4381713bda01c485cecae17abea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa6399be_a05c2cee","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":28},"updated":"2016-10-13 01:56:18.000000000","message":"i did not see the related code to handle multiple policies in plugin. also it is better to split this patch intro granular patches.","commit_id":"47b543edad81a4eb9b38f668458251ecc0b01474"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"03514b1f790129ce03e204bc98f3620ec7c36d5f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"2. Add functional test for alarm monitor"},{"line_number":12,"context_line":"3. Refactor tosca template for alarm monitor"},{"line_number":13,"context_line":"4. Support scaling in/out at the same time"},{"line_number":14,"context_line":"5. Support multiple policies"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-bug: #1630614"},{"line_number":17,"context_line":"Change-Id: Ic5d0046d0dc0b4381713bda01c485cecae17abea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa6399be_e25621d1","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":28},"in_reply_to":"fa6399be_a05c2cee","updated":"2016-10-13 12:00:54.000000000","message":"will move this one out of this patch and will create new patch later.","commit_id":"47b543edad81a4eb9b38f668458251ecc0b01474"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"4285a7560977f320565548f92893647cf11a7519","unresolved":false,"context_lines":[{"line_number":11,"context_line":"2. Add functional test for alarm monitor"},{"line_number":12,"context_line":"3. Refactor tosca template for alarm monitor"},{"line_number":13,"context_line":"4. Support scaling in/out at the same time"},{"line_number":14,"context_line":"5. Support multiple policies"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-bug: #1630614"},{"line_number":17,"context_line":"Change-Id: Ic5d0046d0dc0b4381713bda01c485cecae17abea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa6399be_36df6d0e","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":28},"in_reply_to":"fa6399be_e25621d1","updated":"2016-10-13 13:50:22.000000000","message":"Done","commit_id":"47b543edad81a4eb9b38f668458251ecc0b01474"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"ea2cc9fdac57b630ea4b4e3644ba9ab1b2fafc1e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     doantungbk \u003cdoantungbk.203@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-13 11:46:49 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RFE: Alarm monitor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will focus on:"},{"line_number":10,"context_line":"1. Fix hardcoded vdu"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa6399be_da6481ba","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":18},"updated":"2016-10-14 01:41:51.000000000","message":"this is a very abstract title. please modify this to something more specific to the patch.","commit_id":"1f08856ab53387b159a996b074b405f175b203d3"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"f680af02f17c59d2a1d4370fb259177382d91332","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     doantungbk \u003cdoantungbk.203@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-13 11:46:49 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RFE: Alarm monitor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will focus on:"},{"line_number":10,"context_line":"1. Fix hardcoded vdu"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa6399be_a196b9ed","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":18},"in_reply_to":"fa6399be_da6481ba","updated":"2016-10-14 02:59:34.000000000","message":"Done","commit_id":"1f08856ab53387b159a996b074b405f175b203d3"}],"samples/tosca-templates/vnfd/tosca-vnfd-alarm-scale.yaml":[{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"02bcf9adb4ebb54d4608162f371930740fc8e9f3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        image: cirros-0.3.4-x86_64-uec"},{"line_number":19,"context_line":"        mgmt_driver: noop"},{"line_number":20,"context_line":"        availability_zone: nova"},{"line_number":21,"context_line":"        metadata: {get_param: vnf_id}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    CP1:"},{"line_number":24,"context_line":"      type: tosca.nodes.nfv.CP.Tacker"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa6399be_c0c5a08e","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":37},"updated":"2016-10-13 01:56:18.000000000","message":"this is a heat level construct, are you planning to implement this as a parameterized value for metadata? please refer to existing sample parameterized template [1] for the tosca structure.\n\n[1] https://github.com/openstack/tacker/blob/master/samples/tosca-templates/vnfd/tosca-vnfd-vdu-name.yaml","commit_id":"47b543edad81a4eb9b38f668458251ecc0b01474"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"02d8c7d43426cab137e0fd531fb16d39a9fac2f5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        image: cirros-0.3.4-x86_64-uec"},{"line_number":19,"context_line":"        mgmt_driver: noop"},{"line_number":20,"context_line":"        availability_zone: nova"},{"line_number":21,"context_line":"        metadata: {get_param: vnf_id}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    CP1:"},{"line_number":24,"context_line":"      type: tosca.nodes.nfv.CP.Tacker"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa6399be_5a1f9107","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":37},"in_reply_to":"fa6399be_02031510","updated":"2016-10-14 01:37:23.000000000","message":"then why can\u0027t we just have metadata: vnf_id ?","commit_id":"47b543edad81a4eb9b38f668458251ecc0b01474"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"7f8724c027125c6cad6c5cde15e04af72f30036c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        image: cirros-0.3.4-x86_64-uec"},{"line_number":19,"context_line":"        mgmt_driver: noop"},{"line_number":20,"context_line":"        availability_zone: nova"},{"line_number":21,"context_line":"        metadata: {get_param: vnf_id}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    CP1:"},{"line_number":24,"context_line":"      type: tosca.nodes.nfv.CP.Tacker"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa6399be_2160e900","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":37},"in_reply_to":"fa6399be_5a1f9107","updated":"2016-10-14 02:59:20.000000000","message":"Hi Sripriya,\nmetadata requires a map [1]\n[1] https://github.com/openstack/tacker/blob/master/tacker/vnfm/tosca/lib/tacker_nfv_defs.yaml#L175","commit_id":"47b543edad81a4eb9b38f668458251ecc0b01474"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"03514b1f790129ce03e204bc98f3620ec7c36d5f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        image: cirros-0.3.4-x86_64-uec"},{"line_number":19,"context_line":"        mgmt_driver: noop"},{"line_number":20,"context_line":"        availability_zone: nova"},{"line_number":21,"context_line":"        metadata: {get_param: vnf_id}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    CP1:"},{"line_number":24,"context_line":"      type: tosca.nodes.nfv.CP.Tacker"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa6399be_02031510","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":37},"in_reply_to":"fa6399be_c0c5a08e","updated":"2016-10-13 12:00:54.000000000","message":"Hi Sripriya,\n\nI already looked into \"parameterized\" part which supported in tosca-parser before. But IMO metadata here has a bit difference. The reason is that vnf_id is created at runtime. Therefore, i did my own way here [1]. Do we have other choices?\n[1] https://review.openstack.org/#/c/382479/5/tacker/vnfm/tosca/utils.py@127","commit_id":"47b543edad81a4eb9b38f668458251ecc0b01474"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"5a6ae6399b392ce94eff7a05afc0d8fc9fbdb6b4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                    evaluations: 1"},{"line_number":88,"context_line":"                    method: avg"},{"line_number":89,"context_line":"                    comparison_operator: gt"},{"line_number":90,"context_line":"                action:"},{"line_number":91,"context_line":"                  resize_compute:"},{"line_number":92,"context_line":"                    action_name: SP1"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    - vdu_low_cpu_usage_monitoring_policy:"},{"line_number":95,"context_line":"        type: tosca.policies.tacker.Alarming"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa6399be_f0f29a05","line":92,"range":{"start_line":90,"start_character":16,"end_line":92,"end_character":36},"updated":"2016-10-19 06:42:06.000000000","message":"there is no need for nested resize_compute.","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"89211ab3176a0fbd1db356003c35bcff4d0e1060","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                    evaluations: 1"},{"line_number":88,"context_line":"                    method: avg"},{"line_number":89,"context_line":"                    comparison_operator: gt"},{"line_number":90,"context_line":"                action:"},{"line_number":91,"context_line":"                  resize_compute:"},{"line_number":92,"context_line":"                    action_name: SP1"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    - vdu_low_cpu_usage_monitoring_policy:"},{"line_number":95,"context_line":"        type: tosca.policies.tacker.Alarming"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9a629dbe_5b1d17bc","line":92,"range":{"start_line":90,"start_character":16,"end_line":92,"end_character":36},"in_reply_to":"fa6399be_70812a8f","updated":"2016-11-09 00:27:54.000000000","message":"please followup with a bug id","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"4a0b4c3bdbd82fd0ce4dccbd5d26ac529c213282","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                    evaluations: 1"},{"line_number":88,"context_line":"                    method: avg"},{"line_number":89,"context_line":"                    comparison_operator: gt"},{"line_number":90,"context_line":"                action:"},{"line_number":91,"context_line":"                  resize_compute:"},{"line_number":92,"context_line":"                    action_name: SP1"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    - vdu_low_cpu_usage_monitoring_policy:"},{"line_number":95,"context_line":"        type: tosca.policies.tacker.Alarming"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa6399be_70812a8f","line":92,"range":{"start_line":90,"start_character":16,"end_line":92,"end_character":36},"in_reply_to":"fa6399be_f0f29a05","updated":"2016-10-19 06:56:50.000000000","message":"As mentioned before, I would like to create new patch for it. Is fine for you? Thanks","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"5a6ae6399b392ce94eff7a05afc0d8fc9fbdb6b4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    - vdu_low_cpu_usage_monitoring_policy:"},{"line_number":95,"context_line":"        type: tosca.policies.tacker.Alarming"},{"line_number":96,"context_line":"        triggers:"},{"line_number":97,"context_line":"            resize_compute:"},{"line_number":98,"context_line":"                event_type:"},{"line_number":99,"context_line":"                    type: tosca.events.resource.utilization"},{"line_number":100,"context_line":"                    implementation: ceilometer"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa6399be_b0810250","line":97,"range":{"start_line":97,"start_character":12,"end_line":97,"end_character":26},"updated":"2016-10-19 06:42:06.000000000","message":"it should be any string.","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"4a0b4c3bdbd82fd0ce4dccbd5d26ac529c213282","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    - vdu_low_cpu_usage_monitoring_policy:"},{"line_number":95,"context_line":"        type: tosca.policies.tacker.Alarming"},{"line_number":96,"context_line":"        triggers:"},{"line_number":97,"context_line":"            resize_compute:"},{"line_number":98,"context_line":"                event_type:"},{"line_number":99,"context_line":"                    type: tosca.events.resource.utilization"},{"line_number":100,"context_line":"                    implementation: ceilometer"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa6399be_b062e214","line":97,"range":{"start_line":97,"start_character":12,"end_line":97,"end_character":26},"in_reply_to":"fa6399be_b0810250","updated":"2016-10-19 06:56:50.000000000","message":"It should be suitable for scaling. of course, it should be changed in other cases like respawning,..","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"}],"tacker/tests/etc/samples/sample-tosca-alarm-respawn.yaml":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"5a6ae6399b392ce94eff7a05afc0d8fc9fbdb6b4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    - vdu1_cpu_usage_monitoring_policy:"},{"line_number":41,"context_line":"        type: tosca.policies.tacker.Alarming"},{"line_number":42,"context_line":"        triggers:"},{"line_number":43,"context_line":"            resize_compute:"},{"line_number":44,"context_line":"                event_type:"},{"line_number":45,"context_line":"                    type: tosca.events.resource.utilization"},{"line_number":46,"context_line":"                    implementation: ceilometer"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa6399be_d00756c7","line":43,"range":{"start_line":43,"start_character":12,"end_line":43,"end_character":27},"updated":"2016-10-19 06:42:06.000000000","message":"I think since triggers is a pluar, so resize_compute should be one of triigers, and we should be able to define many triggers.","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"4a0b4c3bdbd82fd0ce4dccbd5d26ac529c213282","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    - vdu1_cpu_usage_monitoring_policy:"},{"line_number":41,"context_line":"        type: tosca.policies.tacker.Alarming"},{"line_number":42,"context_line":"        triggers:"},{"line_number":43,"context_line":"            resize_compute:"},{"line_number":44,"context_line":"                event_type:"},{"line_number":45,"context_line":"                    type: tosca.events.resource.utilization"},{"line_number":46,"context_line":"                    implementation: ceilometer"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa6399be_30541253","line":43,"range":{"start_line":43,"start_character":12,"end_line":43,"end_character":27},"in_reply_to":"fa6399be_d00756c7","updated":"2016-10-19 06:56:50.000000000","message":"totally correct. IMHO, resize_compute should be only compatible with scaling. Actually, this patch is a partial bug. I have intention to support multiple policies (as we discussed before, hope you remember) in another patch. It is item #5 as described here: https://bugs.launchpad.net/tacker/+bug/1630614","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"5a6ae6399b392ce94eff7a05afc0d8fc9fbdb6b4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                    comparison_operator: gt"},{"line_number":55,"context_line":"                action:"},{"line_number":56,"context_line":"                  resize_compute:"},{"line_number":57,"context_line":"                    action_name: respawn"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa6399be_b03662b2","line":57,"range":{"start_line":57,"start_character":20,"end_line":57,"end_character":40},"updated":"2016-10-19 06:42:06.000000000","message":"the respawn is a inner action, right?\n\nwe should be able to define many actions:\nactions:\n    -SP1\n    -respawn\n    -notify","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"4a0b4c3bdbd82fd0ce4dccbd5d26ac529c213282","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                    comparison_operator: gt"},{"line_number":55,"context_line":"                action:"},{"line_number":56,"context_line":"                  resize_compute:"},{"line_number":57,"context_line":"                    action_name: respawn"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa6399be_f0d0dacb","line":57,"range":{"start_line":57,"start_character":20,"end_line":57,"end_character":40},"in_reply_to":"fa6399be_b03662b2","updated":"2016-10-19 06:56:50.000000000","message":"I guess we need more discussion here and need change code as well. Should it be another patch?","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"89211ab3176a0fbd1db356003c35bcff4d0e1060","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                    comparison_operator: gt"},{"line_number":55,"context_line":"                action:"},{"line_number":56,"context_line":"                  resize_compute:"},{"line_number":57,"context_line":"                    action_name: respawn"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9a629dbe_1b51df62","line":57,"range":{"start_line":57,"start_character":20,"end_line":57,"end_character":40},"in_reply_to":"fa6399be_f0d0dacb","updated":"2016-11-09 00:27:54.000000000","message":"i think gongysh is implying if action_name can hold any predefined actions or scaling policy in case scaling is requested.","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"}],"tacker/tests/etc/samples/sample-tosca-alarm-scale.yaml":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"075304251f3b838550ca0762cb9c0906a075e17d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                    comparison_operator: lt"},{"line_number":85,"context_line":"                action:"},{"line_number":86,"context_line":"                  resize_compute:"},{"line_number":87,"context_line":"                    action_name: SP1"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa6399be_76dbe21b","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":36},"updated":"2016-10-19 08:25:38.000000000","message":"Although, it is sample yaml so no problem, but is it ok to have same action for both(scale in/out) ?","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"a194b420805c91615ac72ee5a29309c862610eb9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                    comparison_operator: lt"},{"line_number":85,"context_line":"                action:"},{"line_number":86,"context_line":"                  resize_compute:"},{"line_number":87,"context_line":"                    action_name: SP1"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa6399be_4472a4e4","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":36},"in_reply_to":"fa6399be_76dbe21b","updated":"2016-10-19 08:43:46.000000000","message":"actually scaling in/out policies are specified when handling tosca template in openstack.py. Therefore we cannot point to specific scaling type here. Please note that official action will be specified here [1]. After analyzing tosca-template, we will have action names SP1-in and SP1-out, respectively.\n[1] https://review.openstack.org/#/c/382479/15/tacker/vnfm/monitor.py@236","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"}],"tacker/tests/functional/vnfm/test_tosca_vnf_alarm.py":[{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"ea2cc9fdac57b630ea4b4e3644ba9ab1b2fafc1e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                           vnf_id)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Verify VNF monitor events captured for states, ACTIVE and DEAD"},{"line_number":87,"context_line":"        vnf_state_list \u003d [evt_constants.ACTIVE, evt_constants.DEAD]"},{"line_number":88,"context_line":"        self.verify_vnf_monitor_events(vnf_id, vnf_state_list)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # Delete vnfd_instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_a6640fb9","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":67},"updated":"2016-10-14 01:41:51.000000000","message":"what about events PENDING_SCALE_OUT/IN for scale case?","commit_id":"1f08856ab53387b159a996b074b405f175b203d3"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"f680af02f17c59d2a1d4370fb259177382d91332","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                           vnf_id)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Verify VNF monitor events captured for states, ACTIVE and DEAD"},{"line_number":87,"context_line":"        vnf_state_list \u003d [evt_constants.ACTIVE, evt_constants.DEAD]"},{"line_number":88,"context_line":"        self.verify_vnf_monitor_events(vnf_id, vnf_state_list)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # Delete vnfd_instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_818e15ce","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":67},"in_reply_to":"fa6399be_a6640fb9","updated":"2016-10-14 02:59:34.000000000","message":"will update..thanks","commit_id":"1f08856ab53387b159a996b074b405f175b203d3"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"075304251f3b838550ca0762cb9c0906a075e17d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                vnf_id,"},{"line_number":86,"context_line":"                constants.VNF_CIRROS_CREATE_TIMEOUT,"},{"line_number":87,"context_line":"                constants.ACTIVE_SLEEP_TIME)"},{"line_number":88,"context_line":"            trigger_vnf(vnf_id, mon_policy_name, mon_policy_action)"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            _waiting_time(2)"},{"line_number":91,"context_line":"            time.sleep(constants.SCALE_WINDOW_SLEEP_TIME)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_39af9de4","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":67},"updated":"2016-10-19 08:25:38.000000000","message":"Do we need to trigger it manually?\nIf yes, we can not test that alarm triggering automatically or not.\nSo can we add test for that?","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"a194b420805c91615ac72ee5a29309c862610eb9","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                vnf_id,"},{"line_number":86,"context_line":"                constants.VNF_CIRROS_CREATE_TIMEOUT,"},{"line_number":87,"context_line":"                constants.ACTIVE_SLEEP_TIME)"},{"line_number":88,"context_line":"            trigger_vnf(vnf_id, mon_policy_name, mon_policy_action)"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            _waiting_time(2)"},{"line_number":91,"context_line":"            time.sleep(constants.SCALE_WINDOW_SLEEP_TIME)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_9f816950","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":67},"in_reply_to":"fa6399be_39af9de4","updated":"2016-10-19 08:43:46.000000000","message":"actually i still have no idea to test automatically. it seems difficult. At least manual trigger could ensure that tacker-server will still work well in case of alarm monitoring.","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"}],"tacker/tests/unit/vm/infra_drivers/openstack/data/test_tosca_vnfd_alarm_respawn.yaml":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"7c8189719aa0af02f15f9ad3de7ea44ac0af2f8b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      properties:"},{"line_number":18,"context_line":"        image: cirros-0.3.4-x86_64-uec"},{"line_number":19,"context_line":"        mgmt_driver: noop"},{"line_number":20,"context_line":"        availability_zone: nova"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    CP1:"},{"line_number":23,"context_line":"      type: tosca.nodes.nfv.CP.Tacker"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a6eadb0_e4aa1170","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":25},"updated":"2016-12-13 03:09:08.000000000","message":"we need metadata here too","commit_id":"5d159a8dd490c7e18dd8482a646d9b041bb09f57"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"038e8003b9ccdee8012b85f3d5baf42c7f1c24c4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      properties:"},{"line_number":18,"context_line":"        image: cirros-0.3.4-x86_64-uec"},{"line_number":19,"context_line":"        mgmt_driver: noop"},{"line_number":20,"context_line":"        availability_zone: nova"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    CP1:"},{"line_number":23,"context_line":"      type: tosca.nodes.nfv.CP.Tacker"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a6eadb0_62dcf612","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":25},"in_reply_to":"1a6eadb0_e4aa1170","updated":"2016-12-14 04:54:01.000000000","message":"Done","commit_id":"5d159a8dd490c7e18dd8482a646d9b041bb09f57"}],"tacker/tests/unit/vm/infra_drivers/openstack/data/tosca_alarm_metadata.yaml":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"e73986e50aad4f1e8ab11fbf130e7b6f3ddb28c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_profile_for_nfv_1_0_0"},{"line_number":2,"context_line":"description: Demo example"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":" template_name: sample-tosca-vnfd"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"da4df55a_7fa3a84f","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":25},"updated":"2016-12-26 05:46:28.000000000","message":"add a description about what is used for, for example:\nsince VDU1 has not be given metadata {\u0027metering: VDU1\u0027} which\nis required at line 56, tacker will raise an exception","commit_id":"6154743211c6e4c0cff69bd7969ad0e43f46514a"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"7a95d711f44912821d077b1b13cccf59b319390d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_profile_for_nfv_1_0_0"},{"line_number":2,"context_line":"description: Demo example"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":" template_name: sample-tosca-vnfd"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"da4df55a_52a09b43","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":25},"in_reply_to":"da4df55a_7fa3a84f","updated":"2016-12-26 06:30:43.000000000","message":"Done","commit_id":"6154743211c6e4c0cff69bd7969ad0e43f46514a"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a507d028fcb54555ddcbba24e7ec87fb51ca383e","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                properties[\u0027meter_name\u0027] \u003d trigger_dict[\u0027metrics\u0027]"},{"line_number":410,"context_line":"                is_matched \u003d False"},{"line_number":411,"context_line":"                for vdu_name, metadata_dict in metadata[\u0027vdus\u0027].items():"},{"line_number":412,"context_line":"                    if trigger_dict[\u0027metadata\u0027] \u003d\u003d\\"},{"line_number":413,"context_line":"                            metadata_dict[\u0027metering.vnf\u0027]:"},{"line_number":414,"context_line":"                        is_matched \u003d True"},{"line_number":415,"context_line":"                if not is_matched:"},{"line_number":416,"context_line":"                    raise vnfm.MetadataNotMatched()"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a6eadb0_c6fc7dba","line":413,"range":{"start_line":412,"start_character":19,"end_line":413,"end_character":58},"updated":"2016-12-16 10:59:27.000000000","message":"what will happen if metadata is empty?","commit_id":"ef765e4715a31c356634031d2c325d94ccfa44a6"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"b19752eafe32e6943df5deffd7ce2f7e98d4f7d1","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                properties[\u0027meter_name\u0027] \u003d trigger_dict[\u0027metrics\u0027]"},{"line_number":410,"context_line":"                is_matched \u003d False"},{"line_number":411,"context_line":"                for vdu_name, metadata_dict in metadata[\u0027vdus\u0027].items():"},{"line_number":412,"context_line":"                    if trigger_dict[\u0027metadata\u0027] \u003d\u003d\\"},{"line_number":413,"context_line":"                            metadata_dict[\u0027metering.vnf\u0027]:"},{"line_number":414,"context_line":"                        is_matched \u003d True"},{"line_number":415,"context_line":"                if not is_matched:"},{"line_number":416,"context_line":"                    raise vnfm.MetadataNotMatched()"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a6eadb0_062035f6","line":413,"range":{"start_line":412,"start_character":19,"end_line":413,"end_character":58},"in_reply_to":"1a6eadb0_c6fc7dba","updated":"2016-12-16 11:13:09.000000000","message":"metadata is caught at L406","commit_id":"ef765e4715a31c356634031d2c325d94ccfa44a6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a507d028fcb54555ddcbba24e7ec87fb51ca383e","unresolved":false,"context_lines":[{"line_number":415,"context_line":"                if not is_matched:"},{"line_number":416,"context_line":"                    raise vnfm.MetadataNotMatched()"},{"line_number":417,"context_line":"                matching_metadata_dict[\u0027metadata.user_metadata.vnf_id\u0027] \u003d\\"},{"line_number":418,"context_line":"                    trigger_dict[\u0027metadata\u0027]"},{"line_number":419,"context_line":"                properties[\u0027matching_metadata\u0027] \u003d \\"},{"line_number":420,"context_line":"                    matching_metadata_dict"},{"line_number":421,"context_line":"                properties[\u0027comparison_operator\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a6eadb0_8640c508","line":418,"range":{"start_line":418,"start_character":42,"end_line":418,"end_character":44},"updated":"2016-12-16 10:59:27.000000000","message":"is it surly a vnf_id? from the templates and codes, it can be anything.","commit_id":"ef765e4715a31c356634031d2c325d94ccfa44a6"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"b19752eafe32e6943df5deffd7ce2f7e98d4f7d1","unresolved":false,"context_lines":[{"line_number":415,"context_line":"                if not is_matched:"},{"line_number":416,"context_line":"                    raise vnfm.MetadataNotMatched()"},{"line_number":417,"context_line":"                matching_metadata_dict[\u0027metadata.user_metadata.vnf_id\u0027] \u003d\\"},{"line_number":418,"context_line":"                    trigger_dict[\u0027metadata\u0027]"},{"line_number":419,"context_line":"                properties[\u0027matching_metadata\u0027] \u003d \\"},{"line_number":420,"context_line":"                    matching_metadata_dict"},{"line_number":421,"context_line":"                properties[\u0027comparison_operator\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a6eadb0_a6b86176","line":418,"range":{"start_line":418,"start_character":42,"end_line":418,"end_character":44},"in_reply_to":"1a6eadb0_8640c508","updated":"2016-12-16 11:13:09.000000000","message":"Ouch.. my mistake. it\u0027s just \"vnf\"","commit_id":"ef765e4715a31c356634031d2c325d94ccfa44a6"}],"tacker/vnfm/monitor.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"5a6ae6399b392ce94eff7a05afc0d8fc9fbdb6b4","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            \u0027tacker.tacker.alarm_monitor.drivers\u0027,"},{"line_number":216,"context_line":"            cfg.CONF.tacker.alarm_monitor_driver)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def update_vnf_with_alarm(self, plugin, context, vnf, policy_name, policy_dict):      # noqa"},{"line_number":219,"context_line":"        params \u003d dict()"},{"line_number":220,"context_line":"        params[\u0027vnf_id\u0027] \u003d vnf[\u0027id\u0027]"},{"line_number":221,"context_line":"        params[\u0027mon_policy_name\u0027] \u003d policy_name"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_4e3ba8eb","line":218,"range":{"start_line":218,"start_character":35,"end_line":218,"end_character":36},"updated":"2016-10-19 06:42:06.000000000","message":"put context as the first argument","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"04aea36cc03e91c9ab57a76d062ed5d661c0cdd2","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            \u0027tacker.tacker.alarm_monitor.drivers\u0027,"},{"line_number":216,"context_line":"            cfg.CONF.tacker.alarm_monitor_driver)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def update_vnf_with_alarm(self, plugin, context, vnf, policy_name, policy_dict):      # noqa"},{"line_number":219,"context_line":"        params \u003d dict()"},{"line_number":220,"context_line":"        params[\u0027vnf_id\u0027] \u003d vnf[\u0027id\u0027]"},{"line_number":221,"context_line":"        params[\u0027mon_policy_name\u0027] \u003d policy_name"}],"source_content_type":"text/x-python","patch_set":15,"id":"da6895a0_ec7c78ed","line":218,"range":{"start_line":218,"start_character":35,"end_line":218,"end_character":36},"in_reply_to":"fa6399be_2afd603a","updated":"2016-10-25 01:35:40.000000000","message":"no, let us change it too.","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"4a0b4c3bdbd82fd0ce4dccbd5d26ac529c213282","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            \u0027tacker.tacker.alarm_monitor.drivers\u0027,"},{"line_number":216,"context_line":"            cfg.CONF.tacker.alarm_monitor_driver)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def update_vnf_with_alarm(self, plugin, context, vnf, policy_name, policy_dict):      # noqa"},{"line_number":219,"context_line":"        params \u003d dict()"},{"line_number":220,"context_line":"        params[\u0027vnf_id\u0027] \u003d vnf[\u0027id\u0027]"},{"line_number":221,"context_line":"        params[\u0027mon_policy_name\u0027] \u003d policy_name"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_50d6e6c3","line":218,"range":{"start_line":218,"start_character":35,"end_line":218,"end_character":36},"in_reply_to":"fa6399be_4e3ba8eb","updated":"2016-10-19 06:56:50.000000000","message":"Done","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"d4fe9827f60ff04f82338954310b0f1a59f7e665","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            \u0027tacker.tacker.alarm_monitor.drivers\u0027,"},{"line_number":216,"context_line":"            cfg.CONF.tacker.alarm_monitor_driver)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def update_vnf_with_alarm(self, plugin, context, vnf, policy_name, policy_dict):      # noqa"},{"line_number":219,"context_line":"        params \u003d dict()"},{"line_number":220,"context_line":"        params[\u0027vnf_id\u0027] \u003d vnf[\u0027id\u0027]"},{"line_number":221,"context_line":"        params[\u0027mon_policy_name\u0027] \u003d policy_name"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_2afd603a","line":218,"range":{"start_line":218,"start_character":35,"end_line":218,"end_character":36},"in_reply_to":"fa6399be_50d6e6c3","updated":"2016-10-19 17:15:49.000000000","message":"Ouch.. Hi gongysh, I just look again. Actually the method update_vnf_with_alarm() is used in plugin.py [1]. Therefore it is better to keep this order IMO.\n[1] https://review.openstack.org/#/c/382479/15/tacker/vnfm/plugin.py@261","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"5a6ae6399b392ce94eff7a05afc0d8fc9fbdb6b4","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        if bkend_policies:"},{"line_number":249,"context_line":"            bkend_policy \u003d bkend_policies[0]"},{"line_number":250,"context_line":"            if bkend_policy[\u0027type\u0027] \u003d\u003d constants.POLICY_SCALING:"},{"line_number":251,"context_line":"                cp \u003d policy_dict[\u0027triggers\u0027][\u0027resize_compute\u0027][\u0027condition\u0027]. \\"},{"line_number":252,"context_line":"                    get(\u0027comparison_operator\u0027)"},{"line_number":253,"context_line":"                scaling_type \u003d \u0027out\u0027 if cp \u003d\u003d \u0027gt\u0027 else \u0027in\u0027"},{"line_number":254,"context_line":"                alarm_action_name \u003d\\"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_ce589859","line":251,"range":{"start_line":251,"start_character":46,"end_line":251,"end_character":60},"updated":"2016-10-19 06:42:06.000000000","message":"do we need to hardcode it?","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":13485,"name":"Sripriya Seetharam","email":"sseetha@brocade.com","username":"Sripriya"},"change_message_id":"89211ab3176a0fbd1db356003c35bcff4d0e1060","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        if bkend_policies:"},{"line_number":249,"context_line":"            bkend_policy \u003d bkend_policies[0]"},{"line_number":250,"context_line":"            if bkend_policy[\u0027type\u0027] \u003d\u003d constants.POLICY_SCALING:"},{"line_number":251,"context_line":"                cp \u003d policy_dict[\u0027triggers\u0027][\u0027resize_compute\u0027][\u0027condition\u0027]. \\"},{"line_number":252,"context_line":"                    get(\u0027comparison_operator\u0027)"},{"line_number":253,"context_line":"                scaling_type \u003d \u0027out\u0027 if cp \u003d\u003d \u0027gt\u0027 else \u0027in\u0027"},{"line_number":254,"context_line":"                alarm_action_name \u003d\\"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a629dbe_fb78abc6","line":251,"range":{"start_line":251,"start_character":46,"end_line":251,"end_character":60},"in_reply_to":"fa6399be_b094a2e8","updated":"2016-11-09 00:27:54.000000000","message":"yes, this needs to be revisited, we cannot hardcode triggers here.","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"4a0b4c3bdbd82fd0ce4dccbd5d26ac529c213282","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        if bkend_policies:"},{"line_number":249,"context_line":"            bkend_policy \u003d bkend_policies[0]"},{"line_number":250,"context_line":"            if bkend_policy[\u0027type\u0027] \u003d\u003d constants.POLICY_SCALING:"},{"line_number":251,"context_line":"                cp \u003d policy_dict[\u0027triggers\u0027][\u0027resize_compute\u0027][\u0027condition\u0027]. \\"},{"line_number":252,"context_line":"                    get(\u0027comparison_operator\u0027)"},{"line_number":253,"context_line":"                scaling_type \u003d \u0027out\u0027 if cp \u003d\u003d \u0027gt\u0027 else \u0027in\u0027"},{"line_number":254,"context_line":"                alarm_action_name \u003d\\"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_b094a2e8","line":251,"range":{"start_line":251,"start_character":46,"end_line":251,"end_character":60},"in_reply_to":"fa6399be_ce589859","updated":"2016-10-19 06:56:50.000000000","message":"totally agree. Do we need to create another patch? I would like to support multiple policies as well.","commit_id":"5924e27f24b4003b73d0b1be8a38ed61b59bc121"}],"tacker/vnfm/tosca/utils.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"7c8189719aa0af02f15f9ad3de7ea44ac0af2f8b","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"@log.log"},{"line_number":121,"context_line":"def get_vdu_metadata(template, vnf):"},{"line_number":122,"context_line":"    metadata \u003d {}"},{"line_number":123,"context_line":"    for nt in template.nodetemplates:"},{"line_number":124,"context_line":"        if nt.type_definition.is_derived_from(TACKERVDU):"},{"line_number":125,"context_line":"            metadata_dict \u003d nt.get_property_value(\u0027metadata\u0027) or None"},{"line_number":126,"context_line":"            if metadata_dict:"},{"line_number":127,"context_line":"                if metadata_dict[\u0027get_param\u0027] \u003d\u003d \u0027vnf_id\u0027:"},{"line_number":128,"context_line":"                    metadata[\u0027vdus\u0027] \u003d {}"},{"line_number":129,"context_line":"                    metadata[\u0027vdus\u0027][nt.name] \u003d {}"},{"line_number":130,"context_line":"                    metadata[\u0027vdus\u0027][nt.name][\u0027metering.vnf_id\u0027] \u003d vnf[\u0027id\u0027]"},{"line_number":131,"context_line":"    return metadata"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"@log.log"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6eadb0_c4e7d53e","line":131,"range":{"start_line":121,"start_character":0,"end_line":131,"end_character":19},"updated":"2016-12-13 03:09:08.000000000","message":"what if I indeed want to pass  other metadata into nova for the VDU?\n\nand since vnf_id is hard coded and needed by our alarm feature, we can put it into hot template no matter users have it in tosca template or not.","commit_id":"5d159a8dd490c7e18dd8482a646d9b041bb09f57"},{"author":{"_account_id":20560,"name":"Tung Doan","email":"doantungbk.203@gmail.com","username":"doantungbk"},"change_message_id":"038e8003b9ccdee8012b85f3d5baf42c7f1c24c4","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"@log.log"},{"line_number":121,"context_line":"def get_vdu_metadata(template, vnf):"},{"line_number":122,"context_line":"    metadata \u003d {}"},{"line_number":123,"context_line":"    for nt in template.nodetemplates:"},{"line_number":124,"context_line":"        if nt.type_definition.is_derived_from(TACKERVDU):"},{"line_number":125,"context_line":"            metadata_dict \u003d nt.get_property_value(\u0027metadata\u0027) or None"},{"line_number":126,"context_line":"            if metadata_dict:"},{"line_number":127,"context_line":"                if metadata_dict[\u0027get_param\u0027] \u003d\u003d \u0027vnf_id\u0027:"},{"line_number":128,"context_line":"                    metadata[\u0027vdus\u0027] \u003d {}"},{"line_number":129,"context_line":"                    metadata[\u0027vdus\u0027][nt.name] \u003d {}"},{"line_number":130,"context_line":"                    metadata[\u0027vdus\u0027][nt.name][\u0027metering.vnf_id\u0027] \u003d vnf[\u0027id\u0027]"},{"line_number":131,"context_line":"    return metadata"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"@log.log"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6eadb0_82d752ec","line":131,"range":{"start_line":121,"start_character":0,"end_line":131,"end_character":19},"in_reply_to":"1a6eadb0_c4e7d53e","updated":"2016-12-14 04:54:01.000000000","message":"Done","commit_id":"5d159a8dd490c7e18dd8482a646d9b041bb09f57"}]}