)]}'
{"tacker/db/nfvo/vnffg_db.py":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"9b943b5f549eade03c3dc4186820f9078004c8ce","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                    vnf_list \u003d vnfm_plugin.get_vnfs(context,"},{"line_number":499,"context_line":"                                                    {\u0027vnfd_id\u0027: [vnfd_id]},"},{"line_number":500,"context_line":"                                                    fields\u003d[\u0027id\u0027])"},{"line_number":501,"context_line":"                    if len(vnf_list) \u003d\u003d 0:"},{"line_number":502,"context_line":"                        raise nfvo.VnffgInvalidMappingException(vnfd_name\u003dvnfd)"},{"line_number":503,"context_line":"                    else:"},{"line_number":504,"context_line":"                        LOG.debug(_(\u0027Matching VNFs found %s\u0027), vnf_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_2afb127a","line":501,"range":{"start_line":501,"start_character":20,"end_line":501,"end_character":41},"updated":"2016-11-20 15:42:54.000000000","message":"Do we really needs to calculate the length?\nInstead of calculating length, it can be as:\n\nif not vnf_list:","commit_id":"f40324475822a1628a83774eaaa14571b16f4ad9"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"57f8970c152aadce1e22dc9fbddf60a07c0a05f8","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                    vnf_list \u003d vnfm_plugin.get_vnfs(context,"},{"line_number":499,"context_line":"                                                    {\u0027vnfd_id\u0027: [vnfd_id]},"},{"line_number":500,"context_line":"                                                    fields\u003d[\u0027id\u0027])"},{"line_number":501,"context_line":"                    if len(vnf_list) \u003d\u003d 0:"},{"line_number":502,"context_line":"                        raise nfvo.VnffgInvalidMappingException(vnfd_name\u003dvnfd)"},{"line_number":503,"context_line":"                    else:"},{"line_number":504,"context_line":"                        LOG.debug(_(\u0027Matching VNFs found %s\u0027), vnf_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_f17d8d6d","line":501,"range":{"start_line":501,"start_character":20,"end_line":501,"end_character":41},"in_reply_to":"7a77a97e_2afb127a","updated":"2016-11-21 01:04:42.000000000","message":"Since it is a list, why can\u0027t we check the length?","commit_id":"f40324475822a1628a83774eaaa14571b16f4ad9"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"ad95be7729296c6747b155ffc68b9b7fae3c7b1f","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                    vnf_list \u003d vnfm_plugin.get_vnfs(context,"},{"line_number":499,"context_line":"                                                    {\u0027vnfd_id\u0027: [vnfd_id]},"},{"line_number":500,"context_line":"                                                    fields\u003d[\u0027id\u0027])"},{"line_number":501,"context_line":"                    if len(vnf_list) \u003d\u003d 0:"},{"line_number":502,"context_line":"                        raise nfvo.VnffgInvalidMappingException(vnfd_name\u003dvnfd)"},{"line_number":503,"context_line":"                    else:"},{"line_number":504,"context_line":"                        LOG.debug(_(\u0027Matching VNFs found %s\u0027), vnf_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_f201d33a","line":501,"range":{"start_line":501,"start_character":20,"end_line":501,"end_character":41},"in_reply_to":"7a77a97e_ac3c9a93","updated":"2016-11-22 08:38:19.000000000","message":"line506 is also judging the condition with vnf_list length","commit_id":"f40324475822a1628a83774eaaa14571b16f4ad9"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"b4604dae626e7de09f6200a3f39701662f2729f5","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                    vnf_list \u003d vnfm_plugin.get_vnfs(context,"},{"line_number":499,"context_line":"                                                    {\u0027vnfd_id\u0027: [vnfd_id]},"},{"line_number":500,"context_line":"                                                    fields\u003d[\u0027id\u0027])"},{"line_number":501,"context_line":"                    if len(vnf_list) \u003d\u003d 0:"},{"line_number":502,"context_line":"                        raise nfvo.VnffgInvalidMappingException(vnfd_name\u003dvnfd)"},{"line_number":503,"context_line":"                    else:"},{"line_number":504,"context_line":"                        LOG.debug(_(\u0027Matching VNFs found %s\u0027), vnf_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_ac3c9a93","line":501,"range":{"start_line":501,"start_character":20,"end_line":501,"end_character":41},"in_reply_to":"7a77a97e_f17d8d6d","updated":"2016-11-21 02:17:47.000000000","message":"yes we can. Actually my point is We can just use \"if not vnf_list\" instead of first calculating the length and then comparing it with 0.","commit_id":"f40324475822a1628a83774eaaa14571b16f4ad9"}]}