)]}'
{"requirements.txt":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"35a2e0dd912de79767d9cdfd781c2b3878923905","unresolved":false,"context_lines":[{"line_number":44,"context_line":"python-mistralclient\u003e\u003d3.1.0 # Apache-2.0"},{"line_number":45,"context_line":"python-barbicanclient!\u003d4.5.0,!\u003d4.5.1,\u003e\u003d4.0.0 # Apache-2.0"},{"line_number":46,"context_line":"kubernetes\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":47,"context_line":"setuptools\u003e\u003d16.0,!\u003d24.0.0,!\u003d34.0.0,!\u003d34.0.1,!\u003d34.0.2,!\u003d34.0.3,!\u003d34.1.0,!\u003d34.1.1,!\u003d34.2.0,!\u003d34.3.0,!\u003d34.3.1,!\u003d34.3.2,!\u003d36.2.0  # PSF/ZPL"},{"line_number":48,"context_line":"PyYAML\u003e\u003d3.10  # MIT"}],"source_content_type":"text/plain","patch_set":11,"id":"1f485f77_a67911fd","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":10},"updated":"2017-11-14 09:12:57.000000000","message":"why do we need this?","commit_id":"2cfd6b53f0cd11011c127e18624feaaa2cc756fb"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"9d693d2f0da94879af55b33e61d1bfec8d8808b0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"python-mistralclient\u003e\u003d3.1.0 # Apache-2.0"},{"line_number":45,"context_line":"python-barbicanclient!\u003d4.5.0,!\u003d4.5.1,\u003e\u003d4.0.0 # Apache-2.0"},{"line_number":46,"context_line":"kubernetes\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":47,"context_line":"setuptools\u003e\u003d16.0,!\u003d24.0.0,!\u003d34.0.0,!\u003d34.0.1,!\u003d34.0.2,!\u003d34.0.3,!\u003d34.1.0,!\u003d34.1.1,!\u003d34.2.0,!\u003d34.3.0,!\u003d34.3.1,!\u003d34.3.2,!\u003d36.2.0  # PSF/ZPL"},{"line_number":48,"context_line":"PyYAML\u003e\u003d3.10  # MIT"}],"source_content_type":"text/plain","patch_set":11,"id":"1f485f77_30178f54","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":10},"in_reply_to":"1f485f77_a67911fd","updated":"2017-11-14 13:52:51.000000000","message":"I check the requirements for kubernetes lib in https://pypi.python.org/pypi/kubernetes/1.0.2\nThey need setuptools, and update it with https://github.com/openstack/requirements/blob/master/global-requirements.txt","commit_id":"2cfd6b53f0cd11011c127e18624feaaa2cc756fb"}],"tacker/nfvo/drivers/vim/kubernetes_driver.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"ecc42dcb581d0d34f9d173d76d9c82b792df7b3d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"KUBERNETES_OPTS \u003d ["},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027api_url\u0027, default\u003d\u0027https://127.0.0.1:6443\u0027,"},{"line_number":40,"context_line":"               help\u003d(\u0027API endpoint of Kubernetes daemon\u0027)),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027kubernetes_fernet_path\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027/etc/tacker/vim/kubernetes/fernet_keys\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Dir.path to store fernet keys.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027kubernetes_ca_cert_path\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027/etc/tacker/vim/kubernetes/ca_certs\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Dir.path to store ca cert files.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_3b7cbd1d","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":54},"updated":"2017-10-16 14:44:54.000000000","message":"I know the current openstack vim is using this way, but we need to devise a new way to the fernet key way.\n\ncurrent way does not allow to use more than one tacker server.","commit_id":"80292122e7b20264cce9aa6406a6ed9ce208d2fe"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"ecc42dcb581d0d34f9d173d76d9c82b792df7b3d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027kubernetes_fernet_path\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027/etc/tacker/vim/kubernetes/fernet_keys\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Dir.path to store fernet keys.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027kubernetes_ca_cert_path\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027/etc/tacker/vim/kubernetes/ca_certs\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Dir.path to store ca cert files.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027use_barbican\u0027, default\u003dFalse,"},{"line_number":48,"context_line":"                help\u003d_(\u0027Use barbican to encrypt vim password if True\u0027"},{"line_number":49,"context_line":"                       \u0027, save vim credentials in local file system\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_bba78dbd","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":56},"updated":"2017-10-16 14:44:54.000000000","message":"prefer to save it into db and generate a temp file once it is needed.","commit_id":"80292122e7b20264cce9aa6406a6ed9ce208d2fe"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"c0b02e9274dabd57754891b1a423cdcd180dccae","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027kubernetes_fernet_path\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027/etc/tacker/vim/kubernetes/fernet_keys\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Dir.path to store fernet keys.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027kubernetes_ca_cert_path\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027/etc/tacker/vim/kubernetes/ca_certs\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Dir.path to store ca cert files.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027use_barbican\u0027, default\u003dFalse,"},{"line_number":48,"context_line":"                help\u003d_(\u0027Use barbican to encrypt vim password if True\u0027"},{"line_number":49,"context_line":"                       \u0027, save vim credentials in local file system\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_fca61bab","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":56},"in_reply_to":"5f4e5783_bba78dbd","updated":"2017-10-16 16:15:19.000000000","message":"I will check and update it asap","commit_id":"80292122e7b20264cce9aa6406a6ed9ce208d2fe"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"683421466183e7cc53a6e5176f64aa328fda82e6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027kubernetes_fernet_path\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027/etc/tacker/vim/kubernetes/fernet_keys\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Dir.path to store fernet keys.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027kubernetes_ca_cert_path\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027/etc/tacker/vim/kubernetes/ca_certs\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Dir.path to store ca cert files.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027use_barbican\u0027, default\u003dFalse,"},{"line_number":48,"context_line":"                help\u003d_(\u0027Use barbican to encrypt vim password if True\u0027"},{"line_number":49,"context_line":"                       \u0027, save vim credentials in local file system\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_b42adbd7","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":56},"in_reply_to":"5f4e5783_fca61bab","updated":"2017-10-17 16:55:52.000000000","message":"I am confusing about creating temp file. K8s client use temp file, after executing command, should I need to call function to delete temp file?","commit_id":"80292122e7b20264cce9aa6406a6ed9ce208d2fe"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"ecc42dcb581d0d34f9d173d76d9c82b792df7b3d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027kubernetes_ca_cert_path\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027/etc/tacker/vim/kubernetes/ca_certs\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Dir.path to store ca cert files.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027use_barbican\u0027, default\u003dFalse,"},{"line_number":48,"context_line":"                help\u003d_(\u0027Use barbican to encrypt vim password if True\u0027"},{"line_number":49,"context_line":"                       \u0027, save vim credentials in local file system\u0027"},{"line_number":50,"context_line":"                       \u0027if False\u0027))"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":"cfg.CONF.register_opts(KUBERNETES_OPTS, \u0027k8s_vim\u0027)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_bb2e6d8f","line":50,"range":{"start_line":47,"start_character":0,"end_line":50,"end_character":35},"updated":"2017-10-16 14:44:54.000000000","message":"we should not consider using non-barbican way.","commit_id":"80292122e7b20264cce9aa6406a6ed9ce208d2fe"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"c0b02e9274dabd57754891b1a423cdcd180dccae","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027kubernetes_ca_cert_path\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027/etc/tacker/vim/kubernetes/ca_certs\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Dir.path to store ca cert files.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027use_barbican\u0027, default\u003dFalse,"},{"line_number":48,"context_line":"                help\u003d_(\u0027Use barbican to encrypt vim password if True\u0027"},{"line_number":49,"context_line":"                       \u0027, save vim credentials in local file system\u0027"},{"line_number":50,"context_line":"                       \u0027if False\u0027))"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":"cfg.CONF.register_opts(KUBERNETES_OPTS, \u0027k8s_vim\u0027)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_7ce90bb5","line":50,"range":{"start_line":47,"start_character":0,"end_line":50,"end_character":35},"in_reply_to":"5f4e5783_bb2e6d8f","updated":"2017-10-16 16:15:19.000000000","message":"That mean Barbican will be the default to encrypt password and bearer_token in Tacker. I this week meeting, I will ask mr. Yangxingan if he can help for this change.","commit_id":"80292122e7b20264cce9aa6406a6ed9ce208d2fe"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"35a2e0dd912de79767d9cdfd781c2b3878923905","unresolved":false,"context_lines":[{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"KUBERNETES_OPTS \u003d ["},{"line_number":31,"context_line":"    cfg.StrOpt(\u0027api_url\u0027, default\u003d\u0027https://127.0.0.1:6443\u0027,"},{"line_number":32,"context_line":"               help\u003d(\u0027API endpoint of Kubernetes daemon\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027use_barbican\u0027, default\u003dTrue,"},{"line_number":34,"context_line":"                help\u003d_(\u0027Use barbican to encrypt vim password if True\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_86f3b573","line":31,"range":{"start_line":31,"start_character":16,"end_line":31,"end_character":23},"updated":"2017-11-14 09:12:57.000000000","message":"why do we need this? since it should be in vim definition.","commit_id":"2cfd6b53f0cd11011c127e18624feaaa2cc756fb"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"df1447e612e2566d92114dda4d4a2c5b56696eae","unresolved":false,"context_lines":[{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"KUBERNETES_OPTS \u003d ["},{"line_number":31,"context_line":"    cfg.StrOpt(\u0027api_url\u0027, default\u003d\u0027https://127.0.0.1:6443\u0027,"},{"line_number":32,"context_line":"               help\u003d(\u0027API endpoint of Kubernetes daemon\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027use_barbican\u0027, default\u003dTrue,"},{"line_number":34,"context_line":"                help\u003d_(\u0027Use barbican to encrypt vim password if True\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_0fd2e400","line":31,"range":{"start_line":31,"start_character":16,"end_line":31,"end_character":23},"in_reply_to":"1f485f77_86f3b573","updated":"2017-11-16 17:08:10.000000000","message":"Done","commit_id":"2cfd6b53f0cd11011c127e18624feaaa2cc756fb"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"9d693d2f0da94879af55b33e61d1bfec8d8808b0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"KUBERNETES_OPTS \u003d ["},{"line_number":31,"context_line":"    cfg.StrOpt(\u0027api_url\u0027, default\u003d\u0027https://127.0.0.1:6443\u0027,"},{"line_number":32,"context_line":"               help\u003d(\u0027API endpoint of Kubernetes daemon\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027use_barbican\u0027, default\u003dTrue,"},{"line_number":34,"context_line":"                help\u003d_(\u0027Use barbican to encrypt vim password if True\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_2b73a2b3","line":31,"range":{"start_line":31,"start_character":16,"end_line":31,"end_character":23},"in_reply_to":"1f485f77_86f3b573","updated":"2017-11-14 13:52:51.000000000","message":"The first time, I intend to use this as default Kubernetes API url. So, I will remove it.","commit_id":"2cfd6b53f0cd11011c127e18624feaaa2cc756fb"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"35a2e0dd912de79767d9cdfd781c2b3878923905","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        else:"},{"line_number":217,"context_line":"            raise nfvo.VimEncryptKeyError(vim_id\u003dvim_id)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def get_vim_resource_id(self):"},{"line_number":220,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_06ad8530","line":219,"range":{"start_line":219,"start_character":8,"end_line":219,"end_character":27},"updated":"2017-11-14 09:12:57.000000000","message":"give an explanation why just pass","commit_id":"2cfd6b53f0cd11011c127e18624feaaa2cc756fb"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"9d693d2f0da94879af55b33e61d1bfec8d8808b0","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        else:"},{"line_number":217,"context_line":"            raise nfvo.VimEncryptKeyError(vim_id\u003dvim_id)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def get_vim_resource_id(self):"},{"line_number":220,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_2b5a8229","line":219,"range":{"start_line":219,"start_character":8,"end_line":219,"end_character":27},"in_reply_to":"1f485f77_06ad8530","updated":"2017-11-14 13:52:51.000000000","message":"https://github.com/openstack/tacker/blob/8fd9521cbe6c16bb8f5921645884a90becbb06b8/tacker/nfvo/drivers/vim/abstract_vim_driver.py#L86\n\nThis method is used to find VIM resources like network, compute. But in Kubernetes VIM, we can not get these information, so I leave it with pass.","commit_id":"2cfd6b53f0cd11011c127e18624feaaa2cc756fb"}],"tacker/tests/unit/nfvo/drivers/vim/test_kubernetes_driver.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"35a2e0dd912de79767d9cdfd781c2b3878923905","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Brocade Communications System, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_a9ffa2ff","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":52},"updated":"2017-11-14 09:12:57.000000000","message":"delete this","commit_id":"2cfd6b53f0cd11011c127e18624feaaa2cc756fb"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"df1447e612e2566d92114dda4d4a2c5b56696eae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Brocade Communications System, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_8f07f482","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":52},"in_reply_to":"1f485f77_a9ffa2ff","updated":"2017-11-16 17:08:10.000000000","message":"Done","commit_id":"2cfd6b53f0cd11011c127e18624feaaa2cc756fb"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"9d693d2f0da94879af55b33e61d1bfec8d8808b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Brocade Communications System, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_0b6a26b2","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":52},"in_reply_to":"1f485f77_a9ffa2ff","updated":"2017-11-14 13:52:51.000000000","message":"I will do it","commit_id":"2cfd6b53f0cd11011c127e18624feaaa2cc756fb"}]}