)]}'
{"tacker/api/v1/attributes.py":[{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"0649ff12519f20a39c6bf03843947ad39e9bd031","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        return _validate_dict(data, key_specs)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"def _validate_dict_not_empty(data, key_specs\u003dNone):"},{"line_number":453,"context_line":"    if not isinstance(data, dict) or len(data) \u003d\u003d 0:"},{"line_number":454,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid dictionary or it is an\""},{"line_number":455,"context_line":"                \" empty dictionary\") % data"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3991f545","line":452,"range":{"start_line":452,"start_character":4,"end_line":452,"end_character":28},"updated":"2018-08-02 05:45:39.000000000","message":"IMO, we should enhance _validate_dict function for it. What do you think?","commit_id":"66677ea869c48f32a58f29df34849b44fd9f1560"},{"author":{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},"change_message_id":"e91ab35d7a150faf4dd722420439ddaa3606c9a6","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        return _validate_dict(data, key_specs)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"def _validate_dict_not_empty(data, key_specs\u003dNone):"},{"line_number":453,"context_line":"    if not isinstance(data, dict) or len(data) \u003d\u003d 0:"},{"line_number":454,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid dictionary or it is an\""},{"line_number":455,"context_line":"                \" empty dictionary\") % data"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2c1190f9","line":452,"range":{"start_line":452,"start_character":4,"end_line":452,"end_character":28},"in_reply_to":"5f7c97a3_3991f545","updated":"2018-08-03 09:38:32.000000000","message":"As auth_cred, vim_project parameters are mandatory, its length cant be 0. So here checking that if length is zero then raise BadRequest. If I move same changes to \u0027_validate_dict\u0027 method, then it will fail for cases where the parameters value can be None.\nExample,\n1. create a vnf using vnfd-template\n\ntacker  vnf-create vnf1 --vnfd-template samples/tosca-templates/vnfd/tosca-vnfd-hello-world.yaml\n\nHere value of \u0027placement_attr\u0027 can be None, so after modifying \u0027_validate_dict\u0027 method it will fail because of length(data) check.\n\nThere may be such more cases. So IMO it is better not to change \u0027_validate_dict\u0027 method.","commit_id":"66677ea869c48f32a58f29df34849b44fd9f1560"}]}