)]}'
{"api-ref/source/v1/parameters.yaml":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"b68b6dda5c3b8c669c83ebfdcc097d1c092690ff","unresolved":false,"context_lines":[{"line_number":692,"context_line":"  in: body"},{"line_number":693,"context_line":"  required: true"},{"line_number":694,"context_line":"  type: object"},{"line_number":695,"context_line":"vnf_attributes_delete_opt:"},{"line_number":696,"context_line":"  description: |"},{"line_number":697,"context_line":"    VNF attributes object with ``force`` key which can contain true/false value."},{"line_number":698,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_34942041","line":695,"range":{"start_line":695,"start_character":0,"end_line":695,"end_character":25},"updated":"2019-12-26 07:13:12.000000000","message":"I prefer `vnf_force_delete_flag`.","commit_id":"e7cb3b82dac5beb6138fdd9d59b7de68348665ae"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"6063f81572acf9645b93c2b6e64e64c890369300","unresolved":false,"context_lines":[{"line_number":692,"context_line":"  in: body"},{"line_number":693,"context_line":"  required: true"},{"line_number":694,"context_line":"  type: object"},{"line_number":695,"context_line":"vnf_attributes_delete_opt:"},{"line_number":696,"context_line":"  description: |"},{"line_number":697,"context_line":"    VNF attributes object with ``force`` key which can contain true/false value."},{"line_number":698,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_97339612","line":695,"range":{"start_line":695,"start_character":0,"end_line":695,"end_character":25},"in_reply_to":"3fa7e38b_34942041","updated":"2019-12-26 12:16:13.000000000","message":"Done","commit_id":"e7cb3b82dac5beb6138fdd9d59b7de68348665ae"}],"api-ref/source/v1/vnfs.inc":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"23b119792f1008ae734ec3c38b9ed57ca9426ee1","unresolved":false,"context_lines":[{"line_number":269,"context_line":".. note::"},{"line_number":270,"context_line":"    Non-admin users are not allowed to delete a VNF in ``PENDING_CREATE`` and"},{"line_number":271,"context_line":"    ``PENDING_DELETE`` status. In this case, it would return 409 error. Admin"},{"line_number":272,"context_line":"    users can delete a VNF in any status if deleted forcefully."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"Response Codes"},{"line_number":275,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"3fa7e38b_15cd9e5d","line":272,"range":{"start_line":272,"start_character":41,"end_line":272,"end_character":62},"updated":"2019-12-05 06:25:19.000000000","message":"with force flag true.","commit_id":"b1cdf052a42c8ad4b452574ba392d71b6c3d8ea1"}],"tacker/db/vnfm/vnfm_db.py":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"23b119792f1008ae734ec3c38b9ed57ca9426ee1","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        if(vnf_db.status in [constants.PENDING_UPDATE,"},{"line_number":515,"context_line":"                             constants.PENDING_HEAL]):"},{"line_number":516,"context_line":"            raise vnfm.VNFInUse(vnf_id\u003dvnf_id)"},{"line_number":517,"context_line":"        if vnf_db.status \u003d\u003d constants.PENDING_CREATE:"},{"line_number":518,"context_line":"            error_reason \u003d _(\"Operation on PENDING_CREATE VNF \""},{"line_number":519,"context_line":"                             \"is not permitted\")"},{"line_number":520,"context_line":"            raise vnfm.VNFDeleteFailed(reason\u003derror_reason)"},{"line_number":521,"context_line":"        return True"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    def _update_vnf_scaling_status(self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_b37d896e","line":520,"range":{"start_line":517,"start_character":8,"end_line":520,"end_character":59},"updated":"2019-12-05 06:25:19.000000000","message":"This check can not be here, as check_vnf_status_legality can be called from multiple operations.","commit_id":"b1cdf052a42c8ad4b452574ba392d71b6c3d8ea1"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"b85fad7e2869d4c3c9b05c8b2957046c01f103dc","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        if(vnf_db.status in [constants.PENDING_UPDATE,"},{"line_number":515,"context_line":"                             constants.PENDING_HEAL]):"},{"line_number":516,"context_line":"            raise vnfm.VNFInUse(vnf_id\u003dvnf_id)"},{"line_number":517,"context_line":"        if vnf_db.status \u003d\u003d constants.PENDING_CREATE:"},{"line_number":518,"context_line":"            error_reason \u003d _(\"Operation on PENDING_CREATE VNF \""},{"line_number":519,"context_line":"                             \"is not permitted\")"},{"line_number":520,"context_line":"            raise vnfm.VNFDeleteFailed(reason\u003derror_reason)"},{"line_number":521,"context_line":"        return True"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    def _update_vnf_scaling_status(self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_d77c6321","line":520,"range":{"start_line":517,"start_character":8,"end_line":520,"end_character":59},"in_reply_to":"3fa7e38b_b37d896e","updated":"2019-12-11 03:13:56.000000000","message":"\u003e This check can not be here, as check_vnf_status_legality can be\n \u003e called from multiple operations.\n\nWhy should not we have this change? IMO, refusing any operation to a VNF of PENDING_CREATE is reasonable.","commit_id":"b1cdf052a42c8ad4b452574ba392d71b6c3d8ea1"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"b68b6dda5c3b8c669c83ebfdcc097d1c092690ff","unresolved":false,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":"                vnf_db \u003d self._update_vnf_status_db("},{"line_number":606,"context_line":"                    context, vnf_id, _ACTIVE_UPDATE_ERROR_DEAD,"},{"line_number":607,"context_line":"                    constants.PENDING_DELETE, vnf_db\u003dvnf_db)"},{"line_number":608,"context_line":"            else:"},{"line_number":609,"context_line":"                vnf_db \u003d self._update_vnf_status_db_no_check(context,"},{"line_number":610,"context_line":"                    vnf_id, _ACTIVE_UPDATE_ERROR_DEAD,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_94df140a","line":607,"range":{"start_line":607,"start_character":46,"end_line":607,"end_character":59},"updated":"2019-12-26 07:13:12.000000000","message":"In case of deletion of a VNF belonging to a NS, vnf_db is not defined here so does not this result in NameError?","commit_id":"e7cb3b82dac5beb6138fdd9d59b7de68348665ae"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"6063f81572acf9645b93c2b6e64e64c890369300","unresolved":false,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":"                vnf_db \u003d self._update_vnf_status_db("},{"line_number":606,"context_line":"                    context, vnf_id, _ACTIVE_UPDATE_ERROR_DEAD,"},{"line_number":607,"context_line":"                    constants.PENDING_DELETE, vnf_db\u003dvnf_db)"},{"line_number":608,"context_line":"            else:"},{"line_number":609,"context_line":"                vnf_db \u003d self._update_vnf_status_db_no_check(context,"},{"line_number":610,"context_line":"                    vnf_id, _ACTIVE_UPDATE_ERROR_DEAD,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_17000603","line":607,"range":{"start_line":607,"start_character":46,"end_line":607,"end_character":59},"in_reply_to":"3fa7e38b_94df140a","updated":"2019-12-26 12:16:13.000000000","message":"I Think when VNF belongs to NS, In that case nss_db  won\u0027t be None. hence it will raise VNFInUse  exception at line 595. \n\nI mean as per the current design If VNF is belonging to NS then it won\u0027t allow VNF to delete. unless and until it is force delete","commit_id":"e7cb3b82dac5beb6138fdd9d59b7de68348665ae"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"e089127b2a8dee20badcc930d80060531e082b86","unresolved":false,"context_lines":[{"line_number":602,"context_line":"                            message\u003d\"Operation on PENDING_CREATE VNF is not \""},{"line_number":603,"context_line":"                                    \"permitted.\")"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"                vnf_db \u003d self._update_vnf_status_db("},{"line_number":606,"context_line":"                    context, vnf_id, _ACTIVE_UPDATE_ERROR_DEAD,"},{"line_number":607,"context_line":"                    constants.PENDING_DELETE, vnf_db\u003dvnf_db)"},{"line_number":608,"context_line":"            else:"},{"line_number":609,"context_line":"                vnf_db \u003d self._update_vnf_status_db_no_check(context,"},{"line_number":610,"context_line":"                    vnf_id, _ACTIVE_UPDATE_ERROR_DEAD,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_8402fbb8","line":607,"range":{"start_line":605,"start_character":16,"end_line":607,"end_character":60},"updated":"2020-01-30 15:09:08.000000000","message":"it\u0027s better to put this into \"else\" clause, because vnf_db is not defined outside.","commit_id":"8ad5e80690950df744e2d6703c3cd95e3dee2ad2"},{"author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"change_message_id":"ee1f7d023eb314ef1eb6e03fa24fecaa44897d24","unresolved":false,"context_lines":[{"line_number":602,"context_line":"                            message\u003d\"Operation on PENDING_CREATE VNF is not \""},{"line_number":603,"context_line":"                                    \"permitted.\")"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"                vnf_db \u003d self._update_vnf_status_db("},{"line_number":606,"context_line":"                    context, vnf_id, _ACTIVE_UPDATE_ERROR_DEAD,"},{"line_number":607,"context_line":"                    constants.PENDING_DELETE, vnf_db\u003dvnf_db)"},{"line_number":608,"context_line":"            else:"},{"line_number":609,"context_line":"                vnf_db \u003d self._update_vnf_status_db_no_check(context,"},{"line_number":610,"context_line":"                    vnf_id, _ACTIVE_UPDATE_ERROR_DEAD,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_0bbe0f01","line":607,"range":{"start_line":605,"start_character":16,"end_line":607,"end_character":60},"in_reply_to":"3fa7e38b_8402fbb8","updated":"2020-01-31 08:50:50.000000000","message":"Done","commit_id":"8ad5e80690950df744e2d6703c3cd95e3dee2ad2"}]}