)]}'
{"id":"openstack%2Ftacker~619609","triplet_id":"openstack%2Ftacker~master~Ibd30063ca1a46c7ea5686734835a030386ba06e5","project":"openstack/tacker","branch":"master","topic":"bp/test-addition-refactoring","hashtags":[],"change_id":"Ibd30063ca1a46c7ea5686734835a030386ba06e5","subject":"Improve UT test_wsgi, reduce code duplication","status":"MERGED","created":"2018-11-22 16:30:42.000000000","updated":"2018-11-27 07:21:16.000000000","submitted":"2018-11-27 07:21:16.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"619609-1543303276202-26d5690b","meta_rev_id":"b3e63c87257f71d2e740a85576042e47f685ce7c","_number":619609,"virtual_id_number":619609,"owner":{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2018-11-27 07:21:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},{"value":0,"_account_id":27181,"name":"lijiale","email":"lijiale_yewu@cmss.chinamobile.com","username":"lijiale"},{"value":0,"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"value":0,"_account_id":29470,"name":"tangyu","email":"tangyu@cmss.chinamobile.com","username":"ttyy"},{"value":0,"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"recommended":{"_account_id":27181,"name":"lijiale","email":"lijiale_yewu@cmss.chinamobile.com","username":"lijiale"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},{"value":1,"date":"2018-11-26 18:15:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27181,"name":"lijiale","email":"lijiale_yewu@cmss.chinamobile.com","username":"lijiale"},{"value":2,"date":"2018-11-27 07:09:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"value":1,"date":"2018-11-26 14:55:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29470,"name":"tangyu","email":"tangyu@cmss.chinamobile.com","username":"ttyy"},{"value":2,"date":"2018-11-27 06:51:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},{"value":0,"_account_id":27181,"name":"lijiale","email":"lijiale_yewu@cmss.chinamobile.com","username":"lijiale"},{"value":1,"date":"2018-11-27 07:09:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"value":0,"_account_id":29470,"name":"tangyu","email":"tangyu@cmss.chinamobile.com","username":"ttyy"},{"value":0,"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":27181,"name":"lijiale","email":"lijiale_yewu@cmss.chinamobile.com","username":"lijiale"},{"_account_id":29470,"name":"tangyu","email":"tangyu@cmss.chinamobile.com","username":"ttyy"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-11-26 14:55:27.000000000","updated_by":{"_account_id":29470,"name":"tangyu","email":"tangyu@cmss.chinamobile.com","username":"ttyy"},"reviewer":{"_account_id":29470,"name":"tangyu","email":"tangyu@cmss.chinamobile.com","username":"ttyy"},"state":"REVIEWER"},{"updated":"2018-11-26 18:15:35.000000000","updated_by":{"_account_id":27181,"name":"lijiale","email":"lijiale_yewu@cmss.chinamobile.com","username":"lijiale"},"reviewer":{"_account_id":27181,"name":"lijiale","email":"lijiale_yewu@cmss.chinamobile.com","username":"lijiale"},"state":"REVIEWER"},{"updated":"2018-11-27 06:51:21.000000000","updated_by":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"reviewer":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"state":"REVIEWER"},{"updated":"2018-11-27 07:09:56.000000000","updated_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"},{"updated":"2018-11-27 07:21:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"585dd38a2c7bc6da5a50cb29290bf034fecd1769","author":{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},"date":"2018-11-22 16:30:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5cf934c02e0f1bc686f31d4f56b72f15d57f0a73","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-22 18:19:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/09/619609/1/check/openstack-tox-pep8/a93bd75/ : SUCCESS in 5m 01s\n- openstack-tox-py27 http://logs.openstack.org/09/619609/1/check/openstack-tox-py27/863e436/ : SUCCESS in 5m 22s\n- openstack-tox-docs http://logs.openstack.org/09/619609/1/check/openstack-tox-docs/3c465f2/html/ : SUCCESS in 5m 15s\n- openstack-tox-py35 http://logs.openstack.org/09/619609/1/check/openstack-tox-py35/679eaba/ : SUCCESS in 10m 37s\n- openstack-tox-py36 http://logs.openstack.org/09/619609/1/check/openstack-tox-py36/0663067/ : SUCCESS in 12m 35s\n- openstack-tox-cover http://logs.openstack.org/09/619609/1/check/openstack-tox-cover/d97fa83/cover/ : SUCCESS in 5m 47s\n- tacker-functional-devstack-multinode http://logs.openstack.org/09/619609/1/check/tacker-functional-devstack-multinode/3736dfc/ : SUCCESS in 1h 18m 53s (non-voting)\n- tacker-functional-devstack-multinode-python3 http://logs.openstack.org/09/619609/1/check/tacker-functional-devstack-multinode-python3/499f721/ : SUCCESS in 1h 17m 08s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/09/619609/1/check/openstack-tox-lower-constraints/1855e8f/ : SUCCESS in 5m 35s","accounts_in_message":[],"_revision_number":1},{"id":"660d236c216dc762be7d679eb228654318537d6d","author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"date":"2018-11-24 02:16:14.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"cb4c30e41b5391ff939034f880f12b299c3cbb9c","author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"date":"2018-11-26 12:44:49.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"dc2c5b518c73b45ba7d4503b9158dd48e3a6f353","author":{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},"date":"2018-11-26 14:33:54.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0c0257b7fb431de22cb96c264ee5f99451af226d","author":{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},"date":"2018-11-26 14:40:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d221d328c12b93d780767c5acf4c7dd9601ec9dc","author":{"_account_id":29470,"name":"tangyu","email":"tangyu@cmss.chinamobile.com","username":"ttyy"},"date":"2018-11-26 14:55:27.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"21d80fe7f29eeeef0a13fa506d63e720d8c9ba1a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-26 17:22:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/09/619609/2/check/openstack-tox-pep8/ee5e5df/ : SUCCESS in 4m 53s\n- openstack-tox-py27 http://logs.openstack.org/09/619609/2/check/openstack-tox-py27/a447e26/ : SUCCESS in 5m 44s\n- openstack-tox-docs http://logs.openstack.org/09/619609/2/check/openstack-tox-docs/17bc3ea/html/ : SUCCESS in 5m 01s\n- openstack-tox-py35 http://logs.openstack.org/09/619609/2/check/openstack-tox-py35/f66d8bc/ : SUCCESS in 5m 19s\n- openstack-tox-py36 http://logs.openstack.org/09/619609/2/check/openstack-tox-py36/53fc00c/ : SUCCESS in 5m 25s\n- openstack-tox-cover http://logs.openstack.org/09/619609/2/check/openstack-tox-cover/068f9d9/cover/ : SUCCESS in 6m 09s\n- tacker-functional-devstack-multinode http://logs.openstack.org/09/619609/2/check/tacker-functional-devstack-multinode/8dce333/ : SUCCESS in 1h 14m 48s (non-voting)\n- tacker-functional-devstack-multinode-python3 http://logs.openstack.org/09/619609/2/check/tacker-functional-devstack-multinode-python3/eb0e11b/ : SUCCESS in 1h 11m 43s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/09/619609/2/check/openstack-tox-lower-constraints/4d2704c/ : SUCCESS in 5m 20s","accounts_in_message":[],"_revision_number":2},{"id":"8bcd5d79bb0125b859a472e50c3b09b24e6dad76","author":{"_account_id":27181,"name":"lijiale","email":"lijiale_yewu@cmss.chinamobile.com","username":"lijiale"},"date":"2018-11-26 18:15:35.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ed0217c1df20c9383c344c437299e87cd893b462","author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"date":"2018-11-27 06:51:21.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2ff6093b549da70d93c31f845e66f0e572581c3a","author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"date":"2018-11-27 07:09:56.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"90538f8e113edc734c9c67bf75f8e797b039f736","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-27 07:10:34.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"7f49d5a4abd475abeb84a5e2fa94e3105021effc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-27 07:21:16.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"800e9e7f3cda8528fdc33142cef916d3597fae5c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-27 07:21:16.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/09/619609/2/gate/openstack-tox-pep8/e1b0583/ : SUCCESS in 6m 32s\n- openstack-tox-py27 http://logs.openstack.org/09/619609/2/gate/openstack-tox-py27/b6d8c9a/ : SUCCESS in 4m 52s\n- openstack-tox-docs http://logs.openstack.org/09/619609/2/gate/openstack-tox-docs/7fcb4ff/html/ : SUCCESS in 5m 13s\n- openstack-tox-py35 http://logs.openstack.org/09/619609/2/gate/openstack-tox-py35/d60306e/ : SUCCESS in 5m 09s\n- openstack-tox-py36 http://logs.openstack.org/09/619609/2/gate/openstack-tox-py36/ff3b195/ : SUCCESS in 5m 34s\n- openstack-tox-lower-constraints http://logs.openstack.org/09/619609/2/gate/openstack-tox-lower-constraints/a8859a8/ : SUCCESS in 4m 56s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ca437bd223d3d14a31952aa624adc971a21e816b","revisions":{"c33c4a569cbe072bf3d0d16acf8a9a51fa33df8f":{"kind":"REWORK","_number":1,"created":"2018-11-22 16:30:42.000000000","uploader":{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},"ref":"refs/changes/09/619609/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/09/619609/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/09/619609/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/09/619609/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/09/619609/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/09/619609/1"}}},"commit":{"parents":[{"commit":"984db66159e3287a2196130134c67f416680755a","subject":"Merge \"fixed numa node count defined error.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/984db66159e3287a2196130134c67f416680755a"}]}],"author":{"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","date":"2018-11-22 16:09:13.000000000","tz":480},"committer":{"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","date":"2018-11-22 16:09:13.000000000","tz":480},"subject":"Improve UT test_wsgi, reduce code duplication","message":"Improve UT test_wsgi, reduce code duplication\n\nAdd helpers for cases that require PY2 or PY3.\nReduce code duplication in test_wsgi.\n\nChange-Id: Ibd30063ca1a46c7ea5686734835a030386ba06e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/c33c4a569cbe072bf3d0d16acf8a9a51fa33df8f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/c33c4a569cbe072bf3d0d16acf8a9a51fa33df8f"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"984db66159e3287a2196130134c67f416680755a","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"ca437bd223d3d14a31952aa624adc971a21e816b":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2018-11-26 14:40:20.000000000","uploader":{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},"ref":"refs/changes/09/619609/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/09/619609/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/09/619609/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/09/619609/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/09/619609/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/09/619609/2"}}},"commit":{"parents":[{"commit":"92ee4eddcd0bc58cac49df67319f5004363da42c","subject":"Merge \"tosca.policies.tacker.Scaling of tacker_defs.yaml define incorrect\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/92ee4eddcd0bc58cac49df67319f5004363da42c"}]}],"author":{"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","date":"2018-11-22 16:09:13.000000000","tz":480},"committer":{"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","date":"2018-11-26 14:39:22.000000000","tz":480},"subject":"Improve UT test_wsgi, reduce code duplication","message":"Improve UT test_wsgi, reduce code duplication\n\nAdd helpers for cases that require PY2 or PY3.\nReduce code duplication in test_wsgi.\n\nPartially Implements: blueprint test-addition-refactoring\n\nChange-Id: Ibd30063ca1a46c7ea5686734835a030386ba06e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/ca437bd223d3d14a31952aa624adc971a21e816b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/ca437bd223d3d14a31952aa624adc971a21e816b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"92ee4eddcd0bc58cac49df67319f5004363da42c","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}