)]}'
{"id":"openstack%2Ftacker~657729","triplet_id":"openstack%2Ftacker~master~If1f7f60c6c98f90fa57ac79d17a813f0dac13322","project":"openstack/tacker","branch":"master","topic":"code_optimization_in_openstack_module","hashtags":[],"change_id":"If1f7f60c6c98f90fa57ac79d17a813f0dac13322","subject":"Refactor _wait_until_stack_ready method to remove duplicate code","status":"MERGED","created":"2019-05-08 04:26:08.000000000","updated":"2019-05-09 10:58:48.000000000","submitted":"2019-05-09 10:58:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"657729-1557399528021-b00d5b3e","meta_rev_id":"1cd9a7f43511c51fabe7df28ed5d53fad9761d79","_number":657729,"virtual_id_number":657729,"owner":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-05-09 10:58:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"value":0,"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-09 01:19:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"value":2,"date":"2019-05-09 10:45:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"value":1,"date":"2019-05-09 10:45:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-09 01:19:04.000000000","updated_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"},{"updated":"2019-05-09 10:45:26.000000000","updated_by":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"reviewer":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"state":"REVIEWER"},{"updated":"2019-05-09 10:58:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6d5ceee6325e864ffa128a56c1906ed5225c1372","author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"date":"2019-05-08 04:26:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c88c5707460ffe804e7c82f76ef3e181a938c57f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-08 06:03:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/29/657729/1/check/openstack-tox-cover/9b654f5/cover/ : SUCCESS in 6m 17s\n- openstack-tox-lower-constraints http://logs.openstack.org/29/657729/1/check/openstack-tox-lower-constraints/609c928/ : SUCCESS in 6m 40s\n- openstack-tox-pep8 http://logs.openstack.org/29/657729/1/check/openstack-tox-pep8/1c75410/ : SUCCESS in 5m 03s\n- openstack-tox-py27 http://logs.openstack.org/29/657729/1/check/openstack-tox-py27/90e3029/ : SUCCESS in 6m 43s\n- openstack-tox-py36 http://logs.openstack.org/29/657729/1/check/openstack-tox-py36/f548259/ : SUCCESS in 6m 30s\n- openstack-tox-py37 http://logs.openstack.org/29/657729/1/check/openstack-tox-py37/69ef49c/ : SUCCESS in 6m 49s\n- openstack-tox-docs http://logs.openstack.org/29/657729/1/check/openstack-tox-docs/59b0bae/html/ : SUCCESS in 5m 19s\n- tacker-functional-devstack-multinode http://logs.openstack.org/29/657729/1/check/tacker-functional-devstack-multinode/8f73a9c/ : FAILURE in 1h 36m 12s (non-voting)\n- tacker-functional-devstack-multinode-python3 http://logs.openstack.org/29/657729/1/check/tacker-functional-devstack-multinode-python3/4b18969/ : FAILURE in 1h 28m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"28f759498901dd715b57110b37c8a535804450e5","author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"date":"2019-05-09 01:19:04.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks. LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"d6fc353fc8b878e104dc516a02ab39bdfb0c86fb","author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"date":"2019-05-09 10:45:16.000000000","message":"Patch Set 1: Code-Review+2\n\nNice refactoring. Good work.","accounts_in_message":[],"_revision_number":1},{"id":"b52644039557afdf0789dd0f299f26662cf80514","author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"date":"2019-05-09 10:45:26.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"19b31f155505dd10067b325602876f2fed746e1d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-09 10:45:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0bc44ee63b7d1a7e1b9455fcdbc67f9d6d83f03f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-09 10:58:47.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/29/657729/1/gate/openstack-tox-lower-constraints/efe1015/ : SUCCESS in 6m 06s\n- openstack-tox-pep8 http://logs.openstack.org/29/657729/1/gate/openstack-tox-pep8/d90bf13/ : SUCCESS in 7m 27s\n- openstack-tox-py27 http://logs.openstack.org/29/657729/1/gate/openstack-tox-py27/3357e7c/ : SUCCESS in 6m 51s\n- openstack-tox-py36 http://logs.openstack.org/29/657729/1/gate/openstack-tox-py36/1dbc1f1/ : SUCCESS in 6m 25s\n- openstack-tox-py37 http://logs.openstack.org/29/657729/1/gate/openstack-tox-py37/a8b7212/ : SUCCESS in 6m 26s\n- openstack-tox-docs http://logs.openstack.org/29/657729/1/gate/openstack-tox-docs/1c77e6f/html/ : SUCCESS in 4m 48s","accounts_in_message":[],"_revision_number":1},{"id":"79d273f89e7e99b3b8a7e2ec1039b14be8080e2d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-09 10:58:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a14487c93205c8ed5ea0eb2ef7a0848fc63a22fd","revisions":{"a14487c93205c8ed5ea0eb2ef7a0848fc63a22fd":{"kind":"REWORK","_number":1,"created":"2019-05-08 04:26:08.000000000","uploader":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"ref":"refs/changes/29/657729/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/29/657729/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/29/657729/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/29/657729/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/29/657729/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/29/657729/1"}}},"commit":{"parents":[{"commit":"1029e822ea0c5d7b53fc2df68a77fdad2f8af5d6","subject":"Merge \"Replace git.openstack.org URLs with opendev.org URLs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/1029e822ea0c5d7b53fc2df68a77fdad2f8af5d6"}]}],"author":{"name":"Shubham Potale","email":"shubham.potale@nttdata.com","date":"2019-04-16 08:08:49.000000000","tz":330},"committer":{"name":"Shubham Potale","email":"shubham.potale@nttdata.com","date":"2019-05-08 04:25:14.000000000","tz":330},"subject":"Refactor _wait_until_stack_ready method to remove duplicate code","message":"Refactor _wait_until_stack_ready method to remove duplicate code\n\nMade changes to the _wait_until_stack_ready method to make it generic\nfor all *_wait methods so that the duplicate code from the respective\n*_wait methods can be deleted.\n\nChange-Id: If1f7f60c6c98f90fa57ac79d17a813f0dac13322\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/a14487c93205c8ed5ea0eb2ef7a0848fc63a22fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/a14487c93205c8ed5ea0eb2ef7a0848fc63a22fd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
