)]}'
{"tacker/tests/unit/db/utils.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5f407c9bee81c028ef69c1f0c635a85c73deb65a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    return {\u0027vnf\u0027: {u\u0027attributes\u0027: {u\u0027param_values\u0027: \u0027dummy_param\u0027}}}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"def get_dummy_vnf_invalid_config_type_obj():"},{"line_number":168,"context_line":"    return {\u0027vnf\u0027: {u\u0027attributes\u0027: {u\u0027config\u0027: \u0027dummy_config\u0027}}}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1f493fa4_e23b49ce","line":167,"updated":"2020-04-24 04:29:25.000000000","message":"pep8: F811 redefinition of unused \u0027get_dummy_vnf_invalid_config_type_obj\u0027 from line 149","commit_id":"f3917f75e32fa124c4b6b817a0f8e94a2f5f8651"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5f407c9bee81c028ef69c1f0c635a85c73deb65a","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    return {\u0027vnf\u0027: {u\u0027attributes\u0027: {u\u0027config\u0027: \u0027dummy_config\u0027}}}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def get_dummy_vnf_invalid_param_content():"},{"line_number":172,"context_line":"    return {\u0027vnf\u0027: {u\u0027attributes\u0027: {u\u0027param_values\u0027: {}}}}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1f493fa4_c2360de8","line":171,"updated":"2020-04-24 04:29:25.000000000","message":"pep8: F811 redefinition of unused \u0027get_dummy_vnf_invalid_param_content\u0027 from line 153","commit_id":"f3917f75e32fa124c4b6b817a0f8e94a2f5f8651"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5f407c9bee81c028ef69c1f0c635a85c73deb65a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    return {\u0027vnf\u0027: {u\u0027attributes\u0027: {u\u0027param_values\u0027: {}}}}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"def get_dummy_vnf_param_obj():"},{"line_number":176,"context_line":"    return {\u0027vnf\u0027: {u\u0027attributes\u0027: {u\u0027param_values\u0027:"},{"line_number":177,"context_line":"        {\u0027flavor\u0027: \u0027m1.tiny\u0027,"},{"line_number":178,"context_line":"         \u0027reservation_id\u0027: \u002799999999-3925-4c9e-9074-239a902b68d7\u0027}}}}"}],"source_content_type":"text/x-python","patch_set":23,"id":"1f493fa4_2236d1e7","line":175,"updated":"2020-04-24 04:29:25.000000000","message":"pep8: F811 redefinition of unused \u0027get_dummy_vnf_param_obj\u0027 from line 157","commit_id":"f3917f75e32fa124c4b6b817a0f8e94a2f5f8651"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5f407c9bee81c028ef69c1f0c635a85c73deb65a","unresolved":false,"context_lines":[{"line_number":178,"context_line":"         \u0027reservation_id\u0027: \u002799999999-3925-4c9e-9074-239a902b68d7\u0027}}}}"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"def get_dummy_vnf_invalid_param_type_obj():"},{"line_number":182,"context_line":"    return {\u0027vnf\u0027: {u\u0027attributes\u0027: {u\u0027param_values\u0027: \u0027dummy_param\u0027}}}"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1f493fa4_023115ed","line":181,"updated":"2020-04-24 04:29:25.000000000","message":"pep8: F811 redefinition of unused \u0027get_dummy_vnf_invalid_param_type_obj\u0027 from line 163","commit_id":"f3917f75e32fa124c4b6b817a0f8e94a2f5f8651"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5f407c9bee81c028ef69c1f0c635a85c73deb65a","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    return {\u0027vnf\u0027: {\u0027attributes\u0027: {\u0027param_values\u0027: {}}}}"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"def get_dummy_vnf_update_param():"},{"line_number":268,"context_line":"    return {\u0027vnf\u0027: {\u0027attributes\u0027: {\u0027param_values\u0027: update_param_data}}}"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1f493fa4_624d7971","line":267,"updated":"2020-04-24 04:29:25.000000000","message":"pep8: F811 redefinition of unused \u0027get_dummy_vnf_update_param\u0027 from line 251","commit_id":"f3917f75e32fa124c4b6b817a0f8e94a2f5f8651"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5f407c9bee81c028ef69c1f0c635a85c73deb65a","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    return {\u0027vnf\u0027: {\u0027attributes\u0027: {\u0027param_values\u0027: update_param_data}}}"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def get_dummy_vnf_update_new_param():"},{"line_number":272,"context_line":"    return {\u0027vnf\u0027: {\u0027attributes\u0027: {\u0027param_values\u0027: update_new_param_data}}}"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1f493fa4_42503d0b","line":271,"updated":"2020-04-24 04:29:25.000000000","message":"pep8: F811 redefinition of unused \u0027get_dummy_vnf_update_new_param\u0027 from line 255","commit_id":"f3917f75e32fa124c4b6b817a0f8e94a2f5f8651"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5f407c9bee81c028ef69c1f0c635a85c73deb65a","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    return {\u0027vnf\u0027: {\u0027attributes\u0027: {\u0027param_values\u0027: update_new_param_data}}}"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"def get_dummy_vnf_update_invalid_param():"},{"line_number":276,"context_line":"    return {\u0027vnf\u0027: {\u0027attributes\u0027: {\u0027param_values\u0027: update_invalid_param_data}}}"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1f493fa4_a2578102","line":275,"updated":"2020-04-24 04:29:25.000000000","message":"pep8: F811 redefinition of unused \u0027get_dummy_vnf_update_invalid_param\u0027 from line 259","commit_id":"f3917f75e32fa124c4b6b817a0f8e94a2f5f8651"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5f407c9bee81c028ef69c1f0c635a85c73deb65a","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    return {\u0027vnf\u0027: {\u0027attributes\u0027: {\u0027param_values\u0027: update_invalid_param_data}}}"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"def get_dummy_vnf_update_empty_param():"},{"line_number":280,"context_line":"    return {\u0027vnf\u0027: {\u0027attributes\u0027: {\u0027param_values\u0027: {}}}}"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1f493fa4_825a4527","line":279,"updated":"2020-04-24 04:29:25.000000000","message":"pep8: F811 redefinition of unused \u0027get_dummy_vnf_update_empty_param\u0027 from line 263","commit_id":"f3917f75e32fa124c4b6b817a0f8e94a2f5f8651"}],"tacker/vnfm/infra_drivers/kubernetes/k8s/translate_inputs.py":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"23af48ee55cced15f0cbeae1967d9fe23e2ed13e","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                    for key, value in tosca_props.items():"},{"line_number":239,"context_line":"                        if key \u003d\u003d \u0027network_name\u0027:"},{"line_number":240,"context_line":"                            network_names.append(value)"},{"line_number":241,"context_line":"        if len(network_names) \u003e 1:"},{"line_number":242,"context_line":"            pass"},{"line_number":243,"context_line":"        if network_names:"},{"line_number":244,"context_line":"            return network_names"},{"line_number":245,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_35671327","line":242,"range":{"start_line":241,"start_character":8,"end_line":242,"end_character":16},"updated":"2019-09-03 07:16:42.000000000","message":"No more required with multi-interface. This check can be removed.","commit_id":"56851bd5f901de726c03f81a0e72e024c8a98e07"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"d37c2ecf9af5f64d926fd0eaba464510498dd8b9","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                    for key, value in tosca_props.items():"},{"line_number":239,"context_line":"                        if key \u003d\u003d \u0027network_name\u0027:"},{"line_number":240,"context_line":"                            network_names.append(value)"},{"line_number":241,"context_line":"        if len(network_names) \u003e 1:"},{"line_number":242,"context_line":"            pass"},{"line_number":243,"context_line":"        if network_names:"},{"line_number":244,"context_line":"            return network_names"},{"line_number":245,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_d04b2d25","line":242,"range":{"start_line":241,"start_character":8,"end_line":242,"end_character":16},"in_reply_to":"7faddb67_35671327","updated":"2019-09-03 07:54:13.000000000","message":"OK.","commit_id":"56851bd5f901de726c03f81a0e72e024c8a98e07"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"23af48ee55cced15f0cbeae1967d9fe23e2ed13e","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                            network_names.append(value)"},{"line_number":241,"context_line":"        if len(network_names) \u003e 1:"},{"line_number":242,"context_line":"            pass"},{"line_number":243,"context_line":"        if network_names:"},{"line_number":244,"context_line":"            return network_names"},{"line_number":245,"context_line":"        else:"},{"line_number":246,"context_line":"            return None"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_d5779fd0","line":244,"range":{"start_line":243,"start_character":8,"end_line":244,"end_character":32},"updated":"2019-09-03 07:16:42.000000000","message":"we can just return network_names without condition check","commit_id":"56851bd5f901de726c03f81a0e72e024c8a98e07"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"d37c2ecf9af5f64d926fd0eaba464510498dd8b9","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                            network_names.append(value)"},{"line_number":241,"context_line":"        if len(network_names) \u003e 1:"},{"line_number":242,"context_line":"            pass"},{"line_number":243,"context_line":"        if network_names:"},{"line_number":244,"context_line":"            return network_names"},{"line_number":245,"context_line":"        else:"},{"line_number":246,"context_line":"            return None"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_705ef9e9","line":244,"range":{"start_line":243,"start_character":8,"end_line":244,"end_character":32},"in_reply_to":"7faddb67_d5779fd0","updated":"2019-09-03 07:54:13.000000000","message":"OK.","commit_id":"56851bd5f901de726c03f81a0e72e024c8a98e07"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"23af48ee55cced15f0cbeae1967d9fe23e2ed13e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            pass"},{"line_number":243,"context_line":"        if network_names:"},{"line_number":244,"context_line":"            return network_names"},{"line_number":245,"context_line":"        else:"},{"line_number":246,"context_line":"            return None"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @log.log"},{"line_number":249,"context_line":"    def check_mgmt_cp(self, tosca, vdu_name):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_b57a23b8","line":246,"range":{"start_line":245,"start_character":0,"end_line":246,"end_character":23},"updated":"2019-09-03 07:16:42.000000000","message":"can be removed.","commit_id":"56851bd5f901de726c03f81a0e72e024c8a98e07"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"d37c2ecf9af5f64d926fd0eaba464510498dd8b9","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            pass"},{"line_number":243,"context_line":"        if network_names:"},{"line_number":244,"context_line":"            return network_names"},{"line_number":245,"context_line":"        else:"},{"line_number":246,"context_line":"            return None"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @log.log"},{"line_number":249,"context_line":"    def check_mgmt_cp(self, tosca, vdu_name):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_f0718978","line":246,"range":{"start_line":245,"start_character":0,"end_line":246,"end_character":23},"in_reply_to":"7faddb67_b57a23b8","updated":"2019-09-03 07:54:13.000000000","message":"ok.","commit_id":"56851bd5f901de726c03f81a0e72e024c8a98e07"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"72a412347179bff1a68365327cc75e81c8265835","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                        annotations_pad +\u003d \u0027, {\"name\":\"\u0027 + network + \u0027\"}\u0027"},{"line_number":95,"context_line":"                annotations_pad +\u003d \u0027]\u0027"},{"line_number":96,"context_line":"                tosca_kube_obj.annotations \u003d\\"},{"line_number":97,"context_line":"                    {\u0027k8s.v1.cni.cncf.io/networks\u0027: annotations_pad}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            # If connection_point is True, Tacker will manage its service ip"},{"line_number":100,"context_line":"            tosca_kube_obj.mgmt_connection_point \u003d \\"}],"source_content_type":"text/x-python","patch_set":17,"id":"3fa7e38b_b45bf7f6","line":97,"range":{"start_line":97,"start_character":52,"end_line":97,"end_character":67},"updated":"2020-01-24 06:08:55.000000000","message":"Simple question, according to [1], the following description is allowed.\n\n  annotatiions:\n    k8s.v1.cni.cncf.io/networks: nw_name1, nw_name2\n\nSo, can we replace line 89-97 to the following code?\n\n  tasoca_kube_obj.annotations\u003d¥\n    {\u0027k8s.v1.cni.cncf.io/newtorks\u0027: \u0027,\u0027.join(network_names)}\n\n[1] https://github.com/intel/multus-cni/blob/master/doc/how-to-use.md","commit_id":"d1ec782c80cb4956459fa2a003358285b6759b09"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"4827f0c3a36d94edee6bfa62b0a1a7b6ceca186f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                        annotations_pad +\u003d \u0027, {\"name\":\"\u0027 + network + \u0027\"}\u0027"},{"line_number":95,"context_line":"                annotations_pad +\u003d \u0027]\u0027"},{"line_number":96,"context_line":"                tosca_kube_obj.annotations \u003d\\"},{"line_number":97,"context_line":"                    {\u0027k8s.v1.cni.cncf.io/networks\u0027: annotations_pad}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            # If connection_point is True, Tacker will manage its service ip"},{"line_number":100,"context_line":"            tosca_kube_obj.mgmt_connection_point \u003d \\"}],"source_content_type":"text/x-python","patch_set":17,"id":"3fa7e38b_cd8fc175","line":97,"range":{"start_line":97,"start_character":52,"end_line":97,"end_character":67},"in_reply_to":"3fa7e38b_b45bf7f6","updated":"2020-01-30 05:09:26.000000000","message":"Jo, Thank you for your review.\nFirst of all, this implementation use multus-cni. It just use feature of kuryr-kubernetes.\nplease check again:) \n\n[1] https://docs.openstack.org/kuryr-kubernetes/latest/specs/rocky/npwg_spec_support.html","commit_id":"d1ec782c80cb4956459fa2a003358285b6759b09"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"b9657926e557a10bed75b993f6b9e646e8c7690e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        for node_template in vdus:"},{"line_number":82,"context_line":"            vdu_name \u003d node_template.name"},{"line_number":83,"context_line":"            tosca_kube_obj \u003d self.tosca_to_kube_mapping(node_template)"},{"line_number":84,"context_line":"            "},{"line_number":85,"context_line":"        # Find network name in which VDU is attached"},{"line_number":86,"context_line":"            network_names \u003d self.find_networks(tosca, vdu_name)"},{"line_number":87,"context_line":"            if network_names:"}],"source_content_type":"text/x-python","patch_set":18,"id":"df33271e_59ec628e","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":12},"updated":"2020-03-31 12:18:45.000000000","message":"remove space","commit_id":"f408a09268a83a28934c5324cd477ab870ab9666"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"93f37fc3fa9708e7868f7d778e3b321ed4e7c277","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        for node_template in vdus:"},{"line_number":82,"context_line":"            vdu_name \u003d node_template.name"},{"line_number":83,"context_line":"            tosca_kube_obj \u003d self.tosca_to_kube_mapping(node_template)"},{"line_number":84,"context_line":"            "},{"line_number":85,"context_line":"        # Find network name in which VDU is attached"},{"line_number":86,"context_line":"            network_names \u003d self.find_networks(tosca, vdu_name)"},{"line_number":87,"context_line":"            if network_names:"}],"source_content_type":"text/x-python","patch_set":18,"id":"df33271e_939b5564","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":12},"in_reply_to":"df33271e_59ec628e","updated":"2020-04-01 02:42:41.000000000","message":"ok thanks.","commit_id":"f408a09268a83a28934c5324cd477ab870ab9666"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"b9657926e557a10bed75b993f6b9e646e8c7690e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            network_names \u003d self.find_networks(tosca, vdu_name)"},{"line_number":87,"context_line":"            if network_names:"},{"line_number":88,"context_line":"                tosca_kube_obj.network_name \u003d network_names[0]"},{"line_number":89,"context_line":"                annotations_pad \u003d \u0027[\u0027"},{"line_number":90,"context_line":"                for idx, network in enumerate(network_names):"},{"line_number":91,"context_line":"                    if idx \u003d\u003d 0:"},{"line_number":92,"context_line":"                        annotations_pad +\u003d \u0027{\"name\":\"\u0027 + network + \u0027\"}\u0027"},{"line_number":93,"context_line":"                    else:"},{"line_number":94,"context_line":"                        annotations_pad +\u003d \u0027, {\"name\":\"\u0027 + network + \u0027\"}\u0027"},{"line_number":95,"context_line":"                annotations_pad +\u003d \u0027]\u0027"},{"line_number":96,"context_line":"                tosca_kube_obj.annotations \u003d\\"},{"line_number":97,"context_line":"                    {\u0027k8s.v1.cni.cncf.io/networks\u0027: annotations_pad}"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"df33271e_0c0bb6d5","line":95,"range":{"start_line":89,"start_character":16,"end_line":95,"end_character":38},"updated":"2020-03-31 12:18:45.000000000","message":"Faster:\nannotations_pad \u003d str([{\u0027name\u0027: net} for net in network_names])","commit_id":"f408a09268a83a28934c5324cd477ab870ab9666"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"93f37fc3fa9708e7868f7d778e3b321ed4e7c277","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            network_names \u003d self.find_networks(tosca, vdu_name)"},{"line_number":87,"context_line":"            if network_names:"},{"line_number":88,"context_line":"                tosca_kube_obj.network_name \u003d network_names[0]"},{"line_number":89,"context_line":"                annotations_pad \u003d \u0027[\u0027"},{"line_number":90,"context_line":"                for idx, network in enumerate(network_names):"},{"line_number":91,"context_line":"                    if idx \u003d\u003d 0:"},{"line_number":92,"context_line":"                        annotations_pad +\u003d \u0027{\"name\":\"\u0027 + network + \u0027\"}\u0027"},{"line_number":93,"context_line":"                    else:"},{"line_number":94,"context_line":"                        annotations_pad +\u003d \u0027, {\"name\":\"\u0027 + network + \u0027\"}\u0027"},{"line_number":95,"context_line":"                annotations_pad +\u003d \u0027]\u0027"},{"line_number":96,"context_line":"                tosca_kube_obj.annotations \u003d\\"},{"line_number":97,"context_line":"                    {\u0027k8s.v1.cni.cncf.io/networks\u0027: annotations_pad}"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"df33271e_d3c95d59","line":95,"range":{"start_line":89,"start_character":16,"end_line":95,"end_character":38},"in_reply_to":"df33271e_0c0bb6d5","updated":"2020-04-01 02:42:41.000000000","message":"when it puts kube yaml file, it needs \"\" like below.\n k8s.v1.cni.cncf.io/networks: \u0027[{\"name\":\"k8s-multi-10\"}, {\"name\":\"k8s-multi-11\"}]\u0027\n\nSo, I made a code like above.","commit_id":"f408a09268a83a28934c5324cd477ab870ab9666"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f29fdc7f916f1c647c85abcceeda90a9a75cca73","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            network_names \u003d self.find_networks(tosca, vdu_name)"},{"line_number":87,"context_line":"            if network_names:"},{"line_number":88,"context_line":"                tosca_kube_obj.network_name \u003d network_names[0]"},{"line_number":89,"context_line":"                annotations_pad \u003d \u0027[\u0027"},{"line_number":90,"context_line":"                for idx, network in enumerate(network_names):"},{"line_number":91,"context_line":"                    if idx \u003d\u003d 0:"},{"line_number":92,"context_line":"                        annotations_pad +\u003d \u0027{\"name\":\"\u0027 + network + \u0027\"}\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"1f493fa4_3a757a96","line":89,"updated":"2020-04-22 20:05:31.000000000","message":"As Tomi suggested in previous PS, it can be improved. It seems something redundant for the purpose. If double quotation is required, how about this one?\nstr([{\u0027\"name\"\u0027: \u0027\"%s\"\u0027 % net} for net in network_names])","commit_id":"e70122abfc8e9968e1e387800c43785ec53c1c1f"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"2937fd74de55a26a3b1721d58937b7e5ec690f24","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            network_names \u003d self.find_networks(tosca, vdu_name)"},{"line_number":87,"context_line":"            if network_names:"},{"line_number":88,"context_line":"                tosca_kube_obj.network_name \u003d network_names[0]"},{"line_number":89,"context_line":"                annotations_pad \u003d \u0027[\u0027"},{"line_number":90,"context_line":"                for idx, network in enumerate(network_names):"},{"line_number":91,"context_line":"                    if idx \u003d\u003d 0:"},{"line_number":92,"context_line":"                        annotations_pad +\u003d \u0027{\"name\":\"\u0027 + network + \u0027\"}\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"1f493fa4_d3839ca8","line":89,"in_reply_to":"1f493fa4_3a757a96","updated":"2020-04-23 05:57:37.000000000","message":"Hi, Thank you for your comment.\n\nI tested it. But, that result is like below.\n\n    k8s.v1.cni.cncf.io/networks: \u0027[{\u0027\u0027\"name\"\u0027\u0027: \u0027\u0027\"k8s-multi-10\"\u0027\u0027}, {\u0027\u0027\"name\"\u0027\u0027:\u0027\u0027\"k8s-multi-11\"\u0027\u0027}]\u0027\n\n\nIt is supposed to show like below.\n    k8s.v1.cni.cncf.io/networks: \u0027[{\"name\":\"k8s-multi-10\"}, {\"name\":\"k8s-multi-11\"}]\u0027","commit_id":"e70122abfc8e9968e1e387800c43785ec53c1c1f"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"057cc119963081f7a3a532e2628dc3d7fa3b6960","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            network_names \u003d self.find_networks(tosca, vdu_name)"},{"line_number":87,"context_line":"            if network_names:"},{"line_number":88,"context_line":"                tosca_kube_obj.network_name \u003d network_names[0]"},{"line_number":89,"context_line":"                annotations_pad \u003d \u0027[\u0027"},{"line_number":90,"context_line":"                for idx, network in enumerate(network_names):"},{"line_number":91,"context_line":"                    if idx \u003d\u003d 0:"},{"line_number":92,"context_line":"                        annotations_pad +\u003d \u0027{\"name\":\"\u0027 + network + \u0027\"}\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"1f493fa4_d61f0a6e","line":89,"in_reply_to":"1f493fa4_d3839ca8","updated":"2020-04-23 07:11:37.000000000","message":"Oops, sorry for careless mistake. No need spaces and single quotations are remained. It works on my env, how about this one?\n\nstr([{\u0027name\u0027:\u0027%s\u0027 % net} for net in network_names]).\\\n   replace(\"\u0027\", \u0027\"\u0027).replace(\u0027 \u0027, \u0027\u0027)","commit_id":"e70122abfc8e9968e1e387800c43785ec53c1c1f"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"468ee5e91ffaa36784d1875b9a2dbeef9f4beac8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            network_names \u003d self.find_networks(tosca, vdu_name)"},{"line_number":87,"context_line":"            if network_names:"},{"line_number":88,"context_line":"                tosca_kube_obj.network_name \u003d network_names[0]"},{"line_number":89,"context_line":"                annotations_pad \u003d \u0027[\u0027"},{"line_number":90,"context_line":"                for idx, network in enumerate(network_names):"},{"line_number":91,"context_line":"                    if idx \u003d\u003d 0:"},{"line_number":92,"context_line":"                        annotations_pad +\u003d \u0027{\"name\":\"\u0027 + network + \u0027\"}\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"1f493fa4_36774e05","line":89,"in_reply_to":"1f493fa4_d3839ca8","updated":"2020-04-23 06:48:30.000000000","message":"json.dumps([{\"name\": \"%s\" % net} for net in network_names])","commit_id":"e70122abfc8e9968e1e387800c43785ec53c1c1f"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b0cdbb23ab51bdfa0d895b5c86de7b7a64cb319b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            network_names \u003d self.find_networks(tosca, vdu_name)"},{"line_number":87,"context_line":"            if network_names:"},{"line_number":88,"context_line":"                tosca_kube_obj.network_name \u003d network_names[0]"},{"line_number":89,"context_line":"                annotations_pad \u003d \u0027[\u0027"},{"line_number":90,"context_line":"                for idx, network in enumerate(network_names):"},{"line_number":91,"context_line":"                    if idx \u003d\u003d 0:"},{"line_number":92,"context_line":"                        annotations_pad +\u003d \u0027{\"name\":\"\u0027 + network + \u0027\"}\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"1f493fa4_19c5235c","line":89,"in_reply_to":"1f493fa4_d61f0a6e","updated":"2020-04-23 07:35:21.000000000","message":"Thanks Tomi. Your suggestion looks smarter than mine.","commit_id":"e70122abfc8e9968e1e387800c43785ec53c1c1f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4da2d46548a990346fa58a61691402bc7e6bfe48","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        # Find network name in which VDU is attached"},{"line_number":89,"context_line":"            network_names \u003d self.find_networks(tosca, vdu_name)"},{"line_number":90,"context_line":"            if network_names:"},{"line_number":91,"context_line":"                annotations_pad \u003d json.dumps([{\"name\":\"%s\" % net} for net in network_names])"},{"line_number":92,"context_line":"                tosca_kube_obj.annotations \u003d\\"},{"line_number":93,"context_line":"                    {\u0027k8s.v1.cni.cncf.io/networks\u0027: annotations_pad}"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1f493fa4_d2226da4","line":91,"updated":"2020-04-23 13:33:07.000000000","message":"pep8: E231 missing whitespace after \u0027:\u0027","commit_id":"de73cffbd7dc456cfd848a2a8929eba349801118"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4da2d46548a990346fa58a61691402bc7e6bfe48","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        # Find network name in which VDU is attached"},{"line_number":89,"context_line":"            network_names \u003d self.find_networks(tosca, vdu_name)"},{"line_number":90,"context_line":"            if network_names:"},{"line_number":91,"context_line":"                annotations_pad \u003d json.dumps([{\"name\":\"%s\" % net} for net in network_names])"},{"line_number":92,"context_line":"                tosca_kube_obj.annotations \u003d\\"},{"line_number":93,"context_line":"                    {\u0027k8s.v1.cni.cncf.io/networks\u0027: annotations_pad}"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1f493fa4_b22521ae","line":91,"updated":"2020-04-23 13:33:07.000000000","message":"pep8: E501 line too long (92 \u003e 79 characters)","commit_id":"de73cffbd7dc456cfd848a2a8929eba349801118"}],"tools/test-setup-default-vim.sh":[{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"44b1c0d39186a9e9acc04961872813cb11ecd04d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -xe"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# This script is used to set up default vim"},{"line_number":4,"context_line":"# for functional testing, which cannot be put"},{"line_number":5,"context_line":"# in devstack/plugin.sh because new zuul3 CI"},{"line_number":6,"context_line":"# cannot keep the devstack plugins order"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"7faddb67_456fa45f","side":"PARENT","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":40},"updated":"2019-08-30 03:35:04.000000000","message":"why is this file deleted? It causes functional test cases failed I think.","commit_id":"6bcdfa6220b43dc378075ecb8b6e16ec78852785"}]}