)]}'
{"doc/source/_static/policy.yaml.sample":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"7425fac50f51852e272ee3c9b99ef3357eb8de3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Decides what is required for the \u0027is_admin:True\u0027 check to succeed."},{"line_number":2,"context_line":"#\"context_is_admin\": \"role:admin\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Default rule for most non-Admin APIs."}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5faad753_6b668cf0","line":1,"updated":"2019-09-09 08:17:49.000000000","message":"I think we don\u0027t need to push this file. Like Nova[1], adding this file to .gitignore is better. Also we need to change tacker/doc/source/conf.py according to [2].\n\n[1] https://github.com/openstack/nova/blob/master/.gitignore#L49\n[2] https://docs.openstack.org/oslo.policy/latest/user/sphinxpolicygen.html","commit_id":"d1b0792354748cbc6e070d92b269175ecc698489"}],"doc/source/configuration/index.rst":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"d711607a39e311d9cde3ac2449ede2883917d0ce","unresolved":false,"context_lines":[{"line_number":44,"context_line":"* :doc:`Sample Policy File \u003csample_policy\u003e`: A sample tacker"},{"line_number":45,"context_line":"  policy file with inline documentation."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. # NOTE(bhagyashris): This is the section where we hide things that we don\u0027t"},{"line_number":48,"context_line":"   # actually want in the table of contents but sphinx build would fail if"},{"line_number":49,"context_line":"   # they aren\u0027t in the toctree somewhere."},{"line_number":50,"context_line":".. toctree::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_3aff9e68","line":47,"range":{"start_line":47,"start_character":10,"end_line":47,"end_character":21},"updated":"2019-09-17 07:53:01.000000000","message":"Please update name, if she not in co-author.","commit_id":"28bc5cc095ad4ad86aa9c30a2d1809f4aef9c4ee"}],"etc/tacker/README-policy.yaml.txt":[{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"85d8c5ac3ccb3affd2708f21a0bef78677944455","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Tacker"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"To generate the sample tacker policy.yaml file, run the following command from"}],"source_content_type":"text/plain","patch_set":11,"id":"5faad753_1330e5e7","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":6},"updated":"2019-09-15 16:59:16.000000000","message":"I think you should change the name of this file because it uses both .yaml and .txt","commit_id":"7e1c334d3af366408cc242a006cb57a5dc2fa751"}],"etc/tacker/policy.yaml.sample":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"7425fac50f51852e272ee3c9b99ef3357eb8de3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Decides what is required for the \u0027is_admin:True\u0027 check to succeed."},{"line_number":2,"context_line":"#\"context_is_admin\": \"role:admin\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Default rule for most non-Admin APIs."}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5faad753_c82a26e6","line":1,"updated":"2019-09-09 08:17:49.000000000","message":"I think we don\u0027t need to push this file. Like Nova[1], adding this file to .gitignore is better.\n\n[1] https://github.com/openstack/nova/blob/master/.gitignore#L37","commit_id":"d1b0792354748cbc6e070d92b269175ecc698489"}],"tacker/context.py":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"d711607a39e311d9cde3ac2449ede2883917d0ce","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        \"\"\""},{"line_number":164,"context_line":"        if target is None:"},{"line_number":165,"context_line":"            target \u003d {\u0027project_id\u0027: self.project_id,"},{"line_number":166,"context_line":"                      \u0027tenant_id\u0027: self.tenant_id,"},{"line_number":167,"context_line":"                      \u0027user_id\u0027: self.user_id}"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            return policy.authorize(self, action, target)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_1ad742c2","line":166,"range":{"start_line":166,"start_character":22,"end_line":166,"end_character":49},"updated":"2019-09-17 07:53:01.000000000","message":"No needs to add both(i.e. project_id, tenant_id), we can remove tenant_id as it deprecated.","commit_id":"28bc5cc095ad4ad86aa9c30a2d1809f4aef9c4ee"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"37acb3f32ffed201be1b74f70bb2cd8637c96a21","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        \"\"\""},{"line_number":164,"context_line":"        if target is None:"},{"line_number":165,"context_line":"            target \u003d {\u0027project_id\u0027: self.project_id,"},{"line_number":166,"context_line":"                      \u0027tenant_id\u0027: self.tenant_id,"},{"line_number":167,"context_line":"                      \u0027user_id\u0027: self.user_id}"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            return policy.authorize(self, action, target)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_54d80652","line":166,"range":{"start_line":166,"start_character":22,"end_line":166,"end_character":49},"in_reply_to":"3fa7e38b_1ad742c2","updated":"2019-09-19 01:23:34.000000000","message":"I agree we should keep project_id only but there is come tight coupling of using tenant_id in Ownercheck class present in policy.py. We need time to understand that code.I think for now, we will remove project_id as we are not referring it in the base policy rules (tacker/policies/base.py).","commit_id":"28bc5cc095ad4ad86aa9c30a2d1809f4aef9c4ee"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"9700b6ec23d92a7e7b751f3b77a3bc683c9c4f40","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        \"\"\""},{"line_number":164,"context_line":"        if target is None:"},{"line_number":165,"context_line":"            target \u003d {\u0027project_id\u0027: self.project_id,"},{"line_number":166,"context_line":"                      \u0027tenant_id\u0027: self.tenant_id,"},{"line_number":167,"context_line":"                      \u0027user_id\u0027: self.user_id}"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            return policy.authorize(self, action, target)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_e4b5c1ef","line":166,"range":{"start_line":166,"start_character":22,"end_line":166,"end_character":49},"in_reply_to":"3fa7e38b_54d80652","updated":"2019-09-19 05:20:32.000000000","message":"+1","commit_id":"28bc5cc095ad4ad86aa9c30a2d1809f4aef9c4ee"}],"tacker/policies/vnf_package.py":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"7425fac50f51852e272ee3c9b99ef3357eb8de3c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"VNFPKGM \u003d \u0027os_nfv_orchestration_api:vnf_packages:%s\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"rules \u003d ["},{"line_number":25,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":26,"context_line":"        name\u003dVNFPKGM % \u0027create\u0027,"},{"line_number":27,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5faad753_a8d56abb","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":6},"updated":"2019-09-09 08:17:49.000000000","message":"missing GET /vnf_packages/vnfd","commit_id":"d1b0792354748cbc6e070d92b269175ecc698489"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"f732b9cb98fb3d4a0f66d821f868fb3801364e13","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"VNFPKGM \u003d \u0027os_nfv_orchestration_api:vnf_packages:%s\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"rules \u003d ["},{"line_number":25,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":26,"context_line":"        name\u003dVNFPKGM % \u0027create\u0027,"},{"line_number":27,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5faad753_2bfad441","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":6},"in_reply_to":"5faad753_a8d56abb","updated":"2019-09-09 08:55:17.000000000","message":"GET /vnf_packages/vnfd will be implemented in the next release.","commit_id":"d1b0792354748cbc6e070d92b269175ecc698489"}]}