)]}'
{"tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"450c0150fbaf7b00866fc41cda74e38ee274511e","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.mock_log.warning.assert_called_once()"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_update_wait(self):"},{"line_number":151,"context_line":"        self._response_in_wait_until_stack_ready([\"CREATE_COMPLETE\"])"},{"line_number":152,"context_line":"        vnf_dict \u003d utils.get_dummy_vnf(status\u003d\u0027PENDING_UPDATE\u0027,"},{"line_number":153,"context_line":"                                       instance_id\u003dself.instance_uuid)"},{"line_number":154,"context_line":"        self.openstack.update_wait(None, None, vnf_dict, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_2c923e4c","line":151,"range":{"start_line":151,"start_character":8,"end_line":151,"end_character":69},"updated":"2019-09-05 04:59:41.000000000","message":"Can we remove this because update_wait no longer call wait_until_stack_ready?","commit_id":"fdb21cde35e2be968d9448a716a7ffe3f8f06944"},{"author":{"_account_id":30198,"name":"Hiroya Nakaya","email":"nakaya.hr@ncos.nec.co.jp","username":"nakkay"},"change_message_id":"73684a942b5e5ec0e219fac65aa45e5e61707a85","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.mock_log.warning.assert_called_once()"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_update_wait(self):"},{"line_number":151,"context_line":"        self._response_in_wait_until_stack_ready([\"CREATE_COMPLETE\"])"},{"line_number":152,"context_line":"        vnf_dict \u003d utils.get_dummy_vnf(status\u003d\u0027PENDING_UPDATE\u0027,"},{"line_number":153,"context_line":"                                       instance_id\u003dself.instance_uuid)"},{"line_number":154,"context_line":"        self.openstack.update_wait(None, None, vnf_dict, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_d24bb984","line":151,"range":{"start_line":151,"start_character":8,"end_line":151,"end_character":69},"in_reply_to":"7faddb67_2c923e4c","updated":"2019-09-09 05:02:08.000000000","message":"This method create heat stack response.\n\nShould I rename function name?","commit_id":"fdb21cde35e2be968d9448a716a7ffe3f8f06944"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"450c0150fbaf7b00866fc41cda74e38ee274511e","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                          None, None, vnf_dict,"},{"line_number":189,"context_line":"                          None)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def test_update_wait_failed_stack_retries_not_0(self):"},{"line_number":192,"context_line":"        self._response_in_wait_until_stack_ready([\"UPDATE_IN_PROGRESS\","},{"line_number":193,"context_line":"                                                 \"FAILED\"])"},{"line_number":194,"context_line":"        vnf_dict \u003d utils.get_dummy_vnf(status\u003d\u0027PENDING_HEAL\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_8ce6d215","line":191,"range":{"start_line":191,"start_character":13,"end_line":191,"end_character":19},"updated":"2019-09-05 04:59:41.000000000","message":"heal","commit_id":"fdb21cde35e2be968d9448a716a7ffe3f8f06944"},{"author":{"_account_id":30198,"name":"Hiroya Nakaya","email":"nakaya.hr@ncos.nec.co.jp","username":"nakkay"},"change_message_id":"6f60a160105f7246a227e3830f4ccb344373878e","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                          None, None, vnf_dict,"},{"line_number":189,"context_line":"                          None)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def test_update_wait_failed_stack_retries_not_0(self):"},{"line_number":192,"context_line":"        self._response_in_wait_until_stack_ready([\"UPDATE_IN_PROGRESS\","},{"line_number":193,"context_line":"                                                 \"FAILED\"])"},{"line_number":194,"context_line":"        vnf_dict \u003d utils.get_dummy_vnf(status\u003d\u0027PENDING_HEAL\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_12595159","line":191,"range":{"start_line":191,"start_character":13,"end_line":191,"end_character":19},"in_reply_to":"7faddb67_8ce6d215","updated":"2019-09-09 05:02:39.000000000","message":"Done","commit_id":"fdb21cde35e2be968d9448a716a7ffe3f8f06944"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"5a76eeef2ac4af4191b34b53c99fdb210718692f","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    def update_wait(self, plugin, context, vnf_dict, auth_attr,"},{"line_number":231,"context_line":"                    region_name\u003dNone):"},{"line_number":232,"context_line":"        # do nothing but checking if the stack exists at the moment"},{"line_number":233,"context_line":"        heatclient \u003d hc.HeatClient(auth_attr, region_name)"},{"line_number":234,"context_line":"        stack \u003d heatclient.get(vnf_dict[\u0027instance_id\u0027])"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        mgmt_ips \u003d self._find_mgmt_ips(stack.outputs)"},{"line_number":237,"context_line":"        if mgmt_ips:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_4dccf1bb","line":234,"range":{"start_line":233,"start_character":8,"end_line":234,"end_character":55},"updated":"2019-09-10 02:46:23.000000000","message":"IMO, you should keep it\n\n\"stack \u003d self._wait_until_stack_ready(vnf_dict[\u0027instance_id\u0027],\n            auth_attr, infra_cnst.STACK_UPDATE_IN_PROGRESS,\n            infra_cnst.STACK_UPDATE_COMPLETE,\n            vnfm.VNFUpdateWaitFailed, region_name\u003dregion_name)\"","commit_id":"3e29adbff9647dacd1cb828da28dae787c9f3630"},{"author":{"_account_id":30198,"name":"Hiroya Nakaya","email":"nakaya.hr@ncos.nec.co.jp","username":"nakkay"},"change_message_id":"add0834c39ecf60b7c6243f3688e067428e5741c","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    def update_wait(self, plugin, context, vnf_dict, auth_attr,"},{"line_number":231,"context_line":"                    region_name\u003dNone):"},{"line_number":232,"context_line":"        # do nothing but checking if the stack exists at the moment"},{"line_number":233,"context_line":"        heatclient \u003d hc.HeatClient(auth_attr, region_name)"},{"line_number":234,"context_line":"        stack \u003d heatclient.get(vnf_dict[\u0027instance_id\u0027])"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        mgmt_ips \u003d self._find_mgmt_ips(stack.outputs)"},{"line_number":237,"context_line":"        if mgmt_ips:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_1f6654ef","line":234,"range":{"start_line":233,"start_character":8,"end_line":234,"end_character":55},"in_reply_to":"3fa7e38b_d8f8dd7d","updated":"2019-09-17 04:21:26.000000000","message":"I think so too.\nWhen it will be added, update_wait should be reverted.","commit_id":"3e29adbff9647dacd1cb828da28dae787c9f3630"},{"author":{"_account_id":30198,"name":"Hiroya Nakaya","email":"nakaya.hr@ncos.nec.co.jp","username":"nakkay"},"change_message_id":"dbbb6462a7c8e23fd8736a4a8f50f6311d2c1db3","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    def update_wait(self, plugin, context, vnf_dict, auth_attr,"},{"line_number":231,"context_line":"                    region_name\u003dNone):"},{"line_number":232,"context_line":"        # do nothing but checking if the stack exists at the moment"},{"line_number":233,"context_line":"        heatclient \u003d hc.HeatClient(auth_attr, region_name)"},{"line_number":234,"context_line":"        stack \u003d heatclient.get(vnf_dict[\u0027instance_id\u0027])"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        mgmt_ips \u003d self._find_mgmt_ips(stack.outputs)"},{"line_number":237,"context_line":"        if mgmt_ips:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_ad6325b1","line":234,"range":{"start_line":233,"start_character":8,"end_line":234,"end_character":55},"in_reply_to":"5faad753_4dccf1bb","updated":"2019-09-10 04:14:03.000000000","message":"why?\n_wait_until_stack_ready is function to wait until complete heat state changed.\nBut I think vnf-update doesn\u0027t change the state.\nDoes vnf-update have some process to change the state of the heat stack?","commit_id":"3e29adbff9647dacd1cb828da28dae787c9f3630"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"1257cc89f148d25e1ea83530e6c7ede69f15bcb4","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    def update_wait(self, plugin, context, vnf_dict, auth_attr,"},{"line_number":231,"context_line":"                    region_name\u003dNone):"},{"line_number":232,"context_line":"        # do nothing but checking if the stack exists at the moment"},{"line_number":233,"context_line":"        heatclient \u003d hc.HeatClient(auth_attr, region_name)"},{"line_number":234,"context_line":"        stack \u003d heatclient.get(vnf_dict[\u0027instance_id\u0027])"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        mgmt_ips \u003d self._find_mgmt_ips(stack.outputs)"},{"line_number":237,"context_line":"        if mgmt_ips:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_d8f8dd7d","line":234,"range":{"start_line":233,"start_character":8,"end_line":234,"end_character":55},"in_reply_to":"5faad753_ad6325b1","updated":"2019-09-16 17:11:10.000000000","message":"+1 Currently, I am okay with that. But in the future, I think we will have functions for updating VNF.","commit_id":"3e29adbff9647dacd1cb828da28dae787c9f3630"}]}