)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":22,"context_line":"and related with HA like switch over because of unsupported in Tacker."},{"line_number":23,"context_line":"So these features will be enhance after adding required."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Co-Authored-By: hyunsik Yang \u003cyangun@dcn.ssu.ac.kr\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Implements: blueprint vnf-rolling-upgrade"},{"line_number":28,"context_line":"Change-Id: I34b82fd40830dd74d0f5ef24a60b3ff465cd4819"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"9f560f44_a7c47b60","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":17},"updated":"2020-08-04 15:44:27.000000000","message":"It should be capitalized.","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":22,"context_line":"and related with HA like switch over because of unsupported in Tacker."},{"line_number":23,"context_line":"So these features will be enhance after adding required."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Co-Authored-By: hyunsik Yang \u003cyangun@dcn.ssu.ac.kr\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Implements: blueprint vnf-rolling-upgrade"},{"line_number":28,"context_line":"Change-Id: I34b82fd40830dd74d0f5ef24a60b3ff465cd4819"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"9f560f44_95bfce5f","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":17},"in_reply_to":"9f560f44_a7c47b60","updated":"2020-08-05 12:07:19.000000000","message":"Done","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"}],"devstack/plugin.sh":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            echo_summary \"Registering default VIM\""},{"line_number":43,"context_line":"            tacker_register_default_vim"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\t    if is_service_enabled ceilometer; then"},{"line_number":46,"context_line":"\t        echo_summary \"Configure maintenance event types\""},{"line_number":47,"context_line":"\t\tconfigure_maintenance_event_types"},{"line_number":48,"context_line":"\t    fi"}],"source_content_type":"text/x-sh","patch_set":15,"id":"9f560f44_ccb6f43e","line":45,"updated":"2020-08-04 15:44:27.000000000","message":"You shouldn\u0027t use tab in here and following lines.","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            echo_summary \"Registering default VIM\""},{"line_number":43,"context_line":"            tacker_register_default_vim"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"\t    if is_service_enabled ceilometer; then"},{"line_number":46,"context_line":"\t        echo_summary \"Configure maintenance event types\""},{"line_number":47,"context_line":"\t\tconfigure_maintenance_event_types"},{"line_number":48,"context_line":"\t    fi"}],"source_content_type":"text/x-sh","patch_set":15,"id":"9f560f44_55a9b621","line":45,"in_reply_to":"9f560f44_ccb6f43e","updated":"2020-08-05 12:07:19.000000000","message":"Done","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"}],"doc/source/reference/maintenance_usage_guide.rst":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":"      Copyright 2020 DCN"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"      Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"      not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_4cf14401","line":2,"updated":"2020-08-04 15:44:27.000000000","message":"Why don\u0027t you use official name instead of abbreviated one?","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":"      Copyright 2020 DCN"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"      Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"      not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_35a6c254","line":2,"in_reply_to":"9f560f44_4cf14401","updated":"2020-08-05 12:07:19.000000000","message":"Done","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"``Sample tosca-template``:"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. sourcecode:: yaml"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    tosca_definitions_version: tosca_simple_profile_for_nfv_1_0_0"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_0c390ca3","line":111,"updated":"2020-08-04 15:44:27.000000000","message":"Just a question. Why do you use alias instead of `code-block`?","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"``Sample tosca-template``:"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. sourcecode:: yaml"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    tosca_definitions_version: tosca_simple_profile_for_nfv_1_0_0"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_9564ee23","line":111,"in_reply_to":"9f560f44_0c390ca3","updated":"2020-08-05 12:07:19.000000000","message":"Done","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"4f30e3694b2e6eb3c5a9b029ceba6f0e0bf6caec","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Tacker allows you to maintenance host with VNF zero impact. Maintenance"},{"line_number":21,"context_line":"workflows will be performed in the ``Fenix`` service by creating a session"},{"line_number":22,"context_line":"which can do scaling, migrating VNFs and patch hosts."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Installation and configurations"},{"line_number":25,"context_line":"-------------------------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"9f560f44_3d37aa4f","line":22,"updated":"2020-08-06 20:16:16.000000000","message":"How about adding link to Fenix documents.\nThis is important information and some setting such as event_pipleline.yaml is Fenix\u0027s requirement.\nConfiguration guide may be needed.\n\nhttps://fenix.readthedocs.io/en/latest/\nhttps://fenix.readthedocs.io/en/latest/configuration/dependencies.html","commit_id":"fd7eb8c42e337db4ab5971a3d3888e46364a7b25"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"1cc59cf2e9fc49156adbc91b6709ee7184d20051","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Tacker allows you to maintenance host with VNF zero impact. Maintenance"},{"line_number":21,"context_line":"workflows will be performed in the ``Fenix`` service by creating a session"},{"line_number":22,"context_line":"which can do scaling, migrating VNFs and patch hosts."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Installation and configurations"},{"line_number":25,"context_line":"-------------------------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"9f560f44_0aec148d","line":22,"in_reply_to":"9f560f44_3d37aa4f","updated":"2020-08-07 08:53:50.000000000","message":"Done","commit_id":"fd7eb8c42e337db4ab5971a3d3888e46364a7b25"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"4f30e3694b2e6eb3c5a9b029ceba6f0e0bf6caec","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Installation and configurations"},{"line_number":25,"context_line":"-------------------------------"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"1. You need Fenix, ceilometer and Aodh OpenStack services."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"2. Modify the below configuration files:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"9f560f44_bd673ab7","line":27,"updated":"2020-08-06 20:16:16.000000000","message":"nit: Ceilometer","commit_id":"fd7eb8c42e337db4ab5971a3d3888e46364a7b25"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"1cc59cf2e9fc49156adbc91b6709ee7184d20051","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Installation and configurations"},{"line_number":25,"context_line":"-------------------------------"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"1. You need Fenix, ceilometer and Aodh OpenStack services."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"2. Modify the below configuration files:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"9f560f44_6a067054","line":27,"in_reply_to":"9f560f44_bd673ab7","updated":"2020-08-07 08:53:50.000000000","message":"Done","commit_id":"fd7eb8c42e337db4ab5971a3d3888e46364a7b25"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"4f30e3694b2e6eb3c5a9b029ceba6f0e0bf6caec","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    sinks:"},{"line_number":36,"context_line":"      - name: event_sink"},{"line_number":37,"context_line":"        transformers:"},{"line_number":38,"context_line":"        publishers:"},{"line_number":39,"context_line":"            - panko://"},{"line_number":40,"context_line":"            - notifier://"}],"source_content_type":"text/x-rst","patch_set":17,"id":"9f560f44_5d837e04","line":37,"updated":"2020-08-06 20:16:16.000000000","message":"Do we need this line? I don\u0027t think transformers setting is important for latest Ceilometer, especially for EventAlarm.\n\nhttps://docs.openstack.org/ceilometer/latest/admin/telemetry-data-pipelines.html#pipeline-configuration","commit_id":"fd7eb8c42e337db4ab5971a3d3888e46364a7b25"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"1cc59cf2e9fc49156adbc91b6709ee7184d20051","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    sinks:"},{"line_number":36,"context_line":"      - name: event_sink"},{"line_number":37,"context_line":"        transformers:"},{"line_number":38,"context_line":"        publishers:"},{"line_number":39,"context_line":"            - panko://"},{"line_number":40,"context_line":"            - notifier://"}],"source_content_type":"text/x-rst","patch_set":17,"id":"9f560f44_4a01ec37","line":37,"in_reply_to":"9f560f44_5d837e04","updated":"2020-08-07 08:53:50.000000000","message":"Done. Yes, you are right. Thanks.","commit_id":"fd7eb8c42e337db4ab5971a3d3888e46364a7b25"}],"setup.cfg":[{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"5afce41107cc433df96b4167f8ebefd1c85a5c72","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    tacker.vnfm.monitor_drivers.ceilometer.ceilometer \u003d tacker.vnfm.monitor_drivers.ceilometer.ceilometer:config_opts"},{"line_number":93,"context_line":"    tacker.vnfm.monitor_drivers.zabbix.zabbix \u003d tacker.vnfm.monitor_drivers.zabbix.zabbix:config_opts"},{"line_number":94,"context_line":"    tacker.alarm_receiver \u003d tacker.alarm_receiver:config_opts"},{"line_number":95,"context_line":"\ttacker.plugins.fenix \u003d tacker.plugins.fenix:config_opts"},{"line_number":96,"context_line":"mistral.actions \u003d"},{"line_number":97,"context_line":"    tacker.vim_ping_action \u003d tacker.nfvo.workflows.vim_monitor.vim_ping_action:PingVimAction"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"1f493fa4_2f95d533","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":1},"updated":"2020-04-28 05:16:40.000000000","message":"spaces","commit_id":"05fb3e62d543244936f17698215b05ad8a55a740"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"4168e5a5993158ba29fa4e078d1f9a53c33715c9","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    tacker.vnfm.monitor_drivers.ceilometer.ceilometer \u003d tacker.vnfm.monitor_drivers.ceilometer.ceilometer:config_opts"},{"line_number":94,"context_line":"    tacker.vnfm.monitor_drivers.zabbix.zabbix \u003d tacker.vnfm.monitor_drivers.zabbix.zabbix:config_opts"},{"line_number":95,"context_line":"    tacker.alarm_receiver \u003d tacker.alarm_receiver:config_opts"},{"line_number":96,"context_line":"\ttacker.plugins.fenix \u003d tacker.plugins.fenix:config_opts"},{"line_number":97,"context_line":"mistral.actions \u003d"},{"line_number":98,"context_line":"    tacker.vim_ping_action \u003d tacker.nfvo.workflows.vim_monitor.vim_ping_action:PingVimAction"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":14,"id":"9f560f44_3c61b506","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":1},"updated":"2020-08-03 07:18:00.000000000","message":"tab to spaces","commit_id":"f1248b68f9370415f6009499a9655aebfc63f80a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    tacker.vnfm.monitor_drivers.zabbix.zabbix \u003d tacker.vnfm.monitor_drivers.zabbix.zabbix:config_opts"},{"line_number":95,"context_line":"    tacker.alarm_receiver \u003d tacker.alarm_receiver:config_opts"},{"line_number":96,"context_line":"    tacker.plugins.fenix \u003d tacker.plugins.fenix:config_opts"},{"line_number":97,"context_line":"mistral.actions \u003d"},{"line_number":98,"context_line":"    tacker.vim_ping_action \u003d tacker.nfvo.workflows.vim_monitor.vim_ping_action:PingVimAction"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"oslo.policy.enforcer \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":15,"id":"9f560f44_6cf7e8d4","line":97,"updated":"2020-08-04 15:44:27.000000000","message":"Although I understand that it is very tiny thing, could you add a blank line here considering code convention?","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    tacker.vnfm.monitor_drivers.zabbix.zabbix \u003d tacker.vnfm.monitor_drivers.zabbix.zabbix:config_opts"},{"line_number":95,"context_line":"    tacker.alarm_receiver \u003d tacker.alarm_receiver:config_opts"},{"line_number":96,"context_line":"    tacker.plugins.fenix \u003d tacker.plugins.fenix:config_opts"},{"line_number":97,"context_line":"mistral.actions \u003d"},{"line_number":98,"context_line":"    tacker.vim_ping_action \u003d tacker.nfvo.workflows.vim_monitor.vim_ping_action:PingVimAction"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"oslo.policy.enforcer \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":15,"id":"9f560f44_d511465f","line":97,"in_reply_to":"9f560f44_6cf7e8d4","updated":"2020-08-05 12:07:19.000000000","message":"Done","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"}],"tacker/alarm_receiver.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"bfa0e42e16724dcda28cb056501674ee80695148","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                try:"},{"line_number":78,"context_line":"                    body_info[\u0027body\u0027] \u003d self.handle_maintenance_body(body_info)"},{"line_number":79,"context_line":"                    del body_info[\u0027reason_data\u0027]"},{"line_number":80,"context_line":"                except Exception as e:"},{"line_number":81,"context_line":"                    return"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                # Update policy and action"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_2df85479","line":80,"updated":"2020-04-27 12:39:45.000000000","message":"pep8: F841 local variable \u0027e\u0027 is assigned to but never used","commit_id":"980ab0ad6543924419681fe9930d0f29e5d24618"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"bfa0e42e16724dcda28cb056501674ee80695148","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        traits_list \u003d body_info[\u0027reason_data\u0027][\u0027event\u0027][\u0027traits\u0027]"},{"line_number":114,"context_line":"        if type(traits_list) is not list:"},{"line_number":115,"context_line":"            return"},{"line_number":116,"context_line":"        for key, _, val in traits_list:"},{"line_number":117,"context_line":"            if val[0] \u003d\u003d \u0027[\u0027 or val[0] \u003d\u003d \u0027{\u0027:"},{"line_number":118,"context_line":"                body[key] \u003d eval(val)"},{"line_number":119,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_8df1a898","line":116,"updated":"2020-04-27 12:39:45.000000000","message":"pep8: F402 import \u0027_\u0027 from line 18 shadowed by loop variable","commit_id":"980ab0ad6543924419681fe9930d0f29e5d24618"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        # Change the body request"},{"line_number":68,"context_line":"        if req.body:"},{"line_number":69,"context_line":"            body_dict \u003d dict()"},{"line_number":70,"context_line":"            resource \u003d redirect[:-1]"},{"line_number":71,"context_line":"            body_dict[resource] \u003d {}"},{"line_number":72,"context_line":"            body_dict[resource].setdefault(\u0027params\u0027, {})"},{"line_number":73,"context_line":"            # Update params in the body request"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_6cca484e","line":70,"updated":"2020-08-04 15:44:27.000000000","message":"It makes the code something unclear. I think it is better to define `resource`  at line 55 first, then `redirect` at the next line instead as below.\n\n```\n55 resource \u003d \u0027trigger\u0027 if info[4] !\u003d \u0027maintenance\u0027 else \u0027maintenance\u0027\n56 redirect \u003d resource + \u0027s\u0027\n```","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        # Change the body request"},{"line_number":68,"context_line":"        if req.body:"},{"line_number":69,"context_line":"            body_dict \u003d dict()"},{"line_number":70,"context_line":"            resource \u003d redirect[:-1]"},{"line_number":71,"context_line":"            body_dict[resource] \u003d {}"},{"line_number":72,"context_line":"            body_dict[resource].setdefault(\u0027params\u0027, {})"},{"line_number":73,"context_line":"            # Update params in the body request"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_d56ae6ea","line":70,"in_reply_to":"9f560f44_6cca484e","updated":"2020-08-05 12:07:19.000000000","message":"Done","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                                    \u0027vnf_uuid\u0027: p[3]}"},{"line_number":107,"context_line":"        return prefix_url, p, params"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def handle_maintenance_body(self, body_info):"},{"line_number":110,"context_line":"        body \u003d {}"},{"line_number":111,"context_line":"        traits_list \u003d body_info[\u0027reason_data\u0027][\u0027event\u0027][\u0027traits\u0027]"},{"line_number":112,"context_line":"        if type(traits_list) is not list:"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_0c646c49","line":109,"updated":"2020-08-04 15:44:27.000000000","message":"It seems better to add prefix `_` because this method is private.","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                                    \u0027vnf_uuid\u0027: p[3]}"},{"line_number":107,"context_line":"        return prefix_url, p, params"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def handle_maintenance_body(self, body_info):"},{"line_number":110,"context_line":"        body \u003d {}"},{"line_number":111,"context_line":"        traits_list \u003d body_info[\u0027reason_data\u0027][\u0027event\u0027][\u0027traits\u0027]"},{"line_number":112,"context_line":"        if type(traits_list) is not list:"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_1578dec1","line":109,"in_reply_to":"9f560f44_0c646c49","updated":"2020-08-05 12:07:19.000000000","message":"Done","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"}],"tacker/objects/heal_vnf_request.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027parameter\u0027: fields.StringField(),"},{"line_number":30,"context_line":"        \u0027cause\u0027: fields.ListOfStringsField(),"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_67ca634e","line":30,"updated":"2020-08-04 15:44:27.000000000","message":"Is this change required?","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027parameter\u0027: fields.StringField(),"},{"line_number":30,"context_line":"        \u0027cause\u0027: fields.ListOfStringsField(),"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_357b62be","line":30,"in_reply_to":"9f560f44_67ca634e","updated":"2020-08-05 12:07:19.000000000","message":"Done","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"}],"tacker/plugins/fenix.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"bfa0e42e16724dcda28cb056501674ee80695148","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import requests"},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_cd2c5004","line":14,"updated":"2020-04-27 12:39:45.000000000","message":"pep8: F401 \u0027uuid\u0027 imported but unused","commit_id":"980ab0ad6543924419681fe9930d0f29e5d24618"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"bfa0e42e16724dcda28cb056501674ee80695148","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            params.update({\u0027data\u0027: data})"},{"line_number":124,"context_line":"            self.request_fenix(context, vnf_dict, params, is_reply\u003dFalse)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def update_instance_group(self, plugin,  context, vnf_dict):"},{"line_number":127,"context_line":"        def get_max_impacted():"},{"line_number":128,"context_line":"            max_impacted \u003d 0"},{"line_number":129,"context_line":"            policy \u003d self._get_scaling_policies(plugin, context, vnf_dict)[0]"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_ad31045d","line":126,"updated":"2020-04-27 12:39:45.000000000","message":"pep8: E241 multiple spaces after \u0027,\u0027","commit_id":"980ab0ad6543924419681fe9930d0f29e5d24618"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"bfa0e42e16724dcda28cb056501674ee80695148","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        maintenance.update({\u0027policy_action\u0027: policy_action})"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _create_prepare_maintenance(self, plugin, context, maintenance):"},{"line_number":202,"context_line":"        self.request_fenix(maintenance, vnf_dict, state\u003dconstants.NACK)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def _create_planned_maintenance(self, plugin, context, maintenance):"},{"line_number":205,"context_line":"        def post_function(context, vnf_dict, status):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_0d33d863","line":202,"updated":"2020-04-27 12:39:45.000000000","message":"pep8: F821 undefined name \u0027vnf_dict\u0027","commit_id":"980ab0ad6543924419681fe9930d0f29e5d24618"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"bfa0e42e16724dcda28cb056501674ee80695148","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            state \u003d constants.ACK if status \u003d\u003d constants.ACTIVE \\"},{"line_number":207,"context_line":"                else constants.NACK"},{"line_number":208,"context_line":"            maintenance[\u0027data\u0027].update({\u0027instance_action\u0027: \u0027OWN_ACTION\u0027})"},{"line_number":209,"context_line":"            self.request_fenix(context, vnf_dict, maintenance,  state)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        vnf_dict \u003d maintenance[\u0027vnf\u0027]"},{"line_number":212,"context_line":"        instances \u003d self._get_instances(context, vnf_dict)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_ed378c4c","line":209,"updated":"2020-04-27 12:39:45.000000000","message":"pep8: E241 multiple spaces after \u0027,\u0027","commit_id":"980ab0ad6543924419681fe9930d0f29e5d24618"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"5afce41107cc433df96b4167f8ebefd1c85a5c72","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":"OPTS \u003d ["},{"line_number":30,"context_line":"    cfg.HostAddressOpt(\u0027host\u0027, default\u003dutils.get_hostname(),"},{"line_number":31,"context_line":"                       help\u003d_(\"The hostname Fenix is running on\")),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027port\u0027, default\u003d12347,"},{"line_number":33,"context_line":"               help\u003d_(\u0027Port of Fenix service\u0027)),"},{"line_number":34,"context_line":"    cfg.IntOpt(\u0027lead_time\u0027, default\u003d40,"},{"line_number":35,"context_line":"               help\u003d_(\u0027Time for migration_type operation\u0027)),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027max_interruption_time\u0027, default\u003d120,"},{"line_number":37,"context_line":"               help\u003d_(\u0027Time for how long live migration can take\u0027)),"},{"line_number":38,"context_line":"    cfg.IntOpt(\u0027recovery_time\u0027, default\u003d2,"},{"line_number":39,"context_line":"               help\u003d_(\u0027Time for migrated node could be fully running state\u0027))"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":"CONF.register_opts(OPTS, \u0027fenix\u0027)"},{"line_number":42,"context_line":"MAINTENANCE_KEYS \u003d ("}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_6f37dd4e","line":39,"range":{"start_line":29,"start_character":0,"end_line":39,"end_character":77},"updated":"2020-04-28 05:16:40.000000000","message":"These should not exist in the VNFM side. Fenix can be discovered: https://opendev.org/x/fenix/src/branch/master/fenix/tools/vnfm.py#L274\nThe other parameters you have here are VNF internal values coming from VNF instance constraints definitions and instance group constraints definitions. Surely if you just make a generic one without introducing those to VNF, then you can have here configurable parameters that will be used on every VNF.","commit_id":"05fb3e62d543244936f17698215b05ad8a55a740"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"5afce41107cc433df96b4167f8ebefd1c85a5c72","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            data[\u0027instance_id\u0027] \u003d instance[\u0027id\u0027]"},{"line_number":111,"context_line":"            data[\u0027group_id\u0027] \u003d group_id"},{"line_number":112,"context_line":"            data[\u0027instance_name\u0027] \u003d instance[\u0027name\u0027]"},{"line_number":113,"context_line":"            data[\u0027migration_type\u0027] \u003d \u0027MIGRATE\u0027"},{"line_number":114,"context_line":"            data[\u0027max_interruption_time\u0027] \u003d \\"},{"line_number":115,"context_line":"                cfg.CONF.fenix.max_interruption_time"},{"line_number":116,"context_line":"            data[\u0027resource_mitigation\u0027] \u003d True"},{"line_number":117,"context_line":"            data[\u0027lead_time\u0027] \u003d cfg.CONF.fenix.lead_time"},{"line_number":118,"context_line":"            params.update({\u0027data\u0027: data})"},{"line_number":119,"context_line":"            self.request_fenix(context, vnf_dict, params, is_reply\u003dFalse)"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_8ffd0970","line":117,"range":{"start_line":113,"start_character":0,"end_line":117,"end_character":56},"updated":"2020-04-28 05:16:40.000000000","message":"Maybe you try to make a generic plugin to start with, but these could otherwise be VNF specific (or like VMs of certain type/flavor that are grouped to same instance group). Anyhow to start a thing like that these should come the at least from static VNF definition or so.","commit_id":"05fb3e62d543244936f17698215b05ad8a55a740"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"5a0771365720e614207468fc04f5987d2f219c52","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        data[\u0027group_id\u0027] \u003d group_id"},{"line_number":132,"context_line":"        data[\u0027project_id\u0027] \u003d vnf_dict[\u0027tenant_id\u0027]"},{"line_number":133,"context_line":"        data[\u0027group_name\u0027] \u003d \u0027tacker_nonha_app_group_%s\u0027 % vnf_dict[\u0027id\u0027]"},{"line_number":134,"context_line":"        data[\u0027anti_affinity_group\u0027] \u003d False"},{"line_number":135,"context_line":"        data[\u0027max_instances_per_host\u0027] \u003d 0"},{"line_number":136,"context_line":"        data[\u0027max_impacted_members\u0027] \u003d get_max_impacted()"},{"line_number":137,"context_line":"        data[\u0027recovery_time\u0027] \u003d cfg.CONF.fenix.recovery_time"},{"line_number":138,"context_line":"        data[\u0027resource_mitigation\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_f21bd2c6","line":135,"range":{"start_line":134,"start_character":8,"end_line":135,"end_character":42},"updated":"2020-04-28 06:35:44.000000000","message":"These come from Nova / Heat template if server group defined and then that server group id could be used in group_id and name in group_name","commit_id":"05fb3e62d543244936f17698215b05ad8a55a740"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"5afce41107cc433df96b4167f8ebefd1c85a5c72","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        params[\u0027url\u0027] \u003d \u0027%s/instance_group/%s\u0027 % (self.endpoint, group_id)"},{"line_number":131,"context_line":"        data[\u0027group_id\u0027] \u003d group_id"},{"line_number":132,"context_line":"        data[\u0027project_id\u0027] \u003d vnf_dict[\u0027tenant_id\u0027]"},{"line_number":133,"context_line":"        data[\u0027group_name\u0027] \u003d \u0027tacker_nonha_app_group_%s\u0027 % vnf_dict[\u0027id\u0027]"},{"line_number":134,"context_line":"        data[\u0027anti_affinity_group\u0027] \u003d False"},{"line_number":135,"context_line":"        data[\u0027max_instances_per_host\u0027] \u003d 0"},{"line_number":136,"context_line":"        data[\u0027max_impacted_members\u0027] \u003d get_max_impacted()"},{"line_number":137,"context_line":"        data[\u0027recovery_time\u0027] \u003d cfg.CONF.fenix.recovery_time"},{"line_number":138,"context_line":"        data[\u0027resource_mitigation\u0027] \u003d True"},{"line_number":139,"context_line":"        params.update({\u0027data\u0027: data})"},{"line_number":140,"context_line":"        self.request_fenix(context, vnf_dict, params, is_reply\u003dFalse)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_2f1af5ca","line":138,"range":{"start_line":133,"start_character":0,"end_line":138,"end_character":42},"updated":"2020-04-28 05:16:40.000000000","message":"Again VNF specific, but guess you cannot have that without support from VNF. The Group is surely made like this if no existing grouping is done for VMs with specific flavor as server group in Nova (in heat template).","commit_id":"05fb3e62d543244936f17698215b05ad8a55a740"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from tacker.vnfm import vim_client"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":"OPTS \u003d ["},{"line_number":30,"context_line":"    cfg.IntOpt(\u0027lead_time\u0027, default\u003d120,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_275d0be9","line":27,"updated":"2020-08-04 15:44:27.000000000","message":"It is not used in this file actually. Why don\u0027t you use decorator `tacker.common.log` as similar to `common_services_plugin.py` for logging events?","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from tacker.vnfm import vim_client"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":"OPTS \u003d ["},{"line_number":30,"context_line":"    cfg.IntOpt(\u0027lead_time\u0027, default\u003d120,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_150f3e37","line":27,"in_reply_to":"9f560f44_275d0be9","updated":"2020-08-05 12:07:19.000000000","message":"Done. Good idea, thanks.","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"}],"tacker/tests/etc/samples/local-vim.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"auth_url: http://127.0.0.1/identity/v3"},{"line_number":2,"context_line":"username: nfv_user"},{"line_number":3,"context_line":"password: devstack"},{"line_number":4,"context_line":"project_name: nfv"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9f560f44_e78af367","line":1,"updated":"2020-08-04 15:44:27.000000000","message":"Just a question. Why do you change it to `v3`? Is it required for this commit?","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"auth_url: http://127.0.0.1/identity/v3"},{"line_number":2,"context_line":"username: nfv_user"},{"line_number":3,"context_line":"password: devstack"},{"line_number":4,"context_line":"project_name: nfv"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9f560f44_954d0e9c","line":1,"in_reply_to":"9f560f44_e78af367","updated":"2020-08-05 12:07:19.000000000","message":"Done, it\u0027s a mistake.","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"}],"tacker/tests/functional/vnfm/test_tosca_vnf_maintenance.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_cc7ef4ad","line":1,"updated":"2020-08-04 15:44:27.000000000","message":"The name of owner of copyright is missing.","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_d543066b","line":1,"in_reply_to":"9f560f44_cc7ef4ad","updated":"2020-08-05 12:07:19.000000000","message":"Done","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                vnf_id, evt_constants.RES_EVT_SCALE,"},{"line_number":131,"context_line":"                evt_constants.PENDING_SCALE_IN, cnt\u003d1)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        def _create_sample_alarm_data(vnf_dict, alarm_dict, state):"},{"line_number":134,"context_line":"            utc_time \u003d datetime.utcnow().strftime(\u0027%Y-%m-%dT%H:%M:%SZ\u0027)"},{"line_number":135,"context_line":"            fake_url \u003d \u0027http://localhost/\u0027"},{"line_number":136,"context_line":"            sample_data \u003d {"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_2c17b053","line":133,"updated":"2020-08-04 15:44:27.000000000","message":"Could you add a comment to describe your intent why you create this sample from the code, or how it is used. It is helpful for maintainers.","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                vnf_id, evt_constants.RES_EVT_SCALE,"},{"line_number":131,"context_line":"                evt_constants.PENDING_SCALE_IN, cnt\u003d1)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        def _create_sample_alarm_data(vnf_dict, alarm_dict, state):"},{"line_number":134,"context_line":"            utc_time \u003d datetime.utcnow().strftime(\u0027%Y-%m-%dT%H:%M:%SZ\u0027)"},{"line_number":135,"context_line":"            fake_url \u003d \u0027http://localhost/\u0027"},{"line_number":136,"context_line":"            sample_data \u003d {"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_75203aad","line":133,"in_reply_to":"9f560f44_2c17b053","updated":"2020-08-05 12:07:19.000000000","message":"Done. As Hyunsik said, I just wanted to test steps of Fenix workflow and show that it\u0027s work with real alarm payload. I added some comments. Thanks to share your opinions.","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"9a13d67e1c5f3c6cae936f560b2baf8964e79f86","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                vnf_id, evt_constants.RES_EVT_SCALE,"},{"line_number":131,"context_line":"                evt_constants.PENDING_SCALE_IN, cnt\u003d1)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        def _create_sample_alarm_data(vnf_dict, alarm_dict, state):"},{"line_number":134,"context_line":"            utc_time \u003d datetime.utcnow().strftime(\u0027%Y-%m-%dT%H:%M:%SZ\u0027)"},{"line_number":135,"context_line":"            fake_url \u003d \u0027http://localhost/\u0027"},{"line_number":136,"context_line":"            sample_data \u003d {"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_c51b5dc7","line":133,"in_reply_to":"9f560f44_2c17b053","updated":"2020-08-05 06:47:52.000000000","message":"In this patches, we defined new event_type and it used Aodh.\nSo, we added this test function to check new event_type and Aodh alarming functions","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"}],"tacker/tosca/utils.py":[{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"1fe6e6523394daaad43f2c93b2c0059d08858850","unresolved":false,"context_lines":[{"line_number":88,"context_line":"deletenodes \u003d (MONITORING, FAILURE, PLACEMENT)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"HEAT_RESOURCE_MAP \u003d {"},{"line_number":91,"context_line":"    \"flavor\": \"OS::Nova::Flavor\","},{"line_number":92,"context_line":"    \"image\": \"OS::Glance::WebImage\","},{"line_number":93,"context_line":"    \u0027maintenance\u0027: \"OS::Aodh::EventAlarm\""},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"SCALE_GROUP_RESOURCE \u003d \"OS::Heat::AutoScalingGroup\""},{"line_number":97,"context_line":"SCALE_POLICY_RESOURCE \u003d \"OS::Heat::ScalingPolicy\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"@log.log"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_3f0a3c1f","line":97,"range":{"start_line":91,"start_character":0,"end_line":97,"end_character":49},"updated":"2020-03-11 06:02:53.000000000","message":"You might consider changing all \" to \u0027","commit_id":"5678abd4fb8be2775ac2521848eb11ce9aabb1d8"}],"tacker/vnfm/infra_drivers/openstack/vdu.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"bfa0e42e16724dcda28cb056501674ee80695148","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        additional_params \u003d self.heal_request_data_obj.additional_params"},{"line_number":55,"context_line":"        for additional_param in additional_params:"},{"line_number":56,"context_line":"            resource_name \u003d additional_param.parameter"},{"line_number":57,"context_line":"            res_status \u003d self._get_resource_status(self.stack_id, resource_name)"},{"line_number":58,"context_line":"            if res_status !\u003d \u0027CHECK_FAILED\u0027:"},{"line_number":59,"context_line":"                self.heat_client.resource_mark_unhealthy("},{"line_number":60,"context_line":"                    stack_id\u003dself.stack_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_6deedcb4","line":57,"updated":"2020-04-27 12:39:45.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"980ab0ad6543924419681fe9930d0f29e5d24618"}],"tacker/vnfm/policy_actions/vdu_autoheal/vdu_autoheal.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"065f0df1899249795455f3b5c03dd85e4b549c62","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                parameter\u003dresource, cause\u003d[cause % resource])"},{"line_number":67,"context_line":"            additional_params.append(additional_params_obj)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if not cause:"},{"line_number":70,"context_line":"            cause \u003d \"Failed to monitor VDU resource \u0027%s\u0027\""},{"line_number":71,"context_line":"        heal_request_data_obj \u003d objects.HealVnfRequest("},{"line_number":72,"context_line":"            stack_id\u003dstack_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_c3d08222","line":69,"updated":"2020-08-04 15:44:27.000000000","message":"This `cause` cannot be empty here. So this `if` statement has no mean.","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"},{"author":{"_account_id":29908,"name":"JangwonLee","email":"jangwon.lee@dcn.ssu.ac.kr","username":"JangwonLee"},"change_message_id":"e568b83f3123d99ccfd752bd87df32f1bb518b09","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                parameter\u003dresource, cause\u003d[cause % resource])"},{"line_number":67,"context_line":"            additional_params.append(additional_params_obj)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if not cause:"},{"line_number":70,"context_line":"            cause \u003d \"Failed to monitor VDU resource \u0027%s\u0027\""},{"line_number":71,"context_line":"        heal_request_data_obj \u003d objects.HealVnfRequest("},{"line_number":72,"context_line":"            stack_id\u003dstack_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_b80be721","line":69,"in_reply_to":"9f560f44_c3d08222","updated":"2020-08-05 12:07:19.000000000","message":"Done. it\u0027s a mistake.","commit_id":"1e0c2b6b311b5b716bd06a6fbd83463dfae25c1b"}]}