)]}'
{"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"63565378377d564aa4ae487b89ddef25bc13144d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            mgmt_ips \u003d self._find_mgmt_ips(stack.outputs)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        if mgmt_ips:"},{"line_number":149,"context_line":"            vnf_dict[\u0027mgmt_ip_address\u0027] \u003d jsonutils.dump_as_bytes(mgmt_ips)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _wait_until_stack_ready(self, vnf_id, auth_attr, wait_status,"},{"line_number":152,"context_line":"                                expected_status, exception_class,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8f1b6fc8","side":"PARENT","line":149,"range":{"start_line":149,"start_character":52,"end_line":149,"end_character":65},"updated":"2019-10-10 09:26:26.000000000","message":"IMO, It is better to  have dump_as_bytes to ensure that the result type is bytes on both Python 2 and Python 3. and update test accordingly.\n\nPlease see the reference for detail: https://docs.openstack.org/oslo.serialization/latest/reference/index.html#oslo_serialization.jsonutils.dump_as_bytes","commit_id":"4e6929c43478edffddd439b562a28a93ae37b835"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"7dd92a012af249464b0812ef30ed0638b0774c8f","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            mgmt_ips \u003d self._find_mgmt_ips(stack.outputs)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        if mgmt_ips:"},{"line_number":149,"context_line":"            vnf_dict[\u0027mgmt_ip_address\u0027] \u003d jsonutils.dump_as_bytes(mgmt_ips)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _wait_until_stack_ready(self, vnf_id, auth_attr, wait_status,"},{"line_number":152,"context_line":"                                expected_status, exception_class,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_9c81eb50","side":"PARENT","line":149,"range":{"start_line":149,"start_character":52,"end_line":149,"end_character":65},"in_reply_to":"3fa7e38b_6dd2a9d3","updated":"2019-10-18 10:15:30.000000000","message":"I would suggest to use helper function as in [1], please see [2] for reference.\n\n[1]: https://review.opendev.org/#/c/639127\n[2]: https://review.opendev.org/#/c/639127/1/tacker/tests/unit/agent/linux/test_utils.py","commit_id":"4e6929c43478edffddd439b562a28a93ae37b835"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"970d72792c30c3d338a1f2c111dee16acedf917f","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            mgmt_ips \u003d self._find_mgmt_ips(stack.outputs)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        if mgmt_ips:"},{"line_number":149,"context_line":"            vnf_dict[\u0027mgmt_ip_address\u0027] \u003d jsonutils.dump_as_bytes(mgmt_ips)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _wait_until_stack_ready(self, vnf_id, auth_attr, wait_status,"},{"line_number":152,"context_line":"                                expected_status, exception_class,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6dd2a9d3","side":"PARENT","line":149,"range":{"start_line":149,"start_character":52,"end_line":149,"end_character":65},"in_reply_to":"3fa7e38b_8f1b6fc8","updated":"2019-10-11 07:16:42.000000000","message":"But if we have dump_as_bytes here, we need to change test side[1] as it fails in Python3. Do you think we should change test side as follows?\n\n  - self.assertEqual(\u0027{\"VDU1\": \"192.168.120.216\"}\u0027,\n  + self.assertEqual(b\u0027{\"VDU1\": \"192.168.120.216\"}\u0027,\n\n[1] https://github.com/openstack/tacker/blob/4e6929c43478edffddd439b562a28a93ae37b835/tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py#L79","commit_id":"4e6929c43478edffddd439b562a28a93ae37b835"}]}