)]}'
{"doc/source/contributor/monitor-api.rst":[{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"4e4a52873dac4868af87fd9817b5af7902785c17","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"::"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  vduN:"},{"line_number":104,"context_line":"    monitoring_policy:"},{"line_number":105,"context_line":"      \u003cmonitoring-driver-name\u003e:"},{"line_number":106,"context_line":"        monitoring_params:"},{"line_number":107,"context_line":"          \u003cparam-name\u003e: \u003cparam-value\u003e"},{"line_number":108,"context_line":"          ..."},{"line_number":109,"context_line":"        actions:"},{"line_number":110,"context_line":"          \u003cevent\u003e: \u003caction-name\u003e"},{"line_number":111,"context_line":"          ..."},{"line_number":112,"context_line":"      ..."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_5baed280","line":110,"range":{"start_line":103,"start_character":0,"end_line":110,"end_character":32},"updated":"2020-02-05 15:50:45.000000000","message":"ditto","commit_id":"cce366ab468d8b23450c3fce6ef9a5afe2f57491"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"4e4a52873dac4868af87fd9817b5af7902785c17","unresolved":false,"context_lines":[{"line_number":124,"context_line":"          failure: respawn"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  vdu2:"},{"line_number":127,"context_line":"    monitoring_policy:"},{"line_number":128,"context_line":"      http-ping:"},{"line_number":129,"context_line":"        monitoring_params:"},{"line_number":130,"context_line":"          port: 8080"},{"line_number":131,"context_line":"          url: ping.cgi"},{"line_number":132,"context_line":"        actions:"},{"line_number":133,"context_line":"          failure: respawn"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"      vdu_scaling_driver:"},{"line_number":136,"context_line":"        monitoring_params:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_7b886e19","line":133,"range":{"start_line":127,"start_character":0,"end_line":133,"end_character":26},"updated":"2020-02-05 15:50:45.000000000","message":"Monitor policy should be placed in properties, can you update it as below reference. \n\nhttps://github.com/openstack/tacker/blob/master/samples/tosca-templates/vnfd/tosca-vnfd-http-monitor.yaml#L18-L32","commit_id":"cce366ab468d8b23450c3fce6ef9a5afe2f57491"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"4e4a52873dac4868af87fd9817b5af7902785c17","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        actions:"},{"line_number":133,"context_line":"          failure: respawn"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"      vdu_scaling_driver:"},{"line_number":136,"context_line":"        monitoring_params:"},{"line_number":137,"context_line":"          resource: cpu"},{"line_number":138,"context_line":"          threshold: 10000"},{"line_number":139,"context_line":"        actions:"},{"line_number":140,"context_line":"          max_foo_reached: scale_up"},{"line_number":141,"context_line":"          min_foo_reached: scale_down"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  vdu3:"},{"line_number":144,"context_line":"    monitoring_policy:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_bbeca6bc","line":141,"range":{"start_line":135,"start_character":0,"end_line":141,"end_character":37},"updated":"2020-02-05 15:50:45.000000000","message":"autoscaling policy is difference, I think we can mention to template as this link:\nhttps://github.com/openstack/tacker/blob/master/samples/tosca-templates/vnfd/tosca-vnfd-alarm-scale.yaml","commit_id":"cce366ab468d8b23450c3fce6ef9a5afe2f57491"}],"doc/source/contributor/vnfd_template_description.rst":[{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"c94ac86fed6803fe97b1cf7671758913c6eb39ab","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        properties:"},{"line_number":124,"context_line":"          monitoring_policy:"},{"line_number":125,"context_line":"            name: ping"},{"line_number":126,"context_line":"              parameters:"},{"line_number":127,"context_line":"                monitoring_delay: 20"},{"line_number":128,"context_line":"                count: 3"},{"line_number":129,"context_line":"                interval: 2"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_819066f4","side":"PARENT","line":126,"range":{"start_line":126,"start_character":13,"end_line":126,"end_character":25},"updated":"2020-02-21 05:31:40.000000000","message":"just wondering why to change it to monitoring_params?\n\nhttps://github.com/openstack/tacker/blob/484c05a898da0392680d2a55a3f33f4fcbacddfd/tacker/tosca/utils.py#L162","commit_id":"889e1211d77ba8b0e6bee2434201a4d7ed136917"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"143f5614bb240e3ff13a1cdb4f47e575c6caed11","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        properties:"},{"line_number":124,"context_line":"          monitoring_policy:"},{"line_number":125,"context_line":"            name: ping"},{"line_number":126,"context_line":"              parameters:"},{"line_number":127,"context_line":"                monitoring_delay: 20"},{"line_number":128,"context_line":"                count: 3"},{"line_number":129,"context_line":"                interval: 2"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_27066276","side":"PARENT","line":126,"range":{"start_line":126,"start_character":13,"end_line":126,"end_character":25},"in_reply_to":"3fa7e38b_242d00fc","updated":"2020-02-21 09:29:06.000000000","message":"No, we are not using/allowing both.\n\nLet me clarify, \"parameters\" and \"monitoring_params\" both are two deferent variables which store the same data, but their scope are different. While the \"parameters\" is in context of yams file, \"monitoring_params\" is in context of Tosca dict, which generated after parsing yams file. we are just using \"parameters\" in our Tosca template(yams file). And when Tosca utils parse monitoring_policy from yams file and generate a dict, it use the variable name \"monitoring_params\" to store \"parameters\". please see the [1] for reference.\n\n\n[1]: https://github.com/openstack/tacker/blob/484c05a898da0392680d2a55a3f33f4fcbacddfd/tacker/tosca/utils.py#L162","commit_id":"889e1211d77ba8b0e6bee2434201a4d7ed136917"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"aa542a4122eb2fc29817f06d42577c754b7a7c4f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        properties:"},{"line_number":124,"context_line":"          monitoring_policy:"},{"line_number":125,"context_line":"            name: ping"},{"line_number":126,"context_line":"              parameters:"},{"line_number":127,"context_line":"                monitoring_delay: 20"},{"line_number":128,"context_line":"                count: 3"},{"line_number":129,"context_line":"                interval: 2"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1fa4df85_52c83354","side":"PARENT","line":126,"range":{"start_line":126,"start_character":13,"end_line":126,"end_character":25},"in_reply_to":"3fa7e38b_27066276","updated":"2020-02-25 09:08:33.000000000","message":"I understood the intentions of these field. I restored \"parameters\".","commit_id":"889e1211d77ba8b0e6bee2434201a4d7ed136917"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"2d74773a481baef74217d4a837ae8a3cdc9b8b63","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        properties:"},{"line_number":124,"context_line":"          monitoring_policy:"},{"line_number":125,"context_line":"            name: ping"},{"line_number":126,"context_line":"              parameters:"},{"line_number":127,"context_line":"                monitoring_delay: 20"},{"line_number":128,"context_line":"                count: 3"},{"line_number":129,"context_line":"                interval: 2"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_848ab40f","side":"PARENT","line":126,"range":{"start_line":126,"start_character":13,"end_line":126,"end_character":25},"in_reply_to":"3fa7e38b_819066f4","updated":"2020-02-21 07:20:05.000000000","message":"I didn\u0027t recognized this code. So this means we are now allowing both of \u0027params\u0027 and \u0027monitoring_params\u0027. But, IMO, we don\u0027t need to support both of \u0027params\u0027 and \u0027monitoring_params\u0027. I think I can delete \u0027parameters\u0027 support, WDYT?","commit_id":"889e1211d77ba8b0e6bee2434201a4d7ed136917"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"e66ba3f5d4730b9db77d0833c9cf198f0f30f058","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        properties:"},{"line_number":124,"context_line":"          monitoring_policy:"},{"line_number":125,"context_line":"            name: ping"},{"line_number":126,"context_line":"              parameters:"},{"line_number":127,"context_line":"                monitoring_delay: 20"},{"line_number":128,"context_line":"                count: 3"},{"line_number":129,"context_line":"                interval: 2"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_242d00fc","side":"PARENT","line":126,"range":{"start_line":126,"start_character":13,"end_line":126,"end_character":25},"in_reply_to":"3fa7e38b_848ab40f","updated":"2020-02-21 07:29:04.000000000","message":"Or should we keep \u0027parameters\u0027 instead of \u0027monitoring_params\u0027?","commit_id":"889e1211d77ba8b0e6bee2434201a4d7ed136917"}]}