)]}'
{"devstack/lib/tacker":[{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"3eafa885d96df54cab44b834a747cfd995c916a5","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    sudo systemctl enable devstack@tacker.service"},{"line_number":155,"context_line":"    sudo systemctl restart devstack@tacker.service"},{"line_number":156,"context_line":"    # Start the Tacker conductor service"},{"line_number":157,"context_line":"    sudo cp $TACKER_DIR/etc/systemd/system/tacker-conductor.service /etc/systemd/system/devstack@tacker-conductor.service"},{"line_number":158,"context_line":"    sudo systemctl enable devstack@tacker-conductor.service"},{"line_number":159,"context_line":"    sudo systemctl restart devstack@tacker-conductor.service"},{"line_number":160,"context_line":"    echo \"Waiting for Tacker to start...\""},{"line_number":161,"context_line":"    if ! timeout $SERVICE_TIMEOUT sh -c \"while ! wget --no-proxy -q -O- $service_protocol://$TACKER_HOST:$service_port; do sleep 1; done\"; then"},{"line_number":162,"context_line":"        die $LINENO \"Tacker did not start\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_9e02f870","line":159,"range":{"start_line":157,"start_character":0,"end_line":159,"end_character":60},"updated":"2020-02-05 16:34:32.000000000","message":"You may miss config opts, I think you can try this \n\nhttps://github.com/openstack/tacker/blob/master/setup.cfg#L75","commit_id":"7b81e9cb7e637f274885ad99c4ee01882233c820"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ec721a641aa2363a36d38b623c8aee7823c51851","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    sudo systemctl enable devstack@tacker.service"},{"line_number":155,"context_line":"    sudo systemctl restart devstack@tacker.service"},{"line_number":156,"context_line":"    # Start the Tacker conductor service"},{"line_number":157,"context_line":"    sudo cp $TACKER_DIR/etc/systemd/system/tacker-conductor.service /etc/systemd/system/devstack@tacker-conductor.service"},{"line_number":158,"context_line":"    sudo systemctl enable devstack@tacker-conductor.service"},{"line_number":159,"context_line":"    sudo systemctl restart devstack@tacker-conductor.service"},{"line_number":160,"context_line":"    echo \"Waiting for Tacker to start...\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"1fa4df85_0453796c","line":157,"updated":"2020-03-11 05:13:53.000000000","message":"I understood that workingDirectory is required in tacker-conductor.service.\nThis is a simple question, the reason why workingDirectory required in tacker.service is because tacker.service also uses Heat-translator for legacy LCM operations, is it right?","commit_id":"c6f9da1a643b755dcbed349a91a923b192d87bc6"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"a1fc544ac24a9ccb59e69dc131fe9cd9230d8671","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    local service_protocol\u003d$TACKER_PROTOCOL"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    # Start tacker conductor"},{"line_number":153,"context_line":"    run_process tacker-conductor \"$TACKER_BIN_DIR/tacker-conductor $cfg_file_options\""},{"line_number":154,"context_line":"    # Start the Tacker service"},{"line_number":155,"context_line":"    sudo cp $TACKER_DIR/etc/systemd/system/tacker.service /etc/systemd/system/devstack@tacker.service"},{"line_number":156,"context_line":"    sudo systemctl enable devstack@tacker.service"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"df33271e_f5a6c053","side":"PARENT","line":153,"range":{"start_line":153,"start_character":3,"end_line":153,"end_character":15},"updated":"2020-04-03 15:12:26.000000000","message":"As a result of removing \"run_process\", I think we should add \"User \u003d $STACK_USER\" to /etc/systemd/system/tacker-conductor.service and tacker.service. Otherwise, tacker processes are started by root user. That might be not a problem but I think better starting by $STACK_USER like other devstack services.","commit_id":"04efad2f112b9c145f7df07d3d9b7f5dbf773ee4"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"7431bb577edfcfd4d6c92c1e80811d12829eb3e8","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    local service_protocol\u003d$TACKER_PROTOCOL"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    # Start tacker conductor"},{"line_number":153,"context_line":"    run_process tacker-conductor \"$TACKER_BIN_DIR/tacker-conductor $cfg_file_options\""},{"line_number":154,"context_line":"    # Start the Tacker service"},{"line_number":155,"context_line":"    sudo cp $TACKER_DIR/etc/systemd/system/tacker.service /etc/systemd/system/devstack@tacker.service"},{"line_number":156,"context_line":"    sudo systemctl enable devstack@tacker.service"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"3f4c43b2_a3835904","side":"PARENT","line":153,"range":{"start_line":153,"start_character":3,"end_line":153,"end_character":15},"in_reply_to":"3f4c43b2_63d2f136","updated":"2020-04-13 02:21:05.000000000","message":"I will add below code in the next PS.\n\niniset -sudo /etc/systemd/system/devstack@tacker.service \"Service\" \"User\" $STACK_USER\n\niniset -sudo /etc/systemd/system/devstack@tacker-conductor.service \"Service\" \"User\" $STACK_USER","commit_id":"04efad2f112b9c145f7df07d3d9b7f5dbf773ee4"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"aa387d1060b64eb09fbbe5a08c802ef475d7d911","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    local service_protocol\u003d$TACKER_PROTOCOL"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    # Start tacker conductor"},{"line_number":153,"context_line":"    run_process tacker-conductor \"$TACKER_BIN_DIR/tacker-conductor $cfg_file_options\""},{"line_number":154,"context_line":"    # Start the Tacker service"},{"line_number":155,"context_line":"    sudo cp $TACKER_DIR/etc/systemd/system/tacker.service /etc/systemd/system/devstack@tacker.service"},{"line_number":156,"context_line":"    sudo systemctl enable devstack@tacker.service"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"3f4c43b2_c3094532","side":"PARENT","line":153,"range":{"start_line":153,"start_character":3,"end_line":153,"end_character":15},"in_reply_to":"3f4c43b2_a3835904","updated":"2020-04-13 03:01:00.000000000","message":"Done","commit_id":"04efad2f112b9c145f7df07d3d9b7f5dbf773ee4"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"76f417142a766d2f645741ac44be9cbec82dca66","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    local service_protocol\u003d$TACKER_PROTOCOL"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    # Start tacker conductor"},{"line_number":153,"context_line":"    run_process tacker-conductor \"$TACKER_BIN_DIR/tacker-conductor $cfg_file_options\""},{"line_number":154,"context_line":"    # Start the Tacker service"},{"line_number":155,"context_line":"    sudo cp $TACKER_DIR/etc/systemd/system/tacker.service /etc/systemd/system/devstack@tacker.service"},{"line_number":156,"context_line":"    sudo systemctl enable devstack@tacker.service"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"3f4c43b2_406ce735","side":"PARENT","line":153,"range":{"start_line":153,"start_character":3,"end_line":153,"end_character":15},"in_reply_to":"3f4c43b2_c3094532","updated":"2020-04-14 14:01:17.000000000","message":"thanks!","commit_id":"04efad2f112b9c145f7df07d3d9b7f5dbf773ee4"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"a0bda2d1acceba10d235f7fc5d2acd1c48016903","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    local service_protocol\u003d$TACKER_PROTOCOL"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    # Start tacker conductor"},{"line_number":153,"context_line":"    run_process tacker-conductor \"$TACKER_BIN_DIR/tacker-conductor $cfg_file_options\""},{"line_number":154,"context_line":"    # Start the Tacker service"},{"line_number":155,"context_line":"    sudo cp $TACKER_DIR/etc/systemd/system/tacker.service /etc/systemd/system/devstack@tacker.service"},{"line_number":156,"context_line":"    sudo systemctl enable devstack@tacker.service"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"3f4c43b2_63d2f136","side":"PARENT","line":153,"range":{"start_line":153,"start_character":3,"end_line":153,"end_character":15},"in_reply_to":"df33271e_d3eea620","updated":"2020-04-13 01:51:57.000000000","message":"tacker.service is always running by root user.\n\nThe systemd files \"tacker.service\" and \"tacker-conductor.service\"  doesn\u0027t include User information under [Service] section.\n\nAlso, the way tacker-conductor.service is started now in the updated patch is same as tacker.service. So I don\u0027t see any issues there.\n\nIf we want to run both tacker.service and tacker-conductor.service using $STACK_USER, we can address this problem in next patch.\n\nWhat do you think?","commit_id":"04efad2f112b9c145f7df07d3d9b7f5dbf773ee4"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"de721c3880fbe8070d159dd6d087c8f32538ef28","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    local service_protocol\u003d$TACKER_PROTOCOL"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    # Start tacker conductor"},{"line_number":153,"context_line":"    run_process tacker-conductor \"$TACKER_BIN_DIR/tacker-conductor $cfg_file_options\""},{"line_number":154,"context_line":"    # Start the Tacker service"},{"line_number":155,"context_line":"    sudo cp $TACKER_DIR/etc/systemd/system/tacker.service /etc/systemd/system/devstack@tacker.service"},{"line_number":156,"context_line":"    sudo systemctl enable devstack@tacker.service"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"df33271e_d3eea620","side":"PARENT","line":153,"range":{"start_line":153,"start_character":3,"end_line":153,"end_character":15},"in_reply_to":"df33271e_f5a6c053","updated":"2020-04-09 14:33:02.000000000","message":"friendly reminder, please check my comment above.","commit_id":"04efad2f112b9c145f7df07d3d9b7f5dbf773ee4"}]}