)]}'
{"tacker/common/csar_utils.py":[{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"18e441ae505918cb275d3a615687894a9d37afd0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    \u0027flavour_description\u0027]})"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        if \u0027flavour_id\u0027 in vnf_properties and\\"},{"line_number":97,"context_line":"                not isinstance(vnf_properties[\u0027flavour_id\u0027], dict):"},{"line_number":98,"context_line":"            flavour.update({\u0027flavour_id\u0027: vnf_properties[\u0027flavour_id\u0027]})"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8b020e71","line":97,"range":{"start_line":97,"start_character":16,"end_line":97,"end_character":65},"updated":"2020-02-17 17:13:27.000000000","message":"I think it\u0027s better to check if vnf_properties[\u0027flavour_id\u0027] returns the same type of flavour_id than dict","commit_id":"db3e0c669793978a0a1a10d1d60566c7d1a7d01d"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"45107ac3115557a9fbccac484e126c940ac67ad9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    \u0027flavour_description\u0027]})"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        if \u0027flavour_id\u0027 in vnf_properties and\\"},{"line_number":97,"context_line":"                not isinstance(vnf_properties[\u0027flavour_id\u0027], dict):"},{"line_number":98,"context_line":"            flavour.update({\u0027flavour_id\u0027: vnf_properties[\u0027flavour_id\u0027]})"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_253c7c2d","line":97,"range":{"start_line":97,"start_character":16,"end_line":97,"end_character":65},"in_reply_to":"3fa7e38b_8b020e71","updated":"2020-03-10 16:23:54.000000000","message":"You can check if vnf_properties[\u0027flavour_id\u0027] is string\nhttps://github.com/openstack/tacker/blob/master/tacker/objects/vnf_deployment_flavour.py#L99","commit_id":"db3e0c669793978a0a1a10d1d60566c7d1a7d01d"}],"tacker/tests/unit/common/test_csar_utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bbe96b0b30f4153cb70d9eb1ce6dd2b610cfb320","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @mock.patch(\u0027tacker.common.csar_utils._extract_csar_zip_file\u0027)"},{"line_number":45,"context_line":"    def test_load_csar_data_with_single_yaml("},{"line_number":46,"context_line":"            self, mock_extract_csar_zip_file):"},{"line_number":47,"context_line":"        file_path \u003d os.path.join("},{"line_number":48,"context_line":"            self.base_path, \"../../etc/samples/\""},{"line_number":49,"context_line":"                            \"sample_vnfpkg_no_meta_single_vnfd.zip\")"},{"line_number":50,"context_line":"        vnf_data, flavours \u003d csar_utils.load_csar_data("}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_1826716a","line":47,"updated":"2020-03-11 14:17:21.000000000","message":"What do you think defining lines below as a private method and making it called from test_load_csar_data_with_single_yaml() and test_load_csar_data() because there are the same without name of zip files?","commit_id":"2d49f39aa2271617117ba1f632630aac1a3d4311"},{"author":{"_account_id":31577,"name":"Ajay Parja","email":"ajay.parja@nttdata.com","username":"ajay-parja"},"change_message_id":"31659304cd566763b6fe37d57ff28326efc49829","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @mock.patch(\u0027tacker.common.csar_utils._extract_csar_zip_file\u0027)"},{"line_number":45,"context_line":"    def test_load_csar_data_with_single_yaml("},{"line_number":46,"context_line":"            self, mock_extract_csar_zip_file):"},{"line_number":47,"context_line":"        file_path \u003d os.path.join("},{"line_number":48,"context_line":"            self.base_path, \"../../etc/samples/\""},{"line_number":49,"context_line":"                            \"sample_vnfpkg_no_meta_single_vnfd.zip\")"},{"line_number":50,"context_line":"        vnf_data, flavours \u003d csar_utils.load_csar_data("}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_fccc2036","line":47,"in_reply_to":"1fa4df85_1826716a","updated":"2020-04-01 16:01:44.000000000","message":"Added the private method to reuse the common code.\nIt is fixed in patch : https://review.opendev.org/#/c/706217/4","commit_id":"2d49f39aa2271617117ba1f632630aac1a3d4311"}]}