)]}'
{"id":"openstack%2Ftacker~707310","triplet_id":"openstack%2Ftacker~master~Id4d50264d1052a09e6ce527b6aab1bb941fdc6af","project":"openstack/tacker","branch":"master","topic":"bug/1862864","hashtags":[],"change_id":"Id4d50264d1052a09e6ce527b6aab1bb941fdc6af","subject":"Delete vnf package if operationalState is DISABLED","status":"MERGED","created":"2020-02-12 04:49:14.000000000","updated":"2020-02-19 13:55:14.000000000","submitted":"2020-02-19 13:52:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"707310-1582120350118-86a07e3f","meta_rev_id":"693cc92d7dbe8495b69d9804959bcf182deda08f","_number":707310,"virtual_id_number":707310,"owner":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-02-19 05:36:26.000000000","_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-19 13:52:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"value":0,"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"all":[{"value":0,"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-02-19 08:58:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"value":2,"date":"2020-02-19 13:35:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"all":[{"value":0,"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"value":1,"date":"2020-02-19 13:35:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-19 08:58:07.000000000","updated_by":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"reviewer":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"state":"REVIEWER"},{"updated":"2020-02-19 13:35:43.000000000","updated_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"},{"updated":"2020-02-19 13:52:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ec7b0328ce16a6817a56fdbc3d41350071b3b5bf","author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"date":"2020-02-12 04:49:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7849427df59121c60f3f17fefdd9f6272cd9ef05","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-12 06:21:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/73044ef9200f49d08226a0e2ef7339cd : SUCCESS in 5m 20s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/91bcda14c29d423db17608319d255e68 : SUCCESS in 6m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/988b2da0f80c4fe3b6ad2f08b46cac38 : SUCCESS in 8m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bf7798e3f5574f41a32fc81ba10f1c2d : SUCCESS in 7m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/370de0249ec14c9eaf90f4a68d72f1e8 : SUCCESS in 8m 03s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/02758581d98f4faa9aa9d691cea8f872 : SUCCESS in 8m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/659ecb9688e34e9791406e884beaba1e : SUCCESS in 9m 55s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c987feed9a8b4a5eb6eac28d7d281365 : SUCCESS in 7m 17s\n- tacker-functional-devstack-multinode-python3 https://zuul.opendev.org/t/openstack/build/224688e9f07b4115b62be9f1797b0c7a : FAILURE in 1h 29m 18s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6846b56af0eae90d8f7d33df5aac833c09e5edab","author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"date":"2020-02-17 16:33:09.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"ff7329cc86224fe07001abb7f0d10daffde4e34a","author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"date":"2020-02-19 03:03:48.000000000","message":"Patch Set 1: Code-Review-2\n\n(4 comments)\n\nLGTM. However we need to implement \"Update VNF Package API\" in advance to this patch because currently there is no way to change oprational_state to DISABLED.","accounts_in_message":[],"_revision_number":1},{"id":"23d10b9e4f33e9f20aa98d99bf9a58eee296e21b","author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"date":"2020-02-19 05:31:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"17da96e832763854d347c77c13501f341d9d02a2","author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"date":"2020-02-19 05:36:26.000000000","message":"Patch Set 2:\n\n\u003e (4 comments)\n \u003e \n \u003e LGTM. However we need to implement \"Update VNF Package API\" in\n \u003e advance to this patch because currently there is no way to change\n \u003e oprational_state to DISABLED.\n\nI have addressed your review comments. I don\u0027t see there is any dependency on \"Update VNF Package API\" as delete API is also validating UsageState to \"IN_USE\".  Presently, in tacker, there is no code to set usageState to \"IN_USE\".\n\nBut I\u0027m fine, if you want to merge this patch after \"Update VNF package API\" patch [1]  is merged.\n\n[1] : https://review.opendev.org/#/c/705891","accounts_in_message":[],"_revision_number":2},{"id":"e6ee6fa38f0b36ccc59aadd851cae81e400d1e2a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-19 07:17:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/35a702ff451548b4ac27dcd416437aa5 : SUCCESS in 5m 23s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/469cf47a6490441ab8c1371ca0881001 : SUCCESS in 6m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/134bb2bb90fa4c49befe82f73bb95c40 : SUCCESS in 7m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9f283deed3c94b84b539d38b4a0e960b : SUCCESS in 5m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ac795325d6b44bdaa1594daeac42e760 : SUCCESS in 7m 33s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e6ffaca2a63042c88eb94fc7512abef6 : SUCCESS in 7m 41s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/036cc2a820904cf7a540de60e0334c4f : SUCCESS in 8m 01s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b0176b80c1764ca394503c8aeb8b81b3 : SUCCESS in 6m 27s\n- tacker-functional-devstack-multinode-python3 https://zuul.opendev.org/t/openstack/build/de017c44edfa40709074147419c6f2bf : FAILURE in 1h 40m 00s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4d830f2009b0544cb3943a967da21215fe181bb0","author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"date":"2020-02-19 08:58:07.000000000","message":"Patch Set 2: Code-Review+2\n\n\u003e \u003e (4 comments)\n \u003e \u003e\n \u003e \u003e LGTM. However we need to implement \"Update VNF Package API\" in\n \u003e \u003e advance to this patch because currently there is no way to change\n \u003e \u003e oprational_state to DISABLED.\n \u003e \n \u003e I have addressed your review comments. I don\u0027t see there is any\n \u003e dependency on \"Update VNF Package API\" as delete API is also\n \u003e validating UsageState to \"IN_USE\".  Presently, in tacker, there is\n \u003e no code to set usageState to \"IN_USE\".\n \u003e \n \u003e But I\u0027m fine, if you want to merge this patch after \"Update VNF\n \u003e package API\" patch [1]  is merged.\n \u003e \n \u003e [1] : https://review.opendev.org/#/c/705891\n\nSorry, my mistake. I thought the operationalState was set to \"ENABLED\" after uploading a VNF package and we needed \"update VNF package API\" to change it to DISABLED.\n\nThis patch is good to fix the bug. However, according to ETSI standard, operationalState after uploading a VNF package should be ENABLED. I think we should fix this in other patch (update VNF package API?).","accounts_in_message":[],"_revision_number":2},{"id":"694cdeb53d758ad03c4d1d72dc3cdc7a871e887f","author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"date":"2020-02-19 13:35:43.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"3b5e7a00703100f86cfd7d53101a62ae1a7336ce","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-19 13:35:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"14dd130bcb923d72aef47fc42ae5c14e158cafbf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-19 13:52:29.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/86855247839140ea946b5cde1427651b : SUCCESS in 6m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/39d99bc8cea14a008bcce66323ca5c12 : SUCCESS in 8m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dadf56f7c70a452facfb4e8f6606831e : SUCCESS in 6m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a12b94f7840b48c1b5d9cc5416880267 : SUCCESS in 10m 25s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/42bb5407c3f04402be1a1a99590f451c : SUCCESS in 9m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b5c3a53293044c47967aa6bead3257a8 : SUCCESS in 8m 05s","accounts_in_message":[],"_revision_number":2},{"id":"062449af5fc9ec25c668a6a4adf671efa243183a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-19 13:52:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"c1d2617891651e23c5cfbb4e400d97b5e71cbdbb","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-19 13:55:14.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-api-ref https://zuul.opendev.org/t/openstack/build/3656a82c4e1a4f668dd7cb65dcbb3b57 : SUCCESS in 2m 14s\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/861b2cfc2c5448dea9901b3b1cf71281 : SUCCESS in 2m 04s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"33f92086f4cf7d42ddd51507a1c00c78315ed5c1","revisions":{"c818be75b8f6c27d07491c74d2b95f7f6ebc35bf":{"kind":"REWORK","_number":1,"created":"2020-02-12 04:49:14.000000000","uploader":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"ref":"refs/changes/10/707310/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/10/707310/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/10/707310/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/10/707310/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/10/707310/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/10/707310/1"}}},"commit":{"parents":[{"commit":"e82d982d7b5c49bcbf0ba8fce5af2b94e06cc857","subject":"Merge \"Delete VNF should fail with 409 error\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/e82d982d7b5c49bcbf0ba8fce5af2b94e06cc857"}]}],"author":{"name":"tpatil","email":"tushar.vitthal.patil@gmail.com","date":"2020-02-12 02:45:20.000000000","tz":0},"committer":{"name":"tpatil","email":"tushar.vitthal.patil@gmail.com","date":"2020-02-12 04:39:16.000000000","tz":0},"subject":"Delete vnf package if usageState is NOT_IN_USE","message":"Delete vnf package if usageState is NOT_IN_USE\n\nVnf package is deleted when it\u0027s usageState is in \u0027IN_USE\u0027.\n\nAs per percondition rule, vnf package can be deleted only when\nit\u0027s operationalState is \u0027DISABLED\u0027 and it\u0027s usageState is \u0027NOT_IN_USE.\n\nThis patch fixes this issue and now vnf package will be deleted only\nwhen it\u0027s operationalState is \u0027DISABLED\u0027 and it\u0027s usageState is \u0027NOT_IN_USE.\n\nNote: I have fixed windows style line ending issue in vnf_packages.inc.\nAlso, updated \u0027Delete VNF Package\u0027 API doc to include 409 error.\n\nChange-Id: Id4d50264d1052a09e6ce527b6aab1bb941fdc6af\nCloses-Bug: #1862864\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/c818be75b8f6c27d07491c74d2b95f7f6ebc35bf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/c818be75b8f6c27d07491c74d2b95f7f6ebc35bf"}]},"branch":"refs/heads/master"},"33f92086f4cf7d42ddd51507a1c00c78315ed5c1":{"kind":"REWORK","_number":2,"created":"2020-02-19 05:31:31.000000000","uploader":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"ref":"refs/changes/10/707310/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/10/707310/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/10/707310/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/10/707310/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/10/707310/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/10/707310/2"}}},"commit":{"parents":[{"commit":"e82d982d7b5c49bcbf0ba8fce5af2b94e06cc857","subject":"Merge \"Delete VNF should fail with 409 error\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/e82d982d7b5c49bcbf0ba8fce5af2b94e06cc857"}]}],"author":{"name":"tpatil","email":"tushar.vitthal.patil@gmail.com","date":"2020-02-12 02:45:20.000000000","tz":0},"committer":{"name":"tpatil","email":"tushar.vitthal.patil@gmail.com","date":"2020-02-19 05:30:47.000000000","tz":0},"subject":"Delete vnf package if operationalState is DISABLED","message":"Delete vnf package if operationalState is DISABLED\n\nPresently, vnf package can be deleted when it\u0027s operationalState is\n\u0027ENABLED\u0027.\n\nAs per pre-condition rule, vnf package can be deleted only when\nit\u0027s operationalState is \u0027DISABLED\u0027 and it\u0027s usageState is \u0027NOT_IN_USE.\n\nThis patch fixes this issue and now vnf package will be deleted only\nwhen it\u0027s operationalState is \u0027DISABLED\u0027 and it\u0027s usageState is \u0027NOT_IN_USE.\n\nNote: I have fixed windows style line ending issue in vnf_packages.inc.\nAlso, updated \u0027Delete VNF Package\u0027 API doc to include 409 error.\n\nChange-Id: Id4d50264d1052a09e6ce527b6aab1bb941fdc6af\nCloses-Bug: #1862864\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/33f92086f4cf7d42ddd51507a1c00c78315ed5c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/33f92086f4cf7d42ddd51507a1c00c78315ed5c1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}