)]}'
{"tacker/api/schemas/vnf_lcm.py":[{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"d27f4926572a07f09427a95d2c2a4362afa9e13f","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        \u0027terminationType\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":207,"context_line":"                            \u0027enum\u0027: [\u0027FORCEFUL\u0027, \u0027GRACEFUL\u0027]},"},{"line_number":208,"context_line":"        \u0027gracefulTerminationTimeout\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: 0},"},{"line_number":209,"context_line":"        \u0027additionalParams\u0027: parameter_types.keyvalue_pairs,"},{"line_number":210,"context_line":"    },"},{"line_number":211,"context_line":"    \u0027required\u0027: [\u0027terminationType\u0027],"},{"line_number":212,"context_line":"    \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f4c43b2_64c5c53c","line":209,"range":{"start_line":209,"start_character":9,"end_line":209,"end_character":25},"updated":"2020-04-14 05:07:55.000000000","message":"This attribute is out of scope in Ussuri so we can delete it.","commit_id":"8202bac0f181bc8760e2b5f9c2646f4fff5785ea"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"12d8fdf0698e7ed56775a9371a443c5ded7c0bad","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        \u0027terminationType\u0027: {\u0027type\u0027: \u0027string\u0027,"},{"line_number":207,"context_line":"                            \u0027enum\u0027: [\u0027FORCEFUL\u0027, \u0027GRACEFUL\u0027]},"},{"line_number":208,"context_line":"        \u0027gracefulTerminationTimeout\u0027: {\u0027type\u0027: \u0027integer\u0027, \u0027minimum\u0027: 0},"},{"line_number":209,"context_line":"        \u0027additionalParams\u0027: parameter_types.keyvalue_pairs,"},{"line_number":210,"context_line":"    },"},{"line_number":211,"context_line":"    \u0027required\u0027: [\u0027terminationType\u0027],"},{"line_number":212,"context_line":"    \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f4c43b2_bf82364e","line":209,"range":{"start_line":209,"start_character":9,"end_line":209,"end_character":25},"in_reply_to":"3f4c43b2_64c5c53c","updated":"2020-04-14 06:08:49.000000000","message":"Done","commit_id":"8202bac0f181bc8760e2b5f9c2646f4fff5785ea"}],"tacker/objects/terminate_vnf_req.py":[{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"d27f4926572a07f09427a95d2c2a4362afa9e13f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            nullable\u003dFalse),"},{"line_number":32,"context_line":"        \u0027graceful_termination_timeout\u0027: fields.IntegerField(nullable\u003dTrue,"},{"line_number":33,"context_line":"                                                            default\u003d0),"},{"line_number":34,"context_line":"        \u0027additional_params\u0027: fields.DictOfStringsField(nullable\u003dTrue,"},{"line_number":35,"context_line":"                                                       default\u003d{})"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"3f4c43b2_e4e6f5e8","line":34,"range":{"start_line":34,"start_character":9,"end_line":34,"end_character":26},"updated":"2020-04-14 05:07:55.000000000","message":"This attribute is out of scope in Ussuri.","commit_id":"8202bac0f181bc8760e2b5f9c2646f4fff5785ea"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"12d8fdf0698e7ed56775a9371a443c5ded7c0bad","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            nullable\u003dFalse),"},{"line_number":32,"context_line":"        \u0027graceful_termination_timeout\u0027: fields.IntegerField(nullable\u003dTrue,"},{"line_number":33,"context_line":"                                                            default\u003d0),"},{"line_number":34,"context_line":"        \u0027additional_params\u0027: fields.DictOfStringsField(nullable\u003dTrue,"},{"line_number":35,"context_line":"                                                       default\u003d{})"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"3f4c43b2_1f97ea92","line":34,"range":{"start_line":34,"start_character":9,"end_line":34,"end_character":26},"in_reply_to":"3f4c43b2_e4e6f5e8","updated":"2020-04-14 06:08:49.000000000","message":"Done","commit_id":"8202bac0f181bc8760e2b5f9c2646f4fff5785ea"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"d27f4926572a07f09427a95d2c2a4362afa9e13f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        termination_type \u003d data_dict.get(\u0027termination_type\u0027)"},{"line_number":52,"context_line":"        graceful_termination_timeout \u003d \\"},{"line_number":53,"context_line":"            data_dict.get(\u0027graceful_termination_timeout\u0027, 0)"},{"line_number":54,"context_line":"        additional_params \u003d data_dict.get(\u0027additional_params\u0027, {})"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        return cls(termination_type\u003dtermination_type,"},{"line_number":57,"context_line":"                   graceful_termination_timeout\u003dgraceful_termination_timeout,"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f4c43b2_a4134db8","line":54,"range":{"start_line":54,"start_character":43,"end_line":54,"end_character":60},"updated":"2020-04-14 05:07:55.000000000","message":"Same as above comment","commit_id":"8202bac0f181bc8760e2b5f9c2646f4fff5785ea"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"12d8fdf0698e7ed56775a9371a443c5ded7c0bad","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        termination_type \u003d data_dict.get(\u0027termination_type\u0027)"},{"line_number":52,"context_line":"        graceful_termination_timeout \u003d \\"},{"line_number":53,"context_line":"            data_dict.get(\u0027graceful_termination_timeout\u0027, 0)"},{"line_number":54,"context_line":"        additional_params \u003d data_dict.get(\u0027additional_params\u0027, {})"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        return cls(termination_type\u003dtermination_type,"},{"line_number":57,"context_line":"                   graceful_termination_timeout\u003dgraceful_termination_timeout,"}],"source_content_type":"text/x-python","patch_set":32,"id":"3f4c43b2_ff931ea2","line":54,"range":{"start_line":54,"start_character":43,"end_line":54,"end_character":60},"in_reply_to":"3f4c43b2_a4134db8","updated":"2020-04-14 06:08:49.000000000","message":"Done","commit_id":"8202bac0f181bc8760e2b5f9c2646f4fff5785ea"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3f1699033bcc4a53dad576bde2802a49c332b070","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                    termination_timeout \u003d \\"},{"line_number":280,"context_line":"                        terminate_vnf_req.graceful_termination_timeout"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"                    if termination_timeout and termination_timeout \u003e 0:"},{"line_number":283,"context_line":"                        time.sleep(termination_timeout)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"            self._vnf_manager.invoke(vim_connection_info.vim_type,"}],"source_content_type":"text/x-python","patch_set":11,"id":"df33271e_842084b2","line":282,"range":{"start_line":282,"start_character":43,"end_line":282,"end_character":70},"updated":"2020-03-27 02:41:41.000000000","message":"IMO, termination_timeout\u003e 0 is guaranteed, so I think it\u0027s not necessary.","commit_id":"ad4a4850a60bd66c005e503ea438d7b9d3f4b49d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"76e8ebd13e01b5c8ab3a03cef6b7019579a531d7","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                    termination_timeout \u003d \\"},{"line_number":280,"context_line":"                        terminate_vnf_req.graceful_termination_timeout"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"                    if termination_timeout and termination_timeout \u003e 0:"},{"line_number":283,"context_line":"                        time.sleep(termination_timeout)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"            self._vnf_manager.invoke(vim_connection_info.vim_type,"}],"source_content_type":"text/x-python","patch_set":11,"id":"df33271e_bc187c84","line":282,"range":{"start_line":282,"start_character":43,"end_line":282,"end_character":70},"in_reply_to":"df33271e_4ee3e0d9","updated":"2020-04-06 10:43:47.000000000","message":"Yes, I understand that is what the specification says.\nI wanted to say that this L282 might be better below.\nif termination_timeout:","commit_id":"ad4a4850a60bd66c005e503ea438d7b9d3f4b49d"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"916ca23943dbfc9c53848446e357b5ee86556961","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                    termination_timeout \u003d \\"},{"line_number":280,"context_line":"                        terminate_vnf_req.graceful_termination_timeout"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"                    if termination_timeout and termination_timeout \u003e 0:"},{"line_number":283,"context_line":"                        time.sleep(termination_timeout)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"            self._vnf_manager.invoke(vim_connection_info.vim_type,"}],"source_content_type":"text/x-python","patch_set":11,"id":"df33271e_4ee3e0d9","line":282,"range":{"start_line":282,"start_character":43,"end_line":282,"end_character":70},"in_reply_to":"df33271e_842084b2","updated":"2020-04-01 09:51:55.000000000","message":"As per ETSI GS NFV-SOL 003 V2.6.1 (2019-04), Table 5.5.2.8-1:, gracefulTerminationTimeout is not a mandatory parameter even if terminationType is GRACEFUL.\n\nHence, this check is necessary.","commit_id":"ad4a4850a60bd66c005e503ea438d7b9d3f4b49d"}]}