)]}'
{"tacker/vnfm/infra_drivers/kubernetes/k8s/translate_outputs.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"c9571f7d018c296c7a89743db8814106218c7ba2","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        if tosca_kube_obj.labels:"},{"line_number":215,"context_line":"            if \u0027selector\u0027 in update_label:"},{"line_number":216,"context_line":"                del update_label[\u0027selector\u0027]"},{"line_number":217,"context_line":"            labels \u003d tosca_kube_obj.labels.copy()"},{"line_number":218,"context_line":"            labels.update(update_label)"},{"line_number":219,"context_line":"        else:"},{"line_number":220,"context_line":"            labels \u003d update_label"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_99fd5db3","line":217,"updated":"2020-03-30 16:35:37.000000000","message":"If you use copy() to avoid the value `tosca_kube_obj.labels` is changed, I think doing update() with `update_label` is more simple like below.\n\nlabels \u003d update_label.update(tosca_kube_obj.labels)","commit_id":"dcca94905717f225c4e3084bceae59a9bb8f4315"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"524f997202b173d2aae7ed6f0fe9903bbcf2bc9d","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        if tosca_kube_obj.labels:"},{"line_number":215,"context_line":"            if \u0027selector\u0027 in update_label:"},{"line_number":216,"context_line":"                del update_label[\u0027selector\u0027]"},{"line_number":217,"context_line":"            labels \u003d tosca_kube_obj.labels.copy()"},{"line_number":218,"context_line":"            labels.update(update_label)"},{"line_number":219,"context_line":"        else:"},{"line_number":220,"context_line":"            labels \u003d update_label"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_f5eefb1f","line":217,"in_reply_to":"df33271e_99fd5db3","updated":"2020-04-01 12:49:38.000000000","message":"I agree that updating `update_label` is better because it is local variable.\nBut I think update() method return nothing.","commit_id":"dcca94905717f225c4e3084bceae59a9bb8f4315"}]}