)]}'
{"id":"openstack%2Ftacker~723854","triplet_id":"openstack%2Ftacker~master~I08423a7c29c7fd5eeabe64276f6e0d208ccec72b","project":"openstack/tacker","branch":"master","topic":"bug/1873440","hashtags":[],"change_id":"I08423a7c29c7fd5eeabe64276f6e0d208ccec72b","subject":"Fix : Register vim if use_barbican is disabled","status":"MERGED","created":"2020-04-28 09:44:42.000000000","updated":"2020-05-14 07:31:19.000000000","submitted":"2020-05-14 06:48:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"723854-1589438915425-fedd4e4a","meta_rev_id":"233c6b47b7640a97b530dbf8b2038821cbd33812","_number":723854,"virtual_id_number":723854,"owner":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-05-01 09:21:13.000000000","_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"value":0,"date":"2020-04-29 10:52:49.000000000","_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},{"value":0,"date":"2020-04-29 10:43:12.000000000","_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-05-14 06:48:35.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},{"value":0,"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"all":[{"value":0,"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"value":0,"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},{"value":2,"date":"2020-05-07 12:50:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},{"value":0,"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},{"value":2,"date":"2020-05-14 06:31:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"all":[{"value":0,"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"value":0,"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},{"value":0,"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},{"value":1,"date":"2020-05-14 06:31:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-28 09:54:22.000000000","updated_by":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"reviewer":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"state":"REVIEWER"},{"updated":"2020-04-28 09:54:29.000000000","updated_by":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"reviewer":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"state":"REVIEWER"},{"updated":"2020-04-29 10:43:12.000000000","updated_by":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"reviewer":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"state":"REVIEWER"},{"updated":"2020-05-01 09:21:13.000000000","updated_by":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"reviewer":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"state":"REVIEWER"},{"updated":"2020-05-07 12:50:24.000000000","updated_by":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"reviewer":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"state":"REVIEWER"},{"updated":"2020-05-14 06:31:44.000000000","updated_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"},{"updated":"2020-05-14 06:48:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"743f6d7e29dc6778568937c88ba3b81f082e8501","author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"date":"2020-04-28 09:44:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3257abca28c4b75b11f41c8e421b8954f2422678","author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"date":"2020-04-28 10:05:55.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"2e82b7ac462f093f01e7df20b67edb59a77e324c","author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"date":"2020-04-29 10:43:12.000000000","message":"Patch Set 2:\n\nIf you could add a test for a non-barbican case to test_openstack_driver.py, I am very happy.","accounts_in_message":[],"_revision_number":2},{"id":"27c594fe1cf9130347a406140a64ba5e51159c16","author":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"date":"2020-04-29 10:52:49.000000000","message":"Patch Set 2:\n\n\u003e If you could add a test for a non-barbican case to\n \u003e test_openstack_driver.py, I am very happy.\n\nThanks, but I haven\u0027t added new test cases because  \u0027test_register_keystone_v3\u0027 is already running with use_barbiacn\u003dFalse\nplease refer the setup https://review.opendev.org/#/c/723854/2/tacker/tests/unit/nfvo/drivers/vim/test_openstack_driver.py@83","accounts_in_message":[],"_revision_number":2},{"id":"52d7b70bbe9be859acb76c6b1fa94997ed91d72d","author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"date":"2020-05-01 09:21:13.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"892464ef56eabafe5860bab00cc27c61a0ef745b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-01 10:38:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/878265fd12384e559feb8104585a5fa1 : SUCCESS in 6m 28s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9e7292d538e649aea1d28561b1abf64c : SUCCESS in 8m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dccf9153a45c4d3da9d1080e39153113 : SUCCESS in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/90208fe15a5b4b8ea1e0ff57ec18251d : SUCCESS in 9m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/076a1c5747d045b6831e93cb39a2267f : SUCCESS in 8m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f8219b16a7df4288b97e7364a15d570f : SUCCESS in 9m 58s\n- tacker-functional-devstack-multinode-python3 https://zuul.opendev.org/t/openstack/build/ad15fcf385e54fd5a96b2e5673141226 : FAILURE in 1h 16m 28s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"95404267de35efbab591c32d57f5f153f17658a0","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2020-05-07 12:50:24.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"aa448613cd643f4746ad427ef2fee0546226103d","author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"date":"2020-05-14 06:31:44.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"de5f3cd5c9700556f3f04d925540c4fb2d25a2cf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-14 06:31:56.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"3aedb943f86450b75d890454db5cbd6b83bd1689","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-14 06:48:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"d15c98a417a727660cad7ba1a163b39ed857cfa2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-14 06:48:35.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3f9cf6063c1a46eab719ee14d4911cf3 : SUCCESS in 11m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d4d7c0c354ca4aeab8d0881d23ecd654 : SUCCESS in 7m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b9d7c92df6f345dfac4ed8affc96a272 : SUCCESS in 13m 42s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/12e9ea1edd6a40a7ba7daffb678c2fbb : SUCCESS in 11m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/883e86aea11b479da0295a0217f0f05a : SUCCESS in 8m 21s","accounts_in_message":[],"_revision_number":2},{"id":"422afad92744db3c3c2ad582bbbc1324a1b3b056","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-14 06:52:15.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ed86627fecbf45e29ed9dd38131fd76a : SUCCESS in 3m 10s","accounts_in_message":[],"_revision_number":2},{"id":"f4dac19b39982260d44d6f2028de912372960845","author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"date":"2020-05-14 07:31:19.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/ussuri as commit 5783b9fff46544e1d50f1d3eafc254095f9f9b99","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"95bce292f4990b9d3c320cdebc2c22fe0ac6948c","revisions":{"2815d040871e011fb3cf0deb5aec90c7b4bb67e4":{"kind":"REWORK","_number":1,"created":"2020-04-28 09:44:42.000000000","uploader":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"ref":"refs/changes/54/723854/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/54/723854/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/54/723854/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/54/723854/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/54/723854/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/54/723854/1"}}},"commit":{"parents":[{"commit":"8a4a035a4808472cc8a9370f7dc202dd11046502","subject":"Merge \"Cleanup of .keys()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/8a4a035a4808472cc8a9370f7dc202dd11046502"}]}],"author":{"name":"Shubham","email":"Shubham.Potale@nttdata.com","date":"2020-04-21 09:13:58.000000000","tz":330},"committer":{"name":"Shubham","email":"Shubham.Potale@nttdata.com","date":"2020-04-28 09:43:42.000000000","tz":330},"subject":"Fix : Register vim if use_barbican is disabled","message":"Fix : Register vim if use_barbican is disabled\n\nIf use_barbican is disabled and if the tacker services are running\nunder Py3, the registration of vim fails with TypeError.\n\nThis patch fixes this issue by writing fernet key in binary mode.\n\nCloses-bug: #1873440\n\nChange-Id: I08423a7c29c7fd5eeabe64276f6e0d208ccec72b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/2815d040871e011fb3cf0deb5aec90c7b4bb67e4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/2815d040871e011fb3cf0deb5aec90c7b4bb67e4"}]},"branch":"refs/heads/master"},"95bce292f4990b9d3c320cdebc2c22fe0ac6948c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-04-28 10:05:55.000000000","uploader":{"_account_id":29236,"name":"Shubham Potale","email":"Shubham.Potale@nttdata.com","username":"shubham.potale"},"ref":"refs/changes/54/723854/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/54/723854/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/54/723854/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/54/723854/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/54/723854/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/54/723854/2"}}},"commit":{"parents":[{"commit":"8a4a035a4808472cc8a9370f7dc202dd11046502","subject":"Merge \"Cleanup of .keys()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/8a4a035a4808472cc8a9370f7dc202dd11046502"}]}],"author":{"name":"Shubham","email":"Shubham.Potale@nttdata.com","date":"2020-04-21 09:13:58.000000000","tz":330},"committer":{"name":"Shubham","email":"Shubham.Potale@nttdata.com","date":"2020-04-28 10:04:39.000000000","tz":330},"subject":"Fix : Register vim if use_barbican is disabled","message":"Fix : Register vim if use_barbican is disabled\n\nIf use_barbican is disabled and if the tacker services are running\nunder Py3, the registration of vim fails with TypeError.\n\nThis patch fixes this issue by writing fernet key in binary mode.\n\nCloses-Bug: #1873440\n\nChange-Id: I08423a7c29c7fd5eeabe64276f6e0d208ccec72b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/95bce292f4990b9d3c320cdebc2c22fe0ac6948c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/95bce292f4990b9d3c320cdebc2c22fe0ac6948c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}