)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9237ffcc6cf3334a5997a87e618a779fa93c54cd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"On the other hand, need it update for Zuul."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Therefore, I will create these update files to outside"},{"line_number":19,"context_line":"of Git manage."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Iad88c7adfe56e926ee0324d94787577ba066989b"},{"line_number":22,"context_line":"Closes-Bug: #1879303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf51134e_a5b7d7d8","line":19,"updated":"2020-06-16 15:54:59.000000000","message":"* Could you make this description simple because it is referred via \"Closes-Bug\".\n* Please list up your changes below simply instead.","commit_id":"7190618d441c4ef5eab999dfa24b4444c40cf335"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"9545246a722c46248f3bad5feb931419001846df","unresolved":false,"context_lines":[{"line_number":16,"context_line":"On the other hand, need it update for Zuul."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Therefore, I will create these update files to outside"},{"line_number":19,"context_line":"of Git manage."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Iad88c7adfe56e926ee0324d94787577ba066989b"},{"line_number":22,"context_line":"Closes-Bug: #1879303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf51134e_6a0b2329","line":19,"in_reply_to":"bf51134e_a5b7d7d8","updated":"2020-06-25 01:31:35.000000000","message":"I made the revised commit message. Would you be able to check it?","commit_id":"7190618d441c4ef5eab999dfa24b4444c40cf335"}],"roles/setup-default-vim/tasks/main.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9237ffcc6cf3334a5997a87e618a779fa93c54cd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"     src\u003d{{ devstack_base_dir }}/tacker/tools/test-setup-default-vim.sh"},{"line_number":5,"context_line":"     dest\u003d{{ zuul_work_dir }}/tools/test-setup-default-vim.sh"},{"line_number":6,"context_line":"     mode\u003d0755"},{"line_number":7,"context_line":"  when: inventory_hostname \u003d\u003d \u0027controller\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Copy test vim file"},{"line_number":10,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_e91361b7","line":7,"updated":"2020-06-16 15:54:59.000000000","message":"nit: it\u0027s better to use \u0027\"\u0027 without some reason for considering the convention. l.14 and followings are same.","commit_id":"7190618d441c4ef5eab999dfa24b4444c40cf335"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"9545246a722c46248f3bad5feb931419001846df","unresolved":false,"context_lines":[{"line_number":4,"context_line":"     src\u003d{{ devstack_base_dir }}/tacker/tools/test-setup-default-vim.sh"},{"line_number":5,"context_line":"     dest\u003d{{ zuul_work_dir }}/tools/test-setup-default-vim.sh"},{"line_number":6,"context_line":"     mode\u003d0755"},{"line_number":7,"context_line":"  when: inventory_hostname \u003d\u003d \u0027controller\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Copy test vim file"},{"line_number":10,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_aa01bb08","line":7,"in_reply_to":"bf51134e_e91361b7","updated":"2020-06-25 01:31:35.000000000","message":"I fixed. Could you please confirm.","commit_id":"7190618d441c4ef5eab999dfa24b4444c40cf335"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9237ffcc6cf3334a5997a87e618a779fa93c54cd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    src: \"{{ devstack_base_dir }}/devstack/.stackenv\""},{"line_number":29,"context_line":"  register: stackenv"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Set auth_uri for keystone authentication"},{"line_number":32,"context_line":"  set_fact:"},{"line_number":33,"context_line":"    auth_uri: \"{{"},{"line_number":34,"context_line":"              stackenv.content"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_e9624116","line":31,"updated":"2020-06-16 15:54:59.000000000","message":"This part looks just a bit unclear what you expect comparing with others. So, you\u0027d better to revise description in \"name\", or add a comment for explaining.","commit_id":"7190618d441c4ef5eab999dfa24b4444c40cf335"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"9545246a722c46248f3bad5feb931419001846df","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    src: \"{{ devstack_base_dir }}/devstack/.stackenv\""},{"line_number":29,"context_line":"  register: stackenv"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Set auth_uri for keystone authentication"},{"line_number":32,"context_line":"  set_fact:"},{"line_number":33,"context_line":"    auth_uri: \"{{"},{"line_number":34,"context_line":"              stackenv.content"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_052b7882","line":31,"in_reply_to":"bf51134e_e9624116","updated":"2020-06-25 01:31:35.000000000","message":"I revised description in \"name\". Could you please confirm.","commit_id":"7190618d441c4ef5eab999dfa24b4444c40cf335"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9237ffcc6cf3334a5997a87e618a779fa93c54cd","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    - inventory_hostname \u003d\u003d \u0027controller\u0027"},{"line_number":52,"context_line":"    - p.stat.exists"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: Replace config file path of setup default vim script"},{"line_number":55,"context_line":"  replace:"},{"line_number":56,"context_line":"     path: \"{{ zuul_work_dir }}/tools/test-setup-default-vim.sh\""},{"line_number":57,"context_line":"     regexp: \u0027(?\u003c\u003dconfig-file )([^ ]+)(?\u003d )\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_697631db","line":54,"updated":"2020-06-16 15:54:59.000000000","message":"Same as comment at l.31.","commit_id":"7190618d441c4ef5eab999dfa24b4444c40cf335"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"401c9a70432aeab0f63a02e7c359122bbe7e8308","unresolved":false,"context_lines":[{"line_number":4,"context_line":"     src\u003d{{ devstack_base_dir }}/tacker/tools/test-setup-default-vim.sh"},{"line_number":5,"context_line":"     dest\u003d{{ zuul_work_dir }}/tools/test-setup-default-vim.sh"},{"line_number":6,"context_line":"     mode\u003d0755"},{"line_number":7,"context_line":"  when: \"inventory_hostname \u003d\u003d \u0027controller\u0027\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Copy test vim file"},{"line_number":10,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bf51134e_da203afa","line":7,"updated":"2020-06-25 08:24:00.000000000","message":"Sorry for my comment was not clear... I suggested you to surround the term `controller` with double quotations.\n\nYou can use both of single or double quotations in YAML, but it\u0027s not so good to mix them without any reason in general. I just suggested you to change this line as following.\n\nwhen: inventory_hostname \u003d\u003d \"controller\"","commit_id":"0562a9ae69488f4796ffeddc47d37593884c22d3"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"41e635cfef641cf31e571de42a7f8b2e948cd62d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"     src\u003d{{ devstack_base_dir }}/tacker/tools/test-setup-default-vim.sh"},{"line_number":5,"context_line":"     dest\u003d{{ zuul_work_dir }}/tools/test-setup-default-vim.sh"},{"line_number":6,"context_line":"     mode\u003d0755"},{"line_number":7,"context_line":"  when: \"inventory_hostname \u003d\u003d \u0027controller\u0027\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Copy test vim file"},{"line_number":10,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bf51134e_6ec47793","line":7,"in_reply_to":"bf51134e_da203afa","updated":"2020-07-03 02:11:01.000000000","message":"I\u0027m sorry. I will fix it according to the fix sample presented.","commit_id":"0562a9ae69488f4796ffeddc47d37593884c22d3"}],"tools/test-setup-default-vim.sh":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9237ffcc6cf3334a5997a87e618a779fa93c54cd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# cannot keep the devstack plugins order"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"openstack vim register \\"},{"line_number":9,"context_line":"\t--os-username nfv_user \\"},{"line_number":10,"context_line":"\t--os-project-name nfv \\"},{"line_number":11,"context_line":"\t--os-password devstack \\"},{"line_number":12,"context_line":"\t--os-auth-url http://127.0.0.1/identity \\"}],"source_content_type":"text/x-sh","patch_set":6,"id":"bf51134e_456a3b80","line":9,"updated":"2020-06-16 15:54:59.000000000","message":"You\u0027d better to avoid using tab characters because it cause problems sometimes.","commit_id":"7190618d441c4ef5eab999dfa24b4444c40cf335"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"9545246a722c46248f3bad5feb931419001846df","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# cannot keep the devstack plugins order"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"openstack vim register \\"},{"line_number":9,"context_line":"\t--os-username nfv_user \\"},{"line_number":10,"context_line":"\t--os-project-name nfv \\"},{"line_number":11,"context_line":"\t--os-password devstack \\"},{"line_number":12,"context_line":"\t--os-auth-url http://127.0.0.1/identity \\"}],"source_content_type":"text/x-sh","patch_set":6,"id":"bf51134e_c534e0e0","line":9,"in_reply_to":"bf51134e_456a3b80","updated":"2020-06-25 01:31:35.000000000","message":"Fixed from tab to space. Could you please confirm.","commit_id":"7190618d441c4ef5eab999dfa24b4444c40cf335"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"401c9a70432aeab0f63a02e7c359122bbe7e8308","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# This script is used to set up default vim"},{"line_number":4,"context_line":"# for functional testing, which cannot be put"},{"line_number":5,"context_line":"# in devstack/plugin.sh because new zuul3 CI"},{"line_number":6,"context_line":"# cannot keep the devstack plugins order"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"openstack vim register \\"},{"line_number":9,"context_line":"    --os-username nfv_user \\"}],"source_content_type":"text/x-sh","patch_set":7,"id":"bf51134e_3a5e9675","line":6,"updated":"2020-06-25 08:24:00.000000000","message":"Could you add a note to explain some of params are intended to be updated from other scripts, and it should not be updated unexpectedly?","commit_id":"0562a9ae69488f4796ffeddc47d37593884c22d3"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"41e635cfef641cf31e571de42a7f8b2e948cd62d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# This script is used to set up default vim"},{"line_number":4,"context_line":"# for functional testing, which cannot be put"},{"line_number":5,"context_line":"# in devstack/plugin.sh because new zuul3 CI"},{"line_number":6,"context_line":"# cannot keep the devstack plugins order"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"openstack vim register \\"},{"line_number":9,"context_line":"    --os-username nfv_user \\"}],"source_content_type":"text/x-sh","patch_set":7,"id":"bf51134e_8ebbcb0c","line":6,"in_reply_to":"bf51134e_3a5e9675","updated":"2020-07-03 02:11:01.000000000","message":"Sure. I will add a explain.","commit_id":"0562a9ae69488f4796ffeddc47d37593884c22d3"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"76d56972e54c2199303aeab2937f39321a0a3532","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# cannot keep the devstack plugins order"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# Also, this script updates the following"},{"line_number":9,"context_line":"# parameter by ansible playbook"},{"line_number":10,"context_line":"# `roles/setup-default-vim/tasks/main.yaml`"},{"line_number":11,"context_line":"# according to the execution environment of"},{"line_number":12,"context_line":"# Zuul."}],"source_content_type":"text/x-sh","patch_set":8,"id":"bf51134e_1e9366a5","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":14},"updated":"2020-07-02 08:49:06.000000000","message":"I think you can add the following words, \"which has been modified unintentionally by\".","commit_id":"e633aeb14807c23d734f89f1992a71e1c4cbf2ba"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"41e635cfef641cf31e571de42a7f8b2e948cd62d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# cannot keep the devstack plugins order"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# Also, this script updates the following"},{"line_number":9,"context_line":"# parameter by ansible playbook"},{"line_number":10,"context_line":"# `roles/setup-default-vim/tasks/main.yaml`"},{"line_number":11,"context_line":"# according to the execution environment of"},{"line_number":12,"context_line":"# Zuul."}],"source_content_type":"text/x-sh","patch_set":8,"id":"bf51134e_8d7c6021","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":14},"in_reply_to":"bf51134e_1e9366a5","updated":"2020-07-03 02:11:01.000000000","message":"Thank you for the confirmation and advice. I will correct this sentences.","commit_id":"e633aeb14807c23d734f89f1992a71e1c4cbf2ba"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"76d56972e54c2199303aeab2937f39321a0a3532","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#  --os-auth-url"},{"line_number":15,"context_line":"#  --config-file"},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# It should not be updated unintentionally"},{"line_number":18,"context_line":"# except at the above timing."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"openstack vim register \\"},{"line_number":21,"context_line":"    --os-username nfv_user \\"}],"source_content_type":"text/x-sh","patch_set":8,"id":"bf51134e_1ed8867d","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":29},"updated":"2020-07-02 08:49:06.000000000","message":"Can discard this sentence.","commit_id":"e633aeb14807c23d734f89f1992a71e1c4cbf2ba"}]}
