)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b865ae8277111449652f03940c4a07586297baf9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayumu Ueha \u003cueha.ayumu@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-10 10:15:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: Unable to store multiple deployment flavours of VNFD in DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user tries to upload CSAR file with multiple flavours (eg: simple, complex)"},{"line_number":10,"context_line":"of VNFD, it only stores one flavour detail in DB."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_1b94188b","line":7,"updated":"2020-06-16 16:03:11.000000000","message":"Thanks and welcome for your first contribution! I would like to ask you to follow the guidelines to make your patch better to be reviewed well.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#:~:text\u003dSummary%20of%20Git%20commit%20message%20structure,-Provide%20a%20brief\u0026text\u003dThe%20first%20line%20should%20be,wrap%20automatically%20lines%20for%20you.\n\nThank you so kindly again for your contribution!","commit_id":"37538f1371a66a97867b03a8c80124b7850a5b4b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b98e25cdfa6d5a3649e8121ae702e93e27c7ce3c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayumu Ueha \u003cueha.ayumu@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-10 10:15:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: Unable to store multiple deployment flavours of VNFD in DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user tries to upload CSAR file with multiple flavours (eg: simple, complex)"},{"line_number":10,"context_line":"of VNFD, it only stores one flavour detail in DB."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_ef91979b","line":7,"in_reply_to":"bf51134e_1b94188b","updated":"2020-06-17 06:09:43.000000000","message":"Done\nThanks for your comment and teach guideline to me! I had saw the guideline, but had missed its part.. \nI modified the commit message. Could you check it?","commit_id":"37538f1371a66a97867b03a8c80124b7850a5b4b"}],"tacker/common/csar_utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8e017f4bed5bee863f8e84b377b3ea428bc1a5f6","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    return flavours"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def _handle_nested_tosca_templates_with_topology(tosca, topologies):"},{"line_number":135,"context_line":"    for fname, tosca_tpl in tosca.nested_tosca_tpls_with_topology.items():"},{"line_number":136,"context_line":"        for nodetemplate in tosca.nodetemplates:"},{"line_number":137,"context_line":"            if _is_sub_mapped_node(tosca, nodetemplate, tosca_tpl):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_0a28b9df","line":134,"updated":"2020-07-13 07:45:16.000000000","message":"Please add a docstring because it looks just a bit complex and contextual for understanding the behavior, especially, what or how handled for given topologies.","commit_id":"0fb88e54796038d8ae36d00c0e349bd0c6df4983"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_multiple_df/Definitions/helloworld3_df_complex.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8e017f4bed5bee863f8e84b377b3ea428bc1a5f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Complex deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_f00f322b","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-13 07:45:16.000000000","message":"It looks something wrong. I\u0027m not sure the reason why, but seems for your develop env, editor or so. By reviewing with `git log -p`, some char code appears as following.\n\n```\n...\n+++ b/tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_multiple_df/Definitions/helloworld3_df_complex.yaml\n@@ -0,0 +1,114 @@\n+\u003cU+FEFF\u003etosca_definitions_version: tosca_simple_yaml_1_2\n+\n+description: Complex deployment flavour for Sample VNF\n...\n```","commit_id":"0fb88e54796038d8ae36d00c0e349bd0c6df4983"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_multiple_df/Definitions/helloworld3_df_simple.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8e017f4bed5bee863f8e84b377b3ea428bc1a5f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Simple deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_90287686","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-13 07:45:16.000000000","message":"It looks something wrong as similar to `helloworld3_df_complex.yaml`.","commit_id":"0fb88e54796038d8ae36d00c0e349bd0c6df4983"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_multiple_df/Definitions/helloworld3_top.vnfd.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8e017f4bed5bee863f8e84b377b3ea428bc1a5f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_702de293","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-13 07:45:16.000000000","message":"It looks something wrong as similar to `helloworld3_df_complex.yaml`.","commit_id":"0fb88e54796038d8ae36d00c0e349bd0c6df4983"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_multiple_df/Definitions/helloworld3_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8e017f4bed5bee863f8e84b377b3ea428bc1a5f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: VNF type definition"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_d01e6e5d","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-13 07:45:16.000000000","message":"It looks something wrong as similar to `helloworld3_df_complex.yaml`.","commit_id":"0fb88e54796038d8ae36d00c0e349bd0c6df4983"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_multiple_df/TOSCA-Metadata/TOSCA.meta":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8e017f4bed5bee863f8e84b377b3ea428bc1a5f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TOSCA-Meta-File-Version: 1.0"},{"line_number":2,"context_line":"Created-by: Ayumu Ueha"},{"line_number":3,"context_line":"CSAR-Version: 1.1"},{"line_number":4,"context_line":"Entry-Definitions: Definitions/helloworld3_top.vnfd.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"bf51134e_25532e3b","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":22},"updated":"2020-07-13 07:45:16.000000000","message":"You should not use a name of specific person in samples. It is better to use `Dummy User` as similar to [1].\n\n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/tests/etc/samples/etsi/nfv/user_data_sample_basehot_invalid/TOSCA-Metadata/TOSCA.meta","commit_id":"0fb88e54796038d8ae36d00c0e349bd0c6df4983"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_multiple_df_not_sub_mapped_node/Definitions/helloworld3_df_complex.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8e017f4bed5bee863f8e84b377b3ea428bc1a5f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Complex deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_b023faa6","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-13 07:45:16.000000000","message":"It looks something wrong as similar to `helloworld3_df_complex.yaml`.","commit_id":"0fb88e54796038d8ae36d00c0e349bd0c6df4983"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_multiple_df_not_sub_mapped_node/Definitions/helloworld3_df_simple.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8e017f4bed5bee863f8e84b377b3ea428bc1a5f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Simple deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_103c66c6","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-13 07:45:16.000000000","message":"It looks something wrong as similar to `helloworld3_df_complex.yaml`.","commit_id":"0fb88e54796038d8ae36d00c0e349bd0c6df4983"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_multiple_df_not_sub_mapped_node/Definitions/helloworld3_top.vnfd.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8e017f4bed5bee863f8e84b377b3ea428bc1a5f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_f038d2d3","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-13 07:45:16.000000000","message":"It looks something wrong as similar to `helloworld3_df_complex.yaml`.","commit_id":"0fb88e54796038d8ae36d00c0e349bd0c6df4983"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_multiple_df_not_sub_mapped_node/Definitions/helloworld3_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8e017f4bed5bee863f8e84b377b3ea428bc1a5f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: VNF type definition"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_50325ef3","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-13 07:45:16.000000000","message":"It looks something wrong as similar to `helloworld3_df_complex.yaml`.","commit_id":"0fb88e54796038d8ae36d00c0e349bd0c6df4983"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_multiple_df_not_sub_mapped_node/TOSCA-Metadata/TOSCA.meta":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8e017f4bed5bee863f8e84b377b3ea428bc1a5f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TOSCA-Meta-File-Version: 1.0"},{"line_number":2,"context_line":"Created-by: Ayumu Ueha"},{"line_number":3,"context_line":"CSAR-Version: 1.1"},{"line_number":4,"context_line":"Entry-Definitions: Definitions/helloworld3_top.vnfd.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"bf51134e_904d1674","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":22},"updated":"2020-07-13 07:45:16.000000000","message":"You should not use a name of specific person in samples. It is better to use `Dummy User` as similar to [1].\n\n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/tests/etc/samples/etsi/nfv/user_data_sample_basehot_invalid/TOSCA-Metadata/TOSCA.meta","commit_id":"0fb88e54796038d8ae36d00c0e349bd0c6df4983"}]}