)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"b75fcfd0e50c74aa6b3abcc744a666f95d028b30","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: flavour_description is not updated when instantiating"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"flavour_description\" and other proerties for top-level VNF"},{"line_number":10,"context_line":"should be updated in instantiation. Otherwise, it may fail"},{"line_number":11,"context_line":"with the default of \"\" (empty string)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_15581530","line":9,"range":{"start_line":9,"start_character":56,"end_line":9,"end_character":59},"updated":"2020-06-19 17:45:44.000000000","message":"VNFD?","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"1a7be8056a50889107fd1ff40d48dabe48cf931b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: flavour_description is not updated when instantiating"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"flavour_description\" and other proerties for top-level VNF"},{"line_number":10,"context_line":"should be updated in instantiation. Otherwise, it may fail"},{"line_number":11,"context_line":"with the default of \"\" (empty string)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_654f7fbd","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":41},"updated":"2020-06-16 06:07:09.000000000","message":"nit: properties","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"b073e8243d267038be424ec0a27e043fffab5067","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: flavour_description is not updated when instantiating"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"flavour_description\" and other proerties for top-level VNF"},{"line_number":10,"context_line":"should be updated in instantiation. Otherwise, it may fail"},{"line_number":11,"context_line":"with the default of \"\" (empty string)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_85b30898","line":9,"range":{"start_line":9,"start_character":56,"end_line":9,"end_character":59},"in_reply_to":"bf51134e_15581530","updated":"2020-07-14 06:00:24.000000000","message":"I fixed \"properties\" and \"VNFD\". Thank you.","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"}],"tacker/tests/unit/vnflcm/test_utils.py":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"b75fcfd0e50c74aa6b3abcc744a666f95d028b30","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.assertEqual(expected_image_path,"},{"line_number":49,"context_line":"                         vnf_software_images[\u0027VDU1\u0027].image_path)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_get_param_data_with_flavour_description(self):"},{"line_number":52,"context_line":"        vnfd_dict \u003d fakes.get_vnfd_dict()"},{"line_number":53,"context_line":"        vnfd_dict.update({\u0027imports\u0027: []})"},{"line_number":54,"context_line":"        instantiate_vnf_req \u003d fakes.get_instantiate_vnf_request_obj()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_43201ab1","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":52},"updated":"2020-06-19 17:45:44.000000000","message":"If possible, you should add a complete test function for _get_param_data(). I mean, include verification that default value and addtional_param is reflected in return value properly.","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"b073e8243d267038be424ec0a27e043fffab5067","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.assertEqual(expected_image_path,"},{"line_number":49,"context_line":"                         vnf_software_images[\u0027VDU1\u0027].image_path)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_get_param_data_with_flavour_description(self):"},{"line_number":52,"context_line":"        vnfd_dict \u003d fakes.get_vnfd_dict()"},{"line_number":53,"context_line":"        vnfd_dict.update({\u0027imports\u0027: []})"},{"line_number":54,"context_line":"        instantiate_vnf_req \u003d fakes.get_instantiate_vnf_request_obj()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_976b3bb5","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":52},"in_reply_to":"bf51134e_43201ab1","updated":"2020-07-14 06:00:24.000000000","message":"As I mentioned in `utils.py`, this function returns a dict having the properties to be updated by flavour ID and additionalParams in instantiation. To check the update is out of the scope of this function because the actual updates are done in heat-translator.","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2c167b681cce57c1f9e25288a1ed7e128b0f1f2a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.assertEqual(expected_image_path,"},{"line_number":49,"context_line":"                         vnf_software_images[\u0027VDU1\u0027].image_path)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_get_param_data_with_flavour_description(self):"},{"line_number":52,"context_line":"        vnfd_dict \u003d fakes.get_vnfd_dict()"},{"line_number":53,"context_line":"        vnfd_dict.update({\u0027imports\u0027: []})"},{"line_number":54,"context_line":"        instantiate_vnf_req \u003d fakes.get_instantiate_vnf_request_obj()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a0da251a","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":52},"in_reply_to":"bf51134e_910779ca","updated":"2020-07-20 05:48:50.000000000","message":"In fact, I\u0027m not sure why we have the logic to update the parameters with additionalParams here. I cannot find the use case for it so I\u0027m wondering how to design the test.\nAccording to SOL003 v2.6.1 clause 5.5.2.4, we can use additionalParams of InstantiateVnfRequest when instantiating VNF but it doesn\u0027t imply to update the parameters in VNF.","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"a936b28e54b49ea4527e68613a32bebc702e2766","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.assertEqual(expected_image_path,"},{"line_number":49,"context_line":"                         vnf_software_images[\u0027VDU1\u0027].image_path)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_get_param_data_with_flavour_description(self):"},{"line_number":52,"context_line":"        vnfd_dict \u003d fakes.get_vnfd_dict()"},{"line_number":53,"context_line":"        vnfd_dict.update({\u0027imports\u0027: []})"},{"line_number":54,"context_line":"        instantiate_vnf_req \u003d fakes.get_instantiate_vnf_request_obj()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_910779ca","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":52},"in_reply_to":"bf51134e_976b3bb5","updated":"2020-07-18 16:25:08.000000000","message":"Understand. Then why don\u0027t you add verification of additionalParam?","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"}],"tacker/vnflcm/utils.py":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"b75fcfd0e50c74aa6b3abcc744a666f95d028b30","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    input_attributes \u003d vnfd_dict.get(\u0027topology_template\u0027, {}).get(\u0027inputs\u0027)"},{"line_number":215,"context_line":"    if substitution_map is not None:"},{"line_number":216,"context_line":"        subs_map_node_type \u003d substitution_map.get(\u0027node_type\u0027)"},{"line_number":217,"context_line":"        # Get properties in lower-level VNFD for top-level VNF"},{"line_number":218,"context_line":"        node_templates \u003d vnfd_dict.get(\u0027topology_template\u0027,"},{"line_number":219,"context_line":"                                    {}).get(\u0027node_templates\u0027, {})"},{"line_number":220,"context_line":"        for node in node_templates.values():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e8be6d63","line":217,"range":{"start_line":217,"start_character":59,"end_line":217,"end_character":62},"updated":"2020-06-19 17:45:44.000000000","message":"VNFD?","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"b073e8243d267038be424ec0a27e043fffab5067","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    input_attributes \u003d vnfd_dict.get(\u0027topology_template\u0027, {}).get(\u0027inputs\u0027)"},{"line_number":215,"context_line":"    if substitution_map is not None:"},{"line_number":216,"context_line":"        subs_map_node_type \u003d substitution_map.get(\u0027node_type\u0027)"},{"line_number":217,"context_line":"        # Get properties in lower-level VNFD for top-level VNF"},{"line_number":218,"context_line":"        node_templates \u003d vnfd_dict.get(\u0027topology_template\u0027,"},{"line_number":219,"context_line":"                                    {}).get(\u0027node_templates\u0027, {})"},{"line_number":220,"context_line":"        for node in node_templates.values():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_65aeb42e","line":217,"range":{"start_line":217,"start_character":59,"end_line":217,"end_character":62},"in_reply_to":"bf51134e_e8be6d63","updated":"2020-07-14 06:00:24.000000000","message":"Yes. I fixed.","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"b75fcfd0e50c74aa6b3abcc744a666f95d028b30","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                for key, value in imp_node_type.items():"},{"line_number":234,"context_line":"                    if key \u003d\u003d subs_map_node_type:"},{"line_number":235,"context_line":"                        properties \u003d value.get(\u0027properties\u0027)"},{"line_number":236,"context_line":"                        for key, prop in properties.items():"},{"line_number":237,"context_line":"                            if additional_param.get(key):"},{"line_number":238,"context_line":"                                param_value.update({"},{"line_number":239,"context_line":"                                    key: additional_param.get(key)})"},{"line_number":240,"context_line":"                            else:"},{"line_number":241,"context_line":"                                # If the parameter is provided in lower-level"},{"line_number":242,"context_line":"                                # VNFD, use it. Otherwise use the default."},{"line_number":243,"context_line":"                                if param_value.get(key):"},{"line_number":244,"context_line":"                                    pass"},{"line_number":245,"context_line":"                                else:"},{"line_number":246,"context_line":"                                    param_value.update("},{"line_number":247,"context_line":"                                        {key: prop.get(\u0027default\u0027)})"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    for input_attr, value in input_attributes.items():"},{"line_number":250,"context_line":"        if additional_param.get(input_attr):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_230fe689","line":247,"range":{"start_line":236,"start_character":0,"end_line":247,"end_character":67},"updated":"2020-06-19 17:45:44.000000000","message":"I fell this a bit unreadable code. How about the following. Simply, at first extracting properties from type definition, overwriting them by template definition, overwriting again by additional params.\n\n                  if properties:\n                      param_value.update(properties)\n\n  # move L217-L224 here.\n  node_template \u003d vnfd_dict.get(...)\n  ...\n  \n  for key, prop in param_value.items():\n      if additional_param.get(key):\n          param_value.update({key: additional_param.get(key)})","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"b073e8243d267038be424ec0a27e043fffab5067","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                for key, value in imp_node_type.items():"},{"line_number":234,"context_line":"                    if key \u003d\u003d subs_map_node_type:"},{"line_number":235,"context_line":"                        properties \u003d value.get(\u0027properties\u0027)"},{"line_number":236,"context_line":"                        for key, prop in properties.items():"},{"line_number":237,"context_line":"                            if additional_param.get(key):"},{"line_number":238,"context_line":"                                param_value.update({"},{"line_number":239,"context_line":"                                    key: additional_param.get(key)})"},{"line_number":240,"context_line":"                            else:"},{"line_number":241,"context_line":"                                # If the parameter is provided in lower-level"},{"line_number":242,"context_line":"                                # VNFD, use it. Otherwise use the default."},{"line_number":243,"context_line":"                                if param_value.get(key):"},{"line_number":244,"context_line":"                                    pass"},{"line_number":245,"context_line":"                                else:"},{"line_number":246,"context_line":"                                    param_value.update("},{"line_number":247,"context_line":"                                        {key: prop.get(\u0027default\u0027)})"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    for input_attr, value in input_attributes.items():"},{"line_number":250,"context_line":"        if additional_param.get(input_attr):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_256e7cff","line":247,"range":{"start_line":236,"start_character":0,"end_line":247,"end_character":67},"in_reply_to":"bf51134e_230fe689","updated":"2020-07-14 06:00:24.000000000","message":"Thank you for the suggestion, but the logic is not correct behavior for this function. This function should only return;\n   1. tosca.nodes.nfv.VNF properties in lower-VNFD according to the provided flavour ID\n   2. properties to be updated in additionalParam\nWith the suggested logic, all properties for tosca.nodes.nfv.VNF are overwritten by default values because the returned dict of this function will be provided to heat-translator as updated properties.\n\nThis is a bit unreadable but I believe we need to keep this.","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"ff1a6d9c536812815a0be9e77f16b1b09c9819ed","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                for key, value in imp_node_type.items():"},{"line_number":234,"context_line":"                    if key \u003d\u003d subs_map_node_type:"},{"line_number":235,"context_line":"                        properties \u003d value.get(\u0027properties\u0027)"},{"line_number":236,"context_line":"                        for key, prop in properties.items():"},{"line_number":237,"context_line":"                            if additional_param.get(key):"},{"line_number":238,"context_line":"                                param_value.update({"},{"line_number":239,"context_line":"                                    key: additional_param.get(key)})"},{"line_number":240,"context_line":"                            else:"},{"line_number":241,"context_line":"                                # If the parameter is provided in lower-level"},{"line_number":242,"context_line":"                                # VNFD, use it. Otherwise use the default."},{"line_number":243,"context_line":"                                if param_value.get(key):"},{"line_number":244,"context_line":"                                    pass"},{"line_number":245,"context_line":"                                else:"},{"line_number":246,"context_line":"                                    param_value.update("},{"line_number":247,"context_line":"                                        {key: prop.get(\u0027default\u0027)})"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    for input_attr, value in input_attributes.items():"},{"line_number":250,"context_line":"        if additional_param.get(input_attr):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_fed7c0ec","line":247,"range":{"start_line":236,"start_character":0,"end_line":247,"end_character":67},"in_reply_to":"bf51134e_256e7cff","updated":"2020-07-16 17:03:43.000000000","message":"L240-247 mean as follows?\n                            else if not param_value.get(key):\n                                    param_value.update(\n                                        {key: prop.get(\u0027default\u0027)})","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"63a1ef94183780e429f14f35ced56ca9c8718a1b","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                for key, value in imp_node_type.items():"},{"line_number":234,"context_line":"                    if key \u003d\u003d subs_map_node_type:"},{"line_number":235,"context_line":"                        properties \u003d value.get(\u0027properties\u0027)"},{"line_number":236,"context_line":"                        for key, prop in properties.items():"},{"line_number":237,"context_line":"                            if additional_param.get(key):"},{"line_number":238,"context_line":"                                param_value.update({"},{"line_number":239,"context_line":"                                    key: additional_param.get(key)})"},{"line_number":240,"context_line":"                            else:"},{"line_number":241,"context_line":"                                # If the parameter is provided in lower-level"},{"line_number":242,"context_line":"                                # VNFD, use it. Otherwise use the default."},{"line_number":243,"context_line":"                                if param_value.get(key):"},{"line_number":244,"context_line":"                                    pass"},{"line_number":245,"context_line":"                                else:"},{"line_number":246,"context_line":"                                    param_value.update("},{"line_number":247,"context_line":"                                        {key: prop.get(\u0027default\u0027)})"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    for input_attr, value in input_attributes.items():"},{"line_number":250,"context_line":"        if additional_param.get(input_attr):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_67803c48","line":247,"range":{"start_line":236,"start_character":0,"end_line":247,"end_character":67},"in_reply_to":"bf51134e_fed7c0ec","updated":"2020-07-17 07:42:08.000000000","message":"Yes, it seems more readable. I\u0027ve updated the code, thank you.","commit_id":"b59c0696e3b1477fdf7c71e281bfa4d340e6ae68"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"022097182aaf9a13a3fe7297bc809cdb8d9f6da1","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                                    key: additional_param.get(key)})"},{"line_number":240,"context_line":"                            # If the parameter is provided in lower-level"},{"line_number":241,"context_line":"                            # VNFD, use it. Otherwise use the default."},{"line_number":242,"context_line":"                            else if not param_value.get(key):"},{"line_number":243,"context_line":"                                    param_value.update("},{"line_number":244,"context_line":"                                        {key: prop.get(\u0027default\u0027)})"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_ad1b551a","line":242,"updated":"2020-07-17 10:21:54.000000000","message":"Sorry for frequent comment.\nShould we use `elif` instead of else if?","commit_id":"3a4c4828d6c55c08f6ae480edc759bf357d654f0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"baf334af511445430ac8dfe0344ddeba766d8342","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                                    key: additional_param.get(key)})"},{"line_number":240,"context_line":"                            # If the parameter is provided in lower-level"},{"line_number":241,"context_line":"                            # VNFD, use it. Otherwise use the default."},{"line_number":242,"context_line":"                            else if not param_value.get(key):"},{"line_number":243,"context_line":"                                    param_value.update("},{"line_number":244,"context_line":"                                        {key: prop.get(\u0027default\u0027)})"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_7f2a802c","line":242,"updated":"2020-07-17 11:02:46.000000000","message":"pep8: E999 SyntaxError: invalid syntax","commit_id":"3a4c4828d6c55c08f6ae480edc759bf357d654f0"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2c167b681cce57c1f9e25288a1ed7e128b0f1f2a","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                                    key: additional_param.get(key)})"},{"line_number":240,"context_line":"                            # If the parameter is provided in lower-level"},{"line_number":241,"context_line":"                            # VNFD, use it. Otherwise use the default."},{"line_number":242,"context_line":"                            else if not param_value.get(key):"},{"line_number":243,"context_line":"                                    param_value.update("},{"line_number":244,"context_line":"                                        {key: prop.get(\u0027default\u0027)})"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_80ba81bd","line":242,"in_reply_to":"bf51134e_ad1b551a","updated":"2020-07-20 05:48:50.000000000","message":"Thank you, I updated.","commit_id":"3a4c4828d6c55c08f6ae480edc759bf357d654f0"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"fc91151b1a2478ac43df8b5cb17657082da6cc84","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                            # If the parameter is provided in lower-level"},{"line_number":241,"context_line":"                            # VNFD, use it. Otherwise use the default."},{"line_number":242,"context_line":"                            else if not param_value.get(key):"},{"line_number":243,"context_line":"                                    param_value.update("},{"line_number":244,"context_line":"                                        {key: prop.get(\u0027default\u0027)})"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    for input_attr, value in input_attributes.items():"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_ed4eed36","line":243,"updated":"2020-07-17 10:15:36.000000000","message":"One indent (4 spaces) seems be unnecessary.","commit_id":"3a4c4828d6c55c08f6ae480edc759bf357d654f0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"baf334af511445430ac8dfe0344ddeba766d8342","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                            # If the parameter is provided in lower-level"},{"line_number":241,"context_line":"                            # VNFD, use it. Otherwise use the default."},{"line_number":242,"context_line":"                            else if not param_value.get(key):"},{"line_number":243,"context_line":"                                    param_value.update("},{"line_number":244,"context_line":"                                        {key: prop.get(\u0027default\u0027)})"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    for input_attr, value in input_attributes.items():"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_df1e2c0c","line":243,"updated":"2020-07-17 11:02:46.000000000","message":"pep8: E117 over-indented","commit_id":"3a4c4828d6c55c08f6ae480edc759bf357d654f0"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2c167b681cce57c1f9e25288a1ed7e128b0f1f2a","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                            # If the parameter is provided in lower-level"},{"line_number":241,"context_line":"                            # VNFD, use it. Otherwise use the default."},{"line_number":242,"context_line":"                            else if not param_value.get(key):"},{"line_number":243,"context_line":"                                    param_value.update("},{"line_number":244,"context_line":"                                        {key: prop.get(\u0027default\u0027)})"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    for input_attr, value in input_attributes.items():"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_e0affd7a","line":243,"in_reply_to":"bf51134e_ed4eed36","updated":"2020-07-20 05:48:50.000000000","message":"Thank you, I updated.","commit_id":"3a4c4828d6c55c08f6ae480edc759bf357d654f0"}]}