)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"70a61d64888e64c6839527781b4802c0f11e2290","unresolved":false,"context_lines":[{"line_number":13,"context_line":"update:fix router.py to adjust api-calling of"},{"line_number":14,"context_line":"`GET /vnf_packages/{vnfPkgId}/artifacts/{artifactPath}`"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"update:fixed comments for previously commits"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iad045407338535022aa385b57125225ee6253732"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_179322fc","line":16,"updated":"2020-07-30 07:49:20.000000000","message":"You should not need to reply to reviewer. It\u0027s enough to say it from \"Reply\".","commit_id":"136742156b6aa32dc0839fbb68ce0ffe5aebaac9"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"02b361fe79431241d03a901a118b77ad151e0421","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-08-04 23:05:15 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementation Artifacts support in Tacker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement blueprint add-artifacts-vnf-packages"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Tacker API and Conductor service"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_2585f95a","line":8,"updated":"2020-08-05 05:49:05.000000000","message":"You should add a short description for this change, especially for such a large update. Please refer to previous commits as examples.","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"02b361fe79431241d03a901a118b77ad151e0421","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Tacker API and Conductor service"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"update:fix router.py to adjust api-calling of"},{"line_number":14,"context_line":"`GET /vnf_packages/{vnfPkgId}/artifacts/{artifactPath}`"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"update:fixed comments for previously commits"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_45f58dec","line":13,"updated":"2020-08-05 05:49:05.000000000","message":"If it is a reply to reviewers, no need to be in commit message.","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"02b361fe79431241d03a901a118b77ad151e0421","unresolved":false,"context_lines":[{"line_number":13,"context_line":"update:fix router.py to adjust api-calling of"},{"line_number":14,"context_line":"`GET /vnf_packages/{vnfPkgId}/artifacts/{artifactPath}`"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"update:fixed comments for previously commits"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iad045407338535022aa385b57125225ee6253732"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_05ef151e","line":16,"updated":"2020-08-05 05:49:05.000000000","message":"You don\u0027t need to reply to reviewers in this commit message.","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Tacker API and Conductor service"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"update:fix router.py to adjust api-calling of"},{"line_number":14,"context_line":"`GET /vnf_packages/{vnfPkgId}/artifacts/{artifactPath}`"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"update:fixed comments for previously commits"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_41e94ab5","line":13,"updated":"2020-09-04 17:03:08.000000000","message":"No need this line if you reply to a comment on gerrit.","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"update:fix router.py to adjust api-calling of"},{"line_number":14,"context_line":"`GET /vnf_packages/{vnfPkgId}/artifacts/{artifactPath}`"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"update:fixed comments for previously commits"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iad045407338535022aa385b57125225ee6253732"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_21b7f6da","line":16,"updated":"2020-09-04 17:03:08.000000000","message":"No need this line. It\u0027s enough on gerrit.","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"`GET /vnf_packages/{vnfPkgId}/artifacts/{artifactPath}`"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"update:fixed comments for previously commits"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iad045407338535022aa385b57125225ee6253732"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_e1c4de42","line":17,"updated":"2020-09-04 17:03:08.000000000","message":"Please add `Implements` tag for your bp.","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"92150410062942d25fbe613c109800767dcec758","unresolved":false,"context_lines":[{"line_number":14,"context_line":"`GET /vnf_packages/{vnfPkgId}/artifacts/{artifactPath}`"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"update:fixed comments for previously commits"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iad045407338535022aa385b57125225ee6253732"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_5b3baae8","line":17,"in_reply_to":"9f560f44_e1c4de42","updated":"2020-09-10 05:48:14.000000000","message":"I updated a new commit message but sorry I dont know how to add a `implements` tag on my bp.\nCould you please kindly tell me how to do that?","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"c6381146481c20acb06a2df25a96ddd9680a8209","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementation Artifacts support in Tacker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: bp/add-artifacts-vnf-packages"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Add artifacts support for vnf packages:"},{"line_number":12,"context_line":"  * Read and verify artifacts from TOSCA.meta and manifest file."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"9f560f44_c18a6818","line":9,"updated":"2020-09-20 11:06:32.000000000","message":"It\u0027s wrong in format. `Implements: blueprint add-artifacts-vnf-packages` is correct. I\u0027d appreciate if you learn the guidelines to avoid such a mics comments several times.","commit_id":"e4a7357b34b906c77cc34708750390b09d0fbcff"}],"tacker/api/vnfpkgm/v1/controller.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"b7ab43b288956cd6b1655bf5d0450a1f9c7fa5c6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from glance_store import exceptions as store_exceptions"},{"line_number":18,"context_line":"from io import BytesIO"},{"line_number":19,"context_line":"import mimetypes"},{"line_number":20,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_0ebb3b72","line":17,"updated":"2020-07-20 17:02:11.000000000","message":"This is OpenStack package, not core system package.\nIf so, it seems better to move after os packages.\n\nhttps://docs.openstack.org/charm-guide/latest/coding-guidelines.html#import-ordering-and-style","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5b7da6e14672c5562cd6b39810c0baf40efbca81","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from glance_store import exceptions as store_exceptions"},{"line_number":18,"context_line":"from io import BytesIO"},{"line_number":19,"context_line":"import mimetypes"},{"line_number":20,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_60ea96ac","line":17,"in_reply_to":"bf51134e_0ebb3b72","updated":"2020-07-31 10:29:51.000000000","message":"Thanks for comment and link, we have moved it after os packages in patch6","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"b7ab43b288956cd6b1655bf5d0450a1f9c7fa5c6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from tacker.objects import vnf_package as vnf_package_obj"},{"line_number":39,"context_line":"from tacker.policies import vnf_package as vnf_package_policies"},{"line_number":40,"context_line":"from tacker import wsgi"},{"line_number":41,"context_line":"import webob"},{"line_number":42,"context_line":"import zipfile"},{"line_number":43,"context_line":"from zipfile import ZipFile"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_c9781d91","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":27},"updated":"2020-07-20 17:02:11.000000000","message":"These 3 packages are 3rd party package, so I think we do not have to move them.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5b7da6e14672c5562cd6b39810c0baf40efbca81","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from tacker.objects import vnf_package as vnf_package_obj"},{"line_number":39,"context_line":"from tacker.policies import vnf_package as vnf_package_policies"},{"line_number":40,"context_line":"from tacker import wsgi"},{"line_number":41,"context_line":"import webob"},{"line_number":42,"context_line":"import zipfile"},{"line_number":43,"context_line":"from zipfile import ZipFile"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_40ddd212","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":27},"in_reply_to":"bf51134e_c9781d91","updated":"2020-07-31 10:29:51.000000000","message":"Thanks for comment!We have moved these 3 packages to their original place in patch6, also sorry for a late reply :)","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fb4e116c15d9c1356e257b8dd5ffa35bd6ee9c9e","unresolved":false,"context_lines":[{"line_number":562,"context_line":"            except exceptions.FailedToGetVnfArtifact as e:"},{"line_number":563,"context_line":"                LOG.error(e.msg)"},{"line_number":564,"context_line":"                raise webob.exc.HTTPInternalServerError("},{"line_number":565,"context_line":"                    explanation\u003dsix.text_type(e.msg))"},{"line_number":566,"context_line":"            request.response.text \u003d artifact_data.decode(\u0027utf-8\u0027)"},{"line_number":567,"context_line":"            if request.response.status_int \u003d\u003d 206:"},{"line_number":568,"context_line":"                request.response.headers[\u0027Content-Range\u0027] \u003d \u0027bytes %s-%s/%s\u0027 \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_a90b1f29","line":565,"updated":"2020-07-21 09:31:22.000000000","message":"I think you need not to use \u0027six\u0027 library because you don\u0027t have to keep python2.X and python3.X compatible.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5b7da6e14672c5562cd6b39810c0baf40efbca81","unresolved":false,"context_lines":[{"line_number":562,"context_line":"            except exceptions.FailedToGetVnfArtifact as e:"},{"line_number":563,"context_line":"                LOG.error(e.msg)"},{"line_number":564,"context_line":"                raise webob.exc.HTTPInternalServerError("},{"line_number":565,"context_line":"                    explanation\u003dsix.text_type(e.msg))"},{"line_number":566,"context_line":"            request.response.text \u003d artifact_data.decode(\u0027utf-8\u0027)"},{"line_number":567,"context_line":"            if request.response.status_int \u003d\u003d 206:"},{"line_number":568,"context_line":"                request.response.headers[\u0027Content-Range\u0027] \u003d \u0027bytes %s-%s/%s\u0027 \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_20bb7ec4","line":565,"in_reply_to":"bf51134e_a90b1f29","updated":"2020-07-31 10:29:51.000000000","message":"Thank you for comment and also sorry for a late reply,\nin patch6 we have fixed this and also other legacy python2.X related codes.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"b2457c6d1711c5f90ca6d1bee2a836ebca6b589c","unresolved":false,"context_lines":[{"line_number":580,"context_line":"            msg \u003d _(\"Not Found Artifact File.\")"},{"line_number":581,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    def _get_csar_path(self, vnf_package):"},{"line_number":584,"context_line":"        csar_path \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":585,"context_line":"                                 vnf_package.id)"},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_ed61e806","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":22},"updated":"2020-08-09 14:16:45.000000000","message":"Currently, in Tacker, tacker conductor is responsible for this kind of CSAR handling. Like Line 457, an RPC call to tacker conductor is used to take over this process to tacker conductor. Could you consider doing that?","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"abb808021dbadde87b1b1409692d4ce622a09672","unresolved":false,"context_lines":[{"line_number":580,"context_line":"            msg \u003d _(\"Not Found Artifact File.\")"},{"line_number":581,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    def _get_csar_path(self, vnf_package):"},{"line_number":584,"context_line":"        csar_path \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":585,"context_line":"                                 vnf_package.id)"},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_00d17ef8","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":22},"in_reply_to":"9f560f44_1df7015c","updated":"2020-09-26 14:39:22.000000000","message":"Okay, no issue to merge this code.\nThe reason why we oriented to leave CSAR handling to Tacker conductor in the previous release is if tacker-server and tacker-conductor are deployed independent nodes, tacker-server may not able to access to csar directory (When we want tacker HA, this may raise as a realistic problem).\nHowever, it’s true that current tacker includes so many codes which doesn’t follow this design so this kind of refactoring should be taken in the futre...","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"f1cce2ebc08bb7ff62c07c8124efa051095d6018","unresolved":false,"context_lines":[{"line_number":580,"context_line":"            msg \u003d _(\"Not Found Artifact File.\")"},{"line_number":581,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    def _get_csar_path(self, vnf_package):"},{"line_number":584,"context_line":"        csar_path \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":585,"context_line":"                                 vnf_package.id)"},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_c90dea3e","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":22},"in_reply_to":"9f560f44_6aa4b0a6","updated":"2020-09-12 14:47:10.000000000","message":"Sorry for late reply. But your strategy is not consistent with the current code. get_vnf_package_vnfd() responses 200 OK but leaves this kind of CSAR handling to tacker conductor.","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"457aa0d151becf8d465149b069684b6206b083c0","unresolved":false,"context_lines":[{"line_number":580,"context_line":"            msg \u003d _(\"Not Found Artifact File.\")"},{"line_number":581,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    def _get_csar_path(self, vnf_package):"},{"line_number":584,"context_line":"        csar_path \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":585,"context_line":"                                 vnf_package.id)"},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_1df7015c","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":22},"in_reply_to":"9f560f44_c90dea3e","updated":"2020-09-15 00:22:54.000000000","message":"I believe that get_vnf_package_vnfd() is the only method being inconsistent with the strategy, and I\u0027m not sure why it depends on tacker conductor (I think it\u0027s a poor design). Another issue is that we have no clear design rules in the Tacker contributor documents. The refactoring is needed for get_vnf_package_vnfd() but that is out of scope of this patch.","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"a36999cc8fc5a32d9b22706cd1f9b21c2017e9c1","unresolved":false,"context_lines":[{"line_number":580,"context_line":"            msg \u003d _(\"Not Found Artifact File.\")"},{"line_number":581,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    def _get_csar_path(self, vnf_package):"},{"line_number":584,"context_line":"        csar_path \u003d os.path.join(CONF.vnf_package.vnf_package_csar_path,"},{"line_number":585,"context_line":"                                 vnf_package.id)"},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_6aa4b0a6","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":22},"in_reply_to":"9f560f44_ed61e806","updated":"2020-08-26 04:58:40.000000000","message":"Thank you for comment and also sorry for late reply, in our strategy, when tacker is responding 200 OK, we keep logic in tacker server, and when we responding 202 appcepted, we redirect to conductor.","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"}],"tacker/common/csar_utils.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"bf300d7a0424fc992a67c2c41a6be300eedd5e18","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    for data in artifacts_data_split:"},{"line_number":336,"context_line":"        if re.findall(b\u0027.?Source:.?\u0027, data):"},{"line_number":337,"context_line":"            artifact_data_dict \u003d yaml.load(data)"},{"line_number":338,"context_line":"            artifact_path \u003d artifact_data_dict[\u0027Source\u0027]"},{"line_number":339,"context_line":"            algorithm \u003d artifact_data_dict[\u0027Algorithm\u0027]"},{"line_number":340,"context_line":"            hash_code \u003d artifact_data_dict[\u0027Hash\u0027]"},{"line_number":341,"context_line":"            result \u003d _validate_hash(algorithm, hash_code, csar, artifact_path)"},{"line_number":342,"context_line":"            if result:"},{"line_number":343,"context_line":"                vnf_artifacts.append(artifact_data_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_5dcf597e","line":340,"range":{"start_line":338,"start_character":0,"end_line":340,"end_character":50},"updated":"2020-07-08 08:38:01.000000000","message":"In case of missing keys for artifacts in \u0027Source\u0027, \u0027Algorithm\u0027, and \u0027Hash\u0027, it\u0027s better to use ``artifact_data_dict.get()`` to mitigate KeyError.\n\nAlso, it\u0027s better to validate all required key-value pairs are provided here.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"84886bd17af82042663fc66d978f9c1800f43bc8","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    for data in artifacts_data_split:"},{"line_number":336,"context_line":"        if re.findall(b\u0027.?Source:.?\u0027, data):"},{"line_number":337,"context_line":"            artifact_data_dict \u003d yaml.load(data)"},{"line_number":338,"context_line":"            artifact_path \u003d artifact_data_dict[\u0027Source\u0027]"},{"line_number":339,"context_line":"            algorithm \u003d artifact_data_dict[\u0027Algorithm\u0027]"},{"line_number":340,"context_line":"            hash_code \u003d artifact_data_dict[\u0027Hash\u0027]"},{"line_number":341,"context_line":"            result \u003d _validate_hash(algorithm, hash_code, csar, artifact_path)"},{"line_number":342,"context_line":"            if result:"},{"line_number":343,"context_line":"                vnf_artifacts.append(artifact_data_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_6bcd1084","line":340,"range":{"start_line":338,"start_character":0,"end_line":340,"end_character":50},"in_reply_to":"bf51134e_5dcf597e","updated":"2020-07-10 10:36:01.000000000","message":"Thanks for comment. We will add logic to validate 1)missing keys, 2) missing values (include new test cases).","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ef205541089aacf9961d046fa5771c02ad3100b8","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    for data in artifacts_data_split:"},{"line_number":336,"context_line":"        if re.findall(b\u0027.?Source:.?\u0027, data):"},{"line_number":337,"context_line":"            artifact_data_dict \u003d yaml.load(data)"},{"line_number":338,"context_line":"            artifact_path \u003d artifact_data_dict[\u0027Source\u0027]"},{"line_number":339,"context_line":"            algorithm \u003d artifact_data_dict[\u0027Algorithm\u0027]"},{"line_number":340,"context_line":"            hash_code \u003d artifact_data_dict[\u0027Hash\u0027]"},{"line_number":341,"context_line":"            result \u003d _validate_hash(algorithm, hash_code, csar, artifact_path)"},{"line_number":342,"context_line":"            if result:"},{"line_number":343,"context_line":"                vnf_artifacts.append(artifact_data_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ca424168","line":340,"range":{"start_line":338,"start_character":0,"end_line":340,"end_character":50},"in_reply_to":"bf51134e_6bcd1084","updated":"2020-07-13 05:48:22.000000000","message":"Additional, we are only checking \u0027Source\u0027 key here to judge if user is uploading an artifact. In next patch we will also fix the judgement by check \u0027Source\u0027 +\u0027Algorithm\u0027 + \u0027Hash\u0027. (L336)","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"4f36680f7adf3884479244f900089ba2e08c8011","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    for data in artifacts_data_split:"},{"line_number":336,"context_line":"        if re.findall(b\u0027.?Source:.?\u0027, data):"},{"line_number":337,"context_line":"            artifact_data_dict \u003d yaml.load(data)"},{"line_number":338,"context_line":"            artifact_path \u003d artifact_data_dict[\u0027Source\u0027]"},{"line_number":339,"context_line":"            algorithm \u003d artifact_data_dict[\u0027Algorithm\u0027]"},{"line_number":340,"context_line":"            hash_code \u003d artifact_data_dict[\u0027Hash\u0027]"},{"line_number":341,"context_line":"            result \u003d _validate_hash(algorithm, hash_code, csar, artifact_path)"},{"line_number":342,"context_line":"            if result:"},{"line_number":343,"context_line":"                vnf_artifacts.append(artifact_data_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0550435e","line":340,"range":{"start_line":338,"start_character":0,"end_line":340,"end_character":50},"in_reply_to":"bf51134e_ca424168","updated":"2020-07-20 01:56:11.000000000","message":"we have updated new code contains this logic, please kindly have a check.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"bf300d7a0424fc992a67c2c41a6be300eedd5e18","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    algorithm \u003d algorithm.lower()"},{"line_number":357,"context_line":"    hashlib.sha256()"},{"line_number":358,"context_line":"    hash_obj \u003d eval(HASH_LIST[algorithm])"},{"line_number":359,"context_line":"    hash_obj.update(z.read(artifacts_path))"},{"line_number":360,"context_line":"    calculated_hash \u003d hash_obj.hexdigest()"},{"line_number":361,"context_line":"    if hash_code \u003d\u003d calculated_hash:"},{"line_number":362,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_4208182c","line":359,"range":{"start_line":359,"start_character":4,"end_line":359,"end_character":43},"updated":"2020-07-08 08:38:01.000000000","message":"In case of external files provided with URI, ``artifacts_path`` is URI and might fail here. A logic to check if the artifact is provided with file or URI and to download the external file.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ef205541089aacf9961d046fa5771c02ad3100b8","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    algorithm \u003d algorithm.lower()"},{"line_number":357,"context_line":"    hashlib.sha256()"},{"line_number":358,"context_line":"    hash_obj \u003d eval(HASH_LIST[algorithm])"},{"line_number":359,"context_line":"    hash_obj.update(z.read(artifacts_path))"},{"line_number":360,"context_line":"    calculated_hash \u003d hash_obj.hexdigest()"},{"line_number":361,"context_line":"    if hash_code \u003d\u003d calculated_hash:"},{"line_number":362,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_6a7b358b","line":359,"range":{"start_line":359,"start_character":4,"end_line":359,"end_character":43},"in_reply_to":"bf51134e_4208182c","updated":"2020-07-13 05:48:22.000000000","message":"We will add this logic in next patch, also we will not upload the download file to tacker, the file is only used for hash validate. (I found you are talking with Jo-san in artifact spec about download)","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"4f36680f7adf3884479244f900089ba2e08c8011","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    algorithm \u003d algorithm.lower()"},{"line_number":357,"context_line":"    hashlib.sha256()"},{"line_number":358,"context_line":"    hash_obj \u003d eval(HASH_LIST[algorithm])"},{"line_number":359,"context_line":"    hash_obj.update(z.read(artifacts_path))"},{"line_number":360,"context_line":"    calculated_hash \u003d hash_obj.hexdigest()"},{"line_number":361,"context_line":"    if hash_code \u003d\u003d calculated_hash:"},{"line_number":362,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2553c76e","line":359,"range":{"start_line":359,"start_character":4,"end_line":359,"end_character":43},"in_reply_to":"bf51134e_6a7b358b","updated":"2020-07-20 01:56:11.000000000","message":"we have updated new code contains this logic, please kindly have a check.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"a151bdebe88c71075a51702a9c5508d01627eaee","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    return vnf_artifacts"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"def _convert_artifacts(vnf_artifacts, artifacts_data, csar):"},{"line_number":334,"context_line":"    artifacts_data_split \u003d re.split(b\u0027\\n\\n+\u0027, artifacts_data)"},{"line_number":335,"context_line":"    for data in artifacts_data_split:"},{"line_number":336,"context_line":"        if re.findall(b\u0027.?Source:.?\u0027, data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_f70a7787","line":333,"range":{"start_line":333,"start_character":4,"end_line":333,"end_character":22},"updated":"2020-07-14 06:35:06.000000000","message":"VnfSoftowareImage should not be recognized as additionalArtifacts so we need the logic to skip them. They can be detected with `Files/images` directory or extensions.","commit_id":"effed03297d96e606b8bb1484734306c46ebf114"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"344b046906b63584e5bc43c5b90eb2929281d657","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    return vnf_artifacts"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"def _convert_artifacts(vnf_artifacts, artifacts_data, csar):"},{"line_number":334,"context_line":"    artifacts_data_split \u003d re.split(b\u0027\\n\\n+\u0027, artifacts_data)"},{"line_number":335,"context_line":"    for data in artifacts_data_split:"},{"line_number":336,"context_line":"        if re.findall(b\u0027.?Source:.?\u0027, data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_e538afef","line":333,"range":{"start_line":333,"start_character":4,"end_line":333,"end_character":22},"in_reply_to":"bf51134e_a5ed1790","updated":"2020-07-20 02:35:23.000000000","message":"You need to skip it to store in VnfPackageArtifactInfo while it can be in TOSCA.meta or manifest file. Please refer GS ETSI NFV SOL005 v2.6.1 Table 9.5.2.5-1.","commit_id":"effed03297d96e606b8bb1484734306c46ebf114"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"4f36680f7adf3884479244f900089ba2e08c8011","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    return vnf_artifacts"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"def _convert_artifacts(vnf_artifacts, artifacts_data, csar):"},{"line_number":334,"context_line":"    artifacts_data_split \u003d re.split(b\u0027\\n\\n+\u0027, artifacts_data)"},{"line_number":335,"context_line":"    for data in artifacts_data_split:"},{"line_number":336,"context_line":"        if re.findall(b\u0027.?Source:.?\u0027, data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_a5ed1790","line":333,"range":{"start_line":333,"start_character":4,"end_line":333,"end_character":22},"in_reply_to":"bf51134e_f70a7787","updated":"2020-07-20 01:56:11.000000000","message":"Just want to confirm is it means we should skip images in artifacts like \n\n     Source: Files/images/cirros.img\n     Algorithm: SHA-256\n     Hash: 9569dfc57e26436315180cb61f2d0d45c0de7c0ddb47d5759271ae825dc3acab","commit_id":"effed03297d96e606b8bb1484734306c46ebf114"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fb4e116c15d9c1356e257b8dd5ffa35bd6ee9c9e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"try:"},{"line_number":34,"context_line":"    # Python 3.x"},{"line_number":35,"context_line":"    import urllib.request as urllib2"},{"line_number":36,"context_line":"except ImportError:"},{"line_number":37,"context_line":"    # Python 2.x"},{"line_number":38,"context_line":"    import urllib2"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_e957d725","line":36,"updated":"2020-07-21 09:31:22.000000000","message":"I think this branch isn\u0027t necessary because OpenStack no longer supports python2.X.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5b7da6e14672c5562cd6b39810c0baf40efbca81","unresolved":false,"context_lines":[{"line_number":33,"context_line":"try:"},{"line_number":34,"context_line":"    # Python 3.x"},{"line_number":35,"context_line":"    import urllib.request as urllib2"},{"line_number":36,"context_line":"except ImportError:"},{"line_number":37,"context_line":"    # Python 2.x"},{"line_number":38,"context_line":"    import urllib2"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_2009be94","line":36,"in_reply_to":"bf51134e_e957d725","updated":"2020-07-31 10:29:51.000000000","message":"Thanks for comment, we have removed this part and also other legacy code for python2.X in patch6.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # Python 3.x"},{"line_number":35,"context_line":"    import urllib.request as urllib2"},{"line_number":36,"context_line":"except ImportError:"},{"line_number":37,"context_line":"    # Python 2.x"},{"line_number":38,"context_line":"    import urllib2"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"HASH_LIST \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_e50b7d21","line":37,"updated":"2020-07-21 09:59:59.000000000","message":"You should drop python2 because it is not supported anymore.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5b7da6e14672c5562cd6b39810c0baf40efbca81","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # Python 3.x"},{"line_number":35,"context_line":"    import urllib.request as urllib2"},{"line_number":36,"context_line":"except ImportError:"},{"line_number":37,"context_line":"    # Python 2.x"},{"line_number":38,"context_line":"    import urllib2"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"HASH_LIST \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_6003b674","line":37,"in_reply_to":"bf51134e_e50b7d21","updated":"2020-07-31 10:29:51.000000000","message":"Thanks for comment, we have dropped this import also other python2 related code, aslo sorry for late comment","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    # Python 2.x"},{"line_number":38,"context_line":"    import urllib2"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"HASH_LIST \u003d {"},{"line_number":41,"context_line":"    \u0027sha-256\u0027: \u0027hashlib.sha256()\u0027,"},{"line_number":42,"context_line":"    \u0027sha-512\u0027: \u0027hashlib.sha512()\u0027,"},{"line_number":43,"context_line":"    \u0027sha-384\u0027: \u0027hashlib.sha384()\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_0a120063","line":40,"updated":"2020-07-21 09:59:59.000000000","message":"* I don\u0027t understand why you define values as a string and use `eval()` later.\n\n* The name of variable is not appropriate because it is not a list.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fb4e116c15d9c1356e257b8dd5ffa35bd6ee9c9e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    # Python 2.x"},{"line_number":38,"context_line":"    import urllib2"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"HASH_LIST \u003d {"},{"line_number":41,"context_line":"    \u0027sha-256\u0027: \u0027hashlib.sha256()\u0027,"},{"line_number":42,"context_line":"    \u0027sha-512\u0027: \u0027hashlib.sha512()\u0027,"},{"line_number":43,"context_line":"    \u0027sha-384\u0027: \u0027hashlib.sha384()\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_4c0c113b","line":40,"updated":"2020-07-21 09:31:22.000000000","message":"It\u0027s a matter of taste, but I think it\u0027s better to sort in ascending or descending order.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5b7da6e14672c5562cd6b39810c0baf40efbca81","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    # Python 2.x"},{"line_number":38,"context_line":"    import urllib2"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"HASH_LIST \u003d {"},{"line_number":41,"context_line":"    \u0027sha-256\u0027: \u0027hashlib.sha256()\u0027,"},{"line_number":42,"context_line":"    \u0027sha-512\u0027: \u0027hashlib.sha512()\u0027,"},{"line_number":43,"context_line":"    \u0027sha-384\u0027: \u0027hashlib.sha384()\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3aa0b443","line":40,"in_reply_to":"bf51134e_0a120063","updated":"2020-07-31 10:29:51.000000000","message":"we have fixed them in the newest patch","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5b7da6e14672c5562cd6b39810c0baf40efbca81","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    # Python 2.x"},{"line_number":38,"context_line":"    import urllib2"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"HASH_LIST \u003d {"},{"line_number":41,"context_line":"    \u0027sha-256\u0027: \u0027hashlib.sha256()\u0027,"},{"line_number":42,"context_line":"    \u0027sha-512\u0027: \u0027hashlib.sha512()\u0027,"},{"line_number":43,"context_line":"    \u0027sha-384\u0027: \u0027hashlib.sha384()\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_9af9004f","line":40,"in_reply_to":"bf51134e_4c0c113b","updated":"2020-07-31 10:29:51.000000000","message":"We have sorted them in the newest patch","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    if csar.is_tosca_metadata:"},{"line_number":305,"context_line":"        if csar._get_metadata(\"ETSI-Entry-Manifest\"):"},{"line_number":306,"context_line":"            manifest_path \u003d csar._get_metadata(\"ETSI-Entry-Manifest\")"},{"line_number":307,"context_line":"            if manifest_path.lower().endswith(\".mf\"):"},{"line_number":308,"context_line":"                manifest_data \u003d csar.zfile.read(manifest_path)"},{"line_number":309,"context_line":"                vnf_artifacts \u003d _convert_artifacts("},{"line_number":310,"context_line":"                    vnf_artifacts, manifest_data, csar)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_4a0b582a","line":307,"range":{"start_line":307,"start_character":29,"end_line":307,"end_character":36},"updated":"2020-07-21 09:59:59.000000000","message":"Please confirm Why chaining to `lower()`. Is there any possibility the extension is given as \".MF\", \".mF\" or \".Mf\"?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5b7da6e14672c5562cd6b39810c0baf40efbca81","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    if csar.is_tosca_metadata:"},{"line_number":305,"context_line":"        if csar._get_metadata(\"ETSI-Entry-Manifest\"):"},{"line_number":306,"context_line":"            manifest_path \u003d csar._get_metadata(\"ETSI-Entry-Manifest\")"},{"line_number":307,"context_line":"            if manifest_path.lower().endswith(\".mf\"):"},{"line_number":308,"context_line":"                manifest_data \u003d csar.zfile.read(manifest_path)"},{"line_number":309,"context_line":"                vnf_artifacts \u003d _convert_artifacts("},{"line_number":310,"context_line":"                    vnf_artifacts, manifest_data, csar)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_00f47a85","line":307,"range":{"start_line":307,"start_character":29,"end_line":307,"end_character":36},"in_reply_to":"bf51134e_4a0b582a","updated":"2020-07-31 10:29:51.000000000","message":"we are chaning to lower() to prevent if user gives a \".mF\" or \".Mf\" wrongly. Should we consider a \".mF\" file as a error input and give some exception here?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                        vnf_artifacts, manifest_data, csar)"},{"line_number":331,"context_line":"                else:"},{"line_number":332,"context_line":"                    invalid_manifest_err_msg \u003d \\"},{"line_number":333,"context_line":"                        ((\u0027The filename \"%(manifest)s\" is an invalid name.\u0027) %"},{"line_number":334,"context_line":"                        {\u0027manifest\u0027: path, \u0027csar\u0027: csar.path})"},{"line_number":335,"context_line":"                    raise exceptions.InvalidCSAR(invalid_manifest_err_msg)"},{"line_number":336,"context_line":"    # Deduplication"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_2a08a42b","line":333,"updated":"2020-07-21 09:59:59.000000000","message":"Could you make this message not to say just \"invalid\" but why it is invalid?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5b7da6e14672c5562cd6b39810c0baf40efbca81","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                        vnf_artifacts, manifest_data, csar)"},{"line_number":331,"context_line":"                else:"},{"line_number":332,"context_line":"                    invalid_manifest_err_msg \u003d \\"},{"line_number":333,"context_line":"                        ((\u0027The filename \"%(manifest)s\" is an invalid name.\u0027) %"},{"line_number":334,"context_line":"                        {\u0027manifest\u0027: path, \u0027csar\u0027: csar.path})"},{"line_number":335,"context_line":"                    raise exceptions.InvalidCSAR(invalid_manifest_err_msg)"},{"line_number":336,"context_line":"    # Deduplication"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1abcd067","line":333,"in_reply_to":"bf51134e_2a08a42b","updated":"2020-07-31 10:29:51.000000000","message":"we are checking is the manifast file have the same name with main template file in csar, besides we fixed the error message :)","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":380,"context_line":"def _validate_hash(algorithm, hash_code, csar, artifact_path):"},{"line_number":381,"context_line":"    z \u003d zipfile.ZipFile(csar.path)"},{"line_number":382,"context_line":"    algorithm \u003d algorithm.lower()"},{"line_number":383,"context_line":"    hashlib.sha256()"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    # validate Algorithm\u0027s value"},{"line_number":386,"context_line":"    if algorithm in HASH_LIST.keys():"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_8a057017","line":383,"updated":"2020-07-21 09:59:59.000000000","message":"Please confirm what do you want by just calling it.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5b7da6e14672c5562cd6b39810c0baf40efbca81","unresolved":false,"context_lines":[{"line_number":380,"context_line":"def _validate_hash(algorithm, hash_code, csar, artifact_path):"},{"line_number":381,"context_line":"    z \u003d zipfile.ZipFile(csar.path)"},{"line_number":382,"context_line":"    algorithm \u003d algorithm.lower()"},{"line_number":383,"context_line":"    hashlib.sha256()"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    # validate Algorithm\u0027s value"},{"line_number":386,"context_line":"    if algorithm in HASH_LIST.keys():"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7adb4cec","line":383,"in_reply_to":"bf51134e_8a057017","updated":"2020-07-31 10:29:51.000000000","message":"this is a mis-deleting, sorry for that.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                                     \u0027artifact Source is an invalid value.\u0027) %"},{"line_number":407,"context_line":"                                    {\u0027artifact_path\u0027: artifact_path})"},{"line_number":408,"context_line":"        raise exceptions.InvalidCSAR(invalid_artifact_err_msg)"},{"line_number":409,"context_line":"    calculated_hash \u003d hash_obj.hexdigest()"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    # validate Hash\u0027s value"},{"line_number":412,"context_line":"    if hash_code \u003d\u003d calculated_hash:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_6a029c0d","line":409,"updated":"2020-07-21 09:59:59.000000000","message":"Although it is tiny, you don\u0027t need to have this temporary variable.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5b7da6e14672c5562cd6b39810c0baf40efbca81","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                                     \u0027artifact Source is an invalid value.\u0027) %"},{"line_number":407,"context_line":"                                    {\u0027artifact_path\u0027: artifact_path})"},{"line_number":408,"context_line":"        raise exceptions.InvalidCSAR(invalid_artifact_err_msg)"},{"line_number":409,"context_line":"    calculated_hash \u003d hash_obj.hexdigest()"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    # validate Hash\u0027s value"},{"line_number":412,"context_line":"    if hash_code \u003d\u003d calculated_hash:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5ad648c5","line":409,"in_reply_to":"bf51134e_6a029c0d","updated":"2020-07-31 10:29:51.000000000","message":"fixed","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"b2457c6d1711c5f90ca6d1bee2a836ebca6b589c","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                     \u0027contain valid manifest.\u0027) %"},{"line_number":310,"context_line":"                    {\u0027manifest\u0027: manifest_path, \u0027csar\u0027: csar.path})"},{"line_number":311,"context_line":"                raise exceptions.InvalidCSAR(invalid_manifest_err_msg)"},{"line_number":312,"context_line":"        tosca_data \u003d csar.zfile.read(TOSCA_META)"},{"line_number":313,"context_line":"        vnf_artifacts \u003d _convert_artifacts(vnf_artifacts, tosca_data, csar)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    else:"},{"line_number":316,"context_line":"        filelist \u003d csar.zfile.namelist()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_e847161c","line":313,"range":{"start_line":312,"start_character":8,"end_line":313,"end_character":75},"updated":"2020-08-09 14:16:45.000000000","message":"Why do you add these 2 lines? According to [1] (see section 16.2), TOSCA.meta includes information of additional artifacts in a CSAR but the format for the artifacts in TOSCA.meta is different from that of the manifest file defined in ETST NFV-SOL 004. So _convert_artifacts() doesn\u0027t work well.\n\n[1] http://docs.oasis-open.org/tosca/TOSCA/v1.0/os/TOSCA-v1.0-os.pdf","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"a36999cc8fc5a32d9b22706cd1f9b21c2017e9c1","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                     \u0027contain valid manifest.\u0027) %"},{"line_number":310,"context_line":"                    {\u0027manifest\u0027: manifest_path, \u0027csar\u0027: csar.path})"},{"line_number":311,"context_line":"                raise exceptions.InvalidCSAR(invalid_manifest_err_msg)"},{"line_number":312,"context_line":"        tosca_data \u003d csar.zfile.read(TOSCA_META)"},{"line_number":313,"context_line":"        vnf_artifacts \u003d _convert_artifacts(vnf_artifacts, tosca_data, csar)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    else:"},{"line_number":316,"context_line":"        filelist \u003d csar.zfile.namelist()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_2afe386a","line":313,"range":{"start_line":312,"start_character":8,"end_line":313,"end_character":75},"in_reply_to":"9f560f44_e847161c","updated":"2020-08-26 04:58:40.000000000","message":"Thanks for comment ! Here we are considering user will provide artifacts info both in TOSCA.meta and manifest, we modified artifacts info in TOSCA.meta and _convert_artifacts to fit [1] in our newest patch, please kindly have a check on it :)","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"}],"tacker/common/exceptions.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"b7ab43b288956cd6b1655bf5d0450a1f9c7fa5c6","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"class VnfArtifactNotFound(NotFound):"},{"line_number":252,"context_line":"    message \u003d _(\"No vnf artifact  with id %(id)s.\")"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"class VnfInstantiatedInfoNotFound(NotFound):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_c9ebfd0f","line":252,"range":{"start_line":252,"start_character":32,"end_line":252,"end_character":34},"updated":"2020-07-20 17:02:11.000000000","message":"nit: 1 space seems unnecessary.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/db/db_sqlalchemy/models.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"bf300d7a0424fc992a67c2c41a6be300eedd5e18","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    \"\"\"Contains all info about vnf artifacts.\"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    __tablename__ \u003d \u0027vnf_artifacts\u0027"},{"line_number":137,"context_line":"    id \u003d sa.Column(sa.Integer, nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":138,"context_line":"    package_uuid \u003d sa.Column(sa.String(36),"},{"line_number":139,"context_line":"                             sa.ForeignKey(\u0027vnf_packages.id\u0027),"},{"line_number":140,"context_line":"                             nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3dd545b8","line":137,"range":{"start_line":137,"start_character":4,"end_line":137,"end_character":64},"updated":"2020-07-08 08:38:01.000000000","message":"How about inheriting ``models_v1.HasId``? This change force to change \"db/migration/alembic_migrations/versions/9d425296f2c3_add_vnfpkgm_db.py\", too. Without this change, it is needed to add generate_uuid() in \" def _create_vnf_artifacts() in conductor/conductor_server.py\"","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"84886bd17af82042663fc66d978f9c1800f43bc8","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    \"\"\"Contains all info about vnf artifacts.\"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    __tablename__ \u003d \u0027vnf_artifacts\u0027"},{"line_number":137,"context_line":"    id \u003d sa.Column(sa.Integer, nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":138,"context_line":"    package_uuid \u003d sa.Column(sa.String(36),"},{"line_number":139,"context_line":"                             sa.ForeignKey(\u0027vnf_packages.id\u0027),"},{"line_number":140,"context_line":"                             nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_67cd40b6","line":137,"range":{"start_line":137,"start_character":4,"end_line":137,"end_character":64},"in_reply_to":"bf51134e_3dd545b8","updated":"2020-07-10 10:36:01.000000000","message":"Thank you for comment, just to confirm in spec `Id` is an integer ? \n\nhttps://review.opendev.org/#/c/733028/4/specs/victoria/add-artifacts.rst \n# 209","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"d60ad289f09fb28f5af33d19d028ba4152a5566f","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    \"\"\"Contains all info about vnf artifacts.\"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    __tablename__ \u003d \u0027vnf_artifacts\u0027"},{"line_number":137,"context_line":"    id \u003d sa.Column(sa.Integer, nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":138,"context_line":"    package_uuid \u003d sa.Column(sa.String(36),"},{"line_number":139,"context_line":"                             sa.ForeignKey(\u0027vnf_packages.id\u0027),"},{"line_number":140,"context_line":"                             nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_bc011b6d","line":137,"range":{"start_line":137,"start_character":4,"end_line":137,"end_character":64},"in_reply_to":"bf51134e_67cd40b6","updated":"2020-07-13 00:30:31.000000000","message":"OK, I\u0027ll update the spec to be `types.Uuid`. Thank you.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"4f36680f7adf3884479244f900089ba2e08c8011","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    \"\"\"Contains all info about vnf artifacts.\"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    __tablename__ \u003d \u0027vnf_artifacts\u0027"},{"line_number":137,"context_line":"    id \u003d sa.Column(sa.Integer, nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":138,"context_line":"    package_uuid \u003d sa.Column(sa.String(36),"},{"line_number":139,"context_line":"                             sa.ForeignKey(\u0027vnf_packages.id\u0027),"},{"line_number":140,"context_line":"                             nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_654dbfc3","line":137,"range":{"start_line":137,"start_character":4,"end_line":137,"end_character":64},"in_reply_to":"bf51134e_bc011b6d","updated":"2020-07-20 01:56:11.000000000","message":"we have updated new code contains this logic, please kindly have a check.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"}],"tacker/db/migration/alembic_migrations/versions/9d425296f2c3_add_vnfpkgm_db.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"bf300d7a0424fc992a67c2c41a6be300eedd5e18","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                [\u0027vnf_packages.id\u0027], ),"},{"line_number":107,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":108,"context_line":"    )"},{"line_number":109,"context_line":"    op.create_table("},{"line_number":110,"context_line":"        \u0027vnf_artifacts\u0027,"},{"line_number":111,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, nullable\u003dFalse),"},{"line_number":112,"context_line":"        sa.Column(\u0027package_uuid\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9dfd713c","line":109,"range":{"start_line":109,"start_character":4,"end_line":109,"end_character":19},"updated":"2020-07-08 08:38:01.000000000","message":"In my understanding, \u0027created_at\u0027, \u0027updated_at\u0027, \u0027deleted_at\u0027, and \u0027deleted\u0027 fields are also needed.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"d60ad289f09fb28f5af33d19d028ba4152a5566f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                [\u0027vnf_packages.id\u0027], ),"},{"line_number":107,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":108,"context_line":"    )"},{"line_number":109,"context_line":"    op.create_table("},{"line_number":110,"context_line":"        \u0027vnf_artifacts\u0027,"},{"line_number":111,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, nullable\u003dFalse),"},{"line_number":112,"context_line":"        sa.Column(\u0027package_uuid\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3cd4ebe8","line":109,"range":{"start_line":109,"start_character":4,"end_line":109,"end_character":19},"in_reply_to":"bf51134e_073284f2","updated":"2020-07-13 00:30:31.000000000","message":"In delete operation, VnfPackage._destroy_vnf_package fails because it updates `deleted` and `deleted_at` fields. You need to add the logic to check vnf_artifacts DB table to be updated as `deleted\u003dTrue`.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"4f36680f7adf3884479244f900089ba2e08c8011","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                [\u0027vnf_packages.id\u0027], ),"},{"line_number":107,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":108,"context_line":"    )"},{"line_number":109,"context_line":"    op.create_table("},{"line_number":110,"context_line":"        \u0027vnf_artifacts\u0027,"},{"line_number":111,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, nullable\u003dFalse),"},{"line_number":112,"context_line":"        sa.Column(\u0027package_uuid\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a5c4f70f","line":109,"range":{"start_line":109,"start_character":4,"end_line":109,"end_character":19},"in_reply_to":"bf51134e_3cd4ebe8","updated":"2020-07-20 01:56:11.000000000","message":"we have updated new code contains this logic, please kindly have a check.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"84886bd17af82042663fc66d978f9c1800f43bc8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                [\u0027vnf_packages.id\u0027], ),"},{"line_number":107,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":108,"context_line":"    )"},{"line_number":109,"context_line":"    op.create_table("},{"line_number":110,"context_line":"        \u0027vnf_artifacts\u0027,"},{"line_number":111,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, nullable\u003dFalse),"},{"line_number":112,"context_line":"        sa.Column(\u0027package_uuid\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_073284f2","line":109,"range":{"start_line":109,"start_character":4,"end_line":109,"end_character":19},"in_reply_to":"bf51134e_9dfd713c","updated":"2020-07-10 10:36:01.000000000","message":"Thank you for comment, this is a mistake. We\u0027ll fix this in next patch, \nBtw, in our testing enviornment, we override tacker directory with new code and created artifact table manually so here didn\u0027t show any errors.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"bf300d7a0424fc992a67c2c41a6be300eedd5e18","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    )"},{"line_number":109,"context_line":"    op.create_table("},{"line_number":110,"context_line":"        \u0027vnf_artifacts\u0027,"},{"line_number":111,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, nullable\u003dFalse),"},{"line_number":112,"context_line":"        sa.Column(\u0027package_uuid\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"},{"line_number":113,"context_line":"        sa.Column(\u0027artifact_path\u0027, sa.Text(), nullable\u003dFalse),"},{"line_number":114,"context_line":"        sa.Column(\u0027algorithm\u0027, sa.String(64), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ddc6c916","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":51},"updated":"2020-07-08 08:38:01.000000000","message":"How about following the same manner as other tables to have \"sa.Column(\u0027id\u0027, types.Uuid(length\u003d36), nullable\u003dFalse)\"?","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"4f36680f7adf3884479244f900089ba2e08c8011","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    )"},{"line_number":109,"context_line":"    op.create_table("},{"line_number":110,"context_line":"        \u0027vnf_artifacts\u0027,"},{"line_number":111,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, nullable\u003dFalse),"},{"line_number":112,"context_line":"        sa.Column(\u0027package_uuid\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"},{"line_number":113,"context_line":"        sa.Column(\u0027artifact_path\u0027, sa.Text(), nullable\u003dFalse),"},{"line_number":114,"context_line":"        sa.Column(\u0027algorithm\u0027, sa.String(64), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_85c9f326","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":51},"in_reply_to":"bf51134e_ddc6c916","updated":"2020-07-20 01:56:11.000000000","message":"we have updated new code contains this logic, please kindly have a check.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"67584167717c98bb598af9188606d4fd70bb51ed","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":108,"context_line":"    )"},{"line_number":109,"context_line":"    op.create_table("},{"line_number":110,"context_line":"        \u0027vnf_artifacts\u0027,"},{"line_number":111,"context_line":"        sa.Column(\u0027id\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"},{"line_number":112,"context_line":"        sa.Column(\u0027package_uuid\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"},{"line_number":113,"context_line":"        sa.Column(\u0027artifact_path\u0027, sa.Text(), nullable\u003dFalse),"},{"line_number":114,"context_line":"        sa.Column(\u0027algorithm\u0027, sa.String(64), nullable\u003dFalse),"},{"line_number":115,"context_line":"        sa.Column(\u0027hash\u0027, sa.String(128), nullable\u003dFalse),"},{"line_number":116,"context_line":"        sa.Column(\u0027_metadata\u0027, sa.JSON(), nullable\u003dTrue),"},{"line_number":117,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime(), nullable\u003dFalse),"},{"line_number":118,"context_line":"        sa.Column(\u0027updated_at\u0027, sa.DateTime(), nullable\u003dTrue),"},{"line_number":119,"context_line":"        sa.Column(\u0027deleted_at\u0027, sa.DateTime(), nullable\u003dTrue),"},{"line_number":120,"context_line":"        sa.Column(\u0027deleted\u0027, Boolean, default\u003dFalse),"},{"line_number":121,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":122,"context_line":"        sa.ForeignKeyConstraint([\u0027package_uuid\u0027],"},{"line_number":123,"context_line":"                                [\u0027vnf_packages.id\u0027], ),"},{"line_number":124,"context_line":"        mysql_engine \u003d \u0027InnoDB\u0027"},{"line_number":125,"context_line":"    )"},{"line_number":126,"context_line":"    op.create_table("},{"line_number":127,"context_line":"        \u0027vnf_software_images\u0027,"},{"line_number":128,"context_line":"        sa.Column(\u0027id\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_fc0b1cd2","line":125,"range":{"start_line":110,"start_character":0,"end_line":125,"end_character":5},"updated":"2020-09-15 21:30:18.000000000","message":"When updating the DB schema, you need to create a new script instead of updating the existing DB migration script because consider the case of DB upgrade from U release to V release.\nI think that the script can be generated automatically or create new script.\nPlease refer to [1] or [2] for detail.\n[1] https://docs.openstack.org/neutron/latest/contributor/alembic_migrations.html\n[2] tacker/db/migration/README","commit_id":"f9121f1ec61c81d30459acacd96b09297858858d"}],"tacker/tests/constants.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"bf300d7a0424fc992a67c2c41a6be300eedd5e18","unresolved":false,"context_lines":[{"line_number":39,"context_line":"LEASE_CHECK_SLEEP_TIME \u003d 3"},{"line_number":40,"context_line":"UUID \u003d \u0027f26f181d-7891-4720-b022-b074ec1733ef\u0027"},{"line_number":41,"context_line":"INVALID_UUID \u003d \u0027f181d-7891-4720-b022-b074ec3ef\u0027"},{"line_number":42,"context_line":"ARTIFACT_PATH \u003d \u0027Scripts/install.sh\u0027"},{"line_number":43,"context_line":"INVALID_ARTIFACT_PATH \u003d \u0027Scripts/install1.sh\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_7d7b3dbd","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":45},"updated":"2020-07-08 08:38:01.000000000","message":"A comment line is needed to describe these two new variables are related to artifacts test other than Blazar.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"84886bd17af82042663fc66d978f9c1800f43bc8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"LEASE_CHECK_SLEEP_TIME \u003d 3"},{"line_number":40,"context_line":"UUID \u003d \u0027f26f181d-7891-4720-b022-b074ec1733ef\u0027"},{"line_number":41,"context_line":"INVALID_UUID \u003d \u0027f181d-7891-4720-b022-b074ec3ef\u0027"},{"line_number":42,"context_line":"ARTIFACT_PATH \u003d \u0027Scripts/install.sh\u0027"},{"line_number":43,"context_line":"INVALID_ARTIFACT_PATH \u003d \u0027Scripts/install1.sh\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_873df48f","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":45},"in_reply_to":"bf51134e_7d7b3dbd","updated":"2020-07-10 10:36:01.000000000","message":"Thank you for comment, we will add comments in next patch :)","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"4f36680f7adf3884479244f900089ba2e08c8011","unresolved":false,"context_lines":[{"line_number":39,"context_line":"LEASE_CHECK_SLEEP_TIME \u003d 3"},{"line_number":40,"context_line":"UUID \u003d \u0027f26f181d-7891-4720-b022-b074ec1733ef\u0027"},{"line_number":41,"context_line":"INVALID_UUID \u003d \u0027f181d-7891-4720-b022-b074ec3ef\u0027"},{"line_number":42,"context_line":"ARTIFACT_PATH \u003d \u0027Scripts/install.sh\u0027"},{"line_number":43,"context_line":"INVALID_ARTIFACT_PATH \u003d \u0027Scripts/install1.sh\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e5ceef2b","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":45},"in_reply_to":"bf51134e_873df48f","updated":"2020-07-20 01:56:11.000000000","message":"we have updated new code contains this logic, please kindly have a check.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":41,"context_line":"INVALID_UUID \u003d \u0027f181d-7891-4720-b022-b074ec3ef\u0027"},{"line_number":42,"context_line":"# artifact related"},{"line_number":43,"context_line":"ARTIFACT_PATH \u003d \u0027Scripts/install.sh\u0027"},{"line_number":44,"context_line":"INVALID_ARTIFACT_PATH \u003d \u0027Scripts/install1.sh\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_200d6335","line":44,"range":{"start_line":44,"start_character":33,"end_line":44,"end_character":41},"updated":"2020-07-21 09:59:59.000000000","message":"Could you consider to use obviously different name with ARTIFACT_PATH to make it easy to find the difference?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/common/Definitions/etsi_nfv_sol001_common_types.yaml":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"752f6f2fe4f21ace8605d053120ee699d7e2da37","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_3"},{"line_number":2,"context_line":"description: ETSI NFV SOL 001 common types definitions version 3.3.1"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  template_name: etsi_nfv_sol001_common_types"},{"line_number":5,"context_line":"  template_author: ETSI_NFV"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9f560f44_c418641f","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":68},"updated":"2020-09-10 05:38:06.000000000","message":"The `etsi_nfv_sol001_common_types.yaml` and `etsi_nfv_sol001_vnfd_types.yaml` used version is `v2.6.1` in V release. The latest files of `v2.6.1` is the official [1] [2] URL. \n\n[1] https://forge.etsi.org/rep/nfv/SOL001/raw/v2.6.1/etsi_nfv_sol001_common_types.yaml\n[2] https://forge.etsi.org/rep/nfv/SOL001/raw/v2.6.1/etsi_nfv_sol001_vnfd_types.yaml","commit_id":"77dd955a0ae786e802eb32bf7f60663a9a83ca11"}],"tacker/tests/etc/samples/etsi/nfv/common/Definitions/etsi_nfv_sol001_vnfd_types.yaml":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"7d5fcd2f37c41f90ca9e6d02d969cd82fc5b9008","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":"description: ETSI NFV SOL 001 vnfd types definitions version 2.6.1"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  template_name: etsi_nfv_sol001_vnfd_types"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f560f44_3c282284","line":1,"updated":"2020-09-12 15:14:25.000000000","message":"Suggestion. You add this file to several different directories but how about make this master and put symlink for others? Then, we just need to update only this file when there are any changes to this file.","commit_id":"f117cc7cb48e3c5185387ae71095b141415ad2f3"}],"tacker/tests/etc/samples/etsi/nfv/sample_download_vnf_package_csar_artifact/Definitions/helloworld3_df_simple.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Simple deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_2cd1dd30","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_download_vnf_package_csar_artifact/Definitions/helloworld3_top.vnfd.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_4ce091fb","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_download_vnf_package_csar_artifact/Definitions/helloworld3_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: VNF type definition"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_4c12510b","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_download_vnf_package_csar_artifact/TOSCA-Metadata/TOSCA.meta":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TOSCA-Meta-File-Version: 1.0"},{"line_number":2,"context_line":"Created-by: Hiroyuki JO"},{"line_number":3,"context_line":"CSAR-Version: 1.1"},{"line_number":4,"context_line":"Entry-Definitions: Definitions/helloworld3_top.vnfd.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9f560f44_41b82ae4","line":2,"updated":"2020-09-04 17:03:08.000000000","message":"Please avoid to use actual personal name.","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"92150410062942d25fbe613c109800767dcec758","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TOSCA-Meta-File-Version: 1.0"},{"line_number":2,"context_line":"Created-by: Hiroyuki JO"},{"line_number":3,"context_line":"CSAR-Version: 1.1"},{"line_number":4,"context_line":"Entry-Definitions: Definitions/helloworld3_top.vnfd.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9f560f44_db269acb","line":2,"in_reply_to":"9f560f44_41b82ae4","updated":"2020-09-10 05:48:14.000000000","message":"All personal name is removed in the newest patch, please kindly have a confirm on it :)","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/Definitions/etsi_nfv_sol001_common_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_41d30ad6","line":1,"updated":"2020-09-04 17:03:08.000000000","message":"Could you describe what is your todo more exactly. It\u0027s ambiguous that it\u0027s a future work, or note for the usage.\n\nIf it\u0027s todo, you should add your nickname to show who has the responsibility.","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"92150410062942d25fbe613c109800767dcec758","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_5b144a4d","line":1,"in_reply_to":"9f560f44_41d30ad6","updated":"2020-09-10 05:48:14.000000000","message":"We are assuming to get newest version of VNFD from etsi to make sure no useless comments remains in vnfd file. However we tried to use v3.3.1 but Zuul check is not passed, we will update another patch to use v2.6.1 after local tox check.\n\nAlso other uncomplete comment outs/mistakes will be solved after file replace, same to here. like line 3 and line 38.","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"},{"line_number":5,"context_line":"metadata:"},{"line_number":6,"context_line":"  template_name: etsi_nfv_sol001_common_types"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_e147bebb","line":3,"updated":"2020-09-04 17:03:08.000000000","message":"Why this line is required? Misspelled for 1.0?","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        required: false"},{"line_number":36,"context_line":"        constraints:"},{"line_number":37,"context_line":"          - valid_values: [ ipv4, ipv6 ]"},{"line_number":38,"context_line":"      number_of_ip_address:"},{"line_number":39,"context_line":"        type: integer"},{"line_number":40,"context_line":"        description: Minimum number of IP addresses to be assigned"},{"line_number":41,"context_line":"        required: false"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_21bd3668","line":38,"range":{"start_line":38,"start_character":16,"end_line":38,"end_character":26},"updated":"2020-09-04 17:03:08.000000000","message":"Why it is singular?","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/Definitions/etsi_nfv_sol001_vnfd_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 vnfd types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_014e3295","line":1,"updated":"2020-09-04 17:03:08.000000000","message":"Same as [1].\n[1] https://review.opendev.org/#/c/739697/10/tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/Definitions/etsi_nfv_sol001_common_types.yaml","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"92150410062942d25fbe613c109800767dcec758","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 vnfd types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_c4c22434","line":1,"in_reply_to":"9f560f44_014e3295","updated":"2020-09-10 05:48:14.000000000","message":"resolved by replace newest file","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 vnfd types definitions version 2.6.1"},{"line_number":5,"context_line":"metadata:"},{"line_number":6,"context_line":"  template_name: etsi_nfv_sol001_vnfd_types"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_a15e6642","line":3,"updated":"2020-09-04 17:03:08.000000000","message":"same as above","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":143,"context_line":"  tosca.datatypes.nfv.VnfcConfigurableProperties:"},{"line_number":144,"context_line":"    derived_from: tosca.datatypes.Root"},{"line_number":145,"context_line":"    description: Defines the configurable properties of a VNFC"},{"line_number":146,"context_line":"    # properties:"},{"line_number":147,"context_line":"      # additional_vnfc_configurable_properties:"},{"line_number":148,"context_line":"      #   type: tosca.datatypes.nfv.VnfcAdditionalConfigurableProperties"},{"line_number":149,"context_line":"      #   description: Describes additional configuration for VNFC that"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_244c2475","line":146,"updated":"2020-09-04 17:03:08.000000000","message":"Could you tell me why you comment out here, follow blocks similar to here, such as L.851, 864 or so ?","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/Definitions/sample_vnfd_df_complex_int.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Complex deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_2c2c3d49","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/Definitions/sample_vnfd_df_simple_int.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Simple deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_6c26356b","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/Definitions/sample_vnfd_top.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNF of NTT NS lab."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_4c2b712f","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/Definitions/sample_vnfd_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: ntt.nslab.VNF type definition"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_ac1fad07","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/Files/images/cirros.img":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"0c3944114b25f6de26fa6a6e10b42e04cf0dd18b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#### THIS IS A DUMMY FILE TO SAVE FILE SIZE #####"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"9f560f44_32214fb7","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":49},"updated":"2020-09-15 07:38:12.000000000","message":"I think this file is not needed. This file may be referred from TOSCA.meta file.","commit_id":"f9121f1ec61c81d30459acacd96b09297858858d"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/TOSCA-Metadata/TOSCA.meta":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"b2457c6d1711c5f90ca6d1bee2a836ebca6b589c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Entry-Definitions: Definitions/sample_vnfd_top.yaml"},{"line_number":5,"context_line":"ETSI-Entry-Manifest: manifest.mf"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Source: Scripts/install.sh"},{"line_number":8,"context_line":"Algorithm: SHA-256"},{"line_number":9,"context_line":"Hash: 27bbdb25d8f4ed6d07d6f6581b86515e8b2f0059b236ef7b6f50d6674b34f02a"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"9f560f44_8862daac","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2020-08-09 14:16:45.000000000","message":"According to section 16.2 in [1], this should be Name.\n\n[1] http://docs.oasis-open.org/tosca/TOSCA/v1.0/os/TOSCA-v1.0-os.pdf","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"a36999cc8fc5a32d9b22706cd1f9b21c2017e9c1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Entry-Definitions: Definitions/sample_vnfd_top.yaml"},{"line_number":5,"context_line":"ETSI-Entry-Manifest: manifest.mf"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Source: Scripts/install.sh"},{"line_number":8,"context_line":"Algorithm: SHA-256"},{"line_number":9,"context_line":"Hash: 27bbdb25d8f4ed6d07d6f6581b86515e8b2f0059b236ef7b6f50d6674b34f02a"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"9f560f44_2ab0f8dc","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"9f560f44_8862daac","updated":"2020-08-26 04:58:40.000000000","message":"Thanks for comment! We misunderstood here and in the newest patch we fixed artifacts info to have Name, Content-type, Algorithm and Hash. Please kindly have a confirm","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"b2457c6d1711c5f90ca6d1bee2a836ebca6b589c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"ETSI-Entry-Manifest: manifest.mf"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Source: Scripts/install.sh"},{"line_number":8,"context_line":"Algorithm: SHA-256"},{"line_number":9,"context_line":"Hash: 27bbdb25d8f4ed6d07d6f6581b86515e8b2f0059b236ef7b6f50d6674b34f02a"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"9f560f44_c85852fb","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":18},"updated":"2020-08-09 14:16:45.000000000","message":"Content-type is needed before this line as well.","commit_id":"81827dfb9798afc8a1466dfa65820fbd8e672b62"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest_false/Definitions/etsi_nfv_sol001_common_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_04d48046","line":1,"updated":"2020-09-04 17:03:08.000000000","message":"Same as [1].\n[1] https://review.opendev.org/#/c/739697/10/tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/Definitions/etsi_nfv_sol001_common_types.yaml","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"92150410062942d25fbe613c109800767dcec758","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_44e454e0","line":1,"in_reply_to":"9f560f44_04d48046","updated":"2020-09-10 05:48:14.000000000","message":"problems here will resolved by replace newest file","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"},{"line_number":5,"context_line":"metadata:"},{"line_number":6,"context_line":"  template_name: etsi_nfv_sol001_common_types"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_64cbbca4","line":3,"updated":"2020-09-04 17:03:08.000000000","message":"same as above","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest_false/Definitions/etsi_nfv_sol001_vnfd_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 vnfd types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_44ce78b4","line":1,"updated":"2020-09-04 17:03:08.000000000","message":"Same as [1].\n[1] https://review.opendev.org/#/c/739697/10/tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/Definitions/etsi_nfv_sol001_common_types.yaml","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"92150410062942d25fbe613c109800767dcec758","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 vnfd types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_24e7a0e5","line":1,"in_reply_to":"9f560f44_44ce78b4","updated":"2020-09-10 05:48:14.000000000","message":"will be resolved by replace newest file","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 vnfd types definitions version 2.6.1"},{"line_number":5,"context_line":"metadata:"},{"line_number":6,"context_line":"  template_name: etsi_nfv_sol001_vnfd_types"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_84bff0fa","line":3,"updated":"2020-09-04 17:03:08.000000000","message":"same as above","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest_false/Definitions/sample_vnfd_df_complex_int.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Complex deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_8ce10900","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest_false/Definitions/sample_vnfd_df_simple_int.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Simple deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_eceec5eb","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest_false/Definitions/sample_vnfd_top.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNF of NTT NS lab."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_cceb01da","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNF of NTT NS lab."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"imports:"},{"line_number":6,"context_line":"  - etsi_nfv_sol001_common_types.yaml"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_6cb475f3","line":3,"range":{"start_line":3,"start_character":27,"end_line":3,"end_character":37},"updated":"2020-07-21 09:59:59.000000000","message":"Please avoid such a specific name.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest_false/Definitions/sample_vnfd_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: ntt.nslab.VNF type definition"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_accded87","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: ntt.nslab.VNF type definition"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"imports:"},{"line_number":6,"context_line":"  - etsi_nfv_sol001_common_types.yaml"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_ecc7e563","line":3,"range":{"start_line":3,"start_character":13,"end_line":3,"end_character":23},"updated":"2020-07-21 09:59:59.000000000","message":"please avoid such a specific name.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - etsi_nfv_sol001_vnfd_types.yaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"node_types:"},{"line_number":10,"context_line":"  ntt.nslab.VNF:"},{"line_number":11,"context_line":"    derived_from: tosca.nodes.nfv.VNF"},{"line_number":12,"context_line":"    properties:"},{"line_number":13,"context_line":"      id:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_0ca4d9b8","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":11},"updated":"2020-07-21 09:59:59.000000000","message":"ditto","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        default: \u00271.0\u0027"},{"line_number":33,"context_line":"      provider:"},{"line_number":34,"context_line":"        type: string"},{"line_number":35,"context_line":"        constraints: [ valid_values: [ \u0027NTT NS lab\u0027 ] ]"},{"line_number":36,"context_line":"        default: \u0027NTT NS lab\u0027"},{"line_number":37,"context_line":"      product_name:"},{"line_number":38,"context_line":"        type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_ac920d57","line":35,"updated":"2020-07-21 09:59:59.000000000","message":"ditto for this line and next one.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest_false_algorithm/Definitions/etsi_nfv_sol001_common_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_445cb8ec","line":1,"updated":"2020-09-04 17:03:08.000000000","message":"Same as [1].\n[1] https://review.opendev.org/#/c/739697/10/tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/Definitions/etsi_nfv_sol001_common_types.yaml","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"92150410062942d25fbe613c109800767dcec758","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_84d14cfe","line":1,"in_reply_to":"9f560f44_445cb8ec","updated":"2020-09-10 05:48:14.000000000","message":"will be resolved by replace newest file","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"},{"line_number":5,"context_line":"metadata:"},{"line_number":6,"context_line":"  template_name: etsi_nfv_sol001_common_types"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_a472f47a","line":3,"updated":"2020-09-04 17:03:08.000000000","message":"same as above","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest_false_algorithm/Definitions/etsi_nfv_sol001_vnfd_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 vnfd types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_240424c6","line":1,"updated":"2020-09-04 17:03:08.000000000","message":"Same as [1].\n[1] https://review.opendev.org/#/c/739697/10/tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest/Definitions/etsi_nfv_sol001_common_types.yaml","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"92150410062942d25fbe613c109800767dcec758","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 vnfd types definitions version 2.6.1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_64ccf860","line":1,"in_reply_to":"9f560f44_240424c6","updated":"2020-09-10 05:48:14.000000000","message":"will be resolved by replace newest file","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# TODO:Manually change from version 1.2 to 1.0"},{"line_number":2,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":3,"context_line":"#tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":4,"context_line":"description: ETSI NFV SOL 001 vnfd types definitions version 2.6.1"},{"line_number":5,"context_line":"metadata:"},{"line_number":6,"context_line":"  template_name: etsi_nfv_sol001_vnfd_types"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_44115804","line":3,"updated":"2020-09-04 17:03:08.000000000","message":"same as above","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest_false_algorithm/Definitions/sample_vnfd_df_complex_int.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Complex deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_2cb6fddd","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  node_templates:"},{"line_number":45,"context_line":"    VNF:"},{"line_number":46,"context_line":"      type: ntt.nslab.VNF"},{"line_number":47,"context_line":"      properties:"},{"line_number":48,"context_line":"        flavour_description: A complex flavour"},{"line_number":49,"context_line":"      interfaces:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_4cb531cd","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":22},"updated":"2020-07-21 09:59:59.000000000","message":"please avoid specific one","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest_false_algorithm/Definitions/sample_vnfd_df_simple_int.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Simple deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_ccc0212e","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest_false_algorithm/Definitions/sample_vnfd_top.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNF of NTT NS lab."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_2cdb9d21","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNF of NTT NS lab."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"imports:"},{"line_number":6,"context_line":"  - etsi_nfv_sol001_common_types.yaml"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_0ce059cc","line":3,"range":{"start_line":3,"start_character":27,"end_line":3,"end_character":37},"updated":"2020-07-21 09:59:59.000000000","message":"please avoid specific one.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  node_templates:"},{"line_number":19,"context_line":"    VNF:"},{"line_number":20,"context_line":"      type: ntt.nslab.VNF"},{"line_number":21,"context_line":"      properties:"},{"line_number":22,"context_line":"        flavour_id: { get_input: selected_flavour }"},{"line_number":23,"context_line":"        descriptor_id: b1bb0ce7-ebca-4fa7-95ed-4840d70a1177"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_4cea51ac","line":20,"range":{"start_line":20,"start_character":12,"end_line":20,"end_character":22},"updated":"2020-07-21 09:59:59.000000000","message":"ditto","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      properties:"},{"line_number":22,"context_line":"        flavour_id: { get_input: selected_flavour }"},{"line_number":23,"context_line":"        descriptor_id: b1bb0ce7-ebca-4fa7-95ed-4840d70a1177"},{"line_number":24,"context_line":"        provider: NTT NS lab"},{"line_number":25,"context_line":"        product_name: Sample VNF"},{"line_number":26,"context_line":"        software_version: \u00271.0\u0027"},{"line_number":27,"context_line":"        descriptor_version: \u00271.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_6ce595dc","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":28},"updated":"2020-07-21 09:59:59.000000000","message":"ditto","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnf_package_csar_in_meta_and_manifest_false_algorithm/Definitions/sample_vnfd_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: ntt.nslab.VNF type definition"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_acce8d58","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_tosac_vnfd/Definitions/helloworld3_df_simple.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Simple deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_0c92194c","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_tosac_vnfd/Definitions/helloworld3_top.vnfd.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_ec752534","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_tosac_vnfd/Definitions/helloworld3_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: VNF type definition"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_4c87f110","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_tosac_vnfd/TOSCA-Metadata/TOSCA.meta":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TOSCA-Meta-File-Version: 1.0"},{"line_number":2,"context_line":"Created-by: Hiroyuki JO"},{"line_number":3,"context_line":"CSAR-Version: 1.1"},{"line_number":4,"context_line":"Entry-Definitions: Definitions/helloworld3_top.vnfd.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"bf51134e_0c8df930","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":23},"updated":"2020-07-21 09:59:59.000000000","message":"please avoid specific name","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_tosca_vnfd/Definitions/helloworld3_df_simple.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Simple deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_cc99417a","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_tosca_vnfd/Definitions/helloworld3_top.vnfd.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_ec9c056c","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove such an invalid char.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfpkg_tosca_vnfd/TOSCA-Metadata/TOSCA.meta":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TOSCA-Meta-File-Version: 1.0"},{"line_number":2,"context_line":"Created-by: Hiroyuki JO"},{"line_number":3,"context_line":"CSAR-Version: 1.1"},{"line_number":4,"context_line":"Entry-Definitions: Definitions/helloworld3_top.vnfd.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"bf51134e_6c0d95e7","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":23},"updated":"2020-07-21 09:59:59.000000000","message":"Could you avoid to use specific person\u0027s name here?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/etsi/nfv/vnfpkgm3/vnfd_helloworld_single.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNFD in sigle file by NTT NS lab."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"metadata:"},{"line_number":6,"context_line":"  template_author: Hiroyuki JO"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_4cf6d1fb","line":3,"range":{"start_line":3,"start_character":38,"end_line":3,"end_character":52},"updated":"2020-07-21 09:59:59.000000000","message":"I think no need to describe it.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":3,"context_line":"description: Sample VNFD in sigle file by NTT NS lab."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"metadata:"},{"line_number":6,"context_line":"  template_author: Hiroyuki JO"},{"line_number":7,"context_line":"  template_version: 1.0"},{"line_number":8,"context_line":"  template_name: Sample VNFD"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_2c827d53","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":30},"updated":"2020-07-21 09:59:59.000000000","message":"please avoid such a specific name","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  # datatype definitions"},{"line_number":12,"context_line":"  tosca.datatypes.nfv.ConnectivityType:"},{"line_number":13,"context_line":"    derived_from: tosca.datatypes.Root"},{"line_number":14,"context_line":"    description: describes additional connectivity information of a virtualLink "},{"line_number":15,"context_line":"    properties:"},{"line_number":16,"context_line":"      layer_protocols:"},{"line_number":17,"context_line":"        type: list"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_ac95ed8a","line":14,"range":{"start_line":14,"start_character":79,"end_line":14,"end_character":80},"updated":"2020-07-21 09:59:59.000000000","message":"Could you remove this space char?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      cidr:"},{"line_number":46,"context_line":"        type: string"},{"line_number":47,"context_line":"        description: Specifies the CIDR (Classless Inter-Domain Routing) of this L3 protocol. The value may be overridden at run-time."},{"line_number":48,"context_line":"        required: true  "},{"line_number":49,"context_line":"      ip_allocation_pools:"},{"line_number":50,"context_line":"        type: list"},{"line_number":51,"context_line":"        description: Specifies the allocation pools with start and end IP addresses for this L3 protocol. The value may be overridden at run-time."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_ece4053f","line":48,"range":{"start_line":48,"start_character":22,"end_line":48,"end_character":24},"updated":"2020-07-21 09:59:59.000000000","message":"Please remove it, and all spaces at the end of lines below.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"70a61d64888e64c6839527781b4802c0f11e2290","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  # datatype definitions"},{"line_number":12,"context_line":"  tosca.datatypes.nfv.ConnectivityType:"},{"line_number":13,"context_line":"    derived_from: tosca.datatypes.Root"},{"line_number":14,"context_line":"    description: describes additional connectivity information of a virtualLink "},{"line_number":15,"context_line":"    properties:"},{"line_number":16,"context_line":"      layer_protocols:"},{"line_number":17,"context_line":"        type: list"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_d776cad8","line":14,"updated":"2020-07-30 07:49:20.000000000","message":"White space trailiing, not only this one but also many below.","commit_id":"136742156b6aa32dc0839fbb68ce0ffe5aebaac9"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"description: Sample VNFD in sigle file by Company Provider."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"metadata:"},{"line_number":6,"context_line":"  template_author: Hiroyuki JO"},{"line_number":7,"context_line":"  template_version: 1.0"},{"line_number":8,"context_line":"  template_name: Sample VNFD"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_81f7d059","line":6,"updated":"2020-09-04 17:03:08.000000000","message":"Please avoid personal name.","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"92150410062942d25fbe613c109800767dcec758","unresolved":false,"context_lines":[{"line_number":3,"context_line":"description: Sample VNFD in sigle file by Company Provider."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"metadata:"},{"line_number":6,"context_line":"  template_author: Hiroyuki JO"},{"line_number":7,"context_line":"  template_version: 1.0"},{"line_number":8,"context_line":"  template_name: Sample VNFD"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_44fd746c","line":6,"in_reply_to":"9f560f44_81f7d059","updated":"2020-09-10 05:48:14.000000000","message":"replaced by Tacker/Fujitsu in the newest patch","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"}],"tacker/tests/etc/samples/sample_vnf_package_csar_in_meta_and_manifest/Definitions/sample_vnfd_df_complex_int.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Complex deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_4c5a512a","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"It seems some invalid character is here, can be happen on windows sometime. Could you confirm that?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  node_templates:"},{"line_number":45,"context_line":"    VNF:"},{"line_number":46,"context_line":"      type: ntt.nslab.VNF"},{"line_number":47,"context_line":"      properties:"},{"line_number":48,"context_line":"        flavour_description: A complex flavour"},{"line_number":49,"context_line":"      interfaces:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_2c743d9c","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":21},"updated":"2020-07-21 09:59:59.000000000","message":"please avoid such a specific name.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/sample_vnf_package_csar_in_meta_and_manifest/Definitions/sample_vnfd_df_simple_int.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Simple deployment flavour for Sample VNF"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_6c07551a","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"It seems some invalid character is here, can be happen on windows sometime. Could you confirm that?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      type: string"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  substitution_mappings:"},{"line_number":38,"context_line":"    node_type: ntt.nslab.VNF"},{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      flavour_id: simple"},{"line_number":41,"context_line":"    requirements:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_ac104d51","line":38,"range":{"start_line":38,"start_character":15,"end_line":38,"end_character":24},"updated":"2020-07-21 09:59:59.000000000","message":"please avoid such a specific name.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  node_templates:"},{"line_number":45,"context_line":"    VNF:"},{"line_number":46,"context_line":"      type: ntt.nslab.VNF"},{"line_number":47,"context_line":"      properties:"},{"line_number":48,"context_line":"        flavour_description: A simple flavour"},{"line_number":49,"context_line":"      interfaces:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_8c0d8937","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":21},"updated":"2020-07-21 09:59:59.000000000","message":"ditto","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/sample_vnf_package_csar_in_meta_and_manifest/Definitions/sample_vnfd_top.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNF of NTT NS lab."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_e6c38437","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"It seems some invalid character is here, can be happen on windows sometime. Could you confirm that?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: Sample VNF of NTT NS lab."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"imports:"},{"line_number":6,"context_line":"  - etsi_nfv_sol001_common_types.yaml"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_06e038cc","line":3,"range":{"start_line":3,"start_character":27,"end_line":3,"end_character":37},"updated":"2020-07-21 09:59:59.000000000","message":"Could you avoid to use such as specific name?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  node_templates:"},{"line_number":19,"context_line":"    VNF:"},{"line_number":20,"context_line":"      type: ntt.nslab.VNF"},{"line_number":21,"context_line":"      properties:"},{"line_number":22,"context_line":"        flavour_id: { get_input: selected_flavour }"},{"line_number":23,"context_line":"        descriptor_id: b1bb0ce7-ebca-4fa7-95ed-4840d70a1177"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_e016cb55","line":20,"range":{"start_line":20,"start_character":12,"end_line":20,"end_character":21},"updated":"2020-07-21 09:59:59.000000000","message":"ditto","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      properties:"},{"line_number":22,"context_line":"        flavour_id: { get_input: selected_flavour }"},{"line_number":23,"context_line":"        descriptor_id: b1bb0ce7-ebca-4fa7-95ed-4840d70a1177"},{"line_number":24,"context_line":"        provider: NTT NS lab"},{"line_number":25,"context_line":"        product_name: Sample VNF"},{"line_number":26,"context_line":"        software_version: \u00271.0\u0027"},{"line_number":27,"context_line":"        descriptor_version: \u00271.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_2008c32b","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":28},"updated":"2020-07-21 09:59:59.000000000","message":"ditto","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/etc/samples/sample_vnf_package_csar_in_meta_and_manifest/Definitions/sample_vnfd_types.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: ntt.nslab.VNF type definition"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_60547b22","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2020-07-21 09:59:59.000000000","message":"It seems some invalid character is here, can be happen on windows sometime. Could you confirm that?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: ntt.nslab.VNF type definition"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"imports:"},{"line_number":6,"context_line":"  - etsi_nfv_sol001_common_types.yaml"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_802c2fad","line":3,"range":{"start_line":3,"start_character":13,"end_line":3,"end_character":22},"updated":"2020-07-21 09:59:59.000000000","message":"Could you avoid to use such a specific name?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/functional/vnfpkgm/test_vnf_package.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0880fd49de6a1c871dc9651786123f2a3bb67c83","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        self.assertIsNotNone(response2[1])"},{"line_number":502,"context_line":"        self.assertEqual(200, response3[0].status_code)"},{"line_number":503,"context_line":"        self.assertEqual(\u002733\u0027, response3[0].headers[\u0027Content-Length\u0027])"},{"line_number":504,"context_line":"        self.assertIsNotNone(response3.[1])"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def test_fetch_vnf_package_artifacts_partial_download_using_range(self):"},{"line_number":507,"context_line":"        # get range"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_90252fc5","line":504,"updated":"2020-07-10 06:02:26.000000000","message":"pep8: E999 SyntaxError: invalid syntax","commit_id":"2d5ed1485ef02df5e480e6f8cb0e06734f890b43"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \"\"\"Creates and deletes a vnf package.\"\"\""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # Create vnf package"},{"line_number":121,"context_line":"        vnf_package_id \u003d self._create_and_upload_vnf(\u0027vnfpkgm1\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # show vnf package"},{"line_number":124,"context_line":"        show_url \u003d self.base_url + \"/\" + vnf_package_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_408697bc","line":121,"range":{"start_line":121,"start_character":19,"end_line":121,"end_character":22},"updated":"2020-07-21 09:59:59.000000000","message":"Just a question. Why you change from `uuid` of `package_uuid` to `id` of `vnf_package_id`? Is it not a uuid?","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            \u0027softwareImages\u0027,"},{"line_number":291,"context_line":"            \u0027checksum\u0027,"},{"line_number":292,"context_line":"            \u0027userDefinedData\u0027,"},{"line_number":293,"context_line":"                \u0027additionalArtifacts\u0027]:"},{"line_number":294,"context_line":"            package.pop(attr, None)"},{"line_number":295,"context_line":"        expected_result \u003d [package]"},{"line_number":296,"context_line":"        self.assertEqual(expected_result, body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_8090afef","line":293,"updated":"2020-07-21 09:59:59.000000000","message":"nit. You should keep the indent level same.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ddab2c8c9370d7f028d95038e5bea28f4ab15b25","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            \u0027softwareImages\u0027,"},{"line_number":324,"context_line":"            \u0027checksum\u0027,"},{"line_number":325,"context_line":"            \u0027userDefinedData\u0027,"},{"line_number":326,"context_line":"                \u0027additionalArtifacts\u0027]:"},{"line_number":327,"context_line":"            package2.pop(attr, None)"},{"line_number":328,"context_line":"        expected_result \u003d [package2]"},{"line_number":329,"context_line":"        self.assertEqual(expected_result, body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_608d9bd2","line":326,"updated":"2020-07-21 09:59:59.000000000","message":"nit. You should keep the indent level same.","commit_id":"5099566d69a2e761c0b7d2d013901de77c01dc3e"}],"tacker/tests/unit/common/test_csar_utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cc9fee15700a732015d95353001340a1b1e2587c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        zcsar.close()"},{"line_number":91,"context_line":"        return tempname"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _get_csar_file_path(self, file_name):"},{"line_number":94,"context_line":"        self.base_path \u003d os.path.dirname(os.path.abspath(__file__))"},{"line_number":95,"context_line":"        return os.path.join("},{"line_number":96,"context_line":"            self.base_path,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_93fc46b6","line":93,"updated":"2020-09-04 17:03:08.000000000","message":"It looks no need because it\u0027s not used from anywhere.","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"92150410062942d25fbe613c109800767dcec758","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        zcsar.close()"},{"line_number":91,"context_line":"        return tempname"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _get_csar_file_path(self, file_name):"},{"line_number":94,"context_line":"        self.base_path \u003d os.path.dirname(os.path.abspath(__file__))"},{"line_number":95,"context_line":"        return os.path.join("},{"line_number":96,"context_line":"            self.base_path,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_dbffbaff","line":93,"in_reply_to":"9f560f44_93fc46b6","updated":"2020-09-10 05:48:14.000000000","message":"This function is not used and have been deleted in the newest patch:)","commit_id":"ee3d84b893ff1007338dba2c8c3275d5c81f7850"}],"tacker/tests/unit/conductor/fakes.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"bf300d7a0424fc992a67c2c41a6be300eedd5e18","unresolved":false,"context_lines":[{"line_number":77,"context_line":"def create_fake_csar_dir(vnf_package_id, temp_dir,"},{"line_number":78,"context_line":"                         csar_without_tosca_meta\u003dFalse):"},{"line_number":79,"context_line":"    csar_dir \u003d (\u0027sample_vnfpkg_no_meta_single_vnfd\u0027 if csar_without_tosca_meta"},{"line_number":80,"context_line":"                else \u0027sample_vnfpkg_tosac_vnfd\u0027)"},{"line_number":81,"context_line":"    fake_csar \u003d os.path.join(temp_dir, vnf_package_id)"},{"line_number":82,"context_line":"    cfg.CONF.set_override(\u0027vnf_package_csar_path\u0027, temp_dir,"},{"line_number":83,"context_line":"                          group\u003d\u0027vnf_package\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a83595dc","line":80,"range":{"start_line":80,"start_character":36,"end_line":80,"end_character":41},"updated":"2020-07-08 08:38:01.000000000","message":"typo?","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"4f36680f7adf3884479244f900089ba2e08c8011","unresolved":false,"context_lines":[{"line_number":77,"context_line":"def create_fake_csar_dir(vnf_package_id, temp_dir,"},{"line_number":78,"context_line":"                         csar_without_tosca_meta\u003dFalse):"},{"line_number":79,"context_line":"    csar_dir \u003d (\u0027sample_vnfpkg_no_meta_single_vnfd\u0027 if csar_without_tosca_meta"},{"line_number":80,"context_line":"                else \u0027sample_vnfpkg_tosac_vnfd\u0027)"},{"line_number":81,"context_line":"    fake_csar \u003d os.path.join(temp_dir, vnf_package_id)"},{"line_number":82,"context_line":"    cfg.CONF.set_override(\u0027vnf_package_csar_path\u0027, temp_dir,"},{"line_number":83,"context_line":"                          group\u003d\u0027vnf_package\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_25d8e7ee","line":80,"range":{"start_line":80,"start_character":36,"end_line":80,"end_character":41},"in_reply_to":"bf51134e_a773d8e6","updated":"2020-07-20 01:56:11.000000000","message":"we have updated new code contains this logic, please kindly have a check.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"84886bd17af82042663fc66d978f9c1800f43bc8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"def create_fake_csar_dir(vnf_package_id, temp_dir,"},{"line_number":78,"context_line":"                         csar_without_tosca_meta\u003dFalse):"},{"line_number":79,"context_line":"    csar_dir \u003d (\u0027sample_vnfpkg_no_meta_single_vnfd\u0027 if csar_without_tosca_meta"},{"line_number":80,"context_line":"                else \u0027sample_vnfpkg_tosac_vnfd\u0027)"},{"line_number":81,"context_line":"    fake_csar \u003d os.path.join(temp_dir, vnf_package_id)"},{"line_number":82,"context_line":"    cfg.CONF.set_override(\u0027vnf_package_csar_path\u0027, temp_dir,"},{"line_number":83,"context_line":"                          group\u003d\u0027vnf_package\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a773d8e6","line":80,"range":{"start_line":80,"start_character":36,"end_line":80,"end_character":41},"in_reply_to":"bf51134e_a83595dc","updated":"2020-07-10 10:36:01.000000000","message":"yes, it\u0027s a typo..we will fix it in next patch.","commit_id":"fe7180cb259a2bc0a7aa4fbc527f2dbead0252f1"}]}