)]}'
{"id":"openstack%2Ftacker~740179","triplet_id":"openstack%2Ftacker~master~I7a62ecf3eeec2f363d0f099bb46d3dec7948501a","project":"openstack/tacker","branch":"master","topic":"bug/1886622","hashtags":[],"change_id":"I7a62ecf3eeec2f363d0f099bb46d3dec7948501a","subject":"Fix: Remove wrong constraint in vnf_package_vnfd","status":"MERGED","created":"2020-07-09 08:08:31.000000000","updated":"2020-09-24 01:20:21.000000000","submitted":"2020-09-24 01:18:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"740179-1600910328895-b2ad87a5","meta_rev_id":"380275267e4bb8bf6c56733a28f67244caa04a92","_number":740179,"virtual_id_number":740179,"owner":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},{"value":0,"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":0,"date":"2020-09-23 13:06:05.000000000","_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-24 01:18:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"value":0,"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"recommended":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"all":[{"value":1,"date":"2020-09-23 13:37:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},{"value":2,"date":"2020-09-23 15:47:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":1,"date":"2020-09-24 00:43:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},{"value":1,"date":"2020-09-23 14:05:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":0,"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"value":2,"date":"2020-09-24 01:08:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"all":[{"value":0,"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},{"value":0,"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":0,"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"value":1,"date":"2020-09-24 01:08:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-20 14:10:14.000000000","updated_by":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"reviewer":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"state":"REVIEWER"},{"updated":"2020-09-23 13:37:41.000000000","updated_by":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"reviewer":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"state":"REVIEWER"},{"updated":"2020-09-23 14:05:51.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"state":"REVIEWER"},{"updated":"2020-09-23 15:47:11.000000000","updated_by":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"reviewer":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"state":"REVIEWER"},{"updated":"2020-09-24 00:43:14.000000000","updated_by":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"reviewer":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"state":"REVIEWER"},{"updated":"2020-09-24 01:08:14.000000000","updated_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"},{"updated":"2020-09-24 01:18:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"daffa50cc975f817788b99137b9b9cd68dcac94b","author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"date":"2020-07-09 08:08:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d9d9c03dc4ac748cea3ddc545d91966ea8d8d742","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-09 10:07:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c71b0fe1c0294699a0cfa23cd2def857 : SUCCESS in 9m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5406d251ba8948638ff1ba45ab9d3dc8 : SUCCESS in 8m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ad2578283fe74a349a1a1ef4759410e4 : SUCCESS in 7m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2f68a4ac43fb4693bbad83a533cb87a6 : SUCCESS in 11m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/265c0c7240864468a3e9f17f3fd21d52 : SUCCESS in 9m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/09b51c41fd744575bda65ba89a6e480d : SUCCESS in 11m 15s\n- tacker-functional-devstack-multinode-python3 https://zuul.opendev.org/t/openstack/build/fb051826f4204ecc9e362a3c88e55304 : FAILURE in 1h 55m 28s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8b45d729120824c26eeea83d830d19474049c728","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2020-08-18 09:58:40.000000000","message":"Patch Set 1:\n\nAs per commit message \"`deleted` is varchar(36) now,\" \nAren\u0027t we suppose to do changes for the \u0027deleted\u0027 column while creating DB table \"vnf_package_vnfd\". \nIn file, \"9d425296f2c3_add_vnfpkgm_db.py\" at line number 87, \n\" op.create_table(\n        \u0027vnf_package_vnfd\u0027,\n\t\t. . .\n\t\t      sa.Column(\u0027deleted\u0027, Boolean, default\u003dFalse),\n        . . .\n)\"","accounts_in_message":[],"_revision_number":1},{"id":"d480c7ab3f56b25ec2fe82395775b73d88a1e963","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2020-08-18 15:53:37.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"8e677f29f672fe2d1d9340f7b782e6084c62b853","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 17:31:56.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7d08684109924e609e3615cb0048dca7 : SUCCESS in 6m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/efacf71cefb14e13a793e5d8849879ec : SUCCESS in 14m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/785ebf401ce94031a74f12168f3a99b8 : SUCCESS in 5m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/89b5dbc731cb43cfa620a378b7c06d15 : SUCCESS in 7m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/824edd624ab34ae09595cf93c6514cf1 : SUCCESS in 7m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a8f735b36da44234b10df398198cb97e : SUCCESS in 6m 32s\n- tacker-functional-devstack-multinode-python3 https://zuul.opendev.org/t/openstack/build/aa76ff9f770347c9be5ee7b37f435b9c : FAILURE in 1h 32m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7155baefce5beb90177f58964ed75dcf0f88892c","author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"date":"2020-08-24 02:53:50.000000000","message":"Patch Set 1:\n\nSorry but what is the meaning of \"Aren\u0027t we suppose to do changes\"?\nIn my understanding, the purpose of existing \"975e28392888_add_unique_key_vnf_package_vnfd.py\" seems *changing* data type of \u0027deleted\u0027 in \"vnf_package_vnfd\". My change just added missing operation.\n\n[9d425296f2c3_add_vnfpkgm_db.py]\ncreate \"vnf_package_vnfd\" with column \u0027deleted\u0027 whose type is Boolean.\n(\u0027CONSTRAINT `CONSTRAINT_1` CHECK (`deleted` in (0,1))\u0027 is added in this.)\n\n[975e28392888_add_unique_key_vnf_package_vnfd.py]\nchange type of \u0027deleted\u0027 to String(36) and update value.\n\nL59:\n    op.alter_column(\u0027vnf_package_vnfd\u0027,\n                    \u0027deleted\u0027,\n                    type_\u003dsa.String(36), default\u003d\"0\")\n\nL47:\n                    if dup_obj.deleted \u003d\u003d \u00271\u0027:\n                        session.execute(t.update().where(\n                            t.c.id \u003d\u003d dup_obj.id).values(deleted\u003ddup_obj.id))\n\n[Issue]\nAfter above updating, the type of \u0027deleted\u0027 is String(36) and there is a constraint \u0027`deleted` in (0,1)\u0027. It\u0027s strange that these are in sql definition at the same time.","accounts_in_message":[],"_revision_number":1},{"id":"7598f4e18397b251aaa596cf5b2193ac935dd4f8","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2020-08-24 11:32:04.000000000","message":"Patch Set 1: Code-Review+1\n\nSorry for the confusion. \nI misunderstood the commit message and raised queries regarding changes required in the data type of \"deleted\" column. \nThanks for the detail explanation.","accounts_in_message":[],"_revision_number":1},{"id":"980bc8124ac7168bb08721baa49f20d9083fd2df","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2020-09-18 09:58:20.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"7514ed11c8d6e1b15d11861928ad3a4eae00d21e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-18 12:02:09.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/74b536734bb345ca99ab563332748ea4 : SUCCESS in 6m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/75ce3934d27040708ceb9954630a1bb9 : SUCCESS in 8m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7037844d8185422a8cd9fd494ada1559 : SUCCESS in 4m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/52550c9d02b748a19adc80b8240d1817 : SUCCESS in 8m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/41383a073b9b4735ace68a7e0675fb7c : SUCCESS in 8m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/13b941e507914c1a8c12108232d164e6 : SUCCESS in 7m 20s\n- tacker-functional-devstack-multinode-python3 https://zuul.opendev.org/t/openstack/build/918ad706c36d48809515ac283573a6b1 : FAILURE in 1h 28m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"27a506ba9e688988d2ed5e463a528b249e43a1ee","author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"date":"2020-09-21 15:08:54.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nI suggest certain improvement.\nKindly update, may skip some of them if not required.","accounts_in_message":[],"_revision_number":1},{"id":"4dc244ab9124c85c528349d2a418e0441d4186b3","author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"date":"2020-09-22 07:48:55.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nThank you for your good suggestions, we need some discussion.","accounts_in_message":[],"_revision_number":1},{"id":"7975f206981f5d4dc634a12141a7a66d63a1343b","author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"date":"2020-09-22 08:58:18.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)\n\nLGTM.\nThank you for sharing details.","accounts_in_message":[],"_revision_number":1},{"id":"da57ae04aeef1bb0b4d50249d3a3be3394853604","author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"date":"2020-09-22 09:36:18.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)\n\nJust want to make sure that this table has only 1 constraint.\nPlease check my comment.","accounts_in_message":[],"_revision_number":1},{"id":"25ce87ebad5cb34603fa5180485bc37e976b66a9","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2020-09-22 17:47:49.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8e04080ba5f5f548ce15c846aaf0b563b05c091f","author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"date":"2020-09-23 12:13:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d1c6f7a8a6a035e2b5da89a80fa4068cc49cfc29","author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"date":"2020-09-23 13:06:05.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f92bd318105b976cedc1e4d68c99690fbf7466fd","author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"date":"2020-09-23 13:37:41.000000000","message":"Patch Set 2: Code-Review+1\n\nThank you for considering my input.\nLooks good to me.","accounts_in_message":[],"_revision_number":2},{"id":"7687f7c3063f534733c539e72ef1082592136248","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-23 14:04:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8afe1ac7467749308a102692351014c6 : SUCCESS in 8m 55s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cb00fb7a242843a59a9490c33cb08e75 : SUCCESS in 10m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/79c5a8dab3c04cb794f6832ade05590c : SUCCESS in 5m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c306beeb54d041218e79d7bef02b15d6 : SUCCESS in 9m 00s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a4def10dca474bb0972767c278169831 : SUCCESS in 9m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/68b11f29b32740ad8256a82ed85de3d0 : SUCCESS in 5m 29s\n- tacker-functional-devstack-multinode-python3 https://zuul.opendev.org/t/openstack/build/fc79afff25bd42bf8e353a4e0b6a47a5 : FAILURE in 1h 40m 11s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ea3946f29083a1153f5934129918a3d1226251a7","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2020-09-23 14:05:51.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"7cc5227d7b6a5829eb6c159494f786addb44dbb2","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2020-09-23 15:47:11.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"64b9889fcf4e8247aa109933fe2647cf89fdffa0","author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"date":"2020-09-24 00:43:14.000000000","message":"Patch Set 2: Code-Review+1\n\nIn the first place \u0027deleted\u0027 is 0 or positive interger, it was wrong to create columun \u0027deleted\u0027 as Boolean at creating table.　(just my impression)","accounts_in_message":[],"_revision_number":2},{"id":"3f7139e14fba8d277eda90c42201bcddb5eb3b65","author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"date":"2020-09-24 01:08:14.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"b0cb900dc5e98f9f9e37d88e4c1c8db2d7e47c6a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 01:08:25.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"f93868fdfd5762b6e83d51a31ccb31837c4c58ff","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 01:18:48.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5a46aa0506eb48ab82800c0de7b8c685 : SUCCESS in 8m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a9d1990efe89474d858ca689a2550e82 : SUCCESS in 4m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0eb46aa29b804b4aaedcf52125af6a5a : SUCCESS in 8m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4608ef5255764962b361099a80c4c3df : SUCCESS in 8m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f21dc723ac994030b0db93115189662b : SUCCESS in 6m 16s","accounts_in_message":[],"_revision_number":2},{"id":"c8166220ff430d5b8c76bd30e63729d36d4a5643","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 01:18:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"d82240e69d14ecc62099909424cf71fc277da236","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 01:20:21.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/346f9a6b370c41ab8b12045bd06a1bae : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d744c3936ef6afa4b985e2241be3555b63fb699f","revisions":{"f9de2f594fc562aab70d41d24268fcd04b79c72a":{"kind":"REWORK","_number":1,"created":"2020-07-09 08:08:31.000000000","uploader":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"ref":"refs/changes/79/740179/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/79/740179/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/79/740179/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/79/740179/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/79/740179/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/79/740179/1"}}},"commit":{"parents":[{"commit":"f1a0c7ebc0435176bdb7d2c5fa0e180b13d69de1","subject":"Merge \"Stop to use the __future__ module.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/f1a0c7ebc0435176bdb7d2c5fa0e180b13d69de1"}]}],"author":{"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","date":"2020-07-09 05:59:17.000000000","tz":540},"committer":{"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","date":"2020-07-09 08:07:21.000000000","tz":540},"subject":"Fix: Remove wrong constraint in vnf_package_vnfd","message":"Fix: Remove wrong constraint in vnf_package_vnfd\n\nCurrently, vnf_package_vnfd table has a following constraint\nin database created by tacker db migration.\nThis is incorrect, so this patch remove the constraint.\n\nCONSTRAINT `CONSTRAINT_1` CHECK (`deleted` in (0,1))\n\nThis is created because `deleted` was boolean before.\n`deleted` is varchar(36) now, so db migration change its type\nby alter_column method. But this does not remove check constraint.\nThis patch add drop_constraint to remove the constraint.\n\nChange-Id: I7a62ecf3eeec2f363d0f099bb46d3dec7948501a\nCloses-Bug: #1886622\nSigned-off-by: Toshiaki Takahashi \u003cts-takahashi@nec.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/f9de2f594fc562aab70d41d24268fcd04b79c72a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/f9de2f594fc562aab70d41d24268fcd04b79c72a"}]},"branch":"refs/heads/master"},"d744c3936ef6afa4b985e2241be3555b63fb699f":{"kind":"REWORK","_number":2,"created":"2020-09-23 12:13:26.000000000","uploader":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"ref":"refs/changes/79/740179/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/79/740179/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/79/740179/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/79/740179/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/79/740179/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/79/740179/2"}}},"commit":{"parents":[{"commit":"f1a0c7ebc0435176bdb7d2c5fa0e180b13d69de1","subject":"Merge \"Stop to use the __future__ module.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/f1a0c7ebc0435176bdb7d2c5fa0e180b13d69de1"}]}],"author":{"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","date":"2020-07-09 05:59:17.000000000","tz":540},"committer":{"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","date":"2020-09-23 12:12:23.000000000","tz":540},"subject":"Fix: Remove wrong constraint in vnf_package_vnfd","message":"Fix: Remove wrong constraint in vnf_package_vnfd\n\nCurrently, vnf_package_vnfd table has a following constraint\nin database created by tacker db migration.\nThis is incorrect, so this patch remove the constraint.\n\nCONSTRAINT `CONSTRAINT_1` CHECK (`deleted` in (0,1))\n\nThis is created because `deleted` was boolean before.\n`deleted` is varchar(36) now, so db migration change its type\nby alter_column method. But this does not remove check constraint.\nThis patch add drop_constraint to remove the constraint.\n\nChange-Id: I7a62ecf3eeec2f363d0f099bb46d3dec7948501a\nCloses-Bug: #1886622\nSigned-off-by: Toshiaki Takahashi \u003cts-takahashi@nec.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/d744c3936ef6afa4b985e2241be3555b63fb699f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/d744c3936ef6afa4b985e2241be3555b63fb699f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
