)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"0ddb16cb0d75b8c20f75fdf080f297bf9c74fda6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-08 07:30:00 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support Subscription for LCM notifications for VNF based on ETSI NFV-SOL specification"},{"line_number":8,"context_line":"    Support for Flow of managing subscriptions as defined in ETSI SOL003"},{"line_number":9,"context_line":"        * Support POST/DELETE/GET(List)/GET(Individual) LccnSubscription"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_b1c8e254","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":86},"updated":"2020-08-10 14:01:45.000000000","message":"Too long. Please shorten the commit title.","commit_id":"779b49c749328d13a4886a5a6af5fe86eb3ef602"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4a45bc6bd1db67bb4f31091ce04f0f025eb1ff4a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-08 07:30:00 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support Subscription for LCM notifications for VNF based on ETSI NFV-SOL specification"},{"line_number":8,"context_line":"    Support for Flow of managing subscriptions as defined in ETSI SOL003"},{"line_number":9,"context_line":"        * Support POST/DELETE/GET(List)/GET(Individual) LccnSubscription"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_b670c1dc","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":86},"in_reply_to":"9f560f44_2bb0ba8b","updated":"2020-08-28 12:54:29.000000000","message":"Commit title is shortened.","commit_id":"779b49c749328d13a4886a5a6af5fe86eb3ef602"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-08 07:30:00 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support Subscription for LCM notifications for VNF based on ETSI NFV-SOL specification"},{"line_number":8,"context_line":"    Support for Flow of managing subscriptions as defined in ETSI SOL003"},{"line_number":9,"context_line":"        * Support POST/DELETE/GET(List)/GET(Individual) LccnSubscription"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_2bb0ba8b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":86},"in_reply_to":"9f560f44_b1c8e254","updated":"2020-08-28 12:52:41.000000000","message":"Done","commit_id":"779b49c749328d13a4886a5a6af5fe86eb3ef602"},{"author":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"change_message_id":"0ddb16cb0d75b8c20f75fdf080f297bf9c74fda6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-08-08 07:30:00 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support Subscription for LCM notifications for VNF based on ETSI NFV-SOL specification"},{"line_number":8,"context_line":"    Support for Flow of managing subscriptions as defined in ETSI SOL003"},{"line_number":9,"context_line":"        * Support POST/DELETE/GET(List)/GET(Individual) LccnSubscription"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://specs.openstack.org/openstack/tacker-specs/specs/victoria/support-notification-api-based-on-etsi-nfv-sol.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_11c42e3f","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":72},"updated":"2020-08-10 14:01:45.000000000","message":"Please add a blank line.","commit_id":"779b49c749328d13a4886a5a6af5fe86eb3ef602"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4a45bc6bd1db67bb4f31091ce04f0f025eb1ff4a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-08-08 07:30:00 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support Subscription for LCM notifications for VNF based on ETSI NFV-SOL specification"},{"line_number":8,"context_line":"    Support for Flow of managing subscriptions as defined in ETSI SOL003"},{"line_number":9,"context_line":"        * Support POST/DELETE/GET(List)/GET(Individual) LccnSubscription"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://specs.openstack.org/openstack/tacker-specs/specs/victoria/support-notification-api-based-on-etsi-nfv-sol.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_5649658c","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":72},"in_reply_to":"9f560f44_0badf630","updated":"2020-08-28 12:54:29.000000000","message":"Added blank line.","commit_id":"779b49c749328d13a4886a5a6af5fe86eb3ef602"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-08-08 07:30:00 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support Subscription for LCM notifications for VNF based on ETSI NFV-SOL specification"},{"line_number":8,"context_line":"    Support for Flow of managing subscriptions as defined in ETSI SOL003"},{"line_number":9,"context_line":"        * Support POST/DELETE/GET(List)/GET(Individual) LccnSubscription"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://specs.openstack.org/openstack/tacker-specs/specs/victoria/support-notification-api-based-on-etsi-nfv-sol.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_0badf630","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":72},"in_reply_to":"9f560f44_11c42e3f","updated":"2020-08-28 12:52:41.000000000","message":"Done","commit_id":"779b49c749328d13a4886a5a6af5fe86eb3ef602"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9f560f44_c1b34399","line":18,"updated":"2020-09-09 16:35:47.000000000","message":"Please add your bp with `Implements` tag.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9f560f44_c9eef889","line":18,"in_reply_to":"9f560f44_c1b34399","updated":"2020-09-22 02:30:36.000000000","message":"added implements tag","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9f560f44_a9f3c472","line":18,"in_reply_to":"9f560f44_c1b34399","updated":"2020-09-22 02:30:36.000000000","message":"added implements tag.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"}],"api-ref/source/v1/vnflcm.inc":[{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"536d9a5d36383e2f88c575973146a8c95f85b80f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  - vnfProductName: vnf_instance_vnf_product_name"},{"line_number":64,"context_line":"  - vnfSoftwareVersion: vnf_instance_vnf_software_version"},{"line_number":65,"context_line":"  - vnfdVersion: vnf_instance_vnfd_version"},{"line_number":66,"context_line":"  - vnfPkgId: vnf_instance_vnf_pkg_id"},{"line_number":67,"context_line":"  - instantiationState: vnf_instance_instantiation_state"},{"line_number":68,"context_line":"  - _links: vnf_instance_links"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":18,"id":"9f560f44_2f603835","line":66,"range":{"start_line":66,"start_character":2,"end_line":66,"end_character":37},"updated":"2020-09-23 11:28:47.000000000","message":"This part is not related to this patch. you should remove it. Moreover, lots of modified part in this file are not related to this patch. Please remove all of them.","commit_id":"258456dad720a82b60ee57760734547ac0589990"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ea9f10e639b9d86c261958efd41afe036b044a10","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  - vnfProductName: vnf_instance_vnf_product_name"},{"line_number":64,"context_line":"  - vnfSoftwareVersion: vnf_instance_vnf_software_version"},{"line_number":65,"context_line":"  - vnfdVersion: vnf_instance_vnfd_version"},{"line_number":66,"context_line":"  - vnfPkgId: vnf_instance_vnf_pkg_id"},{"line_number":67,"context_line":"  - instantiationState: vnf_instance_instantiation_state"},{"line_number":68,"context_line":"  - _links: vnf_instance_links"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":18,"id":"9f560f44_44244ac6","line":66,"range":{"start_line":66,"start_character":2,"end_line":66,"end_character":37},"in_reply_to":"9f560f44_2f603835","updated":"2020-09-24 18:33:19.000000000","message":"it is modified.","commit_id":"258456dad720a82b60ee57760734547ac0589990"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"95961d190b89ce736f8ae4a5d0a10f2343c33441","unresolved":false,"context_lines":[{"line_number":566,"context_line":"Response Example"},{"line_number":567,"context_line":"----------------"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":".. literalinclude:: samples/vnflcm/list-vnf-instance-response.json"},{"line_number":570,"context_line":"   :language: javascript"},{"line_number":571,"context_line":" "},{"line_number":572,"context_line":" Create a new subscription"}],"source_content_type":"text/x-c++src","patch_set":19,"id":"9f560f44_434f3391","line":569,"updated":"2020-09-24 03:35:01.000000000","message":"api-ref: Error in \"literalinclude\" directive:","commit_id":"fb86d42c401c06843bf26f0a412b2fe44df1a1b9"}],"tacker/api/schemas/vnf_lcm.py":[{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"56800e45506a0705323892b9c2b0c35da9a38b76","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        \u0027callbackUri\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027maxLength\u0027: 255},"},{"line_number":236,"context_line":"        \u0027authentication\u0027: parameter_types.keyvalue_pairs,"},{"line_number":237,"context_line":"    },"},{"line_number":238,"context_line":"    \u0027required\u0027: [\u0027filter\u0027],"},{"line_number":239,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":240,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":29,"id":"9f560f44_90f29304","line":238,"range":{"start_line":238,"start_character":18,"end_line":238,"end_character":24},"updated":"2020-10-05 05:01:59.000000000","message":"I think `callbackUri` should be required because cardinality of the attribute is 1. Moreover, `filter` should not be required.","commit_id":"b096a2e37df89b78997ebb90846716f1c60a01ba"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"aedaa86d4ca04f80e9faadfcf9191784ff1a8894","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        \u0027callbackUri\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027maxLength\u0027: 255},"},{"line_number":236,"context_line":"        \u0027authentication\u0027: parameter_types.keyvalue_pairs,"},{"line_number":237,"context_line":"    },"},{"line_number":238,"context_line":"    \u0027required\u0027: [\u0027filter\u0027],"},{"line_number":239,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":240,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":29,"id":"9f560f44_d0f08b95","line":238,"range":{"start_line":238,"start_character":18,"end_line":238,"end_character":24},"in_reply_to":"9f560f44_90f29304","updated":"2020-10-05 06:38:42.000000000","message":"Fixed as suggested.","commit_id":"b096a2e37df89b78997ebb90846716f1c60a01ba"}],"tacker/api/views/vnf_lcm.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d4c1674ab29bf4a940946ce4280cc6a405b19e19","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                \u0027callbackUri\u0027: vnf_lcm_subscription.callback_uri,"},{"line_number":119,"context_line":"            }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def checkKeyEq(self, checkData, keyStr, valueStr):"},{"line_number":122,"context_line":"        LOG.debug(\"checkData %s \\n type %s\" % (checkData, type(checkData)))"},{"line_number":123,"context_line":"        if not isinstance(checkData, str):"},{"line_number":124,"context_line":"            for key, value in checkData.items():"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_ff8777b5","line":121,"updated":"2020-08-17 06:46:35.000000000","message":"Please fix from camelCase to snake_case.\nThere are many others, so please correct it as well.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                \u0027callbackUri\u0027: vnf_lcm_subscription.callback_uri,"},{"line_number":119,"context_line":"            }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def checkKeyEq(self, checkData, keyStr, valueStr):"},{"line_number":122,"context_line":"        LOG.debug(\"checkData %s \\n type %s\" % (checkData, type(checkData)))"},{"line_number":123,"context_line":"        if not isinstance(checkData, str):"},{"line_number":124,"context_line":"            for key, value in checkData.items():"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_8b1f5d5a","line":121,"in_reply_to":"9f560f44_ff8777b5","updated":"2020-08-28 12:52:41.000000000","message":"Changed to snake case and implemented in other occurrences as well.(checkKeyEq、checkKeyCon、checkKeyNeq、lastFlg、addFlg). \nPlease expect it in patch3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7d27c6dd8b7d301da1b43fe651b470ddca3f0efb","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                            return True"},{"line_number":184,"context_line":"        return False"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def _subscription_filter("},{"line_number":187,"context_line":"            self,"},{"line_number":188,"context_line":"            subscription_data,"},{"line_number":189,"context_line":"            filter,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f04822cd","line":186,"updated":"2020-08-19 05:22:28.000000000","message":"I couldn\u0027t understand the logic inside this function.\nCould you add a comment to help me understand the intent of the process?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"757760cc8d7cf700524dbcc50edb012a9c5e26fc","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                            return True"},{"line_number":184,"context_line":"        return False"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def _subscription_filter("},{"line_number":187,"context_line":"            self,"},{"line_number":188,"context_line":"            subscription_data,"},{"line_number":189,"context_line":"            filter,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_73b19b44","line":186,"in_reply_to":"9f560f44_f04822cd","updated":"2020-09-07 00:42:18.000000000","message":"SOL003 5.5.2.16 Type: LccnSubscription filter setting and SOL013 5.4 Handling of large query results processing are implemented.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48e3264c4983f72e0c71ec514e52c6582a0d7125","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            dic_line[\u0027href\u0027] \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":203,"context_line":"                \"/vnflcm/v1/subscriptions/\" + line.id.decode()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            if filter:"},{"line_number":206,"context_line":"                LOG.debug(\"filter: %s\" % filter)"},{"line_number":207,"context_line":"                addFlg \u003d True"},{"line_number":208,"context_line":"                for fil in filter.split(\u0027;\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_620750cb","line":205,"updated":"2020-08-17 09:59:11.000000000","message":"Can you fix the code to use a below IF to validate filters?\n\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/api/vnfpkgm/v1/controller.py#L140\n   filters \u003d self._view_builder.validate_filter(filters)","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"757760cc8d7cf700524dbcc50edb012a9c5e26fc","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            dic_line[\u0027href\u0027] \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":203,"context_line":"                \"/vnflcm/v1/subscriptions/\" + line.id.decode()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            if filter:"},{"line_number":206,"context_line":"                LOG.debug(\"filter: %s\" % filter)"},{"line_number":207,"context_line":"                addFlg \u003d True"},{"line_number":208,"context_line":"                for fil in filter.split(\u0027;\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_d39a27c3","line":205,"in_reply_to":"9f560f44_620750cb","updated":"2020-09-07 00:42:18.000000000","message":"This process is a filter for DB search, not a filter for attribute. Therefore, the current implementation is necessary.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7d27c6dd8b7d301da1b43fe651b470ddca3f0efb","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                    fil_val \u003d fil.split(\u0027,\u0027)[2]"},{"line_number":213,"context_line":"                    return_str \u003d \u0027\u0027"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"                    # check_eq"},{"line_number":216,"context_line":"                    if fil_method \u003d\u003d \u0027eq\u0027:"},{"line_number":217,"context_line":"                        if not self.checkKeyEq(dic_line, fil_name, fil_val):"},{"line_number":218,"context_line":"                            addFlg \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_70dd3241","line":215,"updated":"2020-08-19 05:22:28.000000000","message":"Are other \u0027opOne\u0027 and \u0027opMulti\u0027 defined in SOL013 5.2.2 not supported?\n(e.g.) gt,lt,in,nin","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"757760cc8d7cf700524dbcc50edb012a9c5e26fc","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                    fil_val \u003d fil.split(\u0027,\u0027)[2]"},{"line_number":213,"context_line":"                    return_str \u003d \u0027\u0027"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"                    # check_eq"},{"line_number":216,"context_line":"                    if fil_method \u003d\u003d \u0027eq\u0027:"},{"line_number":217,"context_line":"                        if not self.checkKeyEq(dic_line, fil_name, fil_val):"},{"line_number":218,"context_line":"                            addFlg \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_d3834755","line":215,"in_reply_to":"9f560f44_70dd3241","updated":"2020-09-07 00:42:18.000000000","message":"The spec is an undefined implementation, so processing will be deleted","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"from oslo_log import log as logging"},{"line_number":18,"context_line":"import re"},{"line_number":19,"context_line":"from tacker.common import utils"},{"line_number":20,"context_line":"import tacker.conf"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_987bf6bc","line":17,"updated":"2020-09-01 17:51:01.000000000","message":"It should be placed after `import re` for considering coding rule.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"from oslo_log import log as logging"},{"line_number":18,"context_line":"import re"},{"line_number":19,"context_line":"from tacker.common import utils"},{"line_number":20,"context_line":"import tacker.conf"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9e96b948","line":17,"in_reply_to":"9f560f44_987bf6bc","updated":"2020-09-11 12:15:38.000000000","message":"This definition was removed since the filtering process was removed.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"from oslo_log import log as logging"},{"line_number":18,"context_line":"import re"},{"line_number":19,"context_line":"from tacker.common import utils"},{"line_number":20,"context_line":"import tacker.conf"},{"line_number":21,"context_line":"from tacker.objects import fields"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_187086dc","line":19,"updated":"2020-09-01 17:51:01.000000000","message":"You need to separate standard libs and project local ones with a blank line.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"from oslo_log import log as logging"},{"line_number":18,"context_line":"import re"},{"line_number":19,"context_line":"from tacker.common import utils"},{"line_number":20,"context_line":"import tacker.conf"},{"line_number":21,"context_line":"from tacker.objects import fields"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_29577903","line":19,"in_reply_to":"9f560f44_187086dc","updated":"2020-09-11 12:15:38.000000000","message":"Done.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if not filter:"},{"line_number":101,"context_line":"            if \u0027filter\u0027 in vnf_lcm_subscription:"},{"line_number":102,"context_line":"                LOG.debug(\"filter cnt %s\" % len(vnf_lcm_subscription.filter))"},{"line_number":103,"context_line":"                filter_dict \u003d json.loads(vnf_lcm_subscription.filter)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"                return {"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ce8db5d4","line":102,"updated":"2020-09-01 17:51:01.000000000","message":"Please say more exactly then `cnt` for better understanding.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if not filter:"},{"line_number":101,"context_line":"            if \u0027filter\u0027 in vnf_lcm_subscription:"},{"line_number":102,"context_line":"                LOG.debug(\"filter cnt %s\" % len(vnf_lcm_subscription.filter))"},{"line_number":103,"context_line":"                filter_dict \u003d json.loads(vnf_lcm_subscription.filter)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"                return {"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_5e9ee153","line":102,"in_reply_to":"9f560f44_ce8db5d4","updated":"2020-09-11 12:15:38.000000000","message":"This description was removed since the filtering process was removed.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                \u0027callbackUri\u0027: vnf_lcm_subscription.callback_uri,"},{"line_number":119,"context_line":"            }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def check_key_eq(self, checkData, keyStr, valueStr):"},{"line_number":122,"context_line":"        LOG.debug(\"checkData %s \\n type %s\" % (checkData, type(checkData)))"},{"line_number":123,"context_line":"        if not isinstance(checkData, str):"},{"line_number":124,"context_line":"            for key, value in checkData.items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d32a717c","line":121,"updated":"2020-09-01 17:51:01.000000000","message":"Please use snake case.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                \u0027callbackUri\u0027: vnf_lcm_subscription.callback_uri,"},{"line_number":119,"context_line":"            }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def check_key_eq(self, checkData, keyStr, valueStr):"},{"line_number":122,"context_line":"        LOG.debug(\"checkData %s \\n type %s\" % (checkData, type(checkData)))"},{"line_number":123,"context_line":"        if not isinstance(checkData, str):"},{"line_number":124,"context_line":"            for key, value in checkData.items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_bea9fd7c","line":121,"in_reply_to":"9f560f44_d32a717c","updated":"2020-09-11 12:15:38.000000000","message":"This definition was removed since the filtering process was removed.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                            return True"},{"line_number":141,"context_line":"        return False"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def check_key_neq(self, checkData, keyStr, valueStr):"},{"line_number":144,"context_line":"        if not isinstance(checkData, str):"},{"line_number":145,"context_line":"            for key, value in checkData.items():"},{"line_number":146,"context_line":"                LOG.debug(\"key %s, value %s\" % (key, value))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7339e5d6","line":143,"updated":"2020-09-01 17:51:01.000000000","message":"Please use snake case.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                            return True"},{"line_number":141,"context_line":"        return False"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def check_key_neq(self, checkData, keyStr, valueStr):"},{"line_number":144,"context_line":"        if not isinstance(checkData, str):"},{"line_number":145,"context_line":"            for key, value in checkData.items():"},{"line_number":146,"context_line":"                LOG.debug(\"key %s, value %s\" % (key, value))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9ea4f9a4","line":143,"in_reply_to":"9f560f44_7339e5d6","updated":"2020-09-11 12:15:38.000000000","message":"This definition was removed since the filtering process was removed.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                            return False"},{"line_number":162,"context_line":"        return True"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def check_key_con(self, checkData, keyStr, valueStr):"},{"line_number":165,"context_line":"        if not isinstance(checkData, str):"},{"line_number":166,"context_line":"            for key, value in checkData.items():"},{"line_number":167,"context_line":"                LOG.debug(\"key %s, value %s\" % (key, value))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b3337df6","line":164,"updated":"2020-09-01 17:51:01.000000000","message":"Please use snake case.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                            return False"},{"line_number":162,"context_line":"        return True"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def check_key_con(self, checkData, keyStr, valueStr):"},{"line_number":165,"context_line":"        if not isinstance(checkData, str):"},{"line_number":166,"context_line":"            for key, value in checkData.items():"},{"line_number":167,"context_line":"                LOG.debug(\"key %s, value %s\" % (key, value))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_feb895c8","line":164,"in_reply_to":"9f560f44_b3337df6","updated":"2020-09-11 12:15:38.000000000","message":"This definition was removed since the filtering process was removed.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            paging):"},{"line_number":192,"context_line":"        # filter processing"},{"line_number":193,"context_line":"        lcmsubscription \u003d []"},{"line_number":194,"context_line":"        LOG.debug(\"subscription_data %s\" % subscription_data)"},{"line_number":195,"context_line":"        last_flg \u003d False"},{"line_number":196,"context_line":"        startNum \u003d CONF.vnf_lcm.subscription_num * (paging - 1)"},{"line_number":197,"context_line":"        LOG.debug(\"startNum %d\" % startNum)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b8fb5a45","line":194,"updated":"2020-09-01 17:51:01.000000000","message":"User might be confused such a poor explanation. Please make it more meaningful.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            paging):"},{"line_number":192,"context_line":"        # filter processing"},{"line_number":193,"context_line":"        lcmsubscription \u003d []"},{"line_number":194,"context_line":"        LOG.debug(\"subscription_data %s\" % subscription_data)"},{"line_number":195,"context_line":"        last_flg \u003d False"},{"line_number":196,"context_line":"        startNum \u003d CONF.vnf_lcm.subscription_num * (paging - 1)"},{"line_number":197,"context_line":"        LOG.debug(\"startNum %d\" % startNum)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_297019a4","line":194,"in_reply_to":"9f560f44_b8fb5a45","updated":"2020-09-11 12:15:38.000000000","message":"The line was removed since it was not so necessary debug message.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        # filter processing"},{"line_number":193,"context_line":"        lcmsubscription \u003d []"},{"line_number":194,"context_line":"        LOG.debug(\"subscription_data %s\" % subscription_data)"},{"line_number":195,"context_line":"        last_flg \u003d False"},{"line_number":196,"context_line":"        startNum \u003d CONF.vnf_lcm.subscription_num * (paging - 1)"},{"line_number":197,"context_line":"        LOG.debug(\"startNum %d\" % startNum)"},{"line_number":198,"context_line":"        wk_counter \u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_93fd99b3","line":195,"updated":"2020-09-01 17:51:01.000000000","message":"Could you add a comment for describing the condition for turning True because it is hard to understand it from the name.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        # filter processing"},{"line_number":193,"context_line":"        lcmsubscription \u003d []"},{"line_number":194,"context_line":"        LOG.debug(\"subscription_data %s\" % subscription_data)"},{"line_number":195,"context_line":"        last_flg \u003d False"},{"line_number":196,"context_line":"        startNum \u003d CONF.vnf_lcm.subscription_num * (paging - 1)"},{"line_number":197,"context_line":"        LOG.debug(\"startNum %d\" % startNum)"},{"line_number":198,"context_line":"        wk_counter \u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c9b51d34","line":195,"in_reply_to":"9f560f44_93fd99b3","updated":"2020-09-11 12:15:38.000000000","message":"Done.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        lcmsubscription \u003d []"},{"line_number":194,"context_line":"        LOG.debug(\"subscription_data %s\" % subscription_data)"},{"line_number":195,"context_line":"        last_flg \u003d False"},{"line_number":196,"context_line":"        startNum \u003d CONF.vnf_lcm.subscription_num * (paging - 1)"},{"line_number":197,"context_line":"        LOG.debug(\"startNum %d\" % startNum)"},{"line_number":198,"context_line":"        wk_counter \u003d 0"},{"line_number":199,"context_line":"        for cnt, line in enumerate(subscription_data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_786a621b","line":196,"range":{"start_line":196,"start_character":8,"end_line":196,"end_character":16},"updated":"2020-09-01 17:51:01.000000000","message":"Please use snake case.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        lcmsubscription \u003d []"},{"line_number":194,"context_line":"        LOG.debug(\"subscription_data %s\" % subscription_data)"},{"line_number":195,"context_line":"        last_flg \u003d False"},{"line_number":196,"context_line":"        startNum \u003d CONF.vnf_lcm.subscription_num * (paging - 1)"},{"line_number":197,"context_line":"        LOG.debug(\"startNum %d\" % startNum)"},{"line_number":198,"context_line":"        wk_counter \u003d 0"},{"line_number":199,"context_line":"        for cnt, line in enumerate(subscription_data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c98ebd77","line":196,"range":{"start_line":196,"start_character":8,"end_line":196,"end_character":16},"in_reply_to":"9f560f44_786a621b","updated":"2020-09-11 12:15:38.000000000","message":"Done.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        LOG.debug(\"subscription_data %s\" % subscription_data)"},{"line_number":195,"context_line":"        last_flg \u003d False"},{"line_number":196,"context_line":"        startNum \u003d CONF.vnf_lcm.subscription_num * (paging - 1)"},{"line_number":197,"context_line":"        LOG.debug(\"startNum %d\" % startNum)"},{"line_number":198,"context_line":"        wk_counter \u003d 0"},{"line_number":199,"context_line":"        for cnt, line in enumerate(subscription_data):"},{"line_number":200,"context_line":"            LOG.debug(\"cnt %d,line %s\" % (cnt, line))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_58831eaa","line":197,"updated":"2020-09-01 17:51:01.000000000","message":"Please revise this message.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        LOG.debug(\"subscription_data %s\" % subscription_data)"},{"line_number":195,"context_line":"        last_flg \u003d False"},{"line_number":196,"context_line":"        startNum \u003d CONF.vnf_lcm.subscription_num * (paging - 1)"},{"line_number":197,"context_line":"        LOG.debug(\"startNum %d\" % startNum)"},{"line_number":198,"context_line":"        wk_counter \u003d 0"},{"line_number":199,"context_line":"        for cnt, line in enumerate(subscription_data):"},{"line_number":200,"context_line":"            LOG.debug(\"cnt %d,line %s\" % (cnt, line))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a9dee966","line":197,"in_reply_to":"9f560f44_58831eaa","updated":"2020-09-11 12:15:38.000000000","message":"The line was removed since it was not so necessary debug message.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            if filter:"},{"line_number":206,"context_line":"                LOG.debug(\"filter: %s\" % filter)"},{"line_number":207,"context_line":"                add_flg \u003d True"},{"line_number":208,"context_line":"                for fil in filter.split(\u0027;\u0027):"},{"line_number":209,"context_line":"                    fil \u003d re.sub(r\u0027\\(|\\)\u0027, \u0027\u0027, fil)"},{"line_number":210,"context_line":"                    fil_method \u003d str(fil.split(\u0027,\u0027)[0])"},{"line_number":211,"context_line":"                    fil_name \u003d fil.split(\u0027,\u0027)[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_33f12d03","line":208,"updated":"2020-09-01 17:51:01.000000000","message":"Could you add a short explanation what is the purpose of doing this block?","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            if filter:"},{"line_number":206,"context_line":"                LOG.debug(\"filter: %s\" % filter)"},{"line_number":207,"context_line":"                add_flg \u003d True"},{"line_number":208,"context_line":"                for fil in filter.split(\u0027;\u0027):"},{"line_number":209,"context_line":"                    fil \u003d re.sub(r\u0027\\(|\\)\u0027, \u0027\u0027, fil)"},{"line_number":210,"context_line":"                    fil_method \u003d str(fil.split(\u0027,\u0027)[0])"},{"line_number":211,"context_line":"                    fil_name \u003d fil.split(\u0027,\u0027)[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_09d39561","line":208,"in_reply_to":"9f560f44_33f12d03","updated":"2020-09-11 12:15:38.000000000","message":"This description was removed since the filtering process was removed.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                    fil_val \u003d fil.split(\u0027,\u0027)[2]"},{"line_number":213,"context_line":"                    return_str \u003d \u0027\u0027"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"                    # check_eq"},{"line_number":216,"context_line":"                    if fil_method \u003d\u003d \u0027eq\u0027:"},{"line_number":217,"context_line":"                        if not self.check_key_eq(dic_line, fil_name, fil_val):"},{"line_number":218,"context_line":"                            add_flg \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d39d51bc","line":215,"updated":"2020-09-01 17:51:01.000000000","message":"This comment has no meaning.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                    fil_val \u003d fil.split(\u0027,\u0027)[2]"},{"line_number":213,"context_line":"                    return_str \u003d \u0027\u0027"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"                    # check_eq"},{"line_number":216,"context_line":"                    if fil_method \u003d\u003d \u0027eq\u0027:"},{"line_number":217,"context_line":"                        if not self.check_key_eq(dic_line, fil_name, fil_val):"},{"line_number":218,"context_line":"                            add_flg \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e9d58144","line":215,"in_reply_to":"9f560f44_d39d51bc","updated":"2020-09-11 12:15:38.000000000","message":"This description was removed since the filtering process was removed.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                        if not self.check_key_eq(dic_line, fil_name, fil_val):"},{"line_number":218,"context_line":"                            add_flg \u003d False"},{"line_number":219,"context_line":"                            break"},{"line_number":220,"context_line":"                    # check_neq"},{"line_number":221,"context_line":"                    if fil_method \u003d\u003d \u0027neq\u0027:"},{"line_number":222,"context_line":"                        if not self.check_key_neq(dic_line, fil_name, fil_val):"},{"line_number":223,"context_line":"                            add_flg \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_33a3ed02","line":220,"updated":"2020-09-01 17:51:01.000000000","message":"This comment has no meaning.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                        if not self.check_key_eq(dic_line, fil_name, fil_val):"},{"line_number":218,"context_line":"                            add_flg \u003d False"},{"line_number":219,"context_line":"                            break"},{"line_number":220,"context_line":"                    # check_neq"},{"line_number":221,"context_line":"                    if fil_method \u003d\u003d \u0027neq\u0027:"},{"line_number":222,"context_line":"                        if not self.check_key_neq(dic_line, fil_name, fil_val):"},{"line_number":223,"context_line":"                            add_flg \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_49c90daa","line":220,"in_reply_to":"9f560f44_33a3ed02","updated":"2020-09-11 12:15:38.000000000","message":"This description was removed since the filtering process was removed.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                        if not self.check_key_neq(dic_line, fil_name, fil_val):"},{"line_number":223,"context_line":"                            add_flg \u003d False"},{"line_number":224,"context_line":"                            break"},{"line_number":225,"context_line":"                    # check_cont"},{"line_number":226,"context_line":"                    if fil_method \u003d\u003d \u0027cont\u0027:"},{"line_number":227,"context_line":"                        if not self.check_key_con(dic_line, fil_name, fil_val):"},{"line_number":228,"context_line":"                            add_flg \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_13a869d9","line":225,"updated":"2020-09-01 17:51:01.000000000","message":"This comment has no meaning.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                        if not self.check_key_neq(dic_line, fil_name, fil_val):"},{"line_number":223,"context_line":"                            add_flg \u003d False"},{"line_number":224,"context_line":"                            break"},{"line_number":225,"context_line":"                    # check_cont"},{"line_number":226,"context_line":"                    if fil_method \u003d\u003d \u0027cont\u0027:"},{"line_number":227,"context_line":"                        if not self.check_key_con(dic_line, fil_name, fil_val):"},{"line_number":228,"context_line":"                            add_flg \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_29cc99b9","line":225,"in_reply_to":"9f560f44_13a869d9","updated":"2020-09-11 12:15:38.000000000","message":"This description was removed since the filtering process was removed.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        return vnf_lcm_subscription_response"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def subscription_create(self, vnf_lcm_subscription, filter):"},{"line_number":282,"context_line":"        return self._get_vnf_lcm_subscription(vnf_lcm_subscription, filter)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def subscription_list("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8e08dd2d","line":281,"updated":"2020-09-01 17:51:01.000000000","message":"It seems violating naming convention. Pls make it verb first, then noun.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        return vnf_lcm_subscription_response"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def subscription_create(self, vnf_lcm_subscription, filter):"},{"line_number":282,"context_line":"        return self._get_vnf_lcm_subscription(vnf_lcm_subscription, filter)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def subscription_list("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_49574dcb","line":281,"in_reply_to":"9f560f44_8e08dd2d","updated":"2020-09-11 12:15:38.000000000","message":"Can you please tell me where such a naming convention is defined?","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def subscription_create(self, vnf_lcm_subscription, filter):"},{"line_number":282,"context_line":"        return self._get_vnf_lcm_subscription(vnf_lcm_subscription, filter)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def subscription_list("},{"line_number":285,"context_line":"            self,"},{"line_number":286,"context_line":"            vnf_lcm_subscriptions,"},{"line_number":287,"context_line":"            filter,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_390c793a","line":284,"updated":"2020-09-01 17:51:01.000000000","message":"Same as above","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def subscription_create(self, vnf_lcm_subscription, filter):"},{"line_number":282,"context_line":"        return self._get_vnf_lcm_subscription(vnf_lcm_subscription, filter)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def subscription_list("},{"line_number":285,"context_line":"            self,"},{"line_number":286,"context_line":"            vnf_lcm_subscriptions,"},{"line_number":287,"context_line":"            filter,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c96a3d7f","line":284,"in_reply_to":"9f560f44_390c793a","updated":"2020-09-11 12:15:38.000000000","message":"Same as previous reply.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        return self._subscription_filter("},{"line_number":291,"context_line":"            vnf_lcm_subscriptions, filter, nextpage_opaque_marker, paging)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def subscription_show(self, vnf_lcm_subscriptions):"},{"line_number":294,"context_line":"        return self._get_vnf_lcm_subscription(vnf_lcm_subscriptions)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_790d5134","line":293,"updated":"2020-09-01 17:51:01.000000000","message":"Same as above","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        return self._subscription_filter("},{"line_number":291,"context_line":"            vnf_lcm_subscriptions, filter, nextpage_opaque_marker, paging)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def subscription_show(self, vnf_lcm_subscriptions):"},{"line_number":294,"context_line":"        return self._get_vnf_lcm_subscription(vnf_lcm_subscriptions)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a96549b1","line":293,"in_reply_to":"9f560f44_790d5134","updated":"2020-09-11 12:15:38.000000000","message":"Same as previous reply.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        lcmsubscription \u003d []"},{"line_number":109,"context_line":"        LOG.debug(\"subscription_data %s\" % subscription_data)"},{"line_number":110,"context_line":"        last_flg \u003d False"},{"line_number":111,"context_line":"        startNum \u003d CONF.vnf_lcm.subscription_num * (paging - 1)"},{"line_number":112,"context_line":"        LOG.debug(\"startNum %d\" % startNum)"},{"line_number":113,"context_line":"        wk_counter \u003d 0"},{"line_number":114,"context_line":"        for cnt, line in enumerate(subscription_data):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_7475d397","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":16},"updated":"2020-09-09 16:35:47.000000000","message":"Please use snake case.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        lcmsubscription \u003d []"},{"line_number":109,"context_line":"        LOG.debug(\"subscription_data %s\" % subscription_data)"},{"line_number":110,"context_line":"        last_flg \u003d False"},{"line_number":111,"context_line":"        startNum \u003d CONF.vnf_lcm.subscription_num * (paging - 1)"},{"line_number":112,"context_line":"        LOG.debug(\"startNum %d\" % startNum)"},{"line_number":113,"context_line":"        wk_counter \u003d 0"},{"line_number":114,"context_line":"        for cnt, line in enumerate(subscription_data):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_a989c96f","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":16},"in_reply_to":"9f560f44_7475d397","updated":"2020-09-11 12:15:38.000000000","message":"Done.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        last_flg \u003d False"},{"line_number":111,"context_line":"        startNum \u003d CONF.vnf_lcm.subscription_num * (paging - 1)"},{"line_number":112,"context_line":"        LOG.debug(\"startNum %d\" % startNum)"},{"line_number":113,"context_line":"        wk_counter \u003d 0"},{"line_number":114,"context_line":"        for cnt, line in enumerate(subscription_data):"},{"line_number":115,"context_line":"            LOG.debug(\"cnt %d,line %s\" % (cnt, line))"},{"line_number":116,"context_line":"            dic_line \u003d self._basic_subscription_info(line)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_d4465f21","line":113,"updated":"2020-09-09 16:35:47.000000000","message":"Could you add a comment for the meaning of `wk_counter` to make it more understandable by taking a glance.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        last_flg \u003d False"},{"line_number":111,"context_line":"        startNum \u003d CONF.vnf_lcm.subscription_num * (paging - 1)"},{"line_number":112,"context_line":"        LOG.debug(\"startNum %d\" % startNum)"},{"line_number":113,"context_line":"        wk_counter \u003d 0"},{"line_number":114,"context_line":"        for cnt, line in enumerate(subscription_data):"},{"line_number":115,"context_line":"            LOG.debug(\"cnt %d,line %s\" % (cnt, line))"},{"line_number":116,"context_line":"            dic_line \u003d self._basic_subscription_info(line)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_29adf430","line":113,"in_reply_to":"9f560f44_d4465f21","updated":"2020-09-22 02:30:36.000000000","message":"add comment for the meaning of wk_counter","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        wk_counter \u003d 0"},{"line_number":114,"context_line":"        for cnt, line in enumerate(subscription_data):"},{"line_number":115,"context_line":"            LOG.debug(\"cnt %d,line %s\" % (cnt, line))"},{"line_number":116,"context_line":"            dic_line \u003d self._basic_subscription_info(line)"},{"line_number":117,"context_line":"            dic_line[\u0027href\u0027] \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":118,"context_line":"                \"/vnflcm/v1/subscriptions/\" + line.id.decode()"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_749af3c4","line":116,"range":{"start_line":116,"start_character":12,"end_line":116,"end_character":20},"updated":"2020-09-09 16:35:47.000000000","message":"It looks hard to understand the meaning of this variable. So, could you revise the name with more intuitive?","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        wk_counter \u003d 0"},{"line_number":114,"context_line":"        for cnt, line in enumerate(subscription_data):"},{"line_number":115,"context_line":"            LOG.debug(\"cnt %d,line %s\" % (cnt, line))"},{"line_number":116,"context_line":"            dic_line \u003d self._basic_subscription_info(line)"},{"line_number":117,"context_line":"            dic_line[\u0027href\u0027] \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":118,"context_line":"                \"/vnflcm/v1/subscriptions/\" + line.id.decode()"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_4975c8cb","line":116,"range":{"start_line":116,"start_character":12,"end_line":116,"end_character":20},"in_reply_to":"9f560f44_749af3c4","updated":"2020-09-22 02:30:36.000000000","message":"Changed the name of dic_line to something that is easy to understand","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        for cnt, line in enumerate(subscription_data):"},{"line_number":115,"context_line":"            LOG.debug(\"cnt %d,line %s\" % (cnt, line))"},{"line_number":116,"context_line":"            dic_line \u003d self._basic_subscription_info(line)"},{"line_number":117,"context_line":"            dic_line[\u0027href\u0027] \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":118,"context_line":"                \"/vnflcm/v1/subscriptions/\" + line.id.decode()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"            return_str \u003d line"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_14b1f744","line":117,"updated":"2020-09-09 16:35:47.000000000","message":"Why don\u0027t you use `os.path.join` instead?","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        for cnt, line in enumerate(subscription_data):"},{"line_number":115,"context_line":"            LOG.debug(\"cnt %d,line %s\" % (cnt, line))"},{"line_number":116,"context_line":"            dic_line \u003d self._basic_subscription_info(line)"},{"line_number":117,"context_line":"            dic_line[\u0027href\u0027] \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":118,"context_line":"                \"/vnflcm/v1/subscriptions/\" + line.id.decode()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"            return_str \u003d line"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_897b60bd","line":117,"in_reply_to":"9f560f44_14b1f744","updated":"2020-09-22 02:30:36.000000000","message":"Because it\u0027s a URL and not a file path","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"}],"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d4c1674ab29bf4a940946ce4280cc6a405b19e19","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                       \u0027OPERATE\u0027,"},{"line_number":98,"context_line":"                       \u0027CHANGE_EXT_CONN\u0027,"},{"line_number":99,"context_line":"                       \u0027MODIFY_INFO\u0027]"},{"line_number":100,"context_line":"    operationStateList \u003d [\u0027STARTING\u0027,"},{"line_number":101,"context_line":"                        \u0027PROCESSING\u0027,"},{"line_number":102,"context_line":"                        \u0027COMPLETED\u0027,"},{"line_number":103,"context_line":"                        \u0027FAILED_TEMP\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_bf27bf64","line":100,"updated":"2020-08-17 06:46:35.000000000","message":"Are \u0027operation\u0027 and \u0027determined\u0027 should included in operationStateList?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                       \u0027OPERATE\u0027,"},{"line_number":98,"context_line":"                       \u0027CHANGE_EXT_CONN\u0027,"},{"line_number":99,"context_line":"                       \u0027MODIFY_INFO\u0027]"},{"line_number":100,"context_line":"    operationStateList \u003d [\u0027STARTING\u0027,"},{"line_number":101,"context_line":"                        \u0027PROCESSING\u0027,"},{"line_number":102,"context_line":"                        \u0027COMPLETED\u0027,"},{"line_number":103,"context_line":"                        \u0027FAILED_TEMP\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_ab3501de","line":100,"in_reply_to":"9f560f44_bf27bf64","updated":"2020-08-28 12:52:41.000000000","message":"Deleted because it is unnecessary (operation,determined). Please expect it in patch3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48e3264c4983f72e0c71ec514e52c6582a0d7125","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            tenant_id\u003drequest.context.project_id)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        vnf_instance.create()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        result \u003d self._view_builder.create(vnf_instance)"},{"line_number":231,"context_line":"        headers \u003d {\"location\": self._get_vnf_instance_href(vnf_instance)}"},{"line_number":232,"context_line":"        return wsgi.ResponseObject(result, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a22a0829","line":229,"updated":"2020-08-17 09:59:11.000000000","message":"I think it\u0027s an unnecessary line break.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            tenant_id\u003drequest.context.project_id)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        vnf_instance.create()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        result \u003d self._view_builder.create(vnf_instance)"},{"line_number":231,"context_line":"        headers \u003d {\"location\": self._get_vnf_instance_href(vnf_instance)}"},{"line_number":232,"context_line":"        return wsgi.ResponseObject(result, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_6b592934","line":229,"in_reply_to":"9f560f44_a22a0829","updated":"2020-08-28 12:52:41.000000000","message":"Deleted the unnecessary line break. Please expect it in patch3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48e3264c4983f72e0c71ec514e52c6582a0d7125","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                    msg \u003d ("},{"line_number":372,"context_line":"                        _(\"notificationTypes value mismatch: %s\") %"},{"line_number":373,"context_line":"                        notification_type)"},{"line_number":374,"context_line":"                    return self._make_problem_detail("},{"line_number":375,"context_line":"                        msg, 400, title\u003d\u0027Bad Request\u0027)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"            # operationTypes check"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a2ade89c","line":374,"updated":"2020-08-17 09:59:11.000000000","message":"Can you fix the error handling using webob.exc.HTTPBadRequest?\nSame for other parts.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"757760cc8d7cf700524dbcc50edb012a9c5e26fc","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                    msg \u003d ("},{"line_number":372,"context_line":"                        _(\"notificationTypes value mismatch: %s\") %"},{"line_number":373,"context_line":"                        notification_type)"},{"line_number":374,"context_line":"                    return self._make_problem_detail("},{"line_number":375,"context_line":"                        msg, 400, title\u003d\u0027Bad Request\u0027)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"            # operationTypes check"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_13a13ff8","line":374,"in_reply_to":"9f560f44_a2ade89c","updated":"2020-09-07 00:42:18.000000000","message":"This implementation is sufficient because webob.Response is started with _make_problem_detail that sets ProblemDetails and can be shared.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48e3264c4983f72e0c71ec514e52c6582a0d7125","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            vnf_lcm_subscription \u003d vnf_lcm_subscription.create(filter)"},{"line_number":407,"context_line":"            LOG.debug(\"vnf_lcm_subscription %s\" % vnf_lcm_subscription)"},{"line_number":408,"context_line":"        except Exception as e:"},{"line_number":409,"context_line":"            if re.search(\"^303\", str(e)):"},{"line_number":410,"context_line":"                res \u003d self._make_problem_detail("},{"line_number":411,"context_line":"                    \"See Other\", 303, title\u003d\u0027See Other\u0027)"},{"line_number":412,"context_line":"                link \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_22a6f854","line":409,"updated":"2020-08-17 09:59:11.000000000","message":"Can you define an exception class in common/exceptions.py and fix the error handling using it?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"be92ee32ad8478379656b1f3c820961593f60271","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            vnf_lcm_subscription \u003d vnf_lcm_subscription.create(filter)"},{"line_number":407,"context_line":"            LOG.debug(\"vnf_lcm_subscription %s\" % vnf_lcm_subscription)"},{"line_number":408,"context_line":"        except Exception as e:"},{"line_number":409,"context_line":"            if re.search(\"^303\", str(e)):"},{"line_number":410,"context_line":"                res \u003d self._make_problem_detail("},{"line_number":411,"context_line":"                    \"See Other\", 303, title\u003d\u0027See Other\u0027)"},{"line_number":412,"context_line":"                link \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b6b973cc","line":409,"in_reply_to":"9f560f44_22a6f854","updated":"2020-09-04 13:17:00.000000000","message":"* Added class SeeOther to tacker/common/exceptions.py and replace the relevant part with exception exceptions.\nFixed to SeeOther.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48e3264c4983f72e0c71ec514e52c6582a0d7125","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            LOG.debug(\"vnf_lcm_subscription %s\" % vnf_lcm_subscription)"},{"line_number":408,"context_line":"        except Exception as e:"},{"line_number":409,"context_line":"            if re.search(\"^303\", str(e)):"},{"line_number":410,"context_line":"                res \u003d self._make_problem_detail("},{"line_number":411,"context_line":"                    \"See Other\", 303, title\u003d\u0027See Other\u0027)"},{"line_number":412,"context_line":"                link \u003d ("},{"line_number":413,"context_line":"                    \u0027LINK\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_026c9434","line":410,"updated":"2020-08-17 09:59:11.000000000","message":"Can you fix the error handling using webob.exc.HTTPSeeOther?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"757760cc8d7cf700524dbcc50edb012a9c5e26fc","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            LOG.debug(\"vnf_lcm_subscription %s\" % vnf_lcm_subscription)"},{"line_number":408,"context_line":"        except Exception as e:"},{"line_number":409,"context_line":"            if re.search(\"^303\", str(e)):"},{"line_number":410,"context_line":"                res \u003d self._make_problem_detail("},{"line_number":411,"context_line":"                    \"See Other\", 303, title\u003d\u0027See Other\u0027)"},{"line_number":412,"context_line":"                link \u003d ("},{"line_number":413,"context_line":"                    \u0027LINK\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f3a5ab04","line":410,"in_reply_to":"9f560f44_026c9434","updated":"2020-09-07 00:42:18.000000000","message":"This implementation is sufficient because webob.Response is started with _make_problem_detail that sets ProblemDetails and can be shared.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d4c1674ab29bf4a940946ce4280cc6a405b19e19","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                res.headerlist.append(link)"},{"line_number":419,"context_line":"                return res"},{"line_number":420,"context_line":"            else:"},{"line_number":421,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":422,"context_line":"                return self._make_problem_detail("},{"line_number":423,"context_line":"                    str(e), 500, title\u003d\u0027Internal Server Error\u0027)"},{"line_number":424,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_7f0407c7","line":421,"updated":"2020-08-17 06:46:35.000000000","message":"Instead of logging \u0027traceback\u0027 as it is, I think it\u0027s better to define an exception class in tacker/common/exceptions.py and use it for error handling.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"757760cc8d7cf700524dbcc50edb012a9c5e26fc","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                res.headerlist.append(link)"},{"line_number":419,"context_line":"                return res"},{"line_number":420,"context_line":"            else:"},{"line_number":421,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":422,"context_line":"                return self._make_problem_detail("},{"line_number":423,"context_line":"                    str(e), 500, title\u003d\u0027Internal Server Error\u0027)"},{"line_number":424,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_735cfb18","line":421,"in_reply_to":"9f560f44_7f0407c7","updated":"2020-09-07 00:42:18.000000000","message":"In ETSI, it is necessary to set ProblemDetails as body information for 4xx/5xx errors, and it is not implemented in exceptions.py, but the current implementation.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48e3264c4983f72e0c71ec514e52c6582a0d7125","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                return res"},{"line_number":420,"context_line":"            else:"},{"line_number":421,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":422,"context_line":"                return self._make_problem_detail("},{"line_number":423,"context_line":"                    str(e), 500, title\u003d\u0027Internal Server Error\u0027)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        return self._view_builder.subscription_create("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a29b2864","line":422,"updated":"2020-08-17 09:59:11.000000000","message":"Can you fix the error handling using webob.exc.HTTPInternalServerError?\nSame for other parts.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"757760cc8d7cf700524dbcc50edb012a9c5e26fc","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                return res"},{"line_number":420,"context_line":"            else:"},{"line_number":421,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":422,"context_line":"                return self._make_problem_detail("},{"line_number":423,"context_line":"                    str(e), 500, title\u003d\u0027Internal Server Error\u0027)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        return self._view_builder.subscription_create("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_53ae17e7","line":422,"in_reply_to":"9f560f44_a29b2864","updated":"2020-09-07 00:42:18.000000000","message":"This implementation is sufficient because webob.Response is started with _make_problem_detail that sets ProblemDetails and can be shared.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48e3264c4983f72e0c71ec514e52c6582a0d7125","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                msg \u003d ("},{"line_number":436,"context_line":"                    _(\"Can not find requested vnf lcm subscriptions: %s\") %"},{"line_number":437,"context_line":"                    subscriptionId)"},{"line_number":438,"context_line":"                return self._make_problem_detail(msg, 404, title\u003d\u0027Not Found\u0027)"},{"line_number":439,"context_line":"        except Exception as e:"},{"line_number":440,"context_line":"            return self._make_problem_detail("},{"line_number":441,"context_line":"                str(e), 500, title\u003d\u0027Internal Server Error\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_42da0c17","line":438,"updated":"2020-08-17 09:59:11.000000000","message":"Can you fix the error handling using webob.exc.HTTPNotFound?\nSame for other parts.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"757760cc8d7cf700524dbcc50edb012a9c5e26fc","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                msg \u003d ("},{"line_number":436,"context_line":"                    _(\"Can not find requested vnf lcm subscriptions: %s\") %"},{"line_number":437,"context_line":"                    subscriptionId)"},{"line_number":438,"context_line":"                return self._make_problem_detail(msg, 404, title\u003d\u0027Not Found\u0027)"},{"line_number":439,"context_line":"        except Exception as e:"},{"line_number":440,"context_line":"            return self._make_problem_detail("},{"line_number":441,"context_line":"                str(e), 500, title\u003d\u0027Internal Server Error\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_33aba3d6","line":438,"in_reply_to":"9f560f44_42da0c17","updated":"2020-09-07 00:42:18.000000000","message":"This implementation is sufficient because webob.Response is started with _make_problem_detail that sets ProblemDetails and can be shared.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d4c1674ab29bf4a940946ce4280cc6a405b19e19","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        re_url \u003d request.path_url"},{"line_number":452,"context_line":"        query_params \u003d request.query_string"},{"line_number":453,"context_line":"        if query_params:"},{"line_number":454,"context_line":"            query_params \u003d parse.unquote(query_params)"},{"line_number":455,"context_line":"        LOG.debug(\"query_params %s\" % query_params)"},{"line_number":456,"context_line":"        if query_params:"},{"line_number":457,"context_line":"            query_param_list \u003d query_params.split(\u0027\u0026\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_dff273e3","line":454,"updated":"2020-08-17 06:46:35.000000000","message":"I think you need not to use the \u0027six.moves.urllib\u0027 library because Python2 support is not needed.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"be92ee32ad8478379656b1f3c820961593f60271","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        re_url \u003d request.path_url"},{"line_number":452,"context_line":"        query_params \u003d request.query_string"},{"line_number":453,"context_line":"        if query_params:"},{"line_number":454,"context_line":"            query_params \u003d parse.unquote(query_params)"},{"line_number":455,"context_line":"        LOG.debug(\"query_params %s\" % query_params)"},{"line_number":456,"context_line":"        if query_params:"},{"line_number":457,"context_line":"            query_param_list \u003d query_params.split(\u0027\u0026\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f6012b6c","line":454,"in_reply_to":"9f560f44_dff273e3","updated":"2020-09-04 13:17:00.000000000","message":"We change to use python3 lib","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7d27c6dd8b7d301da1b43fe651b470ddca3f0efb","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                    filter \u003d query_param_key_value[1]"},{"line_number":466,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027nextpage_opaque_marker\u0027:"},{"line_number":467,"context_line":"                    nextpage_opaque_marker \u003d query_param_key_value[1]"},{"line_number":468,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027page\u0027:"},{"line_number":469,"context_line":"                    paging \u003d int(query_param_key_value[1])"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        # check subscription_regex"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_358a8c1a","line":468,"updated":"2020-08-19 05:22:28.000000000","message":"I\u0027ve referenced SOL003 10.4.7.3.2 but couldn\u0027t find the query parameter \u0027page\u0027, do you need it?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"2030c54b0141c87ef9cddc8cc8cf839910424a7b","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                    filter \u003d query_param_key_value[1]"},{"line_number":466,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027nextpage_opaque_marker\u0027:"},{"line_number":467,"context_line":"                    nextpage_opaque_marker \u003d query_param_key_value[1]"},{"line_number":468,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027page\u0027:"},{"line_number":469,"context_line":"                    paging \u003d int(query_param_key_value[1])"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        # check subscription_regex"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_808925c8","line":468,"in_reply_to":"9f560f44_0f66142a","updated":"2020-09-25 07:43:18.000000000","message":"Added a TODO. We will support it as soon as RFC specifications is confirmed.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5a25a07e5da36f0bb418ab82bfc169075e1e40b8","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                    filter \u003d query_param_key_value[1]"},{"line_number":466,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027nextpage_opaque_marker\u0027:"},{"line_number":467,"context_line":"                    nextpage_opaque_marker \u003d query_param_key_value[1]"},{"line_number":468,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027page\u0027:"},{"line_number":469,"context_line":"                    paging \u003d int(query_param_key_value[1])"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        # check subscription_regex"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_307d87b2","line":468,"in_reply_to":"9f560f44_10dcc3df","updated":"2020-10-05 06:59:21.000000000","message":"Thank you for adding.\nThere is no recomment.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"757760cc8d7cf700524dbcc50edb012a9c5e26fc","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                    filter \u003d query_param_key_value[1]"},{"line_number":466,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027nextpage_opaque_marker\u0027:"},{"line_number":467,"context_line":"                    nextpage_opaque_marker \u003d query_param_key_value[1]"},{"line_number":468,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027page\u0027:"},{"line_number":469,"context_line":"                    paging \u003d int(query_param_key_value[1])"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        # check subscription_regex"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b3885371","line":468,"in_reply_to":"9f560f44_358a8c1a","updated":"2020-09-07 00:42:18.000000000","message":"When implementing SOL013 5.4 Handling of large query results, variable page is used for internal control. Controls the next of RFC8288 operation.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ca3672b2207e607effa0be6efe963b8e78923bf0","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                    filter \u003d query_param_key_value[1]"},{"line_number":466,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027nextpage_opaque_marker\u0027:"},{"line_number":467,"context_line":"                    nextpage_opaque_marker \u003d query_param_key_value[1]"},{"line_number":468,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027page\u0027:"},{"line_number":469,"context_line":"                    paging \u003d int(query_param_key_value[1])"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        # check subscription_regex"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c56ecf2a","line":468,"in_reply_to":"9f560f44_49ddf611","updated":"2020-09-22 15:20:20.000000000","message":"On victoria spec , attribute based filter is not required. So we deleted it. On the other side , nextpage_opaque_marker  may not be able to operate Subscription List, so it is better to support it, so I left the process.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"146102da0e65f1f311eaee2eb94e7fc123bd29ba","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                    filter \u003d query_param_key_value[1]"},{"line_number":466,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027nextpage_opaque_marker\u0027:"},{"line_number":467,"context_line":"                    nextpage_opaque_marker \u003d query_param_key_value[1]"},{"line_number":468,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027page\u0027:"},{"line_number":469,"context_line":"                    paging \u003d int(query_param_key_value[1])"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        # check subscription_regex"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_9040d308","line":468,"in_reply_to":"9f560f44_808925c8","updated":"2020-10-05 05:19:32.000000000","message":"It seems that the TODO comment has been deleted.\nI think it\u0027s not necessary to make it TODO, but please leave a comment about how to interpret and implement SOL as a tacker.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"50213960919c818fe72c3d8bf075a986b9199610","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                    filter \u003d query_param_key_value[1]"},{"line_number":466,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027nextpage_opaque_marker\u0027:"},{"line_number":467,"context_line":"                    nextpage_opaque_marker \u003d query_param_key_value[1]"},{"line_number":468,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027page\u0027:"},{"line_number":469,"context_line":"                    paging \u003d int(query_param_key_value[1])"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        # check subscription_regex"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_10dcc3df","line":468,"in_reply_to":"9f560f44_9040d308","updated":"2020-10-05 06:49:53.000000000","message":"I think the comment you are referring to is the information we indicated in Line-525. Please confirm whether information is sufficient, else, we will improve it, or do you want it stated in this line as well?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fa1973075b14f52a1fe2d605639510de4db54369","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                    filter \u003d query_param_key_value[1]"},{"line_number":466,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027nextpage_opaque_marker\u0027:"},{"line_number":467,"context_line":"                    nextpage_opaque_marker \u003d query_param_key_value[1]"},{"line_number":468,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027page\u0027:"},{"line_number":469,"context_line":"                    paging \u003d int(query_param_key_value[1])"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        # check subscription_regex"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_49ddf611","line":468,"in_reply_to":"9f560f44_b3885371","updated":"2020-09-18 08:06:21.000000000","message":"In patchset-12, \u0027filter\u0027 is removed and \u0027page\u0027 remains.\nAs far as I can see SOL003 10.4.7.3.2, I thought it was correct to remove \u0027page\u0027 and remain \u0027filter\u0027.\nIs it right?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a9d377654a53cd2d7faa8745224505da84822e47","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                    filter \u003d query_param_key_value[1]"},{"line_number":466,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027nextpage_opaque_marker\u0027:"},{"line_number":467,"context_line":"                    nextpage_opaque_marker \u003d query_param_key_value[1]"},{"line_number":468,"context_line":"                if query_param_key_value[0] \u003d\u003d \u0027page\u0027:"},{"line_number":469,"context_line":"                    paging \u003d int(query_param_key_value[1])"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        # check subscription_regex"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_0f66142a","line":468,"in_reply_to":"9f560f44_c56ecf2a","updated":"2020-09-23 10:19:59.000000000","message":"I understood that the query parameter \u0027filter\u0027 is not needed.\nI couldn\u0027t find where the query parameter \u0027page\u0027 was described in SOL, so please let me know.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class VnfLcmController(wsgi.Controller):"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    notificationTypeList \u003d [\u0027VnfLcmOperationOccurrenceNotification\u0027,"},{"line_number":90,"context_line":"                          \u0027VnfIdentifierCreationNotification\u0027,"},{"line_number":91,"context_line":"                          \u0027VnfIdentifierDeletionNotification\u0027]"},{"line_number":92,"context_line":"    operationTypeList \u003d [\u0027INSTANTIATE\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_3417dbf0","line":89,"updated":"2020-09-09 16:35:47.000000000","message":"Please do not use camel case usually. Use snake case for a variable or capital for constant instead.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class VnfLcmController(wsgi.Controller):"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    notificationTypeList \u003d [\u0027VnfLcmOperationOccurrenceNotification\u0027,"},{"line_number":90,"context_line":"                          \u0027VnfIdentifierCreationNotification\u0027,"},{"line_number":91,"context_line":"                          \u0027VnfIdentifierDeletionNotification\u0027]"},{"line_number":92,"context_line":"    operationTypeList \u003d [\u0027INSTANTIATE\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_09411064","line":89,"in_reply_to":"9f560f44_3417dbf0","updated":"2020-09-22 02:30:36.000000000","message":"changed to snake case","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    notificationTypeList \u003d [\u0027VnfLcmOperationOccurrenceNotification\u0027,"},{"line_number":90,"context_line":"                          \u0027VnfIdentifierCreationNotification\u0027,"},{"line_number":91,"context_line":"                          \u0027VnfIdentifierDeletionNotification\u0027]"},{"line_number":92,"context_line":"    operationTypeList \u003d [\u0027INSTANTIATE\u0027,"},{"line_number":93,"context_line":"                       \u0027SCALE\u0027,"},{"line_number":94,"context_line":"                       \u0027SCALE_TO_LEVEL\u0027,"},{"line_number":95,"context_line":"                       \u0027CHANGE_FLAVOUR\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_f4e5630b","line":92,"updated":"2020-09-09 16:35:47.000000000","message":"Same as before.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    notificationTypeList \u003d [\u0027VnfLcmOperationOccurrenceNotification\u0027,"},{"line_number":90,"context_line":"                          \u0027VnfIdentifierCreationNotification\u0027,"},{"line_number":91,"context_line":"                          \u0027VnfIdentifierDeletionNotification\u0027]"},{"line_number":92,"context_line":"    operationTypeList \u003d [\u0027INSTANTIATE\u0027,"},{"line_number":93,"context_line":"                       \u0027SCALE\u0027,"},{"line_number":94,"context_line":"                       \u0027SCALE_TO_LEVEL\u0027,"},{"line_number":95,"context_line":"                       \u0027CHANGE_FLAVOUR\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_e945bc70","line":92,"in_reply_to":"9f560f44_f4e5630b","updated":"2020-09-22 02:30:36.000000000","message":"changed to snake case","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                       \u0027OPERATE\u0027,"},{"line_number":99,"context_line":"                       \u0027CHANGE_EXT_CONN\u0027,"},{"line_number":100,"context_line":"                       \u0027MODIFY_INFO\u0027]"},{"line_number":101,"context_line":"    operationStateList \u003d [\u0027STARTING\u0027,"},{"line_number":102,"context_line":"                        \u0027PROCESSING\u0027,"},{"line_number":103,"context_line":"                        \u0027COMPLETED\u0027,"},{"line_number":104,"context_line":"                        \u0027FAILED_TEMP\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_d4cbff6e","line":101,"updated":"2020-09-09 16:35:47.000000000","message":"Same as before.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                       \u0027OPERATE\u0027,"},{"line_number":99,"context_line":"                       \u0027CHANGE_EXT_CONN\u0027,"},{"line_number":100,"context_line":"                       \u0027MODIFY_INFO\u0027]"},{"line_number":101,"context_line":"    operationStateList \u003d [\u0027STARTING\u0027,"},{"line_number":102,"context_line":"                        \u0027PROCESSING\u0027,"},{"line_number":103,"context_line":"                        \u0027COMPLETED\u0027,"},{"line_number":104,"context_line":"                        \u0027FAILED_TEMP\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_495e6845","line":101,"in_reply_to":"9f560f44_d4cbff6e","updated":"2020-09-22 02:30:36.000000000","message":"changed to snake case","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":508,"context_line":"            return self._make_problem_detail("},{"line_number":509,"context_line":"                str(e), 500, title\u003d\u0027Internal Server Error\u0027)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _make_problem_detail("},{"line_number":512,"context_line":"            self,"},{"line_number":513,"context_line":"            detail,"},{"line_number":514,"context_line":"            status,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_f4cf2354","line":511,"updated":"2020-09-09 16:35:47.000000000","message":"You should a short note for such a method commonly used.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[{"line_number":508,"context_line":"            return self._make_problem_detail("},{"line_number":509,"context_line":"                str(e), 500, title\u003d\u0027Internal Server Error\u0027)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _make_problem_detail("},{"line_number":512,"context_line":"            self,"},{"line_number":513,"context_line":"            detail,"},{"line_number":514,"context_line":"            status,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_89540024","line":511,"in_reply_to":"9f560f44_f4cf2354","updated":"2020-09-22 02:30:36.000000000","message":"added a note","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            instance\u003dNone):"},{"line_number":518,"context_line":"        LOG.warn(detail)"},{"line_number":519,"context_line":"        res \u003d webob.Response(content_type\u003d\u0027application/problem+json\u0027)"},{"line_number":520,"context_line":"        problemDetails \u003d {}"},{"line_number":521,"context_line":"        if type:"},{"line_number":522,"context_line":"            problemDetails[\u0027type\u0027] \u003d type"},{"line_number":523,"context_line":"        if title:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_74dcb317","line":520,"range":{"start_line":520,"start_character":8,"end_line":520,"end_character":22},"updated":"2020-09-09 16:35:47.000000000","message":"Please use snake case.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            instance\u003dNone):"},{"line_number":518,"context_line":"        LOG.warn(detail)"},{"line_number":519,"context_line":"        res \u003d webob.Response(content_type\u003d\u0027application/problem+json\u0027)"},{"line_number":520,"context_line":"        problemDetails \u003d {}"},{"line_number":521,"context_line":"        if type:"},{"line_number":522,"context_line":"            problemDetails[\u0027type\u0027] \u003d type"},{"line_number":523,"context_line":"        if title:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_6951ac30","line":520,"range":{"start_line":520,"start_character":8,"end_line":520,"end_character":22},"in_reply_to":"9f560f44_74dcb317","updated":"2020-09-22 02:30:36.000000000","message":"changed to snake case","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"}],"tacker/conf/vnf_lcm.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48e3264c4983f72e0c71ec514e52c6582a0d7125","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        default\u003d\u0027http://localhost:9890/\u0027,"},{"line_number":22,"context_line":"        help\u003d\"endpoint_url\"),"},{"line_number":23,"context_line":"    cfg.StrOpt("},{"line_number":24,"context_line":"        \u0027subscription_regex\u0027,"},{"line_number":25,"context_line":"        default\u003d\u0027^\\\\((eq|neq|cont),\\"},{"line_number":26,"context_line":"            (id|vnfdIds|vnfProvider|vnfProductName|vnfSoftwareVersion|vnfdVersions|\\"},{"line_number":27,"context_line":"                vnfInstanceIds|vnfInstanceNames|notificationTypes|\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a5169254","line":24,"updated":"2020-08-17 09:59:11.000000000","message":"Should this subscription_regex be configurable in config?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"e6e2549a74129b2bf4a7450f0ef0778df67281e5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        default\u003d\u0027http://localhost:9890/\u0027,"},{"line_number":22,"context_line":"        help\u003d\"endpoint_url\"),"},{"line_number":23,"context_line":"    cfg.StrOpt("},{"line_number":24,"context_line":"        \u0027subscription_regex\u0027,"},{"line_number":25,"context_line":"        default\u003d\u0027^\\\\((eq|neq|cont),\\"},{"line_number":26,"context_line":"            (id|vnfdIds|vnfProvider|vnfProductName|vnfSoftwareVersion|vnfdVersions|\\"},{"line_number":27,"context_line":"                vnfInstanceIds|vnfInstanceNames|notificationTypes|\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_20c04750","line":24,"in_reply_to":"9f560f44_a5169254","updated":"2020-09-09 13:04:35.000000000","message":"We think it is not necessary so much to be configurable.\nDo you think this is mandatory change?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d4c1674ab29bf4a940946ce4280cc6a405b19e19","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    cfg.IntOpt("},{"line_number":41,"context_line":"        \u0027retry_num\u0027,"},{"line_number":42,"context_line":"        default\u003d3,"},{"line_number":43,"context_line":"        help\u003d\"Number of subscriptions\"),"},{"line_number":44,"context_line":"    cfg.IntOpt("},{"line_number":45,"context_line":"        \u0027retry_wait\u0027,"},{"line_number":46,"context_line":"        default\u003d10,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_df38b33c","line":43,"updated":"2020-08-17 06:46:35.000000000","message":"I think the description is incorrect.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    cfg.IntOpt("},{"line_number":41,"context_line":"        \u0027retry_num\u0027,"},{"line_number":42,"context_line":"        default\u003d3,"},{"line_number":43,"context_line":"        help\u003d\"Number of subscriptions\"),"},{"line_number":44,"context_line":"    cfg.IntOpt("},{"line_number":45,"context_line":"        \u0027retry_wait\u0027,"},{"line_number":46,"context_line":"        default\u003d10,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_ab3a21c1","line":43,"in_reply_to":"9f560f44_df38b33c","updated":"2020-08-28 12:52:41.000000000","message":"Modified as follows: \nNumber of subscriptions \u003d\u003e Number of retry\nPlease expect it in patch3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d4c1674ab29bf4a940946ce4280cc6a405b19e19","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.IntOpt("},{"line_number":45,"context_line":"        \u0027retry_wait\u0027,"},{"line_number":46,"context_line":"        default\u003d10,"},{"line_number":47,"context_line":"        help\u003d\"Number of subscriptions\")]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"},{"line_number":50,"context_line":"    title\u003d\u0027vnf_lcm options\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_3f48cfca","line":47,"updated":"2020-08-17 06:46:35.000000000","message":"I think the description is incorrect.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.IntOpt("},{"line_number":45,"context_line":"        \u0027retry_wait\u0027,"},{"line_number":46,"context_line":"        default\u003d10,"},{"line_number":47,"context_line":"        help\u003d\"Number of subscriptions\")]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"},{"line_number":50,"context_line":"    title\u003d\u0027vnf_lcm options\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_0b486d5a","line":47,"in_reply_to":"9f560f44_3f48cfca","updated":"2020-08-28 12:52:41.000000000","message":"Modified as follows:\nNumber of subscriptions \u003d\u003e Retry interval\nPlease expect it in patch3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        default\u003d\u0027http://localhost:9890/\u0027,"},{"line_number":22,"context_line":"        help\u003d\"endpoint_url\"),"},{"line_number":23,"context_line":"    cfg.StrOpt("},{"line_number":24,"context_line":"        \u0027subscription_regex\u0027,"},{"line_number":25,"context_line":"        default\u003d\u0027^\\\\((eq|neq|cont),\\"},{"line_number":26,"context_line":"            (id|vnfdIds|vnfProvider|vnfProductName|vnfSoftwareVersion|vnfdVersions|\\"},{"line_number":27,"context_line":"                vnfInstanceIds|vnfInstanceNames|notificationTypes|\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b3053d17","line":24,"updated":"2020-09-01 17:51:01.000000000","message":"Could add a explanation for the regex because it is so hard to understand, especially for considering code maintenance.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        default\u003d\u0027http://localhost:9890/\u0027,"},{"line_number":22,"context_line":"        help\u003d\"endpoint_url\"),"},{"line_number":23,"context_line":"    cfg.StrOpt("},{"line_number":24,"context_line":"        \u0027subscription_regex\u0027,"},{"line_number":25,"context_line":"        default\u003d\u0027^\\\\((eq|neq|cont),\\"},{"line_number":26,"context_line":"            (id|vnfdIds|vnfProvider|vnfProductName|vnfSoftwareVersion|vnfdVersions|\\"},{"line_number":27,"context_line":"                vnfInstanceIds|vnfInstanceNames|notificationTypes|\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_89220551","line":24,"in_reply_to":"9f560f44_b3053d17","updated":"2020-09-11 12:15:38.000000000","message":"The target code was removed due to the change of no using filter.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        help\u003d\"Number of retry\"),"},{"line_number":44,"context_line":"    cfg.IntOpt("},{"line_number":45,"context_line":"        \u0027retry_wait\u0027,"},{"line_number":46,"context_line":"        default\u003d10,"},{"line_number":47,"context_line":"        help\u003d\"Retry interval\")]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7ffd2707","line":46,"updated":"2020-09-01 17:51:01.000000000","message":"Is it sec or min? It seems better to a comment simply.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        help\u003d\"Number of retry\"),"},{"line_number":44,"context_line":"    cfg.IntOpt("},{"line_number":45,"context_line":"        \u0027retry_wait\u0027,"},{"line_number":46,"context_line":"        default\u003d10,"},{"line_number":47,"context_line":"        help\u003d\"Retry interval\")]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_691df10d","line":46,"in_reply_to":"9f560f44_7ffd2707","updated":"2020-09-11 12:15:38.000000000","message":"Added that it was sec.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"},{"line_number":50,"context_line":"    title\u003d\u0027vnf_lcm options\u0027,"},{"line_number":51,"context_line":"    help\u003d\" \")"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_5f002301","line":51,"updated":"2020-09-01 17:51:01.000000000","message":"Why it is empty?","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"},{"line_number":50,"context_line":"    title\u003d\u0027vnf_lcm options\u0027,"},{"line_number":51,"context_line":"    help\u003d\" \")"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c9187d1f","line":51,"in_reply_to":"9f560f44_5f002301","updated":"2020-09-11 12:15:38.000000000","message":"Added a message.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"}],"tacker/db/db_sqlalchemy/models.py":[{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"8651a867a196b22b3a07bafbe21468f06c0e5696","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    subscription_authentication \u003d sa.Column(sa.JSON, nullable\u003dTrue)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"class VnfLcmFilters(model_base.BASE):"},{"line_number":239,"context_line":"    \"\"\"Contains all info about vnf LCM filters.\"\"\""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    __tablename__ \u003d \u0027vnf_lcm_filters\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_4320ce9b","line":238,"range":{"start_line":238,"start_character":6,"end_line":238,"end_character":19},"updated":"2020-08-25 04:31:49.000000000","message":"According to the spec(https://opendev.org/openstack/tacker-specs/src/branch/master/specs/victoria/support-notification-api-based-on-etsi-nfv-sol.rst), vnf_instance_ids, operation_states, and operation_states_len should be defined at vnf_lcm_filters DB.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"497618cf7e6096846e977bf06b34e639879f6f1f","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    subscription_authentication \u003d sa.Column(sa.JSON, nullable\u003dTrue)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"class VnfLcmFilters(model_base.BASE):"},{"line_number":239,"context_line":"    \"\"\"Contains all info about vnf LCM filters.\"\"\""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    __tablename__ \u003d \u0027vnf_lcm_filters\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_d246dd7b","line":238,"range":{"start_line":238,"start_character":6,"end_line":238,"end_character":19},"in_reply_to":"9f560f44_24c21254","updated":"2020-09-18 08:15:25.000000000","message":"Understood.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"e6e2549a74129b2bf4a7450f0ef0778df67281e5","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    subscription_authentication \u003d sa.Column(sa.JSON, nullable\u003dTrue)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"class VnfLcmFilters(model_base.BASE):"},{"line_number":239,"context_line":"    \"\"\"Contains all info about vnf LCM filters.\"\"\""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    __tablename__ \u003d \u0027vnf_lcm_filters\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_24c21254","line":238,"range":{"start_line":238,"start_character":6,"end_line":238,"end_character":19},"in_reply_to":"9f560f44_4320ce9b","updated":"2020-09-09 13:04:35.000000000","message":"This is the incorrect description in the spec side.\nActually no need to define those parameters.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7d27c6dd8b7d301da1b43fe651b470ddca3f0efb","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    filter \u003d sa.Column(sa.JSON, nullable\u003dFalse)"},{"line_number":248,"context_line":"    notification_types \u003d sa.Column(sa.VARBINARY(255), nullable\u003dTrue)"},{"line_number":249,"context_line":"    notification_types_len \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":250,"context_line":"    operation_types \u003d sa.Column("},{"line_number":251,"context_line":"        sa.LargeBinary("},{"line_number":252,"context_line":"            length\u003d__maxsize__),"},{"line_number":253,"context_line":"        nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_4b2a13e7","line":250,"updated":"2020-08-19 05:22:28.000000000","message":"Can operation_types be huge data that cannot be expressed without using LargeBinary?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fa1973075b14f52a1fe2d605639510de4db54369","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    filter \u003d sa.Column(sa.JSON, nullable\u003dFalse)"},{"line_number":248,"context_line":"    notification_types \u003d sa.Column(sa.VARBINARY(255), nullable\u003dTrue)"},{"line_number":249,"context_line":"    notification_types_len \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":250,"context_line":"    operation_types \u003d sa.Column("},{"line_number":251,"context_line":"        sa.LargeBinary("},{"line_number":252,"context_line":"            length\u003d__maxsize__),"},{"line_number":253,"context_line":"        nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a4a8398c","line":250,"in_reply_to":"9f560f44_137adf75","updated":"2020-09-18 08:06:21.000000000","message":"In my opinion, operation_types wouldn\u0027t be a big size.\nI referred to SOL003 5.5.4.7 LcmOperationType.\nIs it right?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"757760cc8d7cf700524dbcc50edb012a9c5e26fc","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    filter \u003d sa.Column(sa.JSON, nullable\u003dFalse)"},{"line_number":248,"context_line":"    notification_types \u003d sa.Column(sa.VARBINARY(255), nullable\u003dTrue)"},{"line_number":249,"context_line":"    notification_types_len \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":250,"context_line":"    operation_types \u003d sa.Column("},{"line_number":251,"context_line":"        sa.LargeBinary("},{"line_number":252,"context_line":"            length\u003d__maxsize__),"},{"line_number":253,"context_line":"        nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_137adf75","line":250,"in_reply_to":"9f560f44_4b2a13e7","updated":"2020-09-07 00:42:18.000000000","message":"Since the data is set using \"GENERATED ALWAYS AS\", the size is large, so this definition is appropriate.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ca3672b2207e607effa0be6efe963b8e78923bf0","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    filter \u003d sa.Column(sa.JSON, nullable\u003dFalse)"},{"line_number":248,"context_line":"    notification_types \u003d sa.Column(sa.VARBINARY(255), nullable\u003dTrue)"},{"line_number":249,"context_line":"    notification_types_len \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":250,"context_line":"    operation_types \u003d sa.Column("},{"line_number":251,"context_line":"        sa.LargeBinary("},{"line_number":252,"context_line":"            length\u003d__maxsize__),"},{"line_number":253,"context_line":"        nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e54af3aa","line":250,"in_reply_to":"9f560f44_a4a8398c","updated":"2020-09-22 15:20:20.000000000","message":"No, LifecycleChangeNotificationsFilter is.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"68be98550dc04322ea97ad91a586bee3383e5f08","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    filter \u003d sa.Column(sa.JSON, nullable\u003dFalse)"},{"line_number":248,"context_line":"    notification_types \u003d sa.Column(sa.VARBINARY(255), nullable\u003dTrue)"},{"line_number":249,"context_line":"    notification_types_len \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":250,"context_line":"    operation_types \u003d sa.Column("},{"line_number":251,"context_line":"        sa.LargeBinary("},{"line_number":252,"context_line":"            length\u003d__maxsize__),"},{"line_number":253,"context_line":"        nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_8f694e8d","line":250,"in_reply_to":"9f560f44_af3c4830","updated":"2020-09-25 09:41:59.000000000","message":"As defined in chapter 5.5.3.12 in SOL003, the cardinality is defined as \"0..N\".\nIt indicates it can be set in multiple, so LargeBinary is used.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a9d377654a53cd2d7faa8745224505da84822e47","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    filter \u003d sa.Column(sa.JSON, nullable\u003dFalse)"},{"line_number":248,"context_line":"    notification_types \u003d sa.Column(sa.VARBINARY(255), nullable\u003dTrue)"},{"line_number":249,"context_line":"    notification_types_len \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":250,"context_line":"    operation_types \u003d sa.Column("},{"line_number":251,"context_line":"        sa.LargeBinary("},{"line_number":252,"context_line":"            length\u003d__maxsize__),"},{"line_number":253,"context_line":"        nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_af3c4830","line":250,"in_reply_to":"9f560f44_e54af3aa","updated":"2020-09-23 10:19:59.000000000","message":"I couldn\u0027t understand.\nIsn\u0027t this operation_types LifecycleChangeNotificationsFilter.LcmOperationType?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"8651a867a196b22b3a07bafbe21468f06c0e5696","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    operation_types_len \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"class VnfLcmOpOccs(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":258,"context_line":"                models.TimestampMixin):"},{"line_number":259,"context_line":"    \"\"\"VNF LCM OP OCCS Fields\"\"\""},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_633d12ba","line":257,"range":{"start_line":257,"start_character":6,"end_line":257,"end_character":18},"updated":"2020-08-25 04:31:49.000000000","message":"It seems that additional columns are added compared to the spec (https://opendev.org/openstack/tacker-specs/src/branch/master/specs/victoria/support-notification-api-based-on- etsi-nfv-sol, first). Which specification is correct?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"e6e2549a74129b2bf4a7450f0ef0778df67281e5","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    operation_types_len \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"class VnfLcmOpOccs(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":258,"context_line":"                models.TimestampMixin):"},{"line_number":259,"context_line":"    \"\"\"VNF LCM OP OCCS Fields\"\"\""},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_642feaf5","line":257,"range":{"start_line":257,"start_character":6,"end_line":257,"end_character":18},"in_reply_to":"9f560f44_633d12ba","updated":"2020-09-09 13:04:35.000000000","message":"There are incorrect definitions in both the spec and the code.\nActually grant_id, cancel_mode and changed_ext_connectivity are not necessary, so removed.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"497618cf7e6096846e977bf06b34e639879f6f1f","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    operation_types_len \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"class VnfLcmOpOccs(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":258,"context_line":"                models.TimestampMixin):"},{"line_number":259,"context_line":"    \"\"\"VNF LCM OP OCCS Fields\"\"\""},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_12585555","line":257,"range":{"start_line":257,"start_character":6,"end_line":257,"end_character":18},"in_reply_to":"9f560f44_642feaf5","updated":"2020-09-18 08:15:25.000000000","message":"Understood.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"}],"tacker/db/migration/alembic_migrations/versions/c47a733f425a_add_vnflcm_subscription.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":37,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":38,"context_line":"    op.create_table("},{"line_number":39,"context_line":"        \u0027vnf_lcm_subscriptions\u0027,"},{"line_number":40,"context_line":"        sa.Column(\u0027id\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"},{"line_number":41,"context_line":"        sa.Column(\u0027callback_uri\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":42,"context_line":"        sa.Column(\u0027subscription_authentication\u0027, sa.JSON(), nullable\u003dTrue),"},{"line_number":43,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime(), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6b6bbbf0","line":40,"updated":"2020-09-01 17:51:01.000000000","message":"This schema is failed for \"NameError: name \u0027types\u0027 is not defined\" in functional test. It looks you need to import from `tacker.db`.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":37,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":38,"context_line":"    op.create_table("},{"line_number":39,"context_line":"        \u0027vnf_lcm_subscriptions\u0027,"},{"line_number":40,"context_line":"        sa.Column(\u0027id\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"},{"line_number":41,"context_line":"        sa.Column(\u0027callback_uri\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":42,"context_line":"        sa.Column(\u0027subscription_authentication\u0027, sa.JSON(), nullable\u003dTrue),"},{"line_number":43,"context_line":"        sa.Column(\u0027created_at\u0027, sa.DateTime(), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c99b5d70","line":40,"in_reply_to":"9f560f44_6b6bbbf0","updated":"2020-09-11 12:15:38.000000000","message":"Modified to import from tacker.db.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"eb3e8e9ebcb5939158aeaf6833d03db2fe00bfdd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"import sqlalchemy as sa"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from tacker.db import migration"},{"line_number":35,"context_line":"from tacker.db import types"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_299e26b7","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":31},"updated":"2020-09-12 11:23:44.000000000","message":"This seems not needed.","commit_id":"6235b170d74f115ae88f94409b11ec2563fbd9ae"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"6026b6e2df6598810e3902e4f396b7b987e40962","unresolved":false,"context_lines":[{"line_number":31,"context_line":"import sqlalchemy as sa"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from tacker.db import migration"},{"line_number":35,"context_line":"from tacker.db import types"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_f6f6b95d","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":31},"in_reply_to":"9f560f44_299e26b7","updated":"2020-09-14 20:25:30.000000000","message":"It is removed.","commit_id":"6235b170d74f115ae88f94409b11ec2563fbd9ae"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"eb3e8e9ebcb5939158aeaf6833d03db2fe00bfdd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":49,"context_line":"    )"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    op.create_table("},{"line_number":52,"context_line":"        \u0027vnf_lcm_filters\u0027,"},{"line_number":53,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, autoincrement\u003dTrue, nullable\u003dFalse),"},{"line_number":54,"context_line":"        sa.Column(\u0027subscription_uuid\u0027, sa.String(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_e9af0edd","line":51,"updated":"2020-09-12 11:23:44.000000000","message":"This definition of column looks different from spec, is it correct?","commit_id":"6235b170d74f115ae88f94409b11ec2563fbd9ae"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"6026b6e2df6598810e3902e4f396b7b987e40962","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":49,"context_line":"    )"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    op.create_table("},{"line_number":52,"context_line":"        \u0027vnf_lcm_filters\u0027,"},{"line_number":53,"context_line":"        sa.Column(\u0027id\u0027, sa.Integer, autoincrement\u003dTrue, nullable\u003dFalse),"},{"line_number":54,"context_line":"        sa.Column(\u0027subscription_uuid\u0027, sa.String(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_76a0e943","line":51,"in_reply_to":"9f560f44_e9af0edd","updated":"2020-09-14 20:25:30.000000000","message":"Modified with the correct definition.","commit_id":"6235b170d74f115ae88f94409b11ec2563fbd9ae"}],"tacker/objects/vnf_lcm_subscriptions.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7d27c6dd8b7d301da1b43fe651b470ddca3f0efb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    try:"},{"line_number":118,"context_line":"        result \u003d context.session.execute(sql, {\u0027subsc_id\u0027: subscriptionId})"},{"line_number":119,"context_line":"        for line in result:"},{"line_number":120,"context_line":"            result_line \u003d line"},{"line_number":121,"context_line":"    except exceptions.NotFound:"},{"line_number":122,"context_line":"        return \u0027\u0027"},{"line_number":123,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f535b4db","line":120,"updated":"2020-08-19 05:22:28.000000000","message":"If multiple elements are stored in result, the last element is always assigned to result_line.\nWhat is the purpose of this \u0027for\u0027 statement?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"be92ee32ad8478379656b1f3c820961593f60271","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    try:"},{"line_number":118,"context_line":"        result \u003d context.session.execute(sql, {\u0027subsc_id\u0027: subscriptionId})"},{"line_number":119,"context_line":"        for line in result:"},{"line_number":120,"context_line":"            result_line \u003d line"},{"line_number":121,"context_line":"    except exceptions.NotFound:"},{"line_number":122,"context_line":"        return \u0027\u0027"},{"line_number":123,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_169e5f06","line":120,"in_reply_to":"9f560f44_f535b4db","updated":"2020-09-04 13:17:00.000000000","message":"It has been deleted.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7d27c6dd8b7d301da1b43fe651b470ddca3f0efb","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    try:"},{"line_number":158,"context_line":"        result \u003d context.session.execute(sql, {\u0027subsc_id\u0027: subscriptionsId})"},{"line_number":159,"context_line":"        for line in result:"},{"line_number":160,"context_line":"            result_line \u003d line"},{"line_number":161,"context_line":"    except exceptions.NotFound:"},{"line_number":162,"context_line":"        return \u0027\u0027"},{"line_number":163,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_8aac1736","line":160,"updated":"2020-08-19 05:22:28.000000000","message":"If multiple elements are stored in result, the last element is always assigned to result_line.\nWhat is the purpose of this \u0027for\u0027 statement?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"380a30a0792c1dd0b257d85aaf181debee059e19","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    try:"},{"line_number":158,"context_line":"        result \u003d context.session.execute(sql, {\u0027subsc_id\u0027: subscriptionsId})"},{"line_number":159,"context_line":"        for line in result:"},{"line_number":160,"context_line":"            result_line \u003d line"},{"line_number":161,"context_line":"    except exceptions.NotFound:"},{"line_number":162,"context_line":"        return \u0027\u0027"},{"line_number":163,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_06fbbf7a","line":160,"in_reply_to":"9f560f44_6928baed","updated":"2020-09-22 00:41:03.000000000","message":"It is deleted.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"be92ee32ad8478379656b1f3c820961593f60271","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    try:"},{"line_number":158,"context_line":"        result \u003d context.session.execute(sql, {\u0027subsc_id\u0027: subscriptionsId})"},{"line_number":159,"context_line":"        for line in result:"},{"line_number":160,"context_line":"            result_line \u003d line"},{"line_number":161,"context_line":"    except exceptions.NotFound:"},{"line_number":162,"context_line":"        return \u0027\u0027"},{"line_number":163,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f60f6b85","line":160,"in_reply_to":"9f560f44_8aac1736","updated":"2020-09-04 13:17:00.000000000","message":"It has been deleted.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fa1973075b14f52a1fe2d605639510de4db54369","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    try:"},{"line_number":158,"context_line":"        result \u003d context.session.execute(sql, {\u0027subsc_id\u0027: subscriptionsId})"},{"line_number":159,"context_line":"        for line in result:"},{"line_number":160,"context_line":"            result_line \u003d line"},{"line_number":161,"context_line":"    except exceptions.NotFound:"},{"line_number":162,"context_line":"        return \u0027\u0027"},{"line_number":163,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_6928baed","line":160,"in_reply_to":"9f560f44_f60f6b85","updated":"2020-09-18 08:06:21.000000000","message":"It doesn\u0027t seem to have been deleted.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48e3264c4983f72e0c71ec514e52c6582a0d7125","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            new_entries.append({\"id\": values.id,"},{"line_number":234,"context_line":"                                \"callback_uri\": values.callback_uri})"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if new_entries:"},{"line_number":237,"context_line":"            context.session.execute("},{"line_number":238,"context_line":"                models.VnfLcmSubscriptions.__table__.insert(None),"},{"line_number":239,"context_line":"                new_entries)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_025f7441","line":236,"updated":"2020-08-17 09:59:11.000000000","message":"I think this is unnecessary because this if branch always passes.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            new_entries.append({\"id\": values.id,"},{"line_number":234,"context_line":"                                \"callback_uri\": values.callback_uri})"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if new_entries:"},{"line_number":237,"context_line":"            context.session.execute("},{"line_number":238,"context_line":"                models.VnfLcmSubscriptions.__table__.insert(None),"},{"line_number":239,"context_line":"                new_entries)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_d1d90485","line":236,"in_reply_to":"9f560f44_025f7441","updated":"2020-08-28 12:52:41.000000000","message":"Deleted unnecessary LOG output process. Please expect it in patch 3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"380a30a0792c1dd0b257d85aaf181debee059e19","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            new_entries.append({\"id\": values.id,"},{"line_number":234,"context_line":"                                \"callback_uri\": values.callback_uri})"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if new_entries:"},{"line_number":237,"context_line":"            context.session.execute("},{"line_number":238,"context_line":"                models.VnfLcmSubscriptions.__table__.insert(None),"},{"line_number":239,"context_line":"                new_entries)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c629c7f2","line":236,"in_reply_to":"9f560f44_2946c2c1","updated":"2020-09-22 00:41:03.000000000","message":"It is fixed.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fa1973075b14f52a1fe2d605639510de4db54369","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            new_entries.append({\"id\": values.id,"},{"line_number":234,"context_line":"                                \"callback_uri\": values.callback_uri})"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if new_entries:"},{"line_number":237,"context_line":"            context.session.execute("},{"line_number":238,"context_line":"                models.VnfLcmSubscriptions.__table__.insert(None),"},{"line_number":239,"context_line":"                new_entries)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_2946c2c1","line":236,"in_reply_to":"9f560f44_d1d90485","updated":"2020-09-18 08:06:21.000000000","message":"It doesn\u0027t seem to have been fixed.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7d27c6dd8b7d301da1b43fe651b470ddca3f0efb","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            vnf_lcm_subscriptions_id \u003d _vnf_lcm_subscriptions_id_get(context,"},{"line_number":259,"context_line":"                                            callbackUri)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            if vnf_lcm_subscriptions_id:"},{"line_number":262,"context_line":"                raise Exception(\"303\" + vnf_lcm_subscriptions_id.id.decode())"},{"line_number":263,"context_line":"            _add_filter_data(context, values.id, {})"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_3560cca5","line":261,"updated":"2020-08-19 05:22:28.000000000","message":"If filter does not exist, is it possible that it will be 303?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"757760cc8d7cf700524dbcc50edb012a9c5e26fc","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            vnf_lcm_subscriptions_id \u003d _vnf_lcm_subscriptions_id_get(context,"},{"line_number":259,"context_line":"                                            callbackUri)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            if vnf_lcm_subscriptions_id:"},{"line_number":262,"context_line":"                raise Exception(\"303\" + vnf_lcm_subscriptions_id.id.decode())"},{"line_number":263,"context_line":"            _add_filter_data(context, values.id, {})"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f37e4b68","line":261,"in_reply_to":"9f560f44_3560cca5","updated":"2020-09-07 00:42:18.000000000","message":"Since filter is not required, 303 may be set even if there is no filter.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d4c1674ab29bf4a940946ce4280cc6a405b19e19","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                raise Exception(\"303\" + vnf_lcm_subscriptions_id.id.decode())"},{"line_number":263,"context_line":"            _add_filter_data(context, values.id, {})"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    # return vnf_lcm_subscriptions"},{"line_number":266,"context_line":"    return values"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_5ff2e370","line":265,"updated":"2020-08-17 06:46:35.000000000","message":"I think this is an unnecessary comment out, so please delete it.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                raise Exception(\"303\" + vnf_lcm_subscriptions_id.id.decode())"},{"line_number":263,"context_line":"            _add_filter_data(context, values.id, {})"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    # return vnf_lcm_subscriptions"},{"line_number":266,"context_line":"    return values"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_4b7385b5","line":265,"in_reply_to":"9f560f44_5ff2e370","updated":"2020-08-28 12:52:41.000000000","message":"Deleted the unnecessary comment. Please expect it in Patch 3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7d27c6dd8b7d301da1b43fe651b470ddca3f0efb","unresolved":false,"context_lines":[{"line_number":269,"context_line":"@db_api.context_manager.writer"},{"line_number":270,"context_line":"def _destroy_vnf_lcm_subscription(context, subscriptionId):"},{"line_number":271,"context_line":"    now \u003d timeutils.utcnow()"},{"line_number":272,"context_line":"    updated_values \u003d {\u0027deleted\u0027: True,"},{"line_number":273,"context_line":"                      \u0027deleted_at\u0027: now}"},{"line_number":274,"context_line":"    try:"},{"line_number":275,"context_line":"        api.model_query(context, models.VnfLcmSubscriptions). \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_7509a42a","line":272,"updated":"2020-08-19 05:22:28.000000000","message":"I think \u0027deleted\u0027: 1 is correct.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":269,"context_line":"@db_api.context_manager.writer"},{"line_number":270,"context_line":"def _destroy_vnf_lcm_subscription(context, subscriptionId):"},{"line_number":271,"context_line":"    now \u003d timeutils.utcnow()"},{"line_number":272,"context_line":"    updated_values \u003d {\u0027deleted\u0027: True,"},{"line_number":273,"context_line":"                      \u0027deleted_at\u0027: now}"},{"line_number":274,"context_line":"    try:"},{"line_number":275,"context_line":"        api.model_query(context, models.VnfLcmSubscriptions). \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b144501b","line":272,"in_reply_to":"9f560f44_7509a42a","updated":"2020-08-28 12:52:41.000000000","message":"Changed to True \u003d\u003e 1. Pleas expect it in patch3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d4c1674ab29bf4a940946ce4280cc6a405b19e19","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @base.remotable"},{"line_number":297,"context_line":"    def create(self, filter):"},{"line_number":298,"context_line":"        # def create(self):"},{"line_number":299,"context_line":"        updates \u003d self.obj_clone()"},{"line_number":300,"context_line":"        # filter \u003d updates.pop(\u0027filter\u0027, None)"},{"line_number":301,"context_line":"        db_vnf_lcm_subscriptions \u003d _vnf_lcm_subscriptions_create("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_bfe97f81","line":298,"updated":"2020-08-17 06:46:35.000000000","message":"I think this is an unnecessary comment out, so please delete it.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @base.remotable"},{"line_number":297,"context_line":"    def create(self, filter):"},{"line_number":298,"context_line":"        # def create(self):"},{"line_number":299,"context_line":"        updates \u003d self.obj_clone()"},{"line_number":300,"context_line":"        # filter \u003d updates.pop(\u0027filter\u0027, None)"},{"line_number":301,"context_line":"        db_vnf_lcm_subscriptions \u003d _vnf_lcm_subscriptions_create("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_2b78d18d","line":298,"in_reply_to":"9f560f44_bfe97f81","updated":"2020-08-28 12:52:41.000000000","message":"Deleted the unnecessary comment. Please expect it in patch3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d4c1674ab29bf4a940946ce4280cc6a405b19e19","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    def create(self, filter):"},{"line_number":298,"context_line":"        # def create(self):"},{"line_number":299,"context_line":"        updates \u003d self.obj_clone()"},{"line_number":300,"context_line":"        # filter \u003d updates.pop(\u0027filter\u0027, None)"},{"line_number":301,"context_line":"        db_vnf_lcm_subscriptions \u003d _vnf_lcm_subscriptions_create("},{"line_number":302,"context_line":"            self._context, updates, filter)"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_9fec7b90","line":300,"updated":"2020-08-17 06:46:35.000000000","message":"I think this is an unnecessary comment out, so please delete it.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    def create(self, filter):"},{"line_number":298,"context_line":"        # def create(self):"},{"line_number":299,"context_line":"        updates \u003d self.obj_clone()"},{"line_number":300,"context_line":"        # filter \u003d updates.pop(\u0027filter\u0027, None)"},{"line_number":301,"context_line":"        db_vnf_lcm_subscriptions \u003d _vnf_lcm_subscriptions_create("},{"line_number":302,"context_line":"            self._context, updates, filter)"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_8b6d9dce","line":300,"in_reply_to":"9f560f44_9fec7b90","updated":"2020-08-28 12:52:41.000000000","message":"Deleted the unnecessary comment. Please expect it in patch3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48e3264c4983f72e0c71ec514e52c6582a0d7125","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        db_vnf_lcm_subscriptions \u003d _vnf_lcm_subscriptions_create("},{"line_number":302,"context_line":"            self._context, updates, filter)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        LOG.debug("},{"line_number":305,"context_line":"            \u0027test_log: db_vnf_lcm_subscriptions %s\u0027 %"},{"line_number":306,"context_line":"            db_vnf_lcm_subscriptions)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_424facbc","line":304,"updated":"2020-08-17 09:59:11.000000000","message":"If it is unnecessary logging, delete it.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        db_vnf_lcm_subscriptions \u003d _vnf_lcm_subscriptions_create("},{"line_number":302,"context_line":"            self._context, updates, filter)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        LOG.debug("},{"line_number":305,"context_line":"            \u0027test_log: db_vnf_lcm_subscriptions %s\u0027 %"},{"line_number":306,"context_line":"            db_vnf_lcm_subscriptions)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_d1c2a486","line":304,"in_reply_to":"9f560f44_424facbc","updated":"2020-08-28 12:52:41.000000000","message":"Deleted unnecessary LOG output process. please expect it in patch3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7d27c6dd8b7d301da1b43fe651b470ddca3f0efb","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        return vnf_lcm_subscriptions"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    @base.remotable_classmethod"},{"line_number":330,"context_line":"    def vnf_lcm_subscriptions_get(cls, context,"},{"line_number":331,"context_line":"                                  notificationTypes,"},{"line_number":332,"context_line":"                                  operationTypes\u003dNone):"},{"line_number":333,"context_line":"        return _vnf_lcm_subscriptions_get(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_2bf23f70","line":330,"updated":"2020-08-19 05:22:28.000000000","message":"Seems like an unused method, is it necessary?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fa1973075b14f52a1fe2d605639510de4db54369","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        return vnf_lcm_subscriptions"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    @base.remotable_classmethod"},{"line_number":330,"context_line":"    def vnf_lcm_subscriptions_get(cls, context,"},{"line_number":331,"context_line":"                                  notificationTypes,"},{"line_number":332,"context_line":"                                  operationTypes\u003dNone):"},{"line_number":333,"context_line":"        return _vnf_lcm_subscriptions_get(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c94d86c6","line":330,"in_reply_to":"9f560f44_00a8a375","updated":"2020-09-18 08:06:21.000000000","message":"I couldn\u0027t understand where it was called from.\nPlease tell me which source code.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"e6e2549a74129b2bf4a7450f0ef0778df67281e5","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        return vnf_lcm_subscriptions"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    @base.remotable_classmethod"},{"line_number":330,"context_line":"    def vnf_lcm_subscriptions_get(cls, context,"},{"line_number":331,"context_line":"                                  notificationTypes,"},{"line_number":332,"context_line":"                                  operationTypes\u003dNone):"},{"line_number":333,"context_line":"        return _vnf_lcm_subscriptions_get(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_00a8a375","line":330,"in_reply_to":"9f560f44_2bf23f70","updated":"2020-09-09 13:04:35.000000000","message":"This function is to be called from sendNotification, so need to be defined.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"380a30a0792c1dd0b257d85aaf181debee059e19","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        return vnf_lcm_subscriptions"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    @base.remotable_classmethod"},{"line_number":330,"context_line":"    def vnf_lcm_subscriptions_get(cls, context,"},{"line_number":331,"context_line":"                                  notificationTypes,"},{"line_number":332,"context_line":"                                  operationTypes\u003dNone):"},{"line_number":333,"context_line":"        return _vnf_lcm_subscriptions_get(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_0630df54","line":330,"in_reply_to":"9f560f44_c94d86c6","updated":"2020-09-22 00:41:03.000000000","message":"It is called \"objects.VnfLcmSubscription.vnf_lcm_subscriptions_get\" in send_notification of conductor_server.py","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48e3264c4983f72e0c71ec514e52c6582a0d7125","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        try:"},{"line_number":340,"context_line":"            get_subscriptionid \u003d _get_by_subscriptionid("},{"line_number":341,"context_line":"                context, subscriptionId)"},{"line_number":342,"context_line":"        except Exception as e:"},{"line_number":343,"context_line":"            raise e"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if not get_subscriptionid:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_05277e14","line":342,"updated":"2020-08-17 09:59:11.000000000","message":"Can you define an exception class in common/exceptions.py and fix the error handling using it?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"757760cc8d7cf700524dbcc50edb012a9c5e26fc","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        try:"},{"line_number":340,"context_line":"            get_subscriptionid \u003d _get_by_subscriptionid("},{"line_number":341,"context_line":"                context, subscriptionId)"},{"line_number":342,"context_line":"        except Exception as e:"},{"line_number":343,"context_line":"            raise e"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if not get_subscriptionid:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_93b42f38","line":342,"in_reply_to":"9f560f44_05277e14","updated":"2020-09-07 00:42:18.000000000","message":"This implementation is sufficient because webob.Response is started with _make_problem_detail that sets ProblemDetails and can be shared.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                               ):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    if notificationTypes \u003d\u003d \u0027VnfLcmOperationOccurrenceNotification\u0027:"},{"line_number":56,"context_line":"        sql \u003d ("},{"line_number":57,"context_line":"            \"select\""},{"line_number":58,"context_line":"            \" t1.id,t1.callback_uri,t1.subscription_authentication,t2.filter \""},{"line_number":59,"context_line":"            \" from \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_38e58add","line":56,"updated":"2020-09-01 17:51:01.000000000","message":"Why don\u0027t use ORM like query instead of raw sql statement? It looks hard to maintain such a long one.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                               ):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    if notificationTypes \u003d\u003d \u0027VnfLcmOperationOccurrenceNotification\u0027:"},{"line_number":56,"context_line":"        sql \u003d ("},{"line_number":57,"context_line":"            \"select\""},{"line_number":58,"context_line":"            \" t1.id,t1.callback_uri,t1.subscription_authentication,t2.filter \""},{"line_number":59,"context_line":"            \" from \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c419847a","line":56,"in_reply_to":"9f560f44_38e58add","updated":"2020-09-11 12:15:38.000000000","message":"It was passed on due to the difficulty and time required for the modification.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    if isinstance(value, list):"},{"line_number":35,"context_line":"        res \u003d \"\""},{"line_number":36,"context_line":"        for i in range(len(value)):"},{"line_number":37,"context_line":"            t \u003d \u0027\"\u0027 + value[i] + \u0027\"\u0027"},{"line_number":38,"context_line":"            if i \u003d\u003d 0:"},{"line_number":39,"context_line":"                res \u003d str(t)"},{"line_number":40,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_945ce77d","line":37,"updated":"2020-09-09 16:35:47.000000000","message":"In general, you should not use `+` operator for embedding variables in a string. Use `format()` or `%` instead TO MAKE IT MORE READABLE.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    if isinstance(value, list):"},{"line_number":35,"context_line":"        res \u003d \"\""},{"line_number":36,"context_line":"        for i in range(len(value)):"},{"line_number":37,"context_line":"            t \u003d \u0027\"\u0027 + value[i] + \u0027\"\u0027"},{"line_number":38,"context_line":"            if i \u003d\u003d 0:"},{"line_number":39,"context_line":"                res \u003d str(t)"},{"line_number":40,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_c92f18a5","line":37,"in_reply_to":"9f560f44_945ce77d","updated":"2020-09-22 02:30:36.000000000","message":"Fixed as suggested.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            if i \u003d\u003d 0:"},{"line_number":39,"context_line":"                res \u003d str(t)"},{"line_number":40,"context_line":"            else:"},{"line_number":41,"context_line":"                res \u003d res + \",\" + t"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        res \u003d \"[\" + res + \"]\""},{"line_number":44,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_1448d7b0","line":41,"updated":"2020-09-09 16:35:47.000000000","message":"Same as before.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            if i \u003d\u003d 0:"},{"line_number":39,"context_line":"                res \u003d str(t)"},{"line_number":40,"context_line":"            else:"},{"line_number":41,"context_line":"                res \u003d res + \",\" + t"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        res \u003d \"[\" + res + \"]\""},{"line_number":44,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_a93464fc","line":41,"in_reply_to":"9f560f44_1448d7b0","updated":"2020-09-22 02:30:36.000000000","message":"Fixed as suggested.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            else:"},{"line_number":41,"context_line":"                res \u003d res + \",\" + t"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        res \u003d \"[\" + res + \"]\""},{"line_number":44,"context_line":"    else:"},{"line_number":45,"context_line":"        res \u003d \"[\\\"\" + str(value) + \"\\\"]\""},{"line_number":46,"context_line":"    return res"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_b4cc8b34","line":43,"updated":"2020-09-09 16:35:47.000000000","message":"Same as before.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            else:"},{"line_number":41,"context_line":"                res \u003d res + \",\" + t"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        res \u003d \"[\" + res + \"]\""},{"line_number":44,"context_line":"    else:"},{"line_number":45,"context_line":"        res \u003d \"[\\\"\" + str(value) + \"\\\"]\""},{"line_number":46,"context_line":"    return res"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_09363003","line":43,"in_reply_to":"9f560f44_b4cc8b34","updated":"2020-09-22 02:30:36.000000000","message":"Fixed as suggested.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        res \u003d \"[\" + res + \"]\""},{"line_number":44,"context_line":"    else:"},{"line_number":45,"context_line":"        res \u003d \"[\\\"\" + str(value) + \"\\\"]\""},{"line_number":46,"context_line":"    return res"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_34e07b97","line":45,"updated":"2020-09-09 16:35:47.000000000","message":"Same as before.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"16859efc7eb9a8488e0f6363abdbc2b141cdb000","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        res \u003d \"[\" + res + \"]\""},{"line_number":44,"context_line":"    else:"},{"line_number":45,"context_line":"        res \u003d \"[\\\"\" + str(value) + \"\\\"]\""},{"line_number":46,"context_line":"    return res"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_e93adce3","line":45,"in_reply_to":"9f560f44_34e07b97","updated":"2020-09-22 02:30:36.000000000","message":"Fixed as suggested.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"19dda7c3a1ff1e001f246e837744e1b5fc8bebe4","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"@db_api.context_manager.reader"},{"line_number":50,"context_line":"def _vnf_lcm_subscriptions_get(context,"},{"line_number":51,"context_line":"                               notificationTypes,"},{"line_number":52,"context_line":"                               operationTypes\u003dNone"},{"line_number":53,"context_line":"                               ):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    if notificationTypes \u003d\u003d \u0027VnfLcmOperationOccurrenceNotification\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_48744236","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":50},"updated":"2020-09-11 16:11:42.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fba964676923ec88602def9b9014f5f278146a45","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"@db_api.context_manager.reader"},{"line_number":50,"context_line":"def _vnf_lcm_subscriptions_get(context,"},{"line_number":51,"context_line":"                               notificationTypes,"},{"line_number":52,"context_line":"                               operationTypes\u003dNone"},{"line_number":53,"context_line":"                               ):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    if notificationTypes \u003d\u003d \u0027VnfLcmOperationOccurrenceNotification\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_578fb621","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":50},"in_reply_to":"9f560f44_48744236","updated":"2020-09-12 02:47:32.000000000","message":"It is fixed.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64621f2f9c5758edc2f6a16f4ebacaa7abf9e63b","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    if notificationTypes \u003d\u003d \u0027VnfLcmOperationOccurrenceNotification\u0027:"},{"line_number":56,"context_line":"        sql \u003d ("},{"line_number":57,"context_line":"            \"select\""},{"line_number":58,"context_line":"            \" t1.id,t1.callback_uri,t1.subscription_authentication,t2.filter \""},{"line_number":59,"context_line":"            \" from \""},{"line_number":60,"context_line":"            \" vnf_lcm_subscriptions t1, \""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_f402833d","line":57,"updated":"2020-09-09 16:35:47.000000000","message":"Why don\u0027t you use OR mapping instead of raw SQL?","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    if notificationTypes \u003d\u003d \u0027VnfLcmOperationOccurrenceNotification\u0027:"},{"line_number":56,"context_line":"        sql \u003d ("},{"line_number":57,"context_line":"            \"select\""},{"line_number":58,"context_line":"            \" t1.id,t1.callback_uri,t1.subscription_authentication,t2.filter \""},{"line_number":59,"context_line":"            \" from \""},{"line_number":60,"context_line":"            \" vnf_lcm_subscriptions t1, \""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_a4145042","line":57,"in_reply_to":"9f560f44_f402833d","updated":"2020-09-11 12:15:38.000000000","message":"It was passed on due to the difficulty and time required for the modification.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"19dda7c3a1ff1e001f246e837744e1b5fc8bebe4","unresolved":false,"context_lines":[{"line_number":166,"context_line":"@db_api.context_manager.reader"},{"line_number":167,"context_line":"def _vnf_lcm_subscriptions_id_get(context,"},{"line_number":168,"context_line":"                                  callbackUri,"},{"line_number":169,"context_line":"                                  notificationTypes\u003dNone,"},{"line_number":170,"context_line":"                                  operationTypes\u003dNone"},{"line_number":171,"context_line":"                                  ):"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    sql \u003d (\"select \""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_c895f233","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":53},"updated":"2020-09-11 16:11:42.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fba964676923ec88602def9b9014f5f278146a45","unresolved":false,"context_lines":[{"line_number":166,"context_line":"@db_api.context_manager.reader"},{"line_number":167,"context_line":"def _vnf_lcm_subscriptions_id_get(context,"},{"line_number":168,"context_line":"                                  callbackUri,"},{"line_number":169,"context_line":"                                  notificationTypes\u003dNone,"},{"line_number":170,"context_line":"                                  operationTypes\u003dNone"},{"line_number":171,"context_line":"                                  ):"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    sql \u003d (\"select \""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_9795ce34","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":53},"in_reply_to":"9f560f44_c895f233","updated":"2020-09-12 02:47:32.000000000","message":"It is fixed.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"19dda7c3a1ff1e001f246e837744e1b5fc8bebe4","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        callbackUri \u003d values.callback_uri"},{"line_number":238,"context_line":"        if filter:"},{"line_number":239,"context_line":"            notificationTypes \u003d filter.get(\u0027notificationTypes\u0027)"},{"line_number":240,"context_line":"            operationTypes \u003d filter.get(\u0027operationTypes\u0027)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"            vnf_lcm_subscriptions_id \u003d _vnf_lcm_subscriptions_id_get("}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_a8987e68","line":239,"range":{"start_line":239,"start_character":12,"end_line":239,"end_character":29},"updated":"2020-09-11 16:11:42.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fba964676923ec88602def9b9014f5f278146a45","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        callbackUri \u003d values.callback_uri"},{"line_number":238,"context_line":"        if filter:"},{"line_number":239,"context_line":"            notificationTypes \u003d filter.get(\u0027notificationTypes\u0027)"},{"line_number":240,"context_line":"            operationTypes \u003d filter.get(\u0027operationTypes\u0027)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"            vnf_lcm_subscriptions_id \u003d _vnf_lcm_subscriptions_id_get("}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_7798fa67","line":239,"range":{"start_line":239,"start_character":12,"end_line":239,"end_character":29},"in_reply_to":"9f560f44_a8987e68","updated":"2020-09-12 02:47:32.000000000","message":"It is fixed.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"19dda7c3a1ff1e001f246e837744e1b5fc8bebe4","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        callbackUri \u003d values.callback_uri"},{"line_number":238,"context_line":"        if filter:"},{"line_number":239,"context_line":"            notificationTypes \u003d filter.get(\u0027notificationTypes\u0027)"},{"line_number":240,"context_line":"            operationTypes \u003d filter.get(\u0027operationTypes\u0027)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"            vnf_lcm_subscriptions_id \u003d _vnf_lcm_subscriptions_id_get("},{"line_number":243,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_e89d5657","line":240,"range":{"start_line":240,"start_character":12,"end_line":240,"end_character":26},"updated":"2020-09-11 16:11:42.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fba964676923ec88602def9b9014f5f278146a45","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        callbackUri \u003d values.callback_uri"},{"line_number":238,"context_line":"        if filter:"},{"line_number":239,"context_line":"            notificationTypes \u003d filter.get(\u0027notificationTypes\u0027)"},{"line_number":240,"context_line":"            operationTypes \u003d filter.get(\u0027operationTypes\u0027)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"            vnf_lcm_subscriptions_id \u003d _vnf_lcm_subscriptions_id_get("},{"line_number":243,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_d7a2a699","line":240,"range":{"start_line":240,"start_character":12,"end_line":240,"end_character":26},"in_reply_to":"9f560f44_e89d5657","updated":"2020-09-12 02:47:32.000000000","message":"It is fixed.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"19dda7c3a1ff1e001f246e837744e1b5fc8bebe4","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    @base.remotable_classmethod"},{"line_number":318,"context_line":"    def vnf_lcm_subscriptions_get(cls, context,"},{"line_number":319,"context_line":"                                  notificationTypes,"},{"line_number":320,"context_line":"                                  operationTypes\u003dNone):"},{"line_number":321,"context_line":"        return _vnf_lcm_subscriptions_get(context,"},{"line_number":322,"context_line":"                                          notificationTypes,"},{"line_number":323,"context_line":"                                          operationTypes)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_28a46ea2","line":320,"range":{"start_line":319,"start_character":0,"end_line":320,"end_character":55},"updated":"2020-09-11 16:11:42.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fba964676923ec88602def9b9014f5f278146a45","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    @base.remotable_classmethod"},{"line_number":318,"context_line":"    def vnf_lcm_subscriptions_get(cls, context,"},{"line_number":319,"context_line":"                                  notificationTypes,"},{"line_number":320,"context_line":"                                  operationTypes\u003dNone):"},{"line_number":321,"context_line":"        return _vnf_lcm_subscriptions_get(context,"},{"line_number":322,"context_line":"                                          notificationTypes,"},{"line_number":323,"context_line":"                                          operationTypes)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_b79d7258","line":320,"range":{"start_line":319,"start_character":0,"end_line":320,"end_character":55},"in_reply_to":"9f560f44_28a46ea2","updated":"2020-09-12 02:47:32.000000000","message":"It is fixed.","commit_id":"d77c3e152c07a97a0665a33dee92fdb12ed9d97a"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"497618cf7e6096846e977bf06b34e639879f6f1f","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":276,"context_line":"class VnfLcmSubscription(base.TackerObject, base.TackerPersistentObject):"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    # Version 1.0: Initial version"},{"line_number":279,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_44b83dc6","line":276,"range":{"start_line":276,"start_character":6,"end_line":276,"end_character":24},"updated":"2020-09-18 08:15:25.000000000","message":"The class name can align with other class description such as LccnSubscription.","commit_id":"05e40b8951f0ab8be70cef8a34cbc7aba385dbc3"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"380a30a0792c1dd0b257d85aaf181debee059e19","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":276,"context_line":"class VnfLcmSubscription(base.TackerObject, base.TackerPersistentObject):"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    # Version 1.0: Initial version"},{"line_number":279,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_c6770708","line":276,"range":{"start_line":276,"start_character":6,"end_line":276,"end_character":24},"in_reply_to":"9f560f44_44b83dc6","updated":"2020-09-22 00:41:03.000000000","message":"Changed the class name to LccnSubscription","commit_id":"05e40b8951f0ab8be70cef8a34cbc7aba385dbc3"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"497618cf7e6096846e977bf06b34e639879f6f1f","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    fields \u003d {"},{"line_number":282,"context_line":"        \u0027id\u0027: fields.UUIDField(nullable\u003dFalse),"},{"line_number":283,"context_line":"        \u0027callback_uri\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":284,"context_line":"        \u0027subscription_authentication\u0027:"},{"line_number":285,"context_line":"            fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":286,"context_line":"        \u0027filter\u0027: fields.StringField(nullable\u003dTrue)"},{"line_number":287,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_a496793d","line":284,"range":{"start_line":284,"start_character":9,"end_line":284,"end_character":36},"updated":"2020-09-18 08:15:25.000000000","message":"According to ETSI NFV SOL003, SubscriptionAuthentication is located in Type:LccnSubscriptionRequest. If this class defines Type:LccnSubscription objects, this should be removed and new class for LccnSubscriptionRequet should be defined.","commit_id":"05e40b8951f0ab8be70cef8a34cbc7aba385dbc3"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ea9f10e639b9d86c261958efd41afe036b044a10","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    fields \u003d {"},{"line_number":282,"context_line":"        \u0027id\u0027: fields.UUIDField(nullable\u003dFalse),"},{"line_number":283,"context_line":"        \u0027callback_uri\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":284,"context_line":"        \u0027subscription_authentication\u0027:"},{"line_number":285,"context_line":"            fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":286,"context_line":"        \u0027filter\u0027: fields.StringField(nullable\u003dTrue)"},{"line_number":287,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_c4bdfa68","line":284,"range":{"start_line":284,"start_character":9,"end_line":284,"end_character":36},"in_reply_to":"9f560f44_62408760","updated":"2020-09-24 18:33:19.000000000","message":"As defined in SOL003 5.5.3.12, Cardinality is defined as 0..N, and multiple settings can be made, so it is set as Large Binary.","commit_id":"05e40b8951f0ab8be70cef8a34cbc7aba385dbc3"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"06153a1d2d46eb1b77d8fdeeaa2021a6cf0812e2","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    fields \u003d {"},{"line_number":282,"context_line":"        \u0027id\u0027: fields.UUIDField(nullable\u003dFalse),"},{"line_number":283,"context_line":"        \u0027callback_uri\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":284,"context_line":"        \u0027subscription_authentication\u0027:"},{"line_number":285,"context_line":"            fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":286,"context_line":"        \u0027filter\u0027: fields.StringField(nullable\u003dTrue)"},{"line_number":287,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_0b553150","line":284,"range":{"start_line":284,"start_character":9,"end_line":284,"end_character":36},"in_reply_to":"9f560f44_8f5f8e0d","updated":"2020-09-25 11:10:34.000000000","message":"Sorry for incorrect comment. Answered it.\nAs for Kuriu-san\u0027s question here, fixed as pointed out.","commit_id":"05e40b8951f0ab8be70cef8a34cbc7aba385dbc3"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ca3672b2207e607effa0be6efe963b8e78923bf0","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    fields \u003d {"},{"line_number":282,"context_line":"        \u0027id\u0027: fields.UUIDField(nullable\u003dFalse),"},{"line_number":283,"context_line":"        \u0027callback_uri\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":284,"context_line":"        \u0027subscription_authentication\u0027:"},{"line_number":285,"context_line":"            fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":286,"context_line":"        \u0027filter\u0027: fields.StringField(nullable\u003dTrue)"},{"line_number":287,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_e5f8334b","line":284,"range":{"start_line":284,"start_character":9,"end_line":284,"end_character":36},"in_reply_to":"9f560f44_a496793d","updated":"2020-09-22 15:20:20.000000000","message":"On this timing, There is a risk for merge.\nWe propose refactoring in the W version.","commit_id":"05e40b8951f0ab8be70cef8a34cbc7aba385dbc3"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"feab68ac03714461eb86bcd53d4c6a179b52362e","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    fields \u003d {"},{"line_number":282,"context_line":"        \u0027id\u0027: fields.UUIDField(nullable\u003dFalse),"},{"line_number":283,"context_line":"        \u0027callback_uri\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":284,"context_line":"        \u0027subscription_authentication\u0027:"},{"line_number":285,"context_line":"            fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":286,"context_line":"        \u0027filter\u0027: fields.StringField(nullable\u003dTrue)"},{"line_number":287,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_8f5f8e0d","line":284,"range":{"start_line":284,"start_character":9,"end_line":284,"end_character":36},"in_reply_to":"9f560f44_c4bdfa68","updated":"2020-09-25 09:31:58.000000000","message":"I think this is the answer to my comment below.\nhttps://review.opendev.org/#/c/745428/2/tacker/db/db_sqlalchemy/models.py@250\nIf so, please answer there.","commit_id":"05e40b8951f0ab8be70cef8a34cbc7aba385dbc3"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"536d9a5d36383e2f88c575973146a8c95f85b80f","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    fields \u003d {"},{"line_number":282,"context_line":"        \u0027id\u0027: fields.UUIDField(nullable\u003dFalse),"},{"line_number":283,"context_line":"        \u0027callback_uri\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":284,"context_line":"        \u0027subscription_authentication\u0027:"},{"line_number":285,"context_line":"            fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":286,"context_line":"        \u0027filter\u0027: fields.StringField(nullable\u003dTrue)"},{"line_number":287,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_62408760","line":284,"range":{"start_line":284,"start_character":9,"end_line":284,"end_character":36},"in_reply_to":"9f560f44_e5f8334b","updated":"2020-09-23 11:28:47.000000000","message":"I could not understand the reason why this change causes the risk. At least, to align with other code style, the LccnSubscriptionRequest should be defined.","commit_id":"05e40b8951f0ab8be70cef8a34cbc7aba385dbc3"}],"tacker/tests/unit/conductor/test_conductor_server.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d4c1674ab29bf4a940946ce4280cc6a405b19e19","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_get_vnf_package_vnfd_with_tosca_meta_file_in_csar(self):"},{"line_number":137,"context_line":"        fake_csar \u003d fakes.create_fake_csar_dir(self.vnf_package.id,"},{"line_number":138,"context_line":"            self.temp_dir)"},{"line_number":139,"context_line":"        expected_data \u003d fakes.get_expected_vnfd_data()"},{"line_number":140,"context_line":"        result \u003d self.conductor.get_vnf_package_vnfd(self.context,"},{"line_number":141,"context_line":"                                                     self.vnf_package)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_1feb4bdc","line":138,"updated":"2020-08-17 06:46:35.000000000","message":"Do you need to modify this file?\nThe code looks essentially unchanged.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_get_vnf_package_vnfd_with_tosca_meta_file_in_csar(self):"},{"line_number":137,"context_line":"        fake_csar \u003d fakes.create_fake_csar_dir(self.vnf_package.id,"},{"line_number":138,"context_line":"            self.temp_dir)"},{"line_number":139,"context_line":"        expected_data \u003d fakes.get_expected_vnfd_data()"},{"line_number":140,"context_line":"        result \u003d self.conductor.get_vnf_package_vnfd(self.context,"},{"line_number":141,"context_line":"                                                     self.vnf_package)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_71ad989a","line":138,"in_reply_to":"9f560f44_1feb4bdc","updated":"2020-08-28 12:52:41.000000000","message":"Reverted due to unnecessary changes. Please expect it in Patch 3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    def test_get_vnf_package_vnfd_with_tosca_meta_file_in_csar(self):"},{"line_number":137,"context_line":"        fake_csar \u003d fakes.create_fake_csar_dir(self.vnf_package.id,"},{"line_number":138,"context_line":"                                               self.temp_dir)"},{"line_number":139,"context_line":"        expected_data \u003d fakes.get_expected_vnfd_data()"},{"line_number":140,"context_line":"        result \u003d self.conductor.get_vnf_package_vnfd(self.context,"},{"line_number":141,"context_line":"                                                     self.vnf_package)"},{"line_number":142,"context_line":"        self.assertEqual(expected_data, result)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b357fd26","line":139,"updated":"2020-09-01 17:51:01.000000000","message":"It looks no need to be changed, right?","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    def test_get_vnf_package_vnfd_with_tosca_meta_file_in_csar(self):"},{"line_number":137,"context_line":"        fake_csar \u003d fakes.create_fake_csar_dir(self.vnf_package.id,"},{"line_number":138,"context_line":"                                               self.temp_dir)"},{"line_number":139,"context_line":"        expected_data \u003d fakes.get_expected_vnfd_data()"},{"line_number":140,"context_line":"        result \u003d self.conductor.get_vnf_package_vnfd(self.context,"},{"line_number":141,"context_line":"                                                     self.vnf_package)"},{"line_number":142,"context_line":"        self.assertEqual(expected_data, result)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6437d8e4","line":139,"in_reply_to":"9f560f44_b357fd26","updated":"2020-09-11 12:15:38.000000000","message":"Reverted.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        vnf_instance.create()"},{"line_number":238,"context_line":"        instantiate_vnf_req \u003d vnflcm_fakes.get_instantiate_vnf_request_obj()"},{"line_number":239,"context_line":"        self.conductor.instantiate(self.context, vnf_instance,"},{"line_number":240,"context_line":"                instantiate_vnf_req)"},{"line_number":241,"context_line":"        self.vnflcm_driver.instantiate_vnf.assert_not_called()"},{"line_number":242,"context_line":"        mock_package_in_use.assert_not_called()"},{"line_number":243,"context_line":"        expected_log \u003d \u0027Vnf instance %(id)s is already in %(state)s state.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f32e95a9","line":240,"updated":"2020-09-01 17:51:01.000000000","message":"No need to be changed.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        vnf_instance.create()"},{"line_number":238,"context_line":"        instantiate_vnf_req \u003d vnflcm_fakes.get_instantiate_vnf_request_obj()"},{"line_number":239,"context_line":"        self.conductor.instantiate(self.context, vnf_instance,"},{"line_number":240,"context_line":"                instantiate_vnf_req)"},{"line_number":241,"context_line":"        self.vnflcm_driver.instantiate_vnf.assert_not_called()"},{"line_number":242,"context_line":"        mock_package_in_use.assert_not_called()"},{"line_number":243,"context_line":"        expected_log \u003d \u0027Vnf instance %(id)s is already in %(state)s state.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c43224f2","line":240,"in_reply_to":"9f560f44_f32e95a9","updated":"2020-09-11 12:15:38.000000000","message":"Reverted.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fa1973075b14f52a1fe2d605639510de4db54369","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        vnf_instance.create()"},{"line_number":218,"context_line":"        instantiate_vnf_req \u003d vnflcm_fakes.get_instantiate_vnf_request_obj()"},{"line_number":219,"context_line":"        self.conductor.instantiate(self.context, vnf_instance,"},{"line_number":220,"context_line":"                                   instantiate_vnf_req)"},{"line_number":221,"context_line":"        self.vnflcm_driver.instantiate_vnf.assert_called_once_with("},{"line_number":222,"context_line":"            self.context, mock.ANY, instantiate_vnf_req)"},{"line_number":223,"context_line":"        mock_package_in_use.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_c9d2a6cf","side":"PARENT","line":220,"range":{"start_line":220,"start_character":16,"end_line":220,"end_character":34},"updated":"2020-09-18 08:06:21.000000000","message":"There is only a fix to change the indent, isn\u0027t it unnecessary?","commit_id":"dd96678969945665a9e0ff315a833db8dcf64041"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"380a30a0792c1dd0b257d85aaf181debee059e19","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        vnf_instance.create()"},{"line_number":218,"context_line":"        instantiate_vnf_req \u003d vnflcm_fakes.get_instantiate_vnf_request_obj()"},{"line_number":219,"context_line":"        self.conductor.instantiate(self.context, vnf_instance,"},{"line_number":220,"context_line":"                                   instantiate_vnf_req)"},{"line_number":221,"context_line":"        self.vnflcm_driver.instantiate_vnf.assert_called_once_with("},{"line_number":222,"context_line":"            self.context, mock.ANY, instantiate_vnf_req)"},{"line_number":223,"context_line":"        mock_package_in_use.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_a61773a3","side":"PARENT","line":220,"range":{"start_line":220,"start_character":16,"end_line":220,"end_character":34},"in_reply_to":"9f560f44_c9d2a6cf","updated":"2020-09-22 00:41:03.000000000","message":"Indent is fixed.","commit_id":"dd96678969945665a9e0ff315a833db8dcf64041"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a9d377654a53cd2d7faa8745224505da84822e47","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        vnf_instance.create()"},{"line_number":259,"context_line":"        instantiate_vnf_req \u003d vnflcm_fakes.get_instantiate_vnf_request_obj()"},{"line_number":260,"context_line":"        self.conductor.instantiate(self.context, vnf_instance,"},{"line_number":261,"context_line":"                instantiate_vnf_req)"},{"line_number":262,"context_line":"        self.vnflcm_driver.instantiate_vnf.assert_called_once_with("},{"line_number":263,"context_line":"            self.context, mock.ANY, instantiate_vnf_req)"},{"line_number":264,"context_line":"        mock_vnf_package_in_use.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_4f82ccc8","line":261,"updated":"2020-09-23 10:19:59.000000000","message":"There is only a fix to change the indent, isn\u0027t it unnecessary?","commit_id":"258456dad720a82b60ee57760734547ac0589990"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"492546e7482f51883eaaf44ee7e57ead38b9cd22","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        vnf_instance.create()"},{"line_number":259,"context_line":"        instantiate_vnf_req \u003d vnflcm_fakes.get_instantiate_vnf_request_obj()"},{"line_number":260,"context_line":"        self.conductor.instantiate(self.context, vnf_instance,"},{"line_number":261,"context_line":"                instantiate_vnf_req)"},{"line_number":262,"context_line":"        self.vnflcm_driver.instantiate_vnf.assert_called_once_with("},{"line_number":263,"context_line":"            self.context, mock.ANY, instantiate_vnf_req)"},{"line_number":264,"context_line":"        mock_vnf_package_in_use.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_19c8eca5","line":261,"in_reply_to":"9f560f44_4f82ccc8","updated":"2020-09-25 08:23:55.000000000","message":"It is fixed.","commit_id":"258456dad720a82b60ee57760734547ac0589990"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a9d377654a53cd2d7faa8745224505da84822e47","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        instantiate_vnf_req \u003d vnflcm_fakes.get_instantiate_vnf_request_obj()"},{"line_number":278,"context_line":"        mock_is_package_in_use.side_effect \u003d Exception"},{"line_number":279,"context_line":"        self.conductor.instantiate(self.context, vnf_instance,"},{"line_number":280,"context_line":"                instantiate_vnf_req)"},{"line_number":281,"context_line":"        self.vnflcm_driver.instantiate_vnf.assert_called_once_with("},{"line_number":282,"context_line":"            self.context, mock.ANY, instantiate_vnf_req)"},{"line_number":283,"context_line":"        mock_is_package_in_use.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_af6a8817","line":280,"updated":"2020-09-23 10:19:59.000000000","message":"There is only a fix to change the indent, isn\u0027t it unnecessary?","commit_id":"258456dad720a82b60ee57760734547ac0589990"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"492546e7482f51883eaaf44ee7e57ead38b9cd22","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        instantiate_vnf_req \u003d vnflcm_fakes.get_instantiate_vnf_request_obj()"},{"line_number":278,"context_line":"        mock_is_package_in_use.side_effect \u003d Exception"},{"line_number":279,"context_line":"        self.conductor.instantiate(self.context, vnf_instance,"},{"line_number":280,"context_line":"                instantiate_vnf_req)"},{"line_number":281,"context_line":"        self.vnflcm_driver.instantiate_vnf.assert_called_once_with("},{"line_number":282,"context_line":"            self.context, mock.ANY, instantiate_vnf_req)"},{"line_number":283,"context_line":"        mock_is_package_in_use.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_f9ca589d","line":280,"in_reply_to":"9f560f44_af6a8817","updated":"2020-09-25 08:23:55.000000000","message":"It is fixed.","commit_id":"258456dad720a82b60ee57760734547ac0589990"}],"tacker/tests/unit/objects/fakes.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7d27c6dd8b7d301da1b43fe651b470ddca3f0efb","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u0027type\u0027: \u0027tosca.artifacts.nfv.SwImage\u0027,"},{"line_number":51,"context_line":"    \u0027algorithm\u0027: \u0027sha512\u0027, \u0027hash\u0027: uuidsentinel.hash}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"filter \u003d {\"usageState\": [\"NOT_IN_USE\"],"},{"line_number":54,"context_line":"    \"vnfPkgId\": [\"f04857cb-abdc-405f-8254-01501f3fa059\"],"},{"line_number":55,"context_line":"    \"vnfdId\": [\"b1bb0ce7-5555-0001-95ed-4840d70a1209\"],"},{"line_number":56,"context_line":"    \"vnfProductsFromProviders\": [{\"vnfProvider\": \"xxxxx\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_4b94d3e8","line":53,"updated":"2020-08-19 05:22:28.000000000","message":"Can you add indents to improve readability?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u0027type\u0027: \u0027tosca.artifacts.nfv.SwImage\u0027,"},{"line_number":51,"context_line":"    \u0027algorithm\u0027: \u0027sha512\u0027, \u0027hash\u0027: uuidsentinel.hash}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"filter \u003d {\"usageState\": [\"NOT_IN_USE\"],"},{"line_number":54,"context_line":"    \"vnfPkgId\": [\"f04857cb-abdc-405f-8254-01501f3fa059\"],"},{"line_number":55,"context_line":"    \"vnfdId\": [\"b1bb0ce7-5555-0001-95ed-4840d70a1209\"],"},{"line_number":56,"context_line":"    \"vnfProductsFromProviders\": [{\"vnfProvider\": \"xxxxx\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_31d5e01c","line":53,"in_reply_to":"9f560f44_4b94d3e8","updated":"2020-08-28 12:52:41.000000000","message":"Indents are added. Please expect in patch 3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"}],"tacker/tests/unit/objects/test_vnf_lcm_subscriptions.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d4c1674ab29bf4a940946ce4280cc6a405b19e19","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2019 NTT DATA"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_bf34df4b","line":1,"updated":"2020-08-17 06:46:35.000000000","message":"I think this Copyright is incorrect.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2019 NTT DATA"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_316200af","line":1,"in_reply_to":"9f560f44_bf34df4b","updated":"2020-08-28 12:52:41.000000000","message":"This line is removed. Please expect it in patch 3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7d27c6dd8b7d301da1b43fe651b470ddca3f0efb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                       \u0027_vnf_lcm_subscriptions_create\u0027)"},{"line_number":55,"context_line":"    def _create_subscription(self, mock_vnf_lcm_subscriptions_create):"},{"line_number":56,"context_line":"        filter \u003d fakes.filter"},{"line_number":57,"context_line":"        mock_vnf_lcm_subscriptions_create.return_value \u003d \\"},{"line_number":58,"context_line":"            \u0027{\"filter\": \"{\"operationStates\": [\"COMPLETED\"], \"vnfInstanceNames\": \\"},{"line_number":59,"context_line":"                [\"xxxxxxxxxxxxxxxxxx\"], \"operationTypes\": [\"INSTANTIATE\"], \\"},{"line_number":60,"context_line":"                \"vnfdIds\": [\"405d73c7-e964-4c8b-a914-41478ccd7c42\"], \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_35056cc3","line":57,"updated":"2020-08-19 05:22:28.000000000","message":"Is it possible to improve readability because it is a concatenation of strings and the structure is difficult to understand?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f81666e87764566e5bc3de5386a640adf3507b8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                       \u0027_vnf_lcm_subscriptions_create\u0027)"},{"line_number":55,"context_line":"    def _create_subscription(self, mock_vnf_lcm_subscriptions_create):"},{"line_number":56,"context_line":"        filter \u003d fakes.filter"},{"line_number":57,"context_line":"        mock_vnf_lcm_subscriptions_create.return_value \u003d \\"},{"line_number":58,"context_line":"            \u0027{\"filter\": \"{\"operationStates\": [\"COMPLETED\"], \"vnfInstanceNames\": \\"},{"line_number":59,"context_line":"                [\"xxxxxxxxxxxxxxxxxx\"], \"operationTypes\": [\"INSTANTIATE\"], \\"},{"line_number":60,"context_line":"                \"vnfdIds\": [\"405d73c7-e964-4c8b-a914-41478ccd7c42\"], \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b16d709b","line":57,"in_reply_to":"9f560f44_35056cc3","updated":"2020-08-28 12:52:41.000000000","message":"Added indent: \n          - _create_subscription\n          - test_create\n          - test_show\n          - test_list\nPlease expect it in Patch 3.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from tacker.tests.unit.db.base import SqlTestCase"},{"line_number":17,"context_line":"from tacker.tests.unit.objects import fakes"},{"line_number":18,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":19,"context_line":"from unittest import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestVnfd(SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_93ebd9da","line":19,"updated":"2020-09-01 17:51:01.000000000","message":"Please move such a standard lib before tacker project local one, and separate them with a blank line.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from tacker.tests.unit.db.base import SqlTestCase"},{"line_number":17,"context_line":"from tacker.tests.unit.objects import fakes"},{"line_number":18,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":19,"context_line":"from unittest import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestVnfd(SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_445454fe","line":19,"in_reply_to":"9f560f44_93ebd9da","updated":"2020-09-11 12:15:38.000000000","message":"Done.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def _create_subscription(self, mock_vnf_lcm_subscriptions_create):"},{"line_number":54,"context_line":"        filter \u003d fakes.filter"},{"line_number":55,"context_line":"        mock_vnf_lcm_subscriptions_create.return_value \u003d \\"},{"line_number":56,"context_line":"            \u0027{\\"},{"line_number":57,"context_line":"                \"filter\": \"{\"operationStates\": [\"COMPLETED\"],\\"},{"line_number":58,"context_line":"                \"vnfInstanceNames\": [\"xxxxxxxxxxxxxxxxxx\"],\\"},{"line_number":59,"context_line":"                \"operationTypes\": [\"INSTANTIATE\"],\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_538301aa","line":56,"updated":"2020-09-01 17:51:01.000000000","message":"Why don\u0027t you define this json string as an object and convert to a string then instead of defining it as a string so that it can be validated. If whole of the object is defined as a string, it\u0027s hard to find invalid syntax.\n\n```\nreturned_value \u003d {\u0027filter\u0027: {\u0027operationStates\u0027: [\u0027COMPLETED\u0027],...}\nmock_vnf_lcm_subscriptions_create.return_value \u003d json.dumps(returned_valuue)\n```","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def _create_subscription(self, mock_vnf_lcm_subscriptions_create):"},{"line_number":54,"context_line":"        filter \u003d fakes.filter"},{"line_number":55,"context_line":"        mock_vnf_lcm_subscriptions_create.return_value \u003d \\"},{"line_number":56,"context_line":"            \u0027{\\"},{"line_number":57,"context_line":"                \"filter\": \"{\"operationStates\": [\"COMPLETED\"],\\"},{"line_number":58,"context_line":"                \"vnfInstanceNames\": [\"xxxxxxxxxxxxxxxxxx\"],\\"},{"line_number":59,"context_line":"                \"operationTypes\": [\"INSTANTIATE\"],\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_646518e1","line":56,"in_reply_to":"9f560f44_538301aa","updated":"2020-09-11 12:15:38.000000000","message":"Thank you for the suggestion, but decided to leave as it is because of less time for the further modification.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        filter \u003d fakes.filter"},{"line_number":117,"context_line":"        subscription_obj \u003d objects.vnf_lcm_subscriptions.VnfLcmSubscription("},{"line_number":118,"context_line":"            context\u003dself.context)"},{"line_number":119,"context_line":"        mock_vnf_lcm_subscriptions_create.return_value \u003d \\"},{"line_number":120,"context_line":"            \u0027{\\"},{"line_number":121,"context_line":"                \"filter\": \"{\"operationStates\": [\"COMPLETED\"],\\"},{"line_number":122,"context_line":"                \"vnfInstanceNames\": [\"xxxxxxxxxxxxxxxxxx\"],\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_938d99d5","line":119,"updated":"2020-09-01 17:51:01.000000000","message":"Same as previous comment.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        filter \u003d fakes.filter"},{"line_number":117,"context_line":"        subscription_obj \u003d objects.vnf_lcm_subscriptions.VnfLcmSubscription("},{"line_number":118,"context_line":"            context\u003dself.context)"},{"line_number":119,"context_line":"        mock_vnf_lcm_subscriptions_create.return_value \u003d \\"},{"line_number":120,"context_line":"            \u0027{\\"},{"line_number":121,"context_line":"                \"filter\": \"{\"operationStates\": [\"COMPLETED\"],\\"},{"line_number":122,"context_line":"                \"vnfInstanceNames\": [\"xxxxxxxxxxxxxxxxxx\"],\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c46064d2","line":119,"in_reply_to":"9f560f44_938d99d5","updated":"2020-09-11 12:15:38.000000000","message":"Same as previous reply.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        subscription_obj \u003d objects.vnf_lcm_subscriptions.VnfLcmSubscription("},{"line_number":179,"context_line":"            context\u003dself.context)"},{"line_number":180,"context_line":"        mock_vnf_lcm_subscriptions_show.return_value \u003d \\"},{"line_number":181,"context_line":"            \u0027{\\"},{"line_number":182,"context_line":"                \"filter\": \"{\"operationStates\": [\"COMPLETED\"],\\"},{"line_number":183,"context_line":"                \"vnfInstanceNames\": [\"xxxxxxxxxxxxxxxxxx\"],\\"},{"line_number":184,"context_line":"                \"operationTypes\": [\"INSTANTIATE\"],\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d3c0b1e3","line":181,"updated":"2020-09-01 17:51:01.000000000","message":"Same as previous comment.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        subscription_obj \u003d objects.vnf_lcm_subscriptions.VnfLcmSubscription("},{"line_number":179,"context_line":"            context\u003dself.context)"},{"line_number":180,"context_line":"        mock_vnf_lcm_subscriptions_show.return_value \u003d \\"},{"line_number":181,"context_line":"            \u0027{\\"},{"line_number":182,"context_line":"                \"filter\": \"{\"operationStates\": [\"COMPLETED\"],\\"},{"line_number":183,"context_line":"                \"vnfInstanceNames\": [\"xxxxxxxxxxxxxxxxxx\"],\\"},{"line_number":184,"context_line":"                \"operationTypes\": [\"INSTANTIATE\"],\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a45bb01f","line":181,"in_reply_to":"9f560f44_d3c0b1e3","updated":"2020-09-11 12:15:38.000000000","message":"Same as previous reply.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"}],"tacker/tests/unit/vnflcm/test_controller.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4ff0a3092e8662bb81d371378cc52d500a33ba95","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from tacker.tests.unit.vnflcm import fakes"},{"line_number":34,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":35,"context_line":"from tacker.vnfm import vim_client"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from tacker.tests.unit.nfvo.test_nfvo_plugin import FakeVNFMPlugin"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_137069dc","line":36,"updated":"2020-09-01 17:51:01.000000000","message":"Why this blank line here?","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6983628b941a605fce7029249982ed625ddfeafe","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from tacker.tests.unit.vnflcm import fakes"},{"line_number":34,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":35,"context_line":"from tacker.vnfm import vim_client"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from tacker.tests.unit.nfvo.test_nfvo_plugin import FakeVNFMPlugin"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e49e48b6","line":36,"in_reply_to":"9f560f44_137069dc","updated":"2020-09-11 12:15:38.000000000","message":"The blank line was removed and the definition was moved into appropriate line.","commit_id":"316334fbdfcdcda1c13c1c15e84169981176faba"}],"tacker/tests/unit/vnfm/test_monitor.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d4c1674ab29bf4a940946ce4280cc6a405b19e19","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        test_vnfmonitor._monitor_manager \u003d self.mock_monitor_manager"},{"line_number":156,"context_line":"        test_vnfmonitor.run_monitor(test_hosting_vnf)"},{"line_number":157,"context_line":"        self.mock_monitor_manager \\"},{"line_number":158,"context_line":"            .invoke.assert_any_call(\u0027ping\u0027, \u0027monitor_call\u0027,"},{"line_number":159,"context_line":"                                            vnf\u003d{\u0027status\u0027: \u0027ACTIVE\u0027},"},{"line_number":160,"context_line":"                                            kwargs\u003dmock_kwargs)"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_3f9e0f63","line":158,"updated":"2020-08-17 06:46:35.000000000","message":"Why is this fix needed?","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"380a30a0792c1dd0b257d85aaf181debee059e19","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        test_vnfmonitor._monitor_manager \u003d self.mock_monitor_manager"},{"line_number":156,"context_line":"        test_vnfmonitor.run_monitor(test_hosting_vnf)"},{"line_number":157,"context_line":"        self.mock_monitor_manager \\"},{"line_number":158,"context_line":"            .invoke.assert_any_call(\u0027ping\u0027, \u0027monitor_call\u0027,"},{"line_number":159,"context_line":"                                            vnf\u003d{\u0027status\u0027: \u0027ACTIVE\u0027},"},{"line_number":160,"context_line":"                                            kwargs\u003dmock_kwargs)"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_46265718","line":158,"in_reply_to":"9f560f44_09a49e4a","updated":"2020-09-22 00:41:03.000000000","message":"It is restored.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"6026b6e2df6598810e3902e4f396b7b987e40962","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        test_vnfmonitor._monitor_manager \u003d self.mock_monitor_manager"},{"line_number":156,"context_line":"        test_vnfmonitor.run_monitor(test_hosting_vnf)"},{"line_number":157,"context_line":"        self.mock_monitor_manager \\"},{"line_number":158,"context_line":"            .invoke.assert_any_call(\u0027ping\u0027, \u0027monitor_call\u0027,"},{"line_number":159,"context_line":"                                            vnf\u003d{\u0027status\u0027: \u0027ACTIVE\u0027},"},{"line_number":160,"context_line":"                                            kwargs\u003dmock_kwargs)"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e3d6fdc4","line":158,"in_reply_to":"9f560f44_3f9e0f63","updated":"2020-09-14 20:25:30.000000000","message":"It was fixed because tox did not pass, but now it is restored.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fa1973075b14f52a1fe2d605639510de4db54369","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        test_vnfmonitor._monitor_manager \u003d self.mock_monitor_manager"},{"line_number":156,"context_line":"        test_vnfmonitor.run_monitor(test_hosting_vnf)"},{"line_number":157,"context_line":"        self.mock_monitor_manager \\"},{"line_number":158,"context_line":"            .invoke.assert_any_call(\u0027ping\u0027, \u0027monitor_call\u0027,"},{"line_number":159,"context_line":"                                            vnf\u003d{\u0027status\u0027: \u0027ACTIVE\u0027},"},{"line_number":160,"context_line":"                                            kwargs\u003dmock_kwargs)"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_09a49e4a","line":158,"in_reply_to":"9f560f44_e3d6fdc4","updated":"2020-09-18 08:06:21.000000000","message":"It has not been restored and seems to remain fixed.","commit_id":"b08147ce732979265b2b379c161fa24f14476ca8"}]}