)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9ec50d1fa3ae00610e780e65e412b0e6fc2b9011","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support EventAlarming description in TOSCA"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add support new tosca policy"},{"line_number":10,"context_line":"\"tosca.policies.tacker.EventAlarming\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Add this new policy section to definition yaml"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_9484b90c","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":22},"updated":"2020-08-26 17:53:04.000000000","message":"It seems enough `add` or `support`, and it should be `adds` or `supports`.","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"77c3ee6e2169b2e8e5ce2f44bf3648c3c8c9a0c2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support EventAlarming description in TOSCA"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add support new tosca policy"},{"line_number":10,"context_line":"\"tosca.policies.tacker.EventAlarming\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Add this new policy section to definition yaml"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_6152d3e0","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":22},"in_reply_to":"9f560f44_9484b90c","updated":"2020-08-30 13:32:06.000000000","message":"Done.","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9ec50d1fa3ae00610e780e65e412b0e6fc2b9011","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  \"tosca.policies.tacker.EventAlarming\" and"},{"line_number":16,"context_line":"  \"tosca.policies.tacker.Alarming\" in 1 VNF."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"(Assuming used by legacy VNF function)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ifcc40adfa4f0dd7cecb4d4ab3cb79e9032a934f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_741be57f","line":18,"updated":"2020-08-26 17:53:04.000000000","message":"You should describe more about this explanation, such as from which function, for possible reviewers or maintainers who are not so understand well about current tacker implementation.","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"77c3ee6e2169b2e8e5ce2f44bf3648c3c8c9a0c2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  \"tosca.policies.tacker.EventAlarming\" and"},{"line_number":16,"context_line":"  \"tosca.policies.tacker.Alarming\" in 1 VNF."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"(Assuming used by legacy VNF function)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ifcc40adfa4f0dd7cecb4d4ab3cb79e9032a934f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_c143df12","line":18,"in_reply_to":"9f560f44_741be57f","updated":"2020-08-30 13:32:06.000000000","message":"Agree, I add some explanation. Is it enough?","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9ec50d1fa3ae00610e780e65e412b0e6fc2b9011","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  \"tosca.policies.tacker.Alarming\" in 1 VNF."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"(Assuming used by legacy VNF function)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ifcc40adfa4f0dd7cecb4d4ab3cb79e9032a934f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_5703430d","line":19,"updated":"2020-08-26 17:53:04.000000000","message":"Could you add `Implements` tag for your blueprint?","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"77c3ee6e2169b2e8e5ce2f44bf3648c3c8c9a0c2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  \"tosca.policies.tacker.Alarming\" in 1 VNF."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"(Assuming used by legacy VNF function)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ifcc40adfa4f0dd7cecb4d4ab3cb79e9032a934f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_2148db2c","line":19,"in_reply_to":"9f560f44_5703430d","updated":"2020-08-30 13:32:06.000000000","message":"Done.","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"}],"samples/tosca-templates/vnfd/tosca-vnfd-eventalarm-respawn.yaml":[{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"2c455f01bb934281756644a6401752326cbd7968","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        type: tosca.policies.tacker.EventAlarming"},{"line_number":43,"context_line":"        triggers:"},{"line_number":44,"context_line":"            vdu1_event_healing:"},{"line_number":45,"context_line":"                description: VM delete"},{"line_number":46,"context_line":"                event_type:"},{"line_number":47,"context_line":"                    type: compute.instance.update"},{"line_number":48,"context_line":"                    implementation: ceilometer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_fa6fe18e","line":45,"range":{"start_line":45,"start_character":29,"end_line":45,"end_character":38},"updated":"2020-08-26 15:24:34.000000000","message":"should it be VM update failed?","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"77c3ee6e2169b2e8e5ce2f44bf3648c3c8c9a0c2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        type: tosca.policies.tacker.EventAlarming"},{"line_number":43,"context_line":"        triggers:"},{"line_number":44,"context_line":"            vdu1_event_healing:"},{"line_number":45,"context_line":"                description: VM delete"},{"line_number":46,"context_line":"                event_type:"},{"line_number":47,"context_line":"                    type: compute.instance.update"},{"line_number":48,"context_line":"                    implementation: ceilometer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_a15d0bee","line":45,"range":{"start_line":45,"start_character":29,"end_line":45,"end_character":38},"in_reply_to":"9f560f44_fa6fe18e","updated":"2020-08-30 13:32:06.000000000","message":"Yes, Done.","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"}],"tacker/vnfm/plugin.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"895e9e7188ecbfb4f13b122a22f43094bc4d84d1","unresolved":false,"context_lines":[{"line_number":882,"context_line":"        return scale[\u0027scale\u0027]"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    def get_vnf_policies_by_types(self, context, vnf_id, policy_types\u003dNone,"},{"line_number":885,"context_line":"                                  fields\u003dNone):"},{"line_number":886,"context_line":"        result \u003d []"},{"line_number":887,"context_line":"        for policy_type in (policy_types or []):"},{"line_number":888,"context_line":"            result +\u003d self.get_vnf_policies(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_70041fc7","line":885,"range":{"start_line":885,"start_character":45,"end_line":885,"end_character":47},"updated":"2020-08-18 13:09:45.000000000","message":"The function definition had a \"#noqa\" tag, in the modified code it seems it has been removed. Curious to know why was it required earlier?","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"87d51a0215b5c6fdb4ebcfe481a52413c95f13fc","unresolved":false,"context_lines":[{"line_number":882,"context_line":"        return scale[\u0027scale\u0027]"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    def get_vnf_policies_by_types(self, context, vnf_id, policy_types\u003dNone,"},{"line_number":885,"context_line":"                                  fields\u003dNone):"},{"line_number":886,"context_line":"        result \u003d []"},{"line_number":887,"context_line":"        for policy_type in (policy_types or []):"},{"line_number":888,"context_line":"            result +\u003d self.get_vnf_policies(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2d2b0e95","line":885,"range":{"start_line":885,"start_character":45,"end_line":885,"end_character":47},"in_reply_to":"9f560f44_70041fc7","updated":"2020-08-24 17:41:02.000000000","message":"I\u0027ve checked the result of pep8 with removing this \"#noqa\"\nIt seems just a long line...\n\ntacker/vnfm/plugin.py:883:80: E501 line too long (85 \u003e 79 characters)\n\nI think my change can fix it.","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"2c455f01bb934281756644a6401752326cbd7968","unresolved":false,"context_lines":[{"line_number":885,"context_line":"                                  fields\u003dNone):"},{"line_number":886,"context_line":"        result \u003d []"},{"line_number":887,"context_line":"        for policy_type in (policy_types or []):"},{"line_number":888,"context_line":"            result +\u003d self.get_vnf_policies(context,"},{"line_number":889,"context_line":"                                         vnf_id,"},{"line_number":890,"context_line":"                                         filters\u003d{\u0027type\u0027: policy_type})"},{"line_number":891,"context_line":"        if result:"},{"line_number":892,"context_line":"            return result"},{"line_number":893,"context_line":"        raise exceptions.VnfPolicyTypeInvalid("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1a4c5540","line":890,"range":{"start_line":888,"start_character":12,"end_line":890,"end_character":71},"updated":"2020-08-26 15:24:34.000000000","message":"I think using append() for list is better","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9ec50d1fa3ae00610e780e65e412b0e6fc2b9011","unresolved":false,"context_lines":[{"line_number":885,"context_line":"                                  fields\u003dNone):"},{"line_number":886,"context_line":"        result \u003d []"},{"line_number":887,"context_line":"        for policy_type in (policy_types or []):"},{"line_number":888,"context_line":"            result +\u003d self.get_vnf_policies(context,"},{"line_number":889,"context_line":"                                         vnf_id,"},{"line_number":890,"context_line":"                                         filters\u003d{\u0027type\u0027: policy_type})"},{"line_number":891,"context_line":"        if result:"},{"line_number":892,"context_line":"            return result"},{"line_number":893,"context_line":"        raise exceptions.VnfPolicyTypeInvalid("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_80d6384e","line":890,"range":{"start_line":888,"start_character":12,"end_line":890,"end_character":71},"in_reply_to":"9f560f44_1a4c5540","updated":"2020-08-26 17:53:04.000000000","message":"+1 for Cong.","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"77c3ee6e2169b2e8e5ce2f44bf3648c3c8c9a0c2","unresolved":false,"context_lines":[{"line_number":885,"context_line":"                                  fields\u003dNone):"},{"line_number":886,"context_line":"        result \u003d []"},{"line_number":887,"context_line":"        for policy_type in (policy_types or []):"},{"line_number":888,"context_line":"            result +\u003d self.get_vnf_policies(context,"},{"line_number":889,"context_line":"                                         vnf_id,"},{"line_number":890,"context_line":"                                         filters\u003d{\u0027type\u0027: policy_type})"},{"line_number":891,"context_line":"        if result:"},{"line_number":892,"context_line":"            return result"},{"line_number":893,"context_line":"        raise exceptions.VnfPolicyTypeInvalid("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2171fb78","line":890,"range":{"start_line":888,"start_character":12,"end_line":890,"end_character":71},"in_reply_to":"9f560f44_80d6384e","updated":"2020-08-30 13:32:06.000000000","message":"\u0027+\u003d\u0027 means concatenating two lists, not \u0027append\u0027.\nAnyway, I agree with not use \u0027+\u003d\u0027. I think \u0027extend\u0027 is good. What do you think?","commit_id":"4bca90a50b06b25e74343c98cab63d54df3c8b6a"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"d790c7a66b8669bffa5583cbfa5c78446fe00b94","unresolved":false,"context_lines":[{"line_number":882,"context_line":"        return scale[\u0027scale\u0027]"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    def get_vnf_policies_by_types(self, context, vnf_id, policy_types\u003dNone,"},{"line_number":885,"context_line":"                                  fields\u003dNone):"},{"line_number":886,"context_line":"        result \u003d []"},{"line_number":887,"context_line":"        for policy_type in (policy_types or []):"},{"line_number":888,"context_line":"            result.extend(self.get_vnf_policies(context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6a540723","line":885,"range":{"start_line":885,"start_character":34,"end_line":885,"end_character":45},"updated":"2020-09-21 16:21:09.000000000","message":"what is use of \"fields\" ?","commit_id":"9e04c676de706a41f68f290571fa4bbc30dd73b6"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"d790c7a66b8669bffa5583cbfa5c78446fe00b94","unresolved":false,"context_lines":[{"line_number":946,"context_line":"        return pl_action_dict"},{"line_number":947,"context_line":"        # validate url"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    def _get_vnf_triggers(self, context, vnf_id, filters\u003dNone, fields\u003dNone):"},{"line_number":950,"context_line":"        if filters.get(\u0027name\u0027) in constants.RESERVATION_POLICY_ACTIONS:"},{"line_number":951,"context_line":"            policies \u003d self.get_vnf_policies_by_types("},{"line_number":952,"context_line":"                context, vnf_id, policy_types\u003d[constants.POLICY_RESERVATION])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8ac19be7","line":949,"range":{"start_line":949,"start_character":63,"end_line":949,"end_character":74},"updated":"2020-09-21 16:21:09.000000000","message":"what is use of \"fields\" ?","commit_id":"9e04c676de706a41f68f290571fa4bbc30dd73b6"}]}