)]}'
{"api-ref/source/v1/vnflcm.inc":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"16da7a0404c721b17797b8e17d37649d900abdef","unresolved":false,"context_lines":[{"line_number":525,"context_line":"----------------"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":".. literalinclude:: samples/vnflcm/list-vnf-instance-response.json"},{"line_number":528,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"9f560f44_de7fa3dc","line":528,"updated":"2020-08-24 09:08:16.000000000","message":"Do you need to modify this line?","commit_id":"2139261ea1447a88f1fb65fe5461185759f19815"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b17a32330ba8af6e5110ca03860372d6426d9b9e","unresolved":false,"context_lines":[{"line_number":525,"context_line":"----------------"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":".. literalinclude:: samples/vnflcm/list-vnf-instance-response.json"},{"line_number":528,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"9f560f44_b13c62bf","line":528,"in_reply_to":"9f560f44_de7fa3dc","updated":"2020-08-27 09:42:56.000000000","message":"It is removed. Please refer to patch5","commit_id":"2139261ea1447a88f1fb65fe5461185759f19815"}],"tacker/api/views/vnf_lcm.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"542eaf711a6deb7f240ee4c114f2c0eadfaec596","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        vnf_instance_dict \u003d utils.convert_snakecase_to_camelcase("},{"line_number":61,"context_line":"            vnf_instance_dict)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        if api_version \u003d\u003d \"2.6.1\":"},{"line_number":64,"context_line":"            del vnf_instance_dict[\"vnfPkgId\"]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        links \u003d self._get_links(vnf_instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_03cd1fb6","line":63,"updated":"2020-08-26 08:28:54.000000000","message":"I think the following is better.\n  if api_version \u003d\u003d \"2.6.1\" or api_version \u003d\u003d None:\nBecause Tacker is based on 2.6.1, I think this is better as the default behavior when Version is omitted.","commit_id":"2139261ea1447a88f1fb65fe5461185759f19815"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b17a32330ba8af6e5110ca03860372d6426d9b9e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        vnf_instance_dict \u003d utils.convert_snakecase_to_camelcase("},{"line_number":61,"context_line":"            vnf_instance_dict)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        if api_version \u003d\u003d \"2.6.1\":"},{"line_number":64,"context_line":"            del vnf_instance_dict[\"vnfPkgId\"]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        links \u003d self._get_links(vnf_instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_d1af56e0","line":63,"in_reply_to":"9f560f44_03cd1fb6","updated":"2020-08-27 09:42:56.000000000","message":"We fix it based on your suggestion. Please refer to patch5.","commit_id":"2139261ea1447a88f1fb65fe5461185759f19815"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"b7c323c7a16801fa8febd35657648d120d9c54ca","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return {\"_links\": links}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _get_vnf_instance_info(self,"},{"line_number":58,"context_line":"            vnf_instance, api_version\u003dNone):"},{"line_number":59,"context_line":"        vnf_instance_dict \u003d vnf_instance.to_dict()"},{"line_number":60,"context_line":"        vnf_instance_dict \u003d utils.convert_snakecase_to_camelcase("},{"line_number":61,"context_line":"            vnf_instance_dict)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_f4dc1575","line":58,"range":{"start_line":58,"start_character":26,"end_line":58,"end_character":37},"updated":"2020-09-11 13:23:10.000000000","message":"It is necessary to modify the logic so that it does not refer to api_version.","commit_id":"84dba70cc302087a5f46dab3754b874fb6e600d9"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9b6a60202a382f085827b95163d73101fb1a8f4e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return {\"_links\": links}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _get_vnf_instance_info(self,"},{"line_number":58,"context_line":"            vnf_instance, api_version\u003dNone):"},{"line_number":59,"context_line":"        vnf_instance_dict \u003d vnf_instance.to_dict()"},{"line_number":60,"context_line":"        vnf_instance_dict \u003d utils.convert_snakecase_to_camelcase("},{"line_number":61,"context_line":"            vnf_instance_dict)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_8931325c","line":58,"range":{"start_line":58,"start_character":26,"end_line":58,"end_character":37},"in_reply_to":"9f560f44_f4dc1575","updated":"2020-09-12 13:10:26.000000000","message":"Logic is modified.","commit_id":"84dba70cc302087a5f46dab3754b874fb6e600d9"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"b7c323c7a16801fa8febd35657648d120d9c54ca","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        vnf_instance_dict \u003d utils.convert_snakecase_to_camelcase("},{"line_number":61,"context_line":"            vnf_instance_dict)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        if api_version \u003d\u003d \"2.6.1\":"},{"line_number":64,"context_line":"            del vnf_instance_dict[\"vnfPkgId\"]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        links \u003d self._get_links(vnf_instance)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_b4c8dda7","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":45},"updated":"2020-09-11 13:23:10.000000000","message":"It is necessary to modify the logic so that it does not refer to api_version.","commit_id":"84dba70cc302087a5f46dab3754b874fb6e600d9"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9b6a60202a382f085827b95163d73101fb1a8f4e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        vnf_instance_dict \u003d utils.convert_snakecase_to_camelcase("},{"line_number":61,"context_line":"            vnf_instance_dict)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        if api_version \u003d\u003d \"2.6.1\":"},{"line_number":64,"context_line":"            del vnf_instance_dict[\"vnfPkgId\"]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        links \u003d self._get_links(vnf_instance)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_69349e49","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":45},"in_reply_to":"9f560f44_b4c8dda7","updated":"2020-09-12 13:10:26.000000000","message":"Logic is modified.","commit_id":"84dba70cc302087a5f46dab3754b874fb6e600d9"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"b7c323c7a16801fa8febd35657648d120d9c54ca","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def show(self, vnf_instance):"},{"line_number":75,"context_line":"        return self._get_vnf_instance_info(vnf_instance)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def index(self, vnf_instances, api_version\u003dNone):"},{"line_number":78,"context_line":"        return [self._get_vnf_instance_info(vnf_instance, api_version)"},{"line_number":79,"context_line":"                for vnf_instance in vnf_instances]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_f4c5358f","line":77,"range":{"start_line":77,"start_character":35,"end_line":77,"end_character":46},"updated":"2020-09-11 13:23:10.000000000","message":"It is necessary to modify the logic so that it does not refer to api_version.","commit_id":"84dba70cc302087a5f46dab3754b874fb6e600d9"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9b6a60202a382f085827b95163d73101fb1a8f4e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def show(self, vnf_instance):"},{"line_number":75,"context_line":"        return self._get_vnf_instance_info(vnf_instance)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def index(self, vnf_instances, api_version\u003dNone):"},{"line_number":78,"context_line":"        return [self._get_vnf_instance_info(vnf_instance, api_version)"},{"line_number":79,"context_line":"                for vnf_instance in vnf_instances]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_c93e8a27","line":77,"range":{"start_line":77,"start_character":35,"end_line":77,"end_character":46},"in_reply_to":"9f560f44_f4c5358f","updated":"2020-09-12 13:10:26.000000000","message":"Logic is modified.","commit_id":"84dba70cc302087a5f46dab3754b874fb6e600d9"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"b7c323c7a16801fa8febd35657648d120d9c54ca","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        return self._get_vnf_instance_info(vnf_instance)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def index(self, vnf_instances, api_version\u003dNone):"},{"line_number":78,"context_line":"        return [self._get_vnf_instance_info(vnf_instance, api_version)"},{"line_number":79,"context_line":"                for vnf_instance in vnf_instances]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d4c0f17e","line":78,"range":{"start_line":78,"start_character":58,"end_line":78,"end_character":69},"updated":"2020-09-11 13:23:10.000000000","message":"It is necessary to modify the logic so that it does not refer to api_version.","commit_id":"84dba70cc302087a5f46dab3754b874fb6e600d9"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9b6a60202a382f085827b95163d73101fb1a8f4e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        return self._get_vnf_instance_info(vnf_instance)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def index(self, vnf_instances, api_version\u003dNone):"},{"line_number":78,"context_line":"        return [self._get_vnf_instance_info(vnf_instance, api_version)"},{"line_number":79,"context_line":"                for vnf_instance in vnf_instances]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_a939963f","line":78,"range":{"start_line":78,"start_character":58,"end_line":78,"end_character":69},"in_reply_to":"9f560f44_d4c0f17e","updated":"2020-09-12 13:10:26.000000000","message":"Logic is modified.","commit_id":"84dba70cc302087a5f46dab3754b874fb6e600d9"}],"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"16da7a0404c721b17797b8e17d37649d900abdef","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    def index(self, request):"},{"line_number":209,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":210,"context_line":"        vnf_instances \u003d objects.VnfInstanceList.get_all(context)"},{"line_number":211,"context_line":"        api_version \u003d request.headers[\u0027Version\u0027]"},{"line_number":212,"context_line":"        return self._view_builder.index(vnf_instances, api_version)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @check_vnf_state(action\u003d\"delete\","}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_5ee1d39a","line":211,"updated":"2020-08-24 09:08:16.000000000","message":"Is it guaranteed that the \u0027Version\u0027 can be obtained from the header according to the ETSI NFV-SOL specifications?","commit_id":"2139261ea1447a88f1fb65fe5461185759f19815"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b17a32330ba8af6e5110ca03860372d6426d9b9e","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    def index(self, request):"},{"line_number":209,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":210,"context_line":"        vnf_instances \u003d objects.VnfInstanceList.get_all(context)"},{"line_number":211,"context_line":"        api_version \u003d request.headers[\u0027Version\u0027]"},{"line_number":212,"context_line":"        return self._view_builder.index(vnf_instances, api_version)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @check_vnf_state(action\u003d\"delete\","}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_e698e2c0","line":211,"in_reply_to":"9f560f44_5ee1d39a","updated":"2020-08-27 09:42:56.000000000","message":"Based on Sol003 4.2.2, It is assumed to be acquired from Version of Request header fields.","commit_id":"2139261ea1447a88f1fb65fe5461185759f19815"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"b7c323c7a16801fa8febd35657648d120d9c54ca","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    def index(self, request):"},{"line_number":209,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":210,"context_line":"        vnf_instances \u003d objects.VnfInstanceList.get_all(context)"},{"line_number":211,"context_line":"        api_version \u003d request.headers[\u0027Version\u0027]"},{"line_number":212,"context_line":"        return self._view_builder.index(vnf_instances, api_version)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @check_vnf_state(action\u003d\"delete\","},{"line_number":215,"context_line":"        instantiation_state\u003d[fields.VnfInstanceState.NOT_INSTANTIATED],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_144c293d","line":212,"range":{"start_line":211,"start_character":0,"end_line":212,"end_character":67},"updated":"2020-09-11 13:23:10.000000000","message":"It is necessary to modify the logic so that it does not refer to api_version.","commit_id":"84dba70cc302087a5f46dab3754b874fb6e600d9"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9b6a60202a382f085827b95163d73101fb1a8f4e","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    def index(self, request):"},{"line_number":209,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":210,"context_line":"        vnf_instances \u003d objects.VnfInstanceList.get_all(context)"},{"line_number":211,"context_line":"        api_version \u003d request.headers[\u0027Version\u0027]"},{"line_number":212,"context_line":"        return self._view_builder.index(vnf_instances, api_version)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @check_vnf_state(action\u003d\"delete\","},{"line_number":215,"context_line":"        instantiation_state\u003d[fields.VnfInstanceState.NOT_INSTANTIATED],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_094522b4","line":212,"range":{"start_line":211,"start_character":0,"end_line":212,"end_character":67},"in_reply_to":"9f560f44_144c293d","updated":"2020-09-12 13:10:26.000000000","message":"Logic is modified.","commit_id":"84dba70cc302087a5f46dab3754b874fb6e600d9"}],"tacker/tests/unit/vnflcm/test_controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"16da7a0404c721b17797b8e17d37649d900abdef","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self):"},{"line_number":39,"context_line":"        super(FakeVNFMPlugin, self).__init__()"},{"line_number":40,"context_line":"        self.vnf1_vnfd_id \u003d \u0027eb094833-995e-49f0-a047-dfb56aaf7c4e\u0027"},{"line_number":41,"context_line":"        self.vnf1_vnf_id \u003d \u002791e32c20-6d1f-47a4-9ba7-08f5e5effe07\u0027"},{"line_number":42,"context_line":"        self.vnf1_update_vnf_id \u003d \u002791e32c20-6d1f-47a4-9ba7-08f5e5effaf6\u0027"},{"line_number":43,"context_line":"        self.vnf3_vnfd_id \u003d \u0027e4015e9f-1ef2-49fb-adb6-070791ad3c45\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_fe5c274c","line":40,"updated":"2020-08-24 09:08:16.000000000","message":"Please sort the description order.","commit_id":"2139261ea1447a88f1fb65fe5461185759f19815"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b17a32330ba8af6e5110ca03860372d6426d9b9e","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self):"},{"line_number":39,"context_line":"        super(FakeVNFMPlugin, self).__init__()"},{"line_number":40,"context_line":"        self.vnf1_vnfd_id \u003d \u0027eb094833-995e-49f0-a047-dfb56aaf7c4e\u0027"},{"line_number":41,"context_line":"        self.vnf1_vnf_id \u003d \u002791e32c20-6d1f-47a4-9ba7-08f5e5effe07\u0027"},{"line_number":42,"context_line":"        self.vnf1_update_vnf_id \u003d \u002791e32c20-6d1f-47a4-9ba7-08f5e5effaf6\u0027"},{"line_number":43,"context_line":"        self.vnf3_vnfd_id \u003d \u0027e4015e9f-1ef2-49fb-adb6-070791ad3c45\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_5177c6a0","line":40,"in_reply_to":"9f560f44_fe5c274c","updated":"2020-08-27 09:42:56.000000000","message":"The description has been sorted. Please see it implemented in patch5.","commit_id":"2139261ea1447a88f1fb65fe5461185759f19815"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"16da7a0404c721b17797b8e17d37649d900abdef","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.controller \u003d controller.VnfLcmController()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def tearDown(self):"},{"line_number":70,"context_line":"        # 2. patcher の終了"},{"line_number":71,"context_line":"        self.mock_manager.stop()"},{"line_number":72,"context_line":"        super(TestController, self).tearDown()"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_feaee72b","line":70,"updated":"2020-08-24 09:08:16.000000000","message":"Please write in English or delete any unnecessary comments.","commit_id":"2139261ea1447a88f1fb65fe5461185759f19815"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b17a32330ba8af6e5110ca03860372d6426d9b9e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.controller \u003d controller.VnfLcmController()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def tearDown(self):"},{"line_number":70,"context_line":"        # 2. patcher の終了"},{"line_number":71,"context_line":"        self.mock_manager.stop()"},{"line_number":72,"context_line":"        super(TestController, self).tearDown()"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_916ddecd","line":70,"in_reply_to":"9f560f44_feaee72b","updated":"2020-08-27 09:42:56.000000000","message":"The comment is deleted. Please refer to patch 5.","commit_id":"2139261ea1447a88f1fb65fe5461185759f19815"}]}