)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"40a5a709a1b7833139884034f046d6da4312db03","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson C. Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-27 00:45:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support of version 2.4.1 on Create VNF request:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNFM returns a \"201 Created\" response containing"},{"line_number":10,"context_line":"\"vnfPkgId” attribute in the payload body."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_8d1403eb","line":7,"range":{"start_line":7,"start_character":46,"end_line":7,"end_character":47},"updated":"2020-09-07 19:10:32.000000000","message":"It\u0027s not necessary.","commit_id":"b66d2182d0cc96abe4ca9df6d81f721c543058eb"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"b2049e05e11edd8b92ef71cf56479d242b04b3f7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson C. Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-27 00:45:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support of version 2.4.1 on Create VNF request:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNFM returns a \"201 Created\" response containing"},{"line_number":10,"context_line":"\"vnfPkgId” attribute in the payload body."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_516d4b01","line":7,"range":{"start_line":7,"start_character":46,"end_line":7,"end_character":47},"in_reply_to":"9f560f44_8d1403eb","updated":"2020-09-09 07:37:16.000000000","message":"Removed.","commit_id":"b66d2182d0cc96abe4ca9df6d81f721c543058eb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"40a5a709a1b7833139884034f046d6da4312db03","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNFM returns a \"201 Created\" response containing"},{"line_number":10,"context_line":"\"vnfPkgId” attribute in the payload body."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7e227edeb40474fce0a77979f3f540638d90d9f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_2d3df78d","line":11,"updated":"2020-09-07 19:10:32.000000000","message":"Could you add `Implements` tag for blueprint.","commit_id":"b66d2182d0cc96abe4ca9df6d81f721c543058eb"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"b2049e05e11edd8b92ef71cf56479d242b04b3f7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNFM returns a \"201 Created\" response containing"},{"line_number":10,"context_line":"\"vnfPkgId” attribute in the payload body."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7e227edeb40474fce0a77979f3f540638d90d9f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_5146eb7c","line":11,"in_reply_to":"9f560f44_2d3df78d","updated":"2020-09-09 07:37:16.000000000","message":"Added with blueprint name.","commit_id":"b66d2182d0cc96abe4ca9df6d81f721c543058eb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"40a5a709a1b7833139884034f046d6da4312db03","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-03 18:24:18 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support of version 2.4.1 on Create VNF request:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNFM returns a \"201 Created\" response containing"},{"line_number":10,"context_line":"\"vnfPkgId” attribute in the payload body."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_8de9a3e4","line":7,"range":{"start_line":7,"start_character":46,"end_line":7,"end_character":47},"updated":"2020-09-07 19:10:32.000000000","message":"It\u0027s not necessary.","commit_id":"f6254c7657a2e28284936d196d28fd184f730862"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"b2049e05e11edd8b92ef71cf56479d242b04b3f7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-03 18:24:18 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support of version 2.4.1 on Create VNF request:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNFM returns a \"201 Created\" response containing"},{"line_number":10,"context_line":"\"vnfPkgId” attribute in the payload body."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_b15e6742","line":7,"range":{"start_line":7,"start_character":46,"end_line":7,"end_character":47},"in_reply_to":"9f560f44_8de9a3e4","updated":"2020-09-09 07:37:16.000000000","message":"Removed.","commit_id":"f6254c7657a2e28284936d196d28fd184f730862"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"40a5a709a1b7833139884034f046d6da4312db03","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNFM returns a \"201 Created\" response containing"},{"line_number":10,"context_line":"\"vnfPkgId” attribute in the payload body."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7e227edeb40474fce0a77979f3f540638d90d9f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_edbbffe1","line":11,"updated":"2020-09-07 19:10:32.000000000","message":"Could you add `Implements` tag for blueprint.","commit_id":"f6254c7657a2e28284936d196d28fd184f730862"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"b2049e05e11edd8b92ef71cf56479d242b04b3f7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNFM returns a \"201 Created\" response containing"},{"line_number":10,"context_line":"\"vnfPkgId” attribute in the payload body."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7e227edeb40474fce0a77979f3f540638d90d9f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_915b6352","line":11,"in_reply_to":"9f560f44_edbbffe1","updated":"2020-09-09 07:37:16.000000000","message":"Added with blueprint name.","commit_id":"f6254c7657a2e28284936d196d28fd184f730862"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2d7a29ad0c040c52e014a68a90932abd65a98b84","unresolved":false,"context_lines":[{"line_number":10,"context_line":"\"vnfPkgId” attribute in the payload body."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7e227edeb40474fce0a77979f3f540638d90d9f4"},{"line_number":13,"context_line":"Implements: bp/support-etsi-nfv-specs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_9fc68048","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":37},"updated":"2020-09-13 07:10:17.000000000","message":"It\u0027s wrong format. `Implements: blueprint support-etsi-nfv-specs` is correct in this case.","commit_id":"d30b0171574439709ed39b4b22d6ce877bb0c0d2"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"185fbd85b646465324160f006ceb1d7fd7d4a8f7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"\"vnfPkgId” attribute in the payload body."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7e227edeb40474fce0a77979f3f540638d90d9f4"},{"line_number":13,"context_line":"Implements: bp/support-etsi-nfv-specs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_5fd068c8","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":37},"in_reply_to":"9f560f44_9fc68048","updated":"2020-09-13 08:36:09.000000000","message":"Done","commit_id":"d30b0171574439709ed39b4b22d6ce877bb0c0d2"}],"api-ref/source/v1/parameters_vnflcm.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5c99cf98360274f309803b9b070b0088ef07a248","unresolved":false,"context_lines":[{"line_number":737,"context_line":"  type: array"},{"line_number":738,"context_line":"vnf_instance_vnf_pkg_id:"},{"line_number":739,"context_line":"  description: |"},{"line_number":740,"context_line":"    Identifier of information held by the NFVO about the specific VNF package on which the VNF is based. "},{"line_number":741,"context_line":"    This identifier was allocated by the NFVO."},{"line_number":742,"context_line":"    This attribute can be modified with the PATCH method."},{"line_number":743,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_fb9bebc4","line":740,"updated":"2020-09-18 09:56:08.000000000","message":"Trailing white space. You should not make a line too long to find such a mistake easily :)","commit_id":"5655d14f5ab74df3304f404fd034247a9207bd70"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"be61a855aeb0834a087eb87ac846d9c77415e4f6","unresolved":false,"context_lines":[{"line_number":737,"context_line":"  type: array"},{"line_number":738,"context_line":"vnf_instance_vnf_pkg_id:"},{"line_number":739,"context_line":"  description: |"},{"line_number":740,"context_line":"    Identifier of information held by the NFVO about the specific VNF package on which the VNF is based. "},{"line_number":741,"context_line":"    This identifier was allocated by the NFVO."},{"line_number":742,"context_line":"    This attribute can be modified with the PATCH method."},{"line_number":743,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_5090e496","line":740,"in_reply_to":"9f560f44_fb9bebc4","updated":"2020-09-19 09:10:27.000000000","message":"Fixed. Also moved for correct order of description.","commit_id":"5655d14f5ab74df3304f404fd034247a9207bd70"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5c99cf98360274f309803b9b070b0088ef07a248","unresolved":false,"context_lines":[{"line_number":738,"context_line":"vnf_instance_vnf_pkg_id:"},{"line_number":739,"context_line":"  description: |"},{"line_number":740,"context_line":"    Identifier of information held by the NFVO about the specific VNF package on which the VNF is based. "},{"line_number":741,"context_line":"    This identifier was allocated by the NFVO."},{"line_number":742,"context_line":"    This attribute can be modified with the PATCH method."},{"line_number":743,"context_line":"  in: body"},{"line_number":744,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_db5267de","line":741,"range":{"start_line":741,"start_character":20,"end_line":741,"end_character":33},"updated":"2020-09-18 09:56:08.000000000","message":"Why past tense?","commit_id":"5655d14f5ab74df3304f404fd034247a9207bd70"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"be61a855aeb0834a087eb87ac846d9c77415e4f6","unresolved":false,"context_lines":[{"line_number":738,"context_line":"vnf_instance_vnf_pkg_id:"},{"line_number":739,"context_line":"  description: |"},{"line_number":740,"context_line":"    Identifier of information held by the NFVO about the specific VNF package on which the VNF is based. "},{"line_number":741,"context_line":"    This identifier was allocated by the NFVO."},{"line_number":742,"context_line":"    This attribute can be modified with the PATCH method."},{"line_number":743,"context_line":"  in: body"},{"line_number":744,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_d0e99419","line":741,"range":{"start_line":741,"start_character":20,"end_line":741,"end_character":33},"in_reply_to":"9f560f44_db5267de","updated":"2020-09-19 09:10:27.000000000","message":"Fixed.","commit_id":"5655d14f5ab74df3304f404fd034247a9207bd70"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5c99cf98360274f309803b9b070b0088ef07a248","unresolved":false,"context_lines":[{"line_number":739,"context_line":"  description: |"},{"line_number":740,"context_line":"    Identifier of information held by the NFVO about the specific VNF package on which the VNF is based. "},{"line_number":741,"context_line":"    This identifier was allocated by the NFVO."},{"line_number":742,"context_line":"    This attribute can be modified with the PATCH method."},{"line_number":743,"context_line":"  in: body"},{"line_number":744,"context_line":"  required: true"},{"line_number":745,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_5b0db7e6","line":742,"range":{"start_line":742,"start_character":9,"end_line":742,"end_character":18},"updated":"2020-09-18 09:56:08.000000000","message":"Does it equal to the `identifier`? If so, it\u0027s better to join with before such as \"This identifier ... by NFVO and can be modified ...\".","commit_id":"5655d14f5ab74df3304f404fd034247a9207bd70"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"be61a855aeb0834a087eb87ac846d9c77415e4f6","unresolved":false,"context_lines":[{"line_number":739,"context_line":"  description: |"},{"line_number":740,"context_line":"    Identifier of information held by the NFVO about the specific VNF package on which the VNF is based. "},{"line_number":741,"context_line":"    This identifier was allocated by the NFVO."},{"line_number":742,"context_line":"    This attribute can be modified with the PATCH method."},{"line_number":743,"context_line":"  in: body"},{"line_number":744,"context_line":"  required: true"},{"line_number":745,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_f0e6584a","line":742,"range":{"start_line":742,"start_character":9,"end_line":742,"end_character":18},"in_reply_to":"9f560f44_5b0db7e6","updated":"2020-09-19 09:10:27.000000000","message":"Fixed as you pointed out.","commit_id":"5655d14f5ab74df3304f404fd034247a9207bd70"}],"tacker/api/views/vnf_lcm.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"4e5996ebb88cc7b835ade8ca244fa8662fb071a6","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return {\"_links\": links}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _get_vnf_instance_info(self, vnf_instance, api_version\u003dNone):"},{"line_number":58,"context_line":"        vnf_instance_dict \u003d vnf_instance.to_dict()"},{"line_number":59,"context_line":"        vnf_instance_dict \u003d utils.convert_snakecase_to_camelcase("},{"line_number":60,"context_line":"            vnf_instance_dict)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7405a5c1","line":57,"range":{"start_line":57,"start_character":51,"end_line":57,"end_character":62},"updated":"2020-09-11 13:25:20.000000000","message":"It is necessary to modify the logic so that it does not refer to api_version.","commit_id":"e248dfa7c6834105ec586321c8084b9c8b72f2b8"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"185fbd85b646465324160f006ceb1d7fd7d4a8f7","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return {\"_links\": links}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _get_vnf_instance_info(self, vnf_instance, api_version\u003dNone):"},{"line_number":58,"context_line":"        vnf_instance_dict \u003d vnf_instance.to_dict()"},{"line_number":59,"context_line":"        vnf_instance_dict \u003d utils.convert_snakecase_to_camelcase("},{"line_number":60,"context_line":"            vnf_instance_dict)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_9f504060","line":57,"range":{"start_line":57,"start_character":51,"end_line":57,"end_character":62},"in_reply_to":"9f560f44_7405a5c1","updated":"2020-09-13 08:36:09.000000000","message":"Done","commit_id":"e248dfa7c6834105ec586321c8084b9c8b72f2b8"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"4e5996ebb88cc7b835ade8ca244fa8662fb071a6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        vnf_instance_dict \u003d utils.convert_snakecase_to_camelcase("},{"line_number":60,"context_line":"            vnf_instance_dict)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if api_version \u003d\u003d \u00272.6.1\u0027:"},{"line_number":63,"context_line":"            del vnf_instance_dict[\u0027vnfPkgId\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        links \u003d self._get_links(vnf_instance)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_b40bbdd2","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":45},"updated":"2020-09-11 13:25:20.000000000","message":"It is necessary to modify the logic so that it does not refer to api_version.","commit_id":"e248dfa7c6834105ec586321c8084b9c8b72f2b8"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"185fbd85b646465324160f006ceb1d7fd7d4a8f7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        vnf_instance_dict \u003d utils.convert_snakecase_to_camelcase("},{"line_number":60,"context_line":"            vnf_instance_dict)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if api_version \u003d\u003d \u00272.6.1\u0027:"},{"line_number":63,"context_line":"            del vnf_instance_dict[\u0027vnfPkgId\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        links \u003d self._get_links(vnf_instance)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_ff4b3cad","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":45},"in_reply_to":"9f560f44_b40bbdd2","updated":"2020-09-13 08:36:09.000000000","message":"Done","commit_id":"e248dfa7c6834105ec586321c8084b9c8b72f2b8"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"4e5996ebb88cc7b835ade8ca244fa8662fb071a6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        vnf_instance_dict.update(links)"},{"line_number":68,"context_line":"        return vnf_instance_dict"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def create(self, vnf_instance, api_version\u003dNone):"},{"line_number":71,"context_line":"        return self._get_vnf_instance_info(vnf_instance, api_version)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def show(self, vnf_instance):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_f4f895c4","line":70,"range":{"start_line":70,"start_character":35,"end_line":70,"end_character":46},"updated":"2020-09-11 13:25:20.000000000","message":"It is necessary to modify the logic so that it does not refer to api_version.","commit_id":"e248dfa7c6834105ec586321c8084b9c8b72f2b8"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"185fbd85b646465324160f006ceb1d7fd7d4a8f7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        vnf_instance_dict.update(links)"},{"line_number":68,"context_line":"        return vnf_instance_dict"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def create(self, vnf_instance, api_version\u003dNone):"},{"line_number":71,"context_line":"        return self._get_vnf_instance_info(vnf_instance, api_version)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def show(self, vnf_instance):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_df4638a7","line":70,"range":{"start_line":70,"start_character":35,"end_line":70,"end_character":46},"in_reply_to":"9f560f44_f4f895c4","updated":"2020-09-13 08:36:09.000000000","message":"Done","commit_id":"e248dfa7c6834105ec586321c8084b9c8b72f2b8"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"4e5996ebb88cc7b835ade8ca244fa8662fb071a6","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return vnf_instance_dict"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def create(self, vnf_instance, api_version\u003dNone):"},{"line_number":71,"context_line":"        return self._get_vnf_instance_info(vnf_instance, api_version)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def show(self, vnf_instance):"},{"line_number":74,"context_line":"        return self._get_vnf_instance_info(vnf_instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d4f3d1e5","line":71,"range":{"start_line":71,"start_character":57,"end_line":71,"end_character":68},"updated":"2020-09-11 13:25:20.000000000","message":"It is necessary to modify the logic so that it does not refer to api_version.","commit_id":"e248dfa7c6834105ec586321c8084b9c8b72f2b8"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"185fbd85b646465324160f006ceb1d7fd7d4a8f7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return vnf_instance_dict"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def create(self, vnf_instance, api_version\u003dNone):"},{"line_number":71,"context_line":"        return self._get_vnf_instance_info(vnf_instance, api_version)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def show(self, vnf_instance):"},{"line_number":74,"context_line":"        return self._get_vnf_instance_info(vnf_instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3fc77414","line":71,"range":{"start_line":71,"start_character":57,"end_line":71,"end_character":68},"in_reply_to":"9f560f44_d4f3d1e5","updated":"2020-09-13 08:36:09.000000000","message":"Done","commit_id":"e248dfa7c6834105ec586321c8084b9c8b72f2b8"}],"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1073cd187c6b2592633db5d70327de06a2534995","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def create(self, request, body):"},{"line_number":166,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":167,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027create\u0027)"},{"line_number":168,"context_line":"        api_version \u003d request.headers[\u0027Version\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        req_body \u003d utils.convert_camelcase_to_snakecase(body)"},{"line_number":171,"context_line":"        vnfd_id \u003d req_body.get(\u0027vnfd_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_89d33738","line":168,"updated":"2020-08-24 09:31:09.000000000","message":"Is it guaranteed that the \u0027Version\u0027 can be obtained from the header according to the ETSI NFV-SOL specifications?\nI also made a similar comment in 746485 patch.","commit_id":"48fcf2297232169d8cc8c7351801b101ab3baad2"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"916c16b63ce81ef60372b6279850140a3974894d","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def create(self, request, body):"},{"line_number":166,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":167,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027create\u0027)"},{"line_number":168,"context_line":"        api_version \u003d request.headers[\u0027Version\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        req_body \u003d utils.convert_camelcase_to_snakecase(body)"},{"line_number":171,"context_line":"        vnfd_id \u003d req_body.get(\u0027vnfd_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ff4d983b","line":168,"in_reply_to":"9f560f44_3ce4740e","updated":"2020-09-03 09:35:28.000000000","message":"Modified the code as pointed (using \u0027.get()\u0027)","commit_id":"48fcf2297232169d8cc8c7351801b101ab3baad2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d8089068349d2b41494dc5afdb83adff77387de1","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def create(self, request, body):"},{"line_number":166,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":167,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027create\u0027)"},{"line_number":168,"context_line":"        api_version \u003d request.headers[\u0027Version\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        req_body \u003d utils.convert_camelcase_to_snakecase(body)"},{"line_number":171,"context_line":"        vnfd_id \u003d req_body.get(\u0027vnfd_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_86b3d40a","line":168,"in_reply_to":"9f560f44_46fc1c0c","updated":"2020-08-28 07:49:56.000000000","message":"I could find the definition in SOL013 4.2.2.\nThe example has the following description.\n  1.2.0 or 1.2.0- impl:example.com:myProduct:4\nIn addition to Ito\u0027s comment, it seems that there is no clear provision in the description of version.\nIs it okay to rely on this information to switch processing?","commit_id":"48fcf2297232169d8cc8c7351801b101ab3baad2"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"78bd4fc1a4daf6c66fd6e83b7a9f2f0bc60821b6","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def create(self, request, body):"},{"line_number":166,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":167,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027create\u0027)"},{"line_number":168,"context_line":"        api_version \u003d request.headers[\u0027Version\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        req_body \u003d utils.convert_camelcase_to_snakecase(body)"},{"line_number":171,"context_line":"        vnfd_id \u003d req_body.get(\u0027vnfd_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8caf737c","line":168,"in_reply_to":"9f560f44_86b3d40a","updated":"2020-08-28 10:22:25.000000000","message":"The material we are referring to is gs_nfv-sol013v020601p.pdf (not SOL003 as earlier mentioned). You can find the description in 4.2.2. Additionally, Section 9.4 also describes about Version Signaling.\n-----\nAPI consumers conforming to versions of the ETSI NFV-SOL API specifications previous to version 2.5.1 omit this header. If the API producer receives a request without this header:..","commit_id":"48fcf2297232169d8cc8c7351801b101ab3baad2"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"3c2844e2bc19a77d052c31a9c000da1506142115","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def create(self, request, body):"},{"line_number":166,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":167,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027create\u0027)"},{"line_number":168,"context_line":"        api_version \u003d request.headers[\u0027Version\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        req_body \u003d utils.convert_camelcase_to_snakecase(body)"},{"line_number":171,"context_line":"        vnfd_id \u003d req_body.get(\u0027vnfd_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f9afe6df","line":168,"in_reply_to":"9f560f44_89d33738","updated":"2020-08-27 01:28:24.000000000","message":"Based on Sol003 4.2.2, it is assumed to be acquired from the version of Request Header Fields.","commit_id":"48fcf2297232169d8cc8c7351801b101ab3baad2"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"396663f350a93584bc02013f3ef85b24973f11d5","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def create(self, request, body):"},{"line_number":166,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":167,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027create\u0027)"},{"line_number":168,"context_line":"        api_version \u003d request.headers[\u0027Version\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        req_body \u003d utils.convert_camelcase_to_snakecase(body)"},{"line_number":171,"context_line":"        vnfd_id \u003d req_body.get(\u0027vnfd_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3ce4740e","line":168,"in_reply_to":"9f560f44_8caf737c","updated":"2020-09-01 00:42:09.000000000","message":"Thank you for sharing the reference. In my undesrstanding, the \"Version\" header is different from the version of SOL document but it should be the version of API implementation.\n\nIt\u0027s clear from the fact that we use the major version of API \"v1\" in vnflcm. This major version is described in section 9.3.3.2 and clause 4.1 in SOL013 v2.6.1.\n\nAs you mentioned, we should support this API Version header in future, but I think we should not force all API consumers to set the Version header because we don\u0027t support \"GET {apiRoot}/{apiName}/api_versions\" and they cannot decide what version should be used in the header.\n\n\nFrom another point of view, it leads \"KeyError\" to get directly the key \u0027Version\u0027 from dict, so it\u0027s better to use \u0027.get()\u0027.","commit_id":"48fcf2297232169d8cc8c7351801b101ab3baad2"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"9937327b4dbf88862bb9dccef3b16d841a56a0c3","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def create(self, request, body):"},{"line_number":166,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":167,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027create\u0027)"},{"line_number":168,"context_line":"        api_version \u003d request.headers[\u0027Version\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        req_body \u003d utils.convert_camelcase_to_snakecase(body)"},{"line_number":171,"context_line":"        vnfd_id \u003d req_body.get(\u0027vnfd_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_46fc1c0c","line":168,"in_reply_to":"9f560f44_f9afe6df","updated":"2020-08-28 07:19:11.000000000","message":"I couldn\u0027t find the part you mentioned. Section 4.2 is Void and 4.2.2 doesn\u0027t exist in SOL003 v2.4.1.\n\nThis change breaks all CLI based operation with tacker-pythonclient because all requests from CLI don\u0027t contain header of \u0027Version\u0027 and it causes KeyError.","commit_id":"48fcf2297232169d8cc8c7351801b101ab3baad2"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"4e5996ebb88cc7b835ade8ca244fa8662fb071a6","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def create(self, request, body):"},{"line_number":166,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":167,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027create\u0027)"},{"line_number":168,"context_line":"        api_version \u003d request.headers.get(\u0027Version\u0027)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        req_body \u003d utils.convert_camelcase_to_snakecase(body)"},{"line_number":171,"context_line":"        vnfd_id \u003d req_body.get(\u0027vnfd_id\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_945959fe","line":168,"range":{"start_line":168,"start_character":8,"end_line":168,"end_character":19},"updated":"2020-09-11 13:25:20.000000000","message":"It is necessary to modify the logic so that it does not refer to api_version.","commit_id":"e248dfa7c6834105ec586321c8084b9c8b72f2b8"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"185fbd85b646465324160f006ceb1d7fd7d4a8f7","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def create(self, request, body):"},{"line_number":166,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":167,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027create\u0027)"},{"line_number":168,"context_line":"        api_version \u003d request.headers.get(\u0027Version\u0027)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        req_body \u003d utils.convert_camelcase_to_snakecase(body)"},{"line_number":171,"context_line":"        vnfd_id \u003d req_body.get(\u0027vnfd_id\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1fca7018","line":168,"range":{"start_line":168,"start_character":8,"end_line":168,"end_character":19},"in_reply_to":"9f560f44_945959fe","updated":"2020-09-13 08:36:09.000000000","message":"Done","commit_id":"e248dfa7c6834105ec586321c8084b9c8b72f2b8"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"4e5996ebb88cc7b835ade8ca244fa8662fb071a6","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            tenant_id\u003drequest.context.project_id)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        vnf_instance.create()"},{"line_number":193,"context_line":"        result \u003d self._view_builder.create(vnf_instance, api_version)"},{"line_number":194,"context_line":"        headers \u003d {\"location\": self._get_vnf_instance_href(vnf_instance)}"},{"line_number":195,"context_line":"        return wsgi.ResponseObject(result, headers\u003dheaders)"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d46e3194","line":193,"range":{"start_line":193,"start_character":57,"end_line":193,"end_character":68},"updated":"2020-09-11 13:25:20.000000000","message":"It is necessary to modify the logic so that it does not refer to api_version.","commit_id":"e248dfa7c6834105ec586321c8084b9c8b72f2b8"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"185fbd85b646465324160f006ceb1d7fd7d4a8f7","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            tenant_id\u003drequest.context.project_id)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        vnf_instance.create()"},{"line_number":193,"context_line":"        result \u003d self._view_builder.create(vnf_instance, api_version)"},{"line_number":194,"context_line":"        headers \u003d {\"location\": self._get_vnf_instance_href(vnf_instance)}"},{"line_number":195,"context_line":"        return wsgi.ResponseObject(result, headers\u003dheaders)"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7fcd6c2e","line":193,"range":{"start_line":193,"start_character":57,"end_line":193,"end_character":68},"in_reply_to":"9f560f44_d46e3194","updated":"2020-09-13 08:36:09.000000000","message":"Done","commit_id":"e248dfa7c6834105ec586321c8084b9c8b72f2b8"}],"tacker/tests/unit/vnflcm/test_controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1073cd187c6b2592633db5d70327de06a2534995","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from tacker.vnfm import vim_client"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class FakeVNFMPlugin(mock.Mock):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self):"},{"line_number":39,"context_line":"        super(FakeVNFMPlugin, self).__init__()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a9427b0d","line":36,"updated":"2020-08-24 09:31:09.000000000","message":"You should set the 746485 patch to the parent of this patch.\nBecause the same fix has been made.","commit_id":"48fcf2297232169d8cc8c7351801b101ab3baad2"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"3c2844e2bc19a77d052c31a9c000da1506142115","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from tacker.vnfm import vim_client"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class FakeVNFMPlugin(mock.Mock):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self):"},{"line_number":39,"context_line":"        super(FakeVNFMPlugin, self).__init__()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_398f9e75","line":36,"in_reply_to":"9f560f44_a9427b0d","updated":"2020-08-27 01:28:24.000000000","message":"For now we don\u0027t agree with this suggestion since in the functionality point of view, List is another function.","commit_id":"48fcf2297232169d8cc8c7351801b101ab3baad2"},{"author":{"_account_id":30901,"name":"Masazumi ota","email":"masazumi.oota.ds@hco.ntt.co.jp"},"change_message_id":"960db2d9d6eb3196ed0ab2f93cc8f1ad4dac9df0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.controller \u003d controller.VnfLcmController()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def tearDown(self):"},{"line_number":68,"context_line":"        # 2. patcher の終了"},{"line_number":69,"context_line":"        self.mock_manager.stop()"},{"line_number":70,"context_line":"        super(TestController, self).tearDown()"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_50ea92d7","line":68,"updated":"2020-08-20 11:56:56.000000000","message":"Don\u0027t include japanese.","commit_id":"48fcf2297232169d8cc8c7351801b101ab3baad2"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"3c2844e2bc19a77d052c31a9c000da1506142115","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.controller \u003d controller.VnfLcmController()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def tearDown(self):"},{"line_number":68,"context_line":"        # 2. patcher の終了"},{"line_number":69,"context_line":"        self.mock_manager.stop()"},{"line_number":70,"context_line":"        super(TestController, self).tearDown()"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fe77ccd2","line":68,"in_reply_to":"9f560f44_50ea92d7","updated":"2020-08-27 01:28:24.000000000","message":"We have removed the comment in the latest patch.","commit_id":"48fcf2297232169d8cc8c7351801b101ab3baad2"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"40a5a709a1b7833139884034f046d6da4312db03","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self):"},{"line_number":39,"context_line":"        super(FakeVNFMPlugin, self).__init__()"},{"line_number":40,"context_line":"        self.vnf1_vnfd_id \u003d \u0027eb094833-995e-49f0-a047-dfb56aaf7c4e\u0027"},{"line_number":41,"context_line":"        self.vnf1_vnf_id \u003d \u002791e32c20-6d1f-47a4-9ba7-08f5e5effe07\u0027"},{"line_number":42,"context_line":"        self.vnf1_update_vnf_id \u003d \u002791e32c20-6d1f-47a4-9ba7-08f5e5effaf6\u0027"},{"line_number":43,"context_line":"        self.vnf3_vnfd_id \u003d \u0027e4015e9f-1ef2-49fb-adb6-070791ad3c45\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ed049fc8","line":40,"updated":"2020-09-07 19:10:32.000000000","message":"Why don\u0027t you make members `vnf1...`, `vnf2...` or so to make a list of dicts to make it be more understandable, like as following to be referred.\n```\n  self.vnfs[0][\u0027vnfd_id\u0027]\n  self.vnfs[0][\u0027vnf_id\u0027]\n  self.vnfs[1][\u0027update_vnf_id\u0027]\n  ...\n```","commit_id":"b66d2182d0cc96abe4ca9df6d81f721c543058eb"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"b2049e05e11edd8b92ef71cf56479d242b04b3f7","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self):"},{"line_number":39,"context_line":"        super(FakeVNFMPlugin, self).__init__()"},{"line_number":40,"context_line":"        self.vnf1_vnfd_id \u003d \u0027eb094833-995e-49f0-a047-dfb56aaf7c4e\u0027"},{"line_number":41,"context_line":"        self.vnf1_vnf_id \u003d \u002791e32c20-6d1f-47a4-9ba7-08f5e5effe07\u0027"},{"line_number":42,"context_line":"        self.vnf1_update_vnf_id \u003d \u002791e32c20-6d1f-47a4-9ba7-08f5e5effaf6\u0027"},{"line_number":43,"context_line":"        self.vnf3_vnfd_id \u003d \u0027e4015e9f-1ef2-49fb-adb6-070791ad3c45\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b10ca742","line":40,"in_reply_to":"9f560f44_ed049fc8","updated":"2020-09-09 07:37:16.000000000","message":"There is the same code in test_nfvo_client.py, so this code is removed and changed to be imported from the file.","commit_id":"b66d2182d0cc96abe4ca9df6d81f721c543058eb"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"9937327b4dbf88862bb9dccef3b16d841a56a0c3","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    @mock.patch.object(objects.vnf_package.VnfPackage, \u0027save\u0027)"},{"line_number":170,"context_line":"    @mock.patch.object(objects.vnf_instance, \u0027_vnf_instance_create\u0027)"},{"line_number":171,"context_line":"    @mock.patch.object(objects.vnf_package_vnfd.VnfPackageVnfd, \u0027get_by_id\u0027)"},{"line_number":172,"context_line":"    def test_create_with_vnf_pkg_id("},{"line_number":173,"context_line":"            self, mock_get_by_id_package_vnfd,"},{"line_number":174,"context_line":"            mock_vnf_instance_create, mock_package_save,"},{"line_number":175,"context_line":"            mock_get_by_id_package, mock_get_vim):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e644504a","line":172,"range":{"start_line":172,"start_character":8,"end_line":172,"end_character":35},"updated":"2020-08-28 07:19:11.000000000","message":"This method name is confusing. It implies to create VnfInstance with vnfPkdId in request body.\n\nSomething like \"test_create_without_name_and_description_with_v241\" is better.","commit_id":"b66d2182d0cc96abe4ca9df6d81f721c543058eb"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"b2049e05e11edd8b92ef71cf56479d242b04b3f7","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    @mock.patch.object(objects.vnf_package.VnfPackage, \u0027save\u0027)"},{"line_number":170,"context_line":"    @mock.patch.object(objects.vnf_instance, \u0027_vnf_instance_create\u0027)"},{"line_number":171,"context_line":"    @mock.patch.object(objects.vnf_package_vnfd.VnfPackageVnfd, \u0027get_by_id\u0027)"},{"line_number":172,"context_line":"    def test_create_with_vnf_pkg_id("},{"line_number":173,"context_line":"            self, mock_get_by_id_package_vnfd,"},{"line_number":174,"context_line":"            mock_vnf_instance_create, mock_package_save,"},{"line_number":175,"context_line":"            mock_get_by_id_package, mock_get_vim):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_31bd3768","line":172,"range":{"start_line":172,"start_character":8,"end_line":172,"end_character":35},"in_reply_to":"9f560f44_6d4a4f27","updated":"2020-09-09 07:37:16.000000000","message":"Renamed as you suggested.","commit_id":"b66d2182d0cc96abe4ca9df6d81f721c543058eb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"40a5a709a1b7833139884034f046d6da4312db03","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    @mock.patch.object(objects.vnf_package.VnfPackage, \u0027save\u0027)"},{"line_number":170,"context_line":"    @mock.patch.object(objects.vnf_instance, \u0027_vnf_instance_create\u0027)"},{"line_number":171,"context_line":"    @mock.patch.object(objects.vnf_package_vnfd.VnfPackageVnfd, \u0027get_by_id\u0027)"},{"line_number":172,"context_line":"    def test_create_with_vnf_pkg_id("},{"line_number":173,"context_line":"            self, mock_get_by_id_package_vnfd,"},{"line_number":174,"context_line":"            mock_vnf_instance_create, mock_package_save,"},{"line_number":175,"context_line":"            mock_get_by_id_package, mock_get_vim):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6d4a4f27","line":172,"range":{"start_line":172,"start_character":8,"end_line":172,"end_character":35},"in_reply_to":"9f560f44_e644504a","updated":"2020-09-07 19:10:32.000000000","message":"+1 for yoshito\u0027s comment if you add what is created in the suggested method name.","commit_id":"b66d2182d0cc96abe4ca9df6d81f721c543058eb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"40a5a709a1b7833139884034f046d6da4312db03","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self):"},{"line_number":39,"context_line":"        super(FakeVNFMPlugin, self).__init__()"},{"line_number":40,"context_line":"        self.vnf1_vnfd_id \u003d \u0027eb094833-995e-49f0-a047-dfb56aaf7c4e\u0027"},{"line_number":41,"context_line":"        self.vnf1_vnf_id \u003d \u002791e32c20-6d1f-47a4-9ba7-08f5e5effe07\u0027"},{"line_number":42,"context_line":"        self.vnf1_update_vnf_id \u003d \u002791e32c20-6d1f-47a4-9ba7-08f5e5effaf6\u0027"},{"line_number":43,"context_line":"        self.vnf3_vnfd_id \u003d \u0027e4015e9f-1ef2-49fb-adb6-070791ad3c45\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_0db753f7","line":40,"updated":"2020-09-07 19:10:32.000000000","message":"Why don\u0027t you make members `vnf1...`, `vnf2...` or so to make a list of dicts to make it be more understandable, like as following to be referred.\n```\n  self.vnfs[0][\u0027vnfd_id\u0027]\n  self.vnfs[0][\u0027vnf_id\u0027]\n  self.vnfs[1][\u0027update_vnf_id\u0027]\n  ...\n```","commit_id":"f6254c7657a2e28284936d196d28fd184f730862"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"b2049e05e11edd8b92ef71cf56479d242b04b3f7","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self):"},{"line_number":39,"context_line":"        super(FakeVNFMPlugin, self).__init__()"},{"line_number":40,"context_line":"        self.vnf1_vnfd_id \u003d \u0027eb094833-995e-49f0-a047-dfb56aaf7c4e\u0027"},{"line_number":41,"context_line":"        self.vnf1_vnf_id \u003d \u002791e32c20-6d1f-47a4-9ba7-08f5e5effe07\u0027"},{"line_number":42,"context_line":"        self.vnf1_update_vnf_id \u003d \u002791e32c20-6d1f-47a4-9ba7-08f5e5effaf6\u0027"},{"line_number":43,"context_line":"        self.vnf3_vnfd_id \u003d \u0027e4015e9f-1ef2-49fb-adb6-070791ad3c45\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_d1ff9bff","line":40,"in_reply_to":"9f560f44_0db753f7","updated":"2020-09-09 07:37:16.000000000","message":"There is the same code in test_nfvo_client.py, so this code is removed and changed to be imported from the file.","commit_id":"f6254c7657a2e28284936d196d28fd184f730862"}]}