)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  satisfy our k8s client usage"},{"line_number":18,"context_line":"  (kubernets:6.0.0-\u003e11.0.0, urllib3:1.22.0-\u003e1.24.2)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Dependency:"},{"line_number":21,"context_line":"* artifact support:https://review.opendev.org/#/c/739697/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I20ffbaec14ac5fb8236bd61416c2604b7a6590f6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_2cbcc66a","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":57},"updated":"2020-09-23 10:34:22.000000000","message":"We can understand dependency from gerrit. In addition, it has no meaning after your patches are merged actually. So, no need  to explain it in commit message.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  satisfy our k8s client usage"},{"line_number":18,"context_line":"  (kubernets:6.0.0-\u003e11.0.0, urllib3:1.22.0-\u003e1.24.2)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Dependency:"},{"line_number":21,"context_line":"* artifact support:https://review.opendev.org/#/c/739697/"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I20ffbaec14ac5fb8236bd61416c2604b7a6590f6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_18375cb2","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":57},"in_reply_to":"9f560f44_2cbcc66a","updated":"2020-09-24 11:05:37.000000000","message":"Thanks for advice, we have removed dependecy part in the latest patch","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"lower-constraints.txt":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"f8f7c4055835f66b99d7de292f63316a497695bf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"keystoneauth1\u003d\u003d3.15.0"},{"line_number":49,"context_line":"keystonemiddleware\u003d\u003d4.17.0"},{"line_number":50,"context_line":"kombu\u003d\u003d4.3.0"},{"line_number":51,"context_line":"kombu\u003d\u003d4.0.0"},{"line_number":52,"context_line":"linecache2\u003d\u003d1.0.0"},{"line_number":53,"context_line":"Mako\u003d\u003d1.0.7"},{"line_number":54,"context_line":"MarkupSafe\u003d\u003d1.1"}],"source_content_type":"text/plain","patch_set":7,"id":"9f560f44_68ff2f00","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":12},"updated":"2020-09-17 04:13:33.000000000","message":"kubernetes is missing.","commit_id":"3382efc09b7e2199e0f2d42a02a365c8677d4617"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"418596fcfbab48178c9ee60a6c122a86654ff116","unresolved":false,"context_lines":[{"line_number":48,"context_line":"keystoneauth1\u003d\u003d3.15.0"},{"line_number":49,"context_line":"keystonemiddleware\u003d\u003d4.17.0"},{"line_number":50,"context_line":"kombu\u003d\u003d4.3.0"},{"line_number":51,"context_line":"kombu\u003d\u003d4.0.0"},{"line_number":52,"context_line":"linecache2\u003d\u003d1.0.0"},{"line_number":53,"context_line":"Mako\u003d\u003d1.0.7"},{"line_number":54,"context_line":"MarkupSafe\u003d\u003d1.1"}],"source_content_type":"text/plain","patch_set":7,"id":"9f560f44_08a03391","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":12},"in_reply_to":"9f560f44_68ff2f00","updated":"2020-09-17 05:15:04.000000000","message":"Sorry for mistake, we rebased newest master and solved the confict in this file. This is fixed in the latest patch","commit_id":"3382efc09b7e2199e0f2d42a02a365c8677d4617"}],"tacker/common/exceptions.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"class CreateApiFalse(TackerException):"},{"line_number":143,"context_line":"    message \u003d _(\u0027The request to create a resource failed.\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"class InitApiFalse(TackerException):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_ac7456d1","line":143,"updated":"2020-09-23 10:34:22.000000000","message":"Simply \"Failed to create resource\" is better and understandable at a glance.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"class CreateApiFalse(TackerException):"},{"line_number":143,"context_line":"    message \u003d _(\u0027The request to create a resource failed.\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"class InitApiFalse(TackerException):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_b8b63024","line":143,"in_reply_to":"9f560f44_ac7456d1","updated":"2020-09-24 11:05:37.000000000","message":"Thanks for suggestion, we have fixed it in the latest patch","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"class InitApiFalse(TackerException):"},{"line_number":147,"context_line":"    message \u003d _(\u0027The method to init a resource failed.\u0027)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class ReadEndpoindsFalse(TackerException):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_8c7192e1","line":147,"updated":"2020-09-23 10:34:22.000000000","message":"\"Failed to init ...\" is better as previous one.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"class InitApiFalse(TackerException):"},{"line_number":147,"context_line":"    message \u003d _(\u0027The method to init a resource failed.\u0027)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class ReadEndpoindsFalse(TackerException):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_d8bb240c","line":147,"in_reply_to":"9f560f44_8c7192e1","updated":"2020-09-24 11:05:37.000000000","message":"Thanks for suggestion, we have fixed it in the latest patch","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/db/migration/alembic_migrations/versions/985e28392890_add_vnflcm_db.py":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"e23ccfc3dbfb89a22bba9f52c16a52ec61f70e16","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        sa.Column(\u0027vnf_virtual_link_resource_info\u0027, sa.JSON(), nullable\u003dTrue),"},{"line_number":76,"context_line":"        sa.Column(\u0027virtual_storage_resource_info\u0027, sa.JSON(), nullable\u003dTrue),"},{"line_number":77,"context_line":"        sa.Column(\u0027vnf_state\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":78,"context_line":"        sa.Column(\u0027instance_id\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":79,"context_line":"        sa.Column(\u0027instantiation_level_id\u0027,"},{"line_number":80,"context_line":"                  sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":81,"context_line":"        sa.Column(\u0027additional_params\u0027, sa.JSON(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_3e73db18","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":59},"updated":"2020-09-15 07:55:15.000000000","message":"When updating the DB schema, you need to create a new script instead of updating the existing DB migration script because consider the case of DB upgrade from U release to V release.\nI think that the script can be generated automatically or create new script.\nPlease refer to [1] or [2] for detail.\n[1] https://docs.openstack.org/neutron/latest/contributor/alembic_migrations.html\n[2] tacker/db/migration/README","commit_id":"2ee83dfa6d6f8f1d3664be8ba4dd57d4e16875ec"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"8df344e1bfb5819a95856ca2aba6d905330b1772","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        sa.Column(\u0027vnf_virtual_link_resource_info\u0027, sa.JSON(), nullable\u003dTrue),"},{"line_number":76,"context_line":"        sa.Column(\u0027virtual_storage_resource_info\u0027, sa.JSON(), nullable\u003dTrue),"},{"line_number":77,"context_line":"        sa.Column(\u0027vnf_state\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":78,"context_line":"        sa.Column(\u0027instance_id\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":79,"context_line":"        sa.Column(\u0027instantiation_level_id\u0027,"},{"line_number":80,"context_line":"                  sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":81,"context_line":"        sa.Column(\u0027additional_params\u0027, sa.JSON(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_58e6f4b1","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":59},"in_reply_to":"9f560f44_00f11a96","updated":"2020-09-24 11:25:35.000000000","message":"new script is updated :https://review.opendev.org/#/c/746691/10..12/tacker/db/migration/alembic_migrations/versions/aaf461c8844c_change_type_for_vnf_resources.py\nplease kindly have a check, and thank you so much for this suggestion","commit_id":"2ee83dfa6d6f8f1d3664be8ba4dd57d4e16875ec"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        sa.Column(\u0027vnf_virtual_link_resource_info\u0027, sa.JSON(), nullable\u003dTrue),"},{"line_number":76,"context_line":"        sa.Column(\u0027virtual_storage_resource_info\u0027, sa.JSON(), nullable\u003dTrue),"},{"line_number":77,"context_line":"        sa.Column(\u0027vnf_state\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":78,"context_line":"        sa.Column(\u0027instance_id\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":79,"context_line":"        sa.Column(\u0027instantiation_level_id\u0027,"},{"line_number":80,"context_line":"                  sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":81,"context_line":"        sa.Column(\u0027additional_params\u0027, sa.JSON(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_00f11a96","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":59},"in_reply_to":"9f560f44_3e73db18","updated":"2020-09-24 11:05:37.000000000","message":"\u003e When updating the DB schema, you need to create a new script\n \u003e instead of updating the existing DB migration script because\n \u003e consider the case of DB upgrade from U release to V release.\n \u003e I think that the script can be generated automatically or create\n \u003e new script.\n \u003e Please refer to [1] or [2] for detail.\n \u003e [1] https://docs.openstack.org/neutron/latest/contributor/alembic_migrations.html\n \u003e [2] tacker/db/migration/README","commit_id":"2ee83dfa6d6f8f1d3664be8ba4dd57d4e16875ec"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"e23ccfc3dbfb89a22bba9f52c16a52ec61f70e16","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        \u0027vnf_resources\u0027,"},{"line_number":94,"context_line":"        sa.Column(\u0027id\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"},{"line_number":95,"context_line":"        sa.Column(\u0027vnf_instance_id\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"},{"line_number":96,"context_line":"        sa.Column(\u0027resource_name\u0027, sa.Text(), nullable\u003dFalse),"},{"line_number":97,"context_line":"        sa.Column(\u0027resource_type\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":98,"context_line":"        sa.Column(\u0027resource_identifier\u0027, sa.String(length\u003d255),"},{"line_number":99,"context_line":"                  nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_1e709708","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":62},"updated":"2020-09-15 07:55:15.000000000","message":"same as above","commit_id":"2ee83dfa6d6f8f1d3664be8ba4dd57d4e16875ec"}],"tacker/db/migration/alembic_migrations/versions/aaf461c8844c_change_type_for_vnf_resources.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 FUJITSU DATA"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_2c2fa6a7","line":1,"updated":"2020-09-23 10:34:22.000000000","message":"It must be a mistake, right?","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 FUJITSU DATA"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_f8d42849","line":1,"in_reply_to":"9f560f44_2c2fa6a7","updated":"2020-09-24 11:05:37.000000000","message":"Thanks for notice... we have fixed it","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"299c46dae3341c13223b61cafb596ef8380ffcf4","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# revision identifiers, used by Alembic."},{"line_number":27,"context_line":"revision \u003d \u0027aaf461c8844c\u0027"},{"line_number":28,"context_line":"down_revision \u003d \u0027e06fbdc90a32\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from alembic import op"},{"line_number":31,"context_line":"import sqlalchemy as sa"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_0a6c1405","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":30},"updated":"2020-09-25 03:47:22.000000000","message":"You should change to `down_revision` to the previous  revision.","commit_id":"abc02a8b726513f517b981cc846bbc59087fec20"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"718f5abebcd4f7ce672e9b331d4a3b1e2f47a66a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# revision identifiers, used by Alembic."},{"line_number":27,"context_line":"revision \u003d \u0027aaf461c8844c\u0027"},{"line_number":28,"context_line":"down_revision \u003d \u0027e06fbdc90a32\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from alembic import op"},{"line_number":31,"context_line":"import sqlalchemy as sa"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_8afe6403","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":30},"in_reply_to":"9f560f44_0a6c1405","updated":"2020-09-25 04:00:02.000000000","message":"Thanks for help！","commit_id":"abc02a8b726513f517b981cc846bbc59087fec20"}],"tacker/extensions/vnfm.py":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class CnfDefinitionNotFound(exceptions.NotFound):"},{"line_number":104,"context_line":"    message \u003d _("},{"line_number":105,"context_line":"        \"CNF definition file with path %(path)s not found in vnf_artifacts.\")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class CNFCreateWaitFailed(exceptions.TackerException):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_5b13d301","line":105,"range":{"start_line":105,"start_character":48,"end_line":105,"end_character":57},"updated":"2020-09-21 19:12:36.000000000","message":"\"s/\u0027not found\u0027/\u0027is not found\u0027/\"","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class CnfDefinitionNotFound(exceptions.NotFound):"},{"line_number":104,"context_line":"    message \u003d _("},{"line_number":105,"context_line":"        \"CNF definition file with path %(path)s not found in vnf_artifacts.\")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class CNFCreateWaitFailed(exceptions.TackerException):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_04bc1cda","line":105,"range":{"start_line":105,"start_character":48,"end_line":105,"end_character":57},"in_reply_to":"9f560f44_5b13d301","updated":"2020-09-24 11:05:37.000000000","message":"fixed in latest patch, please kindly have a confirm :)","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class CNFCreateWaitFailed(exceptions.TackerException):"},{"line_number":109,"context_line":"    message \u003d _(\u0027CNF Create %(reason)s\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class ServiceTypeNotFound(exceptions.NotFound):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_9bd60b27","line":109,"range":{"start_line":109,"start_character":17,"end_line":109,"end_character":28},"updated":"2020-09-21 19:12:36.000000000","message":"s/\u0027CNF Create\u0027/\u0027CNF Create Failed with reason:\u0027/","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class CNFCreateWaitFailed(exceptions.TackerException):"},{"line_number":109,"context_line":"    message \u003d _(\u0027CNF Create %(reason)s\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class ServiceTypeNotFound(exceptions.NotFound):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_e4be48d2","line":109,"range":{"start_line":109,"start_character":17,"end_line":109,"end_character":28},"in_reply_to":"9f560f44_9bd60b27","updated":"2020-09-24 11:05:37.000000000","message":"fixed in latest patch, please kindly have a confirm :)","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/objects/fields.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"36b21885af983cdb53e92d77e119525b1fe0e597","unresolved":false,"context_lines":[{"line_number":23,"context_line":"ListOfObjectsField \u003d fields.ListOfObjectsField"},{"line_number":24,"context_line":"ListOfStringsField \u003d fields.ListOfStringsField"},{"line_number":25,"context_line":"DictOfStringsField \u003d fields.DictOfStringsField"},{"line_number":26,"context_line":"DictOfListOfStringsField \u003d fields.DictOfListOfStringsField"},{"line_number":27,"context_line":"DictOfNullableStringsField \u003d fields.DictOfNullableStringsField"},{"line_number":28,"context_line":"DateTimeField \u003d fields.DateTimeField"},{"line_number":29,"context_line":"BooleanField \u003d fields.BooleanField"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_92ce7c2a","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":58},"updated":"2020-08-28 00:39:26.000000000","message":"Why is this field added?","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"8df344e1bfb5819a95856ca2aba6d905330b1772","unresolved":false,"context_lines":[{"line_number":23,"context_line":"ListOfObjectsField \u003d fields.ListOfObjectsField"},{"line_number":24,"context_line":"ListOfStringsField \u003d fields.ListOfStringsField"},{"line_number":25,"context_line":"DictOfStringsField \u003d fields.DictOfStringsField"},{"line_number":26,"context_line":"DictOfListOfStringsField \u003d fields.DictOfListOfStringsField"},{"line_number":27,"context_line":"DictOfNullableStringsField \u003d fields.DictOfNullableStringsField"},{"line_number":28,"context_line":"DateTimeField \u003d fields.DateTimeField"},{"line_number":29,"context_line":"BooleanField \u003d fields.BooleanField"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_98940c46","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":58},"in_reply_to":"9f560f44_92ce7c2a","updated":"2020-09-24 11:25:35.000000000","message":"this field is removed in the latest patch, please kindly have a check","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"}],"tacker/tests/etc/samples/etsi/nfv/sample_kubernetes_driver/Files/images/cirros.img":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"2c5a01c217551cc846a271cf531f81eec8afa677","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#### THIS IS A DUMMY FILE TO SAVE FILE SIZE #####"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_0b08562b","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":49},"updated":"2020-08-30 04:29:36.000000000","message":"There are the following two image files in a `/Files/images/` directory.\n・cirros-0.4.0-x86_64-disk.img\n・cirros.img\n\nWould you need `cirros.img` image?","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"8df344e1bfb5819a95856ca2aba6d905330b1772","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#### THIS IS A DUMMY FILE TO SAVE FILE SIZE #####"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_b895903f","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":49},"in_reply_to":"9f560f44_0b08562b","updated":"2020-09-24 11:25:35.000000000","message":"This dummy file is deleted by refactoring of test data","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"}],"tacker/tests/etc/samples/etsi/nfv/sample_kubernetes_driver/Files/kubernetes/testdata_artifact_file_content.yaml":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":2,"context_line":"kind: Pod"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-endpoint-test001"},{"line_number":5,"context_line":"  namespace: curry-ns"},{"line_number":6,"context_line":"spec:"},{"line_number":7,"context_line":"  containers:"},{"line_number":8,"context_line":"  - image: celebdor/kuryr-demo"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_bbb66fdb","line":5,"updated":"2020-09-21 19:12:36.000000000","message":"Do we want to add labels to POD?\n\nFor ex,\nmetadata:\n  name: curry-endpoint-test001\n  namespace: curry-ns \n  labels:\n    role: my-curry","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":2,"context_line":"kind: Pod"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-endpoint-test001"},{"line_number":5,"context_line":"  namespace: curry-ns"},{"line_number":6,"context_line":"spec:"},{"line_number":7,"context_line":"  containers:"},{"line_number":8,"context_line":"  - image: celebdor/kuryr-demo"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_e4a3e8af","line":5,"in_reply_to":"9f560f44_bbb66fdb","updated":"2020-09-24 11:05:37.000000000","message":"Thanks for suggestion, labels is added in latest patch, please kindly have a check","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/sample_kubernetes_driver/TOSCA-Metadata/TOSCA.meta":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"2c5a01c217551cc846a271cf531f81eec8afa677","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TOSCA-Meta-File-Version: 1.0"},{"line_number":2,"context_line":"Created-by: Hiroyuki JO"},{"line_number":3,"context_line":"CSAR-Version: 1.1"},{"line_number":4,"context_line":"Entry-Definitions: Definitions/helloworld3_top.vnfd.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_8b33c613","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":23},"updated":"2020-08-30 04:29:36.000000000","message":"Could you change it to \"Dummy User\"?\nThe other TOSCA.meta files are the same too.","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"418596fcfbab48178c9ee60a6c122a86654ff116","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TOSCA-Meta-File-Version: 1.0"},{"line_number":2,"context_line":"Created-by: Hiroyuki JO"},{"line_number":3,"context_line":"CSAR-Version: 1.1"},{"line_number":4,"context_line":"Entry-Definitions: Definitions/helloworld3_top.vnfd.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_2638f1d2","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":23},"in_reply_to":"9f560f44_8b33c613","updated":"2020-09-17 05:15:04.000000000","message":"We change","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"418596fcfbab48178c9ee60a6c122a86654ff116","unresolved":false,"context_lines":[{"line_number":1,"context_line":"TOSCA-Meta-File-Version: 1.0"},{"line_number":2,"context_line":"Created-by: Hiroyuki JO"},{"line_number":3,"context_line":"CSAR-Version: 1.1"},{"line_number":4,"context_line":"Entry-Definitions: Definitions/helloworld3_top.vnfd.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9f560f44_38b5b333","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":23},"in_reply_to":"9f560f44_8b33c613","updated":"2020-09-17 05:15:04.000000000","message":"We fixed here to avoid specified person name however we used Product User, we will fix it to dummy user in the new patch","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_in_multiple_yaml_with_single_resource/Files/kubernetes/replicaset_service_secret.yaml":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"2c5a01c217551cc846a271cf531f81eec8afa677","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: apps/v1"},{"line_number":3,"context_line":"kind: ReplicaSet"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  name: curry-replicaset-multiple"},{"line_number":6,"context_line":"  namespace: default"},{"line_number":7,"context_line":"spec:"},{"line_number":8,"context_line":"  replicas: 2"},{"line_number":9,"context_line":"  selector:"},{"line_number":10,"context_line":"    matchLabels:"},{"line_number":11,"context_line":"      app: nginx"},{"line_number":12,"context_line":"  template:"},{"line_number":13,"context_line":"    metadata:"},{"line_number":14,"context_line":"      labels:"},{"line_number":15,"context_line":"        app: nginx"},{"line_number":16,"context_line":"    spec:"},{"line_number":17,"context_line":"      containers:"},{"line_number":18,"context_line":"      - image: nginx"},{"line_number":19,"context_line":"        name: nginx"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: Service"},{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  labels:"},{"line_number":25,"context_line":"    app: webserver"},{"line_number":26,"context_line":"    vdu_name: curry-svc-vdu001"},{"line_number":27,"context_line":"  name: curry-svc-vdu001-multiple"},{"line_number":28,"context_line":"  namespace: default"},{"line_number":29,"context_line":"spec:"},{"line_number":30,"context_line":"  ports:"},{"line_number":31,"context_line":"  - name: \"80\""},{"line_number":32,"context_line":"    port: 80"},{"line_number":33,"context_line":"    targetPort: 8080"},{"line_number":34,"context_line":"  selector:"},{"line_number":35,"context_line":"    app: webserver"},{"line_number":36,"context_line":"  type: ClusterIP"},{"line_number":37,"context_line":"---"},{"line_number":38,"context_line":"apiVersion: v1"},{"line_number":39,"context_line":"data:"},{"line_number":40,"context_line":"  param0: a2V5MQ\u003d\u003d"},{"line_number":41,"context_line":"  param1: a2V5Mg\u003d\u003d"},{"line_number":42,"context_line":"kind: Secret"},{"line_number":43,"context_line":"metadata:"},{"line_number":44,"context_line":"  name: curry-sc-multiple"},{"line_number":45,"context_line":"  namespace: default"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_cb165e56","line":45,"range":{"start_line":1,"start_character":0,"end_line":45,"end_character":20},"updated":"2020-08-30 04:29:36.000000000","message":"This comment priority is low because improvement comment.\nThe \"service\" resource and \"secret\" resource are  created in this kubernetes object file but they are not used. I think it is better to be able to use it as kubernetes resources.\n\nFor example in this kubernetes object file, to use the secret resource created, add the following:\n```\n      containers:\n      - image: nginx\n        name: nginx\n        env:                          #add\n        - name: param0                #add\n          valueFrom:                  #add\n            secretKeyRef:             #add\n              key: param0             #add\n              name: curry-sc-multiple #add\n```\nand then to use the service resource created, change the following:\n```\n  selector:\n    matchLabels:\n      app: nginx ⇒ webserver\n  template:\n    metadata:\n      labels:\n        app: nginx ⇒ webserver\n\n```\n\nIf you use nginx container image, change the `target port` for access to a Pod.\n```\ntargetPort: 8080 ⇒ 80\n```","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"8df344e1bfb5819a95856ca2aba6d905330b1772","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"apiVersion: apps/v1"},{"line_number":3,"context_line":"kind: ReplicaSet"},{"line_number":4,"context_line":"metadata:"},{"line_number":5,"context_line":"  name: curry-replicaset-multiple"},{"line_number":6,"context_line":"  namespace: default"},{"line_number":7,"context_line":"spec:"},{"line_number":8,"context_line":"  replicas: 2"},{"line_number":9,"context_line":"  selector:"},{"line_number":10,"context_line":"    matchLabels:"},{"line_number":11,"context_line":"      app: nginx"},{"line_number":12,"context_line":"  template:"},{"line_number":13,"context_line":"    metadata:"},{"line_number":14,"context_line":"      labels:"},{"line_number":15,"context_line":"        app: nginx"},{"line_number":16,"context_line":"    spec:"},{"line_number":17,"context_line":"      containers:"},{"line_number":18,"context_line":"      - image: nginx"},{"line_number":19,"context_line":"        name: nginx"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: Service"},{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  labels:"},{"line_number":25,"context_line":"    app: webserver"},{"line_number":26,"context_line":"    vdu_name: curry-svc-vdu001"},{"line_number":27,"context_line":"  name: curry-svc-vdu001-multiple"},{"line_number":28,"context_line":"  namespace: default"},{"line_number":29,"context_line":"spec:"},{"line_number":30,"context_line":"  ports:"},{"line_number":31,"context_line":"  - name: \"80\""},{"line_number":32,"context_line":"    port: 80"},{"line_number":33,"context_line":"    targetPort: 8080"},{"line_number":34,"context_line":"  selector:"},{"line_number":35,"context_line":"    app: webserver"},{"line_number":36,"context_line":"  type: ClusterIP"},{"line_number":37,"context_line":"---"},{"line_number":38,"context_line":"apiVersion: v1"},{"line_number":39,"context_line":"data:"},{"line_number":40,"context_line":"  param0: a2V5MQ\u003d\u003d"},{"line_number":41,"context_line":"  param1: a2V5Mg\u003d\u003d"},{"line_number":42,"context_line":"kind: Secret"},{"line_number":43,"context_line":"metadata:"},{"line_number":44,"context_line":"  name: curry-sc-multiple"},{"line_number":45,"context_line":"  namespace: default"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_188abc19","line":45,"range":{"start_line":1,"start_character":0,"end_line":45,"end_character":20},"in_reply_to":"9f560f44_cb165e56","updated":"2020-09-24 11:25:35.000000000","message":"Thanks for suggestion, env field is added. Also, this file is merged into a common used file in newest patch.\nhttps://review.opendev.org/#/c/746691/4..12/tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/replicaset_service_secret.yaml","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/bindings.yaml":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":2,"context_line":"kind: Binding"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-endpoint-test001"},{"line_number":5,"context_line":"  namespace: default"},{"line_number":6,"context_line":"target:"},{"line_number":7,"context_line":"  apiVersion: v1"},{"line_number":8,"context_line":"  kind: Node"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_dbb1a3e2","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":20},"updated":"2020-09-21 19:12:36.000000000","message":"I am not sure if related;\nbut POD \u0027name: curry-endpoint-test001\u0027 has been defined with \"namespace: curry-ns\" in previous artifact file\n\"tacker/tests/etc/samples/etsi/nfv/sample_kubernetes_driver/Files/kubernetes/testdata_artifact_file_content.yaml\".\n\nIf related, please update namespace here as well.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":2,"context_line":"kind: Binding"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-endpoint-test001"},{"line_number":5,"context_line":"  namespace: default"},{"line_number":6,"context_line":"target:"},{"line_number":7,"context_line":"  apiVersion: v1"},{"line_number":8,"context_line":"  kind: Node"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_042b7cea","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":20},"in_reply_to":"9f560f44_dbb1a3e2","updated":"2020-09-24 11:05:37.000000000","message":"Thank you for advise, it seems not related here so we decide to keep this change","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/daemon-set.yaml":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    spec:"},{"line_number":15,"context_line":"      containers:"},{"line_number":16,"context_line":"      - image: nginx"},{"line_number":17,"context_line":"        name: nginx"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_1b3afb32","line":17,"updated":"2020-09-21 19:12:36.000000000","message":"I would suggest to add ports for nginx container else it is not possible to reach it from outside.\n\nFor ex, \n    spec:\n      containers:\n      - image: nginx\n        name: nginx\n        ports:\n        - containerPort: 80","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    spec:"},{"line_number":15,"context_line":"      containers:"},{"line_number":16,"context_line":"      - image: nginx"},{"line_number":17,"context_line":"        name: nginx"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_2434c048","line":17,"in_reply_to":"9f560f44_1b3afb32","updated":"2020-09-24 11:05:37.000000000","message":"Thanks for sugesstion, we have add Ports in the latest patch, please kindly have a check","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/deployment.yaml":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"e23ccfc3dbfb89a22bba9f52c16a52ec61f70e16","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        ports:"},{"line_number":22,"context_line":"        - containerPort: 80"},{"line_number":23,"context_line":"          protocol: TCP"},{"line_number":24,"context_line":"        livenessProbe:"},{"line_number":25,"context_line":"          httpGet:"},{"line_number":26,"context_line":"            port: 80"},{"line_number":27,"context_line":"            path: /"},{"line_number":28,"context_line":"          failureThreshold: 5"},{"line_number":29,"context_line":"          periodSeconds: 5"},{"line_number":30,"context_line":"      - image: celebdor/kuryr-demo"},{"line_number":31,"context_line":"        imagePullPolicy: IfNotPresent"},{"line_number":32,"context_line":"        name: kuryr-demo-readiness-probe"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_fe3a0333","line":29,"range":{"start_line":24,"start_character":0,"end_line":29,"end_character":26},"updated":"2020-09-15 07:55:15.000000000","message":"Will this functional test be an \"INSTANTIATED\" status in Devstack using kuryr-CNI? If it fails, it may better to remove the `livenessProbe` and the `readinessProbe` because the Probe may not be possible to check a container connecting the PodNetwork in Devstack.","commit_id":"2ee83dfa6d6f8f1d3664be8ba4dd57d4e16875ec"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"8df344e1bfb5819a95856ca2aba6d905330b1772","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        ports:"},{"line_number":22,"context_line":"        - containerPort: 80"},{"line_number":23,"context_line":"          protocol: TCP"},{"line_number":24,"context_line":"        livenessProbe:"},{"line_number":25,"context_line":"          httpGet:"},{"line_number":26,"context_line":"            port: 80"},{"line_number":27,"context_line":"            path: /"},{"line_number":28,"context_line":"          failureThreshold: 5"},{"line_number":29,"context_line":"          periodSeconds: 5"},{"line_number":30,"context_line":"      - image: celebdor/kuryr-demo"},{"line_number":31,"context_line":"        imagePullPolicy: IfNotPresent"},{"line_number":32,"context_line":"        name: kuryr-demo-readiness-probe"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_986c0c37","line":29,"range":{"start_line":24,"start_character":0,"end_line":29,"end_character":26},"in_reply_to":"9f560f44_fe3a0333","updated":"2020-09-24 11:25:35.000000000","message":"livenessProbe and readiness Probe are removed in the lateset patch, please kindly have a check","commit_id":"2ee83dfa6d6f8f1d3664be8ba4dd57d4e16875ec"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"e23ccfc3dbfb89a22bba9f52c16a52ec61f70e16","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        ports:"},{"line_number":34,"context_line":"        - containerPort: 8080"},{"line_number":35,"context_line":"          protocol: TCP"},{"line_number":36,"context_line":"        readinessProbe:"},{"line_number":37,"context_line":"          httpGet:"},{"line_number":38,"context_line":"            port: 8080"},{"line_number":39,"context_line":"            path: /"},{"line_number":40,"context_line":"          failureThreshold: 2"},{"line_number":41,"context_line":"          periodSeconds: 2"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_1e1b77ca","line":41,"range":{"start_line":36,"start_character":0,"end_line":41,"end_character":26},"updated":"2020-09-15 07:55:15.000000000","message":"same as above","commit_id":"2ee83dfa6d6f8f1d3664be8ba4dd57d4e16875ec"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"8df344e1bfb5819a95856ca2aba6d905330b1772","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        ports:"},{"line_number":34,"context_line":"        - containerPort: 8080"},{"line_number":35,"context_line":"          protocol: TCP"},{"line_number":36,"context_line":"        readinessProbe:"},{"line_number":37,"context_line":"          httpGet:"},{"line_number":38,"context_line":"            port: 8080"},{"line_number":39,"context_line":"            path: /"},{"line_number":40,"context_line":"          failureThreshold: 2"},{"line_number":41,"context_line":"          periodSeconds: 2"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_1862bc3e","line":41,"range":{"start_line":36,"start_character":0,"end_line":41,"end_character":26},"in_reply_to":"9f560f44_1e1b77ca","updated":"2020-09-24 11:25:35.000000000","message":"livenessProbe and readiness Probe are removed in the lateset patch, please kindly have a check","commit_id":"2ee83dfa6d6f8f1d3664be8ba4dd57d4e16875ec"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        ports:"},{"line_number":22,"context_line":"        - containerPort: 80"},{"line_number":23,"context_line":"          protocol: TCP"},{"line_number":24,"context_line":"      - image: celebdor/kuryr-demo"},{"line_number":25,"context_line":"        imagePullPolicy: IfNotPresent"},{"line_number":26,"context_line":"        name: kuryr-demo-readiness-probe"},{"line_number":27,"context_line":"        ports:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_bbc5cf0c","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":34},"updated":"2020-09-21 19:12:36.000000000","message":"Even though there is no impact on execution but for better\nreadability, I would suggest to have container name instead of \nimage as starting element in yaml under containers yaml element.\nFor ex,\n      containers:\n      - name: nginx-liveness-probe\n        image: nginx\n        imagePullPolicy: IfNotPresent\n        ports:\n        - containerPort: 80\n          protocol: TCP","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        ports:"},{"line_number":22,"context_line":"        - containerPort: 80"},{"line_number":23,"context_line":"          protocol: TCP"},{"line_number":24,"context_line":"      - image: celebdor/kuryr-demo"},{"line_number":25,"context_line":"        imagePullPolicy: IfNotPresent"},{"line_number":26,"context_line":"        name: kuryr-demo-readiness-probe"},{"line_number":27,"context_line":"        ports:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_c444e4ba","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":34},"in_reply_to":"9f560f44_bbc5cf0c","updated":"2020-09-24 11:05:37.000000000","message":"Thank for sugesstion, we have fixed it :) please kindly have a check","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/horizontal-pod-autoscaler.yaml":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: autoscaling/v1"},{"line_number":2,"context_line":"kind: HorizontalPodAutoscaler"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-svc-vdu001"},{"line_number":5,"context_line":"  namespace: default"},{"line_number":6,"context_line":"spec:"},{"line_number":7,"context_line":"  maxReplicas: 3"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_9b1d6b75","line":4,"range":{"start_line":4,"start_character":14,"end_line":4,"end_character":17},"updated":"2020-09-21 19:12:36.000000000","message":"I would suggest to use \"hpa\" instead of \"svc\" here.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: autoscaling/v1"},{"line_number":2,"context_line":"kind: HorizontalPodAutoscaler"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-svc-vdu001"},{"line_number":5,"context_line":"  namespace: default"},{"line_number":6,"context_line":"spec:"},{"line_number":7,"context_line":"  maxReplicas: 3"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_84278c12","line":4,"range":{"start_line":4,"start_character":14,"end_line":4,"end_character":17},"in_reply_to":"9f560f44_9b1d6b75","updated":"2020-09-24 11:05:37.000000000","message":"Thanks for sugesstion, it is fixed in the latest patch, please kindly have a check","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  scaleTargetRef:"},{"line_number":10,"context_line":"    apiVersion: extensions/v1beta1"},{"line_number":11,"context_line":"    kind: Deployment"},{"line_number":12,"context_line":"    name: curry-svc-vdu001"},{"line_number":13,"context_line":"  targetCPUUtilizationPercentage: 40"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_db3a43e4","line":12,"range":{"start_line":12,"start_character":16,"end_line":12,"end_character":19},"updated":"2020-09-21 19:12:36.000000000","message":"Just a suggestion, what about using depl instead of svc here, To me svc seems as if we are talking about service.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/job.yaml":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        - echo CURRY"},{"line_number":22,"context_line":"        image: celebdor/kuryr-demo"},{"line_number":23,"context_line":"        name: curryjob"},{"line_number":24,"context_line":"        resources:"},{"line_number":25,"context_line":"          limits: {}"},{"line_number":26,"context_line":"          requests: {}"},{"line_number":27,"context_line":"      restartPolicy: OnFailure"},{"line_number":28,"context_line":"status: {}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_160e5231","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":22},"updated":"2020-09-21 19:12:36.000000000","message":"why we are specifying these fields here if we are not specifying any cpu, memory requests and limits?\n\nI can understand if we are linking it with specifying default cpu request in next yaml.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        - echo CURRY"},{"line_number":22,"context_line":"        image: celebdor/kuryr-demo"},{"line_number":23,"context_line":"        name: curryjob"},{"line_number":24,"context_line":"        resources:"},{"line_number":25,"context_line":"          limits: {}"},{"line_number":26,"context_line":"          requests: {}"},{"line_number":27,"context_line":"      restartPolicy: OnFailure"},{"line_number":28,"context_line":"status: {}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_6467d852","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":22},"in_reply_to":"9f560f44_160e5231","updated":"2020-09-24 11:05:37.000000000","message":"Thank you for sugesstion, we have removed this part, please kindly have a check","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/multiple_yaml_network-policy.yaml":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":6,"context_line":"spec:"},{"line_number":7,"context_line":"  podSelector: {}"},{"line_number":8,"context_line":"  policyTypes:"},{"line_number":9,"context_line":"  - Egress"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_f69f5eb0","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":10},"updated":"2020-09-21 19:12:36.000000000","message":"what about specifying some example policy contents as well?","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":6,"context_line":"spec:"},{"line_number":7,"context_line":"  podSelector: {}"},{"line_number":8,"context_line":"  policyTypes:"},{"line_number":9,"context_line":"  - Egress"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_245b2086","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":10},"in_reply_to":"9f560f44_f69f5eb0","updated":"2020-09-24 11:05:37.000000000","message":"we tried to add some specific policies in the latest patch, please kindly have a check","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/multiple_yaml_priority-class.yaml":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":2,"context_line":"kind: PriorityClass"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: high-priority"},{"line_number":5,"context_line":"  namespace: default"},{"line_number":6,"context_line":"value: 1000000"},{"line_number":7,"context_line":"globalDefault: false"},{"line_number":8,"context_line":"description: \"Priority Class Test\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_16c13281","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":20},"updated":"2020-09-21 19:12:36.000000000","message":"\"A PriorityClass is a non-namespaced object\"\n\nPlease refer following URL for further details:\n\n\"https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/#priorityclass\"","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":2,"context_line":"kind: PriorityClass"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: high-priority"},{"line_number":5,"context_line":"  namespace: default"},{"line_number":6,"context_line":"value: 1000000"},{"line_number":7,"context_line":"globalDefault: false"},{"line_number":8,"context_line":"description: \"Priority Class Test\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_84daece5","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":20},"in_reply_to":"9f560f44_16c13281","updated":"2020-09-24 11:05:37.000000000","message":"Thanks for notice, we have removed namespace, please kindly have a check","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/persistent-volume-1.yaml":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  capacity:"},{"line_number":9,"context_line":"    storage: 1Gi"},{"line_number":10,"context_line":"  hostPath:"},{"line_number":11,"context_line":"    path: /data/curry-sc-test"},{"line_number":12,"context_line":"    type: DirectoryOrCreate"},{"line_number":13,"context_line":"  persistentVolumeReclaimPolicy: Delete"},{"line_number":14,"context_line":"  storageClassName: curry-sc-local"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_3620b649","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":29},"updated":"2020-09-21 19:12:36.000000000","message":"I am not sure if we can use same path for 2 PersistentVolumes, Same as current yaml and previous yaml.\n\nI understand these are just for test purpose, may be no changes required.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  capacity:"},{"line_number":9,"context_line":"    storage: 1Gi"},{"line_number":10,"context_line":"  hostPath:"},{"line_number":11,"context_line":"    path: /data/curry-sc-test"},{"line_number":12,"context_line":"    type: DirectoryOrCreate"},{"line_number":13,"context_line":"  persistentVolumeReclaimPolicy: Delete"},{"line_number":14,"context_line":"  storageClassName: curry-sc-local"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_84030c42","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":29},"in_reply_to":"9f560f44_3620b649","updated":"2020-09-24 11:05:37.000000000","message":"Thanks for sugesstion, we just make a small change here to make the paths be different. Please kindly have a check.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/replicaset_service_secret.yaml":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      containers:"},{"line_number":44,"context_line":"      - image: nginx"},{"line_number":45,"context_line":"        name: nginx"},{"line_number":46,"context_line":"        env:"},{"line_number":47,"context_line":"          - name: param0"},{"line_number":48,"context_line":"            valueFrom:"},{"line_number":49,"context_line":"              secretKeyRef:"},{"line_number":50,"context_line":"                key: param0"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_d6833a02","line":47,"range":{"start_line":46,"start_character":0,"end_line":47,"end_character":18},"updated":"2020-09-21 19:12:36.000000000","message":"can this indentation create problem?\n\nI guess it should be\n \n      containers:\n      - image: nginx\n        name: nginx\n        env:\n        - name: param0","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      containers:"},{"line_number":44,"context_line":"      - image: nginx"},{"line_number":45,"context_line":"        name: nginx"},{"line_number":46,"context_line":"        env:"},{"line_number":47,"context_line":"          - name: param0"},{"line_number":48,"context_line":"            valueFrom:"},{"line_number":49,"context_line":"              secretKeyRef:"},{"line_number":50,"context_line":"                key: param0"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_249e8005","line":47,"range":{"start_line":46,"start_character":0,"end_line":47,"end_character":18},"in_reply_to":"9f560f44_d6833a02","updated":"2020-09-24 11:05:37.000000000","message":"Thanks for notice, we fixed indentation in the latest patch ,please kindly have a check","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/statefulset.yaml":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - metadata:"},{"line_number":29,"context_line":"      name: www"},{"line_number":30,"context_line":"    spec:"},{"line_number":31,"context_line":"      accessModes: [ \"ReadWriteOnce\" ]"},{"line_number":32,"context_line":"      storageClassName: \"curry-sc-local\""},{"line_number":33,"context_line":"      resources:"},{"line_number":34,"context_line":"        requests:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_16c77247","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":38},"updated":"2020-09-21 19:12:36.000000000","message":"To me it seems json format.\n\nIf ok, please change to \naccessModes:\n    - ReadWriteOnce","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - metadata:"},{"line_number":29,"context_line":"      name: www"},{"line_number":30,"context_line":"    spec:"},{"line_number":31,"context_line":"      accessModes: [ \"ReadWriteOnce\" ]"},{"line_number":32,"context_line":"      storageClassName: \"curry-sc-local\""},{"line_number":33,"context_line":"      resources:"},{"line_number":34,"context_line":"        requests:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_a489f0c7","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":38},"in_reply_to":"9f560f44_16c77247","updated":"2020-09-24 11:05:37.000000000","message":"Thanks for sugesstion, it is fixed","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/storage-class.yaml":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-sc-local"},{"line_number":5,"context_line":"provisioner: kubernetes.io/no-provisioner"},{"line_number":6,"context_line":"volumeBindingMode: Immediate"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_d6821ac7","line":6,"updated":"2020-09-21 19:12:36.000000000","message":"storage-class.yaml and storage-class1.yaml are same.\n\nI understand these are just test file to depict storage classes, please check if need any changes else ok to me.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/token-review.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-tokenreview-test"},{"line_number":5,"context_line":"spec:"},{"line_number":6,"context_line":"  token: \"\u003cSA_TOKEN\u003e\"  # SA_TOKEN\u003d$(kubectl describe secret $(kubectl get secrets | grep curry-sa | cut -f1 -d \u0027 \u0027) | grep -E \u0027^token\u0027 | cut -f2 -d\u0027:\u0027 | tr -d \u0027\\t\u0027); echo $SA_TOKEN"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_629fe7b2","line":6,"updated":"2020-09-23 10:34:22.000000000","message":"Why don\u0027t you make this comment multiple lines to be more readable? It\u0027s too long.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-tokenreview-test"},{"line_number":5,"context_line":"spec:"},{"line_number":6,"context_line":"  token: \"\u003cSA_TOKEN\u003e\"  # SA_TOKEN\u003d$(kubectl describe secret $(kubectl get secrets | grep curry-sa | cut -f1 -d \u0027 \u0027) | grep -E \u0027^token\u0027 | cut -f2 -d\u0027:\u0027 | tr -d \u0027\\t\u0027); echo $SA_TOKEN"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_d8e20430","line":6,"in_reply_to":"9f560f44_629fe7b2","updated":"2020-09-24 11:05:37.000000000","message":"fixed in the latest patch, thanks for notice","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_with_artifact_is_url/Files/kubernetes/storage-class.yaml":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"973dbe6daa22a37f5baa30615e7197e79f751d94","unresolved":false,"context_lines":[{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-sc-local"},{"line_number":5,"context_line":"provisioner: kubernetes.io/no-provisioner"},{"line_number":6,"context_line":"volumeBindingMode: Immediate"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_b6ee8688","line":6,"updated":"2020-09-21 19:12:36.000000000","message":"Almost same as \"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/storage-class.yaml\"\n\nIf possible, we should remove duplication.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-sc-local"},{"line_number":5,"context_line":"provisioner: kubernetes.io/no-provisioner"},{"line_number":6,"context_line":"volumeBindingMode: Immediate"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_e465a81e","line":6,"in_reply_to":"9f560f44_b6ee8688","updated":"2020-09-24 11:05:37.000000000","message":"Thanks for sugesstion, we deleted this file in the latest patch","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_with_cluster_role/Files/kubernetes/cluster-role.yaml":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"2c5a01c217551cc846a271cf531f81eec8afa677","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":2,"context_line":"kind: ClusterRole"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-cluster-role"},{"line_number":5,"context_line":"rules:"},{"line_number":6,"context_line":"- apiGroups: [\"\"]"},{"line_number":7,"context_line":"  resources: [\"pods\"]"},{"line_number":8,"context_line":"  verbs: [\"get\", \"watch\", \"list\"]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_4b024e0d","line":8,"range":{"start_line":1,"start_character":0,"end_line":8,"end_character":33},"updated":"2020-08-30 04:29:36.000000000","message":"This comment priority is low because improvement comment.\nCould you combine the `ServiceAccount` , `ClusterRole` and `ClusterRoleBinding` as they are series of operation.","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"8df344e1bfb5819a95856ca2aba6d905330b1772","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":2,"context_line":"kind: ClusterRole"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-cluster-role"},{"line_number":5,"context_line":"rules:"},{"line_number":6,"context_line":"- apiGroups: [\"\"]"},{"line_number":7,"context_line":"  resources: [\"pods\"]"},{"line_number":8,"context_line":"  verbs: [\"get\", \"watch\", \"list\"]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_78cbf848","line":8,"range":{"start_line":1,"start_character":0,"end_line":8,"end_character":33},"in_reply_to":"9f560f44_4b024e0d","updated":"2020-09-24 11:25:35.000000000","message":"This file is no longer exist since test data merged.","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_with_multiple_yaml_and_resources_with_dependence_and_sort/Files/kubernetes/statefulset.yaml":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"2c5a01c217551cc846a271cf531f81eec8afa677","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      resources:"},{"line_number":34,"context_line":"        requests:"},{"line_number":35,"context_line":"          storage: 1Gi"},{"line_number":36,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_cb3dbede","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":4},"updated":"2020-08-30 04:29:36.000000000","message":"This blank line is not needed.","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"8df344e1bfb5819a95856ca2aba6d905330b1772","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      resources:"},{"line_number":34,"context_line":"        requests:"},{"line_number":35,"context_line":"          storage: 1Gi"},{"line_number":36,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_d8efa4ae","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":4},"in_reply_to":"9f560f44_cb3dbede","updated":"2020-09-24 11:25:35.000000000","message":"fixed but in a new file:https://review.opendev.org/#/c/746691/4..12/tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_resources/Files/kubernetes/statefulset.yaml","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"}],"tacker/tests/etc/samples/etsi/nfv/test_create_vnf_instance_and_instantiate_and_terminate_cnf_with_role/Files/kubernetes/role.yaml":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"2c5a01c217551cc846a271cf531f81eec8afa677","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":2,"context_line":"kind: Role"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-role"},{"line_number":5,"context_line":"  namespace: default"},{"line_number":6,"context_line":"rules:"},{"line_number":7,"context_line":"- apiGroups: [\"\"]"},{"line_number":8,"context_line":"  resources: [\"pods\"]"},{"line_number":9,"context_line":"  verbs: [\"get\", \"watch\", \"list\"]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_6b059214","line":9,"range":{"start_line":1,"start_character":0,"end_line":9,"end_character":33},"updated":"2020-08-30 04:29:36.000000000","message":"This comment priority is low because improvement comment.\nCould you combine the `ServiceAccount` , `Role` and `RoleBinding` as they are series of operation.","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"8df344e1bfb5819a95856ca2aba6d905330b1772","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: rbac.authorization.k8s.io/v1"},{"line_number":2,"context_line":"kind: Role"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: curry-role"},{"line_number":5,"context_line":"  namespace: default"},{"line_number":6,"context_line":"rules:"},{"line_number":7,"context_line":"- apiGroups: [\"\"]"},{"line_number":8,"context_line":"  resources: [\"pods\"]"},{"line_number":9,"context_line":"  verbs: [\"get\", \"watch\", \"list\"]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_983ecc26","line":9,"range":{"start_line":1,"start_character":0,"end_line":9,"end_character":33},"in_reply_to":"9f560f44_6b059214","updated":"2020-09-24 11:25:35.000000000","message":"This file is no longer exist since test-data merged","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"}],"tacker/tests/functional/vnflcm/test_kubernetes.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"36b21885af983cdb53e92d77e119525b1fe0e597","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        #                            \"bindings\","},{"line_number":95,"context_line":"        #         {\"key\": \"bindings_functional\"})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        cls.vnf_package_cluster_role, cls.vnfd_id_cluster_role \u003d \\"},{"line_number":98,"context_line":"            _create_and_upload_vnf_package("},{"line_number":99,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":100,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":101,"context_line":"                                   \"cluster_role\","},{"line_number":102,"context_line":"                {\"key\": \"cluster_role_functional\"})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        cls.vnf_package_cluster_role_binding, \\"},{"line_number":105,"context_line":"            cls.vnfd_id_cluster_role_binding \u003d \\"},{"line_number":106,"context_line":"            _create_and_upload_vnf_package("},{"line_number":107,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":108,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":109,"context_line":"                                   \"cluster_role_binding\","},{"line_number":110,"context_line":"                {\"key\": \"cluster_role_binding_functional\"})"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        cls.vnf_package_config_map, cls.vnfd_id_config_map \u003d \\"},{"line_number":113,"context_line":"            _create_and_upload_vnf_package("},{"line_number":114,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":115,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":116,"context_line":"                                   \"config_map\","},{"line_number":117,"context_line":"                {\"key\": \"config_map_functional\"})"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        cls.vnf_package_controller_revision, \\"},{"line_number":120,"context_line":"            cls.vnfd_id_controller_revision \u003d \\"},{"line_number":121,"context_line":"            _create_and_upload_vnf_package("},{"line_number":122,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":123,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":124,"context_line":"                                   \"controller_revision\","},{"line_number":125,"context_line":"                {\"key\": \"controller_revision_functional\"})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        cls.vnf_package_daemon_set, \\"},{"line_number":128,"context_line":"            cls.vnfd_id_daemon_set \u003d \\"},{"line_number":129,"context_line":"            _create_and_upload_vnf_package("},{"line_number":130,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":131,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":132,"context_line":"                                   \"daemon_set\","},{"line_number":133,"context_line":"                {\"key\": \"daemon_set_functional\"})"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        cls.vnf_package_deployment, \\"},{"line_number":136,"context_line":"            cls.vnfd_id_deployment \u003d \\"},{"line_number":137,"context_line":"            _create_and_upload_vnf_package("},{"line_number":138,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":139,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":140,"context_line":"                                   \"deployment\","},{"line_number":141,"context_line":"                {\"key\": \"deployment_functional\"})"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        cls.vnf_package_horizontal_pod_autoscaler, \\"},{"line_number":144,"context_line":"            cls.vnfd_id_horizontal_pod_autoscaler \u003d \\"},{"line_number":145,"context_line":"            _create_and_upload_vnf_package("},{"line_number":146,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":147,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":148,"context_line":"                                   \"horizontal_pod_autoscaler\","},{"line_number":149,"context_line":"                {\"key\": \"horizontal_pod_autoscaler_functional\"})"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        cls.vnf_package_job, \\"},{"line_number":152,"context_line":"            cls.vnfd_id_job \u003d \\"},{"line_number":153,"context_line":"            _create_and_upload_vnf_package("},{"line_number":154,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":155,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":156,"context_line":"                                   \"job\","},{"line_number":157,"context_line":"                {\"key\": \"job_functional\"})"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        cls.vnf_package_limit_range, \\"},{"line_number":160,"context_line":"            cls.vnfd_id_limit_range \u003d \\"},{"line_number":161,"context_line":"            _create_and_upload_vnf_package("},{"line_number":162,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":163,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":164,"context_line":"                                   \"limit_range\","},{"line_number":165,"context_line":"                {\"key\": \"limit_range\"})"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        cls.vnf_package_namespace, cls.vnfd_id_namespace \u003d \\"},{"line_number":168,"context_line":"            _create_and_upload_vnf_package("},{"line_number":169,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":170,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":171,"context_line":"                                   \"namespace\","},{"line_number":172,"context_line":"                {\"key\": \"namespace_functional\"})"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        cls.vnf_package_node, cls.vnfd_id_node \u003d \\"},{"line_number":175,"context_line":"            _create_and_upload_vnf_package("},{"line_number":176,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":177,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":178,"context_line":"                                   \"node\","},{"line_number":179,"context_line":"                {\"key\": \"node_functional\"})"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        cls.vnf_package_pod, cls.vnfd_id_pod \u003d \\"},{"line_number":182,"context_line":"            _create_and_upload_vnf_package("},{"line_number":183,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_instantiate\""},{"line_number":184,"context_line":"                                   \"_and_terminate_cnf_with_pod\","},{"line_number":185,"context_line":"                {\"key\": \"pod_functional\"})"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        cls.vnf_package_pod_template, cls.vnfd_id_pod_template \u003d \\"},{"line_number":188,"context_line":"            _create_and_upload_vnf_package("},{"line_number":189,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":190,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":191,"context_line":"                                   \"pod_template\","},{"line_number":192,"context_line":"                {\"key\": \"pod_template_functional\"})"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        cls.vnf_package_resource_quota, cls.vnfd_id_resource_quota \u003d \\"},{"line_number":195,"context_line":"            _create_and_upload_vnf_package("},{"line_number":196,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":197,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":198,"context_line":"                                   \"resource_quota\","},{"line_number":199,"context_line":"                {\"key\": \"resource_quota_functional\"})"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        cls.vnf_package_role, cls.vnfd_id_role \u003d \\"},{"line_number":202,"context_line":"            _create_and_upload_vnf_package("},{"line_number":203,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":204,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":205,"context_line":"                                   \"role\","},{"line_number":206,"context_line":"                {\"key\": \"role_functional\"})"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        cls.vnf_package_role_binding, cls.vnfd_id_role_binding \u003d \\"},{"line_number":209,"context_line":"            _create_and_upload_vnf_package("},{"line_number":210,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":211,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":212,"context_line":"                                   \"role_binding\","},{"line_number":213,"context_line":"                {\"key\": \"role_binding_functional\"})"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        cls.vnf_package_service_account, cls.vnfd_id_service_account \u003d \\"},{"line_number":216,"context_line":"            _create_and_upload_vnf_package("},{"line_number":217,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":218,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":219,"context_line":"                                   \"service_account\","},{"line_number":220,"context_line":"                {\"key\": \"service_account_functional\"})"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        cls.vnf_package_subject_access_review, \\"},{"line_number":223,"context_line":"            cls.vnfd_id_subject_access_review \u003d \\"},{"line_number":224,"context_line":"            _create_and_upload_vnf_package("},{"line_number":225,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":226,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":227,"context_line":"                                   \"subject_access_review\","},{"line_number":228,"context_line":"                {\"key\": \"subject_access_review_functional\"})"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        cls.vnf_package_token_review, cls.vnfd_id_token_review \u003d \\"},{"line_number":231,"context_line":"            _create_and_upload_vnf_package("},{"line_number":232,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":233,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":234,"context_line":"                                   \"token_review\","},{"line_number":235,"context_line":"                {\"key\": \"token_review_functional\"})"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # complex situation"},{"line_number":238,"context_line":"        cls.vnf_package_single_resource, cls.vnfd_id_single_resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_c613195b","line":235,"range":{"start_line":97,"start_character":0,"end_line":235,"end_character":51},"updated":"2020-08-28 00:39:26.000000000","message":"Is it possible to merge these to a single VNF Package? It seems that too many VNF Packages with few differences are uploaded.","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"071eea16cece07697d52384b1e489fcaf698f652","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        #                            \"bindings\","},{"line_number":95,"context_line":"        #         {\"key\": \"bindings_functional\"})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        cls.vnf_package_cluster_role, cls.vnfd_id_cluster_role \u003d \\"},{"line_number":98,"context_line":"            _create_and_upload_vnf_package("},{"line_number":99,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":100,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":101,"context_line":"                                   \"cluster_role\","},{"line_number":102,"context_line":"                {\"key\": \"cluster_role_functional\"})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        cls.vnf_package_cluster_role_binding, \\"},{"line_number":105,"context_line":"            cls.vnfd_id_cluster_role_binding \u003d \\"},{"line_number":106,"context_line":"            _create_and_upload_vnf_package("},{"line_number":107,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":108,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":109,"context_line":"                                   \"cluster_role_binding\","},{"line_number":110,"context_line":"                {\"key\": \"cluster_role_binding_functional\"})"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        cls.vnf_package_config_map, cls.vnfd_id_config_map \u003d \\"},{"line_number":113,"context_line":"            _create_and_upload_vnf_package("},{"line_number":114,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":115,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":116,"context_line":"                                   \"config_map\","},{"line_number":117,"context_line":"                {\"key\": \"config_map_functional\"})"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        cls.vnf_package_controller_revision, \\"},{"line_number":120,"context_line":"            cls.vnfd_id_controller_revision \u003d \\"},{"line_number":121,"context_line":"            _create_and_upload_vnf_package("},{"line_number":122,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":123,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":124,"context_line":"                                   \"controller_revision\","},{"line_number":125,"context_line":"                {\"key\": \"controller_revision_functional\"})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        cls.vnf_package_daemon_set, \\"},{"line_number":128,"context_line":"            cls.vnfd_id_daemon_set \u003d \\"},{"line_number":129,"context_line":"            _create_and_upload_vnf_package("},{"line_number":130,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":131,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":132,"context_line":"                                   \"daemon_set\","},{"line_number":133,"context_line":"                {\"key\": \"daemon_set_functional\"})"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        cls.vnf_package_deployment, \\"},{"line_number":136,"context_line":"            cls.vnfd_id_deployment \u003d \\"},{"line_number":137,"context_line":"            _create_and_upload_vnf_package("},{"line_number":138,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":139,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":140,"context_line":"                                   \"deployment\","},{"line_number":141,"context_line":"                {\"key\": \"deployment_functional\"})"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        cls.vnf_package_horizontal_pod_autoscaler, \\"},{"line_number":144,"context_line":"            cls.vnfd_id_horizontal_pod_autoscaler \u003d \\"},{"line_number":145,"context_line":"            _create_and_upload_vnf_package("},{"line_number":146,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":147,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":148,"context_line":"                                   \"horizontal_pod_autoscaler\","},{"line_number":149,"context_line":"                {\"key\": \"horizontal_pod_autoscaler_functional\"})"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        cls.vnf_package_job, \\"},{"line_number":152,"context_line":"            cls.vnfd_id_job \u003d \\"},{"line_number":153,"context_line":"            _create_and_upload_vnf_package("},{"line_number":154,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":155,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":156,"context_line":"                                   \"job\","},{"line_number":157,"context_line":"                {\"key\": \"job_functional\"})"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        cls.vnf_package_limit_range, \\"},{"line_number":160,"context_line":"            cls.vnfd_id_limit_range \u003d \\"},{"line_number":161,"context_line":"            _create_and_upload_vnf_package("},{"line_number":162,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":163,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":164,"context_line":"                                   \"limit_range\","},{"line_number":165,"context_line":"                {\"key\": \"limit_range\"})"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        cls.vnf_package_namespace, cls.vnfd_id_namespace \u003d \\"},{"line_number":168,"context_line":"            _create_and_upload_vnf_package("},{"line_number":169,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":170,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":171,"context_line":"                                   \"namespace\","},{"line_number":172,"context_line":"                {\"key\": \"namespace_functional\"})"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        cls.vnf_package_node, cls.vnfd_id_node \u003d \\"},{"line_number":175,"context_line":"            _create_and_upload_vnf_package("},{"line_number":176,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":177,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":178,"context_line":"                                   \"node\","},{"line_number":179,"context_line":"                {\"key\": \"node_functional\"})"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        cls.vnf_package_pod, cls.vnfd_id_pod \u003d \\"},{"line_number":182,"context_line":"            _create_and_upload_vnf_package("},{"line_number":183,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_instantiate\""},{"line_number":184,"context_line":"                                   \"_and_terminate_cnf_with_pod\","},{"line_number":185,"context_line":"                {\"key\": \"pod_functional\"})"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        cls.vnf_package_pod_template, cls.vnfd_id_pod_template \u003d \\"},{"line_number":188,"context_line":"            _create_and_upload_vnf_package("},{"line_number":189,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":190,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":191,"context_line":"                                   \"pod_template\","},{"line_number":192,"context_line":"                {\"key\": \"pod_template_functional\"})"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        cls.vnf_package_resource_quota, cls.vnfd_id_resource_quota \u003d \\"},{"line_number":195,"context_line":"            _create_and_upload_vnf_package("},{"line_number":196,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":197,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":198,"context_line":"                                   \"resource_quota\","},{"line_number":199,"context_line":"                {\"key\": \"resource_quota_functional\"})"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        cls.vnf_package_role, cls.vnfd_id_role \u003d \\"},{"line_number":202,"context_line":"            _create_and_upload_vnf_package("},{"line_number":203,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":204,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":205,"context_line":"                                   \"role\","},{"line_number":206,"context_line":"                {\"key\": \"role_functional\"})"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        cls.vnf_package_role_binding, cls.vnfd_id_role_binding \u003d \\"},{"line_number":209,"context_line":"            _create_and_upload_vnf_package("},{"line_number":210,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":211,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":212,"context_line":"                                   \"role_binding\","},{"line_number":213,"context_line":"                {\"key\": \"role_binding_functional\"})"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        cls.vnf_package_service_account, cls.vnfd_id_service_account \u003d \\"},{"line_number":216,"context_line":"            _create_and_upload_vnf_package("},{"line_number":217,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":218,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":219,"context_line":"                                   \"service_account\","},{"line_number":220,"context_line":"                {\"key\": \"service_account_functional\"})"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        cls.vnf_package_subject_access_review, \\"},{"line_number":223,"context_line":"            cls.vnfd_id_subject_access_review \u003d \\"},{"line_number":224,"context_line":"            _create_and_upload_vnf_package("},{"line_number":225,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":226,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":227,"context_line":"                                   \"subject_access_review\","},{"line_number":228,"context_line":"                {\"key\": \"subject_access_review_functional\"})"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        cls.vnf_package_token_review, cls.vnfd_id_token_review \u003d \\"},{"line_number":231,"context_line":"            _create_and_upload_vnf_package("},{"line_number":232,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":233,"context_line":"                                   \"instantiate_and_terminate_cnf_with_\""},{"line_number":234,"context_line":"                                   \"token_review\","},{"line_number":235,"context_line":"                {\"key\": \"token_review_functional\"})"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # complex situation"},{"line_number":238,"context_line":"        cls.vnf_package_single_resource, cls.vnfd_id_single_resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_b86c23d1","line":235,"range":{"start_line":97,"start_character":0,"end_line":235,"end_character":51},"in_reply_to":"9f560f44_c613195b","updated":"2020-09-15 00:56:26.000000000","message":"We have merged vnf packages in patch 5, thanks for comment","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"36b21885af983cdb53e92d77e119525b1fe0e597","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                                   \"in_single_yaml_with_multiple_resources\","},{"line_number":251,"context_line":"                {\"key\": \"multiple_resources_functional\"})"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        cls.vnf_package_multiple_yaml_no_dependence, \\"},{"line_number":254,"context_line":"            cls.vnfd_id_multiple_yaml_no_dependence \u003d \\"},{"line_number":255,"context_line":"            _create_and_upload_vnf_package("},{"line_number":256,"context_line":"                cls.tacker_client, \"test_create_vnf_instance_and_\""},{"line_number":257,"context_line":"                                   \"instantiate_and_terminate_cnf_\""},{"line_number":258,"context_line":"                                   \"with_multiple_yaml_and_resources\""},{"line_number":259,"context_line":"                                   \"_no_dependence\","},{"line_number":260,"context_line":"                {\"key\": \"multiple_yaml_no_dependence_functional\"})"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        cls.vnf_package_multiple_yaml_dep_sort, \\"},{"line_number":263,"context_line":"            cls.vnfd_id_multiple_yaml_dep_sort \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_865481ff","line":260,"range":{"start_line":253,"start_character":0,"end_line":260,"end_character":66},"updated":"2020-08-28 00:39:26.000000000","message":"This setup fails in Zuul check of tacker-functional-devstack-multinode-python3.","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    #     self._terminate_vnf_instance(vnf_instance[\u0027id\u0027], terminate_req_body)"},{"line_number":284,"context_line":"    #     self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def test_insta_and_termi_cnf_with_clusterrole_clusterrolebinding_SA(self):"},{"line_number":287,"context_line":"        # Create vnf instance"},{"line_number":288,"context_line":"        vnf_instance_name \u003d \"vnf_with_instantiation_level-%s\" % \\"},{"line_number":289,"context_line":"                            uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_cfa25c3f","line":286,"range":{"start_line":286,"start_character":13,"end_line":286,"end_character":28},"updated":"2020-09-23 10:34:22.000000000","message":"You should not use such an unusual abbreviations although it\u0027s so long name...\n\nHere is my suggestion. `term` is popular for `termination`. I don\u0027t know for `instantiation`, but `inst` is enough for the context. So, how about `inst_term` instead?","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    #     self._terminate_vnf_instance(vnf_instance[\u0027id\u0027], terminate_req_body)"},{"line_number":284,"context_line":"    #     self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def test_insta_and_termi_cnf_with_clusterrole_clusterrolebinding_SA(self):"},{"line_number":287,"context_line":"        # Create vnf instance"},{"line_number":288,"context_line":"        vnf_instance_name \u003d \"vnf_with_instantiation_level-%s\" % \\"},{"line_number":289,"context_line":"                            uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_38f22006","line":286,"range":{"start_line":286,"start_character":13,"end_line":286,"end_character":28},"in_reply_to":"9f560f44_cfa25c3f","updated":"2020-09-24 11:05:37.000000000","message":"we have fixed it in the lateset patch, thanks for suggeestion","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        self._terminate_vnf_instance(vnf_instance[\u0027id\u0027], terminate_req_body)"},{"line_number":320,"context_line":"        self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def test_insta_and_termi_cnf_with_config_map(self):"},{"line_number":323,"context_line":"        # Create vnf instance"},{"line_number":324,"context_line":"        vnf_instance_name \u003d \"vnf_with_instantiation_level-%s\" % \\"},{"line_number":325,"context_line":"                            uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_a2673fea","line":322,"range":{"start_line":322,"start_character":13,"end_line":322,"end_character":29},"updated":"2020-09-23 10:34:22.000000000","message":"ditto, here and all following.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        self._terminate_vnf_instance(vnf_instance[\u0027id\u0027], terminate_req_body)"},{"line_number":320,"context_line":"        self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def test_insta_and_termi_cnf_with_config_map(self):"},{"line_number":323,"context_line":"        # Create vnf instance"},{"line_number":324,"context_line":"        vnf_instance_name \u003d \"vnf_with_instantiation_level-%s\" % \\"},{"line_number":325,"context_line":"                            uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_78d77850","line":322,"range":{"start_line":322,"start_character":13,"end_line":322,"end_character":29},"in_reply_to":"9f560f44_a2673fea","updated":"2020-09-24 11:05:37.000000000","message":"we have fixed it in the lateset patch, thanks for suggeestion","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/functional/vnflcm/test_vnf_instance.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"36b21885af983cdb53e92d77e119525b1fe0e597","unresolved":false,"context_lines":[{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def test_create_vnf_instance_and_instantiate_and_terminate_cnf_with_pod("},{"line_number":598,"context_line":"            self):"},{"line_number":599,"context_line":"        \"\"\"Test instantiation and heal API with instantiation level"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"        This test will instantiate vnf with instantiation level. Heal API"},{"line_number":602,"context_line":"        will be invoked by passing vnfcInstanceId parameter in the request"},{"line_number":603,"context_line":"        body as per SOL002 HealVnfRequest."},{"line_number":604,"context_line":"        \"\"\""},{"line_number":605,"context_line":"        # Create vnf instance"},{"line_number":606,"context_line":"        vnf_instance_name \u003d \"vnf_with_instantiation_level-%s\" % \\"},{"line_number":607,"context_line":"            uuidutils.generate_uuid()"},{"line_number":608,"context_line":"        vnf_instance_description \u003d \"vnf with instantiation level 5\""},{"line_number":609,"context_line":"        resp, vnf_instance \u003d self._create_vnf_instance(self.vnfd_id_5,"},{"line_number":610,"context_line":"                vnf_instance_name\u003dvnf_instance_name,"},{"line_number":611,"context_line":"                vnf_instance_description\u003dvnf_instance_description)"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        self.assertIsNotNone(vnf_instance[\u0027id\u0027])"},{"line_number":614,"context_line":"        self.assertEqual(201, resp.status_code)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        # generate body"},{"line_number":617,"context_line":"        request_body \u003d self._instantiate_vnf_request(\"simple\","},{"line_number":618,"context_line":"                instantiation_level_id\u003d\"instantiation_level_5\","},{"line_number":619,"context_line":"                vim_id\u003dself.vim_id)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        # send request"},{"line_number":622,"context_line":"        self._instantiate_vnf_instance(vnf_instance[\u0027id\u0027], request_body)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        vnf_instance \u003d self._show_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":625,"context_line":"        vdu_count \u003d len(vnf_instance[\u0027instantiatedVnfInfo\u0027]"},{"line_number":626,"context_line":"            [\u0027vnfcResourceInfo\u0027])"},{"line_number":627,"context_line":"        self.assertEqual(1, vdu_count)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        # heal as per SOL002 API check, i.e.vnfcInstanceId is passed in"},{"line_number":630,"context_line":"        # the HealVnfRequest."},{"line_number":631,"context_line":"        vnfc_resource_info \u003d (vnf_instance[\u0027instantiatedVnfInfo\u0027]"},{"line_number":632,"context_line":"            [\u0027vnfcResourceInfo\u0027])"},{"line_number":633,"context_line":"        vnfInstanceIds \u003d [vnfc_res_info[\u0027id\u0027] for vnfc_res_info in"},{"line_number":634,"context_line":"            vnfc_resource_info]"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        heal_request_body \u003d {"},{"line_number":637,"context_line":"            \"cause\": \"Heal as per SOL002 API check\","},{"line_number":638,"context_line":"            \"vnfcInstanceId\": vnfInstanceIds"},{"line_number":639,"context_line":"        }"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"        self._heal_vnf_instance(vnf_instance, heal_request_body)"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        # NOTE(tpatil) Wait for sometime as it takes a while to update"},{"line_number":644,"context_line":"        # vnfcResourceInfo after the stack status becomes UPDATE_COMPLETE."},{"line_number":645,"context_line":"        # There is no intermediate status set to VNF which can be used here"},{"line_number":646,"context_line":"        # to confirm healing action is completed successfully."},{"line_number":647,"context_line":"        time.sleep(20)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        vnf_instance_current \u003d self._show_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":650,"context_line":"        self._verify_vnfc_resource_info(vnf_instance, vnf_instance_current, 3)"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        # Terminate vnf forcefully"},{"line_number":653,"context_line":"        terminate_req_body \u003d {"},{"line_number":654,"context_line":"            \"terminationType\": fields.VnfInstanceTerminationType.FORCEFUL"},{"line_number":655,"context_line":"        }"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        self._terminate_vnf_instance(vnf_instance[\u0027id\u0027], terminate_req_body)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    def test_instantiate_vnf_with_ext_vl_and_ext_managed_vl(self):"},{"line_number":662,"context_line":"        \"\"\"Test instantiation vnf with external virtual links"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1cce67b3","line":659,"range":{"start_line":597,"start_character":0,"end_line":659,"end_character":53},"updated":"2020-08-28 00:39:26.000000000","message":"This test method seems the copy of test_instantiate_vnf_with_instantiation_level and not including any pod related operations.","commit_id":"474ec990866a3e65788991383629ffedbaa31f1b"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"071eea16cece07697d52384b1e489fcaf698f652","unresolved":false,"context_lines":[{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def test_create_vnf_instance_and_instantiate_and_terminate_cnf_with_pod("},{"line_number":598,"context_line":"            self):"},{"line_number":599,"context_line":"        \"\"\"Test instantiation and heal API with instantiation level"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"        This test will instantiate vnf with instantiation level. Heal API"},{"line_number":602,"context_line":"        will be invoked by passing vnfcInstanceId parameter in the request"},{"line_number":603,"context_line":"        body as per SOL002 HealVnfRequest."},{"line_number":604,"context_line":"        \"\"\""},{"line_number":605,"context_line":"        # Create vnf instance"},{"line_number":606,"context_line":"        vnf_instance_name \u003d \"vnf_with_instantiation_level-%s\" % \\"},{"line_number":607,"context_line":"            uuidutils.generate_uuid()"},{"line_number":608,"context_line":"        vnf_instance_description \u003d \"vnf with instantiation level 5\""},{"line_number":609,"context_line":"        resp, vnf_instance \u003d self._create_vnf_instance(self.vnfd_id_5,"},{"line_number":610,"context_line":"                vnf_instance_name\u003dvnf_instance_name,"},{"line_number":611,"context_line":"                vnf_instance_description\u003dvnf_instance_description)"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        self.assertIsNotNone(vnf_instance[\u0027id\u0027])"},{"line_number":614,"context_line":"        self.assertEqual(201, resp.status_code)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        # generate body"},{"line_number":617,"context_line":"        request_body \u003d self._instantiate_vnf_request(\"simple\","},{"line_number":618,"context_line":"                instantiation_level_id\u003d\"instantiation_level_5\","},{"line_number":619,"context_line":"                vim_id\u003dself.vim_id)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        # send request"},{"line_number":622,"context_line":"        self._instantiate_vnf_instance(vnf_instance[\u0027id\u0027], request_body)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        vnf_instance \u003d self._show_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":625,"context_line":"        vdu_count \u003d len(vnf_instance[\u0027instantiatedVnfInfo\u0027]"},{"line_number":626,"context_line":"            [\u0027vnfcResourceInfo\u0027])"},{"line_number":627,"context_line":"        self.assertEqual(1, vdu_count)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        # heal as per SOL002 API check, i.e.vnfcInstanceId is passed in"},{"line_number":630,"context_line":"        # the HealVnfRequest."},{"line_number":631,"context_line":"        vnfc_resource_info \u003d (vnf_instance[\u0027instantiatedVnfInfo\u0027]"},{"line_number":632,"context_line":"            [\u0027vnfcResourceInfo\u0027])"},{"line_number":633,"context_line":"        vnfInstanceIds \u003d [vnfc_res_info[\u0027id\u0027] for vnfc_res_info in"},{"line_number":634,"context_line":"            vnfc_resource_info]"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        heal_request_body \u003d {"},{"line_number":637,"context_line":"            \"cause\": \"Heal as per SOL002 API check\","},{"line_number":638,"context_line":"            \"vnfcInstanceId\": vnfInstanceIds"},{"line_number":639,"context_line":"        }"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"        self._heal_vnf_instance(vnf_instance, heal_request_body)"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        # NOTE(tpatil) Wait for sometime as it takes a while to update"},{"line_number":644,"context_line":"        # vnfcResourceInfo after the stack status becomes UPDATE_COMPLETE."},{"line_number":645,"context_line":"        # There is no intermediate status set to VNF which can be used here"},{"line_number":646,"context_line":"        # to confirm healing action is completed successfully."},{"line_number":647,"context_line":"        time.sleep(20)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        vnf_instance_current \u003d self._show_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":650,"context_line":"        self._verify_vnfc_resource_info(vnf_instance, vnf_instance_current, 3)"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        # Terminate vnf forcefully"},{"line_number":653,"context_line":"        terminate_req_body \u003d {"},{"line_number":654,"context_line":"            \"terminationType\": fields.VnfInstanceTerminationType.FORCEFUL"},{"line_number":655,"context_line":"        }"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        self._terminate_vnf_instance(vnf_instance[\u0027id\u0027], terminate_req_body)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    def test_instantiate_vnf_with_ext_vl_and_ext_managed_vl(self):"},{"line_number":662,"context_line":"        \"\"\"Test instantiation vnf with external virtual links"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_5877c7a0","line":659,"range":{"start_line":597,"start_character":0,"end_line":659,"end_character":53},"in_reply_to":"9f560f44_1cce67b3","updated":"2020-09-15 00:56:26.000000000","message":"Sorry, this is a copy miss, thanks for comment, we have fixed this in patch 5","commit_id":"474ec990866a3e65788991383629ffedbaa31f1b"}],"tacker/tests/unit/fixtures.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\"Fixtures for Tacker unit tests.\"\"\""},{"line_number":14,"context_line":"# NOTE(bhagyashris): This is needed for importing from fixtures."},{"line_number":15,"context_line":"from __future__ import absolute_import"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import warnings"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_6ffa3077","line":15,"updated":"2020-09-23 10:34:22.000000000","message":"I don\u0027t understand why it is required for python3.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\"Fixtures for Tacker unit tests.\"\"\""},{"line_number":14,"context_line":"# NOTE(bhagyashris): This is needed for importing from fixtures."},{"line_number":15,"context_line":"from __future__ import absolute_import"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import warnings"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_18e91c19","line":15,"in_reply_to":"9f560f44_6ffa3077","updated":"2020-09-24 11:05:37.000000000","message":"thanks for notice, it is not needed and we removed it in the latest patch, please kindly have a check","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/unit/vnfm/infra_drivers/kubernetes/kubernetes_api_resource/service.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  namespace: default"},{"line_number":9,"context_line":"spec:"},{"line_number":10,"context_line":"  ports:"},{"line_number":11,"context_line":"  - name: \"80\""},{"line_number":12,"context_line":"    port: 80"},{"line_number":13,"context_line":"    targetPort: 8080"},{"line_number":14,"context_line":"  selector:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_6fa510b4","line":11,"updated":"2020-09-23 10:34:22.000000000","message":"Could I confirm that it\u0027s usual to use such a name for a port? For me, `http` is more reasonable than using the port number from my brief survey [1], but sorry if my comment is silly :)\n\n[1] https://kubernetes.io/docs/concepts/services-networking/service/","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  namespace: default"},{"line_number":9,"context_line":"spec:"},{"line_number":10,"context_line":"  ports:"},{"line_number":11,"context_line":"  - name: \"80\""},{"line_number":12,"context_line":"    port: 80"},{"line_number":13,"context_line":"    targetPort: 8080"},{"line_number":14,"context_line":"  selector:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_7892d8a0","line":11,"in_reply_to":"9f560f44_6fa510b4","updated":"2020-09-24 11:05:37.000000000","message":"thanks for notice, we changed it to http","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/unit/vnfm/infra_drivers/kubernetes/kubernetes_api_resource/token-review.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  name: curry-tokenreview-test"},{"line_number":5,"context_line":"  namespace: default"},{"line_number":6,"context_line":"spec:"},{"line_number":7,"context_line":"  token: \"\u003cSA_TOKEN\u003e\"  # SA_TOKEN\u003d$(kubectl describe secret $(kubectl get secrets | grep curry-sa | cut -f1 -d \u0027 \u0027) | grep -E \u0027^token\u0027 | cut -f2 -d\u0027:\u0027 | tr -d \u0027\\t\u0027); echo $SA_TOKEN"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_2f82f852","line":7,"updated":"2020-09-23 10:34:22.000000000","message":"It can be separate multiple line to make it more readable because it\u0027s just a comment.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  name: curry-tokenreview-test"},{"line_number":5,"context_line":"  namespace: default"},{"line_number":6,"context_line":"spec:"},{"line_number":7,"context_line":"  token: \"\u003cSA_TOKEN\u003e\"  # SA_TOKEN\u003d$(kubectl describe secret $(kubectl get secrets | grep curry-sa | cut -f1 -d \u0027 \u0027) | grep -E \u0027^token\u0027 | cut -f2 -d\u0027:\u0027 | tr -d \u0027\\t\u0027); echo $SA_TOKEN"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_587a7476","line":7,"in_reply_to":"9f560f44_2f82f852","updated":"2020-09-24 11:05:37.000000000","message":"thanks for suggestion, we have fixed in the latest patch.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/tests/unit/vnfm/infra_drivers/kubernetes/test_translate_outputs.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tacker.tests.unit import fake_request"},{"line_number":20,"context_line":"from tacker.tests.unit.vnfm.infra_drivers.kubernetes import fakes"},{"line_number":21,"context_line":"from tacker.vnfm.infra_drivers.kubernetes.k8s import translate_outputs"},{"line_number":22,"context_line":"from unittest import mock"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestTransformer(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_5726e8bb","line":22,"updated":"2020-09-23 10:34:22.000000000","message":"Please correct the order of importing.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tacker.tests.unit import fake_request"},{"line_number":20,"context_line":"from tacker.tests.unit.vnfm.infra_drivers.kubernetes import fakes"},{"line_number":21,"context_line":"from tacker.vnfm.infra_drivers.kubernetes.k8s import translate_outputs"},{"line_number":22,"context_line":"from unittest import mock"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestTransformer(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_98aecce4","line":22,"in_reply_to":"9f560f44_5726e8bb","updated":"2020-09-24 11:05:37.000000000","message":"re-ordered in latest patch, thanks for suggestion","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/vnfm/infra_drivers/kubernetes/k8s/translate_outputs.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import re"},{"line_number":18,"context_line":"import yaml"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from kubernetes import client"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"from tacker.common import exceptions"},{"line_number":24,"context_line":"import toscaparser.utils.yamlparser"},{"line_number":25,"context_line":"from urllib.parse import urlparse"},{"line_number":26,"context_line":"import urllib.request as urllib2"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_d7103852","line":26,"range":{"start_line":20,"start_character":0,"end_line":26,"end_character":32},"updated":"2020-09-23 10:34:22.000000000","message":"Please take care about the order of importing for the guidelines.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import re"},{"line_number":18,"context_line":"import yaml"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from kubernetes import client"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"from tacker.common import exceptions"},{"line_number":24,"context_line":"import toscaparser.utils.yamlparser"},{"line_number":25,"context_line":"from urllib.parse import urlparse"},{"line_number":26,"context_line":"import urllib.request as urllib2"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_4410d459","line":26,"range":{"start_line":20,"start_character":0,"end_line":26,"end_character":32},"in_reply_to":"9f560f44_d7103852","updated":"2020-09-24 11:05:37.000000000","message":"We have re-ordered import in the lateset patch, please kindly have a check","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":36,"context_line":"NON_WHITE_SPACE_CHARACTER \u003d \u0027\u0027"},{"line_number":37,"context_line":"HYPHEN_CHARACTER \u003d \u0027-\u0027"},{"line_number":38,"context_line":"DASH_CHARACTER \u003d \u0027_\u0027"},{"line_number":39,"context_line":"OTHER_RESOURCE_SORT_POSITION \u003d 8"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class Transformer(object):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_0c4aa7ab","line":39,"updated":"2020-09-23 10:34:22.000000000","message":"Could you add an explanation for the purpose or meaning because it looks like a magic number without it?","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":36,"context_line":"NON_WHITE_SPACE_CHARACTER \u003d \u0027\u0027"},{"line_number":37,"context_line":"HYPHEN_CHARACTER \u003d \u0027-\u0027"},{"line_number":38,"context_line":"DASH_CHARACTER \u003d \u0027_\u0027"},{"line_number":39,"context_line":"OTHER_RESOURCE_SORT_POSITION \u003d 8"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class Transformer(object):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_24132067","line":39,"in_reply_to":"9f560f44_0c4aa7ab","updated":"2020-09-24 11:05:37.000000000","message":"An explanation is added in the newest patch, please kindly have a check on it :)","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.scaling_api_client \u003d scaling_api_client"},{"line_number":51,"context_line":"        # the new param used when instantiating vnf with addtionalParams"},{"line_number":52,"context_line":"        self.k8s_client_dict \u003d k8s_client_dict"},{"line_number":53,"context_line":"        self.SORT \u003d ["},{"line_number":54,"context_line":"            \u0027StorageClass\u0027,"},{"line_number":55,"context_line":"            \u0027PersistentVolume\u0027,"},{"line_number":56,"context_line":"            \u0027PriorityClass\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_8cb23795","line":53,"range":{"start_line":53,"start_character":13,"end_line":53,"end_character":17},"updated":"2020-09-23 10:34:22.000000000","message":"Could I confirm the meaning of the term because it\u0027s not clear for the usage possibly? You mean \u0027variety\u0027? or \u0027order\u0027 for sorting?","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.scaling_api_client \u003d scaling_api_client"},{"line_number":51,"context_line":"        # the new param used when instantiating vnf with addtionalParams"},{"line_number":52,"context_line":"        self.k8s_client_dict \u003d k8s_client_dict"},{"line_number":53,"context_line":"        self.SORT \u003d ["},{"line_number":54,"context_line":"            \u0027StorageClass\u0027,"},{"line_number":55,"context_line":"            \u0027PersistentVolume\u0027,"},{"line_number":56,"context_line":"            \u0027PriorityClass\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_38086025","line":53,"range":{"start_line":53,"start_character":13,"end_line":53,"end_character":17},"in_reply_to":"9f560f44_8cb23795","updated":"2020-09-24 11:05:37.000000000","message":"here is defining standard creation order of each resource, we changed the variable name in the latest patch, please kindly have a check","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        return kubernetes_objects"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _create_k8s_object(self, kind, file_content_dict):"},{"line_number":159,"context_line":"        \"\"\"must_param referring K8s official object page"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        *e.g:https://github.com/kubernetes-client/python/blob/master/kubernetes/docs/V1Service.md"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_ac1c5b13","line":159,"updated":"2020-09-23 10:34:22.000000000","message":"You shouldn\u0027t write a comment for a variable as a docstrinig. Here is for describing an explanation of method. In this case, you\u0027d better to write it as a plain comment starts with \u0027#\u0027.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        return kubernetes_objects"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _create_k8s_object(self, kind, file_content_dict):"},{"line_number":159,"context_line":"        \"\"\"must_param referring K8s official object page"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        *e.g:https://github.com/kubernetes-client/python/blob/master/kubernetes/docs/V1Service.md"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_98124c57","line":159,"in_reply_to":"9f560f44_ac1c5b13","updated":"2020-09-24 11:05:37.000000000","message":"character fixed , please kindly have a check :)","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            \u0027V1VolumeAttachmentStatus\u0027: \u0027(attached\u003dTrue)\u0027,"},{"line_number":274,"context_line":"        }"},{"line_number":275,"context_line":"        whole_kind \u003d \u0027V1\u0027 + kind"},{"line_number":276,"context_line":"        if whole_kind in must_param.keys():"},{"line_number":277,"context_line":"            k8s_obj \u003d eval(\u0027client.V1\u0027 + kind + must_param.get(whole_kind))"},{"line_number":278,"context_line":"        else:"},{"line_number":279,"context_line":"            k8s_obj \u003d eval(\u0027client.V1\u0027 + kind + \u0027()\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_8cd7d722","line":276,"updated":"2020-09-23 10:34:22.000000000","message":"Could I confirm why `must_param[\u0027RuntimeRawExtension\u0027]` is included in `must_param`, but not used? It\u0027s not started with `V1`, so never be evaluated.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            \u0027V1VolumeAttachmentStatus\u0027: \u0027(attached\u003dTrue)\u0027,"},{"line_number":274,"context_line":"        }"},{"line_number":275,"context_line":"        whole_kind \u003d \u0027V1\u0027 + kind"},{"line_number":276,"context_line":"        if whole_kind in must_param.keys():"},{"line_number":277,"context_line":"            k8s_obj \u003d eval(\u0027client.V1\u0027 + kind + must_param.get(whole_kind))"},{"line_number":278,"context_line":"        else:"},{"line_number":279,"context_line":"            k8s_obj \u003d eval(\u0027client.V1\u0027 + kind + \u0027()\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_d8468450","line":276,"in_reply_to":"9f560f44_8cd7d722","updated":"2020-09-24 11:05:37.000000000","message":"RuntimeRawExetnsion is required when instantiate controllerVersion so we decide it should be required here.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        return \",\".join(deployment_names)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def deploy_k8s(self, kubernetes_objects):"},{"line_number":386,"context_line":"        \"\"\"Deploy Kubernetes objects on Kubernetes VIM and return"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        a list name of services"},{"line_number":389,"context_line":"        \"\"\""},{"line_number":390,"context_line":"        kubernetes_objects \u003d self._sort_k8s_obj(kubernetes_objects)"},{"line_number":391,"context_line":"        new_k8s_objs \u003d list()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_0c72a74a","line":388,"range":{"start_line":386,"start_character":8,"end_line":388,"end_character":31},"updated":"2020-09-23 10:34:22.000000000","message":"It\u0027s wrong because the 1st line is for title and followed by body after one blank line. Could you correct for the guideline?","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        return \",\".join(deployment_names)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def deploy_k8s(self, kubernetes_objects):"},{"line_number":386,"context_line":"        \"\"\"Deploy Kubernetes objects on Kubernetes VIM and return"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        a list name of services"},{"line_number":389,"context_line":"        \"\"\""},{"line_number":390,"context_line":"        kubernetes_objects \u003d self._sort_k8s_obj(kubernetes_objects)"},{"line_number":391,"context_line":"        new_k8s_objs \u003d list()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_9869acbf","line":388,"range":{"start_line":386,"start_character":8,"end_line":388,"end_character":31},"in_reply_to":"9f560f44_0c72a74a","updated":"2020-09-24 11:05:37.000000000","message":"we fixed this , could you please kindly have a check?","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                    setattr(obj, param_value, rely_objs)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def _sort_k8s_obj(self, k8s_objs):"},{"line_number":471,"context_line":"        flag \u003d 0"},{"line_number":472,"context_line":"        objs \u003d k8s_objs"},{"line_number":473,"context_line":"        new_k8s_objs \u003d list()"},{"line_number":474,"context_line":"        for sort_index, kind in enumerate(self.SORT):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_ecf49357","line":471,"range":{"start_line":471,"start_character":8,"end_line":471,"end_character":12},"updated":"2020-09-23 10:34:22.000000000","message":"`pos` or `idx` is better. `flag` isn\u0027t appropriate for considering the meaning at least.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                    setattr(obj, param_value, rely_objs)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def _sort_k8s_obj(self, k8s_objs):"},{"line_number":471,"context_line":"        flag \u003d 0"},{"line_number":472,"context_line":"        objs \u003d k8s_objs"},{"line_number":473,"context_line":"        new_k8s_objs \u003d list()"},{"line_number":474,"context_line":"        for sort_index, kind in enumerate(self.SORT):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_786498e5","line":471,"range":{"start_line":471,"start_character":8,"end_line":471,"end_character":12},"in_reply_to":"9f560f44_ecf49357","updated":"2020-09-24 11:05:37.000000000","message":"fixed to pos","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f9acb9808d00f6939e35be3204d227d2d8a18147","unresolved":false,"context_lines":[{"line_number":470,"context_line":"    def _sort_k8s_obj(self, k8s_objs):"},{"line_number":471,"context_line":"        flag \u003d 0"},{"line_number":472,"context_line":"        objs \u003d k8s_objs"},{"line_number":473,"context_line":"        new_k8s_objs \u003d list()"},{"line_number":474,"context_line":"        for sort_index, kind in enumerate(self.SORT):"},{"line_number":475,"context_line":"            for obj_index, obj in enumerate(objs):"},{"line_number":476,"context_line":"                if obj[\"object\"].kind \u003d\u003d kind:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_2c984b19","line":473,"range":{"start_line":473,"start_character":8,"end_line":473,"end_character":12},"updated":"2020-09-23 10:34:22.000000000","message":"`sorted_` is better.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":470,"context_line":"    def _sort_k8s_obj(self, k8s_objs):"},{"line_number":471,"context_line":"        flag \u003d 0"},{"line_number":472,"context_line":"        objs \u003d k8s_objs"},{"line_number":473,"context_line":"        new_k8s_objs \u003d list()"},{"line_number":474,"context_line":"        for sort_index, kind in enumerate(self.SORT):"},{"line_number":475,"context_line":"            for obj_index, obj in enumerate(objs):"},{"line_number":476,"context_line":"                if obj[\"object\"].kind \u003d\u003d kind:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_d85fa40c","line":473,"range":{"start_line":473,"start_character":8,"end_line":473,"end_character":12},"in_reply_to":"9f560f44_2c984b19","updated":"2020-09-24 11:05:37.000000000","message":"fixed to sorted_ , thank you very much for suggestion","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}],"tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5bc2f660753a4ec7319b2695a506d45c2dbd075e","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                    wait\u003d(self.STACK_RETRIES * self.STACK_RETRY_WAIT),"},{"line_number":277,"context_line":"                    stack\u003dvnf_instance.id"},{"line_number":278,"context_line":"                )"},{"line_number":279,"context_line":"                raise vnfm.CNFCreateWaitFailed(reason\u003derror_reason)"},{"line_number":280,"context_line":"            return k8s_objs"},{"line_number":281,"context_line":"        except Exception as e:"},{"line_number":282,"context_line":"            LOG.error(\u0027Creating wait CNF got an error due to %s\u0027, e)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_e1cfd526","line":279,"range":{"start_line":279,"start_character":16,"end_line":279,"end_character":67},"updated":"2020-09-02 10:36:46.000000000","message":"When this exception is raised, I think rollback action is not working well.\nIt seems that the process of terminate is not executed because `instantiated_vnf_info` is not in `vnf_instance` yet.(*1)\nPlease make changes so that the rollback process is executed normally.\n\n(*1) https://review.opendev.org/#/c/746691/4/tacker/vnflcm/vnflcm_driver.py@280","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"378f796f17144b8157230cc5aca8e3b5da497e26","unresolved":false,"context_lines":[{"line_number":693,"context_line":"            raise"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"    def _select_delete_api(self, k8s_client_dict, namespace, name,"},{"line_number":696,"context_line":"                           kind, api_version, body):"},{"line_number":697,"context_line":"        \"\"\"select kubernetes delete api and call\"\"\""},{"line_number":698,"context_line":"        def convert(name):"},{"line_number":699,"context_line":"            name_with_underscores \u003d re.sub("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_6ef10902","line":696,"range":{"start_line":696,"start_character":46,"end_line":696,"end_character":50},"updated":"2020-09-01 06:52:43.000000000","message":"The `body` argument is not used in this method, I think `body` is  need to add to args of delete_api() method.","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"8df344e1bfb5819a95856ca2aba6d905330b1772","unresolved":false,"context_lines":[{"line_number":693,"context_line":"            raise"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"    def _select_delete_api(self, k8s_client_dict, namespace, name,"},{"line_number":696,"context_line":"                           kind, api_version, body):"},{"line_number":697,"context_line":"        \"\"\"select kubernetes delete api and call\"\"\""},{"line_number":698,"context_line":"        def convert(name):"},{"line_number":699,"context_line":"            name_with_underscores \u003d re.sub("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_d81de4be","line":696,"range":{"start_line":696,"start_character":46,"end_line":696,"end_character":50},"in_reply_to":"9f560f44_6ef10902","updated":"2020-09-24 11:25:35.000000000","message":"body is added as a arg in delete_api method. please kindly havea a check","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"36b21885af983cdb53e92d77e119525b1fe0e597","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"                          vim_connection_info, vnf_software_images,"},{"line_number":1181,"context_line":"                          instantiate_vnf_req, vnf_package_path):"},{"line_number":1182,"context_line":"        vnf_resources \u003d dict()"},{"line_number":1183,"context_line":"        artifact_files \u003d self._get_artifact_files(instantiate_vnf_req)"},{"line_number":1184,"context_line":"        if not artifact_files:"},{"line_number":1185,"context_line":"            # if artifact_files is not provided in request,"},{"line_number":1186,"context_line":"            # we consider k8s info in provided by TOSCA-based VNFD"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_b26580e3","line":1183,"range":{"start_line":1183,"start_character":8,"end_line":1183,"end_character":22},"updated":"2020-08-28 00:39:26.000000000","message":"This name of variable is confusing because we also have `vnf_artifacts` later. Something like \"target_k8s_files\" seems better.","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"071eea16cece07697d52384b1e489fcaf698f652","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"                          vim_connection_info, vnf_software_images,"},{"line_number":1181,"context_line":"                          instantiate_vnf_req, vnf_package_path):"},{"line_number":1182,"context_line":"        vnf_resources \u003d dict()"},{"line_number":1183,"context_line":"        artifact_files \u003d self._get_artifact_files(instantiate_vnf_req)"},{"line_number":1184,"context_line":"        if not artifact_files:"},{"line_number":1185,"context_line":"            # if artifact_files is not provided in request,"},{"line_number":1186,"context_line":"            # we consider k8s info in provided by TOSCA-based VNFD"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_584ea76e","line":1183,"range":{"start_line":1183,"start_character":8,"end_line":1183,"end_character":22},"in_reply_to":"9f560f44_b26580e3","updated":"2020-09-15 00:56:26.000000000","message":"we changed this variable name to target_k8s_files in patch 5, please kind have a check on it","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"36b21885af983cdb53e92d77e119525b1fe0e597","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"                        grant_response, vnf_package_path, base_hot_dict):"},{"line_number":1259,"context_line":"        artifact_files \u003d self._get_artifact_files(instantiate_vnf_req)"},{"line_number":1260,"context_line":"        auth_attr \u003d vim_connection_info.access_info"},{"line_number":1261,"context_line":"        if not artifact_files:"},{"line_number":1262,"context_line":"            instance_id \u003d self.create("},{"line_number":1263,"context_line":"                None, context, vnf_instance, auth_attr)"},{"line_number":1264,"context_line":"            return instance_id"},{"line_number":1265,"context_line":"        else:"},{"line_number":1266,"context_line":"            auth_cred, file_descriptor \u003d self._get_auth_creds(auth_attr)"},{"line_number":1267,"context_line":"            k8s_client_dict \u003d self.kubernetes.get_k8s_client_dict(auth_cred)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_37504232","line":1264,"range":{"start_line":1261,"start_character":7,"end_line":1264,"end_character":30},"updated":"2020-08-28 00:39:26.000000000","message":"Could you put a note here to describe that this condition provides the case for TOSCA based CNF operation and that is out of the scope of this patch.","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"071eea16cece07697d52384b1e489fcaf698f652","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"                        grant_response, vnf_package_path, base_hot_dict):"},{"line_number":1259,"context_line":"        artifact_files \u003d self._get_artifact_files(instantiate_vnf_req)"},{"line_number":1260,"context_line":"        auth_attr \u003d vim_connection_info.access_info"},{"line_number":1261,"context_line":"        if not artifact_files:"},{"line_number":1262,"context_line":"            instance_id \u003d self.create("},{"line_number":1263,"context_line":"                None, context, vnf_instance, auth_attr)"},{"line_number":1264,"context_line":"            return instance_id"},{"line_number":1265,"context_line":"        else:"},{"line_number":1266,"context_line":"            auth_cred, file_descriptor \u003d self._get_auth_creds(auth_attr)"},{"line_number":1267,"context_line":"            k8s_client_dict \u003d self.kubernetes.get_k8s_client_dict(auth_cred)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_3847734f","line":1264,"range":{"start_line":1261,"start_character":7,"end_line":1264,"end_character":30},"in_reply_to":"9f560f44_37504232","updated":"2020-09-15 00:56:26.000000000","message":"thanks for comment! we have added a note in patch 5.","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"36b21885af983cdb53e92d77e119525b1fe0e597","unresolved":false,"context_lines":[{"line_number":1289,"context_line":"                deployment_dict[\u0027kind\u0027] \u003d k8s_obj.get(\u0027object\u0027).kind"},{"line_number":1290,"context_line":"                deployment_dict[\u0027status\u0027] \u003d k8s_obj.get(\u0027status\u0027)"},{"line_number":1291,"context_line":"                deployment_dict_list.append(deployment_dict)"},{"line_number":1292,"context_line":"            deployment_str_list \u003d [str(x) for x in deployment_dict_list]"},{"line_number":1293,"context_line":"            resource_info_str \u003d \u0027;\u0027.join(deployment_str_list)"},{"line_number":1294,"context_line":"            self.clean_authenticate_vim(auth_cred, file_descriptor)"},{"line_number":1295,"context_line":"            vnfd_dict[\u0027instance_id\u0027] \u003d resource_info_str"},{"line_number":1296,"context_line":"            return resource_info_str"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_d23c74c9","line":1293,"range":{"start_line":1292,"start_character":12,"end_line":1293,"end_character":61},"updated":"2020-08-28 00:39:26.000000000","message":"Is the `instance_id` created from all `deployment_dict`? If so, it\u0027s better to put a note to explain it.","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"071eea16cece07697d52384b1e489fcaf698f652","unresolved":false,"context_lines":[{"line_number":1289,"context_line":"                deployment_dict[\u0027kind\u0027] \u003d k8s_obj.get(\u0027object\u0027).kind"},{"line_number":1290,"context_line":"                deployment_dict[\u0027status\u0027] \u003d k8s_obj.get(\u0027status\u0027)"},{"line_number":1291,"context_line":"                deployment_dict_list.append(deployment_dict)"},{"line_number":1292,"context_line":"            deployment_str_list \u003d [str(x) for x in deployment_dict_list]"},{"line_number":1293,"context_line":"            resource_info_str \u003d \u0027;\u0027.join(deployment_str_list)"},{"line_number":1294,"context_line":"            self.clean_authenticate_vim(auth_cred, file_descriptor)"},{"line_number":1295,"context_line":"            vnfd_dict[\u0027instance_id\u0027] \u003d resource_info_str"},{"line_number":1296,"context_line":"            return resource_info_str"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_78728bb2","line":1293,"range":{"start_line":1292,"start_character":12,"end_line":1293,"end_character":61},"in_reply_to":"9f560f44_d23c74c9","updated":"2020-09-15 00:56:26.000000000","message":"thanks for comment, we have added a note here in patch 5","commit_id":"7cd80ad80b678299238a1e005b99ca362a666624"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"25fb1398992ded9755f98303529de2b318b9b596","unresolved":false,"context_lines":[{"line_number":754,"context_line":""},{"line_number":755,"context_line":"    @log.log"},{"line_number":756,"context_line":"    def _delete_k8s_obj(self, kind, k8s_client_dict, vnf_resource, body):"},{"line_number":757,"context_line":"        namespace \u003d vnf_resource.resource_name.\\"},{"line_number":758,"context_line":"            split(COMMA_CHARACTER)[0]"},{"line_number":759,"context_line":"        name \u003d vnf_resource.resource_name.\\"},{"line_number":760,"context_line":"            split(COMMA_CHARACTER)[1]"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_f1a61fac","line":757,"range":{"start_line":757,"start_character":8,"end_line":757,"end_character":17},"updated":"2020-09-23 14:20:11.000000000","message":"what will be value of namespace in case object being deleted itself is namespace?","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"25fb1398992ded9755f98303529de2b318b9b596","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        try:"},{"line_number":776,"context_line":"            self._select_delete_api("},{"line_number":777,"context_line":"                k8s_client_dict\u003dk8s_client_dict,"},{"line_number":778,"context_line":"                namespace\u003dnamespace,"},{"line_number":779,"context_line":"                name\u003dname,"},{"line_number":780,"context_line":"                kind\u003dkind,"},{"line_number":781,"context_line":"                api_version\u003dapi_version,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_f1bf3fa8","line":778,"range":{"start_line":778,"start_character":16,"end_line":778,"end_character":36},"updated":"2020-09-23 14:20:11.000000000","message":"will it handle namespace object deletion as well, i am not sure if we need to have separate delete call to handle namespace of namespace object?","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        try:"},{"line_number":776,"context_line":"            self._select_delete_api("},{"line_number":777,"context_line":"                k8s_client_dict\u003dk8s_client_dict,"},{"line_number":778,"context_line":"                namespace\u003dnamespace,"},{"line_number":779,"context_line":"                name\u003dname,"},{"line_number":780,"context_line":"                kind\u003dkind,"},{"line_number":781,"context_line":"                api_version\u003dapi_version,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_e433e811","line":778,"range":{"start_line":778,"start_character":16,"end_line":778,"end_character":36},"in_reply_to":"9f560f44_f1bf3fa8","updated":"2020-09-24 11:05:37.000000000","message":"It could also handle namespace objects.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"25fb1398992ded9755f98303529de2b318b9b596","unresolved":false,"context_lines":[{"line_number":839,"context_line":"                    \u0027Pod\u0027,"},{"line_number":840,"context_line":"                    # 3."},{"line_number":841,"context_line":"                    \u0027PersistentVolumeClaim\u0027, \u0027ConfigMap\u0027, \u0027Secret\u0027,"},{"line_number":842,"context_line":"                    \u0027PriorityClass\u0027,"},{"line_number":843,"context_line":"                    # 4."},{"line_number":844,"context_line":"                    \u0027PersistentVolume\u0027,"},{"line_number":845,"context_line":"                    # 5."}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_d13f9b1f","line":842,"range":{"start_line":842,"start_character":21,"end_line":842,"end_character":34},"updated":"2020-09-23 14:20:11.000000000","message":"priority classes are non-namespaced.\nwill this code handle deletion of non-namespaced objects properly?","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"21f017770922a3f5dd1a78c182f7a4ba717f70ef","unresolved":false,"context_lines":[{"line_number":839,"context_line":"                    \u0027Pod\u0027,"},{"line_number":840,"context_line":"                    # 3."},{"line_number":841,"context_line":"                    \u0027PersistentVolumeClaim\u0027, \u0027ConfigMap\u0027, \u0027Secret\u0027,"},{"line_number":842,"context_line":"                    \u0027PriorityClass\u0027,"},{"line_number":843,"context_line":"                    # 4."},{"line_number":844,"context_line":"                    \u0027PersistentVolume\u0027,"},{"line_number":845,"context_line":"                    # 5."}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_041a5c7b","line":842,"range":{"start_line":842,"start_character":21,"end_line":842,"end_character":34},"in_reply_to":"9f560f44_d13f9b1f","updated":"2020-09-24 11:05:37.000000000","message":"this code could handle non-namespaced objects delection. It will call delete_namespaced_{resource}/delete_{resource} by judging if namespace exist in object.","commit_id":"40b63b2caca36d569eee805613ee14ddfe4c65aa"}]}