)]}'
{"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        try:"},{"line_number":144,"context_line":"            vnf \u003d self._vnfm_plugin.get_vnf(context, id)"},{"line_number":145,"context_line":"        except vnfm.VNFNotFound:"},{"line_number":146,"context_line":"            msg \u003d _(\"Can not find requested vnf: %s\") % id"},{"line_number":147,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8a0a3bcf","line":144,"updated":"2020-08-21 07:20:13.000000000","message":"If vnf.status!\u003d\"ACTIVE\", I think you need to return 409 Conflict.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        try:"},{"line_number":144,"context_line":"            vnf \u003d self._vnfm_plugin.get_vnf(context, id)"},{"line_number":145,"context_line":"        except vnfm.VNFNotFound:"},{"line_number":146,"context_line":"            msg \u003d _(\"Can not find requested vnf: %s\") % id"},{"line_number":147,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4e824002","line":144,"in_reply_to":"9f560f44_8a0a3bcf","updated":"2020-09-02 14:16:14.000000000","message":"it might not be possible to add if vnf.status!\u003d\u0027ACTIVE\u0027 here since _get_vnf method is commonly used by instantiate, terminate and heal to fetch the vnf_dict. To fix this, a decorator method \u0027check_vnf_status\u0027 is added to validate the appropriate vnf status for each lcm. \n\nModified files:\ntacker\\api\\vnflcm\\v1\\controller.py\ntacker\\common\\exceptions.py","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                % vim_id"},{"line_number":219,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def _instantiation_notification_process("},{"line_number":222,"context_line":"            self, context, vnf_instance, instantiate_vnf_request):"},{"line_number":223,"context_line":"        vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()"},{"line_number":224,"context_line":"        is_auto \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4a16634b","line":221,"updated":"2020-08-21 07:20:13.000000000","message":"Since there are many logics similar to _healing_notification_process, can it be commonize?","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                % vim_id"},{"line_number":219,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def _instantiation_notification_process("},{"line_number":222,"context_line":"            self, context, vnf_instance, instantiate_vnf_request):"},{"line_number":223,"context_line":"        vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()"},{"line_number":224,"context_line":"        is_auto \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_cec77064","line":221,"in_reply_to":"9f560f44_4a16634b","updated":"2020-09-02 14:16:14.000000000","message":"Added common notification processing:_notification_process\nremove: _instantiation_notification_process,\n_healing_notification_process","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        is_auto \u003d False"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        try:"},{"line_number":227,"context_line":"            # call create lcm op occs here"},{"line_number":228,"context_line":"            LOG.debug(\u0027Create LCM OP OCCS\u0027)"},{"line_number":229,"context_line":"            vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc("},{"line_number":230,"context_line":"                context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c52a6be5","line":227,"updated":"2020-08-20 05:51:45.000000000","message":"Since the same logic is defined in multiple places, can you cut out as a method and made common?","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        is_auto \u003d False"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        try:"},{"line_number":227,"context_line":"            # call create lcm op occs here"},{"line_number":228,"context_line":"            LOG.debug(\u0027Create LCM OP OCCS\u0027)"},{"line_number":229,"context_line":"            vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc("},{"line_number":230,"context_line":"                context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_aec4bc60","line":227,"in_reply_to":"9f560f44_c52a6be5","updated":"2020-09-02 14:16:14.000000000","message":"Added common notification processing: _notification_process\nremoved:_instantiation_notification_process,\n_healing_notification_process","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c8bfbe9411d74ef2fec523d7e01e4395d865063e","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            \u0027isAutomaticInvocation\u0027: is_auto,"},{"line_number":256,"context_line":"            \u0027vnfLcmOpOccId\u0027: vnf_lcm_op_occs_id,"},{"line_number":257,"context_line":"            \u0027_links\u0027: {\u0027vnfInstance\u0027: {"},{"line_number":258,"context_line":"                \u0027href\u0027: \u0027/vnflcm/v1/vnf_instances/%s\u0027 % vnf_instance.id},"},{"line_number":259,"context_line":"                \u0027vnfLcmOpOcc\u0027: {"},{"line_number":260,"context_line":"                    \u0027href\u0027: ("},{"line_number":261,"context_line":"                        \u0027/vnflcmv1/vnf_lcm_op_occs/%s\u0027 % vnf_lcm_op_occs_id)}}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2e4b915f","line":258,"updated":"2020-09-01 06:37:21.000000000","message":"It is better to use self._get_vnf_instance_href(vnf_instance).","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"535e90e632d1cf420e03f16a3b64d80900971a40","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            \u0027isAutomaticInvocation\u0027: is_auto,"},{"line_number":256,"context_line":"            \u0027vnfLcmOpOccId\u0027: vnf_lcm_op_occs_id,"},{"line_number":257,"context_line":"            \u0027_links\u0027: {\u0027vnfInstance\u0027: {"},{"line_number":258,"context_line":"                \u0027href\u0027: \u0027/vnflcm/v1/vnf_instances/%s\u0027 % vnf_instance.id},"},{"line_number":259,"context_line":"                \u0027vnfLcmOpOcc\u0027: {"},{"line_number":260,"context_line":"                    \u0027href\u0027: ("},{"line_number":261,"context_line":"                        \u0027/vnflcmv1/vnf_lcm_op_occs/%s\u0027 % vnf_lcm_op_occs_id)}}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e4ec882a","line":258,"in_reply_to":"9f560f44_2e4b915f","updated":"2020-09-10 05:24:50.000000000","message":"Modified as you suggested.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"d771c8a0b0fd62279e237832d577d5786d365ed8","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                \u0027href\u0027: \u0027/vnflcm/v1/vnf_instances/%s\u0027 % vnf_instance.id},"},{"line_number":259,"context_line":"                \u0027vnfLcmOpOcc\u0027: {"},{"line_number":260,"context_line":"                    \u0027href\u0027: ("},{"line_number":261,"context_line":"                        \u0027/vnflcmv1/vnf_lcm_op_occs/%s\u0027 % vnf_lcm_op_occs_id)}}}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        # call sendNotification"},{"line_number":264,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_be1a9d6b","line":261,"range":{"start_line":261,"start_character":25,"end_line":261,"end_character":35},"updated":"2020-08-26 02:32:10.000000000","message":"Typo: /vnflcm/v1/","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c48a2ca6b23f935af755cebab0493b79e9542d4f","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                \u0027href\u0027: \u0027/vnflcm/v1/vnf_instances/%s\u0027 % vnf_instance.id},"},{"line_number":259,"context_line":"                \u0027vnfLcmOpOcc\u0027: {"},{"line_number":260,"context_line":"                    \u0027href\u0027: ("},{"line_number":261,"context_line":"                        \u0027/vnflcmv1/vnf_lcm_op_occs/%s\u0027 % vnf_lcm_op_occs_id)}}}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        # call sendNotification"},{"line_number":264,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a61db374","line":261,"range":{"start_line":261,"start_character":25,"end_line":261,"end_character":35},"in_reply_to":"9f560f44_2ba08c91","updated":"2020-09-22 01:23:01.000000000","message":"It is fixed.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7e264f797fd501bacb39a6a1244c4d77ff7bb226","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                \u0027href\u0027: \u0027/vnflcm/v1/vnf_instances/%s\u0027 % vnf_instance.id},"},{"line_number":259,"context_line":"                \u0027vnfLcmOpOcc\u0027: {"},{"line_number":260,"context_line":"                    \u0027href\u0027: ("},{"line_number":261,"context_line":"                        \u0027/vnflcmv1/vnf_lcm_op_occs/%s\u0027 % vnf_lcm_op_occs_id)}}}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        # call sendNotification"},{"line_number":264,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2ba08c91","line":261,"range":{"start_line":261,"start_character":25,"end_line":261,"end_character":35},"in_reply_to":"9f560f44_64d8787e","updated":"2020-09-17 10:17:57.000000000","message":"I disagree with your answer that you don\u0027t have enough time to fix it.\nFor the following reasons, I think it\u0027s better to create a function like self._get_vnf_lcm_op_occs_href to create the URL.\n\n* To improve code maintainability by following the existing coding\n* Prevent typo of URL creation","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"535e90e632d1cf420e03f16a3b64d80900971a40","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                \u0027href\u0027: \u0027/vnflcm/v1/vnf_instances/%s\u0027 % vnf_instance.id},"},{"line_number":259,"context_line":"                \u0027vnfLcmOpOcc\u0027: {"},{"line_number":260,"context_line":"                    \u0027href\u0027: ("},{"line_number":261,"context_line":"                        \u0027/vnflcmv1/vnf_lcm_op_occs/%s\u0027 % vnf_lcm_op_occs_id)}}}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        # call sendNotification"},{"line_number":264,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_64d8787e","line":261,"range":{"start_line":261,"start_character":25,"end_line":261,"end_character":35},"in_reply_to":"9f560f44_8e3bbdc6","updated":"2020-09-10 05:24:50.000000000","message":"Thank you for the suggestion, but decided to leave as it is because of less time for the further modification.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                \u0027href\u0027: \u0027/vnflcm/v1/vnf_instances/%s\u0027 % vnf_instance.id},"},{"line_number":259,"context_line":"                \u0027vnfLcmOpOcc\u0027: {"},{"line_number":260,"context_line":"                    \u0027href\u0027: ("},{"line_number":261,"context_line":"                        \u0027/vnflcmv1/vnf_lcm_op_occs/%s\u0027 % vnf_lcm_op_occs_id)}}}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        # call sendNotification"},{"line_number":264,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4e97e03b","line":261,"range":{"start_line":261,"start_character":25,"end_line":261,"end_character":35},"in_reply_to":"9f560f44_8e3bbdc6","updated":"2020-09-02 14:16:14.000000000","message":"fixed the typo.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c8bfbe9411d74ef2fec523d7e01e4395d865063e","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                \u0027href\u0027: \u0027/vnflcm/v1/vnf_instances/%s\u0027 % vnf_instance.id},"},{"line_number":259,"context_line":"                \u0027vnfLcmOpOcc\u0027: {"},{"line_number":260,"context_line":"                    \u0027href\u0027: ("},{"line_number":261,"context_line":"                        \u0027/vnflcmv1/vnf_lcm_op_occs/%s\u0027 % vnf_lcm_op_occs_id)}}}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        # call sendNotification"},{"line_number":264,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8e3bbdc6","line":261,"range":{"start_line":261,"start_character":25,"end_line":261,"end_character":35},"in_reply_to":"9f560f44_be1a9d6b","updated":"2020-09-01 06:37:21.000000000","message":"In order to prevent the same typo from being created in multiple places, it is better to create an internal function for building the URL, such as self._get_vnf_instance_href().","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                    \u0027href\u0027: ("},{"line_number":261,"context_line":"                        \u0027/vnflcmv1/vnf_lcm_op_occs/%s\u0027 % vnf_lcm_op_occs_id)}}}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        # call sendNotification"},{"line_number":264,"context_line":"        try:"},{"line_number":265,"context_line":"            self.rpc_api.sendNotification(context, notification)"},{"line_number":266,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_45f93b7e","line":263,"updated":"2020-08-20 05:51:45.000000000","message":"Since the same logic is defined in multiple places, can you cut out as a method and made common?","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                    \u0027href\u0027: ("},{"line_number":261,"context_line":"                        \u0027/vnflcmv1/vnf_lcm_op_occs/%s\u0027 % vnf_lcm_op_occs_id)}}}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        # call sendNotification"},{"line_number":264,"context_line":"        try:"},{"line_number":265,"context_line":"            self.rpc_api.sendNotification(context, notification)"},{"line_number":266,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6ecbc449","line":263,"in_reply_to":"9f560f44_45f93b7e","updated":"2020-09-02 14:16:14.000000000","message":"Added common notification processing:_notification_process\n\nremove: _instantiation_notification_process, _healing_notification_process","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"d771c8a0b0fd62279e237832d577d5786d365ed8","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                    \u0027href\u0027: \u0027/vnflcm/v1/vnf_instances/%s\u0027 % vnf_instance.id},"},{"line_number":316,"context_line":"                \u0027vnfLcmOpOcc\u0027: {"},{"line_number":317,"context_line":"                    \u0027href\u0027: ("},{"line_number":318,"context_line":"                        \u0027/vnflcmv1/vnf_lcm_op_occs/%s\u0027 % vnf_lcm_op_occs_id)}}}"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        # call sendNotification"},{"line_number":321,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ded6714f","line":318,"range":{"start_line":318,"start_character":25,"end_line":318,"end_character":35},"updated":"2020-08-26 02:32:10.000000000","message":"Typo: /vnflcm/v1/","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                    \u0027href\u0027: \u0027/vnflcm/v1/vnf_instances/%s\u0027 % vnf_instance.id},"},{"line_number":316,"context_line":"                \u0027vnfLcmOpOcc\u0027: {"},{"line_number":317,"context_line":"                    \u0027href\u0027: ("},{"line_number":318,"context_line":"                        \u0027/vnflcmv1/vnf_lcm_op_occs/%s\u0027 % vnf_lcm_op_occs_id)}}}"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        # call sendNotification"},{"line_number":321,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4efec06b","line":318,"range":{"start_line":318,"start_character":25,"end_line":318,"end_character":35},"in_reply_to":"9f560f44_ded6714f","updated":"2020-09-02 14:16:14.000000000","message":"Fixed the typo","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9d5874a6cfc01cef69e415b9d2d791fe2beb4c0e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    If the vnf is in the wrong state, it will raise conflict exception."},{"line_number":94,"context_line":"    \"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    if status is not None and not \\"},{"line_number":97,"context_line":"            isinstance(status, set):"},{"line_number":98,"context_line":"        status \u003d set(status)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f8c1df81","line":96,"updated":"2020-09-10 16:57:26.000000000","message":"This two lines can ben combined with one.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b89d74b90bb7a87f3459743cf4001495e6ac7f96","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    If the vnf is in the wrong state, it will raise conflict exception."},{"line_number":94,"context_line":"    \"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    if status is not None and not \\"},{"line_number":97,"context_line":"            isinstance(status, set):"},{"line_number":98,"context_line":"        status \u003d set(status)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_9c4717a4","line":96,"in_reply_to":"9f560f44_f8c1df81","updated":"2020-09-22 09:56:29.000000000","message":"Lines are combined into one line.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9d5874a6cfc01cef69e415b9d2d791fe2beb4c0e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        status \u003d set(status)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def outer(f):"},{"line_number":101,"context_line":"        @six.wraps(f)"},{"line_number":102,"context_line":"        def inner(self, context, vnf_instance, vnf, *args, **kw):"},{"line_number":103,"context_line":"            if status is not None and \\"},{"line_number":104,"context_line":"                    vnf[\u0027status\u0027] not in \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_38beb7ad","line":101,"updated":"2020-09-10 16:57:26.000000000","message":"It\u0027s better to use `functools.wraps` because we don\u0027t support py2 anymore.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b89d74b90bb7a87f3459743cf4001495e6ac7f96","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        status \u003d set(status)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def outer(f):"},{"line_number":101,"context_line":"        @six.wraps(f)"},{"line_number":102,"context_line":"        def inner(self, context, vnf_instance, vnf, *args, **kw):"},{"line_number":103,"context_line":"            if status is not None and \\"},{"line_number":104,"context_line":"                    vnf[\u0027status\u0027] not in \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_fcc5730b","line":101,"in_reply_to":"9f560f44_38beb7ad","updated":"2020-09-22 09:56:29.000000000","message":"used functools.wraps as suggested.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"}],"tacker/common/exceptions.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"class NotificationProcessingError(TackerException):"},{"line_number":326,"context_line":"    message \u003d _(\"Notification Processing Failed\")"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"class UserDataUpdateCreateFailed(TackerException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_05b8e373","line":326,"updated":"2020-08-20 05:51:45.000000000","message":"tacker/conductor/conductor_server.py\nWhen I look at above code, it looks like I\u0027m expecting to pass the cause of the error in the message, but it can\u0027t work properly now.\nI think it needs to be modified as follows.\n_(\"Notification Processing Failed: %(error)\")\nI think it\u0027s better to use \u0027error\u0027 rather than \u0027message\u0027, consistent with existing code.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"class NotificationProcessingError(TackerException):"},{"line_number":326,"context_line":"    message \u003d _(\"Notification Processing Failed\")"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"class UserDataUpdateCreateFailed(TackerException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ae431caf","line":326,"in_reply_to":"9f560f44_05b8e373","updated":"2020-09-02 14:16:14.000000000","message":"Modified as follows:\n\nclass NotificationProcessingError(TackerException):\n    message \u003d _(\"Notification Processing Failed: %(error)s\")","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        or isinstance(exp, exceptions.VNFPackageURLInvalid)):"},{"line_number":127,"context_line":"                    # Delete the csar file from the glance store."},{"line_number":128,"context_line":"                    glance_store.delete_csar(context, vnf_package.id,"},{"line_number":129,"context_line":"                                             vnf_package.location_glance_store)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"                    csar_utils.delete_csar_data(vnf_package.id)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_455f7b40","line":129,"updated":"2020-08-20 05:51:45.000000000","message":"Do you need to add this indent?","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        or isinstance(exp, exceptions.VNFPackageURLInvalid)):"},{"line_number":127,"context_line":"                    # Delete the csar file from the glance store."},{"line_number":128,"context_line":"                    glance_store.delete_csar(context, vnf_package.id,"},{"line_number":129,"context_line":"                                             vnf_package.location_glance_store)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"                    csar_utils.delete_csar_data(vnf_package.id)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8e6a9818","line":129,"in_reply_to":"9f560f44_455f7b40","updated":"2020-09-02 14:16:14.000000000","message":"I think this is necessary because this is a fix to pep8 issue regarding multi-line.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            for file in imported_yamls:"},{"line_number":349,"context_line":"                file_path \u003d os.path.join("},{"line_number":350,"context_line":"                    csar_path, dir_of_parent_definition_file, file)"},{"line_number":351,"context_line":"                file_data \u003d yaml.safe_load(io.open(file_path))"},{"line_number":352,"context_line":"                dest_file_path \u003d os.path.abspath(file_path).split("},{"line_number":353,"context_line":"                    csar_path + \u0027/\u0027)[-1]"},{"line_number":354,"context_line":"                file_path_and_data[dest_file_path] \u003d yaml.dump(file_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c519cb88","line":351,"updated":"2020-08-20 05:51:45.000000000","message":"I think this modification isn\u0027t necessary because it is not io.closed.\nIs there any reason why it is necessary?\nSame for other parts.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            for file in imported_yamls:"},{"line_number":349,"context_line":"                file_path \u003d os.path.join("},{"line_number":350,"context_line":"                    csar_path, dir_of_parent_definition_file, file)"},{"line_number":351,"context_line":"                file_data \u003d yaml.safe_load(io.open(file_path))"},{"line_number":352,"context_line":"                dest_file_path \u003d os.path.abspath(file_path).split("},{"line_number":353,"context_line":"                    csar_path + \u0027/\u0027)[-1]"},{"line_number":354,"context_line":"                file_path_and_data[dest_file_path] \u003d yaml.dump(file_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_31d48dbd","line":351,"in_reply_to":"9f560f44_c519cb88","updated":"2020-09-02 14:16:14.000000000","message":"You are correct. We reverted this back to the original line. Other lines as well (369-370, 385-386)","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        return file_path_and_data"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    @log.log"},{"line_number":390,"context_line":"    def _get_vnf_notif(self, context, id):"},{"line_number":391,"context_line":"        # check if id is of type uuid format"},{"line_number":392,"context_line":"        if not uuidutils.is_uuid_like(id):"},{"line_number":393,"context_line":"            error_msg \u003d _(\"Can not find requested vnf instance: %s\") % id"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0514634d","line":390,"updated":"2020-08-20 05:51:45.000000000","message":"typo: _get_vnf_notify","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        return file_path_and_data"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    @log.log"},{"line_number":390,"context_line":"    def _get_vnf_notif(self, context, id):"},{"line_number":391,"context_line":"        # check if id is of type uuid format"},{"line_number":392,"context_line":"        if not uuidutils.is_uuid_like(id):"},{"line_number":393,"context_line":"            error_msg \u003d _(\"Can not find requested vnf instance: %s\") % id"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d1fb9144","line":390,"in_reply_to":"9f560f44_0514634d","updated":"2020-09-02 14:16:14.000000000","message":"updated method name from _get_vnf_notif -\u003e _get_vnf_notify","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    @log.log"},{"line_number":390,"context_line":"    def _get_vnf_notif(self, context, id):"},{"line_number":391,"context_line":"        # check if id is of type uuid format"},{"line_number":392,"context_line":"        if not uuidutils.is_uuid_like(id):"},{"line_number":393,"context_line":"            error_msg \u003d _(\"Can not find requested vnf instance: %s\") % id"},{"line_number":394,"context_line":"            raise exceptions.NotificationProcessingError(message\u003derror_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1ce947b6","line":391,"updated":"2020-08-21 07:20:13.000000000","message":"I think this check is not necessary.\nBecause this id is generated by uuidutils.generate_uuid.\nIs it right?","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    @log.log"},{"line_number":390,"context_line":"    def _get_vnf_notif(self, context, id):"},{"line_number":391,"context_line":"        # check if id is of type uuid format"},{"line_number":392,"context_line":"        if not uuidutils.is_uuid_like(id):"},{"line_number":393,"context_line":"            error_msg \u003d _(\"Can not find requested vnf instance: %s\") % id"},{"line_number":394,"context_line":"            raise exceptions.NotificationProcessingError(message\u003derror_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b18d3dd5","line":391,"in_reply_to":"9f560f44_1ce947b6","updated":"2020-09-02 14:16:14.000000000","message":"That is right.The checking is removed.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        # check if id is of type uuid format"},{"line_number":392,"context_line":"        if not uuidutils.is_uuid_like(id):"},{"line_number":393,"context_line":"            error_msg \u003d _(\"Can not find requested vnf instance: %s\") % id"},{"line_number":394,"context_line":"            raise exceptions.NotificationProcessingError(message\u003derror_msg)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        try:"},{"line_number":397,"context_line":"            vnf_notif \u003d objects.VnfLcmOpOcc.get_by_id(context, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_45765bda","line":394,"updated":"2020-08-20 05:51:45.000000000","message":"I think it\u0027s better to modify as follows.\nexceptions.NotificationProcessingError(error\u003derror_msg)","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        # check if id is of type uuid format"},{"line_number":392,"context_line":"        if not uuidutils.is_uuid_like(id):"},{"line_number":393,"context_line":"            error_msg \u003d _(\"Can not find requested vnf instance: %s\") % id"},{"line_number":394,"context_line":"            raise exceptions.NotificationProcessingError(message\u003derror_msg)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        try:"},{"line_number":397,"context_line":"            vnf_notif \u003d objects.VnfLcmOpOcc.get_by_id(context, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b1a6dd52","line":394,"in_reply_to":"9f560f44_45765bda","updated":"2020-09-02 14:16:14.000000000","message":"Modified as suggested.\nexceptions.NotificationProcessingError(error\u003derror_msg)","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        return vnf_notif"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    @log.log"},{"line_number":408,"context_line":"    def _send_insta_op_occ_notification("},{"line_number":409,"context_line":"            self,"},{"line_number":410,"context_line":"            context,"},{"line_number":411,"context_line":"            vnf_lcm_op_occs_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8d7b758a","line":408,"updated":"2020-08-21 07:20:13.000000000","message":"Since there are many logics similar to _send_terminate_op_occ_notification and _send_heal_op_occ_notification, can it be commonize?","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        return vnf_notif"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    @log.log"},{"line_number":408,"context_line":"    def _send_insta_op_occ_notification("},{"line_number":409,"context_line":"            self,"},{"line_number":410,"context_line":"            context,"},{"line_number":411,"context_line":"            vnf_lcm_op_occs_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b1541d23","line":408,"in_reply_to":"9f560f44_8d7b758a","updated":"2020-09-02 14:16:14.000000000","message":"commonized the _send_XXX method by creating a common method: _send_lcm_op_occ_notification()","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            operation_state\u003dfields.LcmOccsOperationState.PROCESSING,"},{"line_number":414,"context_line":"            error\u003dNone):"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        error_point \u003d 1"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        try:"},{"line_number":419,"context_line":"            # self.update_vnf_lcm_op(context, vnf_lcm_op_occs_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7cb20396","line":416,"updated":"2020-08-21 07:20:13.000000000","message":"Please clarify what error_point is.\nIf this file is not appropriate, you can define another file.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            operation_state\u003dfields.LcmOccsOperationState.PROCESSING,"},{"line_number":414,"context_line":"            error\u003dNone):"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        error_point \u003d 1"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        try:"},{"line_number":419,"context_line":"            # self.update_vnf_lcm_op(context, vnf_lcm_op_occs_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_112fc9a7","line":416,"in_reply_to":"9f560f44_7cb20396","updated":"2020-09-02 14:16:14.000000000","message":"Removed \"error_point\" since this is part of the Rollback Patch.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        error_point \u003d 1"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        try:"},{"line_number":419,"context_line":"            # self.update_vnf_lcm_op(context, vnf_lcm_op_occs_id,"},{"line_number":420,"context_line":"            # operation_state)"},{"line_number":421,"context_line":"            LOG.debug("},{"line_number":422,"context_line":"                \"Update vnf lcm %s %s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9ca5574a","line":419,"updated":"2020-08-21 07:20:13.000000000","message":"I think it\u0027s unnecessary comment out.\nPlease check other parts.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        error_point \u003d 1"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        try:"},{"line_number":419,"context_line":"            # self.update_vnf_lcm_op(context, vnf_lcm_op_occs_id,"},{"line_number":420,"context_line":"            # operation_state)"},{"line_number":421,"context_line":"            LOG.debug("},{"line_number":422,"context_line":"                \"Update vnf lcm %s %s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_11186982","line":419,"in_reply_to":"9f560f44_9ca5574a","updated":"2020-09-02 14:16:14.000000000","message":"removed all the unnecessary comment outs.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            vnf_notif.operation_state \u003d operation_state"},{"line_number":427,"context_line":"            if operation_state \u003d\u003d fields.LcmOccsOperationState.PROCESSING:"},{"line_number":428,"context_line":"                vnf_notif.error_point \u003d error_point"},{"line_number":429,"context_line":"            if operation_state \u003d\u003d fields.LcmOccsOperationState.FAILED_TEMP:"},{"line_number":430,"context_line":"                error_details \u003d objects.ProblemDetails("},{"line_number":431,"context_line":"                    context\u003dcontext,"},{"line_number":432,"context_line":"                    status\u003d500,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5c745fcf","line":429,"updated":"2020-08-21 07:20:13.000000000","message":"elif is better.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            vnf_notif.operation_state \u003d operation_state"},{"line_number":427,"context_line":"            if operation_state \u003d\u003d fields.LcmOccsOperationState.PROCESSING:"},{"line_number":428,"context_line":"                vnf_notif.error_point \u003d error_point"},{"line_number":429,"context_line":"            if operation_state \u003d\u003d fields.LcmOccsOperationState.FAILED_TEMP:"},{"line_number":430,"context_line":"                error_details \u003d objects.ProblemDetails("},{"line_number":431,"context_line":"                    context\u003dcontext,"},{"line_number":432,"context_line":"                    status\u003d500,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_240c4d3a","line":429,"in_reply_to":"9f560f44_5c745fcf","updated":"2020-09-02 14:16:14.000000000","message":"modified if to elif.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":467,"context_line":"                affected_resources \u003d vnflcm_utils._get_affected_resources("},{"line_number":468,"context_line":"                    old_vnf_instance\u003dNone, new_vnf_instance\u003dvnf_instance)"},{"line_number":469,"context_line":"                vnf_notif \u003d self._get_vnf_notif(context, vnf_lcm_op_occs_id)"},{"line_number":470,"context_line":"                snakeCase \u003d utils.convert_camelcase_to_snakecase("},{"line_number":471,"context_line":"                    affected_resources)"},{"line_number":472,"context_line":"                resourceChangeObj \u003d jsonutils.dumps(snakeCase)"},{"line_number":473,"context_line":"                resourceChange \u003d objects.ResourceChanges.obj_from_primitive("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ffd2855b","line":470,"updated":"2020-08-21 07:20:13.000000000","message":"Please fix variable name from camelCase to snake_case.\nSame for others.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":467,"context_line":"                affected_resources \u003d vnflcm_utils._get_affected_resources("},{"line_number":468,"context_line":"                    old_vnf_instance\u003dNone, new_vnf_instance\u003dvnf_instance)"},{"line_number":469,"context_line":"                vnf_notif \u003d self._get_vnf_notif(context, vnf_lcm_op_occs_id)"},{"line_number":470,"context_line":"                snakeCase \u003d utils.convert_camelcase_to_snakecase("},{"line_number":471,"context_line":"                    affected_resources)"},{"line_number":472,"context_line":"                resourceChangeObj \u003d jsonutils.dumps(snakeCase)"},{"line_number":473,"context_line":"                resourceChange \u003d objects.ResourceChanges.obj_from_primitive("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_445501fa","line":470,"in_reply_to":"9f560f44_ffd2855b","updated":"2020-09-02 14:16:14.000000000","message":"fixed the the variable name from camelCase to snake_case.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":486,"context_line":"                if operation_state \u003d\u003d fields.LcmOccsOperationState.FAILED_TEMP:"},{"line_number":487,"context_line":"                    notification_data[\u0027error\u0027] \u003d error"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"            # send notification"},{"line_number":490,"context_line":"            self.sendNotification(context, notification_data)"},{"line_number":491,"context_line":"        except Exception as ex:"},{"line_number":492,"context_line":"            LOG.error("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_804a2152","line":489,"updated":"2020-08-20 05:51:45.000000000","message":"Since the same logic is defined in multiple places, can you cut out as a method and made common?","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":486,"context_line":"                if operation_state \u003d\u003d fields.LcmOccsOperationState.FAILED_TEMP:"},{"line_number":487,"context_line":"                    notification_data[\u0027error\u0027] \u003d error"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"            # send notification"},{"line_number":490,"context_line":"            self.sendNotification(context, notification_data)"},{"line_number":491,"context_line":"        except Exception as ex:"},{"line_number":492,"context_line":"            LOG.error("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_446ea1c9","line":489,"in_reply_to":"9f560f44_804a2152","updated":"2020-09-02 14:16:14.000000000","message":"commonized the _send_XXX method by creating a common method: _send_lcm_op_occ_notification()","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":570,"context_line":"                fields.LcmOccsOperationState.COMPLETED)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        except Exception as ex:"},{"line_number":573,"context_line":"            # do abnormal processing here"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"            # send notification \u0027FAILED_TEMP\u0027 with error details"},{"line_number":576,"context_line":"            self._send_insta_op_occ_notification("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_007e116a","line":573,"updated":"2020-08-20 05:51:45.000000000","message":"I think this is an unnecessary comment.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":570,"context_line":"                fields.LcmOccsOperationState.COMPLETED)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        except Exception as ex:"},{"line_number":573,"context_line":"            # do abnormal processing here"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"            # send notification \u0027FAILED_TEMP\u0027 with error details"},{"line_number":576,"context_line":"            self._send_insta_op_occ_notification("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_049949cf","line":573,"in_reply_to":"9f560f44_007e116a","updated":"2020-09-02 14:16:14.000000000","message":"removed all unnecessary comment outs.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            vnf_package.usage_state \u003d fields.PackageUsageStateType.NOT_IN_USE"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        vnf_package.save()"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    @log.log"},{"line_number":600,"context_line":"    def _send_terminate_op_occ_notification("},{"line_number":601,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7c7e8319","line":598,"updated":"2020-08-21 07:20:13.000000000","message":"Since the difference is difficult to check, can you change the method definition order as follows?\n ~~snip~~\n def _send_insta_op_occ_notification\n def _send_terminate_op_occ_notification\n def _send_heal_op_occ_notification\n def _run_cleanup_vnf_packages\n def instantiate\n ~~snip~~","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e71b5fc303e8ae21626b4c07383c2e540651ed6a","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            vnf_package.usage_state \u003d fields.PackageUsageStateType.NOT_IN_USE"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        vnf_package.save()"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    @log.log"},{"line_number":600,"context_line":"    def _send_terminate_op_occ_notification("},{"line_number":601,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_79deacda","line":598,"in_reply_to":"9f560f44_447ce171","updated":"2020-09-04 14:37:10.000000000","message":"def send_notification is also move before \"def instantiate\"","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            vnf_package.usage_state \u003d fields.PackageUsageStateType.NOT_IN_USE"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        vnf_package.save()"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    @log.log"},{"line_number":600,"context_line":"    def _send_terminate_op_occ_notification("},{"line_number":601,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_447ce171","line":598,"in_reply_to":"9f560f44_7c7e8319","updated":"2020-09-02 14:16:14.000000000","message":"1. transformed the _send_XXX method to common _send_lcm_op_occ_notification()\n2. _run_cleanup_vnf_packages() and update_package_usage_state was move on top before the \n_send_lcm_op_occ_notification","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        try:"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"            old_vnf_instance \u003d None"},{"line_number":721,"context_line":"            # send notification: STARTING"},{"line_number":722,"context_line":"            self._send_terminate_op_occ_notification("},{"line_number":723,"context_line":"                context,"},{"line_number":724,"context_line":"                vnfLcmOpOccId,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9f6709b8","line":721,"updated":"2020-08-21 07:20:13.000000000","message":"I think the notification for operation_state:STARTING should be handled by controller.py, not conductor_server.py.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        try:"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"            old_vnf_instance \u003d None"},{"line_number":721,"context_line":"            # send notification: STARTING"},{"line_number":722,"context_line":"            self._send_terminate_op_occ_notification("},{"line_number":723,"context_line":"                context,"},{"line_number":724,"context_line":"                vnfLcmOpOccId,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_64676553","line":721,"in_reply_to":"9f560f44_9f6709b8","updated":"2020-09-02 14:16:14.000000000","message":"operation_state:STARTING is transferred to controller.py","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":933,"context_line":"                                                fields.LcmOccsOperationState."},{"line_number":934,"context_line":"                                                FAILED_TEMP, str(ex))"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"    def sendNotification(self, context, notification):"},{"line_number":937,"context_line":"        try:"},{"line_number":938,"context_line":"            LOG.debug(\"sendNotification start notification[%s]\" % notification)"},{"line_number":939,"context_line":"            if (notification.get(\u0027notificationType\u0027) \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_65027f0d","line":936,"updated":"2020-08-20 05:51:45.000000000","message":"Please fix from camelCase to snake_case.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":933,"context_line":"                                                fields.LcmOccsOperationState."},{"line_number":934,"context_line":"                                                FAILED_TEMP, str(ex))"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"    def sendNotification(self, context, notification):"},{"line_number":937,"context_line":"        try:"},{"line_number":938,"context_line":"            LOG.debug(\"sendNotification start notification[%s]\" % notification)"},{"line_number":939,"context_line":"            if (notification.get(\u0027notificationType\u0027) \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_04c5c90a","line":936,"in_reply_to":"9f560f44_65027f0d","updated":"2020-09-02 14:16:14.000000000","message":"Modified sendNotification -\u003e send_notification","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":977,"context_line":"                notification[\u0027timeStamp\u0027] \u003d datetime.datetime.utcnow("},{"line_number":978,"context_line":"                ).isoformat()"},{"line_number":979,"context_line":"                try:"},{"line_number":980,"context_line":"                    for num in range(CONF.vnf_lcm.retry_num):"},{"line_number":981,"context_line":"                        LOG.info(\"send notify[%s]\" % json.dumps(notification))"},{"line_number":982,"context_line":"                        response \u003d requests.post("},{"line_number":983,"context_line":"                            line.callback_uri.decode(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c2736a15","line":980,"updated":"2020-08-21 07:20:13.000000000","message":"I think it\u0027s better to output a warn log when the number of retries is exceeded.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e71b5fc303e8ae21626b4c07383c2e540651ed6a","unresolved":false,"context_lines":[{"line_number":977,"context_line":"                notification[\u0027timeStamp\u0027] \u003d datetime.datetime.utcnow("},{"line_number":978,"context_line":"                ).isoformat()"},{"line_number":979,"context_line":"                try:"},{"line_number":980,"context_line":"                    for num in range(CONF.vnf_lcm.retry_num):"},{"line_number":981,"context_line":"                        LOG.info(\"send notify[%s]\" % json.dumps(notification))"},{"line_number":982,"context_line":"                        response \u003d requests.post("},{"line_number":983,"context_line":"                            line.callback_uri.decode(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_79a50c47","line":980,"in_reply_to":"9f560f44_04930902","updated":"2020-09-04 14:37:10.000000000","message":"changed info to warn.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":977,"context_line":"                notification[\u0027timeStamp\u0027] \u003d datetime.datetime.utcnow("},{"line_number":978,"context_line":"                ).isoformat()"},{"line_number":979,"context_line":"                try:"},{"line_number":980,"context_line":"                    for num in range(CONF.vnf_lcm.retry_num):"},{"line_number":981,"context_line":"                        LOG.info(\"send notify[%s]\" % json.dumps(notification))"},{"line_number":982,"context_line":"                        response \u003d requests.post("},{"line_number":983,"context_line":"                            line.callback_uri.decode(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_04930902","line":980,"in_reply_to":"9f560f44_c2736a15","updated":"2020-09-02 14:16:14.000000000","message":"added the following line to notify exceed:\nif num \u003d\u003d CONF.vnf_lcm.retry_num:\n                                LOG.warn(\"Number of retries exceeded retry count\")","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"        except Exception as e:"},{"line_number":1009,"context_line":"            LOG.warn(\"Internal Sever Error[%s]\" % str(e))"},{"line_number":1010,"context_line":"            LOG.warn(traceback.format_exc())"},{"line_number":1011,"context_line":"            return 99"},{"line_number":1012,"context_line":"        return 0"},{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_221066a8","line":1011,"updated":"2020-08-21 07:20:13.000000000","message":"I think it\u0027s bettter to retrun -2.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"        except Exception as e:"},{"line_number":1009,"context_line":"            LOG.warn(\"Internal Sever Error[%s]\" % str(e))"},{"line_number":1010,"context_line":"            LOG.warn(traceback.format_exc())"},{"line_number":1011,"context_line":"            return 99"},{"line_number":1012,"context_line":"        return 0"},{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8486f9b9","line":1011,"in_reply_to":"9f560f44_221066a8","updated":"2020-09-02 14:16:14.000000000","message":"modied return from 99 to -2","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"}],"tacker/conductor/conductorrpc/vnf_lcm_rpc.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cctxt \u003d client.prepare()"},{"line_number":56,"context_line":"        rpc_method \u003d cctxt.cast if cast else cctxt.call"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # create vnfLcmOpOccId"},{"line_number":59,"context_line":"        # moved call creation for vnf lcm op occ"},{"line_number":60,"context_line":"        # here to adhere to etsi sol-003"},{"line_number":61,"context_line":"        vnfLcmOpOccId \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e2c30eec","line":58,"updated":"2020-08-21 07:20:13.000000000","message":"I couldn\u0027t understand why terminate was special.\nPlease tell me.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cctxt \u003d client.prepare()"},{"line_number":56,"context_line":"        rpc_method \u003d cctxt.cast if cast else cctxt.call"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # create vnfLcmOpOccId"},{"line_number":59,"context_line":"        # moved call creation for vnf lcm op occ"},{"line_number":60,"context_line":"        # here to adhere to etsi sol-003"},{"line_number":61,"context_line":"        vnfLcmOpOccId \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e74ff767","line":58,"in_reply_to":"9f560f44_e2c30eec","updated":"2020-09-02 14:16:14.000000000","message":"Apparently, this is some implementation miss. \u0027terminate\u0027 is not special, and notification processing will be transferred to controller instead.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            self.vnf_op_occ(method\u003d\"create\", op_dict\u003dcreation_dict)"},{"line_number":76,"context_line":"        except(Exception) as exc:"},{"line_number":77,"context_line":"            raise webob.exc.HTTPInternalServerError("},{"line_number":78,"context_line":"                explanation\u003dsix.text_type(exc))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        return rpc_method(context, \u0027terminate\u0027,"},{"line_number":81,"context_line":"                          vnfLcmOpOccId\u003dvnfLcmOpOccId,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0263a243","line":78,"updated":"2020-08-21 07:20:13.000000000","message":"I think you need not to use the \u0027six\u0027 library because Python2 support is not needed.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            self.vnf_op_occ(method\u003d\"create\", op_dict\u003dcreation_dict)"},{"line_number":76,"context_line":"        except(Exception) as exc:"},{"line_number":77,"context_line":"            raise webob.exc.HTTPInternalServerError("},{"line_number":78,"context_line":"                explanation\u003dsix.text_type(exc))"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        return rpc_method(context, \u0027terminate\u0027,"},{"line_number":81,"context_line":"                          vnfLcmOpOccId\u003dvnfLcmOpOccId,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4720639c","line":78,"in_reply_to":"9f560f44_0263a243","updated":"2020-09-02 14:16:14.000000000","message":"This processing will be removed since not needed and notification processing will be transferred to controller instead.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                          heal_vnf_request\u003dheal_vnf_request,"},{"line_number":98,"context_line":"                          vnf_lcm_op_occs_id\u003dvnf_lcm_op_occs_id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def sendNotification(self, context, notification, cast\u003dTrue):"},{"line_number":101,"context_line":"        serializer \u003d objects_base.TackerObjectSerializer()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        client \u003d rpc.get_client(self.target, version_cap\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c0e89917","line":100,"updated":"2020-08-20 05:51:45.000000000","message":"Please fix from camelCase to snake_case.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                          heal_vnf_request\u003dheal_vnf_request,"},{"line_number":98,"context_line":"                          vnf_lcm_op_occs_id\u003dvnf_lcm_op_occs_id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def sendNotification(self, context, notification, cast\u003dTrue):"},{"line_number":101,"context_line":"        serializer \u003d objects_base.TackerObjectSerializer()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        client \u003d rpc.get_client(self.target, version_cap\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c733d3f5","line":100,"in_reply_to":"9f560f44_c0e89917","updated":"2020-09-02 14:16:14.000000000","message":"Changed sendNotification -\u003e send_notification","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"}],"tacker/db/db_sqlalchemy/models.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    operation_types_len \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"class VnfLcmOpOccs(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":258,"context_line":"                models.TimestampMixin, models_v1.HasId):"},{"line_number":259,"context_line":"    \"\"\"Represents a Vnf Instance.\"\"\""},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_60eb8ddb","line":257,"updated":"2020-08-20 05:51:45.000000000","message":"I think you should modify this file by updating the 745428 patchset.\nIs there any reason to fix in this patch?","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    operation_types_len \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"class VnfLcmOpOccs(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":258,"context_line":"                models.TimestampMixin, models_v1.HasId):"},{"line_number":259,"context_line":"    \"\"\"Represents a Vnf Instance.\"\"\""},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_07b66bdd","line":257,"in_reply_to":"9f560f44_60eb8ddb","updated":"2020-09-02 14:16:14.000000000","message":"Pach set 745428 (Subscription) will be modified and Notification will be rebased.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"d771c8a0b0fd62279e237832d577d5786d365ed8","unresolved":false,"context_lines":[{"line_number":257,"context_line":"class VnfLcmOpOccs(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":258,"context_line":"                models.TimestampMixin, models_v1.HasId):"},{"line_number":259,"context_line":"    \"\"\"Represents a Vnf Instance.\"\"\""},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    __tablename__ \u003d \u0027vnf_lcm_op_occs\u0027"},{"line_number":262,"context_line":"    operation_state \u003d sa.Column(sa.String(16), nullable\u003dFalse)"},{"line_number":263,"context_line":"    state_entered_time \u003d sa.Column(DateTime, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_963b309a","line":260,"updated":"2020-08-26 02:32:10.000000000","message":"Is \"id\" (Identifier of the VNF lifecycle management operation occurrence) missed for this table?","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":257,"context_line":"class VnfLcmOpOccs(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":258,"context_line":"                models.TimestampMixin, models_v1.HasId):"},{"line_number":259,"context_line":"    \"\"\"Represents a Vnf Instance.\"\"\""},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    __tablename__ \u003d \u0027vnf_lcm_op_occs\u0027"},{"line_number":262,"context_line":"    operation_state \u003d sa.Column(sa.String(16), nullable\u003dFalse)"},{"line_number":263,"context_line":"    state_entered_time \u003d sa.Column(DateTime, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_47b063de","line":260,"in_reply_to":"9f560f44_963b309a","updated":"2020-09-02 14:16:14.000000000","message":"Already modified in Subscription. Notification will be rebased.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"d771c8a0b0fd62279e237832d577d5786d365ed8","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    state_entered_time \u003d sa.Column(DateTime, nullable\u003dFalse)"},{"line_number":264,"context_line":"    start_time \u003d sa.Column(DateTime, nullable\u003dFalse)"},{"line_number":265,"context_line":"    vnf_instance_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":266,"context_line":"    grant_id \u003d sa.Column(sa.String(36), nullable\u003dTrue)"},{"line_number":267,"context_line":"    operation \u003d sa.Column(sa.String(16), nullable\u003dFalse)"},{"line_number":268,"context_line":"    is_automatic_invocation \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":269,"context_line":"    operation_params \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f6c9ccab","line":266,"range":{"start_line":266,"start_character":3,"end_line":266,"end_character":12},"updated":"2020-08-26 02:32:10.000000000","message":"This column is not needed because this attribute is not supported in victoria release.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    state_entered_time \u003d sa.Column(DateTime, nullable\u003dFalse)"},{"line_number":264,"context_line":"    start_time \u003d sa.Column(DateTime, nullable\u003dFalse)"},{"line_number":265,"context_line":"    vnf_instance_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":266,"context_line":"    grant_id \u003d sa.Column(sa.String(36), nullable\u003dTrue)"},{"line_number":267,"context_line":"    operation \u003d sa.Column(sa.String(16), nullable\u003dFalse)"},{"line_number":268,"context_line":"    is_automatic_invocation \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":269,"context_line":"    operation_params \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_27b56fce","line":266,"range":{"start_line":266,"start_character":3,"end_line":266,"end_character":12},"in_reply_to":"9f560f44_f6c9ccab","updated":"2020-09-02 14:16:14.000000000","message":"Already modified in Subscription. Notification will be rebased.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"d771c8a0b0fd62279e237832d577d5786d365ed8","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    is_automatic_invocation \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":269,"context_line":"    operation_params \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":270,"context_line":"    is_cancel_pending \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":271,"context_line":"    cancel_mode \u003d sa.Column(sa.String(16), nullable\u003dTrue)"},{"line_number":272,"context_line":"    error \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":273,"context_line":"    resource_changes \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":274,"context_line":"    changed_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d6cc88bc","line":271,"range":{"start_line":271,"start_character":4,"end_line":271,"end_character":15},"updated":"2020-08-26 02:32:10.000000000","message":"This column is not needed because this attribute is not supported in victoria release.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    is_automatic_invocation \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":269,"context_line":"    operation_params \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":270,"context_line":"    is_cancel_pending \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":271,"context_line":"    cancel_mode \u003d sa.Column(sa.String(16), nullable\u003dTrue)"},{"line_number":272,"context_line":"    error \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":273,"context_line":"    resource_changes \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":274,"context_line":"    changed_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_87c9db5b","line":271,"range":{"start_line":271,"start_character":4,"end_line":271,"end_character":15},"in_reply_to":"9f560f44_d6cc88bc","updated":"2020-09-02 14:16:14.000000000","message":"Already modified in Subscription. Notification will be rebased.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"d771c8a0b0fd62279e237832d577d5786d365ed8","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    error \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":273,"context_line":"    resource_changes \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":274,"context_line":"    changed_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":275,"context_line":"    changed_ext_connectivity \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":276,"context_line":"    error_point \u003d sa.Column(sa.Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_36c7c498","line":275,"range":{"start_line":275,"start_character":4,"end_line":275,"end_character":28},"updated":"2020-08-26 02:32:10.000000000","message":"This column is not needed because this attribute is not supported in victoria release.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    error \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":273,"context_line":"    resource_changes \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":274,"context_line":"    changed_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":275,"context_line":"    changed_ext_connectivity \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":276,"context_line":"    error_point \u003d sa.Column(sa.Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_67c6474c","line":275,"range":{"start_line":275,"start_character":4,"end_line":275,"end_character":28},"in_reply_to":"9f560f44_36c7c498","updated":"2020-09-02 14:16:14.000000000","message":"Already modified in Subscription. Notification will be rebased.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"}],"tacker/db/migration/alembic_migrations/versions/985e28392890_add_vnflcm_db.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                                [\u0027vnf_lcm_subscriptions.id\u0027], ),"},{"line_number":150,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":151,"context_line":"    )"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    op.create_table("},{"line_number":154,"context_line":"        \u0027vnf_lcm_op_occs\u0027,"},{"line_number":155,"context_line":"        sa.Column(\u0027id\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0500e366","line":152,"updated":"2020-08-20 05:51:45.000000000","message":"Please check that the job of tacker-functional-devstack-multinode-python3 is RETRY_LIMIT due to this file.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                                [\u0027vnf_lcm_subscriptions.id\u0027], ),"},{"line_number":150,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":151,"context_line":"    )"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    op.create_table("},{"line_number":154,"context_line":"        \u0027vnf_lcm_op_occs\u0027,"},{"line_number":155,"context_line":"        sa.Column(\u0027id\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e2366e03","line":152,"in_reply_to":"9f560f44_0500e366","updated":"2020-08-21 07:20:13.000000000","message":"IMO, when updating the DB schema, you need to create a new script instead of updating the existing DB migration script.\nI think the script can be generated automatically.\nPlease refer to the following documents.\nhttps://docs.openstack.org/neutron/latest/contributor/alembic_migrations.html","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                                [\u0027vnf_lcm_subscriptions.id\u0027], ),"},{"line_number":150,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":151,"context_line":"    )"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    op.create_table("},{"line_number":154,"context_line":"        \u0027vnf_lcm_op_occs\u0027,"},{"line_number":155,"context_line":"        sa.Column(\u0027id\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e7dff709","line":152,"in_reply_to":"9f560f44_0500e366","updated":"2020-09-02 14:16:14.000000000","message":"The RETRY_LIMIT response is primarily due to :\n  File \"/opt/stack/tacker/tacker/db/migration/alembic_migrations/versions/985e28392890_add_vnflcm_db.py\", line 129, in upgrade\n    sa.Column(\u0027vnf_products_from_providers\u0027,sa.text, server_default\u003dNull, nullable\u003dFalse),\nNameError: name \u0027Null\u0027 is not defined\n\nHowever this is for table \u0027vnf_lcm_filters\u0027 which is not modified in this patch, I think fix must be introduce in other patch.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                                [\u0027vnf_lcm_subscriptions.id\u0027], ),"},{"line_number":150,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":151,"context_line":"    )"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    op.create_table("},{"line_number":154,"context_line":"        \u0027vnf_lcm_op_occs\u0027,"},{"line_number":155,"context_line":"        sa.Column(\u0027id\u0027, types.Uuid(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_67cbe749","line":152,"in_reply_to":"9f560f44_e2366e03","updated":"2020-09-02 14:16:14.000000000","message":"Fix: removed \u0027vnf_lcm_op_occs\u0027 from 985e28392890_add_vnflcm_db.py. It will use the file from Subscription: c47a733f425a_add_vnflcm_subscription.py","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"}],"tacker/objects/vnf_lcm_op_occs.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NTT DATA"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_62225ebb","line":1,"updated":"2020-08-21 07:20:13.000000000","message":"I think this Copyright is incorrect.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NTT DATA"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6722c703","line":1,"in_reply_to":"9f560f44_62225ebb","updated":"2020-09-02 14:16:14.000000000","message":"Removed the following line(s):\n# Copyright (C) 2020 NTT DATA\n# All Rights Reserved.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"@db_api.context_manager.writer"},{"line_number":99,"context_line":"def _vnf_notif_create(context, values):"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    vnf_lcm_op_occs \u003d models.VnfLcmOpOccs()"},{"line_number":102,"context_line":"    vnf_lcm_op_occs.update(values)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_021ba280","line":99,"updated":"2020-08-21 07:20:13.000000000","message":"typo: _vnf_notify_create\nSame for others.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"@db_api.context_manager.writer"},{"line_number":99,"context_line":"def _vnf_notif_create(context, values):"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    vnf_lcm_op_occs \u003d models.VnfLcmOpOccs()"},{"line_number":102,"context_line":"    vnf_lcm_op_occs.update(values)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a7717f0f","line":99,"in_reply_to":"9f560f44_021ba280","updated":"2020-09-02 14:16:14.000000000","message":"updated the following keywords/methods:\n\n_vnf_notify_create\n_vnf_notify_get_by_id\n_vnf_notify_update\n_destroy_vnf_notif","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9d5874a6cfc01cef69e415b9d2d791fe2beb4c0e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_15a29e9a","line":1,"updated":"2020-09-10 16:57:26.000000000","message":"No need empty line.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c48a2ca6b23f935af755cebab0493b79e9542d4f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_09a0f0f2","line":1,"in_reply_to":"9f560f44_15a29e9a","updated":"2020-09-22 01:23:01.000000000","message":"deleted blank lines","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9d5874a6cfc01cef69e415b9d2d791fe2beb4c0e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":12,"context_line":"#    under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from datetime import datetime"},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from oslo_serialization import jsonutils"},{"line_number":17,"context_line":"from oslo_utils import timeutils"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_758e7a2e","line":14,"updated":"2020-09-10 16:57:26.000000000","message":"Could you follow the coding guidelines for importing, keeping order, separating blocks or so?","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c48a2ca6b23f935af755cebab0493b79e9542d4f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":12,"context_line":"#    under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from datetime import datetime"},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from oslo_serialization import jsonutils"},{"line_number":17,"context_line":"from oslo_utils import timeutils"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_29aa14d1","line":14,"in_reply_to":"9f560f44_758e7a2e","updated":"2020-09-22 01:23:01.000000000","message":"added line break","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ecb1f425dffbbb624092248a984bc83699d2afb5","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        \u0027is_automatic_invocation\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":158,"context_line":"        \u0027operation_params\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":159,"context_line":"        \u0027is_cancel_pending\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":160,"context_line":"        \u0027cancel_mode\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":161,"context_line":"        \u0027error\u0027: fields.ObjectField("},{"line_number":162,"context_line":"            \u0027ProblemDetails\u0027, nullable\u003dTrue, default\u003dNone),"},{"line_number":163,"context_line":"        \u0027resource_changes\u0027: fields.ObjectField("}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_b12307be","line":160,"range":{"start_line":160,"start_character":9,"end_line":160,"end_character":20},"updated":"2020-09-09 07:40:17.000000000","message":"I think this \u0027cancel_mode\u0027 is an attribute not used in this development, so please delete it.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7e264f797fd501bacb39a6a1244c4d77ff7bb226","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        \u0027is_automatic_invocation\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":158,"context_line":"        \u0027operation_params\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":159,"context_line":"        \u0027is_cancel_pending\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":160,"context_line":"        \u0027cancel_mode\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":161,"context_line":"        \u0027error\u0027: fields.ObjectField("},{"line_number":162,"context_line":"            \u0027ProblemDetails\u0027, nullable\u003dTrue, default\u003dNone),"},{"line_number":163,"context_line":"        \u0027resource_changes\u0027: fields.ObjectField("}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_de542c01","line":160,"range":{"start_line":160,"start_character":9,"end_line":160,"end_character":20},"in_reply_to":"9f560f44_b12307be","updated":"2020-09-17 10:17:57.000000000","message":"Please check this comment.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c48a2ca6b23f935af755cebab0493b79e9542d4f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        \u0027is_automatic_invocation\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":158,"context_line":"        \u0027operation_params\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":159,"context_line":"        \u0027is_cancel_pending\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":160,"context_line":"        \u0027cancel_mode\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":161,"context_line":"        \u0027error\u0027: fields.ObjectField("},{"line_number":162,"context_line":"            \u0027ProblemDetails\u0027, nullable\u003dTrue, default\u003dNone),"},{"line_number":163,"context_line":"        \u0027resource_changes\u0027: fields.ObjectField("}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_268403b1","line":160,"range":{"start_line":160,"start_character":9,"end_line":160,"end_character":20},"in_reply_to":"9f560f44_de542c01","updated":"2020-09-22 01:23:01.000000000","message":"cancel_mode is removed.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ecb1f425dffbbb624092248a984bc83699d2afb5","unresolved":false,"context_lines":[{"line_number":377,"context_line":"    # Version 1.0: Initial version"},{"line_number":378,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    fields \u003d {"},{"line_number":381,"context_line":"        \u0027status\u0027: fields.IntegerField(nullable\u003dFalse),"},{"line_number":382,"context_line":"        \u0027detail\u0027: fields.StringField(nullable\u003dFalse)"},{"line_number":383,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_b154a755","line":380,"updated":"2020-09-09 07:40:17.000000000","message":"I think the attribute \u0027title\u0027 is also the target of this development.\nIs it right?","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c48a2ca6b23f935af755cebab0493b79e9542d4f","unresolved":false,"context_lines":[{"line_number":377,"context_line":"    # Version 1.0: Initial version"},{"line_number":378,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    fields \u003d {"},{"line_number":381,"context_line":"        \u0027status\u0027: fields.IntegerField(nullable\u003dFalse),"},{"line_number":382,"context_line":"        \u0027detail\u0027: fields.StringField(nullable\u003dFalse)"},{"line_number":383,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_a6c133e7","line":380,"in_reply_to":"9f560f44_9e98f4cc","updated":"2020-09-22 01:23:01.000000000","message":"added \u0027title\u0027","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7e264f797fd501bacb39a6a1244c4d77ff7bb226","unresolved":false,"context_lines":[{"line_number":377,"context_line":"    # Version 1.0: Initial version"},{"line_number":378,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    fields \u003d {"},{"line_number":381,"context_line":"        \u0027status\u0027: fields.IntegerField(nullable\u003dFalse),"},{"line_number":382,"context_line":"        \u0027detail\u0027: fields.StringField(nullable\u003dFalse)"},{"line_number":383,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_9e98f4cc","line":380,"in_reply_to":"9f560f44_b154a755","updated":"2020-09-17 10:17:57.000000000","message":"Please check this comment.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fe12e003e824dd4dfd47504467beefc347bfa7e7","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        \u0027change_type\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":422,"context_line":"        \u0027compute_resource\u0027: fields.ObjectField("},{"line_number":423,"context_line":"            \u0027ResourceHandle\u0027, nullable\u003dFalse),"},{"line_number":424,"context_line":"        \u0027metadata\u0027: fields.DictOfStringsField(nullable\u003dTrue, default\u003d{}),"},{"line_number":425,"context_line":"        \u0027affected_vnfc_cp_ids\u0027:"},{"line_number":426,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[]),"},{"line_number":427,"context_line":"        \u0027added_storage_resource_ids\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d1a4bba5","line":424,"range":{"start_line":424,"start_character":9,"end_line":424,"end_character":17},"updated":"2020-09-09 07:08:39.000000000","message":"I think this \u0027metadata\u0027 is an attribute not used in this development, so please delete it.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c48a2ca6b23f935af755cebab0493b79e9542d4f","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        \u0027change_type\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":422,"context_line":"        \u0027compute_resource\u0027: fields.ObjectField("},{"line_number":423,"context_line":"            \u0027ResourceHandle\u0027, nullable\u003dFalse),"},{"line_number":424,"context_line":"        \u0027metadata\u0027: fields.DictOfStringsField(nullable\u003dTrue, default\u003d{}),"},{"line_number":425,"context_line":"        \u0027affected_vnfc_cp_ids\u0027:"},{"line_number":426,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[]),"},{"line_number":427,"context_line":"        \u0027added_storage_resource_ids\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_06b3bf9b","line":424,"range":{"start_line":424,"start_character":9,"end_line":424,"end_character":17},"in_reply_to":"9f560f44_7e9b60c7","updated":"2020-09-22 01:23:01.000000000","message":"\u0027metadata\u0027 is removed.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7e264f797fd501bacb39a6a1244c4d77ff7bb226","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        \u0027change_type\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":422,"context_line":"        \u0027compute_resource\u0027: fields.ObjectField("},{"line_number":423,"context_line":"            \u0027ResourceHandle\u0027, nullable\u003dFalse),"},{"line_number":424,"context_line":"        \u0027metadata\u0027: fields.DictOfStringsField(nullable\u003dTrue, default\u003d{}),"},{"line_number":425,"context_line":"        \u0027affected_vnfc_cp_ids\u0027:"},{"line_number":426,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[]),"},{"line_number":427,"context_line":"        \u0027added_storage_resource_ids\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_7e9b60c7","line":424,"range":{"start_line":424,"start_character":9,"end_line":424,"end_character":17},"in_reply_to":"9f560f44_d1a4bba5","updated":"2020-09-17 10:17:57.000000000","message":"Please check this comment.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ecb1f425dffbbb624092248a984bc83699d2afb5","unresolved":false,"context_lines":[{"line_number":594,"context_line":"    # Version 1.0: Initial version"},{"line_number":595,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    fields \u003d {"},{"line_number":598,"context_line":"        \u0027vnf_instance_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":599,"context_line":"        \u0027vnf_instance_description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":600,"context_line":"        \u0027vnf_configurable_properties\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_3515223e","line":597,"updated":"2020-09-09 07:40:17.000000000","message":"I think the attributes below are also the target of this development.\nIs it right?\n* vimConnectionInfo\n* vnfPkgId","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7e264f797fd501bacb39a6a1244c4d77ff7bb226","unresolved":false,"context_lines":[{"line_number":594,"context_line":"    # Version 1.0: Initial version"},{"line_number":595,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    fields \u003d {"},{"line_number":598,"context_line":"        \u0027vnf_instance_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":599,"context_line":"        \u0027vnf_instance_description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":600,"context_line":"        \u0027vnf_configurable_properties\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_dea26cfc","line":597,"in_reply_to":"9f560f44_3515223e","updated":"2020-09-17 10:17:57.000000000","message":"Please check this comment.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c48a2ca6b23f935af755cebab0493b79e9542d4f","unresolved":false,"context_lines":[{"line_number":594,"context_line":"    # Version 1.0: Initial version"},{"line_number":595,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    fields \u003d {"},{"line_number":598,"context_line":"        \u0027vnf_instance_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":599,"context_line":"        \u0027vnf_instance_description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":600,"context_line":"        \u0027vnf_configurable_properties\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_c661c713","line":597,"in_reply_to":"9f560f44_dea26cfc","updated":"2020-09-22 01:23:01.000000000","message":"Added vimConnectionInfo and vnfPkgId","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ecb1f425dffbbb624092248a984bc83699d2afb5","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    fields \u003d {"},{"line_number":598,"context_line":"        \u0027vnf_instance_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":599,"context_line":"        \u0027vnf_instance_description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":600,"context_line":"        \u0027vnf_configurable_properties\u0027:"},{"line_number":601,"context_line":"            fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":602,"context_line":"        \u0027vnfc_info_modifications_delete_ids\u0027:"},{"line_number":603,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_51838bcb","line":600,"range":{"start_line":600,"start_character":9,"end_line":600,"end_character":36},"updated":"2020-09-09 07:40:17.000000000","message":"I think this \u0027vnf_configurable_properties\u0027 is an attribute not used in this development, so please delete it.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7e264f797fd501bacb39a6a1244c4d77ff7bb226","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    fields \u003d {"},{"line_number":598,"context_line":"        \u0027vnf_instance_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":599,"context_line":"        \u0027vnf_instance_description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":600,"context_line":"        \u0027vnf_configurable_properties\u0027:"},{"line_number":601,"context_line":"            fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":602,"context_line":"        \u0027vnfc_info_modifications_delete_ids\u0027:"},{"line_number":603,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_bea5f805","line":600,"range":{"start_line":600,"start_character":9,"end_line":600,"end_character":36},"in_reply_to":"9f560f44_51838bcb","updated":"2020-09-17 10:17:57.000000000","message":"Please check this comment.","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c48a2ca6b23f935af755cebab0493b79e9542d4f","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    fields \u003d {"},{"line_number":598,"context_line":"        \u0027vnf_instance_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":599,"context_line":"        \u0027vnf_instance_description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":600,"context_line":"        \u0027vnf_configurable_properties\u0027:"},{"line_number":601,"context_line":"            fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":602,"context_line":"        \u0027vnfc_info_modifications_delete_ids\u0027:"},{"line_number":603,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_0668dff1","line":600,"range":{"start_line":600,"start_character":9,"end_line":600,"end_character":36},"in_reply_to":"9f560f44_bea5f805","updated":"2020-09-22 01:23:01.000000000","message":"removed vnf_configurable_properties","commit_id":"aaffc9857eaf790757422470ece123a7d2d9b6fe"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"be2e450e018bb425727af6230003a97920a77129","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[]),"},{"line_number":427,"context_line":"        \u0027added_storage_resource_ids\u0027:"},{"line_number":428,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[]),"},{"line_number":429,"context_line":"        \u0027removed_storage_sesource_ids\u0027:"},{"line_number":430,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[])"},{"line_number":431,"context_line":"    }"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_85312aa5","line":429,"updated":"2020-09-11 15:53:37.000000000","message":"Typo:removed_storage_resource_ids","commit_id":"0135bee90686efc0a6815a28b1f9252e8ce28e9f"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"67653862f80104cf7b25874bcca874168783575b","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[]),"},{"line_number":427,"context_line":"        \u0027added_storage_resource_ids\u0027:"},{"line_number":428,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[]),"},{"line_number":429,"context_line":"        \u0027removed_storage_sesource_ids\u0027:"},{"line_number":430,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[])"},{"line_number":431,"context_line":"    }"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_57ddf611","line":429,"in_reply_to":"9f560f44_85312aa5","updated":"2020-09-12 04:29:35.000000000","message":"It is fixed.","commit_id":"0135bee90686efc0a6815a28b1f9252e8ce28e9f"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"be2e450e018bb425727af6230003a97920a77129","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        added_storage_resource_ids \u003d data_dict.get("},{"line_number":458,"context_line":"            \u0027added_storage_resource_ids\u0027)"},{"line_number":459,"context_line":"        removed_storage_resource_ids \u003d data_dict.get("},{"line_number":460,"context_line":"            \u0027removed_storage_sesource_ids\u0027)"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        obj \u003d cls(id\u003did,"},{"line_number":463,"context_line":"                  vdu_id\u003dvdu_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_2522de52","line":460,"range":{"start_line":460,"start_character":13,"end_line":460,"end_character":41},"updated":"2020-09-11 15:53:37.000000000","message":"Typo:removed_storage_resource_ids","commit_id":"0135bee90686efc0a6815a28b1f9252e8ce28e9f"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"67653862f80104cf7b25874bcca874168783575b","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        added_storage_resource_ids \u003d data_dict.get("},{"line_number":458,"context_line":"            \u0027added_storage_resource_ids\u0027)"},{"line_number":459,"context_line":"        removed_storage_resource_ids \u003d data_dict.get("},{"line_number":460,"context_line":"            \u0027removed_storage_sesource_ids\u0027)"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        obj \u003d cls(id\u003did,"},{"line_number":463,"context_line":"                  vdu_id\u003dvdu_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_37e042cc","line":460,"range":{"start_line":460,"start_character":13,"end_line":460,"end_character":41},"in_reply_to":"9f560f44_2522de52","updated":"2020-09-12 04:29:35.000000000","message":"It is fixed.","commit_id":"0135bee90686efc0a6815a28b1f9252e8ce28e9f"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"be2e450e018bb425727af6230003a97920a77129","unresolved":false,"context_lines":[{"line_number":480,"context_line":"            \u0027metadata\u0027: self.metadata,"},{"line_number":481,"context_line":"            \u0027affected_vnfc_cp_ids\u0027: self.affected_vnfc_cp_ids,"},{"line_number":482,"context_line":"            \u0027added_storage_resource_ids\u0027: self.added_storage_resource_ids,"},{"line_number":483,"context_line":"            \u0027removed_storage_sesource_ids\u0027: self.removed_storage_sesource_ids}"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"@base.TackerObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_85d64a26","line":483,"range":{"start_line":483,"start_character":13,"end_line":483,"end_character":78},"updated":"2020-09-11 15:53:37.000000000","message":"Typo:removed_storage_resource_ids","commit_id":"0135bee90686efc0a6815a28b1f9252e8ce28e9f"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"67653862f80104cf7b25874bcca874168783575b","unresolved":false,"context_lines":[{"line_number":480,"context_line":"            \u0027metadata\u0027: self.metadata,"},{"line_number":481,"context_line":"            \u0027affected_vnfc_cp_ids\u0027: self.affected_vnfc_cp_ids,"},{"line_number":482,"context_line":"            \u0027added_storage_resource_ids\u0027: self.added_storage_resource_ids,"},{"line_number":483,"context_line":"            \u0027removed_storage_sesource_ids\u0027: self.removed_storage_sesource_ids}"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"@base.TackerObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_97e30ed8","line":483,"range":{"start_line":483,"start_character":13,"end_line":483,"end_character":78},"in_reply_to":"9f560f44_85d64a26","updated":"2020-09-12 04:29:35.000000000","message":"It is fixed.","commit_id":"0135bee90686efc0a6815a28b1f9252e8ce28e9f"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"a297a696394ad2bac59a653c2e9d336248ae845d","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        \u0027vnf_instance_description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":600,"context_line":"        \u0027vnf_configurable_properties\u0027:"},{"line_number":601,"context_line":"            fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":602,"context_line":"        \u0027vnfc_info_modifications_delete_ids\u0027:"},{"line_number":603,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue),"},{"line_number":604,"context_line":"        \u0027vnfd_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":605,"context_line":"        \u0027vnf_provider\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_47573102","line":602,"range":{"start_line":602,"start_character":10,"end_line":602,"end_character":43},"updated":"2020-09-10 10:46:56.000000000","message":"I think it should be vim_connection_info_delete_ids.","commit_id":"0135bee90686efc0a6815a28b1f9252e8ce28e9f"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c48a2ca6b23f935af755cebab0493b79e9542d4f","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        \u0027vnf_instance_description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":600,"context_line":"        \u0027vnf_configurable_properties\u0027:"},{"line_number":601,"context_line":"            fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":602,"context_line":"        \u0027vnfc_info_modifications_delete_ids\u0027:"},{"line_number":603,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue),"},{"line_number":604,"context_line":"        \u0027vnfd_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":605,"context_line":"        \u0027vnf_provider\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_a63493fc","line":602,"range":{"start_line":602,"start_character":10,"end_line":602,"end_character":43},"in_reply_to":"9f560f44_47573102","updated":"2020-09-22 01:23:01.000000000","message":"modified as suggested","commit_id":"0135bee90686efc0a6815a28b1f9252e8ce28e9f"}],"tacker/objects/vnf_package_vnfd.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self._from_db_object(self._context, self, db_vnf_package_vnfd)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @base.remotable_classmethod"},{"line_number":131,"context_line":"    def get_vnf_package_vnfd_by_vnfid(self, context, vnfid):"},{"line_number":132,"context_line":"        return _get_vnf_package_vnfd_by_vnfid(context, vnfid)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_cd527b13","line":131,"updated":"2020-08-21 07:20:13.000000000","message":"This method seems unused outside of unittest, is it needed for subsequent patches?","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self._from_db_object(self._context, self, db_vnf_package_vnfd)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @base.remotable_classmethod"},{"line_number":131,"context_line":"    def get_vnf_package_vnfd_by_vnfid(self, context, vnfid):"},{"line_number":132,"context_line":"        return _get_vnf_package_vnfd_by_vnfid(context, vnfid)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ee434710","line":131,"in_reply_to":"9f560f44_cd527b13","updated":"2020-09-02 14:16:14.000000000","message":"THe following lines in objects/vnf_package_vnfd.py will be removed.\n    @base.remotable_classmethod\n    def get_vnf_package_vnfd_by_vnfid(self, context, vnfid):\n        return _get_vnf_package_vnfd_by_vnfid(context, vnfid)","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e71b5fc303e8ae21626b4c07383c2e540651ed6a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self._from_db_object(self._context, self, db_vnf_package_vnfd)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @base.remotable_classmethod"},{"line_number":131,"context_line":"    def get_vnf_package_vnfd_by_vnfid(self, context, vnfid):"},{"line_number":132,"context_line":"        return _get_vnf_package_vnfd_by_vnfid(context, vnfid)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_79286c96","line":131,"in_reply_to":"9f560f44_ee434710","updated":"2020-09-04 14:37:10.000000000","message":"*Def get_vnf_package_vnfd_by_vnfid has been deleted,\nfunctions that are only called from get_vnf_package_vnfd_by_vnfid,\nThe state where mocking remains in test_conductor_server.py","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"}],"tacker/tests/unit/conductor/fakes.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def create_fake_csar_dir(vnf_package_id, temp_dir,"},{"line_number":82,"context_line":"        csar_without_tosca_meta\u003dFalse):"},{"line_number":83,"context_line":"    csar_dir \u003d (\u0027sample_vnfpkg_no_meta_single_vnfd\u0027 if csar_without_tosca_meta"},{"line_number":84,"context_line":"                else \u0027vnfpkgm1\u0027)"},{"line_number":85,"context_line":"    fake_csar \u003d os.path.join(temp_dir, vnf_package_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4d678bea","line":82,"updated":"2020-08-21 07:20:13.000000000","message":"I think this is unnecessary change.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def create_fake_csar_dir(vnf_package_id, temp_dir,"},{"line_number":82,"context_line":"        csar_without_tosca_meta\u003dFalse):"},{"line_number":83,"context_line":"    csar_dir \u003d (\u0027sample_vnfpkg_no_meta_single_vnfd\u0027 if csar_without_tosca_meta"},{"line_number":84,"context_line":"                else \u0027vnfpkgm1\u0027)"},{"line_number":85,"context_line":"    fake_csar \u003d os.path.join(temp_dir, vnf_package_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0e72fb7c","line":82,"in_reply_to":"9f560f44_4d678bea","updated":"2020-09-02 14:16:14.000000000","message":"The change is reverted.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"}],"tacker/tests/unit/conductor/test_conductor_server.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        self.assertEqual(\u0027CREATED\u0027, self.vnf_package.onboarding_state)"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    @mock.patch.object(objects.VnfPackageVnfd, \u0027get_vnf_package_vnfd_by_vnfid\u0027)"},{"line_number":599,"context_line":"    def test_sendNotification_notFoundVnfd("},{"line_number":600,"context_line":"            self, mock_get_vnf_package_vnfd_by_vnfid):"},{"line_number":601,"context_line":"        notification \u003d {\u0027vnfInstanceId\u0027: \u0027Test\u0027}"},{"line_number":602,"context_line":"        mock_get_vnf_package_vnfd_by_vnfid.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0da7530d","line":599,"updated":"2020-08-21 07:20:13.000000000","message":"Please fix from camelCase to snake_case.\nSame for others.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        self.assertEqual(\u0027CREATED\u0027, self.vnf_package.onboarding_state)"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    @mock.patch.object(objects.VnfPackageVnfd, \u0027get_vnf_package_vnfd_by_vnfid\u0027)"},{"line_number":599,"context_line":"    def test_sendNotification_notFoundVnfd("},{"line_number":600,"context_line":"            self, mock_get_vnf_package_vnfd_by_vnfid):"},{"line_number":601,"context_line":"        notification \u003d {\u0027vnfInstanceId\u0027: \u0027Test\u0027}"},{"line_number":602,"context_line":"        mock_get_vnf_package_vnfd_by_vnfid.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8e03abbe","line":599,"in_reply_to":"9f560f44_0da7530d","updated":"2020-09-02 14:16:14.000000000","message":"modified line \n     def test_sendNotification_notFoundVnfd( \u003d\u003d\u003d\u003d\u003e def test_send_notification_not_found_vnfd(","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"}],"tacker/tests/unit/vnflcm/test_controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from tacker.tests.unit.vnflcm import fakes"},{"line_number":36,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":37,"context_line":"from tacker.vnfm import vim_client"},{"line_number":38,"context_line":"from unittest import mock"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a0be45d1","line":38,"updated":"2020-08-20 05:51:45.000000000","message":"I think this fix isn\u0027t necessary.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from tacker.tests.unit.vnflcm import fakes"},{"line_number":36,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":37,"context_line":"from tacker.vnfm import vim_client"},{"line_number":38,"context_line":"from unittest import mock"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6e0617d0","line":38,"in_reply_to":"9f560f44_a0be45d1","updated":"2020-09-02 14:16:14.000000000","message":"This is necessary because this is a fix of pep8 issues regarding imports are not in alphabetical order","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        mock_get_by_id.return_value \u003d fakes.return_vnf_package_vnfd()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        updates \u003d {\u0027vnf_instance_description\u0027: None,"},{"line_number":68,"context_line":"                   \u0027vnf_instance_name\u0027: None}"},{"line_number":69,"context_line":"        mock_vnf_instance_create.return_value \u003d\\"},{"line_number":70,"context_line":"            fakes.return_vnf_instance_model(**updates)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_208fd52e","line":68,"updated":"2020-08-20 05:51:45.000000000","message":"I think it\u0027s not necessary to modify the indentat　because it\u0027s outside the scope of this patch.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        mock_get_by_id.return_value \u003d fakes.return_vnf_package_vnfd()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        updates \u003d {\u0027vnf_instance_description\u0027: None,"},{"line_number":68,"context_line":"                   \u0027vnf_instance_name\u0027: None}"},{"line_number":69,"context_line":"        mock_vnf_instance_create.return_value \u003d\\"},{"line_number":70,"context_line":"            fakes.return_vnf_instance_model(**updates)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ce0da3e9","line":68,"in_reply_to":"9f560f44_208fd52e","updated":"2020-09-02 14:16:14.000000000","message":"This is necessary because this is a fix of pep8 issues regarding multi-line","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"}],"tacker/tests/unit/vnflcm/test_vnflcm_driver.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":30,"context_line":"from tacker.vnflcm import vnflcm_driver"},{"line_number":31,"context_line":"from tacker.vnfm import vim_client"},{"line_number":32,"context_line":"from unittest import mock"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class InfraDriverException(Exception):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_809ea160","line":32,"updated":"2020-08-20 05:51:45.000000000","message":"I think this fix isn\u0027t necessary.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":30,"context_line":"from tacker.vnflcm import vnflcm_driver"},{"line_number":31,"context_line":"from tacker.vnfm import vim_client"},{"line_number":32,"context_line":"from unittest import mock"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class InfraDriverException(Exception):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2efc1fb4","line":32,"in_reply_to":"9f560f44_809ea160","updated":"2020-09-02 14:16:14.000000000","message":"The fix was applied due to pep8 error.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"483efa86e3bf2ba900d15d478f8b34f4f18bd890","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        fake_csar \u003d os.path.join(self.temp_dir, vnf_package_id)"},{"line_number":146,"context_line":"        cfg.CONF.set_override(\u0027vnf_package_csar_path\u0027, self.temp_dir,"},{"line_number":147,"context_line":"                              group\u003d\u0027vnf_package\u0027)"},{"line_number":148,"context_line":"        base_path \u003d os.path.dirname(os.path.abspath(__file__))"},{"line_number":149,"context_line":"        sample_vnf_package_zip \u003d os.path.join("},{"line_number":150,"context_line":"            base_path, \"../../etc/samples/sample_vnf_package_csar.zip\")"},{"line_number":151,"context_line":"        extracted_zip_path \u003d fake_csar"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8077c13a","line":148,"updated":"2020-08-20 05:51:45.000000000","message":"https://review.opendev.org/#/c/730709/\nLike the patch above, please avoid use of zip files in unit tests.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        fake_csar \u003d os.path.join(self.temp_dir, vnf_package_id)"},{"line_number":146,"context_line":"        cfg.CONF.set_override(\u0027vnf_package_csar_path\u0027, self.temp_dir,"},{"line_number":147,"context_line":"                              group\u003d\u0027vnf_package\u0027)"},{"line_number":148,"context_line":"        base_path \u003d os.path.dirname(os.path.abspath(__file__))"},{"line_number":149,"context_line":"        sample_vnf_package_zip \u003d os.path.join("},{"line_number":150,"context_line":"            base_path, \"../../etc/samples/sample_vnf_package_csar.zip\")"},{"line_number":151,"context_line":"        extracted_zip_path \u003d fake_csar"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ee1a2716","line":148,"in_reply_to":"9f560f44_8077c13a","updated":"2020-09-02 14:16:14.000000000","message":"Reverted back to original code.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        self.assertEqual(expected_error % vnf_instance_obj.id, str(error))"},{"line_number":272,"context_line":"        self.assertEqual(\"NOT_INSTANTIATED\","},{"line_number":273,"context_line":"            vnf_instance_obj.instantiation_state)"},{"line_number":274,"context_line":"        self.assertEqual(1, mock_vnf_instance_save.call_count)"},{"line_number":275,"context_line":"        self.assertEqual(2, self._vnf_manager.invoke.call_count)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        shutil.rmtree(fake_csar)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0df593ed","line":274,"updated":"2020-08-21 07:20:13.000000000","message":"Why do you need this change?\nI was wondering if the existing behavior was accidentally changed.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        self.assertEqual(expected_error % vnf_instance_obj.id, str(error))"},{"line_number":272,"context_line":"        self.assertEqual(\"NOT_INSTANTIATED\","},{"line_number":273,"context_line":"            vnf_instance_obj.instantiation_state)"},{"line_number":274,"context_line":"        self.assertEqual(1, mock_vnf_instance_save.call_count)"},{"line_number":275,"context_line":"        self.assertEqual(2, self._vnf_manager.invoke.call_count)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        shutil.rmtree(fake_csar)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4eefd3e8","line":274,"in_reply_to":"9f560f44_0df593ed","updated":"2020-09-02 14:16:14.000000000","message":"In normal scenario, save() will be called twice.\nIn abnormal scenario, save() will be called only once due to exception error prior to the call of second save().\nThis test is abnormal scenario, therefore test_instantiate_vnf_infra_fails_to_instantiate() test will call save() only once.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e71b5fc303e8ae21626b4c07383c2e540651ed6a","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        self.assertEqual(expected_error % vnf_instance_obj.id, str(error))"},{"line_number":272,"context_line":"        self.assertEqual(\"NOT_INSTANTIATED\","},{"line_number":273,"context_line":"            vnf_instance_obj.instantiation_state)"},{"line_number":274,"context_line":"        self.assertEqual(1, mock_vnf_instance_save.call_count)"},{"line_number":275,"context_line":"        self.assertEqual(2, self._vnf_manager.invoke.call_count)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        shutil.rmtree(fake_csar)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0c081026","line":274,"in_reply_to":"9f560f44_4eefd3e8","updated":"2020-09-04 14:37:10.000000000","message":"Test code is restored.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        self.assertEqual(expected_error % vnf_instance_obj.id, str(error))"},{"line_number":314,"context_line":"        self.assertEqual(\"NOT_INSTANTIATED\","},{"line_number":315,"context_line":"            vnf_instance_obj.instantiation_state)"},{"line_number":316,"context_line":"        self.assertEqual(1, mock_vnf_instance_save.call_count)"},{"line_number":317,"context_line":"        self.assertEqual(3, self._vnf_manager.invoke.call_count)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        shutil.rmtree(fake_csar)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6ddd2f6f","line":316,"updated":"2020-08-21 07:20:13.000000000","message":"Why do you need this change?\nI was wondering if the existing behavior was accidentally changed.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        self.assertEqual(expected_error % vnf_instance_obj.id, str(error))"},{"line_number":314,"context_line":"        self.assertEqual(\"NOT_INSTANTIATED\","},{"line_number":315,"context_line":"            vnf_instance_obj.instantiation_state)"},{"line_number":316,"context_line":"        self.assertEqual(1, mock_vnf_instance_save.call_count)"},{"line_number":317,"context_line":"        self.assertEqual(3, self._vnf_manager.invoke.call_count)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        shutil.rmtree(fake_csar)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8eba8bde","line":316,"in_reply_to":"9f560f44_6ddd2f6f","updated":"2020-09-02 14:16:14.000000000","message":"In normal scenario, save() will be called twice.\nIn abnormal scenario, save() will be called only once due to exception error prior to the call of second save().\nThis test is abnormal scenario, therefore test_instantiate_vnf_infra_fails_to_wait_after_instantiate test will call save() only once.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e71b5fc303e8ae21626b4c07383c2e540651ed6a","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        self.assertEqual(expected_error % vnf_instance_obj.id, str(error))"},{"line_number":314,"context_line":"        self.assertEqual(\"NOT_INSTANTIATED\","},{"line_number":315,"context_line":"            vnf_instance_obj.instantiation_state)"},{"line_number":316,"context_line":"        self.assertEqual(1, mock_vnf_instance_save.call_count)"},{"line_number":317,"context_line":"        self.assertEqual(3, self._vnf_manager.invoke.call_count)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        shutil.rmtree(fake_csar)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ac29248a","line":316,"in_reply_to":"9f560f44_8eba8bde","updated":"2020-09-04 14:37:10.000000000","message":"Test code is restored.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        self.assertEqual(None, vnf_instance.task_state)"},{"line_number":690,"context_line":"        expected_msg \u003d (\u0027Failed to update vnf %(id)s resources for \u0027"},{"line_number":691,"context_line":"                        \u0027instance%(instance)s. Error: %(error)s\u0027)"},{"line_number":692,"context_line":"        mock_log.error.assert_called_with(expected_msg,"},{"line_number":693,"context_line":"            {\u0027id\u0027: vnf_instance.id,"},{"line_number":694,"context_line":"             \u0027instance\u0027: vnf_instance.instantiated_vnf_info.instance_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0dce33b3","line":691,"updated":"2020-08-21 07:20:13.000000000","message":"I think this is unnecessary change.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        self.assertEqual(None, vnf_instance.task_state)"},{"line_number":690,"context_line":"        expected_msg \u003d (\u0027Failed to update vnf %(id)s resources for \u0027"},{"line_number":691,"context_line":"                        \u0027instance%(instance)s. Error: %(error)s\u0027)"},{"line_number":692,"context_line":"        mock_log.error.assert_called_with(expected_msg,"},{"line_number":693,"context_line":"            {\u0027id\u0027: vnf_instance.id,"},{"line_number":694,"context_line":"             \u0027instance\u0027: vnf_instance.instantiated_vnf_info.instance_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6ea297af","line":691,"in_reply_to":"9f560f44_0dce33b3","updated":"2020-09-02 14:16:14.000000000","message":"Reverted the code.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e71b5fc303e8ae21626b4c07383c2e540651ed6a","unresolved":false,"context_lines":[{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        self.assertEqual(None, vnf_instance.task_state)"},{"line_number":690,"context_line":"        expected_msg \u003d (\u0027Failed to update vnf %(id)s resources for \u0027"},{"line_number":691,"context_line":"                        \u0027instance%(instance)s. Error: %(error)s\u0027)"},{"line_number":692,"context_line":"        mock_log.error.assert_called_with(expected_msg,"},{"line_number":693,"context_line":"            {\u0027id\u0027: vnf_instance.id,"},{"line_number":694,"context_line":"             \u0027instance\u0027: vnf_instance.instantiated_vnf_info.instance_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2c3a34c3","line":691,"in_reply_to":"9f560f44_6ea297af","updated":"2020-09-04 14:37:10.000000000","message":"Additional code was restored.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1d6e2d6bbee12b1679ce09292ce90743330a813c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    return decorated_function"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@utils.expects_func_args(\u0027vnf_info\u0027, \u0027vnf_instance\u0027, \u0027scale_vnf_request\u0027)"},{"line_number":82,"context_line":"def revert_to_error_scale(function):"},{"line_number":83,"context_line":"    \"\"\"Decorator to revert task_state to error  on failure.\"\"\""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_cd0a7bd0","line":81,"updated":"2020-08-21 07:20:13.000000000","message":"These changes related to scale, and I think it shouldn\u0027t be included in this notification patch.\nIs it right?","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"535e90e632d1cf420e03f16a3b64d80900971a40","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    return decorated_function"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@utils.expects_func_args(\u0027vnf_info\u0027, \u0027vnf_instance\u0027, \u0027scale_vnf_request\u0027)"},{"line_number":82,"context_line":"def revert_to_error_scale(function):"},{"line_number":83,"context_line":"    \"\"\"Decorator to revert task_state to error  on failure.\"\"\""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_445734cb","line":81,"in_reply_to":"9f560f44_33cd635d","updated":"2020-09-10 05:24:50.000000000","message":"Done.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b0063bbf5eadafd3e0b5a1bae7920b82fa5dd257","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    return decorated_function"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@utils.expects_func_args(\u0027vnf_info\u0027, \u0027vnf_instance\u0027, \u0027scale_vnf_request\u0027)"},{"line_number":82,"context_line":"def revert_to_error_scale(function):"},{"line_number":83,"context_line":"    \"\"\"Decorator to revert task_state to error  on failure.\"\"\""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_cea92391","line":81,"in_reply_to":"9f560f44_cd0a7bd0","updated":"2020-09-02 14:16:14.000000000","message":"Removed codes related to scale.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5af4b6640598087631657731990eca605b636004","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    return decorated_function"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@utils.expects_func_args(\u0027vnf_info\u0027, \u0027vnf_instance\u0027, \u0027scale_vnf_request\u0027)"},{"line_number":82,"context_line":"def revert_to_error_scale(function):"},{"line_number":83,"context_line":"    \"\"\"Decorator to revert task_state to error  on failure.\"\"\""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_33cd635d","line":81,"in_reply_to":"9f560f44_cea92391","updated":"2020-09-07 02:52:12.000000000","message":"I think you need to add it to the 747511 patch after removing it.","commit_id":"b1b0f51ada78696afbfccca414901c37d45d48f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f9069b8e930a8daf0e0182d8b1d63ee8fdaddcc9","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                vim_connection_info\u003dvim_connection_info)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @log.log"},{"line_number":225,"context_line":"    @rollback_vnf_instantiated_resources"},{"line_number":226,"context_line":"    def instantiate_vnf(self, context, vnf_instance, instantiate_vnf_req):"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        vim_connection_info_list \u003d vnflcm_utils.\\"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_721e15bc","line":225,"updated":"2020-09-16 02:30:14.000000000","message":"I have a confirmation about the following comment on 747349.\nI think \u0027bp / support-etsi-nfv-specs\u0027 will newly support the rollback operation.\nSo I thought the \"rollback_vnf_instantiated_resources\" in tacker / vnflcm / vnflcm_driver.py should be removed.\nIs it right?\n\n  \u003e The root cause was that \"rollback_vnf_instantiated_resources\"\n  \u003e function in tacker / vnflcm / vnflcm_driver.py was incorrectly deleted\n  \u003e in 746892.","commit_id":"ec0cef4ab87e20eb538552de5784449b31e64234"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c48a2ca6b23f935af755cebab0493b79e9542d4f","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                vim_connection_info\u003dvim_connection_info)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    @log.log"},{"line_number":225,"context_line":"    @rollback_vnf_instantiated_resources"},{"line_number":226,"context_line":"    def instantiate_vnf(self, context, vnf_instance, instantiate_vnf_req):"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        vim_connection_info_list \u003d vnflcm_utils.\\"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_c9fd5809","line":225,"in_reply_to":"9f560f44_721e15bc","updated":"2020-09-22 01:23:01.000000000","message":"I acknowledge it. However, this repair is not done in notification. Therefore, I put it back and deleted it in another patch.","commit_id":"ec0cef4ab87e20eb538552de5784449b31e64234"}]}