)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a4bccb9390ff26c9ebe059f2983ad31e89d4aed1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"* PATCH /vnflcm/v1/vnf_instances/{vnfInstanceId}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"https://specs.openstack.org/openstack/tacker-specs/specs/victoria/support-vnf-update-api-based-on-etsi-nfv-sol.html"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If8c37bcf2fcd9094f3be4d212bdf79c322ae2705"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_f1ef3fae","line":15,"updated":"2020-09-10 16:56:49.000000000","message":"Could you add `Implements` tag for blueprint?","commit_id":"8519d0eb293c3aaedd7ae074fde2e2cf87cc1745"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"49cb567dc2097da0e0b6f8fb5d221f4e9dea9d34","unresolved":false,"context_lines":[{"line_number":12,"context_line":"* PATCH /vnflcm/v1/vnf_instances/{vnfInstanceId}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"https://specs.openstack.org/openstack/tacker-specs/specs/victoria/support-vnf-update-api-based-on-etsi-nfv-sol.html"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If8c37bcf2fcd9094f3be4d212bdf79c322ae2705"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_62a099f4","line":15,"in_reply_to":"9f560f44_f1ef3fae","updated":"2020-09-22 14:19:17.000000000","message":"added implements tag.","commit_id":"8519d0eb293c3aaedd7ae074fde2e2cf87cc1745"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9efc373489819aaacccdd4308630a8f20dec2662","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     70c95d93 ([WIP] Support of OAuth2.0)"},{"line_number":2,"context_line":"Author:     Aldinson Esto \u003cesto.aln@nec.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2020-08-21 21:11:24 +0900"},{"line_number":4,"context_line":"Commit:     Aldinson C. Esto \u003cesto.aln@nec.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f560f44_ed38daa0","line":1,"updated":"2020-08-26 06:21:21.000000000","message":"Is it mandatory to set OAuth2.0 patch to parent?\nIn my opinion, I think it\u0027s not required for this update patch.\nIf it is right, you should better to set the parent to 747149.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"132f353a425f5767bb9fbe1ceaec46e705c6cf3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     70c95d93 ([WIP] Support of OAuth2.0)"},{"line_number":2,"context_line":"Author:     Aldinson Esto \u003cesto.aln@nec.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2020-08-21 21:11:24 +0900"},{"line_number":4,"context_line":"Commit:     Aldinson C. Esto \u003cesto.aln@nec.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f560f44_79000803","line":1,"in_reply_to":"9f560f44_ed38daa0","updated":"2020-08-26 10:49:41.000000000","message":"These patches have similar actions, and there are some associations (parent-to-child) between the patches, so I don\u0027t think it is advisable to change the parent.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e4bcc302ca97639e38c7d1015f9ca52a32359630","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson C. Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-29 04:24:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support VNF update operations based on ETSI NFV-SOL"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Supported ETSI SOL003 Modify VNF function."},{"line_number":10,"context_line":"Added processing for receiving Individual VNF Instances(PATCH)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_7ceb91db","line":7,"updated":"2020-08-31 09:21:48.000000000","message":"It seems that the result of Zuul check may change at each recheck.\nThere may include some problem with not 100% reproducibility.\nPlease be careful.","commit_id":"b2878ebfb1b78fed515ff8b58de3b8fcaa9e2a43"}],"tacker/api/schemas/vnf_lcm.py":[{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"928112a3ecf26f889fed599a8abb13dab69b03c7","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"update \u003d {"},{"line_number":232,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":233,"context_line":"    \u0027properties\u0027: {"},{"line_number":234,"context_line":"        \u0027vnfdId\u0027: parameter_types.uuid,"},{"line_number":235,"context_line":"        \u0027vnfInstanceName\u0027: parameter_types.name_allow_zero_min_length,"},{"line_number":236,"context_line":"        \u0027vnfInstanceDescription\u0027: parameter_types.description,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_38e6a5b1","line":233,"range":{"start_line":233,"start_character":5,"end_line":233,"end_character":15},"updated":"2020-09-24 08:11:09.000000000","message":"In this properties, all attribute in type:VnfInfoModificationRequest which is supported in Victoria should be placed.","commit_id":"0c27f92aebe6a7e318ab11a874d2f16556e594d3"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4a2881fb6290aa1c3aab361b311fbae252856d82","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"update \u003d {"},{"line_number":232,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":233,"context_line":"    \u0027properties\u0027: {"},{"line_number":234,"context_line":"        \u0027vnfdId\u0027: parameter_types.uuid,"},{"line_number":235,"context_line":"        \u0027vnfInstanceName\u0027: parameter_types.name_allow_zero_min_length,"},{"line_number":236,"context_line":"        \u0027vnfInstanceDescription\u0027: parameter_types.description,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_dafbfd77","line":233,"range":{"start_line":233,"start_character":5,"end_line":233,"end_character":15},"in_reply_to":"9f560f44_38e6a5b1","updated":"2020-09-25 14:41:29.000000000","message":"It is fixed.","commit_id":"0c27f92aebe6a7e318ab11a874d2f16556e594d3"}],"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9efc373489819aaacccdd4308630a8f20dec2662","unresolved":false,"context_lines":[{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    @wsgi.response(http_client.OK)"},{"line_number":525,"context_line":"    @wsgi.expected_errors((http_client.FORBIDDEN, http_client.NOT_FOUND))"},{"line_number":526,"context_line":"    def update_vnf(self, request, id, body):"},{"line_number":527,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":528,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027update_vnf\u0027)"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_56fb58bc","line":526,"updated":"2020-08-26 06:21:21.000000000","message":"I think it\u0027s better to use \u0027update\u0027 with the same name as the existing method.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    @wsgi.response(http_client.OK)"},{"line_number":525,"context_line":"    @wsgi.expected_errors((http_client.FORBIDDEN, http_client.NOT_FOUND))"},{"line_number":526,"context_line":"    def update_vnf(self, request, id, body):"},{"line_number":527,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":528,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027update_vnf\u0027)"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3b4d113b","line":526,"in_reply_to":"9f560f44_56fb58bc","updated":"2020-09-09 10:25:40.000000000","message":"Modified as you suggested.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48d88030e0ada392fae0308553d42f8ae81ed70a","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":528,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027update_vnf\u0027)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        # get body"},{"line_number":531,"context_line":"        body_data \u003d {}"},{"line_number":532,"context_line":"        body_data[\u0027vnf_instance_name\u0027] \u003d body.get(\u0027vnfInstanceName\u0027)"},{"line_number":533,"context_line":"        body_data[\u0027vnf_instance_description\u0027] \u003d body.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_fd733f15","line":530,"updated":"2020-08-28 02:57:58.000000000","message":"It seems that the data of body is stored again in body_data, is it necessary?\nIs it possible to use body as it is?","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d2cfee352b107c8722ddaeca8aa8064c788f48c9","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":528,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027update_vnf\u0027)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        # get body"},{"line_number":531,"context_line":"        body_data \u003d {}"},{"line_number":532,"context_line":"        body_data[\u0027vnf_instance_name\u0027] \u003d body.get(\u0027vnfInstanceName\u0027)"},{"line_number":533,"context_line":"        body_data[\u0027vnf_instance_description\u0027] \u003d body.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_9896fa93","line":530,"in_reply_to":"9f560f44_55714d44","updated":"2020-09-22 15:40:06.000000000","message":"here is no need to convert it, but other processing is also advantageous in terms of maintainability such as converting request to snake_case and extracting specific parameters from all functions.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d7410765568e982095e0ab4e27a3ce2ebf254d7c","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":528,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027update_vnf\u0027)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        # get body"},{"line_number":531,"context_line":"        body_data \u003d {}"},{"line_number":532,"context_line":"        body_data[\u0027vnf_instance_name\u0027] \u003d body.get(\u0027vnfInstanceName\u0027)"},{"line_number":533,"context_line":"        body_data[\u0027vnf_instance_description\u0027] \u003d body.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_ac8616b9","line":530,"in_reply_to":"9f560f44_9896fa93","updated":"2020-09-23 09:32:53.000000000","message":"I understood that there was no need to convert and that it had some maintainability benefits.\nHowever, I couldn\u0027t understand what the maintainability benefits were.\nCan you tell me a little more about it?\nIf it\u0027s just an unnecessary conversion, I think it\u0027s better to remove it.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"2bb70584f980e6c2de9057b23f8c336905c2b47c","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":528,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027update_vnf\u0027)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        # get body"},{"line_number":531,"context_line":"        body_data \u003d {}"},{"line_number":532,"context_line":"        body_data[\u0027vnf_instance_name\u0027] \u003d body.get(\u0027vnfInstanceName\u0027)"},{"line_number":533,"context_line":"        body_data[\u0027vnf_instance_description\u0027] \u003d body.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_54218b4c","line":530,"in_reply_to":"9f560f44_ac8616b9","updated":"2020-09-25 09:35:04.000000000","message":"It is modified.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"936c1772e14352b307f2c63bb933ef76ffd7c332","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":528,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027update_vnf\u0027)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        # get body"},{"line_number":531,"context_line":"        body_data \u003d {}"},{"line_number":532,"context_line":"        body_data[\u0027vnf_instance_name\u0027] \u003d body.get(\u0027vnfInstanceName\u0027)"},{"line_number":533,"context_line":"        body_data[\u0027vnf_instance_description\u0027] \u003d body.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_55714d44","line":530,"in_reply_to":"9f560f44_fb5b9950","updated":"2020-09-15 08:29:32.000000000","message":"I couldn\u0027t understand why you converted the key name to snake_case.\nIs there somewhere in the subsequent process that needs to be converted to snake_case?","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        context \u003d request.environ[\u0027tacker.context\u0027]"},{"line_number":528,"context_line":"        context.can(vnf_lcm_policies.VNFLCM % \u0027update_vnf\u0027)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        # get body"},{"line_number":531,"context_line":"        body_data \u003d {}"},{"line_number":532,"context_line":"        body_data[\u0027vnf_instance_name\u0027] \u003d body.get(\u0027vnfInstanceName\u0027)"},{"line_number":533,"context_line":"        body_data[\u0027vnf_instance_description\u0027] \u003d body.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_fb5b9950","line":530,"in_reply_to":"9f560f44_fd733f15","updated":"2020-09-09 10:25:40.000000000","message":"The purpose of this code is for changing each key name to snake case.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9efc373489819aaacccdd4308630a8f20dec2662","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            \u0027operationParams\u0027:"},{"line_number":596,"context_line":"            vnf_instance_data.instantiated_vnf_info.additional_params}"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"        self.rpc_api.update_vnf_instance_content("},{"line_number":599,"context_line":"            context,"},{"line_number":600,"context_line":"            vnf_lcm_opoccs,"},{"line_number":601,"context_line":"            body_data,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_b6d47421","line":598,"updated":"2020-08-26 06:21:21.000000000","message":"I think it\u0027s better to use \"self.rpc_api.update(\" with the same name as the existing method.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            \u0027operationParams\u0027:"},{"line_number":596,"context_line":"            vnf_instance_data.instantiated_vnf_info.additional_params}"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"        self.rpc_api.update_vnf_instance_content("},{"line_number":599,"context_line":"            context,"},{"line_number":600,"context_line":"            vnf_lcm_opoccs,"},{"line_number":601,"context_line":"            body_data,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_9b041dc8","line":598,"in_reply_to":"9f560f44_b6d47421","updated":"2020-09-09 10:25:40.000000000","message":"Modified as you suggested.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6dee56948517ff07089ebb8c2c0c1be82a769a07","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        res \u003d webob.Response(content_type\u003d\u0027application/json\u0027)"},{"line_number":607,"context_line":"        res.status_int \u003d 200"},{"line_number":608,"context_line":"        loc_url \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":609,"context_line":"            \u0027/vnflcmv1/vnf_lcm_op_occs/\u0027 + op_occs_uuid"},{"line_number":610,"context_line":"        location \u003d (\u0027Location\u0027, loc_url)"},{"line_number":611,"context_line":"        res.headerlist.append(location)"},{"line_number":612,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5966d252","line":609,"range":{"start_line":609,"start_character":13,"end_line":609,"end_character":23},"updated":"2020-08-27 06:32:41.000000000","message":"Typo: /vnflcm/v1/","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        res \u003d webob.Response(content_type\u003d\u0027application/json\u0027)"},{"line_number":607,"context_line":"        res.status_int \u003d 200"},{"line_number":608,"context_line":"        loc_url \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":609,"context_line":"            \u0027/vnflcmv1/vnf_lcm_op_occs/\u0027 + op_occs_uuid"},{"line_number":610,"context_line":"        location \u003d (\u0027Location\u0027, loc_url)"},{"line_number":611,"context_line":"        res.headerlist.append(location)"},{"line_number":612,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3bc23154","line":609,"range":{"start_line":609,"start_character":13,"end_line":609,"end_character":23},"in_reply_to":"9f560f44_5966d252","updated":"2020-09-09 10:25:40.000000000","message":"Fixed.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6d4d4c2120c60659ceaa596bab280555f541825e","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        res \u003d webob.Response(content_type\u003d\u0027application/json\u0027)"},{"line_number":607,"context_line":"        res.status_int \u003d 200"},{"line_number":608,"context_line":"        loc_url \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":609,"context_line":"            \u0027/vnflcmv1/vnf_lcm_op_occs/\u0027 + op_occs_uuid"},{"line_number":610,"context_line":"        location \u003d (\u0027Location\u0027, loc_url)"},{"line_number":611,"context_line":"        res.headerlist.append(location)"},{"line_number":612,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_10d30cd7","line":609,"range":{"start_line":609,"start_character":13,"end_line":609,"end_character":23},"updated":"2020-09-04 08:38:27.000000000","message":"Typo: /vnflcm/v1/","commit_id":"b2878ebfb1b78fed515ff8b58de3b8fcaa9e2a43"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"af922482b46a0cdf4499f3a7e2b15162bc752405","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        res \u003d webob.Response(content_type\u003d\u0027application/json\u0027)"},{"line_number":607,"context_line":"        res.status_int \u003d 200"},{"line_number":608,"context_line":"        loc_url \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":609,"context_line":"            \u0027/vnflcmv1/vnf_lcm_op_occs/\u0027 + op_occs_uuid"},{"line_number":610,"context_line":"        location \u003d (\u0027Location\u0027, loc_url)"},{"line_number":611,"context_line":"        res.headerlist.append(location)"},{"line_number":612,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_2484c00a","line":609,"range":{"start_line":609,"start_character":13,"end_line":609,"end_character":23},"in_reply_to":"9f560f44_10d30cd7","updated":"2020-09-11 12:21:55.000000000","message":"Fixed.","commit_id":"b2878ebfb1b78fed515ff8b58de3b8fcaa9e2a43"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"c39d0ff44f2a3d08da8ca30b8cdacbc9f70d0654","unresolved":false,"context_lines":[{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        # make response"},{"line_number":597,"context_line":"        res \u003d webob.Response(content_type\u003d\u0027application/json\u0027)"},{"line_number":598,"context_line":"        res.status_int \u003d 200"},{"line_number":599,"context_line":"        loc_url \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":600,"context_line":"            \u0027/vnflcm/v1/vnf_lcm_op_occs/\u0027 + op_occs_uuid"},{"line_number":601,"context_line":"        location \u003d (\u0027Location\u0027, loc_url)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_e8d556b8","line":598,"range":{"start_line":598,"start_character":25,"end_line":598,"end_character":28},"updated":"2020-09-11 16:24:12.000000000","message":"I think \"202\" is better here.","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"105e6ce23e620f16a7946d84f50b884cb419aed2","unresolved":false,"context_lines":[{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        # make response"},{"line_number":597,"context_line":"        res \u003d webob.Response(content_type\u003d\u0027application/json\u0027)"},{"line_number":598,"context_line":"        res.status_int \u003d 200"},{"line_number":599,"context_line":"        loc_url \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":600,"context_line":"            \u0027/vnflcm/v1/vnf_lcm_op_occs/\u0027 + op_occs_uuid"},{"line_number":601,"context_line":"        location \u003d (\u0027Location\u0027, loc_url)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_a66ee592","line":598,"range":{"start_line":598,"start_character":25,"end_line":598,"end_character":28},"in_reply_to":"9f560f44_e8d556b8","updated":"2020-09-12 09:49:27.000000000","message":"Changed to 202.","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"}],"tacker/api/vnflcm/v1/router.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9efc373489819aaacccdd4308630a8f20dec2662","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # Allowed methods on"},{"line_number":61,"context_line":"        # /vnflcm/v1/vnf_instances/{vnfInstanceId} resource"},{"line_number":62,"context_line":"        methods \u003d {\"DELETE\": \"delete\", \"GET\": \"show\", \"PATCH\": \"update_vnf\"}"},{"line_number":63,"context_line":"        self._setup_route(mapper, \"/vnf_instances/{id}\","},{"line_number":64,"context_line":"                          methods, controller, default_resource)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_b62f543d","line":62,"updated":"2020-08-26 06:21:21.000000000","message":"I think it\u0027s better to use \"update\" with the same name as the existing method.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # Allowed methods on"},{"line_number":61,"context_line":"        # /vnflcm/v1/vnf_instances/{vnfInstanceId} resource"},{"line_number":62,"context_line":"        methods \u003d {\"DELETE\": \"delete\", \"GET\": \"show\", \"PATCH\": \"update_vnf\"}"},{"line_number":63,"context_line":"        self._setup_route(mapper, \"/vnf_instances/{id}\","},{"line_number":64,"context_line":"                          methods, controller, default_resource)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_db0a15cf","line":62,"in_reply_to":"9f560f44_b62f543d","updated":"2020-09-09 10:25:40.000000000","message":"Modified as you suggested.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6d4d4c2120c60659ceaa596bab280555f541825e","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # Allowed methods on"},{"line_number":61,"context_line":"        # /vnflcm/v1/vnf_instances/{vnfInstanceId} resource"},{"line_number":62,"context_line":"        methods \u003d {\"DELETE\": \"delete\", \"GET\": \"show\", \"PATCH\": \"update_vnf\"}"},{"line_number":63,"context_line":"        self._setup_route(mapper, \"/vnf_instances/{id}\","},{"line_number":64,"context_line":"                          methods, controller, default_resource)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_707528cc","line":62,"range":{"start_line":62,"start_character":64,"end_line":62,"end_character":74},"updated":"2020-09-04 08:38:27.000000000","message":"\"modify\" or \"update\" should be appropriate.","commit_id":"b2878ebfb1b78fed515ff8b58de3b8fcaa9e2a43"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"af922482b46a0cdf4499f3a7e2b15162bc752405","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # Allowed methods on"},{"line_number":61,"context_line":"        # /vnflcm/v1/vnf_instances/{vnfInstanceId} resource"},{"line_number":62,"context_line":"        methods \u003d {\"DELETE\": \"delete\", \"GET\": \"show\", \"PATCH\": \"update_vnf\"}"},{"line_number":63,"context_line":"        self._setup_route(mapper, \"/vnf_instances/{id}\","},{"line_number":64,"context_line":"                          methods, controller, default_resource)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_e492c84a","line":62,"range":{"start_line":62,"start_character":64,"end_line":62,"end_character":74},"in_reply_to":"9f560f44_707528cc","updated":"2020-09-11 12:21:55.000000000","message":"Changed to \"update\".","commit_id":"b2878ebfb1b78fed515ff8b58de3b8fcaa9e2a43"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48d88030e0ada392fae0308553d42f8ae81ed70a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                    vnf_obj.updated_at \u003d vnf_now"},{"line_number":174,"context_line":"                    vnf_obj.save()"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"                    # update events"},{"line_number":177,"context_line":"                    e_msg \u003d str(exp)"},{"line_number":178,"context_line":"                    t_admin_context \u003d t_context.get_admin_context()"},{"line_number":179,"context_line":"                    with t_admin_context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7db56f7e","line":176,"updated":"2020-08-28 02:57:58.000000000","message":"Is it necessary to update this events table?","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                    vnf_obj.updated_at \u003d vnf_now"},{"line_number":174,"context_line":"                    vnf_obj.save()"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"                    # update events"},{"line_number":177,"context_line":"                    e_msg \u003d str(exp)"},{"line_number":178,"context_line":"                    t_admin_context \u003d t_context.get_admin_context()"},{"line_number":179,"context_line":"                    with t_admin_context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_db0fb536","line":176,"in_reply_to":"9f560f44_7db56f7e","updated":"2020-09-09 10:25:40.000000000","message":"Deleted due to unnecessary one.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48d88030e0ada392fae0308553d42f8ae81ed70a","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"        except Exception as msg:"},{"line_number":1170,"context_line":"            raise Exception(str(msg))"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        # update events"},{"line_number":1173,"context_line":"        event_admin_context \u003d t_context.get_admin_context()"},{"line_number":1174,"context_line":"        with event_admin_context.session.begin(subtransactions\u003dTrue):"},{"line_number":1175,"context_line":"            event_db \u003d common_services_db.Event("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1dc0b3e0","line":1172,"updated":"2020-08-28 02:57:58.000000000","message":"Is it necessary to update this events table?","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"        except Exception as msg:"},{"line_number":1170,"context_line":"            raise Exception(str(msg))"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        # update events"},{"line_number":1173,"context_line":"        event_admin_context \u003d t_context.get_admin_context()"},{"line_number":1174,"context_line":"        with event_admin_context.session.begin(subtransactions\u003dTrue):"},{"line_number":1175,"context_line":"            event_db \u003d common_services_db.Event("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3b007102","line":1172,"in_reply_to":"9f560f44_1dc0b3e0","updated":"2020-09-09 10:25:40.000000000","message":"Deleted due to unnecessary one.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48d88030e0ada392fae0308553d42f8ae81ed70a","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"        except Exception as msg:"},{"line_number":1215,"context_line":"            raise Exception(str(msg))"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        # Notification"},{"line_number":1218,"context_line":"        notification \u003d {}"},{"line_number":1219,"context_line":"        notification[\u0027notificationType\u0027] \u003d \\"},{"line_number":1220,"context_line":"            \u0027VnfLcmOperationOccurrenceNotification\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1d65531e","line":1217,"updated":"2020-08-28 02:57:58.000000000","message":"I think it\u0027s better to define notification_data like line 524. \nYou should improve readability and make use of variables defined in fields.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"2bb70584f980e6c2de9057b23f8c336905c2b47c","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"        except Exception as msg:"},{"line_number":1215,"context_line":"            raise Exception(str(msg))"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        # Notification"},{"line_number":1218,"context_line":"        notification \u003d {}"},{"line_number":1219,"context_line":"        notification[\u0027notificationType\u0027] \u003d \\"},{"line_number":1220,"context_line":"            \u0027VnfLcmOperationOccurrenceNotification\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_b43907a4","line":1217,"in_reply_to":"9f560f44_0cbbc2c3","updated":"2020-09-25 09:35:04.000000000","message":"It is fixed.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"        except Exception as msg:"},{"line_number":1215,"context_line":"            raise Exception(str(msg))"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        # Notification"},{"line_number":1218,"context_line":"        notification \u003d {}"},{"line_number":1219,"context_line":"        notification[\u0027notificationType\u0027] \u003d \\"},{"line_number":1220,"context_line":"            \u0027VnfLcmOperationOccurrenceNotification\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1e3bdbd0","line":1217,"in_reply_to":"9f560f44_1d65531e","updated":"2020-09-09 10:25:40.000000000","message":"I understand your comment, but left as it is because this is not a small change.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"936c1772e14352b307f2c63bb933ef76ffd7c332","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"        except Exception as msg:"},{"line_number":1215,"context_line":"            raise Exception(str(msg))"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        # Notification"},{"line_number":1218,"context_line":"        notification \u003d {}"},{"line_number":1219,"context_line":"        notification[\u0027notificationType\u0027] \u003d \\"},{"line_number":1220,"context_line":"            \u0027VnfLcmOperationOccurrenceNotification\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d536fd51","line":1217,"in_reply_to":"9f560f44_1e3bdbd0","updated":"2020-09-15 08:29:32.000000000","message":"I don\u0027t think so, so it\u0027s better to fix it.\nFrom a code maintenance perspective, you should avoid writing the same process in different ways.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d7410765568e982095e0ab4e27a3ce2ebf254d7c","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"        except Exception as msg:"},{"line_number":1215,"context_line":"            raise Exception(str(msg))"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        # Notification"},{"line_number":1218,"context_line":"        notification \u003d {}"},{"line_number":1219,"context_line":"        notification[\u0027notificationType\u0027] \u003d \\"},{"line_number":1220,"context_line":"            \u0027VnfLcmOperationOccurrenceNotification\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_0cbbc2c3","line":1217,"in_reply_to":"9f560f44_58a0e2f3","updated":"2020-09-23 09:32:53.000000000","message":"I couldn\u0027t understand your coding policy.\nIf the coding here is as expected, does it mean that line 524 should be fixed?\nIf YES, you should fix it with the parent patch.\nI think the coding policy should be unified to either one.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d2cfee352b107c8722ddaeca8aa8064c788f48c9","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"        except Exception as msg:"},{"line_number":1215,"context_line":"            raise Exception(str(msg))"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        # Notification"},{"line_number":1218,"context_line":"        notification \u003d {}"},{"line_number":1219,"context_line":"        notification[\u0027notificationType\u0027] \u003d \\"},{"line_number":1220,"context_line":"            \u0027VnfLcmOperationOccurrenceNotification\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_58a0e2f3","line":1217,"in_reply_to":"9f560f44_d536fd51","updated":"2020-09-22 15:40:06.000000000","message":"There are multiple similar definitions even in places not subject to review, and it may be easier to maintain if defined with one parameter per line rather than collectively, so I would like to keep it as it is.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6d4d4c2120c60659ceaa596bab280555f541825e","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"                raise Exception(str(msg))"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":"        # update lcm_op_occs"},{"line_number":1187,"context_line":"        changed_info \u003d objects.vnf_lcm_op_occs.VnfInfoModifications()"},{"line_number":1188,"context_line":"        changed_info.vnf_instance_name \u003d body_data.get(\u0027vnf_instance_name\u0027)"},{"line_number":1189,"context_line":"        changed_info.vnf_instance_description \u003d body_data.get("},{"line_number":1190,"context_line":"            \u0027vnf_instance_description\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_c19c28c1","line":1187,"range":{"start_line":1187,"start_character":7,"end_line":1187,"end_character":21},"updated":"2020-09-04 08:38:27.000000000","message":"metadata and vimConnectionInfo should be added in changed_info.","commit_id":"b2878ebfb1b78fed515ff8b58de3b8fcaa9e2a43"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"af922482b46a0cdf4499f3a7e2b15162bc752405","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"                raise Exception(str(msg))"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":"        # update lcm_op_occs"},{"line_number":1187,"context_line":"        changed_info \u003d objects.vnf_lcm_op_occs.VnfInfoModifications()"},{"line_number":1188,"context_line":"        changed_info.vnf_instance_name \u003d body_data.get(\u0027vnf_instance_name\u0027)"},{"line_number":1189,"context_line":"        changed_info.vnf_instance_description \u003d body_data.get("},{"line_number":1190,"context_line":"            \u0027vnf_instance_description\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_db7ddeb2","line":1187,"range":{"start_line":1187,"start_character":7,"end_line":1187,"end_character":21},"in_reply_to":"9f560f44_c19c28c1","updated":"2020-09-11 12:21:55.000000000","message":"Added.\nRelated code including other files was also modified.","commit_id":"b2878ebfb1b78fed515ff8b58de3b8fcaa9e2a43"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6d4d4c2120c60659ceaa596bab280555f541825e","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"        changed_info.vnf_instance_name \u003d body_data.get(\u0027vnf_instance_name\u0027)"},{"line_number":1189,"context_line":"        changed_info.vnf_instance_description \u003d body_data.get("},{"line_number":1190,"context_line":"            \u0027vnf_instance_description\u0027)"},{"line_number":1191,"context_line":"        changed_info.vnf_configurable_properties \u003d body_data.get("},{"line_number":1192,"context_line":"            \u0027vnf_configurable_properties\u0027)"},{"line_number":1193,"context_line":"        changed_info.vnfc_info_modifications_delete_ids \u003d body_data.get("},{"line_number":1194,"context_line":"            \u0027vnfc_info_modifications_delete_ids\u0027)"},{"line_number":1195,"context_line":"        if body_data.get(\u0027vnfd_id\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_0172a0ad","line":1192,"range":{"start_line":1191,"start_character":0,"end_line":1192,"end_character":42},"updated":"2020-09-04 08:38:27.000000000","message":"This attribute is not supported in Victoria, so should be removed.","commit_id":"b2878ebfb1b78fed515ff8b58de3b8fcaa9e2a43"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"af922482b46a0cdf4499f3a7e2b15162bc752405","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"        changed_info.vnf_instance_name \u003d body_data.get(\u0027vnf_instance_name\u0027)"},{"line_number":1189,"context_line":"        changed_info.vnf_instance_description \u003d body_data.get("},{"line_number":1190,"context_line":"            \u0027vnf_instance_description\u0027)"},{"line_number":1191,"context_line":"        changed_info.vnf_configurable_properties \u003d body_data.get("},{"line_number":1192,"context_line":"            \u0027vnf_configurable_properties\u0027)"},{"line_number":1193,"context_line":"        changed_info.vnfc_info_modifications_delete_ids \u003d body_data.get("},{"line_number":1194,"context_line":"            \u0027vnfc_info_modifications_delete_ids\u0027)"},{"line_number":1195,"context_line":"        if body_data.get(\u0027vnfd_id\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_e4092895","line":1192,"range":{"start_line":1191,"start_character":0,"end_line":1192,"end_character":42},"in_reply_to":"9f560f44_0172a0ad","updated":"2020-09-11 12:21:55.000000000","message":"Removed.","commit_id":"b2878ebfb1b78fed515ff8b58de3b8fcaa9e2a43"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6d4d4c2120c60659ceaa596bab280555f541825e","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"            \u0027vnf_instance_description\u0027)"},{"line_number":1191,"context_line":"        changed_info.vnf_configurable_properties \u003d body_data.get("},{"line_number":1192,"context_line":"            \u0027vnf_configurable_properties\u0027)"},{"line_number":1193,"context_line":"        changed_info.vnfc_info_modifications_delete_ids \u003d body_data.get("},{"line_number":1194,"context_line":"            \u0027vnfc_info_modifications_delete_ids\u0027)"},{"line_number":1195,"context_line":"        if body_data.get(\u0027vnfd_id\u0027):"},{"line_number":1196,"context_line":"            changed_info.vnfd_id \u003d body_data.get(\u0027vnfd_id\u0027)"},{"line_number":1197,"context_line":"            changed_info.vnf_provider \u003d vnfd_pkg_data.get(\u0027vnf_provider\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_6168bcb9","line":1194,"range":{"start_line":1193,"start_character":8,"end_line":1194,"end_character":49},"updated":"2020-09-04 08:38:27.000000000","message":"ditto","commit_id":"b2878ebfb1b78fed515ff8b58de3b8fcaa9e2a43"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"af922482b46a0cdf4499f3a7e2b15162bc752405","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"            \u0027vnf_instance_description\u0027)"},{"line_number":1191,"context_line":"        changed_info.vnf_configurable_properties \u003d body_data.get("},{"line_number":1192,"context_line":"            \u0027vnf_configurable_properties\u0027)"},{"line_number":1193,"context_line":"        changed_info.vnfc_info_modifications_delete_ids \u003d body_data.get("},{"line_number":1194,"context_line":"            \u0027vnfc_info_modifications_delete_ids\u0027)"},{"line_number":1195,"context_line":"        if body_data.get(\u0027vnfd_id\u0027):"},{"line_number":1196,"context_line":"            changed_info.vnfd_id \u003d body_data.get(\u0027vnfd_id\u0027)"},{"line_number":1197,"context_line":"            changed_info.vnf_provider \u003d vnfd_pkg_data.get(\u0027vnf_provider\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_24004066","line":1194,"range":{"start_line":1193,"start_character":8,"end_line":1194,"end_character":49},"in_reply_to":"9f560f44_6168bcb9","updated":"2020-09-11 12:21:55.000000000","message":"Removed.","commit_id":"b2878ebfb1b78fed515ff8b58de3b8fcaa9e2a43"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"c39d0ff44f2a3d08da8ca30b8cdacbc9f70d0654","unresolved":false,"context_lines":[{"line_number":965,"context_line":"        notification[\u0027operationTypes\u0027] \u003d \u0027MODIFY_INFO\u0027"},{"line_number":966,"context_line":"        notification[\u0027isAutomaticInvocation\u0027] \u003d \u0027False\u0027"},{"line_number":967,"context_line":"        notification[\u0027vnfLcmOpOccId\u0027] \u003d vnf_lcm_opoccs.get(\u0027id\u0027)"},{"line_number":968,"context_line":"        self.send_notification(context, notification)"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        # update vnf_instances"},{"line_number":971,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_88be5a62","line":968,"updated":"2020-09-11 16:24:12.000000000","message":"I think \"_links\" should be added.","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"105e6ce23e620f16a7946d84f50b884cb419aed2","unresolved":false,"context_lines":[{"line_number":965,"context_line":"        notification[\u0027operationTypes\u0027] \u003d \u0027MODIFY_INFO\u0027"},{"line_number":966,"context_line":"        notification[\u0027isAutomaticInvocation\u0027] \u003d \u0027False\u0027"},{"line_number":967,"context_line":"        notification[\u0027vnfLcmOpOccId\u0027] \u003d vnf_lcm_opoccs.get(\u0027id\u0027)"},{"line_number":968,"context_line":"        self.send_notification(context, notification)"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        # update vnf_instances"},{"line_number":971,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_860be1d2","line":968,"in_reply_to":"9f560f44_88be5a62","updated":"2020-09-12 09:49:27.000000000","message":"_links is added.","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"c39d0ff44f2a3d08da8ca30b8cdacbc9f70d0654","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"        notification[\u0027vnfLcmOpOccId\u0027] \u003d vnf_lcm_opoccs.get(\u0027id\u0027)"},{"line_number":1023,"context_line":"        notification[\u0027changed_info\u0027] \u003d changed_info"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"        self.send_notification(context, notification)"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"def init(args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_a8b7de84","line":1025,"updated":"2020-09-11 16:24:12.000000000","message":"I think \"_links\" should be added.","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"105e6ce23e620f16a7946d84f50b884cb419aed2","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"        notification[\u0027vnfLcmOpOccId\u0027] \u003d vnf_lcm_opoccs.get(\u0027id\u0027)"},{"line_number":1023,"context_line":"        notification[\u0027changed_info\u0027] \u003d changed_info"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"        self.send_notification(context, notification)"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"def init(args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_06ffd1aa","line":1025,"in_reply_to":"9f560f44_a8b7de84","updated":"2020-09-12 09:49:27.000000000","message":"_links is added","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"}],"tacker/conductor/conductorrpc/vnf_lcm_rpc.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9efc373489819aaacccdd4308630a8f20dec2662","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                          heal_vnf_request\u003dheal_vnf_request,"},{"line_number":98,"context_line":"                          vnf_lcm_op_occs_id\u003dvnf_lcm_op_occs_id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def update_vnf_instance_content("},{"line_number":101,"context_line":"            self,"},{"line_number":102,"context_line":"            context,"},{"line_number":103,"context_line":"            vnf_lcm_opoccs,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_f6da6c48","line":100,"updated":"2020-08-26 06:21:21.000000000","message":"I think it\u0027s better to use \"update\" with the same name as the existing method.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                          heal_vnf_request\u003dheal_vnf_request,"},{"line_number":98,"context_line":"                          vnf_lcm_op_occs_id\u003dvnf_lcm_op_occs_id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def update_vnf_instance_content("},{"line_number":101,"context_line":"            self,"},{"line_number":102,"context_line":"            context,"},{"line_number":103,"context_line":"            vnf_lcm_opoccs,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_bb0f61de","line":100,"in_reply_to":"9f560f44_f6da6c48","updated":"2020-09-09 10:25:40.000000000","message":"Modified as you suggested.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48d88030e0ada392fae0308553d42f8ae81ed70a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                          vnf_lcm_op_occs_id\u003dvnf_lcm_op_occs_id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def update_vnf_instance_content("},{"line_number":101,"context_line":"            self,"},{"line_number":102,"context_line":"            context,"},{"line_number":103,"context_line":"            vnf_lcm_opoccs,"},{"line_number":104,"context_line":"            body_data,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5d6fcbfb","line":101,"updated":"2020-08-28 02:57:58.000000000","message":"I think it\u0027s too many line breaks.\nIt\u0027s better to unify with other functions.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                          vnf_lcm_op_occs_id\u003dvnf_lcm_op_occs_id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def update_vnf_instance_content("},{"line_number":101,"context_line":"            self,"},{"line_number":102,"context_line":"            context,"},{"line_number":103,"context_line":"            vnf_lcm_opoccs,"},{"line_number":104,"context_line":"            body_data,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_de6b23b6","line":101,"in_reply_to":"9f560f44_5d6fcbfb","updated":"2020-09-09 10:25:40.000000000","message":"Line breaks were reduced.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"}],"tacker/db/db_sqlalchemy/models.py":[{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6dee56948517ff07089ebb8c2c0c1be82a769a07","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return {m.key: m.value for m in self._metadata}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class VnfArtifactMetadata(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":84,"context_line":"        models.TimestampMixin):"},{"line_number":85,"context_line":"    \"\"\"Contains all info about vnf packages artifacts metadata.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    __tablename__ \u003d \u0027vnf_artifact_metadata\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_407a5687","line":84,"range":{"start_line":83,"start_character":0,"end_line":84,"end_character":31},"updated":"2020-08-27 06:32:41.000000000","message":"Is this class needed for modify VNF? seems it is not referred on other modify VNF execution.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return {m.key: m.value for m in self._metadata}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class VnfArtifactMetadata(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":84,"context_line":"        models.TimestampMixin):"},{"line_number":85,"context_line":"    \"\"\"Contains all info about vnf packages artifacts metadata.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    __tablename__ \u003d \u0027vnf_artifact_metadata\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1b948d43","line":84,"range":{"start_line":83,"start_character":0,"end_line":84,"end_character":31},"in_reply_to":"9f560f44_407a5687","updated":"2020-09-09 10:25:40.000000000","message":"Removed due to unnecessary class.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6dee56948517ff07089ebb8c2c0c1be82a769a07","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class VnfArtifact(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":97,"context_line":"        models.TimestampMixin, models_v1.HasId):"},{"line_number":98,"context_line":"    \"\"\"Contains all info about vnf packages artifacts.\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    __tablename__ \u003d \u0027vnf_artifacts\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_8070eea5","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":48},"updated":"2020-08-27 06:32:41.000000000","message":"Is this class needed for modify VNF? seems it is not referred on other modify VNF execution.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class VnfArtifact(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":97,"context_line":"        models.TimestampMixin, models_v1.HasId):"},{"line_number":98,"context_line":"    \"\"\"Contains all info about vnf packages artifacts.\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    __tablename__ \u003d \u0027vnf_artifacts\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_bb84810c","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":48},"in_reply_to":"9f560f44_8070eea5","updated":"2020-09-09 10:25:40.000000000","message":"Removed due to unnecessary class.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6dee56948517ff07089ebb8c2c0c1be82a769a07","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                                      \u0027VnfSoftwareImage.flavour_uuid,\u0027"},{"line_number":133,"context_line":"                                      \u0027VnfSoftwareImage.deleted \u003d\u003d 0)\u0027)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    artifacts \u003d orm.relationship("},{"line_number":136,"context_line":"        VnfArtifact, primaryjoin\u003d\u0027and_(VnfDeploymentFlavour.id \u003d\u003d \u0027"},{"line_number":137,"context_line":"        \u0027VnfArtifact.flavour_uuid,\u0027"},{"line_number":138,"context_line":"        \u0027VnfArtifact.deleted \u003d\u003d 0)\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_206122d4","line":135,"range":{"start_line":135,"start_character":2,"end_line":135,"end_character":13},"updated":"2020-08-27 06:32:41.000000000","message":"Same comment as above.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                                      \u0027VnfSoftwareImage.flavour_uuid,\u0027"},{"line_number":133,"context_line":"                                      \u0027VnfSoftwareImage.deleted \u003d\u003d 0)\u0027)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    artifacts \u003d orm.relationship("},{"line_number":136,"context_line":"        VnfArtifact, primaryjoin\u003d\u0027and_(VnfDeploymentFlavour.id \u003d\u003d \u0027"},{"line_number":137,"context_line":"        \u0027VnfArtifact.flavour_uuid,\u0027"},{"line_number":138,"context_line":"        \u0027VnfArtifact.deleted \u003d\u003d 0)\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5b73a54e","line":135,"range":{"start_line":135,"start_character":2,"end_line":135,"end_character":13},"in_reply_to":"9f560f44_206122d4","updated":"2020-09-09 10:25:40.000000000","message":"Removed.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6dee56948517ff07089ebb8c2c0c1be82a769a07","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    ext_cp_info \u003d sa.Column(sa.JSON(), nullable\u003dFalse)"},{"line_number":238,"context_line":"    ext_virtual_link_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":239,"context_line":"    ext_managed_virtual_link_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":240,"context_line":"    monitoring_parameters \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":241,"context_line":"    localization_language \u003d sa.Column(sa.String(16), nullable\u003dTrue)"},{"line_number":242,"context_line":"    vnfc_resource_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":243,"context_line":"    vnf_virtual_link_resource_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_a07b7278","line":240,"range":{"start_line":240,"start_character":4,"end_line":240,"end_character":25},"updated":"2020-08-27 06:32:41.000000000","message":"This attribute is not supported in Victoria release. Could you remove it?","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    ext_cp_info \u003d sa.Column(sa.JSON(), nullable\u003dFalse)"},{"line_number":238,"context_line":"    ext_virtual_link_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":239,"context_line":"    ext_managed_virtual_link_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":240,"context_line":"    monitoring_parameters \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":241,"context_line":"    localization_language \u003d sa.Column(sa.String(16), nullable\u003dTrue)"},{"line_number":242,"context_line":"    vnfc_resource_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":243,"context_line":"    vnf_virtual_link_resource_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7b930950","line":240,"range":{"start_line":240,"start_character":4,"end_line":240,"end_character":25},"in_reply_to":"9f560f44_a07b7278","updated":"2020-09-09 10:25:40.000000000","message":"Removed.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6dee56948517ff07089ebb8c2c0c1be82a769a07","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    ext_virtual_link_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":239,"context_line":"    ext_managed_virtual_link_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":240,"context_line":"    monitoring_parameters \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":241,"context_line":"    localization_language \u003d sa.Column(sa.String(16), nullable\u003dTrue)"},{"line_number":242,"context_line":"    vnfc_resource_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":243,"context_line":"    vnf_virtual_link_resource_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":244,"context_line":"    virtual_storage_resource_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_807e2e67","line":241,"range":{"start_line":241,"start_character":4,"end_line":241,"end_character":25},"updated":"2020-08-27 06:32:41.000000000","message":"Same comment as above.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    ext_virtual_link_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":239,"context_line":"    ext_managed_virtual_link_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":240,"context_line":"    monitoring_parameters \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":241,"context_line":"    localization_language \u003d sa.Column(sa.String(16), nullable\u003dTrue)"},{"line_number":242,"context_line":"    vnfc_resource_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":243,"context_line":"    vnf_virtual_link_resource_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":244,"context_line":"    virtual_storage_resource_info \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_bb99216e","line":241,"range":{"start_line":241,"start_character":4,"end_line":241,"end_character":25},"in_reply_to":"9f560f44_807e2e67","updated":"2020-09-09 10:25:40.000000000","message":"Removed.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6dee56948517ff07089ebb8c2c0c1be82a769a07","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    vnf_state \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":246,"context_line":"    instance_id \u003d sa.Column(sa.String(255), nullable\u003dTrue)"},{"line_number":247,"context_line":"    instantiation_level_id \u003d sa.Column(sa.String(255), nullable\u003dTrue)"},{"line_number":248,"context_line":"    extensions \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":249,"context_line":"    additional_params \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    vnf_instance \u003d orm.relationship(VnfInstance,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_e098cac0","line":248,"range":{"start_line":248,"start_character":4,"end_line":248,"end_character":14},"updated":"2020-08-27 06:32:41.000000000","message":"Same comment as above.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    vnf_state \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":246,"context_line":"    instance_id \u003d sa.Column(sa.String(255), nullable\u003dTrue)"},{"line_number":247,"context_line":"    instantiation_level_id \u003d sa.Column(sa.String(255), nullable\u003dTrue)"},{"line_number":248,"context_line":"    extensions \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":249,"context_line":"    additional_params \u003d sa.Column(sa.JSON(), nullable\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    vnf_instance \u003d orm.relationship(VnfInstance,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1ba2cd9a","line":248,"range":{"start_line":248,"start_character":4,"end_line":248,"end_character":14},"in_reply_to":"9f560f44_e098cac0","updated":"2020-09-09 10:25:40.000000000","message":"Removed.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"}],"tacker/objects/fields.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48d88030e0ada392fae0308553d42f8ae81ed70a","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    ALL \u003d (ACTIVE, INACTIVE)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"class InstanceOperationalState(BaseTackerEnum):"},{"line_number":229,"context_line":"    STARTING \u003d \u0027STARTING\u0027"},{"line_number":230,"context_line":"    PROCESSING \u003d \u0027PROCESSING\u0027"},{"line_number":231,"context_line":"    COMPLETED \u003d \u0027COMPLETED\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_40fc040c","line":228,"updated":"2020-08-28 02:57:58.000000000","message":"LcmOccsOperationState already exists, is there any reason to define this class newly?","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    ALL \u003d (ACTIVE, INACTIVE)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"class InstanceOperationalState(BaseTackerEnum):"},{"line_number":229,"context_line":"    STARTING \u003d \u0027STARTING\u0027"},{"line_number":230,"context_line":"    PROCESSING \u003d \u0027PROCESSING\u0027"},{"line_number":231,"context_line":"    COMPLETED \u003d \u0027COMPLETED\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5eb43336","line":228,"in_reply_to":"9f560f44_40fc040c","updated":"2020-09-09 10:25:40.000000000","message":"Removed and changed to use existing class.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"}],"tacker/objects/vnf.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9efc373489819aaacccdd4308630a8f20dec2662","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    @base.remotable_classmethod"},{"line_number":90,"context_line":"    def vnf_index_list(cls, id, context):"},{"line_number":91,"context_line":"        # get vnf_instance data"},{"line_number":92,"context_line":"        # expected_attrs \u003d [\"vnf_attribute\",\"vnfd\",\"vnfd_attribute\"]"},{"line_number":93,"context_line":"        expected_attrs \u003d [\"vnf_attribute\", \"vnfd\"]"},{"line_number":94,"context_line":"        db_vnf \u003d _vnf_get(context, id, columns_to_join\u003dexpected_attrs)"},{"line_number":95,"context_line":"        return db_vnf"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_56e998e0","line":92,"updated":"2020-08-26 06:21:21.000000000","message":"I think it\u0027s unnecessary comment out.\nSame for others.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    @base.remotable_classmethod"},{"line_number":90,"context_line":"    def vnf_index_list(cls, id, context):"},{"line_number":91,"context_line":"        # get vnf_instance data"},{"line_number":92,"context_line":"        # expected_attrs \u003d [\"vnf_attribute\",\"vnfd\",\"vnfd_attribute\"]"},{"line_number":93,"context_line":"        expected_attrs \u003d [\"vnf_attribute\", \"vnfd\"]"},{"line_number":94,"context_line":"        db_vnf \u003d _vnf_get(context, id, columns_to_join\u003dexpected_attrs)"},{"line_number":95,"context_line":"        return db_vnf"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_fb1d590f","line":92,"in_reply_to":"9f560f44_56e998e0","updated":"2020-09-09 10:25:40.000000000","message":"Deleted with the others.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"c39d0ff44f2a3d08da8ca30b8cdacbc9f70d0654","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_086d2a31","line":1,"updated":"2020-09-11 16:24:12.000000000","message":"This file seems not needed.","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d2cfee352b107c8722ddaeca8aa8064c788f48c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_18d14a58","line":1,"in_reply_to":"9f560f44_086d2a31","updated":"2020-09-22 15:40:06.000000000","message":"It is used in another process. It is needed.","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"}],"tacker/objects/vnf_artifact.py":[{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"6dee56948517ff07089ebb8c2c0c1be82a769a07","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":82,"context_line":"class VnfArtifact(base.TackerObject, base.TackerPersistentObject):"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    ALL_ATTRIBUTES \u003d {"},{"line_number":85,"context_line":"        \"additionalArtifacts\": {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_20e4823b","line":82,"range":{"start_line":82,"start_character":6,"end_line":82,"end_character":17},"updated":"2020-08-27 06:32:41.000000000","message":"Does Tacker need vnf_artifact.py for modify VNF? seems it is not referred on other modify VNF execution.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":82,"context_line":"class VnfArtifact(base.TackerObject, base.TackerPersistentObject):"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    ALL_ATTRIBUTES \u003d {"},{"line_number":85,"context_line":"        \"additionalArtifacts\": {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_dbadf584","line":82,"range":{"start_line":82,"start_character":6,"end_line":82,"end_character":17},"in_reply_to":"9f560f44_20e4823b","updated":"2020-09-09 10:25:40.000000000","message":"This file is removed due to unnecessary one.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9efc373489819aaacccdd4308630a8f20dec2662","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                                   expected_attrs\u003dexpected_attrs)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _get_user_metadata(self, include_fields\u003dNone):"},{"line_number":215,"context_line":"        # Need special handling for field containing key-value pair."},{"line_number":216,"context_line":"        # If user requests /metadata/key1 and if"},{"line_number":217,"context_line":"        # additionalArtifacts/metadata contains key1\u003dvalue1, key2\u003dvalue2,"},{"line_number":218,"context_line":"        # it should return only keys that are requested in include_fields."}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_7675bc31","line":215,"updated":"2020-08-26 06:21:21.000000000","message":"I understood this comment includes TODO.\nIs it right?\nIf it is right, please add \"# TODO(yourname)\" as shown below.\nhttps://docs.openstack.org/hacking/latest/user/hacking.html","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                                   expected_attrs\u003dexpected_attrs)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _get_user_metadata(self, include_fields\u003dNone):"},{"line_number":215,"context_line":"        # Need special handling for field containing key-value pair."},{"line_number":216,"context_line":"        # If user requests /metadata/key1 and if"},{"line_number":217,"context_line":"        # additionalArtifacts/metadata contains key1\u003dvalue1, key2\u003dvalue2,"},{"line_number":218,"context_line":"        # it should return only keys that are requested in include_fields."}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1bcf6d7f","line":215,"in_reply_to":"9f560f44_7675bc31","updated":"2020-09-09 10:25:40.000000000","message":"This file is removed due to the other comment.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"}],"tacker/objects/vnf_lcm_op_occs.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3593f536a38b18b8c61725332a3a1235577f5d9d","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[]),"},{"line_number":429,"context_line":"        \u0027added_storage_resource_ids\u0027:"},{"line_number":430,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[]),"},{"line_number":431,"context_line":"        \u0027removed_storage_resource_ids\u0027:"},{"line_number":432,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[])"},{"line_number":433,"context_line":"    }"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_71d12acc","line":431,"updated":"2020-08-27 10:26:01.000000000","message":"I think you should fix this typo in patch-746892.\nSame for others.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[]),"},{"line_number":429,"context_line":"        \u0027added_storage_resource_ids\u0027:"},{"line_number":430,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[]),"},{"line_number":431,"context_line":"        \u0027removed_storage_resource_ids\u0027:"},{"line_number":432,"context_line":"            fields.ListOfStringsField(nullable\u003dTrue, default\u003d[])"},{"line_number":433,"context_line":"    }"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_bb35a147","line":431,"in_reply_to":"9f560f44_71d12acc","updated":"2020-09-09 10:25:40.000000000","message":"It will be fixed in the parent patch, but also did in this patch.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"}],"tacker/objects/vnf_package.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3593f536a38b18b8c61725332a3a1235577f5d9d","unresolved":false,"context_lines":[{"line_number":472,"context_line":"            self.id \u003d updates[\u0027id\u0027]"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        for key in [\u0027vnf_deployment_flavours\u0027]:"},{"line_number":475,"context_line":"            if key in updates.keys():"},{"line_number":476,"context_line":"                updates.pop(key)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        user_data \u003d updates.pop(\u0027user_data\u0027, None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3167b227","line":475,"updated":"2020-08-27 10:26:01.000000000","message":"I think the behavior will not change, is this fix needed?","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":472,"context_line":"            self.id \u003d updates[\u0027id\u0027]"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        for key in [\u0027vnf_deployment_flavours\u0027]:"},{"line_number":475,"context_line":"            if key in updates.keys():"},{"line_number":476,"context_line":"                updates.pop(key)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        user_data \u003d updates.pop(\u0027user_data\u0027, None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_dbe5f5a5","line":475,"in_reply_to":"9f560f44_3167b227","updated":"2020-09-09 10:25:40.000000000","message":"The change is reverted.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"}],"tacker/objects/vnf_package_vnfd.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3593f536a38b18b8c61725332a3a1235577f5d9d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            result_line \u003d line"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    except Exception:"},{"line_number":70,"context_line":"        LOG.info(\"select vnf_package_vnfd failed\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if result_line:"},{"line_number":73,"context_line":"        return result_line"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_91431e6c","line":70,"updated":"2020-08-27 10:26:01.000000000","message":"I think it\u0027s better to use LOG.error.\nSame for others.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            result_line \u003d line"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    except Exception:"},{"line_number":70,"context_line":"        LOG.info(\"select vnf_package_vnfd failed\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if result_line:"},{"line_number":73,"context_line":"        return result_line"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3bf6b15e","line":70,"in_reply_to":"9f560f44_91431e6c","updated":"2020-09-09 10:25:40.000000000","message":"Changed with the others.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"}],"tacker/objects/vnfd.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"c39d0ff44f2a3d08da8ca30b8cdacbc9f70d0654","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_c8cdf230","line":1,"updated":"2020-09-11 16:24:12.000000000","message":"This file seems not needed.","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d2cfee352b107c8722ddaeca8aa8064c788f48c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_78d8467e","line":1,"in_reply_to":"9f560f44_c8cdf230","updated":"2020-09-22 15:40:06.000000000","message":"It is used in another process. It is needed.","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"}],"tacker/objects/vnfd_attribute.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"c39d0ff44f2a3d08da8ca30b8cdacbc9f70d0654","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_88c77a12","line":1,"updated":"2020-09-11 16:24:12.000000000","message":"This file seems not needed.","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"105e6ce23e620f16a7946d84f50b884cb419aed2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_4662693f","line":1,"in_reply_to":"9f560f44_88c77a12","updated":"2020-09-12 09:49:27.000000000","message":"It is removed.","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"}],"tacker/tests/unit/conductor/fakes.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3593f536a38b18b8c61725332a3a1235577f5d9d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import iso8601"},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import shutil"},{"line_number":20,"context_line":"from tacker.db.db_sqlalchemy import models"},{"line_number":21,"context_line":"from tacker import objects"},{"line_number":22,"context_line":"from tacker.objects import fields"},{"line_number":23,"context_line":"from tacker.tests import constants"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_f1fffafe","line":20,"updated":"2020-08-27 10:26:01.000000000","message":"This import should move to line 31.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import iso8601"},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import shutil"},{"line_number":20,"context_line":"from tacker.db.db_sqlalchemy import models"},{"line_number":21,"context_line":"from tacker import objects"},{"line_number":22,"context_line":"from tacker.objects import fields"},{"line_number":23,"context_line":"from tacker.tests import constants"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1b880dc4","line":20,"in_reply_to":"9f560f44_f1fffafe","updated":"2020-09-09 10:25:40.000000000","message":"Moved.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"}],"tacker/tests/unit/conductor/test_conductor_server.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3593f536a38b18b8c61725332a3a1235577f5d9d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            \u0027vnf_instance_id\u0027: uuidsentinel.vnf_instance_id,"},{"line_number":135,"context_line":"            \u0027id\u0027: uuidsentinel.id,"},{"line_number":136,"context_line":"            \u0027state_entered_time\u0027: datetime.datetime("},{"line_number":137,"context_line":"                1900,"},{"line_number":138,"context_line":"                1,"},{"line_number":139,"context_line":"                1,"},{"line_number":140,"context_line":"                1,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_cc133d5b","line":137,"updated":"2020-08-27 10:26:01.000000000","message":"I think you need not line breaks.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            \u0027vnf_instance_id\u0027: uuidsentinel.vnf_instance_id,"},{"line_number":135,"context_line":"            \u0027id\u0027: uuidsentinel.id,"},{"line_number":136,"context_line":"            \u0027state_entered_time\u0027: datetime.datetime("},{"line_number":137,"context_line":"                1900,"},{"line_number":138,"context_line":"                1,"},{"line_number":139,"context_line":"                1,"},{"line_number":140,"context_line":"                1,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5ba72551","line":137,"in_reply_to":"9f560f44_cc133d5b","updated":"2020-09-09 10:25:40.000000000","message":"Modified so as not to use line breaks.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"}],"tacker/tests/unit/objects/test_vnf_lcm_op_occs.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"48d88030e0ada392fae0308553d42f8ae81ed70a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestVnfLcmOpOcc(SqlTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(TestVnfLcmOpOcc, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_9dca0344","line":21,"updated":"2020-08-28 02:57:58.000000000","message":"I think you should move this test file to patch-746892.\nThis is because vnf_lcm_op_occs.py is new code added in patch-746892.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"38b0653b8cef2580762748898b0d56934e0d8186","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestVnfLcmOpOcc(SqlTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def setUp(self):"},{"line_number":24,"context_line":"        super(TestVnfLcmOpOcc, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_9e836b56","line":21,"in_reply_to":"9f560f44_9dca0344","updated":"2020-09-09 10:25:40.000000000","message":"Removed from this patch.","commit_id":"3c950632f52f24eedf6ba0aa3c7f949837957871"}],"tacker/tests/unit/vnflcm/test_controller.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"c39d0ff44f2a3d08da8ca30b8cdacbc9f70d0654","unresolved":false,"context_lines":[{"line_number":1456,"context_line":"        # Call Instantiate API"},{"line_number":1457,"context_line":"        resp \u003d req.get_response(self.app)"},{"line_number":1458,"context_line":"        print(resp)"},{"line_number":1459,"context_line":"        self.assertEqual(http_client.OK, resp.status_code)"},{"line_number":1460,"context_line":"        mock_update.assert_called_once()"},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_a89ebe02","line":1459,"range":{"start_line":1459,"start_character":25,"end_line":1459,"end_character":39},"updated":"2020-09-11 16:24:12.000000000","message":"I think \"http_client.ACCEPTED\" is better here.","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"105e6ce23e620f16a7946d84f50b884cb419aed2","unresolved":false,"context_lines":[{"line_number":1456,"context_line":"        # Call Instantiate API"},{"line_number":1457,"context_line":"        resp \u003d req.get_response(self.app)"},{"line_number":1458,"context_line":"        print(resp)"},{"line_number":1459,"context_line":"        self.assertEqual(http_client.OK, resp.status_code)"},{"line_number":1460,"context_line":"        mock_update.assert_called_once()"},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_86d92157","line":1459,"range":{"start_line":1459,"start_character":25,"end_line":1459,"end_character":39},"in_reply_to":"9f560f44_a89ebe02","updated":"2020-09-12 09:49:27.000000000","message":"modified to http_client.ACCEPTED","commit_id":"0681f469772b10417a8ca34e7aa8d3b53f9f38e7"}]}