)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":11,"context_line":"   Healing"},{"line_number":12,"context_line":"   Scaling"},{"line_number":13,"context_line":"   Termination"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I47a6a995dc25256eb1bd10f2e03a1f810fdb3f69"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_0c99de1d","line":14,"updated":"2020-09-10 18:27:27.000000000","message":"Please add `Implements` tag for your bp.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"   Healing"},{"line_number":12,"context_line":"   Scaling"},{"line_number":13,"context_line":"   Termination"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I47a6a995dc25256eb1bd10f2e03a1f810fdb3f69"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_99c1e951","line":14,"in_reply_to":"9f560f44_0c99de1d","updated":"2020-09-22 09:01:16.000000000","message":"added implements tag","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31902,"name":"Makoto Hamada","email":"makoto.hamada.xu@hco.ntt.co.jp","username":"makoto-h"},"change_message_id":"cfa579b7046d62c0bb2b7c85c1ed99e88fc7f08c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-15 03:37:23 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support for grant request with Synchronous response"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Supported grant for the following sequences:"},{"line_number":10,"context_line":"   Instantiation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_3333d1f8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":51},"updated":"2020-09-18 02:01:13.000000000","message":"Is this patch related to the spec of \"Support ETSI NFV SOL003 to interoperate with 3rd-party NFVO\"？\nI think the topic of this patch should be set \u0027bp/support-vnfm-operations\u0027.","commit_id":"5987ec6ed7bcb4014f282932415285e42033d2c1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"29636d6058ae0aad12d4c1496528c40ab6a3f9cf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aldinson Esto \u003cesto.aln@nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-15 03:37:23 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support for grant request with Synchronous response"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Supported grant for the following sequences:"},{"line_number":10,"context_line":"   Instantiation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_0d6e0a2b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":51},"in_reply_to":"9f560f44_3333d1f8","updated":"2020-09-24 00:45:46.000000000","message":"It is set as suggested.","commit_id":"5987ec6ed7bcb4014f282932415285e42033d2c1"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"_INACTIVE_STATUS \u003d (constants.INACTIVE)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"_PENDING_STATUS \u003d ("},{"line_number":109,"context_line":"    constants.PENDING_UPDATE,"},{"line_number":110,"context_line":"    constants.PENDING_CREATE"},{"line_number":111,"context_line":")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_040a971e","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":15},"updated":"2020-09-07 10:02:28.000000000","message":"I think \u0027_PENDING_STATUSES\u0027 is better.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"43eb3112ba614b58ba1c49a7573f2aa5644d8467","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"_INACTIVE_STATUS \u003d (constants.INACTIVE)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"_PENDING_STATUS \u003d ("},{"line_number":109,"context_line":"    constants.PENDING_UPDATE,"},{"line_number":110,"context_line":"    constants.PENDING_CREATE"},{"line_number":111,"context_line":")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_492931f0","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":15},"in_reply_to":"9f560f44_040a971e","updated":"2020-09-23 01:21:41.000000000","message":"Please check this comment.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"2a4cc7190c226b2894132b009730942f10c47333","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"_INACTIVE_STATUS \u003d (constants.INACTIVE)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"_PENDING_STATUS \u003d ("},{"line_number":109,"context_line":"    constants.PENDING_UPDATE,"},{"line_number":110,"context_line":"    constants.PENDING_CREATE"},{"line_number":111,"context_line":")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_04841c5d","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":15},"in_reply_to":"9f560f44_492931f0","updated":"2020-09-24 11:36:13.000000000","message":"We think it\u0027s better to use _PENDING_STATUS since only 1 status will be shown among the list.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                    notification[\u0027_links\u0027][\u0027vnfInstance\u0027][\u0027href\u0027] \u003d instaUrl"},{"line_number":209,"context_line":"                    notification[\u0027_links\u0027][\u0027vnfLcmOpOcc\u0027] \u003d {}"},{"line_number":210,"context_line":"                    notification[\u0027_links\u0027][\u0027vnfLcmOpOcc\u0027][\u0027href\u0027] \u003d vnflcmUrl"},{"line_number":211,"context_line":"                    self.sendNotification(context, notification)"},{"line_number":212,"context_line":"                except Exception as e:"},{"line_number":213,"context_line":"                    LOG.warning(\"Failed notification for vnf \""},{"line_number":214,"context_line":"                                \"instance %(id)s. Error: %(error)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0d6ffc5f","line":211,"updated":"2020-09-11 15:52:30.000000000","message":"Function names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                    notification[\u0027_links\u0027][\u0027vnfInstance\u0027][\u0027href\u0027] \u003d instaUrl"},{"line_number":209,"context_line":"                    notification[\u0027_links\u0027][\u0027vnfLcmOpOcc\u0027] \u003d {}"},{"line_number":210,"context_line":"                    notification[\u0027_links\u0027][\u0027vnfLcmOpOcc\u0027][\u0027href\u0027] \u003d vnflcmUrl"},{"line_number":211,"context_line":"                    self.sendNotification(context, notification)"},{"line_number":212,"context_line":"                except Exception as e:"},{"line_number":213,"context_line":"                    LOG.warning(\"Failed notification for vnf \""},{"line_number":214,"context_line":"                                \"instance %(id)s. Error: %(error)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_59fb5614","line":211,"in_reply_to":"9f560f44_0d6ffc5f","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        if not self._get_glant_execute():"},{"line_number":816,"context_line":"            return"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"        addResources \u003d []"},{"line_number":819,"context_line":"        vnf_inf \u003d vnf_instance.instantiated_vnf_info"},{"line_number":820,"context_line":"        for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":821,"context_line":"            resource \u003d objects.ResourceDefinition()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6db838c7","line":818,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        if not self._get_glant_execute():"},{"line_number":816,"context_line":"            return"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"        addResources \u003d []"},{"line_number":819,"context_line":"        vnf_inf \u003d vnf_instance.instantiated_vnf_info"},{"line_number":820,"context_line":"        for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":821,"context_line":"            resource \u003d objects.ResourceDefinition()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_39294289","line":818,"in_reply_to":"9f560f44_6db838c7","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":820,"context_line":"        for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":821,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":822,"context_line":"            resource.id \u003d vnfc_resource.id"},{"line_number":823,"context_line":"            resource.type \u003d \u0027COMPUTE\u0027"},{"line_number":824,"context_line":"            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":825,"context_line":"            resource.resource_template_id \u003d vnfc_resource.vdu_id"},{"line_number":826,"context_line":"            addResources.append(resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_db82f1c6","line":823,"range":{"start_line":823,"start_character":28,"end_line":823,"end_character":37},"updated":"2020-09-10 18:27:27.000000000","message":"It’s better to make such a keyword to `constants` like as L.268 or so.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":820,"context_line":"        for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":821,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":822,"context_line":"            resource.id \u003d vnfc_resource.id"},{"line_number":823,"context_line":"            resource.type \u003d \u0027COMPUTE\u0027"},{"line_number":824,"context_line":"            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":825,"context_line":"            resource.resource_template_id \u003d vnfc_resource.vdu_id"},{"line_number":826,"context_line":"            addResources.append(resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3520a3b0","line":823,"range":{"start_line":823,"start_character":28,"end_line":823,"end_character":37},"in_reply_to":"9f560f44_db82f1c6","updated":"2020-09-22 09:01:16.000000000","message":"Made the definition common (applied the same definition to openstack.py)","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":823,"context_line":"            resource.type \u003d \u0027COMPUTE\u0027"},{"line_number":824,"context_line":"            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":825,"context_line":"            resource.resource_template_id \u003d vnfc_resource.vdu_id"},{"line_number":826,"context_line":"            addResources.append(resource)"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        for vl_resource in vnf_inf.vnf_virtual_link_resource_info:"},{"line_number":829,"context_line":"            resource \u003d objects.ResourceDefinition()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4dbbb4c2","line":826,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":823,"context_line":"            resource.type \u003d \u0027COMPUTE\u0027"},{"line_number":824,"context_line":"            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":825,"context_line":"            resource.resource_template_id \u003d vnfc_resource.vdu_id"},{"line_number":826,"context_line":"            addResources.append(resource)"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        for vl_resource in vnf_inf.vnf_virtual_link_resource_info:"},{"line_number":829,"context_line":"            resource \u003d objects.ResourceDefinition()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f92eaa8a","line":826,"in_reply_to":"9f560f44_4dbbb4c2","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        for vl_resource in vnf_inf.vnf_virtual_link_resource_info:"},{"line_number":829,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":830,"context_line":"            resource.id \u003d vl_resource.id"},{"line_number":831,"context_line":"            resource.type \u003d \u0027VL\u0027"},{"line_number":832,"context_line":"            resource.resource_template_id \u003d \\"},{"line_number":833,"context_line":"                vl_resource.vnf_virtual_link_desc_id"},{"line_number":834,"context_line":"            addResources.append(resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1b68e91e","line":831,"range":{"start_line":831,"start_character":28,"end_line":831,"end_character":32},"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        for vl_resource in vnf_inf.vnf_virtual_link_resource_info:"},{"line_number":829,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":830,"context_line":"            resource.id \u003d vl_resource.id"},{"line_number":831,"context_line":"            resource.type \u003d \u0027VL\u0027"},{"line_number":832,"context_line":"            resource.resource_template_id \u003d \\"},{"line_number":833,"context_line":"                vl_resource.vnf_virtual_link_desc_id"},{"line_number":834,"context_line":"            addResources.append(resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9529af9d","line":831,"range":{"start_line":831,"start_character":28,"end_line":831,"end_character":32},"in_reply_to":"9f560f44_1b68e91e","updated":"2020-09-22 09:01:16.000000000","message":"To Common Definition","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":831,"context_line":"            resource.type \u003d \u0027VL\u0027"},{"line_number":832,"context_line":"            resource.resource_template_id \u003d \\"},{"line_number":833,"context_line":"                vl_resource.vnf_virtual_link_desc_id"},{"line_number":834,"context_line":"            addResources.append(resource)"},{"line_number":835,"context_line":"            for cp_resource in vl_resource.vnf_link_ports:"},{"line_number":836,"context_line":"                for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":837,"context_line":"                    for vnfc_cp_resource in vnfc_resource.vnfc_cp_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6dddd812","line":834,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":831,"context_line":"            resource.type \u003d \u0027VL\u0027"},{"line_number":832,"context_line":"            resource.resource_template_id \u003d \\"},{"line_number":833,"context_line":"                vl_resource.vnf_virtual_link_desc_id"},{"line_number":834,"context_line":"            addResources.append(resource)"},{"line_number":835,"context_line":"            for cp_resource in vl_resource.vnf_link_ports:"},{"line_number":836,"context_line":"                for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":837,"context_line":"                    for vnfc_cp_resource in vnfc_resource.vnfc_cp_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_394e626e","line":834,"in_reply_to":"9f560f44_6dddd812","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":838,"context_line":"                        if cp_resource.cp_instance_id \u003d\u003d vnfc_cp_resource.id:"},{"line_number":839,"context_line":"                            resource \u003d objects.ResourceDefinition()"},{"line_number":840,"context_line":"                            resource.id \u003d cp_resource.id"},{"line_number":841,"context_line":"                            resource.type \u003d \u0027LINKPORT\u0027"},{"line_number":842,"context_line":"                            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":843,"context_line":"                            resource.resource_template_id \u003d \\"},{"line_number":844,"context_line":"                                vnfc_cp_resource.cpd_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7b73e516","line":841,"range":{"start_line":841,"start_character":44,"end_line":841,"end_character":54},"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":838,"context_line":"                        if cp_resource.cp_instance_id \u003d\u003d vnfc_cp_resource.id:"},{"line_number":839,"context_line":"                            resource \u003d objects.ResourceDefinition()"},{"line_number":840,"context_line":"                            resource.id \u003d cp_resource.id"},{"line_number":841,"context_line":"                            resource.type \u003d \u0027LINKPORT\u0027"},{"line_number":842,"context_line":"                            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":843,"context_line":"                            resource.resource_template_id \u003d \\"},{"line_number":844,"context_line":"                                vnfc_cp_resource.cpd_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_75269bcd","line":841,"range":{"start_line":841,"start_character":44,"end_line":841,"end_character":54},"in_reply_to":"9f560f44_7b73e516","updated":"2020-09-22 09:01:16.000000000","message":"To Common Definition","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":842,"context_line":"                            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":843,"context_line":"                            resource.resource_template_id \u003d \\"},{"line_number":844,"context_line":"                                vnfc_cp_resource.cpd_id"},{"line_number":845,"context_line":"                            addResources.append(resource)"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"        for storage_resource in vnf_inf.virtual_storage_resource_info:"},{"line_number":848,"context_line":"            for vnfc_resource in vnf_inf.vnfc_resource_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ade370d7","line":845,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":842,"context_line":"                            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":843,"context_line":"                            resource.resource_template_id \u003d \\"},{"line_number":844,"context_line":"                                vnfc_cp_resource.cpd_id"},{"line_number":845,"context_line":"                            addResources.append(resource)"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"        for storage_resource in vnf_inf.virtual_storage_resource_info:"},{"line_number":848,"context_line":"            for vnfc_resource in vnf_inf.vnfc_resource_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7958da30","line":845,"in_reply_to":"9f560f44_ade370d7","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":849,"context_line":"                if storage_resource.id in vnfc_resource.storage_resource_ids:"},{"line_number":850,"context_line":"                    resource \u003d objects.ResourceDefinition()"},{"line_number":851,"context_line":"                    resource.id \u003d storage_resource.id"},{"line_number":852,"context_line":"                    resource.type \u003d \u0027STORAGE\u0027"},{"line_number":853,"context_line":"                    resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":854,"context_line":"                    resource.resource_template_id \u003d \\"},{"line_number":855,"context_line":"                        storage_resource.virtual_storage_desc_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9b651948","line":852,"range":{"start_line":852,"start_character":36,"end_line":852,"end_character":45},"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":849,"context_line":"                if storage_resource.id in vnfc_resource.storage_resource_ids:"},{"line_number":850,"context_line":"                    resource \u003d objects.ResourceDefinition()"},{"line_number":851,"context_line":"                    resource.id \u003d storage_resource.id"},{"line_number":852,"context_line":"                    resource.type \u003d \u0027STORAGE\u0027"},{"line_number":853,"context_line":"                    resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":854,"context_line":"                    resource.resource_template_id \u003d \\"},{"line_number":855,"context_line":"                        storage_resource.virtual_storage_desc_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d5184785","line":852,"range":{"start_line":852,"start_character":36,"end_line":852,"end_character":45},"in_reply_to":"9f560f44_9b651948","updated":"2020-09-22 09:01:16.000000000","message":"To Common Definition","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        if not self._get_glant_execute():"},{"line_number":816,"context_line":"            return"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"        addResources \u003d []"},{"line_number":819,"context_line":"        vnf_inf \u003d vnf_instance.instantiated_vnf_info"},{"line_number":820,"context_line":"        for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":821,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":822,"context_line":"            resource.id \u003d vnfc_resource.id"},{"line_number":823,"context_line":"            resource.type \u003d \u0027COMPUTE\u0027"},{"line_number":824,"context_line":"            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":825,"context_line":"            resource.resource_template_id \u003d vnfc_resource.vdu_id"},{"line_number":826,"context_line":"            addResources.append(resource)"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        for vl_resource in vnf_inf.vnf_virtual_link_resource_info:"},{"line_number":829,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":830,"context_line":"            resource.id \u003d vl_resource.id"},{"line_number":831,"context_line":"            resource.type \u003d \u0027VL\u0027"},{"line_number":832,"context_line":"            resource.resource_template_id \u003d \\"},{"line_number":833,"context_line":"                vl_resource.vnf_virtual_link_desc_id"},{"line_number":834,"context_line":"            addResources.append(resource)"},{"line_number":835,"context_line":"            for cp_resource in vl_resource.vnf_link_ports:"},{"line_number":836,"context_line":"                for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":837,"context_line":"                    for vnfc_cp_resource in vnfc_resource.vnfc_cp_info:"},{"line_number":838,"context_line":"                        if cp_resource.cp_instance_id \u003d\u003d vnfc_cp_resource.id:"},{"line_number":839,"context_line":"                            resource \u003d objects.ResourceDefinition()"},{"line_number":840,"context_line":"                            resource.id \u003d cp_resource.id"},{"line_number":841,"context_line":"                            resource.type \u003d \u0027LINKPORT\u0027"},{"line_number":842,"context_line":"                            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":843,"context_line":"                            resource.resource_template_id \u003d \\"},{"line_number":844,"context_line":"                                vnfc_cp_resource.cpd_id"},{"line_number":845,"context_line":"                            addResources.append(resource)"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"        for storage_resource in vnf_inf.virtual_storage_resource_info:"},{"line_number":848,"context_line":"            for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":849,"context_line":"                if storage_resource.id in vnfc_resource.storage_resource_ids:"},{"line_number":850,"context_line":"                    resource \u003d objects.ResourceDefinition()"},{"line_number":851,"context_line":"                    resource.id \u003d storage_resource.id"},{"line_number":852,"context_line":"                    resource.type \u003d \u0027STORAGE\u0027"},{"line_number":853,"context_line":"                    resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":854,"context_line":"                    resource.resource_template_id \u003d \\"},{"line_number":855,"context_line":"                        storage_resource.virtual_storage_desc_id"},{"line_number":856,"context_line":"                    addResources.append(resource)"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        p_c_list \u003d []"},{"line_number":859,"context_line":"        placement_obj_list \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_44c80f54","line":856,"range":{"start_line":818,"start_character":0,"end_line":856,"end_character":49},"updated":"2020-09-07 10:02:28.000000000","message":"It looks like the following code contains similar processing. \nIs it possible to commonize the processing?\n_instantiate_grant\n_heal_grant\n_terminate_grant","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":853,"context_line":"                    resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":854,"context_line":"                    resource.resource_template_id \u003d \\"},{"line_number":855,"context_line":"                        storage_resource.virtual_storage_desc_id"},{"line_number":856,"context_line":"                    addResources.append(resource)"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        p_c_list \u003d []"},{"line_number":859,"context_line":"        placement_obj_list \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4d09f492","line":856,"range":{"start_line":856,"start_character":20,"end_line":856,"end_character":32},"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e264f2e7657db8b407f9b4c35454a2444396a6ca","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        if not self._get_glant_execute():"},{"line_number":816,"context_line":"            return"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"        addResources \u003d []"},{"line_number":819,"context_line":"        vnf_inf \u003d vnf_instance.instantiated_vnf_info"},{"line_number":820,"context_line":"        for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":821,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":822,"context_line":"            resource.id \u003d vnfc_resource.id"},{"line_number":823,"context_line":"            resource.type \u003d \u0027COMPUTE\u0027"},{"line_number":824,"context_line":"            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":825,"context_line":"            resource.resource_template_id \u003d vnfc_resource.vdu_id"},{"line_number":826,"context_line":"            addResources.append(resource)"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        for vl_resource in vnf_inf.vnf_virtual_link_resource_info:"},{"line_number":829,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":830,"context_line":"            resource.id \u003d vl_resource.id"},{"line_number":831,"context_line":"            resource.type \u003d \u0027VL\u0027"},{"line_number":832,"context_line":"            resource.resource_template_id \u003d \\"},{"line_number":833,"context_line":"                vl_resource.vnf_virtual_link_desc_id"},{"line_number":834,"context_line":"            addResources.append(resource)"},{"line_number":835,"context_line":"            for cp_resource in vl_resource.vnf_link_ports:"},{"line_number":836,"context_line":"                for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":837,"context_line":"                    for vnfc_cp_resource in vnfc_resource.vnfc_cp_info:"},{"line_number":838,"context_line":"                        if cp_resource.cp_instance_id \u003d\u003d vnfc_cp_resource.id:"},{"line_number":839,"context_line":"                            resource \u003d objects.ResourceDefinition()"},{"line_number":840,"context_line":"                            resource.id \u003d cp_resource.id"},{"line_number":841,"context_line":"                            resource.type \u003d \u0027LINKPORT\u0027"},{"line_number":842,"context_line":"                            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":843,"context_line":"                            resource.resource_template_id \u003d \\"},{"line_number":844,"context_line":"                                vnfc_cp_resource.cpd_id"},{"line_number":845,"context_line":"                            addResources.append(resource)"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"        for storage_resource in vnf_inf.virtual_storage_resource_info:"},{"line_number":848,"context_line":"            for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":849,"context_line":"                if storage_resource.id in vnfc_resource.storage_resource_ids:"},{"line_number":850,"context_line":"                    resource \u003d objects.ResourceDefinition()"},{"line_number":851,"context_line":"                    resource.id \u003d storage_resource.id"},{"line_number":852,"context_line":"                    resource.type \u003d \u0027STORAGE\u0027"},{"line_number":853,"context_line":"                    resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":854,"context_line":"                    resource.resource_template_id \u003d \\"},{"line_number":855,"context_line":"                        storage_resource.virtual_storage_desc_id"},{"line_number":856,"context_line":"                    addResources.append(resource)"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        p_c_list \u003d []"},{"line_number":859,"context_line":"        placement_obj_list \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1741cb36","line":856,"range":{"start_line":818,"start_character":0,"end_line":856,"end_character":49},"in_reply_to":"9f560f44_44c80f54","updated":"2020-09-25 17:00:53.000000000","message":"Similar but the content is different. So, I want to leave as is.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":853,"context_line":"                    resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":854,"context_line":"                    resource.resource_template_id \u003d \\"},{"line_number":855,"context_line":"                        storage_resource.virtual_storage_desc_id"},{"line_number":856,"context_line":"                    addResources.append(resource)"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        p_c_list \u003d []"},{"line_number":859,"context_line":"        placement_obj_list \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f9434a3e","line":856,"range":{"start_line":856,"start_character":20,"end_line":856,"end_character":32},"in_reply_to":"9f560f44_4d09f492","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":912,"context_line":"                                             vnf_lcm_op_occ_id,"},{"line_number":913,"context_line":"                                             \u0027INSTANTIATE\u0027,"},{"line_number":914,"context_line":"                                             False,"},{"line_number":915,"context_line":"                                             add_resources\u003daddResources,"},{"line_number":916,"context_line":"                                             placement_constraints\u003dp_c_list)"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"        vnf_dict[\u0027placement_obj_list\u0027] \u003d placement_obj_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_edf9e87f","line":915,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":912,"context_line":"                                             vnf_lcm_op_occ_id,"},{"line_number":913,"context_line":"                                             \u0027INSTANTIATE\u0027,"},{"line_number":914,"context_line":"                                             False,"},{"line_number":915,"context_line":"                                             add_resources\u003daddResources,"},{"line_number":916,"context_line":"                                             placement_constraints\u003dp_c_list)"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"        vnf_dict[\u0027placement_obj_list\u0027] \u003d placement_obj_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_996cced1","line":915,"in_reply_to":"9f560f44_edf9e87f","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"        vnf_instantiated_info_after \u003d copy.deepcopy(vnf_inf)"},{"line_number":1025,"context_line":"        del_cre_vdu_list \u003d []"},{"line_number":1026,"context_line":"        addResources \u003d []"},{"line_number":1027,"context_line":"        rmResources \u003d []"},{"line_number":1028,"context_line":"        affinity_list \u003d []"},{"line_number":1029,"context_line":"        for vnfc_resource in vnf_instantiated_info_after.vnfc_resource_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_bb8a9d17","line":1026,"updated":"2020-09-10 18:27:27.000000000","message":"Is there any reason for using camel case only this two lines? Or it\u0027s better to use snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"        vnf_instantiated_info_after \u003d copy.deepcopy(vnf_inf)"},{"line_number":1025,"context_line":"        del_cre_vdu_list \u003d []"},{"line_number":1026,"context_line":"        addResources \u003d []"},{"line_number":1027,"context_line":"        rmResources \u003d []"},{"line_number":1028,"context_line":"        affinity_list \u003d []"},{"line_number":1029,"context_line":"        for vnfc_resource in vnf_instantiated_info_after.vnfc_resource_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_550c3741","line":1026,"in_reply_to":"9f560f44_bb8a9d17","updated":"2020-09-22 09:01:16.000000000","message":"fixed.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"            if vnfc_resource.vdu_id in del_cre_vdu_list:"},{"line_number":1037,"context_line":"                resource \u003d objects.ResourceDefinition()"},{"line_number":1038,"context_line":"                resource.id \u003d vnfc_resource.id"},{"line_number":1039,"context_line":"                resource.type \u003d \u0027COMPUTE\u0027"},{"line_number":1040,"context_line":"                resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1041,"context_line":"                resource.resource_template_id \u003d vnfc_resource.vdu_id"},{"line_number":1042,"context_line":"                vim_id \u003d vnfc_resource.compute_resource.vim_connection_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7b4c85c7","line":1039,"range":{"start_line":1039,"start_character":32,"end_line":1039,"end_character":41},"updated":"2020-09-10 18:27:27.000000000","message":"It’s better to make such a keyword to `constants` like as L.268 or so.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"            if vnfc_resource.vdu_id in del_cre_vdu_list:"},{"line_number":1037,"context_line":"                resource \u003d objects.ResourceDefinition()"},{"line_number":1038,"context_line":"                resource.id \u003d vnfc_resource.id"},{"line_number":1039,"context_line":"                resource.type \u003d \u0027COMPUTE\u0027"},{"line_number":1040,"context_line":"                resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1041,"context_line":"                resource.resource_template_id \u003d vnfc_resource.vdu_id"},{"line_number":1042,"context_line":"                vim_id \u003d vnfc_resource.compute_resource.vim_connection_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3509c330","line":1039,"range":{"start_line":1039,"start_character":32,"end_line":1039,"end_character":41},"in_reply_to":"9f560f44_7b4c85c7","updated":"2020-09-22 09:01:16.000000000","message":"To common definition.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"                add_uuid \u003d uuidutils.generate_uuid()"},{"line_number":1050,"context_line":"                resource \u003d objects.ResourceDefinition()"},{"line_number":1051,"context_line":"                resource.id \u003d add_uuid"},{"line_number":1052,"context_line":"                resource.type \u003d \u0027COMPUTE\u0027"},{"line_number":1053,"context_line":"                resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1054,"context_line":"                resource.resource_template_id \u003d vnfc_resource.vdu_id"},{"line_number":1055,"context_line":"                addResources.append(resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_bbc73d12","line":1052,"range":{"start_line":1052,"start_character":32,"end_line":1052,"end_character":41},"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"                add_uuid \u003d uuidutils.generate_uuid()"},{"line_number":1050,"context_line":"                resource \u003d objects.ResourceDefinition()"},{"line_number":1051,"context_line":"                resource.id \u003d add_uuid"},{"line_number":1052,"context_line":"                resource.type \u003d \u0027COMPUTE\u0027"},{"line_number":1053,"context_line":"                resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1054,"context_line":"                resource.resource_template_id \u003d vnfc_resource.vdu_id"},{"line_number":1055,"context_line":"                addResources.append(resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_95024f0b","line":1052,"range":{"start_line":1052,"start_character":32,"end_line":1052,"end_character":41},"in_reply_to":"9f560f44_bbc73d12","updated":"2020-09-22 09:01:16.000000000","message":"To common definition.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"                    if storage_resource.id in id_list:"},{"line_number":1082,"context_line":"                        resource \u003d objects.ResourceDefinition()"},{"line_number":1083,"context_line":"                        resource.id \u003d storage_resource.id"},{"line_number":1084,"context_line":"                        resource.type \u003d \u0027STORAGE\u0027"},{"line_number":1085,"context_line":"                        resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1086,"context_line":"                        resource.resource_template_id \u003d \\"},{"line_number":1087,"context_line":"                            storage_resource.virtual_storage_desc_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_fbcd3530","line":1084,"range":{"start_line":1084,"start_character":40,"end_line":1084,"end_character":49},"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"                    if storage_resource.id in id_list:"},{"line_number":1082,"context_line":"                        resource \u003d objects.ResourceDefinition()"},{"line_number":1083,"context_line":"                        resource.id \u003d storage_resource.id"},{"line_number":1084,"context_line":"                        resource.type \u003d \u0027STORAGE\u0027"},{"line_number":1085,"context_line":"                        resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1086,"context_line":"                        resource.resource_template_id \u003d \\"},{"line_number":1087,"context_line":"                            storage_resource.virtual_storage_desc_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_75ffbb01","line":1084,"range":{"start_line":1084,"start_character":40,"end_line":1084,"end_character":49},"in_reply_to":"9f560f44_fbcd3530","updated":"2020-09-22 09:01:16.000000000","message":"To common definition.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                        resource \u003d objects.ResourceDefinition()"},{"line_number":1098,"context_line":"                        resource \u003d objects.ResourceDefinition()"},{"line_number":1099,"context_line":"                        resource.id \u003d add_uuid"},{"line_number":1100,"context_line":"                        resource.type \u003d \u0027STORAGE\u0027"},{"line_number":1101,"context_line":"                        resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1102,"context_line":"                        resource.resource_template_id \u003d \\"},{"line_number":1103,"context_line":"                            storage_resource.virtual_storage_desc_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_dbd031cb","line":1100,"range":{"start_line":1100,"start_character":40,"end_line":1100,"end_character":49},"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                        resource \u003d objects.ResourceDefinition()"},{"line_number":1098,"context_line":"                        resource \u003d objects.ResourceDefinition()"},{"line_number":1099,"context_line":"                        resource.id \u003d add_uuid"},{"line_number":1100,"context_line":"                        resource.type \u003d \u0027STORAGE\u0027"},{"line_number":1101,"context_line":"                        resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1102,"context_line":"                        resource.resource_template_id \u003d \\"},{"line_number":1103,"context_line":"                            storage_resource.virtual_storage_desc_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f9fd8508","line":1100,"range":{"start_line":1100,"start_character":40,"end_line":1100,"end_character":49},"in_reply_to":"9f560f44_dbd031cb","updated":"2020-09-22 09:01:16.000000000","message":"To common definition.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":1141,"context_line":"        if not self._get_glant_execute():"},{"line_number":1142,"context_line":"            return"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"        rmResources \u003d []"},{"line_number":1145,"context_line":"        for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":1146,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":1147,"context_line":"            resource.id \u003d vnfc_resource.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ade6d0ae","line":1144,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":1141,"context_line":"        if not self._get_glant_execute():"},{"line_number":1142,"context_line":"            return"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"        rmResources \u003d []"},{"line_number":1145,"context_line":"        for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":1146,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":1147,"context_line":"            resource.id \u003d vnfc_resource.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f95cea1a","line":1144,"in_reply_to":"9f560f44_ade6d0ae","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"        for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":1146,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":1147,"context_line":"            resource.id \u003d vnfc_resource.id"},{"line_number":1148,"context_line":"            resource.type \u003d \u0027COMPUTE\u0027"},{"line_number":1149,"context_line":"            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1150,"context_line":"            resource.resource_template_id \u003d vnfc_resource.vdu_id"},{"line_number":1151,"context_line":"            vim_id \u003d vnfc_resource.compute_resource.vim_connection_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1bd629c4","line":1148,"range":{"start_line":1148,"start_character":28,"end_line":1148,"end_character":37},"updated":"2020-09-10 18:27:27.000000000","message":"It’s better to make such a keyword to `constants` like as L.268 or so.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"        for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":1146,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":1147,"context_line":"            resource.id \u003d vnfc_resource.id"},{"line_number":1148,"context_line":"            resource.type \u003d \u0027COMPUTE\u0027"},{"line_number":1149,"context_line":"            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1150,"context_line":"            resource.resource_template_id \u003d vnfc_resource.vdu_id"},{"line_number":1151,"context_line":"            vim_id \u003d vnfc_resource.compute_resource.vim_connection_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d9024109","line":1148,"range":{"start_line":1148,"start_character":28,"end_line":1148,"end_character":37},"in_reply_to":"9f560f44_1bd629c4","updated":"2020-09-22 09:01:16.000000000","message":"To common definition.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":1154,"context_line":"                vim_connection_id\u003dvim_id,"},{"line_number":1155,"context_line":"                resource_id\u003drsc_id)"},{"line_number":1156,"context_line":"            resource.resource \u003d vnfc_rh"},{"line_number":1157,"context_line":"            rmResources.append(resource)"},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"        for vl_resource in vnf_inf.vnf_virtual_link_resource_info:"},{"line_number":1160,"context_line":"            resource \u003d objects.ResourceDefinition()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8de94c80","line":1157,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":1154,"context_line":"                vim_connection_id\u003dvim_id,"},{"line_number":1155,"context_line":"                resource_id\u003drsc_id)"},{"line_number":1156,"context_line":"            resource.resource \u003d vnfc_rh"},{"line_number":1157,"context_line":"            rmResources.append(resource)"},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"        for vl_resource in vnf_inf.vnf_virtual_link_resource_info:"},{"line_number":1160,"context_line":"            resource \u003d objects.ResourceDefinition()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_399ca2be","line":1157,"in_reply_to":"9f560f44_8de94c80","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"        for vl_resource in vnf_inf.vnf_virtual_link_resource_info:"},{"line_number":1160,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":1161,"context_line":"            resource.id \u003d vl_resource.id"},{"line_number":1162,"context_line":"            resource.type \u003d \u0027VL\u0027"},{"line_number":1163,"context_line":"            resource.resource_template_id \u003d \\"},{"line_number":1164,"context_line":"                vl_resource.vnf_virtual_link_desc_id"},{"line_number":1165,"context_line":"            vim_id \u003d vl_resource.network_resource.vim_connection_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7be1259b","line":1162,"range":{"start_line":1162,"start_character":28,"end_line":1162,"end_character":32},"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"        for vl_resource in vnf_inf.vnf_virtual_link_resource_info:"},{"line_number":1160,"context_line":"            resource \u003d objects.ResourceDefinition()"},{"line_number":1161,"context_line":"            resource.id \u003d vl_resource.id"},{"line_number":1162,"context_line":"            resource.type \u003d \u0027VL\u0027"},{"line_number":1163,"context_line":"            resource.resource_template_id \u003d \\"},{"line_number":1164,"context_line":"                vl_resource.vnf_virtual_link_desc_id"},{"line_number":1165,"context_line":"            vim_id \u003d vl_resource.network_resource.vim_connection_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_39041d14","line":1162,"range":{"start_line":1162,"start_character":28,"end_line":1162,"end_character":32},"in_reply_to":"9f560f44_7be1259b","updated":"2020-09-22 09:01:16.000000000","message":"To common definition.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"                vim_connection_id\u003dvim_id,"},{"line_number":1169,"context_line":"                resource_id\u003drsc_id)"},{"line_number":1170,"context_line":"            resource.resource \u003d vl_rh"},{"line_number":1171,"context_line":"            rmResources.append(resource)"},{"line_number":1172,"context_line":"            for cp_resource in vl_resource.vnf_link_ports:"},{"line_number":1173,"context_line":"                for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":1174,"context_line":"                    for vnfc_cp_resource in vnfc_resource.vnfc_cp_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_cdfea436","line":1171,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"                vim_connection_id\u003dvim_id,"},{"line_number":1169,"context_line":"                resource_id\u003drsc_id)"},{"line_number":1170,"context_line":"            resource.resource \u003d vl_rh"},{"line_number":1171,"context_line":"            rmResources.append(resource)"},{"line_number":1172,"context_line":"            for cp_resource in vl_resource.vnf_link_ports:"},{"line_number":1173,"context_line":"                for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":1174,"context_line":"                    for vnfc_cp_resource in vnfc_resource.vnfc_cp_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_99a16efb","line":1171,"in_reply_to":"9f560f44_cdfea436","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"                        if cp_resource.cp_instance_id \u003d\u003d vnfc_cp_resource.id:"},{"line_number":1176,"context_line":"                            resource \u003d objects.ResourceDefinition()"},{"line_number":1177,"context_line":"                            resource.id \u003d cp_resource.id"},{"line_number":1178,"context_line":"                            resource.type \u003d \u0027LINKPORT\u0027"},{"line_number":1179,"context_line":"                            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1180,"context_line":"                            resource.resource_template_id \u003d \\"},{"line_number":1181,"context_line":"                                vnfc_cp_resource.cpd_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9bf35973","line":1178,"range":{"start_line":1178,"start_character":44,"end_line":1178,"end_character":54},"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"                        if cp_resource.cp_instance_id \u003d\u003d vnfc_cp_resource.id:"},{"line_number":1176,"context_line":"                            resource \u003d objects.ResourceDefinition()"},{"line_number":1177,"context_line":"                            resource.id \u003d cp_resource.id"},{"line_number":1178,"context_line":"                            resource.type \u003d \u0027LINKPORT\u0027"},{"line_number":1179,"context_line":"                            resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1180,"context_line":"                            resource.resource_template_id \u003d \\"},{"line_number":1181,"context_line":"                                vnfc_cp_resource.cpd_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1909592a","line":1178,"range":{"start_line":1178,"start_character":44,"end_line":1178,"end_character":54},"in_reply_to":"9f560f44_9bf35973","updated":"2020-09-22 09:01:16.000000000","message":"To common definition.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":1186,"context_line":"                                vim_connection_id\u003dvim_id,"},{"line_number":1187,"context_line":"                                resource_id\u003drsc_id)"},{"line_number":1188,"context_line":"                            resource.resource \u003d cp_rh"},{"line_number":1189,"context_line":"                            rmResources.append(resource)"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"        for storage_resource in vnf_inf.virtual_storage_resource_info:"},{"line_number":1192,"context_line":"            for vnfc_resource in vnf_inf.vnfc_resource_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2dfac041","line":1189,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":1186,"context_line":"                                vim_connection_id\u003dvim_id,"},{"line_number":1187,"context_line":"                                resource_id\u003drsc_id)"},{"line_number":1188,"context_line":"                            resource.resource \u003d cp_rh"},{"line_number":1189,"context_line":"                            rmResources.append(resource)"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"        for storage_resource in vnf_inf.virtual_storage_resource_info:"},{"line_number":1192,"context_line":"            for vnfc_resource in vnf_inf.vnfc_resource_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d9aac6d1","line":1189,"in_reply_to":"9f560f44_2dfac041","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1193,"context_line":"                if storage_resource.id in vnfc_resource.storage_resource_ids:"},{"line_number":1194,"context_line":"                    resource \u003d objects.ResourceDefinition()"},{"line_number":1195,"context_line":"                    resource.id \u003d storage_resource.id"},{"line_number":1196,"context_line":"                    resource.type \u003d \u0027STORAGE\u0027"},{"line_number":1197,"context_line":"                    resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1198,"context_line":"                    resource.resource_template_id \u003d \\"},{"line_number":1199,"context_line":"                        storage_resource.virtual_storage_desc_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9b98791b","line":1196,"range":{"start_line":1196,"start_character":36,"end_line":1196,"end_character":45},"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1193,"context_line":"                if storage_resource.id in vnfc_resource.storage_resource_ids:"},{"line_number":1194,"context_line":"                    resource \u003d objects.ResourceDefinition()"},{"line_number":1195,"context_line":"                    resource.id \u003d storage_resource.id"},{"line_number":1196,"context_line":"                    resource.type \u003d \u0027STORAGE\u0027"},{"line_number":1197,"context_line":"                    resource.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1198,"context_line":"                    resource.resource_template_id \u003d \\"},{"line_number":1199,"context_line":"                        storage_resource.virtual_storage_desc_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_79117553","line":1196,"range":{"start_line":1196,"start_character":36,"end_line":1196,"end_character":45},"in_reply_to":"9f560f44_9b98791b","updated":"2020-09-22 09:01:16.000000000","message":"To common definition.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"                        vim_connection_id\u003dvim_id,"},{"line_number":1205,"context_line":"                        resource_id\u003drsc_id)"},{"line_number":1206,"context_line":"                    resource.resource \u003d st_rh"},{"line_number":1207,"context_line":"                    rmResources.append(resource)"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"        grant_request \u003d self._make_grant_request(context,"},{"line_number":1210,"context_line":"                                                 vnf_instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0df53c51","line":1207,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"                        vim_connection_id\u003dvim_id,"},{"line_number":1205,"context_line":"                        resource_id\u003drsc_id)"},{"line_number":1206,"context_line":"                    resource.resource \u003d st_rh"},{"line_number":1207,"context_line":"                    rmResources.append(resource)"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"        grant_request \u003d self._make_grant_request(context,"},{"line_number":1210,"context_line":"                                                 vnf_instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f9b18a46","line":1207,"in_reply_to":"9f560f44_0df53c51","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"                                                 vnf_lcm_op_occ_id,"},{"line_number":1212,"context_line":"                                                 \u0027TERMINATE\u0027,"},{"line_number":1213,"context_line":"                                                 False,"},{"line_number":1214,"context_line":"                                                 remove_resources\u003drmResources)"},{"line_number":1215,"context_line":"        self._grant(context, grant_request)"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def _get_glant_execute(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ed88c8c6","line":1214,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"                                                 vnf_lcm_op_occ_id,"},{"line_number":1212,"context_line":"                                                 \u0027TERMINATE\u0027,"},{"line_number":1213,"context_line":"                                                 False,"},{"line_number":1214,"context_line":"                                                 remove_resources\u003drmResources)"},{"line_number":1215,"context_line":"        self._grant(context, grant_request)"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def _get_glant_execute(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_5980764a","line":1214,"in_reply_to":"9f560f44_ed88c8c6","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"                                                 remove_resources\u003drmResources)"},{"line_number":1215,"context_line":"        self._grant(context, grant_request)"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def _get_glant_execute(self):"},{"line_number":1218,"context_line":"        if CONF.vnf_lcm.glant_exec is True:"},{"line_number":1219,"context_line":"            return True"},{"line_number":1220,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_107288e3","line":1217,"range":{"start_line":1217,"start_character":13,"end_line":1217,"end_character":18},"updated":"2020-09-10 18:27:27.000000000","message":"misspelled?","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"                                                 remove_resources\u003drmResources)"},{"line_number":1215,"context_line":"        self._grant(context, grant_request)"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def _get_glant_execute(self):"},{"line_number":1218,"context_line":"        if CONF.vnf_lcm.glant_exec is True:"},{"line_number":1219,"context_line":"            return True"},{"line_number":1220,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b9178d46","line":1217,"range":{"start_line":1217,"start_character":13,"end_line":1217,"end_character":18},"in_reply_to":"9f560f44_107288e3","updated":"2020-09-22 09:01:16.000000000","message":"glant → grant (corrected other parts as well)","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"                                                 remove_resources\u003drmResources)"},{"line_number":1215,"context_line":"        self._grant(context, grant_request)"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def _get_glant_execute(self):"},{"line_number":1218,"context_line":"        if CONF.vnf_lcm.glant_exec is True:"},{"line_number":1219,"context_line":"            return True"},{"line_number":1220,"context_line":"        return False"},{"line_number":1221,"context_line":""},{"line_number":1222,"context_line":"    def _make_grant_request(self, context, vnf_instance,"},{"line_number":1223,"context_line":"                            vnf_lcm_op_occ_id, operation,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_24efdb1d","line":1220,"range":{"start_line":1217,"start_character":4,"end_line":1220,"end_character":20},"updated":"2020-09-07 10:02:28.000000000","message":"It is better to judge based on whether or not the opposite NFVO destination URL is set.\nIs it right?","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"43eb3112ba614b58ba1c49a7573f2aa5644d8467","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"                                                 remove_resources\u003drmResources)"},{"line_number":1215,"context_line":"        self._grant(context, grant_request)"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def _get_glant_execute(self):"},{"line_number":1218,"context_line":"        if CONF.vnf_lcm.glant_exec is True:"},{"line_number":1219,"context_line":"            return True"},{"line_number":1220,"context_line":"        return False"},{"line_number":1221,"context_line":""},{"line_number":1222,"context_line":"    def _make_grant_request(self, context, vnf_instance,"},{"line_number":1223,"context_line":"                            vnf_lcm_op_occ_id, operation,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_292e7df9","line":1220,"range":{"start_line":1217,"start_character":4,"end_line":1220,"end_character":20},"in_reply_to":"9f560f44_24efdb1d","updated":"2020-09-23 01:21:41.000000000","message":"Please check this comment.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e264f2e7657db8b407f9b4c35454a2444396a6ca","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"                                                 remove_resources\u003drmResources)"},{"line_number":1215,"context_line":"        self._grant(context, grant_request)"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def _get_glant_execute(self):"},{"line_number":1218,"context_line":"        if CONF.vnf_lcm.glant_exec is True:"},{"line_number":1219,"context_line":"            return True"},{"line_number":1220,"context_line":"        return False"},{"line_number":1221,"context_line":""},{"line_number":1222,"context_line":"    def _make_grant_request(self, context, vnf_instance,"},{"line_number":1223,"context_line":"                            vnf_lcm_op_occ_id, operation,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_77e80715","line":1220,"range":{"start_line":1217,"start_character":4,"end_line":1220,"end_character":20},"in_reply_to":"9f560f44_292e7df9","updated":"2020-09-25 17:00:53.000000000","message":"It is not possible to deal with it until the 25th, it will be dealt with in the FT patch.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"587f380ff367e10c900c1a4119399a127f953114","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"                                                 remove_resources\u003drmResources)"},{"line_number":1215,"context_line":"        self._grant(context, grant_request)"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def _get_glant_execute(self):"},{"line_number":1218,"context_line":"        if CONF.vnf_lcm.glant_exec is True:"},{"line_number":1219,"context_line":"            return True"},{"line_number":1220,"context_line":"        return False"},{"line_number":1221,"context_line":""},{"line_number":1222,"context_line":"    def _make_grant_request(self, context, vnf_instance,"},{"line_number":1223,"context_line":"                            vnf_lcm_op_occ_id, operation,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6a4c9e75","line":1220,"range":{"start_line":1217,"start_character":4,"end_line":1220,"end_character":20},"in_reply_to":"9f560f44_77e80715","updated":"2020-09-25 17:13:53.000000000","message":"Sorry to have passed the wrong message.. Actually, this issue is fixed.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"            vnf_instance.instantiated_vnf_info.flavour_id"},{"line_number":1234,"context_line":"        grant_request.operation \u003d operation"},{"line_number":1235,"context_line":"        grant_request.is_automatic_invocation \u003d is_automatic_invocation"},{"line_number":1236,"context_line":"        vnflcmUrl \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":1237,"context_line":"            \"/vnflcm/v1/vnf_lcm_op_occs/\" + vnf_lcm_op_occ_id"},{"line_number":1238,"context_line":"        instaUrl \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":1239,"context_line":"            \"/vnflcm/v1/vnf_instances/\" + vnf_instance.id"},{"line_number":1240,"context_line":"        link_vnflcm \u003d objects.Link(href\u003dvnflcmUrl)"},{"line_number":1241,"context_line":"        link_insta \u003d objects.Link(href\u003dinstaUrl)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_64aef3e7","line":1238,"range":{"start_line":1236,"start_character":8,"end_line":1238,"end_character":16},"updated":"2020-09-07 10:02:28.000000000","message":"Please fix these to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"            vnf_instance.instantiated_vnf_info.flavour_id"},{"line_number":1234,"context_line":"        grant_request.operation \u003d operation"},{"line_number":1235,"context_line":"        grant_request.is_automatic_invocation \u003d is_automatic_invocation"},{"line_number":1236,"context_line":"        vnflcmUrl \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":1237,"context_line":"            \"/vnflcm/v1/vnf_lcm_op_occs/\" + vnf_lcm_op_occ_id"},{"line_number":1238,"context_line":"        instaUrl \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":1239,"context_line":"            \"/vnflcm/v1/vnf_instances/\" + vnf_instance.id"},{"line_number":1240,"context_line":"        link_vnflcm \u003d objects.Link(href\u003dvnflcmUrl)"},{"line_number":1241,"context_line":"        link_insta \u003d objects.Link(href\u003dinstaUrl)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d9e081cf","line":1238,"range":{"start_line":1236,"start_character":8,"end_line":1238,"end_character":16},"in_reply_to":"9f560f44_64aef3e7","updated":"2020-09-22 09:01:16.000000000","message":"It is fixed.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"        grant_request._links \u003d link"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"        if add_resources:"},{"line_number":1247,"context_line":"            grant_request.add_resources \u003d []"},{"line_number":1248,"context_line":"            grant_request.add_resources.extend(add_resources)"},{"line_number":1249,"context_line":"        if remove_resources:"},{"line_number":1250,"context_line":"            grant_request.remove_resources \u003d []"},{"line_number":1251,"context_line":"            grant_request.remove_resources.extend(remove_resources)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3b77add6","line":1248,"range":{"start_line":1247,"start_character":12,"end_line":1248,"end_character":61},"updated":"2020-09-10 18:27:27.000000000","message":"Why don\u0027t you make it one line as bellow?\n\n```\ngrant_request.add_resources \u003d add_resources\n```","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"        grant_request._links \u003d link"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"        if add_resources:"},{"line_number":1247,"context_line":"            grant_request.add_resources \u003d []"},{"line_number":1248,"context_line":"            grant_request.add_resources.extend(add_resources)"},{"line_number":1249,"context_line":"        if remove_resources:"},{"line_number":1250,"context_line":"            grant_request.remove_resources \u003d []"},{"line_number":1251,"context_line":"            grant_request.remove_resources.extend(remove_resources)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1922f9a3","line":1248,"range":{"start_line":1247,"start_character":12,"end_line":1248,"end_character":61},"in_reply_to":"9f560f44_3b77add6","updated":"2020-09-22 09:01:16.000000000","message":"fixed.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"            grant_request.add_resources \u003d []"},{"line_number":1248,"context_line":"            grant_request.add_resources.extend(add_resources)"},{"line_number":1249,"context_line":"        if remove_resources:"},{"line_number":1250,"context_line":"            grant_request.remove_resources \u003d []"},{"line_number":1251,"context_line":"            grant_request.remove_resources.extend(remove_resources)"},{"line_number":1252,"context_line":"        if placement_constraints:"},{"line_number":1253,"context_line":"            grant_request.placement_constraints \u003d []"},{"line_number":1254,"context_line":"            grant_request.placement_constraints.extend(placement_constraints)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_db45d170","line":1251,"range":{"start_line":1250,"start_character":12,"end_line":1251,"end_character":67},"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"            grant_request.add_resources \u003d []"},{"line_number":1248,"context_line":"            grant_request.add_resources.extend(add_resources)"},{"line_number":1249,"context_line":"        if remove_resources:"},{"line_number":1250,"context_line":"            grant_request.remove_resources \u003d []"},{"line_number":1251,"context_line":"            grant_request.remove_resources.extend(remove_resources)"},{"line_number":1252,"context_line":"        if placement_constraints:"},{"line_number":1253,"context_line":"            grant_request.placement_constraints \u003d []"},{"line_number":1254,"context_line":"            grant_request.placement_constraints.extend(placement_constraints)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f94bc55b","line":1251,"range":{"start_line":1250,"start_character":12,"end_line":1251,"end_character":67},"in_reply_to":"9f560f44_db45d170","updated":"2020-09-22 09:01:16.000000000","message":"fixed","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"            grant_request.remove_resources \u003d []"},{"line_number":1251,"context_line":"            grant_request.remove_resources.extend(remove_resources)"},{"line_number":1252,"context_line":"        if placement_constraints:"},{"line_number":1253,"context_line":"            grant_request.placement_constraints \u003d []"},{"line_number":1254,"context_line":"            grant_request.placement_constraints.extend(placement_constraints)"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":"        return grant_request"},{"line_number":1257,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3b604d01","line":1254,"range":{"start_line":1253,"start_character":12,"end_line":1254,"end_character":77},"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"            grant_request.remove_resources \u003d []"},{"line_number":1251,"context_line":"            grant_request.remove_resources.extend(remove_resources)"},{"line_number":1252,"context_line":"        if placement_constraints:"},{"line_number":1253,"context_line":"            grant_request.placement_constraints \u003d []"},{"line_number":1254,"context_line":"            grant_request.placement_constraints.extend(placement_constraints)"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":"        return grant_request"},{"line_number":1257,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d950810d","line":1254,"range":{"start_line":1253,"start_character":12,"end_line":1254,"end_character":77},"in_reply_to":"9f560f44_3b604d01","updated":"2020-09-22 09:01:16.000000000","message":"fixed","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"            instantiate_vnf,"},{"line_number":1281,"context_line":"            vnf_lcm_op_occs_id):"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"        LOG.debug(\"\u003e\u003e\u003e\u003e\u003e\u003e\u003e conductor server instantiate\")"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"        self._instantiate_grant(context,"},{"line_number":1286,"context_line":"            vnf_instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c409bfdd","line":1283,"range":{"start_line":1283,"start_character":18,"end_line":1283,"end_character":26},"updated":"2020-09-07 10:02:28.000000000","message":"Is \"\u003e\u003e\u003e\u003e\u003e\u003e\u003e\" an intentional comment?","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"            instantiate_vnf,"},{"line_number":1281,"context_line":"            vnf_lcm_op_occs_id):"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"        LOG.debug(\"\u003e\u003e\u003e\u003e\u003e\u003e\u003e conductor server instantiate\")"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"        self._instantiate_grant(context,"},{"line_number":1286,"context_line":"            vnf_instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_fbb25505","line":1283,"range":{"start_line":1283,"start_character":18,"end_line":1283,"end_character":26},"in_reply_to":"9f560f44_c409bfdd","updated":"2020-09-10 18:27:27.000000000","message":"I also feel it\u0027s strange.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"            instantiate_vnf,"},{"line_number":1281,"context_line":"            vnf_lcm_op_occs_id):"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"        LOG.debug(\"\u003e\u003e\u003e\u003e\u003e\u003e\u003e conductor server instantiate\")"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"        self._instantiate_grant(context,"},{"line_number":1286,"context_line":"            vnf_instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9942893a","line":1283,"range":{"start_line":1283,"start_character":18,"end_line":1283,"end_character":26},"in_reply_to":"9f560f44_fbb25505","updated":"2020-09-22 09:01:16.000000000","message":"Since it is a debug log, the log itself is deleted.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"                self._build_instantiated_vnf_info("},{"line_number":1371,"context_line":"                    context, vnf_instance, instantiate_vnf, vnf_dict)"},{"line_number":1372,"context_line":""},{"line_number":1373,"context_line":"            finally:"},{"line_number":1374,"context_line":"                pass"},{"line_number":1375,"context_line":""},{"line_number":1376,"context_line":"            # send notification \u0027FAILED_TEMP\u0027 with error details"},{"line_number":1377,"context_line":"            self._send_insta_op_occ_notification("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_44cdaf5b","line":1374,"range":{"start_line":1373,"start_character":12,"end_line":1374,"end_character":20},"updated":"2020-09-07 10:02:28.000000000","message":"Is this code meaningful?\nSame for others.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"2a4cc7190c226b2894132b009730942f10c47333","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"                self._build_instantiated_vnf_info("},{"line_number":1371,"context_line":"                    context, vnf_instance, instantiate_vnf, vnf_dict)"},{"line_number":1372,"context_line":""},{"line_number":1373,"context_line":"            finally:"},{"line_number":1374,"context_line":"                pass"},{"line_number":1375,"context_line":""},{"line_number":1376,"context_line":"            # send notification \u0027FAILED_TEMP\u0027 with error details"},{"line_number":1377,"context_line":"            self._send_insta_op_occ_notification("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_bea8dd77","line":1374,"range":{"start_line":1373,"start_character":12,"end_line":1374,"end_character":20},"in_reply_to":"9f560f44_44cdaf5b","updated":"2020-09-24 11:36:13.000000000","message":"It is for performing notification-related processing regardless of whether the processing is normal or abnormal.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":1786,"context_line":"                                                fields.LcmOccsOperationState."},{"line_number":1787,"context_line":"                                                FAILED_TEMP, str(ex))"},{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"    def sendNotification(self, context, notification):"},{"line_number":1790,"context_line":"        try:"},{"line_number":1791,"context_line":"            LOG.debug(\"sendNotification start notification[%s]\" % notification)"},{"line_number":1792,"context_line":"            if (notification.get(\u0027notificationType\u0027) \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2da9207b","line":1789,"updated":"2020-09-11 15:52:30.000000000","message":"Maybe, this function name should be changed to snake_case in parent patch.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":1786,"context_line":"                                                fields.LcmOccsOperationState."},{"line_number":1787,"context_line":"                                                FAILED_TEMP, str(ex))"},{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"    def sendNotification(self, context, notification):"},{"line_number":1790,"context_line":"        try:"},{"line_number":1791,"context_line":"            LOG.debug(\"sendNotification start notification[%s]\" % notification)"},{"line_number":1792,"context_line":"            if (notification.get(\u0027notificationType\u0027) \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_59e5163e","line":1789,"in_reply_to":"9f560f44_2da9207b","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"5a1df151b640fe45430fea4b96b867942dc9949d","unresolved":false,"context_lines":[{"line_number":913,"context_line":"        vnf_inf \u003d vnf_instance.instantiated_vnf_info"},{"line_number":914,"context_line":"        if not self._get_glant_execute():"},{"line_number":915,"context_line":"            return"},{"line_number":916,"context_line":"        else:"},{"line_number":917,"context_line":"            action \u003d vnflcm_utils._get_vnflcm_interface(context,"},{"line_number":918,"context_line":"                                                        \u0027heal\u0027,"},{"line_number":919,"context_line":"                                                        vnf_instance,"},{"line_number":920,"context_line":"                                                        vnf_inf.flavour_id)"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"            if action:"},{"line_number":923,"context_line":"                return"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"        placement_obj_list \u003d self._get_placement(context, vnf_instance)"},{"line_number":926,"context_line":"        vim_info \u003d vnflcm_utils._get_vim(context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_842255a2","line":923,"range":{"start_line":916,"start_character":0,"end_line":923,"end_character":22},"updated":"2020-09-18 07:37:17.000000000","message":"I think this process is unnecessary.","commit_id":"5987ec6ed7bcb4014f282932415285e42033d2c1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":913,"context_line":"        vnf_inf \u003d vnf_instance.instantiated_vnf_info"},{"line_number":914,"context_line":"        if not self._get_glant_execute():"},{"line_number":915,"context_line":"            return"},{"line_number":916,"context_line":"        else:"},{"line_number":917,"context_line":"            action \u003d vnflcm_utils._get_vnflcm_interface(context,"},{"line_number":918,"context_line":"                                                        \u0027heal\u0027,"},{"line_number":919,"context_line":"                                                        vnf_instance,"},{"line_number":920,"context_line":"                                                        vnf_inf.flavour_id)"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"            if action:"},{"line_number":923,"context_line":"                return"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"        placement_obj_list \u003d self._get_placement(context, vnf_instance)"},{"line_number":926,"context_line":"        vim_info \u003d vnflcm_utils._get_vim(context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_9940c9a4","line":923,"range":{"start_line":916,"start_character":0,"end_line":923,"end_character":22},"in_reply_to":"9f560f44_842255a2","updated":"2020-09-22 09:01:16.000000000","message":"it is removed.","commit_id":"5987ec6ed7bcb4014f282932415285e42033d2c1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"88c08a4d042ed80de8766630311d6a0cc52a12c4","unresolved":false,"context_lines":[{"line_number":1414,"context_line":"                    self.__set_auth_subscription(line)"},{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"                    for num in range(CONF.vnf_lcm.retry_num):"},{"line_number":1417,"context_line":"                        LOG.warn(\"send notify[%s]\" % json.dumps(notification))"},{"line_number":1418,"context_line":"                        auth_client \u003d auth.auth_manager.get_auth_client("},{"line_number":1419,"context_line":"                            notification[\u0027subscriptionId\u0027])"},{"line_number":1420,"context_line":"                        response \u003d auth_client.post("}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_23a143f8","line":1417,"range":{"start_line":1417,"start_character":24,"end_line":1417,"end_character":78},"updated":"2020-09-25 06:45:48.000000000","message":"why it is logging warn just for seding notifies?","commit_id":"50da11df690dcf79d8018d71d77d1ad895dbd549"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"e56bd9728f760082fb428781ab265fea558db1bd","unresolved":false,"context_lines":[{"line_number":1414,"context_line":"                    self.__set_auth_subscription(line)"},{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"                    for num in range(CONF.vnf_lcm.retry_num):"},{"line_number":1417,"context_line":"                        LOG.warn(\"send notify[%s]\" % json.dumps(notification))"},{"line_number":1418,"context_line":"                        auth_client \u003d auth.auth_manager.get_auth_client("},{"line_number":1419,"context_line":"                            notification[\u0027subscriptionId\u0027])"},{"line_number":1420,"context_line":"                        response \u003d auth_client.post("}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_f96ed8c5","line":1417,"range":{"start_line":1417,"start_character":24,"end_line":1417,"end_character":78},"in_reply_to":"9f560f44_1e7f32df","updated":"2020-09-25 08:18:49.000000000","message":"Thanks for telling me that, got it!","commit_id":"50da11df690dcf79d8018d71d77d1ad895dbd549"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"bd45d195586f8dc43a47596fc15783cffa21bead","unresolved":false,"context_lines":[{"line_number":1414,"context_line":"                    self.__set_auth_subscription(line)"},{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"                    for num in range(CONF.vnf_lcm.retry_num):"},{"line_number":1417,"context_line":"                        LOG.warn(\"send notify[%s]\" % json.dumps(notification))"},{"line_number":1418,"context_line":"                        auth_client \u003d auth.auth_manager.get_auth_client("},{"line_number":1419,"context_line":"                            notification[\u0027subscriptionId\u0027])"},{"line_number":1420,"context_line":"                        response \u003d auth_client.post("}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_1e7f32df","line":1417,"range":{"start_line":1417,"start_character":24,"end_line":1417,"end_character":78},"in_reply_to":"9f560f44_23a143f8","updated":"2020-09-25 08:11:49.000000000","message":"This change is derived from Notification feature in 746892.","commit_id":"50da11df690dcf79d8018d71d77d1ad895dbd549"}],"tacker/conf/vnf_lcm.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \u0027retry_wait\u0027,"},{"line_number":46,"context_line":"        default\u003d10,"},{"line_number":47,"context_line":"        help\u003d\"Number of subscriptions\"),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027glant_exec\u0027,"},{"line_number":49,"context_line":"               default\u003dFalse,"},{"line_number":50,"context_line":"               help\u003d\"glant exec flag\")]"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f09b9413","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":21},"updated":"2020-09-10 18:27:27.000000000","message":"misspelled?","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \u0027retry_wait\u0027,"},{"line_number":46,"context_line":"        default\u003d10,"},{"line_number":47,"context_line":"        help\u003d\"Number of subscriptions\"),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027glant_exec\u0027,"},{"line_number":49,"context_line":"               default\u003dFalse,"},{"line_number":50,"context_line":"               help\u003d\"glant exec flag\")]"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_5993d1a3","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":21},"in_reply_to":"9f560f44_f09b9413","updated":"2020-09-22 09:01:16.000000000","message":"it is corrected.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \u0027retry_wait\u0027,"},{"line_number":46,"context_line":"        default\u003d10,"},{"line_number":47,"context_line":"        help\u003d\"Number of subscriptions\"),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027glant_exec\u0027,"},{"line_number":49,"context_line":"               default\u003dFalse,"},{"line_number":50,"context_line":"               help\u003d\"glant exec flag\")]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0910f058","line":50,"range":{"start_line":48,"start_character":4,"end_line":50,"end_character":39},"updated":"2020-09-07 10:02:28.000000000","message":"Do you need this config?\nIs it possible to judge based on whether the opposite NFVO destination URL is set?","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        help\u003d\"Number of subscriptions\"),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027glant_exec\u0027,"},{"line_number":49,"context_line":"               default\u003dFalse,"},{"line_number":50,"context_line":"               help\u003d\"glant exec flag\")]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_708f84cc","line":50,"range":{"start_line":50,"start_character":21,"end_line":50,"end_character":26},"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e264f2e7657db8b407f9b4c35454a2444396a6ca","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \u0027retry_wait\u0027,"},{"line_number":46,"context_line":"        default\u003d10,"},{"line_number":47,"context_line":"        help\u003d\"Number of subscriptions\"),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027glant_exec\u0027,"},{"line_number":49,"context_line":"               default\u003dFalse,"},{"line_number":50,"context_line":"               help\u003d\"glant exec flag\")]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_17dd4b6c","line":50,"range":{"start_line":48,"start_character":4,"end_line":50,"end_character":39},"in_reply_to":"9f560f44_0910f058","updated":"2020-09-25 17:00:53.000000000","message":"It is not possible to deal with it until the 25th, it will be dealt with in the FT patch.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"587f380ff367e10c900c1a4119399a127f953114","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \u0027retry_wait\u0027,"},{"line_number":46,"context_line":"        default\u003d10,"},{"line_number":47,"context_line":"        help\u003d\"Number of subscriptions\"),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027glant_exec\u0027,"},{"line_number":49,"context_line":"               default\u003dFalse,"},{"line_number":50,"context_line":"               help\u003d\"glant exec flag\")]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8a55b2fb","line":50,"range":{"start_line":48,"start_character":4,"end_line":50,"end_character":39},"in_reply_to":"9f560f44_17dd4b6c","updated":"2020-09-25 17:13:53.000000000","message":"Sorry to have passed the wrong message.. Actually, this is not yet fixed and we will fix it soon.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"43eb3112ba614b58ba1c49a7573f2aa5644d8467","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        help\u003d\"Number of subscriptions\"),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027glant_exec\u0027,"},{"line_number":49,"context_line":"               default\u003dFalse,"},{"line_number":50,"context_line":"               help\u003d\"glant exec flag\")]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0943b9b1","line":50,"range":{"start_line":50,"start_character":21,"end_line":50,"end_character":26},"in_reply_to":"9f560f44_19f3190b","updated":"2020-09-23 01:21:41.000000000","message":"Please check my comment.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        help\u003d\"Number of subscriptions\"),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027glant_exec\u0027,"},{"line_number":49,"context_line":"               default\u003dFalse,"},{"line_number":50,"context_line":"               help\u003d\"glant exec flag\")]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_19f3190b","line":50,"range":{"start_line":50,"start_character":21,"end_line":50,"end_character":26},"in_reply_to":"9f560f44_708f84cc","updated":"2020-09-22 09:01:16.000000000","message":"fixed spelling.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e264f2e7657db8b407f9b4c35454a2444396a6ca","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        help\u003d\"Number of subscriptions\"),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027glant_exec\u0027,"},{"line_number":49,"context_line":"               default\u003dFalse,"},{"line_number":50,"context_line":"               help\u003d\"glant exec flag\")]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"vnf_lcm_group \u003d cfg.OptGroup(\u0027vnf_lcm\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_77d12757","line":50,"range":{"start_line":50,"start_character":21,"end_line":50,"end_character":26},"in_reply_to":"9f560f44_708f84cc","updated":"2020-09-25 17:00:53.000000000","message":"same answer above.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"}],"tacker/db/db_sqlalchemy/models.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"f22a1a41609b7fb26bf136b0edcc6af92f6a2844","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    error_point \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"class PlacementConstraint(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":281,"context_line":"                models.TimestampMixin, models_v1.HasId):"},{"line_number":282,"context_line":"    \"\"\"Represents a Vnf Placement Constraint.\"\"\""},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_26a495b8","line":280,"range":{"start_line":280,"start_character":6,"end_line":280,"end_character":25},"updated":"2020-09-12 09:08:39.000000000","message":"I think a migration script of alembic_migrations to add placement_constraint table is needed.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    error_point \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"class PlacementConstraint(model_base.BASE, models.SoftDeleteMixin,"},{"line_number":281,"context_line":"                models.TimestampMixin, models_v1.HasId):"},{"line_number":282,"context_line":"    \"\"\"Represents a Vnf Placement Constraint.\"\"\""},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d9f5a686","line":280,"range":{"start_line":280,"start_character":6,"end_line":280,"end_character":25},"in_reply_to":"9f560f44_26a495b8","updated":"2020-09-14 18:46:03.000000000","message":"It is added.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"}],"tacker/db/vnfm/vnfm_db.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":836,"context_line":"            LOG.error(\u0027Failed to update status of vnf %(vnf_id)s \u0027,"},{"line_number":837,"context_line":"                  {\u0027vnf_id\u0027: vnf_id})"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    def create_vnf_exec_action(self, context, vnf_id, stack_id, action):"},{"line_number":840,"context_line":"        pass"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"    def get_vnf_exec_action(self, context, vnf_id, stack_id):"},{"line_number":843,"context_line":"        pass"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"    def delete_vnf_exec_action(self, context, vnf_id, stack_id):"},{"line_number":846,"context_line":"        pass"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    def create_placement_constraint(self, context, placement_obj_list):"},{"line_number":849,"context_line":"        context.session.add_all(placement_obj_list)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_84ece7bb","line":846,"range":{"start_line":839,"start_character":0,"end_line":846,"end_character":12},"updated":"2020-09-07 10:02:28.000000000","message":"These codes don\u0027t seem to be used, are they unnecessary?","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":836,"context_line":"            LOG.error(\u0027Failed to update status of vnf %(vnf_id)s \u0027,"},{"line_number":837,"context_line":"                  {\u0027vnf_id\u0027: vnf_id})"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    def create_vnf_exec_action(self, context, vnf_id, stack_id, action):"},{"line_number":840,"context_line":"        pass"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"    def get_vnf_exec_action(self, context, vnf_id, stack_id):"},{"line_number":843,"context_line":"        pass"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"    def delete_vnf_exec_action(self, context, vnf_id, stack_id):"},{"line_number":846,"context_line":"        pass"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    def create_placement_constraint(self, context, placement_obj_list):"},{"line_number":849,"context_line":"        context.session.add_all(placement_obj_list)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_59c11180","line":846,"range":{"start_line":839,"start_character":0,"end_line":846,"end_character":12},"in_reply_to":"9f560f44_84ece7bb","updated":"2020-09-22 09:01:16.000000000","message":"removed.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":882,"context_line":"            filter(models.PlacementConstraint.deleted \u003d\u003d 0)."},{"line_number":883,"context_line":"            update({\u0027deleted\u0027: 0, \u0027deleted_at\u0027: timeutils.utcnow()}))"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"    def _get_glant_execute(self):"},{"line_number":886,"context_line":"        if CONF.vnf_lcm.glant_exec is True:"},{"line_number":887,"context_line":"            return True"},{"line_number":888,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f0427467","line":885,"range":{"start_line":885,"start_character":13,"end_line":885,"end_character":18},"updated":"2020-09-10 18:27:27.000000000","message":"misspelled?","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d13fe39863c8748e8bd7550b5d15c5a736ddfd37","unresolved":false,"context_lines":[{"line_number":882,"context_line":"            filter(models.PlacementConstraint.deleted \u003d\u003d 0)."},{"line_number":883,"context_line":"            update({\u0027deleted\u0027: 0, \u0027deleted_at\u0027: timeutils.utcnow()}))"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"    def _get_glant_execute(self):"},{"line_number":886,"context_line":"        if CONF.vnf_lcm.glant_exec is True:"},{"line_number":887,"context_line":"            return True"},{"line_number":888,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d9f36172","line":885,"range":{"start_line":885,"start_character":13,"end_line":885,"end_character":18},"in_reply_to":"9f560f44_f0427467","updated":"2020-09-22 10:47:46.000000000","message":"it is corrected","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"}],"tacker/plugins/common/constants.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":60,"context_line":"RESERVATION_POLICY_ACTIONS \u003d [\u0027start_actions\u0027,"},{"line_number":61,"context_line":"                              \u0027before_end_actions\u0027, \u0027end_actions\u0027]"},{"line_number":62,"context_line":"DEFAULT_ALARM_ACTIONS \u003d [\u0027respawn\u0027, \u0027log\u0027, \u0027log_and_kill\u0027, \u0027notify\u0027,"},{"line_number":63,"context_line":"                         \u0027vdu_autoheal\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"RES_TYPE_VNFD \u003d \"vnfd\""},{"line_number":66,"context_line":"RES_TYPE_NSD \u003d \"nsd\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a472cb10","line":63,"range":{"start_line":63,"start_character":26,"end_line":63,"end_character":38},"updated":"2020-09-07 10:02:28.000000000","message":"Is it intentional to add \u0027vdu_autoheal\u0027?","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e264f2e7657db8b407f9b4c35454a2444396a6ca","unresolved":false,"context_lines":[{"line_number":60,"context_line":"RESERVATION_POLICY_ACTIONS \u003d [\u0027start_actions\u0027,"},{"line_number":61,"context_line":"                              \u0027before_end_actions\u0027, \u0027end_actions\u0027]"},{"line_number":62,"context_line":"DEFAULT_ALARM_ACTIONS \u003d [\u0027respawn\u0027, \u0027log\u0027, \u0027log_and_kill\u0027, \u0027notify\u0027,"},{"line_number":63,"context_line":"                         \u0027vdu_autoheal\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"RES_TYPE_VNFD \u003d \"vnfd\""},{"line_number":66,"context_line":"RES_TYPE_NSD \u003d \"nsd\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d782b3a4","line":63,"range":{"start_line":63,"start_character":26,"end_line":63,"end_character":38},"in_reply_to":"9f560f44_29179da5","updated":"2020-09-25 17:00:53.000000000","message":"it is removed.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"43eb3112ba614b58ba1c49a7573f2aa5644d8467","unresolved":false,"context_lines":[{"line_number":60,"context_line":"RESERVATION_POLICY_ACTIONS \u003d [\u0027start_actions\u0027,"},{"line_number":61,"context_line":"                              \u0027before_end_actions\u0027, \u0027end_actions\u0027]"},{"line_number":62,"context_line":"DEFAULT_ALARM_ACTIONS \u003d [\u0027respawn\u0027, \u0027log\u0027, \u0027log_and_kill\u0027, \u0027notify\u0027,"},{"line_number":63,"context_line":"                         \u0027vdu_autoheal\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"RES_TYPE_VNFD \u003d \"vnfd\""},{"line_number":66,"context_line":"RES_TYPE_NSD \u003d \"nsd\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_29179da5","line":63,"range":{"start_line":63,"start_character":26,"end_line":63,"end_character":38},"in_reply_to":"9f560f44_a472cb10","updated":"2020-09-23 01:21:41.000000000","message":"Please check this comment.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"}],"tacker/tests/unit/conductor/test_conductor_server.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":309,"context_line":"                \u0027._build_instantiated_vnf_info\u0027)"},{"line_number":310,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"},{"line_number":311,"context_line":"    @mock.patch.object(conductor_server.Conductor, \"_get_glant_execute\")"},{"line_number":312,"context_line":"    @mock.patch.object(nfvo_client.GrantRequest, \"grants\")"},{"line_number":313,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils._convert_desired_capacity\u0027)"},{"line_number":314,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9034d8fc","line":311,"range":{"start_line":311,"start_character":57,"end_line":311,"end_character":62},"updated":"2020-09-10 18:27:27.000000000","message":"It looks misspelled here and bellow.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d13fe39863c8748e8bd7550b5d15c5a736ddfd37","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":309,"context_line":"                \u0027._build_instantiated_vnf_info\u0027)"},{"line_number":310,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"},{"line_number":311,"context_line":"    @mock.patch.object(conductor_server.Conductor, \"_get_glant_execute\")"},{"line_number":312,"context_line":"    @mock.patch.object(nfvo_client.GrantRequest, \"grants\")"},{"line_number":313,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils._convert_desired_capacity\u0027)"},{"line_number":314,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_199f9902","line":311,"range":{"start_line":311,"start_character":57,"end_line":311,"end_character":62},"in_reply_to":"9f560f44_9034d8fc","updated":"2020-09-22 10:47:46.000000000","message":"fixed the spelling.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            instantiate_vnf_req, vnf_lcm_op_occs_id\u003dvnf_lcm_op_occs_id)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":386,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":387,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":388,"context_line":"                \u0027._build_instantiated_vnf_info\u0027)"},{"line_number":389,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8d7dcc6e","line":386,"updated":"2020-09-11 15:52:30.000000000","message":"Function names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            instantiate_vnf_req, vnf_lcm_op_occs_id\u003dvnf_lcm_op_occs_id)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":386,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":387,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":388,"context_line":"                \u0027._build_instantiated_vnf_info\u0027)"},{"line_number":389,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d9d80682","line":386,"in_reply_to":"9f560f44_8d7dcc6e","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":460,"context_line":"            \u0027ROLLED_BACK\u0027)"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":463,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":464,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":465,"context_line":"                \u0027._build_instantiated_vnf_info\u0027)"},{"line_number":466,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ed97288f","line":463,"updated":"2020-09-11 15:52:30.000000000","message":"Function names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":460,"context_line":"            \u0027ROLLED_BACK\u0027)"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":463,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":464,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":465,"context_line":"                \u0027._build_instantiated_vnf_info\u0027)"},{"line_number":466,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_59ceb6b7","line":463,"in_reply_to":"9f560f44_ed97288f","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        # mock_package_in_use.assert_called_once()"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":723,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":724,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"},{"line_number":725,"context_line":"    @mock.patch.object(conductor_server.Conductor, \"_get_glant_execute\")"},{"line_number":726,"context_line":"    @mock.patch.object(nfvo_client.GrantRequest, \"grants\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0d89bc6d","line":723,"updated":"2020-09-11 15:52:30.000000000","message":"Function names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        # mock_package_in_use.assert_called_once()"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":723,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":724,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"},{"line_number":725,"context_line":"    @mock.patch.object(conductor_server.Conductor, \"_get_glant_execute\")"},{"line_number":726,"context_line":"    @mock.patch.object(nfvo_client.GrantRequest, \"grants\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_99c84ea9","line":723,"in_reply_to":"9f560f44_0d89bc6d","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":777,"context_line":"            \u0027ROLLED_BACK\u0027)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":780,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":781,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"},{"line_number":782,"context_line":"    @mock.patch.object(conductor_server.Conductor, \"_get_glant_execute\")"},{"line_number":783,"context_line":"    @mock.patch.object(nfvo_client.GrantRequest, \"grants\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4dec5428","line":780,"updated":"2020-09-11 15:52:30.000000000","message":"Function names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":777,"context_line":"            \u0027ROLLED_BACK\u0027)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":780,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":781,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"},{"line_number":782,"context_line":"    @mock.patch.object(conductor_server.Conductor, \"_get_glant_execute\")"},{"line_number":783,"context_line":"    @mock.patch.object(nfvo_client.GrantRequest, \"grants\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d9c12684","line":780,"in_reply_to":"9f560f44_4dec5428","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":1125,"context_line":"            vnf_lcm_op_occs_id)"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":1128,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":1129,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":1130,"context_line":"                \u0027._update_instantiated_vnf_info\u0027)"},{"line_number":1131,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8df2ec03","line":1128,"updated":"2020-09-11 15:52:30.000000000","message":"Function names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":1125,"context_line":"            vnf_lcm_op_occs_id)"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":1128,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":1129,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":1130,"context_line":"                \u0027._update_instantiated_vnf_info\u0027)"},{"line_number":1131,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_19bc3e05","line":1128,"in_reply_to":"9f560f44_8df2ec03","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"            \u0027ROLLED_BACK\u0027)"},{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":1221,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":1222,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":1223,"context_line":"                \u0027._update_instantiated_vnf_info\u0027)"},{"line_number":1224,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4dd57442","line":1221,"updated":"2020-09-11 15:52:30.000000000","message":"Function names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"            \u0027ROLLED_BACK\u0027)"},{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":1221,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":1222,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":1223,"context_line":"                \u0027._update_instantiated_vnf_info\u0027)"},{"line_number":1224,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f9b86a12","line":1221,"in_reply_to":"9f560f44_4dd57442","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":1868,"context_line":"        self.assertEqual(1, mock_grants.call_count)"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":1871,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":1872,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"},{"line_number":1873,"context_line":"    @mock.patch.object(objects.VnfInstance, \u0027get_by_id\u0027)"},{"line_number":1874,"context_line":"    @mock.patch.object(vim_client.VimClient, \"get_vim\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ad3d308f","line":1871,"updated":"2020-09-11 15:52:30.000000000","message":"Function names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":1868,"context_line":"        self.assertEqual(1, mock_grants.call_count)"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":1871,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":1872,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"},{"line_number":1873,"context_line":"    @mock.patch.object(objects.VnfInstance, \u0027get_by_id\u0027)"},{"line_number":1874,"context_line":"    @mock.patch.object(vim_client.VimClient, \"get_vim\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_590196b5","line":1871,"in_reply_to":"9f560f44_ad3d308f","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":1963,"context_line":"            \u0027ROLLED_BACK\u0027)"},{"line_number":1964,"context_line":""},{"line_number":1965,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":1966,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":1967,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"},{"line_number":1968,"context_line":"    @mock.patch.object(objects.VnfInstance, \u0027get_by_id\u0027)"},{"line_number":1969,"context_line":"    @mock.patch.object(vim_client.VimClient, \"get_vim\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8d402c08","line":1966,"updated":"2020-09-11 15:52:30.000000000","message":"Function names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":1963,"context_line":"            \u0027ROLLED_BACK\u0027)"},{"line_number":1964,"context_line":""},{"line_number":1965,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":1966,"context_line":"                \u0027.sendNotification\u0027)"},{"line_number":1967,"context_line":"    @mock.patch.object(coordination.Coordinator, \u0027get_lock\u0027)"},{"line_number":1968,"context_line":"    @mock.patch.object(objects.VnfInstance, \u0027get_by_id\u0027)"},{"line_number":1969,"context_line":"    @mock.patch.object(vim_client.VimClient, \"get_vim\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7910da01","line":1966,"in_reply_to":"9f560f44_8d402c08","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"88c08a4d042ed80de8766630311d6a0cc52a12c4","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            objects.VnfLcmOpOcc(context\u003dself.context,"},{"line_number":436,"context_line":"            **lcm_op_occs_data)"},{"line_number":437,"context_line":"        mock_exec.return_value \u003d True"},{"line_number":438,"context_line":"        vimAssets \u003d {\u0027computeResourceFlavours\u0027: ["},{"line_number":439,"context_line":"            {\u0027vimConnectionId\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"             \u0027vnfdVirtualComputeDescId\u0027: \u0027CDU1\u0027,"},{"line_number":441,"context_line":"             \u0027vimFlavourId\u0027: \u0027m1.tiny\u0027}],"},{"line_number":442,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":443,"context_line":"            {\u0027vimConnectionId\u0027: uuidsentinel.vim_id,"},{"line_number":444,"context_line":"             \u0027vnfdSoftwareImageId\u0027: \u0027VDU1\u0027,"},{"line_number":445,"context_line":"             \u0027vimSoftwareImageId\u0027: \u0027cirros\u0027}]}"},{"line_number":446,"context_line":"        resAddResource \u003d []"},{"line_number":447,"context_line":"        resource \u003d {"},{"line_number":448,"context_line":"            \u0027resourceDefinitionId\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_00b7d586","line":445,"range":{"start_line":438,"start_character":0,"end_line":445,"end_character":46},"updated":"2020-09-25 06:45:48.000000000","message":"this value assigning part seems duplicated with other lines. It is not critical but may be a TODO in future refactoring","commit_id":"50da11df690dcf79d8018d71d77d1ad895dbd549"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"bd45d195586f8dc43a47596fc15783cffa21bead","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            objects.VnfLcmOpOcc(context\u003dself.context,"},{"line_number":436,"context_line":"            **lcm_op_occs_data)"},{"line_number":437,"context_line":"        mock_exec.return_value \u003d True"},{"line_number":438,"context_line":"        vimAssets \u003d {\u0027computeResourceFlavours\u0027: ["},{"line_number":439,"context_line":"            {\u0027vimConnectionId\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"             \u0027vnfdVirtualComputeDescId\u0027: \u0027CDU1\u0027,"},{"line_number":441,"context_line":"             \u0027vimFlavourId\u0027: \u0027m1.tiny\u0027}],"},{"line_number":442,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":443,"context_line":"            {\u0027vimConnectionId\u0027: uuidsentinel.vim_id,"},{"line_number":444,"context_line":"             \u0027vnfdSoftwareImageId\u0027: \u0027VDU1\u0027,"},{"line_number":445,"context_line":"             \u0027vimSoftwareImageId\u0027: \u0027cirros\u0027}]}"},{"line_number":446,"context_line":"        resAddResource \u003d []"},{"line_number":447,"context_line":"        resource \u003d {"},{"line_number":448,"context_line":"            \u0027resourceDefinitionId\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_bef2866d","line":445,"range":{"start_line":438,"start_character":0,"end_line":445,"end_character":46},"in_reply_to":"9f560f44_00b7d586","updated":"2020-09-25 08:11:49.000000000","message":"In my understanding, this is not duplicated with the other. Can you please tell me target lines duplicated?","commit_id":"50da11df690dcf79d8018d71d77d1ad895dbd549"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5dd3eb21eb8148f64a72ed6d2da2f0d80d6a8536","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            objects.VnfLcmOpOcc(context\u003dself.context,"},{"line_number":436,"context_line":"            **lcm_op_occs_data)"},{"line_number":437,"context_line":"        mock_exec.return_value \u003d True"},{"line_number":438,"context_line":"        vimAssets \u003d {\u0027computeResourceFlavours\u0027: ["},{"line_number":439,"context_line":"            {\u0027vimConnectionId\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"             \u0027vnfdVirtualComputeDescId\u0027: \u0027CDU1\u0027,"},{"line_number":441,"context_line":"             \u0027vimFlavourId\u0027: \u0027m1.tiny\u0027}],"},{"line_number":442,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":443,"context_line":"            {\u0027vimConnectionId\u0027: uuidsentinel.vim_id,"},{"line_number":444,"context_line":"             \u0027vnfdSoftwareImageId\u0027: \u0027VDU1\u0027,"},{"line_number":445,"context_line":"             \u0027vimSoftwareImageId\u0027: \u0027cirros\u0027}]}"},{"line_number":446,"context_line":"        resAddResource \u003d []"},{"line_number":447,"context_line":"        resource \u003d {"},{"line_number":448,"context_line":"            \u0027resourceDefinitionId\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_197aac75","line":445,"range":{"start_line":438,"start_character":0,"end_line":445,"end_character":46},"in_reply_to":"9f560f44_1953cc17","updated":"2020-09-25 08:19:39.000000000","message":"↑this is not critical in logic, typo....","commit_id":"50da11df690dcf79d8018d71d77d1ad895dbd549"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"e56bd9728f760082fb428781ab265fea558db1bd","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            objects.VnfLcmOpOcc(context\u003dself.context,"},{"line_number":436,"context_line":"            **lcm_op_occs_data)"},{"line_number":437,"context_line":"        mock_exec.return_value \u003d True"},{"line_number":438,"context_line":"        vimAssets \u003d {\u0027computeResourceFlavours\u0027: ["},{"line_number":439,"context_line":"            {\u0027vimConnectionId\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"             \u0027vnfdVirtualComputeDescId\u0027: \u0027CDU1\u0027,"},{"line_number":441,"context_line":"             \u0027vimFlavourId\u0027: \u0027m1.tiny\u0027}],"},{"line_number":442,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":443,"context_line":"            {\u0027vimConnectionId\u0027: uuidsentinel.vim_id,"},{"line_number":444,"context_line":"             \u0027vnfdSoftwareImageId\u0027: \u0027VDU1\u0027,"},{"line_number":445,"context_line":"             \u0027vimSoftwareImageId\u0027: \u0027cirros\u0027}]}"},{"line_number":446,"context_line":"        resAddResource \u003d []"},{"line_number":447,"context_line":"        resource \u003d {"},{"line_number":448,"context_line":"            \u0027resourceDefinitionId\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_1953cc17","line":445,"range":{"start_line":438,"start_character":0,"end_line":445,"end_character":46},"in_reply_to":"9f560f44_bef2866d","updated":"2020-09-25 08:18:49.000000000","message":"thanks for your reply.\nlike here and L960~\nI think this may be some test data that is commonly used in multiple methods. Maybe it could write in setUP() of test class or somewhere commonly.\nAnyway this is not critical logic","commit_id":"50da11df690dcf79d8018d71d77d1ad895dbd549"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"88c08a4d042ed80de8766630311d6a0cc52a12c4","unresolved":false,"context_lines":[{"line_number":460,"context_line":"            \u0027zoneId\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":461,"context_line":"        resAddResource.append(resource)"},{"line_number":462,"context_line":"        grant_dict \u003d {}"},{"line_number":463,"context_line":"        grant_dict[\u0027id\u0027] \u003d \u0027c213e465-8220-487e-9464-f79104e81e96\u0027"},{"line_number":464,"context_line":"        grant_dict[\u0027vnfInstanceId\u0027] \u003d vnf_instance.id"},{"line_number":465,"context_line":"        grant_dict[\u0027vnfLcmOpOccId\u0027] \u003d vnf_lcm_op_occs_id"},{"line_number":466,"context_line":"        grant_dict[\u0027addResources\u0027] \u003d []"},{"line_number":467,"context_line":"        grant_dict[\u0027addResources\u0027].extend(resAddResource)"},{"line_number":468,"context_line":"        grant_dict[\u0027vimAssets\u0027] \u003d vimAssets"},{"line_number":469,"context_line":"        json_data \u003d jsonutils.dumps(grant_dict)"},{"line_number":470,"context_line":"        mock_grants.return_value \u003d MockResponse(json_data\u003djson_data)"},{"line_number":471,"context_line":"        self.assertRaises(exceptions.ValidationError,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_60b1718f","line":468,"range":{"start_line":463,"start_character":0,"end_line":468,"end_character":43},"updated":"2020-09-25 06:45:48.000000000","message":"same as above","commit_id":"50da11df690dcf79d8018d71d77d1ad895dbd549"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"bd45d195586f8dc43a47596fc15783cffa21bead","unresolved":false,"context_lines":[{"line_number":460,"context_line":"            \u0027zoneId\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":461,"context_line":"        resAddResource.append(resource)"},{"line_number":462,"context_line":"        grant_dict \u003d {}"},{"line_number":463,"context_line":"        grant_dict[\u0027id\u0027] \u003d \u0027c213e465-8220-487e-9464-f79104e81e96\u0027"},{"line_number":464,"context_line":"        grant_dict[\u0027vnfInstanceId\u0027] \u003d vnf_instance.id"},{"line_number":465,"context_line":"        grant_dict[\u0027vnfLcmOpOccId\u0027] \u003d vnf_lcm_op_occs_id"},{"line_number":466,"context_line":"        grant_dict[\u0027addResources\u0027] \u003d []"},{"line_number":467,"context_line":"        grant_dict[\u0027addResources\u0027].extend(resAddResource)"},{"line_number":468,"context_line":"        grant_dict[\u0027vimAssets\u0027] \u003d vimAssets"},{"line_number":469,"context_line":"        json_data \u003d jsonutils.dumps(grant_dict)"},{"line_number":470,"context_line":"        mock_grants.return_value \u003d MockResponse(json_data\u003djson_data)"},{"line_number":471,"context_line":"        self.assertRaises(exceptions.ValidationError,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_fee87e7b","line":468,"range":{"start_line":463,"start_character":0,"end_line":468,"end_character":43},"in_reply_to":"9f560f44_60b1718f","updated":"2020-09-25 08:11:49.000000000","message":"Same the above answer.","commit_id":"50da11df690dcf79d8018d71d77d1ad895dbd549"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"88c08a4d042ed80de8766630311d6a0cc52a12c4","unresolved":false,"context_lines":[{"line_number":490,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":491,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"},{"line_number":492,"context_line":"    def test_instantiate_vnf_instance_grant_exception(self,"},{"line_number":493,"context_line":"            mock_vnf_by_id,"},{"line_number":494,"context_line":"            mock_save,"},{"line_number":495,"context_line":"            mock_check,"},{"line_number":496,"context_line":"            mock_des, mock_vnfd_dict, mock_grants,"},{"line_number":497,"context_line":"            mock_exec, mock_get_lock,"},{"line_number":498,"context_line":"            mock_build_info,"},{"line_number":499,"context_line":"            mock_send):"},{"line_number":500,"context_line":"        vnf_package_vnfd \u003d self._create_and_upload_vnf_package()"},{"line_number":501,"context_line":"        vnf_instance_data \u003d fake_obj.get_vnf_instance_data("}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_a07c29b6","line":498,"range":{"start_line":493,"start_character":0,"end_line":498,"end_character":28},"updated":"2020-09-25 06:45:48.000000000","message":"some of parameters seems imported but not been used in method, is that necessary? Maybe decorator or common class is better.\nAlso this is not critical for release","commit_id":"50da11df690dcf79d8018d71d77d1ad895dbd549"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"c167ad0c8251c3e8ea9f0e3adc7283d0d48c6984","unresolved":false,"context_lines":[{"line_number":490,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":491,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"},{"line_number":492,"context_line":"    def test_instantiate_vnf_instance_grant_exception(self,"},{"line_number":493,"context_line":"            mock_vnf_by_id,"},{"line_number":494,"context_line":"            mock_save,"},{"line_number":495,"context_line":"            mock_check,"},{"line_number":496,"context_line":"            mock_des, mock_vnfd_dict, mock_grants,"},{"line_number":497,"context_line":"            mock_exec, mock_get_lock,"},{"line_number":498,"context_line":"            mock_build_info,"},{"line_number":499,"context_line":"            mock_send):"},{"line_number":500,"context_line":"        vnf_package_vnfd \u003d self._create_and_upload_vnf_package()"},{"line_number":501,"context_line":"        vnf_instance_data \u003d fake_obj.get_vnf_instance_data("}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_7d94e68c","line":498,"range":{"start_line":493,"start_character":0,"end_line":498,"end_character":28},"in_reply_to":"9f560f44_9e7ce2b6","updated":"2020-10-06 00:52:58.000000000","message":"got it, thx","commit_id":"50da11df690dcf79d8018d71d77d1ad895dbd549"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"bd45d195586f8dc43a47596fc15783cffa21bead","unresolved":false,"context_lines":[{"line_number":490,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":491,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"},{"line_number":492,"context_line":"    def test_instantiate_vnf_instance_grant_exception(self,"},{"line_number":493,"context_line":"            mock_vnf_by_id,"},{"line_number":494,"context_line":"            mock_save,"},{"line_number":495,"context_line":"            mock_check,"},{"line_number":496,"context_line":"            mock_des, mock_vnfd_dict, mock_grants,"},{"line_number":497,"context_line":"            mock_exec, mock_get_lock,"},{"line_number":498,"context_line":"            mock_build_info,"},{"line_number":499,"context_line":"            mock_send):"},{"line_number":500,"context_line":"        vnf_package_vnfd \u003d self._create_and_upload_vnf_package()"},{"line_number":501,"context_line":"        vnf_instance_data \u003d fake_obj.get_vnf_instance_data("}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_9e7ce2b6","line":498,"range":{"start_line":493,"start_character":0,"end_line":498,"end_character":28},"in_reply_to":"9f560f44_a07c29b6","updated":"2020-09-25 08:11:49.000000000","message":"When a patch is applied with mock, return_value will be None by default. In this case, it is not used in the code.","commit_id":"50da11df690dcf79d8018d71d77d1ad895dbd549"}],"tacker/tests/unit/vnflcm/test_vnflcm_driver.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":579,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":580,"context_line":"    @mock.patch(\u0027tacker.vnflcm.vnflcm_driver.LOG\u0027)"},{"line_number":581,"context_line":"    def test_heal_vnf_without_vnfc_instance_infra_delete_fail(self, mock_log,"},{"line_number":582,"context_line":"            mock_save, mock_get_service_plugins):"},{"line_number":583,"context_line":"        # Heal as per SOL003 i.e. without vnfcInstanceId"},{"line_number":584,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest()"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"        vnf_instance \u003d fakes.return_vnf_instance("},{"line_number":587,"context_line":"            fields.VnfInstanceState.INSTANTIATED)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        vnf_instance.instantiated_vnf_info.instance_id \u003d\\"},{"line_number":590,"context_line":"            uuidsentinel.instance_id"},{"line_number":591,"context_line":"        self._mock_vnf_manager(fail_method_name\u003d\u0027delete\u0027)"},{"line_number":592,"context_line":"        driver \u003d vnflcm_driver.VnfLcmDriver()"},{"line_number":593,"context_line":"        self.assertRaises(exceptions.VnfHealFailed,"},{"line_number":594,"context_line":"            driver.heal_vnf, self.context, vnf_instance, heal_vnf_req)"},{"line_number":595,"context_line":"        self.assertEqual(1, mock_save.call_count)"},{"line_number":596,"context_line":"        self.assertEqual(1, self._vnf_manager.invoke.call_count)"},{"line_number":597,"context_line":"        self.assertEqual(fields.VnfInstanceTaskState.ERROR,"},{"line_number":598,"context_line":"            vnf_instance.task_state)"},{"line_number":599,"context_line":"        expected_msg \u003d (\u0027Failed to delete vnf resources for vnf instance %s \u0027"},{"line_number":600,"context_line":"                        \u0027before respawning. The vnf is in inconsistent \u0027"},{"line_number":601,"context_line":"                        \u0027state. Error: delete failed\u0027)"},{"line_number":602,"context_line":"        mock_log.error.assert_called_with(expected_msg % vnf_instance.id)"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":605,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":606,"context_line":"    @mock.patch.object(objects.VnfPackageVnfd, \u0027get_by_id\u0027)"},{"line_number":607,"context_line":"    @mock.patch.object(vim_client.VimClient, \"get_vim\")"},{"line_number":608,"context_line":"    @mock.patch.object(objects.VnfResource, \"create\")"},{"line_number":609,"context_line":"    @mock.patch.object(objects.VnfResource, \"destroy\")"},{"line_number":610,"context_line":"    @mock.patch.object(objects.VnfResourceList, \"get_by_vnf_instance_id\")"},{"line_number":611,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":612,"context_line":"    @mock.patch(\u0027tacker.vnflcm.vnflcm_driver.LOG\u0027)"},{"line_number":613,"context_line":"    def test_heal_vnf_without_vnfc_instance_infra_instantiate_vnf_fail(self,"},{"line_number":614,"context_line":"            mock_log, mock_save, mock_vnf_resource_list,"},{"line_number":615,"context_line":"            mock_resource_destroy, mock_resource_create, mock_vim,"},{"line_number":616,"context_line":"            mock_vnf_package_vnfd, mock_get_service_plugins):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a4e00b99","side":"PARENT","line":613,"range":{"start_line":581,"start_character":4,"end_line":613,"end_character":70},"updated":"2020-09-07 10:02:28.000000000","message":"The following tests have been removed, are they intentional?\ntest_heal_vnf_without_vnfc_instance_infra_delete_fail\ntest_heal_vnf_without_vnfc_instance_infra_instantiate_vnf_fail","commit_id":"ec770c4c7c78d6d1eabbf67a7f694689563b8291"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"2a4cc7190c226b2894132b009730942f10c47333","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":579,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":580,"context_line":"    @mock.patch(\u0027tacker.vnflcm.vnflcm_driver.LOG\u0027)"},{"line_number":581,"context_line":"    def test_heal_vnf_without_vnfc_instance_infra_delete_fail(self, mock_log,"},{"line_number":582,"context_line":"            mock_save, mock_get_service_plugins):"},{"line_number":583,"context_line":"        # Heal as per SOL003 i.e. without vnfcInstanceId"},{"line_number":584,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest()"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"        vnf_instance \u003d fakes.return_vnf_instance("},{"line_number":587,"context_line":"            fields.VnfInstanceState.INSTANTIATED)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        vnf_instance.instantiated_vnf_info.instance_id \u003d\\"},{"line_number":590,"context_line":"            uuidsentinel.instance_id"},{"line_number":591,"context_line":"        self._mock_vnf_manager(fail_method_name\u003d\u0027delete\u0027)"},{"line_number":592,"context_line":"        driver \u003d vnflcm_driver.VnfLcmDriver()"},{"line_number":593,"context_line":"        self.assertRaises(exceptions.VnfHealFailed,"},{"line_number":594,"context_line":"            driver.heal_vnf, self.context, vnf_instance, heal_vnf_req)"},{"line_number":595,"context_line":"        self.assertEqual(1, mock_save.call_count)"},{"line_number":596,"context_line":"        self.assertEqual(1, self._vnf_manager.invoke.call_count)"},{"line_number":597,"context_line":"        self.assertEqual(fields.VnfInstanceTaskState.ERROR,"},{"line_number":598,"context_line":"            vnf_instance.task_state)"},{"line_number":599,"context_line":"        expected_msg \u003d (\u0027Failed to delete vnf resources for vnf instance %s \u0027"},{"line_number":600,"context_line":"                        \u0027before respawning. The vnf is in inconsistent \u0027"},{"line_number":601,"context_line":"                        \u0027state. Error: delete failed\u0027)"},{"line_number":602,"context_line":"        mock_log.error.assert_called_with(expected_msg % vnf_instance.id)"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":605,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":606,"context_line":"    @mock.patch.object(objects.VnfPackageVnfd, \u0027get_by_id\u0027)"},{"line_number":607,"context_line":"    @mock.patch.object(vim_client.VimClient, \"get_vim\")"},{"line_number":608,"context_line":"    @mock.patch.object(objects.VnfResource, \"create\")"},{"line_number":609,"context_line":"    @mock.patch.object(objects.VnfResource, \"destroy\")"},{"line_number":610,"context_line":"    @mock.patch.object(objects.VnfResourceList, \"get_by_vnf_instance_id\")"},{"line_number":611,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":612,"context_line":"    @mock.patch(\u0027tacker.vnflcm.vnflcm_driver.LOG\u0027)"},{"line_number":613,"context_line":"    def test_heal_vnf_without_vnfc_instance_infra_instantiate_vnf_fail(self,"},{"line_number":614,"context_line":"            mock_log, mock_save, mock_vnf_resource_list,"},{"line_number":615,"context_line":"            mock_resource_destroy, mock_resource_create, mock_vim,"},{"line_number":616,"context_line":"            mock_vnf_package_vnfd, mock_get_service_plugins):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d855e41f","side":"PARENT","line":613,"range":{"start_line":581,"start_character":4,"end_line":613,"end_character":70},"in_reply_to":"9f560f44_a4e00b99","updated":"2020-09-24 11:36:13.000000000","message":"It is restored.","commit_id":"ec770c4c7c78d6d1eabbf67a7f694689563b8291"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":747,"context_line":"    @mock.patch.object(yaml, \"safe_load\")"},{"line_number":748,"context_line":"    @mock.patch.object(driver_manager.DriverManager, \"invoke\")"},{"line_number":749,"context_line":"    def test_scale_false_out_0(self, mock_invoke, mock_safe_load,"},{"line_number":750,"context_line":"                               mock_get_service_plugins):"},{"line_number":751,"context_line":"        vnf_info \u003d fakes._get_vnf()"},{"line_number":752,"context_line":"        vnf_info[\u0027attributes\u0027][\u0027scale_group\u0027] \u003d \u0027{\\\"scaleGroupDict\\\": \u0027 + \\"},{"line_number":753,"context_line":"            \u0027{ \\\"SP1\\\": { \\\"vdu\\\": [\\\"VDU1\\\"], \\\"num\\\": \u0027 + \\"},{"line_number":754,"context_line":"            \u00271, \\\"maxLevel\\\": 3, \\\"initialNum\\\": 0, \u0027 + \\"},{"line_number":755,"context_line":"            \u0027\\\"initialLevel\\\": 0, \\\"default\\\": 0 }}}\u0027"},{"line_number":756,"context_line":"        scale_vnf_request \u003d fakes.scale_request(\"SCALE_OUT\", 1, \"False\")"},{"line_number":757,"context_line":"        vim_connection_info \u003d vim_connection.VimConnectionInfo("},{"line_number":758,"context_line":"            vim_type\u003d\"fake_type\")"},{"line_number":759,"context_line":"        scale_name_list \u003d [\"fake\"]"},{"line_number":760,"context_line":"        grp_id \u003d \"fake_id\""},{"line_number":761,"context_line":"        with open(vnf_info[\"attributes\"][\"heat_template\"], \"r\") as f:"},{"line_number":762,"context_line":"            mock_safe_load.return_value \u003d yaml.safe_load(f)"},{"line_number":763,"context_line":"            print(mock_safe_load.return_value)"},{"line_number":764,"context_line":"        driver \u003d vnflcm_driver.VnfLcmDriver()"},{"line_number":765,"context_line":"        driver.scale(self.context, vnf_info, scale_vnf_request,"},{"line_number":766,"context_line":"        vim_connection_info, scale_name_list, grp_id)"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":769,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":770,"context_line":"    @mock.patch.object(yaml, \"safe_load\")"},{"line_number":771,"context_line":"    @mock.patch.object(driver_manager.DriverManager, \"invoke\")"},{"line_number":772,"context_line":"    def test_scale_false_out_1(self, mock_invoke, mock_safe_load,"},{"line_number":773,"context_line":"                               mock_get_service_plugins):"},{"line_number":774,"context_line":"        vnf_info \u003d fakes._get_vnf()"},{"line_number":775,"context_line":"        vnf_info[\u0027attributes\u0027][\u0027scale_group\u0027] \u003d \u0027{\\\"scaleGroupDict\\\": \u0027 + \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_04d297d1","line":772,"range":{"start_line":749,"start_character":8,"end_line":772,"end_character":30},"updated":"2020-09-07 10:02:28.000000000","message":"It is better to use a name that indicates the test content rather than a meaningless name such as \u00270\u0027 or \u00271\u0027.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":747,"context_line":"    @mock.patch.object(yaml, \"safe_load\")"},{"line_number":748,"context_line":"    @mock.patch.object(driver_manager.DriverManager, \"invoke\")"},{"line_number":749,"context_line":"    def test_scale_false_out_0(self, mock_invoke, mock_safe_load,"},{"line_number":750,"context_line":"                               mock_get_service_plugins):"},{"line_number":751,"context_line":"        vnf_info \u003d fakes._get_vnf()"},{"line_number":752,"context_line":"        vnf_info[\u0027attributes\u0027][\u0027scale_group\u0027] \u003d \u0027{\\\"scaleGroupDict\\\": \u0027 + \\"},{"line_number":753,"context_line":"            \u0027{ \\\"SP1\\\": { \\\"vdu\\\": [\\\"VDU1\\\"], \\\"num\\\": \u0027 + \\"},{"line_number":754,"context_line":"            \u00271, \\\"maxLevel\\\": 3, \\\"initialNum\\\": 0, \u0027 + \\"},{"line_number":755,"context_line":"            \u0027\\\"initialLevel\\\": 0, \\\"default\\\": 0 }}}\u0027"},{"line_number":756,"context_line":"        scale_vnf_request \u003d fakes.scale_request(\"SCALE_OUT\", 1, \"False\")"},{"line_number":757,"context_line":"        vim_connection_info \u003d vim_connection.VimConnectionInfo("},{"line_number":758,"context_line":"            vim_type\u003d\"fake_type\")"},{"line_number":759,"context_line":"        scale_name_list \u003d [\"fake\"]"},{"line_number":760,"context_line":"        grp_id \u003d \"fake_id\""},{"line_number":761,"context_line":"        with open(vnf_info[\"attributes\"][\"heat_template\"], \"r\") as f:"},{"line_number":762,"context_line":"            mock_safe_load.return_value \u003d yaml.safe_load(f)"},{"line_number":763,"context_line":"            print(mock_safe_load.return_value)"},{"line_number":764,"context_line":"        driver \u003d vnflcm_driver.VnfLcmDriver()"},{"line_number":765,"context_line":"        driver.scale(self.context, vnf_info, scale_vnf_request,"},{"line_number":766,"context_line":"        vim_connection_info, scale_name_list, grp_id)"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":769,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":770,"context_line":"    @mock.patch.object(yaml, \"safe_load\")"},{"line_number":771,"context_line":"    @mock.patch.object(driver_manager.DriverManager, \"invoke\")"},{"line_number":772,"context_line":"    def test_scale_false_out_1(self, mock_invoke, mock_safe_load,"},{"line_number":773,"context_line":"                               mock_get_service_plugins):"},{"line_number":774,"context_line":"        vnf_info \u003d fakes._get_vnf()"},{"line_number":775,"context_line":"        vnf_info[\u0027attributes\u0027][\u0027scale_group\u0027] \u003d \u0027{\\\"scaleGroupDict\\\": \u0027 + \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_390a5dd0","line":772,"range":{"start_line":749,"start_character":8,"end_line":772,"end_character":30},"in_reply_to":"9f560f44_04d297d1","updated":"2020-09-22 09:01:16.000000000","message":"changed the test code name.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"}],"tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1505,"context_line":""},{"line_number":1506,"context_line":"        vnf \u003d utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":1507,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":1508,"context_line":"        vnf[\u0027attributes\u0027][\u0027heat_template\u0027] \u003d \u0027heat_template_version:\u0027 + \\"},{"line_number":1509,"context_line":"            \u0027 2016-10-14\\ndescription: \\\u0027CIRROS VNF \u0027 + \\"},{"line_number":1510,"context_line":"            \u0027Descriptor (TEST)\\n\\n  \\\u0027\\nparameters:\\n  \u0027 + \\"},{"line_number":1511,"context_line":"            \u0027DB11_image:\\n    type: string\\n    \u0027 + \\"},{"line_number":1512,"context_line":"            \u0027default: cirros\\nresources:\\n  DB11:\\n    \u0027 + \\"},{"line_number":1513,"context_line":"            \u0027type: OS::Nova::Server\\n    properties:\\n\u0027 + \\"},{"line_number":1514,"context_line":"            \u0027      user_data_format: SOFTWARE_CONFIG\\n\u0027 + \\"},{"line_number":1515,"context_line":"            \u0027      availability_zone: nova\\n      \u0027 + \\"},{"line_number":1516,"context_line":"            \u0027block_device_mapping_v2:\\n        \u0027 + \\"},{"line_number":1517,"context_line":"            \u0027- device_name: vda\\n          volume_id: \u0027 + \\"},{"line_number":1518,"context_line":"            \u0027{get_resource: ST1}\\n      flavor: m1.tiny\\n\u0027 + \\"},{"line_number":1519,"context_line":"            \u0027      networks:\\n      - port: {get_resource:\u0027 + \\"},{"line_number":1520,"context_line":"            \u0027 DB11-CP}\\n      config_drive: false\\n\u0027 + \\"},{"line_number":1521,"context_line":"            \u0027  DB11-CP:\\n    type: OS::Neutron::Port\\n\u0027 + \\"},{"line_number":1522,"context_line":"            \u0027    properties:\\n      network: net_mgmt\\n\u0027 + \\"},{"line_number":1523,"context_line":"            \u0027outputs:\\n  id-DB11:\\n    value:\\n      \u0027 + \\"},{"line_number":1524,"context_line":"            \u0027get_attr: [DB11-CP, fixed_ips, 0, \u0027 + \\"},{"line_number":1525,"context_line":"            \u0027ip_address]\\n\u0027"},{"line_number":1526,"context_line":"        fake_alarm_plugin \u003d FakeAlarmPlugin()"},{"line_number":1527,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1528,"context_line":"        vnf_instance.instantiated_vnf_info \u003d objects.InstantiatedVnfInfo("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_56eb58a2","line":1525,"range":{"start_line":1508,"start_character":45,"end_line":1525,"end_character":27},"updated":"2020-09-10 18:27:27.000000000","message":"Why don\u0027t you make it here-document to make it be maintained better?","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e264f2e7657db8b407f9b4c35454a2444396a6ca","unresolved":false,"context_lines":[{"line_number":1505,"context_line":""},{"line_number":1506,"context_line":"        vnf \u003d utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":1507,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":1508,"context_line":"        vnf[\u0027attributes\u0027][\u0027heat_template\u0027] \u003d \u0027heat_template_version:\u0027 + \\"},{"line_number":1509,"context_line":"            \u0027 2016-10-14\\ndescription: \\\u0027CIRROS VNF \u0027 + \\"},{"line_number":1510,"context_line":"            \u0027Descriptor (TEST)\\n\\n  \\\u0027\\nparameters:\\n  \u0027 + \\"},{"line_number":1511,"context_line":"            \u0027DB11_image:\\n    type: string\\n    \u0027 + \\"},{"line_number":1512,"context_line":"            \u0027default: cirros\\nresources:\\n  DB11:\\n    \u0027 + \\"},{"line_number":1513,"context_line":"            \u0027type: OS::Nova::Server\\n    properties:\\n\u0027 + \\"},{"line_number":1514,"context_line":"            \u0027      user_data_format: SOFTWARE_CONFIG\\n\u0027 + \\"},{"line_number":1515,"context_line":"            \u0027      availability_zone: nova\\n      \u0027 + \\"},{"line_number":1516,"context_line":"            \u0027block_device_mapping_v2:\\n        \u0027 + \\"},{"line_number":1517,"context_line":"            \u0027- device_name: vda\\n          volume_id: \u0027 + \\"},{"line_number":1518,"context_line":"            \u0027{get_resource: ST1}\\n      flavor: m1.tiny\\n\u0027 + \\"},{"line_number":1519,"context_line":"            \u0027      networks:\\n      - port: {get_resource:\u0027 + \\"},{"line_number":1520,"context_line":"            \u0027 DB11-CP}\\n      config_drive: false\\n\u0027 + \\"},{"line_number":1521,"context_line":"            \u0027  DB11-CP:\\n    type: OS::Neutron::Port\\n\u0027 + \\"},{"line_number":1522,"context_line":"            \u0027    properties:\\n      network: net_mgmt\\n\u0027 + \\"},{"line_number":1523,"context_line":"            \u0027outputs:\\n  id-DB11:\\n    value:\\n      \u0027 + \\"},{"line_number":1524,"context_line":"            \u0027get_attr: [DB11-CP, fixed_ips, 0, \u0027 + \\"},{"line_number":1525,"context_line":"            \u0027ip_address]\\n\u0027"},{"line_number":1526,"context_line":"        fake_alarm_plugin \u003d FakeAlarmPlugin()"},{"line_number":1527,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1528,"context_line":"        vnf_instance.instantiated_vnf_info \u003d objects.InstantiatedVnfInfo("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d7f3d39d","line":1525,"range":{"start_line":1508,"start_character":45,"end_line":1525,"end_character":27},"in_reply_to":"9f560f44_56eb58a2","updated":"2020-09-25 17:00:53.000000000","message":"It is provided.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1868,"context_line":"            \u0027{ \\\"SP1\\\": { \\\"vdu\\\": [\\\"VDU1\\\"], \\\"num\\\": \u0027 + \\"},{"line_number":1869,"context_line":"            \u00271, \\\"maxLevel\\\": 3, \\\"initialNum\\\": 0, \u0027 + \\"},{"line_number":1870,"context_line":"            \u0027\\\"initialLevel\\\": 0, \\\"default\\\": 0 }}}\u0027"},{"line_number":1871,"context_line":"        vnf_info[\u0027attributes\u0027][\u0027heat_template\u0027] \u003d \u0027heat_template_version:\u0027 + \\"},{"line_number":1872,"context_line":"            \u0027 2013-05-23\\ndescription: \\\u0027CIRROS VNF \u0027 + \\"},{"line_number":1873,"context_line":"            \u0027Descriptor (TEST)\\n\\n  \\\u0027\\nparameters:\u0027 + \\"},{"line_number":1874,"context_line":"            \u0027\\n  current_num:\\n    type: number\\n  \u0027 + \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d634884b","line":1871,"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e264f2e7657db8b407f9b4c35454a2444396a6ca","unresolved":false,"context_lines":[{"line_number":1868,"context_line":"            \u0027{ \\\"SP1\\\": { \\\"vdu\\\": [\\\"VDU1\\\"], \\\"num\\\": \u0027 + \\"},{"line_number":1869,"context_line":"            \u00271, \\\"maxLevel\\\": 3, \\\"initialNum\\\": 0, \u0027 + \\"},{"line_number":1870,"context_line":"            \u0027\\\"initialLevel\\\": 0, \\\"default\\\": 0 }}}\u0027"},{"line_number":1871,"context_line":"        vnf_info[\u0027attributes\u0027][\u0027heat_template\u0027] \u003d \u0027heat_template_version:\u0027 + \\"},{"line_number":1872,"context_line":"            \u0027 2013-05-23\\ndescription: \\\u0027CIRROS VNF \u0027 + \\"},{"line_number":1873,"context_line":"            \u0027Descriptor (TEST)\\n\\n  \\\u0027\\nparameters:\u0027 + \\"},{"line_number":1874,"context_line":"            \u0027\\n  current_num:\\n    type: number\\n  \u0027 + \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_772ac7e6","line":1871,"in_reply_to":"9f560f44_d634884b","updated":"2020-09-25 17:00:53.000000000","message":"same answer above.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1891,"context_line":"            \u0027SP1_group}\\n      adjustment_type: \u0027 + \\"},{"line_number":1892,"context_line":"            \u0027change_in_capacity\\n      scaling_\u0027 + \\"},{"line_number":1893,"context_line":"            \u0027adjustment: -1\\noutputs: {}\\n\u0027"},{"line_number":1894,"context_line":"        vnf_info[\u0027attributes\u0027][\u0027SP1_res.yaml\u0027] \u003d \u0027heat_template_version:\u0027 + \\"},{"line_number":1895,"context_line":"            \u0027 2013-05-23\\ndescription: \\\u0027CIRROS VNF \u0027 + \\"},{"line_number":1896,"context_line":"            \u0027Descriptor (TEST)\\n\\n  \\\u0027\\nparameters:\\n  \u0027 + \\"},{"line_number":1897,"context_line":"            \u0027DB11_image:\\n    type: string\\n    default:\u0027 + \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_363fc425","line":1894,"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e264f2e7657db8b407f9b4c35454a2444396a6ca","unresolved":false,"context_lines":[{"line_number":1891,"context_line":"            \u0027SP1_group}\\n      adjustment_type: \u0027 + \\"},{"line_number":1892,"context_line":"            \u0027change_in_capacity\\n      scaling_\u0027 + \\"},{"line_number":1893,"context_line":"            \u0027adjustment: -1\\noutputs: {}\\n\u0027"},{"line_number":1894,"context_line":"        vnf_info[\u0027attributes\u0027][\u0027SP1_res.yaml\u0027] \u003d \u0027heat_template_version:\u0027 + \\"},{"line_number":1895,"context_line":"            \u0027 2013-05-23\\ndescription: \\\u0027CIRROS VNF \u0027 + \\"},{"line_number":1896,"context_line":"            \u0027Descriptor (TEST)\\n\\n  \\\u0027\\nparameters:\\n  \u0027 + \\"},{"line_number":1897,"context_line":"            \u0027DB11_image:\\n    type: string\\n    default:\u0027 + \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_572d03fb","line":1894,"in_reply_to":"9f560f44_363fc425","updated":"2020-09-25 17:00:53.000000000","message":"same answer above.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":2028,"context_line":"            \u0027\\\"initialLevel\\\": 0, \\\"default\\\": 0 }}}\u0027"},{"line_number":2029,"context_line":"        vnf_info[\u0027attributes\u0027][\u0027heat_template\u0027] \u003d \\"},{"line_number":2030,"context_line":"            \u0027heat_template_version: \u0027 + \\"},{"line_number":2031,"context_line":"            \u00272013-05-23\\ndescription: \u0027 + \\"},{"line_number":2032,"context_line":"            \u0027\\\u0027CIRROS VNF Descriptor (TEST)\\n\\n  \u0027 + \\"},{"line_number":2033,"context_line":"            \u0027\\\u0027\\nparameters:\\n  current_num:\\n    \u0027 + \\"},{"line_number":2034,"context_line":"            \u0027type: number\\n  nfv:\\n    \u0027 + \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_163a8032","line":2031,"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e264f2e7657db8b407f9b4c35454a2444396a6ca","unresolved":false,"context_lines":[{"line_number":2028,"context_line":"            \u0027\\\"initialLevel\\\": 0, \\\"default\\\": 0 }}}\u0027"},{"line_number":2029,"context_line":"        vnf_info[\u0027attributes\u0027][\u0027heat_template\u0027] \u003d \\"},{"line_number":2030,"context_line":"            \u0027heat_template_version: \u0027 + \\"},{"line_number":2031,"context_line":"            \u00272013-05-23\\ndescription: \u0027 + \\"},{"line_number":2032,"context_line":"            \u0027\\\u0027CIRROS VNF Descriptor (TEST)\\n\\n  \u0027 + \\"},{"line_number":2033,"context_line":"            \u0027\\\u0027\\nparameters:\\n  current_num:\\n    \u0027 + \\"},{"line_number":2034,"context_line":"            \u0027type: number\\n  nfv:\\n    \u0027 + \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b730df56","line":2031,"in_reply_to":"9f560f44_163a8032","updated":"2020-09-25 17:00:53.000000000","message":"same answer above.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":2050,"context_line":"            \u0027SP1_group}\\n      adjustment_type: \u0027 + \\"},{"line_number":2051,"context_line":"            \u0027change_in_capacity\\n      scaling_adjustment:\u0027 + \\"},{"line_number":2052,"context_line":"            \u0027 -1\\noutputs: {}\\n\u0027"},{"line_number":2053,"context_line":"        vnf_info[\u0027attributes\u0027][\u0027SP1_res.yaml\u0027] \u003d \u0027heat_template_version:\u0027 + \\"},{"line_number":2054,"context_line":"            \u0027 2016-10-14\\ndescription: \\\u0027CIRROS VNF \u0027 + \\"},{"line_number":2055,"context_line":"            \u0027Descriptor (TEST)\\n\\n  \\\u0027\\nparameters:\\n  \u0027 + \\"},{"line_number":2056,"context_line":"            \u0027DB11_image:\\n    type: string\\n    \u0027 + \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7645bcb3","line":2053,"updated":"2020-09-10 18:27:27.000000000","message":"ditto","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e264f2e7657db8b407f9b4c35454a2444396a6ca","unresolved":false,"context_lines":[{"line_number":2050,"context_line":"            \u0027SP1_group}\\n      adjustment_type: \u0027 + \\"},{"line_number":2051,"context_line":"            \u0027change_in_capacity\\n      scaling_adjustment:\u0027 + \\"},{"line_number":2052,"context_line":"            \u0027 -1\\noutputs: {}\\n\u0027"},{"line_number":2053,"context_line":"        vnf_info[\u0027attributes\u0027][\u0027SP1_res.yaml\u0027] \u003d \u0027heat_template_version:\u0027 + \\"},{"line_number":2054,"context_line":"            \u0027 2016-10-14\\ndescription: \\\u0027CIRROS VNF \u0027 + \\"},{"line_number":2055,"context_line":"            \u0027Descriptor (TEST)\\n\\n  \\\u0027\\nparameters:\\n  \u0027 + \\"},{"line_number":2056,"context_line":"            \u0027DB11_image:\\n    type: string\\n    \u0027 + \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d738f33b","line":2053,"in_reply_to":"9f560f44_7645bcb3","updated":"2020-09-25 17:00:53.000000000","message":"same answer above.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"}],"tacker/tests/unit/vnfm/test_plugin.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"            instantiation_state\u003d\u0027 \u0027,"},{"line_number":1162,"context_line":"            tenant_id\u003d\u00279b3f0518-bf6b-4982-af32-d282ce577c8f\u0027,"},{"line_number":1163,"context_line":"            created_at\u003ddatetime("},{"line_number":1164,"context_line":"                2020,"},{"line_number":1165,"context_line":"                1,"},{"line_number":1166,"context_line":"                1,"},{"line_number":1167,"context_line":"                1,"},{"line_number":1168,"context_line":"                1,"},{"line_number":1169,"context_line":"                1,"},{"line_number":1170,"context_line":"                tzinfo\u003diso8601.UTC))"},{"line_number":1171,"context_line":"        self.context.session.add(vnf_inst)"},{"line_number":1172,"context_line":"        self.context.session.flush()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e494c3ea","line":1169,"range":{"start_line":1164,"start_character":0,"end_line":1169,"end_character":18},"updated":"2020-09-07 10:02:28.000000000","message":"I think these line breaks are not needed.\nSame for others.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"            instantiation_state\u003d\u0027 \u0027,"},{"line_number":1162,"context_line":"            tenant_id\u003d\u00279b3f0518-bf6b-4982-af32-d282ce577c8f\u0027,"},{"line_number":1163,"context_line":"            created_at\u003ddatetime("},{"line_number":1164,"context_line":"                2020,"},{"line_number":1165,"context_line":"                1,"},{"line_number":1166,"context_line":"                1,"},{"line_number":1167,"context_line":"                1,"},{"line_number":1168,"context_line":"                1,"},{"line_number":1169,"context_line":"                1,"},{"line_number":1170,"context_line":"                tzinfo\u003diso8601.UTC))"},{"line_number":1171,"context_line":"        self.context.session.add(vnf_inst)"},{"line_number":1172,"context_line":"        self.context.session.flush()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_59e2b102","line":1169,"range":{"start_line":1164,"start_character":0,"end_line":1169,"end_character":18},"in_reply_to":"9f560f44_9617b0a3","updated":"2020-09-22 09:01:16.000000000","message":"it is fixed","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"754f0476fe801400a293bb12c0898705e3d1f238","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"            instantiation_state\u003d\u0027 \u0027,"},{"line_number":1162,"context_line":"            tenant_id\u003d\u00279b3f0518-bf6b-4982-af32-d282ce577c8f\u0027,"},{"line_number":1163,"context_line":"            created_at\u003ddatetime("},{"line_number":1164,"context_line":"                2020,"},{"line_number":1165,"context_line":"                1,"},{"line_number":1166,"context_line":"                1,"},{"line_number":1167,"context_line":"                1,"},{"line_number":1168,"context_line":"                1,"},{"line_number":1169,"context_line":"                1,"},{"line_number":1170,"context_line":"                tzinfo\u003diso8601.UTC))"},{"line_number":1171,"context_line":"        self.context.session.add(vnf_inst)"},{"line_number":1172,"context_line":"        self.context.session.flush()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9617b0a3","line":1169,"range":{"start_line":1164,"start_character":0,"end_line":1169,"end_character":18},"in_reply_to":"9f560f44_e494c3ea","updated":"2020-09-10 18:27:27.000000000","message":"I strongly agree with Hiroo.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"340be8445a8a2ea2e6efc89bbe456231cee10334","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"_INITIAL_STATE \u003d (\u0027INACTIVE\u0027)"},{"line_number":103,"context_line":"_ACTIVE_STATE \u003d (\u0027ACTIVE\u0027)"},{"line_number":104,"context_line":"_PENDING_STATE \u003d (\u0027PENDING_CREATE,PENDING_DELETE\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def get_scaling_policy_name(action, policy_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_04473779","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":14},"updated":"2020-09-07 10:02:28.000000000","message":"I think \u0027_PENDING_STATES\u0027 is better.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"_INITIAL_STATE \u003d (\u0027INACTIVE\u0027)"},{"line_number":103,"context_line":"_ACTIVE_STATE \u003d (\u0027ACTIVE\u0027)"},{"line_number":104,"context_line":"_PENDING_STATE \u003d (\u0027PENDING_CREATE,PENDING_DELETE\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def get_scaling_policy_name(action, policy_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d98d2132","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":14},"in_reply_to":"9f560f44_04473779","updated":"2020-09-22 09:01:16.000000000","message":"Deleted","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8ba19a138ef99e58f3507ff7fbf14032ace67202","unresolved":false,"context_lines":[{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1210,"context_line":"            vnf_id \u003d vnf_instance.id"},{"line_number":1211,"context_line":"            # stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"            vnf_model \u003d ("},{"line_number":1214,"context_line":"                context.session.query("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ae7c5db6","line":1211,"range":{"start_line":1211,"start_character":12,"end_line":1211,"end_character":71},"updated":"2020-09-08 06:58:54.000000000","message":"I think this is an unnecessary comment.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1210,"context_line":"            vnf_id \u003d vnf_instance.id"},{"line_number":1211,"context_line":"            # stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"            vnf_model \u003d ("},{"line_number":1214,"context_line":"                context.session.query("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_797cd51f","line":1211,"range":{"start_line":1211,"start_character":12,"end_line":1211,"end_character":71},"in_reply_to":"9f560f44_ae7c5db6","updated":"2020-09-22 09:01:16.000000000","message":"It is removed. (rebasing will remove it).","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8ba19a138ef99e58f3507ff7fbf14032ace67202","unresolved":false,"context_lines":[{"line_number":1968,"context_line":"                    vl.vnf_link_ports.pop(ind)"},{"line_number":1969,"context_line":""},{"line_number":1970,"context_line":"    @log.log"},{"line_number":1971,"context_line":"    def scale_in_reverse(self, context, plugin, auth_attr, vnf_info,"},{"line_number":1972,"context_line":"                         scale_vnf_request, region_name,"},{"line_number":1973,"context_line":"                         scale_name_list, grp_id):"},{"line_number":1974,"context_line":"        heatclient \u003d hc.HeatClient(auth_attr, region_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2eb4cd81","line":1971,"range":{"start_line":1971,"start_character":8,"end_line":1971,"end_character":24},"updated":"2020-09-08 06:58:54.000000000","message":"This method is called not only by scale-in but also by scale-out, so it is better to change the method name.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1968,"context_line":"                    vl.vnf_link_ports.pop(ind)"},{"line_number":1969,"context_line":""},{"line_number":1970,"context_line":"    @log.log"},{"line_number":1971,"context_line":"    def scale_in_reverse(self, context, plugin, auth_attr, vnf_info,"},{"line_number":1972,"context_line":"                         scale_vnf_request, region_name,"},{"line_number":1973,"context_line":"                         scale_name_list, grp_id):"},{"line_number":1974,"context_line":"        heatclient \u003d hc.HeatClient(auth_attr, region_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b972ed48","line":1971,"range":{"start_line":1971,"start_character":8,"end_line":1971,"end_character":24},"in_reply_to":"9f560f44_2eb4cd81","updated":"2020-09-22 09:01:16.000000000","message":"Since scale_in_reverse is used only for Scale_in, there is no name change. Instead, there are some corrections to the judgment process","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8ba19a138ef99e58f3507ff7fbf14032ace67202","unresolved":false,"context_lines":[{"line_number":2036,"context_line":"        vnf_info[\u0027attributes\u0027].update({\u0027stack_param\u0027: str(paramDict)})"},{"line_number":2037,"context_line":""},{"line_number":2038,"context_line":"    @log.log"},{"line_number":2039,"context_line":"    def scale_in_reverse_wait("},{"line_number":2040,"context_line":"            self,"},{"line_number":2041,"context_line":"            context,"},{"line_number":2042,"context_line":"            plugin,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2e696df7","line":2039,"updated":"2020-09-08 06:58:54.000000000","message":"This method is called not only by scale-in but also by scale-out, so it is better to change the method name.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":2036,"context_line":"        vnf_info[\u0027attributes\u0027].update({\u0027stack_param\u0027: str(paramDict)})"},{"line_number":2037,"context_line":""},{"line_number":2038,"context_line":"    @log.log"},{"line_number":2039,"context_line":"    def scale_in_reverse_wait("},{"line_number":2040,"context_line":"            self,"},{"line_number":2041,"context_line":"            context,"},{"line_number":2042,"context_line":"            plugin,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d992414b","line":2039,"in_reply_to":"9f560f44_2e696df7","updated":"2020-09-22 09:01:16.000000000","message":"Changed name of process","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":2083,"context_line":"            placement_obj_list,"},{"line_number":2084,"context_line":"            vim_connection_info,"},{"line_number":2085,"context_line":"            del_list):"},{"line_number":2086,"context_line":"        addResources \u003d []"},{"line_number":2087,"context_line":"        removeResources \u003d []"},{"line_number":2088,"context_line":"        affinity_list \u003d []"},{"line_number":2089,"context_line":"        placement_constraint_list \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_edb1e890","line":2086,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":2083,"context_line":"            placement_obj_list,"},{"line_number":2084,"context_line":"            vim_connection_info,"},{"line_number":2085,"context_line":"            del_list):"},{"line_number":2086,"context_line":"        addResources \u003d []"},{"line_number":2087,"context_line":"        removeResources \u003d []"},{"line_number":2088,"context_line":"        affinity_list \u003d []"},{"line_number":2089,"context_line":"        placement_constraint_list \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_99d96e58","line":2086,"in_reply_to":"9f560f44_edb1e890","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":2084,"context_line":"            vim_connection_info,"},{"line_number":2085,"context_line":"            del_list):"},{"line_number":2086,"context_line":"        addResources \u003d []"},{"line_number":2087,"context_line":"        removeResources \u003d []"},{"line_number":2088,"context_line":"        affinity_list \u003d []"},{"line_number":2089,"context_line":"        placement_constraint_list \u003d []"},{"line_number":2090,"context_line":"        if scale_vnf_request.type \u003d\u003d \u0027SCALE_OUT\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ad69b0f8","line":2087,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":2084,"context_line":"            vim_connection_info,"},{"line_number":2085,"context_line":"            del_list):"},{"line_number":2086,"context_line":"        addResources \u003d []"},{"line_number":2087,"context_line":"        removeResources \u003d []"},{"line_number":2088,"context_line":"        affinity_list \u003d []"},{"line_number":2089,"context_line":"        placement_constraint_list \u003d []"},{"line_number":2090,"context_line":"        if scale_vnf_request.type \u003d\u003d \u0027SCALE_OUT\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_79de1a3f","line":2087,"in_reply_to":"9f560f44_ad69b0f8","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":2111,"context_line":"                            type\u003d\u0027COMPUTE\u0027,"},{"line_number":2112,"context_line":"                            vdu_id\u003dresource_name,"},{"line_number":2113,"context_line":"                            resource_template_id\u003dresource_name)"},{"line_number":2114,"context_line":"                        addResources.append(rsc)"},{"line_number":2115,"context_line":"                        uuid_list.append(add_uuid)"},{"line_number":2116,"context_line":"                        for net in resource.get(\u0027networks\u0027, []):"},{"line_number":2117,"context_line":"                            add_uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2d7da0b1","line":2114,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":2111,"context_line":"                            type\u003d\u0027COMPUTE\u0027,"},{"line_number":2112,"context_line":"                            vdu_id\u003dresource_name,"},{"line_number":2113,"context_line":"                            resource_template_id\u003dresource_name)"},{"line_number":2114,"context_line":"                        addResources.append(rsc)"},{"line_number":2115,"context_line":"                        uuid_list.append(add_uuid)"},{"line_number":2116,"context_line":"                        for net in resource.get(\u0027networks\u0027, []):"},{"line_number":2117,"context_line":"                            add_uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f9e98ae3","line":2114,"in_reply_to":"9f560f44_2d7da0b1","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":2121,"context_line":"                                type\u003d\u0027LINKPORT\u0027,"},{"line_number":2122,"context_line":"                                vdu_id\u003dresource_name,"},{"line_number":2123,"context_line":"                                resource_template_id\u003dport_rsc)"},{"line_number":2124,"context_line":"                            addResources.append(rsc)"},{"line_number":2125,"context_line":"                            port_uuid_list.append(add_uuid)"},{"line_number":2126,"context_line":"                    if resource[\u0027properties\u0027].get(\u0027block_device_mapping_v2\u0027):"},{"line_number":2127,"context_line":"                        for i in range(size):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0d789cbe","line":2124,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":2121,"context_line":"                                type\u003d\u0027LINKPORT\u0027,"},{"line_number":2122,"context_line":"                                vdu_id\u003dresource_name,"},{"line_number":2123,"context_line":"                                resource_template_id\u003dport_rsc)"},{"line_number":2124,"context_line":"                            addResources.append(rsc)"},{"line_number":2125,"context_line":"                            port_uuid_list.append(add_uuid)"},{"line_number":2126,"context_line":"                    if resource[\u0027properties\u0027].get(\u0027block_device_mapping_v2\u0027):"},{"line_number":2127,"context_line":"                        for i in range(size):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_39bdc2d7","line":2124,"in_reply_to":"9f560f44_0d789cbe","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":2134,"context_line":"                                    type\u003d\u0027STORAGE\u0027,"},{"line_number":2135,"context_line":"                                    vdu_id\u003dresource_name,"},{"line_number":2136,"context_line":"                                    resource_template_id\u003dvol_rsc)"},{"line_number":2137,"context_line":"                                addResources.append(rsc)"},{"line_number":2138,"context_line":"                                storage_uuid_list.append(add_uuid)"},{"line_number":2139,"context_line":"                    if resource[\u0027properties\u0027].get(\u0027scheduler_hints\u0027):"},{"line_number":2140,"context_line":"                        sch_hint \u003d resource[\u0027properties\u0027][\u0027scheduler_hints\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4d4f3491","line":2137,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":2134,"context_line":"                                    type\u003d\u0027STORAGE\u0027,"},{"line_number":2135,"context_line":"                                    vdu_id\u003dresource_name,"},{"line_number":2136,"context_line":"                                    resource_template_id\u003dvol_rsc)"},{"line_number":2137,"context_line":"                                addResources.append(rsc)"},{"line_number":2138,"context_line":"                                storage_uuid_list.append(add_uuid)"},{"line_number":2139,"context_line":"                    if resource[\u0027properties\u0027].get(\u0027scheduler_hints\u0027):"},{"line_number":2140,"context_line":"                        sch_hint \u003d resource[\u0027properties\u0027][\u0027scheduler_hints\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_99b20e06","line":2137,"in_reply_to":"9f560f44_4d4f3491","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":2161,"context_line":"                            type\u003d\u0027STORAGE\u0027,"},{"line_number":2162,"context_line":"                            vdu_id\u003dvol_rsc[\u0027get_resource\u0027],"},{"line_number":2163,"context_line":"                            resource_template_id\u003dresource_name)"},{"line_number":2164,"context_line":"                        addResources.append(rsc)"},{"line_number":2165,"context_line":"                        storage_uuid_list.append(add_uuid)"},{"line_number":2166,"context_line":"            vnf_info[\u0027uuid_list\u0027] \u003d uuid_list"},{"line_number":2167,"context_line":"            vnf_info[\u0027port_uuid_list\u0027] \u003d port_uuid_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_cd5a244e","line":2164,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":2161,"context_line":"                            type\u003d\u0027STORAGE\u0027,"},{"line_number":2162,"context_line":"                            vdu_id\u003dvol_rsc[\u0027get_resource\u0027],"},{"line_number":2163,"context_line":"                            resource_template_id\u003dresource_name)"},{"line_number":2164,"context_line":"                        addResources.append(rsc)"},{"line_number":2165,"context_line":"                        storage_uuid_list.append(add_uuid)"},{"line_number":2166,"context_line":"            vnf_info[\u0027uuid_list\u0027] \u003d uuid_list"},{"line_number":2167,"context_line":"            vnf_info[\u0027port_uuid_list\u0027] \u003d port_uuid_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_79b73af7","line":2164,"in_reply_to":"9f560f44_cd5a244e","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":2208,"context_line":"                                    resource\u003dobjects.ResourceHandle("},{"line_number":2209,"context_line":"                                        vim_connection_id\u003dvim_id,"},{"line_number":2210,"context_line":"                                        resource_id\u003drsc_id))"},{"line_number":2211,"context_line":"                                removeResources.append(resource)"},{"line_number":2212,"context_line":"                    if rsc.resource_type \u003d\u003d \u0027OS::Neutron::Port\u0027:"},{"line_number":2213,"context_line":"                        for vl_resource in \\"},{"line_number":2214,"context_line":"                                inst_info.vnf_virtual_link_resource_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2d56402b","line":2211,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":2208,"context_line":"                                    resource\u003dobjects.ResourceHandle("},{"line_number":2209,"context_line":"                                        vim_connection_id\u003dvim_id,"},{"line_number":2210,"context_line":"                                        resource_id\u003drsc_id))"},{"line_number":2211,"context_line":"                                removeResources.append(resource)"},{"line_number":2212,"context_line":"                    if rsc.resource_type \u003d\u003d \u0027OS::Neutron::Port\u0027:"},{"line_number":2213,"context_line":"                        for vl_resource in \\"},{"line_number":2214,"context_line":"                                inst_info.vnf_virtual_link_resource_info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b99b9262","line":2211,"in_reply_to":"9f560f44_2d56402b","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":2240,"context_line":"                                                rs.vdu_id \u003d v_id"},{"line_number":2241,"context_line":"                                                rs.resource_template_id \u003d d_id"},{"line_number":2242,"context_line":"                                                rs.resource \u003d r_hd"},{"line_number":2243,"context_line":"                                                removeResources.append("},{"line_number":2244,"context_line":"                                                    rs)"},{"line_number":2245,"context_line":"                    if rsc.resource_type \u003d\u003d \u0027OS::Cinder::Volume\u0027:"},{"line_number":2246,"context_line":"                        st_info \u003d inst_info.virtual_storage_resource_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0d51bc30","line":2243,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":2240,"context_line":"                                                rs.vdu_id \u003d v_id"},{"line_number":2241,"context_line":"                                                rs.resource_template_id \u003d d_id"},{"line_number":2242,"context_line":"                                                rs.resource \u003d r_hd"},{"line_number":2243,"context_line":"                                                removeResources.append("},{"line_number":2244,"context_line":"                                                    rs)"},{"line_number":2245,"context_line":"                    if rsc.resource_type \u003d\u003d \u0027OS::Cinder::Volume\u0027:"},{"line_number":2246,"context_line":"                        st_info \u003d inst_info.virtual_storage_resource_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_59b4f6d4","line":2243,"in_reply_to":"9f560f44_0d51bc30","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8ba19a138ef99e58f3507ff7fbf14032ace67202","unresolved":false,"context_lines":[{"line_number":2075,"context_line":"                                        cinder[\u0027volume_id\u0027][\u0027get_resource\u0027])"},{"line_number":2076,"context_line":"        return cinder_list"},{"line_number":2077,"context_line":""},{"line_number":2078,"context_line":"    def get_grant_resource("},{"line_number":2079,"context_line":"            self,"},{"line_number":2080,"context_line":"            vnf_instance,"},{"line_number":2081,"context_line":"            vnf_info,"},{"line_number":2082,"context_line":"            scale_vnf_request,"},{"line_number":2083,"context_line":"            placement_obj_list,"},{"line_number":2084,"context_line":"            vim_connection_info,"},{"line_number":2085,"context_line":"            del_list):"},{"line_number":2086,"context_line":"        addResources \u003d []"},{"line_number":2087,"context_line":"        removeResources \u003d []"},{"line_number":2088,"context_line":"        affinity_list \u003d []"},{"line_number":2089,"context_line":"        placement_constraint_list \u003d []"},{"line_number":2090,"context_line":"        if scale_vnf_request.type \u003d\u003d \u0027SCALE_OUT\u0027:"},{"line_number":2091,"context_line":"            uuid_list \u003d []"},{"line_number":2092,"context_line":"            port_uuid_list \u003d []"},{"line_number":2093,"context_line":"            storage_uuid_list \u003d []"},{"line_number":2094,"context_line":"            heat_template \u003d vnf_info[\u0027attributes\u0027][\u0027heat_template\u0027]"},{"line_number":2095,"context_line":"            heat_resource \u003d yaml.safe_load(heat_template)"},{"line_number":2096,"context_line":"            key_vnfd \u003d scale_vnf_request.aspect_id + \u0027_scale_out\u0027"},{"line_number":2097,"context_line":"            ajust_prop \u003d heat_resource[\u0027resources\u0027][key_vnfd][\u0027properties\u0027]"},{"line_number":2098,"context_line":"            ajust \u003d ajust_prop[\u0027scaling_adjustment\u0027]"},{"line_number":2099,"context_line":"            size \u003d ajust * scale_vnf_request.number_of_steps"},{"line_number":2100,"context_line":"            yaml_name \u003d scale_vnf_request.aspect_id + \u0027_res.yaml\u0027"},{"line_number":2101,"context_line":"            if not vnf_info[\u0027attributes\u0027].get(yaml_name):"},{"line_number":2102,"context_line":"                yaml_name \u003d scale_vnf_request.aspect_id + \u0027.hot.yaml\u0027"},{"line_number":2103,"context_line":"            nested_hot \u003d yaml.safe_load("},{"line_number":2104,"context_line":"                vnf_info[\u0027attributes\u0027][yaml_name])"},{"line_number":2105,"context_line":"            for resource_name, resource in nested_hot[\u0027resources\u0027].items():"},{"line_number":2106,"context_line":"                if resource[\u0027type\u0027] \u003d\u003d \u0027OS::Nova::Server\u0027:"},{"line_number":2107,"context_line":"                    for i in range(size):"},{"line_number":2108,"context_line":"                        add_uuid \u003d uuidutils.generate_uuid()"},{"line_number":2109,"context_line":"                        rsc \u003d objects.ResourceDefinition("},{"line_number":2110,"context_line":"                            id\u003dadd_uuid,"},{"line_number":2111,"context_line":"                            type\u003d\u0027COMPUTE\u0027,"},{"line_number":2112,"context_line":"                            vdu_id\u003dresource_name,"},{"line_number":2113,"context_line":"                            resource_template_id\u003dresource_name)"},{"line_number":2114,"context_line":"                        addResources.append(rsc)"},{"line_number":2115,"context_line":"                        uuid_list.append(add_uuid)"},{"line_number":2116,"context_line":"                        for net in resource.get(\u0027networks\u0027, []):"},{"line_number":2117,"context_line":"                            add_uuid \u003d uuidutils.generate_uuid()"},{"line_number":2118,"context_line":"                            port_rsc \u003d net[\u0027port\u0027][\u0027get_resource\u0027]"},{"line_number":2119,"context_line":"                            rsc \u003d objects.ResourceDefinition("},{"line_number":2120,"context_line":"                                id\u003dadd_uuid,"},{"line_number":2121,"context_line":"                                type\u003d\u0027LINKPORT\u0027,"},{"line_number":2122,"context_line":"                                vdu_id\u003dresource_name,"},{"line_number":2123,"context_line":"                                resource_template_id\u003dport_rsc)"},{"line_number":2124,"context_line":"                            addResources.append(rsc)"},{"line_number":2125,"context_line":"                            port_uuid_list.append(add_uuid)"},{"line_number":2126,"context_line":"                    if resource[\u0027properties\u0027].get(\u0027block_device_mapping_v2\u0027):"},{"line_number":2127,"context_line":"                        for i in range(size):"},{"line_number":2128,"context_line":"                            for cinder in resource[\u0027properties\u0027].get("},{"line_number":2129,"context_line":"                                    \u0027block_device_mapping_v2\u0027, []):"},{"line_number":2130,"context_line":"                                add_uuid \u003d uuidutils.generate_uuid()"},{"line_number":2131,"context_line":"                                vol_rsc \u003d cinder[\u0027volume_id\u0027][\u0027get_resource\u0027]"},{"line_number":2132,"context_line":"                                rsc \u003d objects.ResourceDefinition("},{"line_number":2133,"context_line":"                                    id\u003dadd_uuid,"},{"line_number":2134,"context_line":"                                    type\u003d\u0027STORAGE\u0027,"},{"line_number":2135,"context_line":"                                    vdu_id\u003dresource_name,"},{"line_number":2136,"context_line":"                                    resource_template_id\u003dvol_rsc)"},{"line_number":2137,"context_line":"                                addResources.append(rsc)"},{"line_number":2138,"context_line":"                                storage_uuid_list.append(add_uuid)"},{"line_number":2139,"context_line":"                    if resource[\u0027properties\u0027].get(\u0027scheduler_hints\u0027):"},{"line_number":2140,"context_line":"                        sch_hint \u003d resource[\u0027properties\u0027][\u0027scheduler_hints\u0027]"},{"line_number":2141,"context_line":"                        if sch_hint[\u0027group\u0027].get(\u0027get_param\u0027):"},{"line_number":2142,"context_line":"                            affinity_name \u003d sch_hint[\u0027group\u0027][\u0027get_param\u0027]"},{"line_number":2143,"context_line":"                        else:"},{"line_number":2144,"context_line":"                            affinity_name \u003d sch_hint[\u0027group\u0027][\u0027get_resource\u0027]"},{"line_number":2145,"context_line":"                        for placement in placement_obj_list:"},{"line_number":2146,"context_line":"                            if placement.server_group_name \u003d\u003d affinity_name:"},{"line_number":2147,"context_line":"                                for uuid in uuid_list:"},{"line_number":2148,"context_line":"                                    rsc \u003d objects.ConstraintResourceRef("},{"line_number":2149,"context_line":"                                        id_type\u003d\u0027GRANT\u0027, resource_id\u003duuid)"},{"line_number":2150,"context_line":"                                    plm \u003d jsonutils.loads(placement.resource)"},{"line_number":2151,"context_line":"                                    plm.append(rsc.to_dict())"},{"line_number":2152,"context_line":"                                    placement.resource \u003d jsonutils.dumps(plm)"},{"line_number":2153,"context_line":"                                affinity_list.append(affinity_name)"},{"line_number":2154,"context_line":"                                break"},{"line_number":2155,"context_line":"                if resource[\u0027type\u0027] \u003d\u003d \u0027OS::Cinder::VolumeAttachment\u0027:"},{"line_number":2156,"context_line":"                    for i in range(size):"},{"line_number":2157,"context_line":"                        add_uuid \u003d uuidutils.generate_uuid()"},{"line_number":2158,"context_line":"                        vol_rsc \u003d resource[\u0027properties\u0027][\u0027instance_uuid\u0027]"},{"line_number":2159,"context_line":"                        rsc \u003d objects.ResourceDefinition("},{"line_number":2160,"context_line":"                            id\u003dadd_uuid,"},{"line_number":2161,"context_line":"                            type\u003d\u0027STORAGE\u0027,"},{"line_number":2162,"context_line":"                            vdu_id\u003dvol_rsc[\u0027get_resource\u0027],"},{"line_number":2163,"context_line":"                            resource_template_id\u003dresource_name)"},{"line_number":2164,"context_line":"                        addResources.append(rsc)"},{"line_number":2165,"context_line":"                        storage_uuid_list.append(add_uuid)"},{"line_number":2166,"context_line":"            vnf_info[\u0027uuid_list\u0027] \u003d uuid_list"},{"line_number":2167,"context_line":"            vnf_info[\u0027port_uuid_list\u0027] \u003d port_uuid_list"},{"line_number":2168,"context_line":"            vnf_info[\u0027storage_uuid_list\u0027] \u003d storage_uuid_list"},{"line_number":2169,"context_line":"            for placement in placement_obj_list:"},{"line_number":2170,"context_line":"                if placement.server_group_name in affinity_list:"},{"line_number":2171,"context_line":"                    plm \u003d jsonutils.loads(placement.resource)"},{"line_number":2172,"context_line":"                    addRsc \u003d []"},{"line_number":2173,"context_line":"                    for pl in plm:"},{"line_number":2174,"context_line":"                        vim_id \u003d pl.get(\u0027vim_connection_id\u0027)"},{"line_number":2175,"context_line":"                        addRsc.append("},{"line_number":2176,"context_line":"                            objects.ConstraintResourceRef("},{"line_number":2177,"context_line":"                                id_type\u003dpl[\u0027id_type\u0027],"},{"line_number":2178,"context_line":"                                resource_id\u003dpl[\u0027resource_id\u0027],"},{"line_number":2179,"context_line":"                                vim_connection_id\u003dvim_id))"},{"line_number":2180,"context_line":"                    placement_constraint \u003d objects.PlacementConstraint("},{"line_number":2181,"context_line":"                        affinity_or_anti_affinity\u003d\u0027ANTI_AFFINITY\u0027,"},{"line_number":2182,"context_line":"                        scope\u003d\u0027ZONE\u0027,"},{"line_number":2183,"context_line":"                        resource\u003daddRsc,"},{"line_number":2184,"context_line":"                        fallback_best_effort\u003dTrue)"},{"line_number":2185,"context_line":"                    placement_constraint_list.append(placement_constraint)"},{"line_number":2186,"context_line":"        else:"},{"line_number":2187,"context_line":"            access_info \u003d vim_connection_info.access_info"},{"line_number":2188,"context_line":""},{"line_number":2189,"context_line":"            heatclient \u003d hc.HeatClient(access_info,"},{"line_number":2190,"context_line":"                region_name\u003daccess_info.get(\u0027region\u0027))"},{"line_number":2191,"context_line":"            inst_info \u003d vnf_instance.instantiated_vnf_info"},{"line_number":2192,"context_line":"            for del_rsc in del_list:"},{"line_number":2193,"context_line":"                scale_resurce_list \u003d heatclient.resource_get_list(del_rsc)"},{"line_number":2194,"context_line":"                for rsc in scale_resurce_list:"},{"line_number":2195,"context_line":"                    if rsc.resource_type \u003d\u003d \u0027OS::Nova::Server\u0027:"},{"line_number":2196,"context_line":"                        for vnfc_resource in inst_info.vnfc_resource_info:"},{"line_number":2197,"context_line":"                            if vnfc_resource.\\"},{"line_number":2198,"context_line":"                                compute_resource.resource_id \u003d\u003d \\"},{"line_number":2199,"context_line":"                                    rsc.physical_resource_id:"},{"line_number":2200,"context_line":"                                cmo_rsc \u003d vnfc_resource.compute_resource"},{"line_number":2201,"context_line":"                                vim_id \u003d cmo_rsc.vim_connection_id"},{"line_number":2202,"context_line":"                                rsc_id \u003d cmo_rsc.resource_id"},{"line_number":2203,"context_line":"                                resource \u003d objects.ResourceDefinition("},{"line_number":2204,"context_line":"                                    id\u003dvnfc_resource.id,"},{"line_number":2205,"context_line":"                                    type\u003d\u0027COMPUTE\u0027,"},{"line_number":2206,"context_line":"                                    vdu_id\u003dvnfc_resource.vdu_id,"},{"line_number":2207,"context_line":"                                    resource_template_id\u003dvnfc_resource.vdu_id,"},{"line_number":2208,"context_line":"                                    resource\u003dobjects.ResourceHandle("},{"line_number":2209,"context_line":"                                        vim_connection_id\u003dvim_id,"},{"line_number":2210,"context_line":"                                        resource_id\u003drsc_id))"},{"line_number":2211,"context_line":"                                removeResources.append(resource)"},{"line_number":2212,"context_line":"                    if rsc.resource_type \u003d\u003d \u0027OS::Neutron::Port\u0027:"},{"line_number":2213,"context_line":"                        for vl_resource in \\"},{"line_number":2214,"context_line":"                                inst_info.vnf_virtual_link_resource_info:"},{"line_number":2215,"context_line":"                            for cp_resource in vl_resource.vnf_link_ports:"},{"line_number":2216,"context_line":"                                cp_handl \u003d cp_resource.resource_handle"},{"line_number":2217,"context_line":"                                cp_id \u003d cp_handl.resource_id"},{"line_number":2218,"context_line":"                                vim_id \u003d cp_handl.vim_connection_id"},{"line_number":2219,"context_line":"                                if cp_id \u003d\u003d rsc.physical_resource_id:"},{"line_number":2220,"context_line":"                                    for vnfc_resource in inst_info.\\"},{"line_number":2221,"context_line":"                                            vnfc_resource_info:"},{"line_number":2222,"context_line":"                                        for vnfc_cp_rsc in vnfc_resource.\\"},{"line_number":2223,"context_line":"                                                vnfc_cp_info:"},{"line_number":2224,"context_line":"                                            if cp_resource.\\"},{"line_number":2225,"context_line":"                                                cp_instance_id \u003d\u003d \\"},{"line_number":2226,"context_line":"                                                    vnfc_cp_rsc.id:"},{"line_number":2227,"context_line":"                                                p_id \u003d cp_resource.id"},{"line_number":2228,"context_line":"                                                v_id \u003d vnfc_resource.vdu_id"},{"line_number":2229,"context_line":"                                                d_id \u003d vnfc_cp_rsc.cpd_id"},{"line_number":2230,"context_line":"                                                r_hd \u003d objects.\\"},{"line_number":2231,"context_line":"                                                    ResourceHandle()"},{"line_number":2232,"context_line":"                                                r_hd.\\"},{"line_number":2233,"context_line":"                                                    vim_connection_id \u003d \\"},{"line_number":2234,"context_line":"                                                    vim_id"},{"line_number":2235,"context_line":"                                                r_hd.resource_id \u003d cp_id"},{"line_number":2236,"context_line":"                                                rs \u003d objects.\\"},{"line_number":2237,"context_line":"                                                    ResourceDefinition()"},{"line_number":2238,"context_line":"                                                rs.id \u003d p_id"},{"line_number":2239,"context_line":"                                                rs.type \u003d \u0027LINKPORT\u0027"},{"line_number":2240,"context_line":"                                                rs.vdu_id \u003d v_id"},{"line_number":2241,"context_line":"                                                rs.resource_template_id \u003d d_id"},{"line_number":2242,"context_line":"                                                rs.resource \u003d r_hd"},{"line_number":2243,"context_line":"                                                removeResources.append("},{"line_number":2244,"context_line":"                                                    rs)"},{"line_number":2245,"context_line":"                    if rsc.resource_type \u003d\u003d \u0027OS::Cinder::Volume\u0027:"},{"line_number":2246,"context_line":"                        st_info \u003d inst_info.virtual_storage_resource_info"},{"line_number":2247,"context_line":"                        for storage_resource in st_info:"},{"line_number":2248,"context_line":"                            st_rsc \u003d storage_resource.storage_resource"},{"line_number":2249,"context_line":"                            st_id \u003d st_rsc.resource_id"},{"line_number":2250,"context_line":"                            if st_id \u003d\u003d rsc.physical_resource_id:"},{"line_number":2251,"context_line":"                                ins_vnfc \u003d inst_info.vnfc_resource_info"},{"line_number":2252,"context_line":"                                for vnfc_resource in ins_vnfc:"},{"line_number":2253,"context_line":"                                    s_ids \u003d vnfc_resource.storage_resource_ids"},{"line_number":2254,"context_line":"                                    if storage_resource.id in s_ids:"},{"line_number":2255,"context_line":"                                        rs \u003d objects.ResourceDefinition()"},{"line_number":2256,"context_line":"                                        rs.id \u003d storage_resource.id"},{"line_number":2257,"context_line":"                                        rs.type \u003d \u0027STORAGE\u0027"},{"line_number":2258,"context_line":"                                        rs.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":2259,"context_line":"                                        tmp_id \u003d storage_resource.\\"},{"line_number":2260,"context_line":"                                            virtual_storage_desc_id"},{"line_number":2261,"context_line":"                                        rs.resource_template_id \u003d tmp_id"},{"line_number":2262,"context_line":"                                        r_hd \u003d objects.ResourceHandle()"},{"line_number":2263,"context_line":"                                        vim_id \u003d st_rsc.vim_connection_id"},{"line_number":2264,"context_line":"                                        rsc_id \u003d st_rsc.resource_id"},{"line_number":2265,"context_line":"                                        r_hd.vim_connection_id \u003d vim_id"},{"line_number":2266,"context_line":"                                        r_hd.resource_id \u003d rsc_id"},{"line_number":2267,"context_line":"                                        rs.resource \u003d r_hd"},{"line_number":2268,"context_line":"                                        removeResources.append(rs)"},{"line_number":2269,"context_line":"        vnf_info[\u0027addResources\u0027] \u003d addResources"},{"line_number":2270,"context_line":"        vnf_info[\u0027removeResources\u0027] \u003d removeResources"},{"line_number":2271,"context_line":"        vnf_info[\u0027affinity_list\u0027] \u003d affinity_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ee05b57b","line":2268,"range":{"start_line":2078,"start_character":4,"end_line":2268,"end_character":66},"updated":"2020-09-08 06:58:54.000000000","message":"The nest is too deep and less readable.\nIs it possible to improve?\nFor example, define the sub method and move some logics to new sub method.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":2075,"context_line":"                                        cinder[\u0027volume_id\u0027][\u0027get_resource\u0027])"},{"line_number":2076,"context_line":"        return cinder_list"},{"line_number":2077,"context_line":""},{"line_number":2078,"context_line":"    def get_grant_resource("},{"line_number":2079,"context_line":"            self,"},{"line_number":2080,"context_line":"            vnf_instance,"},{"line_number":2081,"context_line":"            vnf_info,"},{"line_number":2082,"context_line":"            scale_vnf_request,"},{"line_number":2083,"context_line":"            placement_obj_list,"},{"line_number":2084,"context_line":"            vim_connection_info,"},{"line_number":2085,"context_line":"            del_list):"},{"line_number":2086,"context_line":"        addResources \u003d []"},{"line_number":2087,"context_line":"        removeResources \u003d []"},{"line_number":2088,"context_line":"        affinity_list \u003d []"},{"line_number":2089,"context_line":"        placement_constraint_list \u003d []"},{"line_number":2090,"context_line":"        if scale_vnf_request.type \u003d\u003d \u0027SCALE_OUT\u0027:"},{"line_number":2091,"context_line":"            uuid_list \u003d []"},{"line_number":2092,"context_line":"            port_uuid_list \u003d []"},{"line_number":2093,"context_line":"            storage_uuid_list \u003d []"},{"line_number":2094,"context_line":"            heat_template \u003d vnf_info[\u0027attributes\u0027][\u0027heat_template\u0027]"},{"line_number":2095,"context_line":"            heat_resource \u003d yaml.safe_load(heat_template)"},{"line_number":2096,"context_line":"            key_vnfd \u003d scale_vnf_request.aspect_id + \u0027_scale_out\u0027"},{"line_number":2097,"context_line":"            ajust_prop \u003d heat_resource[\u0027resources\u0027][key_vnfd][\u0027properties\u0027]"},{"line_number":2098,"context_line":"            ajust \u003d ajust_prop[\u0027scaling_adjustment\u0027]"},{"line_number":2099,"context_line":"            size \u003d ajust * scale_vnf_request.number_of_steps"},{"line_number":2100,"context_line":"            yaml_name \u003d scale_vnf_request.aspect_id + \u0027_res.yaml\u0027"},{"line_number":2101,"context_line":"            if not vnf_info[\u0027attributes\u0027].get(yaml_name):"},{"line_number":2102,"context_line":"                yaml_name \u003d scale_vnf_request.aspect_id + \u0027.hot.yaml\u0027"},{"line_number":2103,"context_line":"            nested_hot \u003d yaml.safe_load("},{"line_number":2104,"context_line":"                vnf_info[\u0027attributes\u0027][yaml_name])"},{"line_number":2105,"context_line":"            for resource_name, resource in nested_hot[\u0027resources\u0027].items():"},{"line_number":2106,"context_line":"                if resource[\u0027type\u0027] \u003d\u003d \u0027OS::Nova::Server\u0027:"},{"line_number":2107,"context_line":"                    for i in range(size):"},{"line_number":2108,"context_line":"                        add_uuid \u003d uuidutils.generate_uuid()"},{"line_number":2109,"context_line":"                        rsc \u003d objects.ResourceDefinition("},{"line_number":2110,"context_line":"                            id\u003dadd_uuid,"},{"line_number":2111,"context_line":"                            type\u003d\u0027COMPUTE\u0027,"},{"line_number":2112,"context_line":"                            vdu_id\u003dresource_name,"},{"line_number":2113,"context_line":"                            resource_template_id\u003dresource_name)"},{"line_number":2114,"context_line":"                        addResources.append(rsc)"},{"line_number":2115,"context_line":"                        uuid_list.append(add_uuid)"},{"line_number":2116,"context_line":"                        for net in resource.get(\u0027networks\u0027, []):"},{"line_number":2117,"context_line":"                            add_uuid \u003d uuidutils.generate_uuid()"},{"line_number":2118,"context_line":"                            port_rsc \u003d net[\u0027port\u0027][\u0027get_resource\u0027]"},{"line_number":2119,"context_line":"                            rsc \u003d objects.ResourceDefinition("},{"line_number":2120,"context_line":"                                id\u003dadd_uuid,"},{"line_number":2121,"context_line":"                                type\u003d\u0027LINKPORT\u0027,"},{"line_number":2122,"context_line":"                                vdu_id\u003dresource_name,"},{"line_number":2123,"context_line":"                                resource_template_id\u003dport_rsc)"},{"line_number":2124,"context_line":"                            addResources.append(rsc)"},{"line_number":2125,"context_line":"                            port_uuid_list.append(add_uuid)"},{"line_number":2126,"context_line":"                    if resource[\u0027properties\u0027].get(\u0027block_device_mapping_v2\u0027):"},{"line_number":2127,"context_line":"                        for i in range(size):"},{"line_number":2128,"context_line":"                            for cinder in resource[\u0027properties\u0027].get("},{"line_number":2129,"context_line":"                                    \u0027block_device_mapping_v2\u0027, []):"},{"line_number":2130,"context_line":"                                add_uuid \u003d uuidutils.generate_uuid()"},{"line_number":2131,"context_line":"                                vol_rsc \u003d cinder[\u0027volume_id\u0027][\u0027get_resource\u0027]"},{"line_number":2132,"context_line":"                                rsc \u003d objects.ResourceDefinition("},{"line_number":2133,"context_line":"                                    id\u003dadd_uuid,"},{"line_number":2134,"context_line":"                                    type\u003d\u0027STORAGE\u0027,"},{"line_number":2135,"context_line":"                                    vdu_id\u003dresource_name,"},{"line_number":2136,"context_line":"                                    resource_template_id\u003dvol_rsc)"},{"line_number":2137,"context_line":"                                addResources.append(rsc)"},{"line_number":2138,"context_line":"                                storage_uuid_list.append(add_uuid)"},{"line_number":2139,"context_line":"                    if resource[\u0027properties\u0027].get(\u0027scheduler_hints\u0027):"},{"line_number":2140,"context_line":"                        sch_hint \u003d resource[\u0027properties\u0027][\u0027scheduler_hints\u0027]"},{"line_number":2141,"context_line":"                        if sch_hint[\u0027group\u0027].get(\u0027get_param\u0027):"},{"line_number":2142,"context_line":"                            affinity_name \u003d sch_hint[\u0027group\u0027][\u0027get_param\u0027]"},{"line_number":2143,"context_line":"                        else:"},{"line_number":2144,"context_line":"                            affinity_name \u003d sch_hint[\u0027group\u0027][\u0027get_resource\u0027]"},{"line_number":2145,"context_line":"                        for placement in placement_obj_list:"},{"line_number":2146,"context_line":"                            if placement.server_group_name \u003d\u003d affinity_name:"},{"line_number":2147,"context_line":"                                for uuid in uuid_list:"},{"line_number":2148,"context_line":"                                    rsc \u003d objects.ConstraintResourceRef("},{"line_number":2149,"context_line":"                                        id_type\u003d\u0027GRANT\u0027, resource_id\u003duuid)"},{"line_number":2150,"context_line":"                                    plm \u003d jsonutils.loads(placement.resource)"},{"line_number":2151,"context_line":"                                    plm.append(rsc.to_dict())"},{"line_number":2152,"context_line":"                                    placement.resource \u003d jsonutils.dumps(plm)"},{"line_number":2153,"context_line":"                                affinity_list.append(affinity_name)"},{"line_number":2154,"context_line":"                                break"},{"line_number":2155,"context_line":"                if resource[\u0027type\u0027] \u003d\u003d \u0027OS::Cinder::VolumeAttachment\u0027:"},{"line_number":2156,"context_line":"                    for i in range(size):"},{"line_number":2157,"context_line":"                        add_uuid \u003d uuidutils.generate_uuid()"},{"line_number":2158,"context_line":"                        vol_rsc \u003d resource[\u0027properties\u0027][\u0027instance_uuid\u0027]"},{"line_number":2159,"context_line":"                        rsc \u003d objects.ResourceDefinition("},{"line_number":2160,"context_line":"                            id\u003dadd_uuid,"},{"line_number":2161,"context_line":"                            type\u003d\u0027STORAGE\u0027,"},{"line_number":2162,"context_line":"                            vdu_id\u003dvol_rsc[\u0027get_resource\u0027],"},{"line_number":2163,"context_line":"                            resource_template_id\u003dresource_name)"},{"line_number":2164,"context_line":"                        addResources.append(rsc)"},{"line_number":2165,"context_line":"                        storage_uuid_list.append(add_uuid)"},{"line_number":2166,"context_line":"            vnf_info[\u0027uuid_list\u0027] \u003d uuid_list"},{"line_number":2167,"context_line":"            vnf_info[\u0027port_uuid_list\u0027] \u003d port_uuid_list"},{"line_number":2168,"context_line":"            vnf_info[\u0027storage_uuid_list\u0027] \u003d storage_uuid_list"},{"line_number":2169,"context_line":"            for placement in placement_obj_list:"},{"line_number":2170,"context_line":"                if placement.server_group_name in affinity_list:"},{"line_number":2171,"context_line":"                    plm \u003d jsonutils.loads(placement.resource)"},{"line_number":2172,"context_line":"                    addRsc \u003d []"},{"line_number":2173,"context_line":"                    for pl in plm:"},{"line_number":2174,"context_line":"                        vim_id \u003d pl.get(\u0027vim_connection_id\u0027)"},{"line_number":2175,"context_line":"                        addRsc.append("},{"line_number":2176,"context_line":"                            objects.ConstraintResourceRef("},{"line_number":2177,"context_line":"                                id_type\u003dpl[\u0027id_type\u0027],"},{"line_number":2178,"context_line":"                                resource_id\u003dpl[\u0027resource_id\u0027],"},{"line_number":2179,"context_line":"                                vim_connection_id\u003dvim_id))"},{"line_number":2180,"context_line":"                    placement_constraint \u003d objects.PlacementConstraint("},{"line_number":2181,"context_line":"                        affinity_or_anti_affinity\u003d\u0027ANTI_AFFINITY\u0027,"},{"line_number":2182,"context_line":"                        scope\u003d\u0027ZONE\u0027,"},{"line_number":2183,"context_line":"                        resource\u003daddRsc,"},{"line_number":2184,"context_line":"                        fallback_best_effort\u003dTrue)"},{"line_number":2185,"context_line":"                    placement_constraint_list.append(placement_constraint)"},{"line_number":2186,"context_line":"        else:"},{"line_number":2187,"context_line":"            access_info \u003d vim_connection_info.access_info"},{"line_number":2188,"context_line":""},{"line_number":2189,"context_line":"            heatclient \u003d hc.HeatClient(access_info,"},{"line_number":2190,"context_line":"                region_name\u003daccess_info.get(\u0027region\u0027))"},{"line_number":2191,"context_line":"            inst_info \u003d vnf_instance.instantiated_vnf_info"},{"line_number":2192,"context_line":"            for del_rsc in del_list:"},{"line_number":2193,"context_line":"                scale_resurce_list \u003d heatclient.resource_get_list(del_rsc)"},{"line_number":2194,"context_line":"                for rsc in scale_resurce_list:"},{"line_number":2195,"context_line":"                    if rsc.resource_type \u003d\u003d \u0027OS::Nova::Server\u0027:"},{"line_number":2196,"context_line":"                        for vnfc_resource in inst_info.vnfc_resource_info:"},{"line_number":2197,"context_line":"                            if vnfc_resource.\\"},{"line_number":2198,"context_line":"                                compute_resource.resource_id \u003d\u003d \\"},{"line_number":2199,"context_line":"                                    rsc.physical_resource_id:"},{"line_number":2200,"context_line":"                                cmo_rsc \u003d vnfc_resource.compute_resource"},{"line_number":2201,"context_line":"                                vim_id \u003d cmo_rsc.vim_connection_id"},{"line_number":2202,"context_line":"                                rsc_id \u003d cmo_rsc.resource_id"},{"line_number":2203,"context_line":"                                resource \u003d objects.ResourceDefinition("},{"line_number":2204,"context_line":"                                    id\u003dvnfc_resource.id,"},{"line_number":2205,"context_line":"                                    type\u003d\u0027COMPUTE\u0027,"},{"line_number":2206,"context_line":"                                    vdu_id\u003dvnfc_resource.vdu_id,"},{"line_number":2207,"context_line":"                                    resource_template_id\u003dvnfc_resource.vdu_id,"},{"line_number":2208,"context_line":"                                    resource\u003dobjects.ResourceHandle("},{"line_number":2209,"context_line":"                                        vim_connection_id\u003dvim_id,"},{"line_number":2210,"context_line":"                                        resource_id\u003drsc_id))"},{"line_number":2211,"context_line":"                                removeResources.append(resource)"},{"line_number":2212,"context_line":"                    if rsc.resource_type \u003d\u003d \u0027OS::Neutron::Port\u0027:"},{"line_number":2213,"context_line":"                        for vl_resource in \\"},{"line_number":2214,"context_line":"                                inst_info.vnf_virtual_link_resource_info:"},{"line_number":2215,"context_line":"                            for cp_resource in vl_resource.vnf_link_ports:"},{"line_number":2216,"context_line":"                                cp_handl \u003d cp_resource.resource_handle"},{"line_number":2217,"context_line":"                                cp_id \u003d cp_handl.resource_id"},{"line_number":2218,"context_line":"                                vim_id \u003d cp_handl.vim_connection_id"},{"line_number":2219,"context_line":"                                if cp_id \u003d\u003d rsc.physical_resource_id:"},{"line_number":2220,"context_line":"                                    for vnfc_resource in inst_info.\\"},{"line_number":2221,"context_line":"                                            vnfc_resource_info:"},{"line_number":2222,"context_line":"                                        for vnfc_cp_rsc in vnfc_resource.\\"},{"line_number":2223,"context_line":"                                                vnfc_cp_info:"},{"line_number":2224,"context_line":"                                            if cp_resource.\\"},{"line_number":2225,"context_line":"                                                cp_instance_id \u003d\u003d \\"},{"line_number":2226,"context_line":"                                                    vnfc_cp_rsc.id:"},{"line_number":2227,"context_line":"                                                p_id \u003d cp_resource.id"},{"line_number":2228,"context_line":"                                                v_id \u003d vnfc_resource.vdu_id"},{"line_number":2229,"context_line":"                                                d_id \u003d vnfc_cp_rsc.cpd_id"},{"line_number":2230,"context_line":"                                                r_hd \u003d objects.\\"},{"line_number":2231,"context_line":"                                                    ResourceHandle()"},{"line_number":2232,"context_line":"                                                r_hd.\\"},{"line_number":2233,"context_line":"                                                    vim_connection_id \u003d \\"},{"line_number":2234,"context_line":"                                                    vim_id"},{"line_number":2235,"context_line":"                                                r_hd.resource_id \u003d cp_id"},{"line_number":2236,"context_line":"                                                rs \u003d objects.\\"},{"line_number":2237,"context_line":"                                                    ResourceDefinition()"},{"line_number":2238,"context_line":"                                                rs.id \u003d p_id"},{"line_number":2239,"context_line":"                                                rs.type \u003d \u0027LINKPORT\u0027"},{"line_number":2240,"context_line":"                                                rs.vdu_id \u003d v_id"},{"line_number":2241,"context_line":"                                                rs.resource_template_id \u003d d_id"},{"line_number":2242,"context_line":"                                                rs.resource \u003d r_hd"},{"line_number":2243,"context_line":"                                                removeResources.append("},{"line_number":2244,"context_line":"                                                    rs)"},{"line_number":2245,"context_line":"                    if rsc.resource_type \u003d\u003d \u0027OS::Cinder::Volume\u0027:"},{"line_number":2246,"context_line":"                        st_info \u003d inst_info.virtual_storage_resource_info"},{"line_number":2247,"context_line":"                        for storage_resource in st_info:"},{"line_number":2248,"context_line":"                            st_rsc \u003d storage_resource.storage_resource"},{"line_number":2249,"context_line":"                            st_id \u003d st_rsc.resource_id"},{"line_number":2250,"context_line":"                            if st_id \u003d\u003d rsc.physical_resource_id:"},{"line_number":2251,"context_line":"                                ins_vnfc \u003d inst_info.vnfc_resource_info"},{"line_number":2252,"context_line":"                                for vnfc_resource in ins_vnfc:"},{"line_number":2253,"context_line":"                                    s_ids \u003d vnfc_resource.storage_resource_ids"},{"line_number":2254,"context_line":"                                    if storage_resource.id in s_ids:"},{"line_number":2255,"context_line":"                                        rs \u003d objects.ResourceDefinition()"},{"line_number":2256,"context_line":"                                        rs.id \u003d storage_resource.id"},{"line_number":2257,"context_line":"                                        rs.type \u003d \u0027STORAGE\u0027"},{"line_number":2258,"context_line":"                                        rs.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":2259,"context_line":"                                        tmp_id \u003d storage_resource.\\"},{"line_number":2260,"context_line":"                                            virtual_storage_desc_id"},{"line_number":2261,"context_line":"                                        rs.resource_template_id \u003d tmp_id"},{"line_number":2262,"context_line":"                                        r_hd \u003d objects.ResourceHandle()"},{"line_number":2263,"context_line":"                                        vim_id \u003d st_rsc.vim_connection_id"},{"line_number":2264,"context_line":"                                        rsc_id \u003d st_rsc.resource_id"},{"line_number":2265,"context_line":"                                        r_hd.vim_connection_id \u003d vim_id"},{"line_number":2266,"context_line":"                                        r_hd.resource_id \u003d rsc_id"},{"line_number":2267,"context_line":"                                        rs.resource \u003d r_hd"},{"line_number":2268,"context_line":"                                        removeResources.append(rs)"},{"line_number":2269,"context_line":"        vnf_info[\u0027addResources\u0027] \u003d addResources"},{"line_number":2270,"context_line":"        vnf_info[\u0027removeResources\u0027] \u003d removeResources"},{"line_number":2271,"context_line":"        vnf_info[\u0027affinity_list\u0027] \u003d affinity_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b9a78da8","line":2268,"range":{"start_line":2078,"start_character":4,"end_line":2268,"end_character":66},"in_reply_to":"9f560f44_ee05b57b","updated":"2020-09-22 09:01:16.000000000","message":"Separated processing by Scale_out and Scale_in, slightly improved nesting depth","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"                                        r_hd.resource_id \u003d rsc_id"},{"line_number":2267,"context_line":"                                        rs.resource \u003d r_hd"},{"line_number":2268,"context_line":"                                        removeResources.append(rs)"},{"line_number":2269,"context_line":"        vnf_info[\u0027addResources\u0027] \u003d addResources"},{"line_number":2270,"context_line":"        vnf_info[\u0027removeResources\u0027] \u003d removeResources"},{"line_number":2271,"context_line":"        vnf_info[\u0027affinity_list\u0027] \u003d affinity_list"},{"line_number":2272,"context_line":"        vnf_info[\u0027placement_constraint_list\u0027] \u003d placement_constraint_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ed2448c8","line":2269,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"                                        r_hd.resource_id \u003d rsc_id"},{"line_number":2267,"context_line":"                                        rs.resource \u003d r_hd"},{"line_number":2268,"context_line":"                                        removeResources.append(rs)"},{"line_number":2269,"context_line":"        vnf_info[\u0027addResources\u0027] \u003d addResources"},{"line_number":2270,"context_line":"        vnf_info[\u0027removeResources\u0027] \u003d removeResources"},{"line_number":2271,"context_line":"        vnf_info[\u0027affinity_list\u0027] \u003d affinity_list"},{"line_number":2272,"context_line":"        vnf_info[\u0027placement_constraint_list\u0027] \u003d placement_constraint_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_79b3baea","line":2269,"in_reply_to":"9f560f44_ed2448c8","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3ebf36942559632aa79cdc95b9d69eca1bbb85a7","unresolved":false,"context_lines":[{"line_number":2267,"context_line":"                                        rs.resource \u003d r_hd"},{"line_number":2268,"context_line":"                                        removeResources.append(rs)"},{"line_number":2269,"context_line":"        vnf_info[\u0027addResources\u0027] \u003d addResources"},{"line_number":2270,"context_line":"        vnf_info[\u0027removeResources\u0027] \u003d removeResources"},{"line_number":2271,"context_line":"        vnf_info[\u0027affinity_list\u0027] \u003d affinity_list"},{"line_number":2272,"context_line":"        vnf_info[\u0027placement_constraint_list\u0027] \u003d placement_constraint_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_cd1fc46d","line":2270,"updated":"2020-09-11 15:52:30.000000000","message":"Variable names should be implemented in the snake case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d8c0235a7e91619fbfaefe6f30d559bcdf520b56","unresolved":false,"context_lines":[{"line_number":2267,"context_line":"                                        rs.resource \u003d r_hd"},{"line_number":2268,"context_line":"                                        removeResources.append(rs)"},{"line_number":2269,"context_line":"        vnf_info[\u0027addResources\u0027] \u003d addResources"},{"line_number":2270,"context_line":"        vnf_info[\u0027removeResources\u0027] \u003d removeResources"},{"line_number":2271,"context_line":"        vnf_info[\u0027affinity_list\u0027] \u003d affinity_list"},{"line_number":2272,"context_line":"        vnf_info[\u0027placement_constraint_list\u0027] \u003d placement_constraint_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d9c76646","line":2270,"in_reply_to":"9f560f44_cd1fc46d","updated":"2020-09-14 18:46:03.000000000","message":"Changed to snake_case.","commit_id":"043f7899b24c35cc404bd822d12a22bbba121def"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"72c44b4e3f8cf186236ea37b3ac918e62c513288","unresolved":false,"context_lines":[{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1206,"context_line":"            vnf_id \u003d vnf_instance.id"},{"line_number":1207,"context_line":"            # stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"            vnf_model \u003d ("},{"line_number":1210,"context_line":"                context.session.query("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_70b53fd0","line":1207,"range":{"start_line":1207,"start_character":0,"end_line":1207,"end_character":71},"updated":"2020-09-18 03:54:20.000000000","message":"Maybe its better to delete comment outs if they are not used","commit_id":"5987ec6ed7bcb4014f282932415285e42033d2c1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1206,"context_line":"            vnf_id \u003d vnf_instance.id"},{"line_number":1207,"context_line":"            # stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"            vnf_model \u003d ("},{"line_number":1210,"context_line":"                context.session.query("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f92905f2","line":1207,"range":{"start_line":1207,"start_character":0,"end_line":1207,"end_character":71},"in_reply_to":"9f560f44_70b53fd0","updated":"2020-09-22 09:01:16.000000000","message":"Deleted","commit_id":"5987ec6ed7bcb4014f282932415285e42033d2c1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"72c44b4e3f8cf186236ea37b3ac918e62c513288","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"            is_error\u003dFalse):"},{"line_number":1235,"context_line":"        \u0027\u0027\u0027Table unlock processing\u0027\u0027\u0027"},{"line_number":1236,"context_line":"        vnf_id \u003d vnf_instance.id"},{"line_number":1237,"context_line":"        # stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1238,"context_line":"        if not physical_resource_id:"},{"line_number":1239,"context_line":"            physical_resource_id \u003d \"\""},{"line_number":1240,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_50dd9b11","line":1237,"updated":"2020-09-18 03:54:20.000000000","message":"ditto","commit_id":"5987ec6ed7bcb4014f282932415285e42033d2c1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fbe2153004a2f131720e024057558ed457c0b45f","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"            is_error\u003dFalse):"},{"line_number":1235,"context_line":"        \u0027\u0027\u0027Table unlock processing\u0027\u0027\u0027"},{"line_number":1236,"context_line":"        vnf_id \u003d vnf_instance.id"},{"line_number":1237,"context_line":"        # stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1238,"context_line":"        if not physical_resource_id:"},{"line_number":1239,"context_line":"            physical_resource_id \u003d \"\""},{"line_number":1240,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_39309d55","line":1237,"in_reply_to":"9f560f44_50dd9b11","updated":"2020-09-22 09:01:16.000000000","message":"Deleted","commit_id":"5987ec6ed7bcb4014f282932415285e42033d2c1"}]}
