)]}'
{"api-ref/source/v1/vnflcm.inc":[{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"c7eceb480cf1c65b065130b0c005e2afbeb011f5","unresolved":false,"context_lines":[{"line_number":411,"context_line":""},{"line_number":412,"context_line":"The GET method queries information about multiple VNF instances."},{"line_number":413,"context_line":"In Victoria release, added attribute-based filtering expression (for VnfInstance)"},{"line_number":414,"context_line":"that follows 5.2 of ETSI GS NFV SOL13."},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Response Codes"},{"line_number":417,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9f560f44_0c98e218","line":414,"range":{"start_line":414,"start_character":12,"end_line":414,"end_character":13},"updated":"2020-09-23 09:32:46.000000000","message":"insert `clause`","commit_id":"9dcd60534a7404d1d4f1bf0b9616de8fd0c11432"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3e8fed54afa5af9b57fd77717d6d598df5d436b7","unresolved":false,"context_lines":[{"line_number":411,"context_line":""},{"line_number":412,"context_line":"The GET method queries information about multiple VNF instances."},{"line_number":413,"context_line":"In Victoria release, added attribute-based filtering expression (for VnfInstance)"},{"line_number":414,"context_line":"that follows 5.2 of ETSI GS NFV SOL13."},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Response Codes"},{"line_number":417,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9f560f44_168f202e","line":414,"range":{"start_line":414,"start_character":12,"end_line":414,"end_character":13},"in_reply_to":"9f560f44_0c98e218","updated":"2020-09-25 01:25:00.000000000","message":"Done","commit_id":"9dcd60534a7404d1d4f1bf0b9616de8fd0c11432"}],"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0e5153d1901c569cb6ae1738f6b85ffb95c8a991","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        filters \u003d request.GET.get(\u0027filter\u0027)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if(not filters):"},{"line_number":215,"context_line":"            vnf_instances \u003d objects.VnfInstanceList.get_all(context)"},{"line_number":216,"context_line":"        else:"},{"line_number":217,"context_line":"            filters \u003d self._view_builder.validate_filter(filters)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bcd3175f","line":214,"updated":"2020-09-04 09:39:25.000000000","message":"tacker/api/vnfpkgm/v1/controller.py\nAs mentioned above, can you fix it to an implementation that doesn\u0027t use \u0027get_all\u0027 and only \u0027uses get_by_filters\u0027?","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ee060b465d89f9e7bf14d06b55f61006f642a208","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        filters \u003d request.GET.get(\u0027filter\u0027)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if(not filters):"},{"line_number":215,"context_line":"            vnf_instances \u003d objects.VnfInstanceList.get_all(context)"},{"line_number":216,"context_line":"        else:"},{"line_number":217,"context_line":"            filters \u003d self._view_builder.validate_filter(filters)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_118edc78","line":214,"in_reply_to":"9f560f44_bcd3175f","updated":"2020-09-14 12:00:13.000000000","message":"Removed condition and use \u0027get_by_filters\u0027 only.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"}],"tacker/objects/vnf_instance.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0e5153d1901c569cb6ae1738f6b85ffb95c8a991","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"@db_api.context_manager.reader"},{"line_number":107,"context_line":"def _vnf_instance_list_by_filter(context, columns_to_join\u003dNone,"},{"line_number":108,"context_line":"                                 filters\u003dNone):"},{"line_number":109,"context_line":"    query \u003d api.model_query(context, models.VnfInstance,"},{"line_number":110,"context_line":"                            read_deleted\u003d\"no\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fc5bcff2","line":107,"updated":"2020-09-04 09:39:25.000000000","message":"tacker/objects/vnf_package.py\nAs mentioned above, can you fix it to an implementation that doesn\u0027t use \u0027_vnf_instance_list\u0027 and only \u0027_vnf_instance_list\u0027?","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e0039cdbfabb5087c7b60d4dee9934a0867487ef","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"@db_api.context_manager.reader"},{"line_number":107,"context_line":"def _vnf_instance_list_by_filter(context, columns_to_join\u003dNone,"},{"line_number":108,"context_line":"                                 filters\u003dNone):"},{"line_number":109,"context_line":"    query \u003d api.model_query(context, models.VnfInstance,"},{"line_number":110,"context_line":"                            read_deleted\u003d\"no\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e358b058","line":107,"in_reply_to":"9f560f44_069bbf16","updated":"2020-09-15 04:48:29.000000000","message":"I\u0027m sorry that the comment is difficult to understand.\ntacker / api / vnflcm / v1 / controller.py\nIt was a comment related to, but I was able to confirm that it was fixed.\nThank you.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c7c99c4f56c2a9886eb70144f2c33018fcedcbbf","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"@db_api.context_manager.reader"},{"line_number":107,"context_line":"def _vnf_instance_list_by_filter(context, columns_to_join\u003dNone,"},{"line_number":108,"context_line":"                                 filters\u003dNone):"},{"line_number":109,"context_line":"    query \u003d api.model_query(context, models.VnfInstance,"},{"line_number":110,"context_line":"                            read_deleted\u003d\"no\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_069bbf16","line":107,"in_reply_to":"9f560f44_fc5bcff2","updated":"2020-09-07 07:07:24.000000000","message":"Sorry, but I don\u0027t understand what you meant by your comment. Is it:\n\n\"..., can you fix it to an implementation that doesn\u0027t use \u0027_vnf_instance_list\u0027 and only \u0027_vnf_instance_list_by_filters\u0027?\"","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"2364fdcd87d9d54a00da179201f161aa3216e4c1","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                                                nullable\u003dTrue, default\u003dNone)"},{"line_number":161,"context_line":"    }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    ALL_ATTRIBUTES \u003d {"},{"line_number":164,"context_line":"        \u0027id\u0027: (\u0027id\u0027, \"string\", \u0027VnfInstance\u0027),"},{"line_number":165,"context_line":"        \u0027vnfInstanceName\u0027: (\u0027vnf_instance_name\u0027, \u0027string\u0027, \u0027VnfInstance\u0027),"},{"line_number":166,"context_line":"        \u0027vnfInstanceDescription\u0027: ("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7c285f96","line":163,"range":{"start_line":163,"start_character":3,"end_line":163,"end_character":18},"updated":"2020-09-04 10:09:46.000000000","message":"\"metadata\" and \"_links\" are in Type:VnfInstance in SOL003 v2.6.1. They should be added in this attribibutes list.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ee060b465d89f9e7bf14d06b55f61006f642a208","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                                                nullable\u003dTrue, default\u003dNone)"},{"line_number":161,"context_line":"    }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    ALL_ATTRIBUTES \u003d {"},{"line_number":164,"context_line":"        \u0027id\u0027: (\u0027id\u0027, \"string\", \u0027VnfInstance\u0027),"},{"line_number":165,"context_line":"        \u0027vnfInstanceName\u0027: (\u0027vnf_instance_name\u0027, \u0027string\u0027, \u0027VnfInstance\u0027),"},{"line_number":166,"context_line":"        \u0027vnfInstanceDescription\u0027: ("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b1d5704a","line":163,"range":{"start_line":163,"start_character":3,"end_line":163,"end_character":18},"in_reply_to":"9f560f44_7c285f96","updated":"2020-09-14 12:00:13.000000000","message":"Added metadata to attribute list. \"_links\" was not added since this is currently not a field in the database.\n\nfiltering using \"_links\" is impossible since these values are not stored in the DB. This is why they\u0027re not added in the attributes list","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"}],"tacker/objects/vnf_instantiated_info.py":[{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"2364fdcd87d9d54a00da179201f161aa3216e4c1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                       default\u003d{})"},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    ALL_ATTRIBUTES \u003d {"},{"line_number":85,"context_line":"        \u0027instantiatedInfo\u0027: {"},{"line_number":86,"context_line":"            \u0027flavourId\u0027: (\u0027id\u0027, \u0027string\u0027, \u0027VnfInstantiatedInfo\u0027),"},{"line_number":87,"context_line":"            \u0027vnfInstanceId\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_dc2feba4","line":84,"range":{"start_line":84,"start_character":3,"end_line":84,"end_character":18},"updated":"2020-09-04 10:09:46.000000000","message":"According to SOL003 v2.6.1, \"vnfcInfo\" is one of resource in InstantiatedVnfInfo. It should be added in this attribute.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"94bf917ea4cb98f37bf9b5e25bf292955d6e9baf","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                       default\u003d{})"},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    ALL_ATTRIBUTES \u003d {"},{"line_number":85,"context_line":"        \u0027instantiatedInfo\u0027: {"},{"line_number":86,"context_line":"            \u0027flavourId\u0027: (\u0027id\u0027, \u0027string\u0027, \u0027VnfInstantiatedInfo\u0027),"},{"line_number":87,"context_line":"            \u0027vnfInstanceId\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_970577c4","line":84,"range":{"start_line":84,"start_character":3,"end_line":84,"end_character":18},"in_reply_to":"9f560f44_11bc1c05","updated":"2020-09-17 12:25:13.000000000","message":"Where is `vnfcInfo` datatype define in this file? I think `class VnfcInfo` should be needed such as `class VnfExtCpInfo`.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"660e189e34d714ae3f459aa59aeff2b1e21171c5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                       default\u003d{})"},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    ALL_ATTRIBUTES \u003d {"},{"line_number":85,"context_line":"        \u0027instantiatedInfo\u0027: {"},{"line_number":86,"context_line":"            \u0027flavourId\u0027: (\u0027id\u0027, \u0027string\u0027, \u0027VnfInstantiatedInfo\u0027),"},{"line_number":87,"context_line":"            \u0027vnfInstanceId\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d8a6b254","line":84,"range":{"start_line":84,"start_character":3,"end_line":84,"end_character":18},"in_reply_to":"9f560f44_32a0f991","updated":"2020-09-22 16:11:39.000000000","message":"No Action is Necessary in this patch. Need to check other patch 747420.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"325d58bfa481253bd77808b702cb632a313d0053","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                       default\u003d{})"},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    ALL_ATTRIBUTES \u003d {"},{"line_number":85,"context_line":"        \u0027instantiatedInfo\u0027: {"},{"line_number":86,"context_line":"            \u0027flavourId\u0027: (\u0027id\u0027, \u0027string\u0027, \u0027VnfInstantiatedInfo\u0027),"},{"line_number":87,"context_line":"            \u0027vnfInstanceId\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_32a0f991","line":84,"range":{"start_line":84,"start_character":3,"end_line":84,"end_character":18},"in_reply_to":"9f560f44_970577c4","updated":"2020-09-17 12:34:05.000000000","message":"I retracted my comment because he vnfcInfo will be handled in Patch 747420.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ee060b465d89f9e7bf14d06b55f61006f642a208","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                       default\u003d{})"},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    ALL_ATTRIBUTES \u003d {"},{"line_number":85,"context_line":"        \u0027instantiatedInfo\u0027: {"},{"line_number":86,"context_line":"            \u0027flavourId\u0027: (\u0027id\u0027, \u0027string\u0027, \u0027VnfInstantiatedInfo\u0027),"},{"line_number":87,"context_line":"            \u0027vnfInstanceId\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_11bc1c05","line":84,"range":{"start_line":84,"start_character":3,"end_line":84,"end_character":18},"in_reply_to":"9f560f44_dc2feba4","updated":"2020-09-14 12:00:13.000000000","message":"Added vnfcInfo in attribute list.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":27180,"name":"Keiko Kuriu","email":"kuriu.keiko@gmail.com","username":"keiko-k"},"change_message_id":"325d58bfa481253bd77808b702cb632a313d0053","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                \u0027additional_params\u0027, \u0027key_value_pair\u0027,"},{"line_number":117,"context_line":"                {\"key_column\": \"key\", \"value_column\": \"value\","},{"line_number":118,"context_line":"                \"model\": \"VnfInstantiatedInfo\"}),"},{"line_number":119,"context_line":"            \u0027vnfcInfo/*\u0027: ("},{"line_number":120,"context_line":"                \u0027vnfc_info\u0027, \u0027key_value_pair\u0027,"},{"line_number":121,"context_line":"                {\"key_column\": \"key\", \"value_column\": \"value\","},{"line_number":122,"context_line":"                \"model\": \"VnfInstantiatedInfo\"}),"},{"line_number":123,"context_line":"        }"},{"line_number":124,"context_line":"    }"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_52a5ad9e","line":122,"range":{"start_line":119,"start_character":12,"end_line":122,"end_character":49},"updated":"2020-09-17 12:34:05.000000000","message":"This part should be handled in patch 747420 because this part is not related to `attribute base filtering`patch.","commit_id":"e4ccbc11289461e4d00b68bd392baa95de5fb9df"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3ea07b8c70d679a46f844d6ff4b4d57be109649e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                \u0027additional_params\u0027, \u0027key_value_pair\u0027,"},{"line_number":117,"context_line":"                {\"key_column\": \"key\", \"value_column\": \"value\","},{"line_number":118,"context_line":"                \"model\": \"VnfInstantiatedInfo\"}),"},{"line_number":119,"context_line":"            \u0027vnfcInfo/*\u0027: ("},{"line_number":120,"context_line":"                \u0027vnfc_info\u0027, \u0027key_value_pair\u0027,"},{"line_number":121,"context_line":"                {\"key_column\": \"key\", \"value_column\": \"value\","},{"line_number":122,"context_line":"                \"model\": \"VnfInstantiatedInfo\"}),"},{"line_number":123,"context_line":"        }"},{"line_number":124,"context_line":"    }"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d031940c","line":122,"range":{"start_line":119,"start_character":12,"end_line":122,"end_character":49},"in_reply_to":"9f560f44_52a5ad9e","updated":"2020-09-19 12:34:42.000000000","message":"Removed from this patch.","commit_id":"e4ccbc11289461e4d00b68bd392baa95de5fb9df"}],"tacker/tests/unit/vnflcm/test_controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0e5153d1901c569cb6ae1738f6b85ffb95c8a991","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import ddt"},{"line_number":18,"context_line":"from oslo_serialization import jsonutils"},{"line_number":19,"context_line":"from six.moves import http_client"},{"line_number":20,"context_line":"from six.moves import urllib"},{"line_number":21,"context_line":"from webob import exc"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tacker.api.vnflcm.v1 import controller"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9cc8d374","line":20,"updated":"2020-09-04 09:39:25.000000000","message":"You don\u0027t need to use six because python2 support is not needed.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ee060b465d89f9e7bf14d06b55f61006f642a208","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import ddt"},{"line_number":18,"context_line":"from oslo_serialization import jsonutils"},{"line_number":19,"context_line":"from six.moves import http_client"},{"line_number":20,"context_line":"from six.moves import urllib"},{"line_number":21,"context_line":"from webob import exc"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tacker.api.vnflcm.v1 import controller"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f1dfe863","line":20,"in_reply_to":"9f560f44_9cc8d374","updated":"2020-09-14 12:00:13.000000000","message":"Used \"urllib\" instead of importing from \"six.moves\"","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0e5153d1901c569cb6ae1738f6b85ffb95c8a991","unresolved":false,"context_lines":[{"line_number":1147,"context_line":"            \u0027/vnflcm/v1/vnf_instances?\u0027 + query)"},{"line_number":1148,"context_line":"        req.headers[\u0027Version\u0027] \u003d api_version"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"        vnf_instance_1 \u003d fakes.return_vnf_instance()"},{"line_number":1151,"context_line":"        vnf_instance_2 \u003d fakes.return_vnf_instance("},{"line_number":1152,"context_line":"            fields.VnfInstanceState.INSTANTIATED)"},{"line_number":1153,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fc858f08","line":1150,"updated":"2020-09-04 09:39:25.000000000","message":"Do you need to have two vnf_instances to run this test?\nSame for others.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ee060b465d89f9e7bf14d06b55f61006f642a208","unresolved":false,"context_lines":[{"line_number":1147,"context_line":"            \u0027/vnflcm/v1/vnf_instances?\u0027 + query)"},{"line_number":1148,"context_line":"        req.headers[\u0027Version\u0027] \u003d api_version"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"        vnf_instance_1 \u003d fakes.return_vnf_instance()"},{"line_number":1151,"context_line":"        vnf_instance_2 \u003d fakes.return_vnf_instance("},{"line_number":1152,"context_line":"            fields.VnfInstanceState.INSTANTIATED)"},{"line_number":1153,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d1c10484","line":1150,"in_reply_to":"9f560f44_fc858f08","updated":"2020-09-14 12:00:13.000000000","message":"No, it is not necessary to have two vnf_instances for this test. This is only to show that the response may consist of many vnf_instances.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0e5153d1901c569cb6ae1738f6b85ffb95c8a991","unresolved":false,"context_lines":[{"line_number":1164,"context_line":"    @mock.patch.object(objects.VnfInstanceList, \"get_by_filters\")"},{"line_number":1165,"context_line":"    def test_index_filter_combination(self, mock_vnf_list):"},{"line_number":1166,"context_line":"        \"\"\"Test multiple filter parameters separated by semicolon.\"\"\""},{"line_number":1167,"context_line":"        params \u003d {"},{"line_number":1168,"context_line":"            \u0027filter\u0027: \"(eq,vnfInstanceName,\u0027dummy_name\u0027);\""},{"line_number":1169,"context_line":"                      \"(eq,vnfInstanceName,\u0027dummy_name\u0027)\"}"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        api_version \u003d \u00272.6.1\u0027"},{"line_number":1172,"context_line":"        query \u003d urllib.parse.urlencode(params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fce8efb3","line":1169,"range":{"start_line":1167,"start_character":0,"end_line":1169,"end_character":58},"updated":"2020-09-04 09:39:25.000000000","message":"You should change one of the conditions because they are the same combination of conditions.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ee060b465d89f9e7bf14d06b55f61006f642a208","unresolved":false,"context_lines":[{"line_number":1164,"context_line":"    @mock.patch.object(objects.VnfInstanceList, \"get_by_filters\")"},{"line_number":1165,"context_line":"    def test_index_filter_combination(self, mock_vnf_list):"},{"line_number":1166,"context_line":"        \"\"\"Test multiple filter parameters separated by semicolon.\"\"\""},{"line_number":1167,"context_line":"        params \u003d {"},{"line_number":1168,"context_line":"            \u0027filter\u0027: \"(eq,vnfInstanceName,\u0027dummy_name\u0027);\""},{"line_number":1169,"context_line":"                      \"(eq,vnfInstanceName,\u0027dummy_name\u0027)\"}"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        api_version \u003d \u00272.6.1\u0027"},{"line_number":1172,"context_line":"        query \u003d urllib.parse.urlencode(params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b1be10fe","line":1169,"range":{"start_line":1167,"start_character":0,"end_line":1169,"end_character":58},"in_reply_to":"9f560f44_fce8efb3","updated":"2020-09-14 12:00:13.000000000","message":"Replaced one of the conditions.","commit_id":"08b7f47b3cf588324c267b8a27199be163fa904c"}]}