)]}'
{"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":51,"context_line":"CONF \u003d tacker.conf.CONF"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def check_vnf_state(action, instantiation_state\u003dNone, task_state\u003d(None,)):"},{"line_number":57,"context_line":"    \"\"\"Decorator to check vnf states are valid for particular action."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0bc15fe5","line":54,"updated":"2020-09-01 09:48:02.000000000","message":"This duplicate description should be fixed in the 747511 patch.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"CONF \u003d tacker.conf.CONF"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def check_vnf_state(action, instantiation_state\u003dNone, task_state\u003d(None,)):"},{"line_number":57,"context_line":"    \"\"\"Decorator to check vnf states are valid for particular action."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7433c1c5","line":54,"in_reply_to":"9f560f44_0bc15fe5","updated":"2020-09-14 20:24:19.000000000","message":"Fixed in Scale patch.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":872,"context_line":"            vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc.get_by_id(context, id)"},{"line_number":873,"context_line":"            if vnf_lcm_op_occs.operation_state !\u003d \u0027FAILED_TEMP\u0027:"},{"line_number":874,"context_line":"                return self._make_problem_detail("},{"line_number":875,"context_line":"                    \u0027OperationState IS NOT FAILED_TEMP\u0027,"},{"line_number":876,"context_line":"                    409,"},{"line_number":877,"context_line":"                    title\u003d\u0027OperationState IS NOT FAILED_TEMP\u0027)"},{"line_number":878,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4b499789","line":875,"updated":"2020-09-01 09:48:02.000000000","message":"Since the same character string is described multiple times, it\u0027s better to define a variable.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":872,"context_line":"            vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc.get_by_id(context, id)"},{"line_number":873,"context_line":"            if vnf_lcm_op_occs.operation_state !\u003d \u0027FAILED_TEMP\u0027:"},{"line_number":874,"context_line":"                return self._make_problem_detail("},{"line_number":875,"context_line":"                    \u0027OperationState IS NOT FAILED_TEMP\u0027,"},{"line_number":876,"context_line":"                    409,"},{"line_number":877,"context_line":"                    title\u003d\u0027OperationState IS NOT FAILED_TEMP\u0027)"},{"line_number":878,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_144ec537","line":875,"in_reply_to":"9f560f44_4b499789","updated":"2020-09-14 20:24:19.000000000","message":"It is similar but it pertains to different string. I will leave it as is for now.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":887,"context_line":"                vnf_lcm_op_occs.operation_params)"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"            if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027 \\"},{"line_number":890,"context_line":"                    and operation_params[\u0027type\u0027] \u003d\u003d \u0027SCALE_IN\u0027:"},{"line_number":891,"context_line":"                return self._make_problem_detail("},{"line_number":892,"context_line":"                    \u0027SCALE_IN CAN NOT ROLLBACK\u0027, 409,"},{"line_number":893,"context_line":"                    title\u003d\u0027SCALE_IN CAN NOT ROLLBACK\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2efd5108","line":890,"updated":"2020-09-01 09:48:02.000000000","message":"The operation_params has a cardinality of 0...1, so I think it may be None.\nIs it right?","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":887,"context_line":"                vnf_lcm_op_occs.operation_params)"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"            if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027 \\"},{"line_number":890,"context_line":"                    and operation_params[\u0027type\u0027] \u003d\u003d \u0027SCALE_IN\u0027:"},{"line_number":891,"context_line":"                return self._make_problem_detail("},{"line_number":892,"context_line":"                    \u0027SCALE_IN CAN NOT ROLLBACK\u0027, 409,"},{"line_number":893,"context_line":"                    title\u003d\u0027SCALE_IN CAN NOT ROLLBACK\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_54615da8","line":890,"in_reply_to":"9f560f44_2efd5108","updated":"2020-09-14 20:24:19.000000000","message":"It is required for Scale.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f785a0cdfb6e5e63fb155c55b37c6068df0815bc","unresolved":false,"context_lines":[{"line_number":887,"context_line":"                vnf_lcm_op_occs.operation_params)"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"            if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027 \\"},{"line_number":890,"context_line":"                    and operation_params[\u0027type\u0027] \u003d\u003d \u0027SCALE_IN\u0027:"},{"line_number":891,"context_line":"                return self._make_problem_detail("},{"line_number":892,"context_line":"                    \u0027SCALE_IN CAN NOT ROLLBACK\u0027, 409,"},{"line_number":893,"context_line":"                    title\u003d\u0027SCALE_IN CAN NOT ROLLBACK\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4fcbeca2","line":890,"in_reply_to":"9f560f44_38836ecd","updated":"2020-09-23 10:20:23.000000000","message":"I\u0027m not arguing if it\u0027s needed for processing.\nWhat I want to say is that the SOL definition allows operation_params to be omitted and should be considered.\nIf processing cannot be continued when omitted, I think that error processing should be performed appropriately.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"94663f4a37b1ca655bdc4b60d3be6e2d8577693e","unresolved":false,"context_lines":[{"line_number":887,"context_line":"                vnf_lcm_op_occs.operation_params)"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"            if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027 \\"},{"line_number":890,"context_line":"                    and operation_params[\u0027type\u0027] \u003d\u003d \u0027SCALE_IN\u0027:"},{"line_number":891,"context_line":"                return self._make_problem_detail("},{"line_number":892,"context_line":"                    \u0027SCALE_IN CAN NOT ROLLBACK\u0027, 409,"},{"line_number":893,"context_line":"                    title\u003d\u0027SCALE_IN CAN NOT ROLLBACK\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_abb6c587","line":890,"in_reply_to":"9f560f44_4fcbeca2","updated":"2020-09-25 11:23:06.000000000","message":"Indeed the cardinality is defined as \"0...1\" in SOL-Attribute, but as for instantiation and scale, which are the target of the rollback, it is guaranteed that each one is set to operationParams.\nBecause of this reason, it is no need to consider omitted case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"14861dcbfe92d41582e90fc1224e894ef8b7d8df","unresolved":false,"context_lines":[{"line_number":887,"context_line":"                vnf_lcm_op_occs.operation_params)"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"            if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027 \\"},{"line_number":890,"context_line":"                    and operation_params[\u0027type\u0027] \u003d\u003d \u0027SCALE_IN\u0027:"},{"line_number":891,"context_line":"                return self._make_problem_detail("},{"line_number":892,"context_line":"                    \u0027SCALE_IN CAN NOT ROLLBACK\u0027, 409,"},{"line_number":893,"context_line":"                    title\u003d\u0027SCALE_IN CAN NOT ROLLBACK\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8b19f47b","line":890,"in_reply_to":"9f560f44_54615da8","updated":"2020-09-16 05:49:23.000000000","message":"I couldn\u0027t convey the intention of the comment correctly, so I will comment again.\nAccording to the following SOL specifications, the Cardinality of operationParams is 0 ... 1, so is there a problem with the access  of \"operation_params [\u0027type\u0027]\"?\nIsn\u0027t it better to use \"operation_params.get (\u0027type\u0027)\"?\n  SOL003 5.5.2.13 VnfLcmOpOcc","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5932c14770e9e9087ffd36874bc9c33a2d4f61c2","unresolved":false,"context_lines":[{"line_number":887,"context_line":"                vnf_lcm_op_occs.operation_params)"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"            if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027 \\"},{"line_number":890,"context_line":"                    and operation_params[\u0027type\u0027] \u003d\u003d \u0027SCALE_IN\u0027:"},{"line_number":891,"context_line":"                return self._make_problem_detail("},{"line_number":892,"context_line":"                    \u0027SCALE_IN CAN NOT ROLLBACK\u0027, 409,"},{"line_number":893,"context_line":"                    title\u003d\u0027SCALE_IN CAN NOT ROLLBACK\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_38836ecd","line":890,"in_reply_to":"9f560f44_8b19f47b","updated":"2020-09-22 16:03:45.000000000","message":"operation_params is required in the process.\nIf this parameter cannot be used, rollback itself cannot be done in the first place. Since it is taken as json just before, I think that the process of reading with a dictionary (current process) is sufficient.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"}],"tacker/common/exceptions.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"db142230bfc751ddb2b9ee14a391677983c55c55","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    code \u003d 303"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"class DBAccessError(TackerException):"},{"line_number":368,"context_line":"    message \u003d _(\"DB Access Error\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_96a80679","line":367,"updated":"2020-09-30 07:35:33.000000000","message":"pep8: F811 redefinition of unused \u0027DBAccessError\u0027 from line 359","commit_id":"2877b6c57fc28c499daaeac7a72927531c243e7b"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c19d96ff65c1e2fed3c770085aa4fdb93a801c53","unresolved":false,"context_lines":[{"line_number":1212,"context_line":"        is_automatic_invocation \u003d \\"},{"line_number":1213,"context_line":"            kwargs.get(\u0027is_automatic_invocation\u0027, False)"},{"line_number":1214,"context_line":"        error \u003d kwargs.get(\u0027error\u0027, None)"},{"line_number":1215,"context_line":"        error_point \u003d kwargs.get(\u0027error_point\u0027, 0)"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        if old_vnf_instance:"},{"line_number":1218,"context_line":"            vnf_instance_id \u003d old_vnf_instance.id"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_0bd308d5","line":1215,"range":{"start_line":1215,"start_character":8,"end_line":1215,"end_character":19},"updated":"2020-09-17 09:59:43.000000000","message":"I think you need an explanation for this variable.\nOtherwise, reviewers will find it difficult to understand what this variable is used for.","commit_id":"b2b1df456b03a1ad20c581daff66373955b3e5bc"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"cf8ac3659f5969065ad7225537ecd924d047ad71","unresolved":false,"context_lines":[{"line_number":1212,"context_line":"        is_automatic_invocation \u003d \\"},{"line_number":1213,"context_line":"            kwargs.get(\u0027is_automatic_invocation\u0027, False)"},{"line_number":1214,"context_line":"        error \u003d kwargs.get(\u0027error\u0027, None)"},{"line_number":1215,"context_line":"        error_point \u003d kwargs.get(\u0027error_point\u0027, 0)"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        if old_vnf_instance:"},{"line_number":1218,"context_line":"            vnf_instance_id \u003d old_vnf_instance.id"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_93b0a242","line":1215,"range":{"start_line":1215,"start_character":8,"end_line":1215,"end_character":19},"in_reply_to":"9f560f44_0bd308d5","updated":"2020-09-22 13:01:36.000000000","message":"Added a comment.","commit_id":"b2b1df456b03a1ad20c581daff66373955b3e5bc"}],"tacker/db/vnfm/vnfm_db.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                \u0027resource\u0027: placement_obj.resource,"},{"line_number":898,"context_line":"                \u0027updated_at\u0027: timeutils.utcnow()}))"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"    def _update_vnf_rollback_status_err(self,"},{"line_number":901,"context_line":"                                       context,"},{"line_number":902,"context_line":"                                       vnf_info):"},{"line_number":903,"context_line":"        vnf_lcm_op_occs \u003d vnf_info[\u0027vnf_lcm_op_occ\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b94a49a9","line":900,"updated":"2020-09-01 09:48:02.000000000","message":"Since it is not an inner function, the leading\u0027_\u0027 should be removed.\nSame for other functions.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"14861dcbfe92d41582e90fc1224e894ef8b7d8df","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                \u0027resource\u0027: placement_obj.resource,"},{"line_number":898,"context_line":"                \u0027updated_at\u0027: timeutils.utcnow()}))"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"    def _update_vnf_rollback_status_err(self,"},{"line_number":901,"context_line":"                                       context,"},{"line_number":902,"context_line":"                                       vnf_info):"},{"line_number":903,"context_line":"        vnf_lcm_op_occs \u003d vnf_info[\u0027vnf_lcm_op_occ\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2b3548dc","line":900,"in_reply_to":"9f560f44_1467e5b9","updated":"2020-09-16 05:49:23.000000000","message":"Thank you for the fix.\nI think you need not to follow the wrong part of the existing code.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"399a7b5e978d1af2967c199de8b6f0280d87007b","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                \u0027resource\u0027: placement_obj.resource,"},{"line_number":898,"context_line":"                \u0027updated_at\u0027: timeutils.utcnow()}))"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"    def _update_vnf_rollback_status_err(self,"},{"line_number":901,"context_line":"                                       context,"},{"line_number":902,"context_line":"                                       vnf_info):"},{"line_number":903,"context_line":"        vnf_lcm_op_occs \u003d vnf_info[\u0027vnf_lcm_op_occ\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e77c8072","line":900,"in_reply_to":"9f560f44_2b3548dc","updated":"2020-09-24 18:53:36.000000000","message":"OK","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                \u0027resource\u0027: placement_obj.resource,"},{"line_number":898,"context_line":"                \u0027updated_at\u0027: timeutils.utcnow()}))"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"    def _update_vnf_rollback_status_err(self,"},{"line_number":901,"context_line":"                                       context,"},{"line_number":902,"context_line":"                                       vnf_info):"},{"line_number":903,"context_line":"        vnf_lcm_op_occs \u003d vnf_info[\u0027vnf_lcm_op_occ\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1467e5b9","line":900,"in_reply_to":"9f560f44_b94a49a9","updated":"2020-09-14 20:24:19.000000000","message":"There is a similar one from the beginning ... (In addition to the part created by NS Lab ...)\nIt can be modified, so I will modify it this time.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"}],"tacker/tests/unit/vnflcm/test_vnflcm_driver.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":800,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":801,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":802,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":803,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":804,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":805,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":806,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c8a172f9","line":803,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":800,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":801,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":802,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":803,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":804,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":805,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":806,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_74758100","line":803,"in_reply_to":"9f560f44_c8a172f9","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":834,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":835,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":836,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":837,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":838,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":839,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":840,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e8a9d6dc","line":837,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":834,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":835,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":836,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":837,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":838,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":839,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":840,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_547afdef","line":837,"in_reply_to":"9f560f44_e8a9d6dc","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":868,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":869,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":870,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":871,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":872,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":873,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":874,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_28b0ee3f","line":871,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":868,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":869,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":870,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":871,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":872,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":873,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":874,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b47f19de","line":871,"in_reply_to":"9f560f44_28b0ee3f","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":902,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":903,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":904,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":905,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":906,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":907,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":908,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a87d1e6e","line":905,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":902,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":903,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":904,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":905,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":906,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":907,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":908,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_948495d5","line":905,"in_reply_to":"9f560f44_a87d1e6e","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":936,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":937,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":938,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":939,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":940,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":941,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":942,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_08988abd","line":939,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":936,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":937,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":938,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":939,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":940,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":941,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":942,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d4656d4b","line":939,"in_reply_to":"9f560f44_08988abd","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":970,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":971,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":972,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":973,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":974,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":975,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":976,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e892769e","line":973,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":970,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":971,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":972,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":973,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":974,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":975,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":976,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_34730919","line":973,"in_reply_to":"9f560f44_e892769e","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":1009,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":1010,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":1011,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":1012,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":1013,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":1014,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_68eca628","line":1011,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":1009,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":1010,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":1011,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":1012,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":1013,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":1014,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_745e217a","line":1011,"in_reply_to":"9f560f44_68eca628","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":1046,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":1047,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":1048,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":1049,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":1050,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":1051,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":1052,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c8efb21a","line":1049,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1046,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":1047,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":1048,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":1049,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":1050,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":1051,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":1052,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_54631d42","line":1049,"in_reply_to":"9f560f44_c8efb21a","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":1085,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":1086,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":1087,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":1088,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":1089,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":1090,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a8f23e03","line":1087,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":1085,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":1086,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":1087,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":1088,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":1089,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":1090,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f4519165","line":1087,"in_reply_to":"9f560f44_a8f23e03","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":1123,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":1124,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":1125,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":1126,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":1127,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":1128,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e8d7164e","line":1125,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"    @mock.patch.object(TackerManager, \u0027get_service_plugins\u0027,"},{"line_number":1123,"context_line":"        return_value\u003d{\u0027VNFM\u0027: FakeVNFMPlugin()})"},{"line_number":1124,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"save\")"},{"line_number":1125,"context_line":"    @mock.patch.object(VNFLcmRPCAPI, \"sendNotification\")"},{"line_number":1126,"context_line":"    @mock.patch.object(objects.VnfInstance, \"save\")"},{"line_number":1127,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback_pre\")"},{"line_number":1128,"context_line":"    @mock.patch.object(vnflcm_driver.VnfLcmDriver, \"_update_vnf_rollback\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d44e0dc1","line":1125,"in_reply_to":"9f560f44_e8d7164e","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                            scale_vnf_request \u003d\\"},{"line_number":181,"context_line":"                                objects.ScaleVnfRequest.obj_from_primitive("},{"line_number":182,"context_line":"                                    operation_params, context\u003dcontext)"},{"line_number":183,"context_line":"                            scale_vnf_request2 \u003d \\"},{"line_number":184,"context_line":"                                copy.deepcopy(scale_vnf_request)"},{"line_number":185,"context_line":"                            scale_vnf_request2.type \u003d \u0027SCALE_IN\u0027"},{"line_number":186,"context_line":"                            resource_changes \u003d self._scale_resource_update("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1977f50a","line":183,"updated":"2020-09-01 09:48:02.000000000","message":"Why are you using deepcopy to create new objects?","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f785a0cdfb6e5e63fb155c55b37c6068df0815bc","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                            scale_vnf_request \u003d\\"},{"line_number":181,"context_line":"                                objects.ScaleVnfRequest.obj_from_primitive("},{"line_number":182,"context_line":"                                    operation_params, context\u003dcontext)"},{"line_number":183,"context_line":"                            scale_vnf_request2 \u003d \\"},{"line_number":184,"context_line":"                                copy.deepcopy(scale_vnf_request)"},{"line_number":185,"context_line":"                            scale_vnf_request2.type \u003d \u0027SCALE_IN\u0027"},{"line_number":186,"context_line":"                            resource_changes \u003d self._scale_resource_update("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_cc254ac1","line":183,"in_reply_to":"9f560f44_0b54c4fd","updated":"2020-09-23 10:20:23.000000000","message":"Please check this comment again.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                            scale_vnf_request \u003d\\"},{"line_number":181,"context_line":"                                objects.ScaleVnfRequest.obj_from_primitive("},{"line_number":182,"context_line":"                                    operation_params, context\u003dcontext)"},{"line_number":183,"context_line":"                            scale_vnf_request2 \u003d \\"},{"line_number":184,"context_line":"                                copy.deepcopy(scale_vnf_request)"},{"line_number":185,"context_line":"                            scale_vnf_request2.type \u003d \u0027SCALE_IN\u0027"},{"line_number":186,"context_line":"                            resource_changes \u003d self._scale_resource_update("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d41a8d16","line":183,"in_reply_to":"9f560f44_1977f50a","updated":"2020-09-14 20:24:19.000000000","message":"Deleted because it seems unnecessary","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"399a7b5e978d1af2967c199de8b6f0280d87007b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                            scale_vnf_request \u003d\\"},{"line_number":181,"context_line":"                                objects.ScaleVnfRequest.obj_from_primitive("},{"line_number":182,"context_line":"                                    operation_params, context\u003dcontext)"},{"line_number":183,"context_line":"                            scale_vnf_request2 \u003d \\"},{"line_number":184,"context_line":"                                copy.deepcopy(scale_vnf_request)"},{"line_number":185,"context_line":"                            scale_vnf_request2.type \u003d \u0027SCALE_IN\u0027"},{"line_number":186,"context_line":"                            resource_changes \u003d self._scale_resource_update("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_47972c91","line":183,"in_reply_to":"9f560f44_cc254ac1","updated":"2020-09-24 18:53:36.000000000","message":"Reflected in the rebasing","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"14861dcbfe92d41582e90fc1224e894ef8b7d8df","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                            scale_vnf_request \u003d\\"},{"line_number":181,"context_line":"                                objects.ScaleVnfRequest.obj_from_primitive("},{"line_number":182,"context_line":"                                    operation_params, context\u003dcontext)"},{"line_number":183,"context_line":"                            scale_vnf_request2 \u003d \\"},{"line_number":184,"context_line":"                                copy.deepcopy(scale_vnf_request)"},{"line_number":185,"context_line":"                            scale_vnf_request2.type \u003d \u0027SCALE_IN\u0027"},{"line_number":186,"context_line":"                            resource_changes \u003d self._scale_resource_update("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0b54c4fd","line":183,"in_reply_to":"9f560f44_d41a8d16","updated":"2020-09-16 05:49:23.000000000","message":"It doesn\u0027t seem to have been deleted.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                vnf_instance)"},{"line_number":198,"context_line":"                except Exception as e:"},{"line_number":199,"context_line":"                    LOG.warning(traceback.format_exc())"},{"line_number":200,"context_line":"                    LOG.warning(\"Failed to scale resource update \""},{"line_number":201,"context_line":"                                \"instance %(id)s. Error: %(error)s\","},{"line_number":202,"context_line":"                                {\"id\": vnf_instance.id, \"error\": e})"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_595a0d83","line":200,"updated":"2020-09-01 09:48:02.000000000","message":"Is it possible that this exception occurs other than Scale operation?","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                vnf_instance)"},{"line_number":198,"context_line":"                except Exception as e:"},{"line_number":199,"context_line":"                    LOG.warning(traceback.format_exc())"},{"line_number":200,"context_line":"                    LOG.warning(\"Failed to scale resource update \""},{"line_number":201,"context_line":"                                \"instance %(id)s. Error: %(error)s\","},{"line_number":202,"context_line":"                                {\"id\": vnf_instance.id, \"error\": e})"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_14988573","line":200,"in_reply_to":"9f560f44_595a0d83","updated":"2020-09-14 20:24:19.000000000","message":"Message is corrected since it can occur on operations other than Scale.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                                jsonutils.dump_as_bytes("},{"line_number":252,"context_line":"                                    resource_dict.get("},{"line_number":253,"context_line":"                                        \u0027affected_virtual_storages\u0027))"},{"line_number":254,"context_line":"                    self.rpc_api.sendNotification(context, notification)"},{"line_number":255,"context_line":"                except Exception as e:"},{"line_number":256,"context_line":"                    LOG.warning(\"Failed to revert scale info for vnf \""},{"line_number":257,"context_line":"                                \"instance %(id)s. Error: %(error)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_483282f3","line":254,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                                jsonutils.dump_as_bytes("},{"line_number":252,"context_line":"                                    resource_dict.get("},{"line_number":253,"context_line":"                                        \u0027affected_virtual_storages\u0027))"},{"line_number":254,"context_line":"                    self.rpc_api.sendNotification(context, notification)"},{"line_number":255,"context_line":"                except Exception as e:"},{"line_number":256,"context_line":"                    LOG.warning(\"Failed to revert scale info for vnf \""},{"line_number":257,"context_line":"                                \"instance %(id)s. Error: %(error)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b480b9f9","line":254,"in_reply_to":"9f560f44_483282f3","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        resource_changes.affected_virtual_storages \u003d []"},{"line_number":831,"context_line":"        if \u0027resource_changes\u0027 in \\"},{"line_number":832,"context_line":"                vnf_lcm_op_occs and vnf_lcm_op_occs.resource_changes:"},{"line_number":833,"context_line":"            res_chg \u003d vnf_lcm_op_occs.resource_changes"},{"line_number":834,"context_line":"            if \u0027affected_vnfcs\u0027 in res_chg:"},{"line_number":835,"context_line":"                if res_chg.affected_vnfcs and \\"},{"line_number":836,"context_line":"                   len(res_chg.affected_vnfcs) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9922e5b9","line":833,"updated":"2020-09-01 09:48:02.000000000","message":"I think these fix should be fixed in the parent patch.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"cf8ac3659f5969065ad7225537ecd924d047ad71","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        resource_changes.affected_virtual_storages \u003d []"},{"line_number":831,"context_line":"        if \u0027resource_changes\u0027 in \\"},{"line_number":832,"context_line":"                vnf_lcm_op_occs and vnf_lcm_op_occs.resource_changes:"},{"line_number":833,"context_line":"            res_chg \u003d vnf_lcm_op_occs.resource_changes"},{"line_number":834,"context_line":"            if \u0027affected_vnfcs\u0027 in res_chg:"},{"line_number":835,"context_line":"                if res_chg.affected_vnfcs and \\"},{"line_number":836,"context_line":"                   len(res_chg.affected_vnfcs) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_73206e4a","line":833,"in_reply_to":"9f560f44_6b446048","updated":"2020-09-22 13:01:36.000000000","message":"The fix is supposed to be in the parent patch (Scale). Rebase will remove this.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f785a0cdfb6e5e63fb155c55b37c6068df0815bc","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        resource_changes.affected_virtual_storages \u003d []"},{"line_number":831,"context_line":"        if \u0027resource_changes\u0027 in \\"},{"line_number":832,"context_line":"                vnf_lcm_op_occs and vnf_lcm_op_occs.resource_changes:"},{"line_number":833,"context_line":"            res_chg \u003d vnf_lcm_op_occs.resource_changes"},{"line_number":834,"context_line":"            if \u0027affected_vnfcs\u0027 in res_chg:"},{"line_number":835,"context_line":"                if res_chg.affected_vnfcs and \\"},{"line_number":836,"context_line":"                   len(res_chg.affected_vnfcs) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6f51900d","line":833,"in_reply_to":"9f560f44_73206e4a","updated":"2020-09-23 10:20:23.000000000","message":"It looks like it\u0027s still fixed in this patch, not the parent. Please check this comment again.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        resource_changes.affected_virtual_storages \u003d []"},{"line_number":831,"context_line":"        if \u0027resource_changes\u0027 in \\"},{"line_number":832,"context_line":"                vnf_lcm_op_occs and vnf_lcm_op_occs.resource_changes:"},{"line_number":833,"context_line":"            res_chg \u003d vnf_lcm_op_occs.resource_changes"},{"line_number":834,"context_line":"            if \u0027affected_vnfcs\u0027 in res_chg:"},{"line_number":835,"context_line":"                if res_chg.affected_vnfcs and \\"},{"line_number":836,"context_line":"                   len(res_chg.affected_vnfcs) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d4760d40","line":833,"in_reply_to":"9f560f44_9922e5b9","updated":"2020-09-14 20:24:19.000000000","message":"It is fixed in scale.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"14861dcbfe92d41582e90fc1224e894ef8b7d8df","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        resource_changes.affected_virtual_storages \u003d []"},{"line_number":831,"context_line":"        if \u0027resource_changes\u0027 in \\"},{"line_number":832,"context_line":"                vnf_lcm_op_occs and vnf_lcm_op_occs.resource_changes:"},{"line_number":833,"context_line":"            res_chg \u003d vnf_lcm_op_occs.resource_changes"},{"line_number":834,"context_line":"            if \u0027affected_vnfcs\u0027 in res_chg:"},{"line_number":835,"context_line":"                if res_chg.affected_vnfcs and \\"},{"line_number":836,"context_line":"                   len(res_chg.affected_vnfcs) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6b446048","line":833,"in_reply_to":"9f560f44_d4760d40","updated":"2020-09-16 05:49:23.000000000","message":"It looks like it\u0027s still fixed in this patch, not the parent.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"        scale_name_list \u003d []"},{"line_number":1157,"context_line":"        grp_id \u003d None"},{"line_number":1158,"context_line":"        self._update_vnf_rollback_pre(context, vnf_info)"},{"line_number":1159,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027:"},{"line_number":1160,"context_line":"            scaleGroupDict \u003d jsonutils.loads("},{"line_number":1161,"context_line":"                vnf_info[\u0027attributes\u0027][\u0027scale_group\u0027])"},{"line_number":1162,"context_line":"            cap_size \u003d scaleGroupDict[\u0027scaleGroupDict\u0027][operation_params"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_54b494f2","line":1159,"updated":"2020-09-01 09:48:02.000000000","message":"If branches related to vnf_lcm_op_occs.operation and vnf_lcm_op_occs.error_point are scattered, and it is very difficult to grasp the whole picture of processing.\nCan you fix the if branch structure?","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5932c14770e9e9087ffd36874bc9c33a2d4f61c2","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"        scale_name_list \u003d []"},{"line_number":1157,"context_line":"        grp_id \u003d None"},{"line_number":1158,"context_line":"        self._update_vnf_rollback_pre(context, vnf_info)"},{"line_number":1159,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027:"},{"line_number":1160,"context_line":"            scaleGroupDict \u003d jsonutils.loads("},{"line_number":1161,"context_line":"                vnf_info[\u0027attributes\u0027][\u0027scale_group\u0027])"},{"line_number":1162,"context_line":"            cap_size \u003d scaleGroupDict[\u0027scaleGroupDict\u0027][operation_params"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_385c0e7c","line":1159,"in_reply_to":"9f560f44_0ecddb85","updated":"2020-09-22 16:03:45.000000000","message":"Conditionally, it is executed in order, so it is described now.\nConsidering the clarification of the conditions, I think that the simplest conditions are the most appropriate, including maintainability.\n\nWhen dealing with multiple operations in the future, I think that the current description is more extensible, so I would like to apply this process.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4b2e159fcf6235a6700965850a88ff3d75fbcc41","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"        scale_name_list \u003d []"},{"line_number":1157,"context_line":"        grp_id \u003d None"},{"line_number":1158,"context_line":"        self._update_vnf_rollback_pre(context, vnf_info)"},{"line_number":1159,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027:"},{"line_number":1160,"context_line":"            scaleGroupDict \u003d jsonutils.loads("},{"line_number":1161,"context_line":"                vnf_info[\u0027attributes\u0027][\u0027scale_group\u0027])"},{"line_number":1162,"context_line":"            cap_size \u003d scaleGroupDict[\u0027scaleGroupDict\u0027][operation_params"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0ecddb85","line":1159,"in_reply_to":"9f560f44_54903d43","updated":"2020-09-17 07:31:52.000000000","message":"\u003e the current branch structure is the simplest, \n\nI disagree with your answer.\nI think this branch structure is very difficult to review for including reviewers other than me.\nFor example, is it possible to modify the structure as shown below?\n   if vnf_lcm_op_occs.operation \u003d\u003d\u0027SCALE\u0027:\n     if vnf_lcm_op_occs.error_point\u003e \u003d 4:\n     elif vnf_lcm_op_occs.error_point \u003d\u003d 7:\n     else:","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"        scale_name_list \u003d []"},{"line_number":1157,"context_line":"        grp_id \u003d None"},{"line_number":1158,"context_line":"        self._update_vnf_rollback_pre(context, vnf_info)"},{"line_number":1159,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027:"},{"line_number":1160,"context_line":"            scaleGroupDict \u003d jsonutils.loads("},{"line_number":1161,"context_line":"                vnf_info[\u0027attributes\u0027][\u0027scale_group\u0027])"},{"line_number":1162,"context_line":"            cap_size \u003d scaleGroupDict[\u0027scaleGroupDict\u0027][operation_params"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_54903d43","line":1159,"in_reply_to":"9f560f44_54b494f2","updated":"2020-09-14 20:24:19.000000000","message":"Judgment of error_point and operation is the situation where the current branch structure is the simplest, and when recreating the branch structure, the processing itself is almost recreated, so it is difficult at a level close to impossible, so I leave it as it is.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"                    vnf_info[\u0027after_scale_level\u0027] \u003d scale.scale_level"},{"line_number":1170,"context_line":"                    break"},{"line_number":1171,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027 \\"},{"line_number":1172,"context_line":"                and vnf_lcm_op_occs.error_point \u003e\u003d 4:"},{"line_number":1173,"context_line":"            scale_id_list, scale_name_list, grp_id \u003d self._vnf_manager.invoke("},{"line_number":1174,"context_line":"                vim_connection_info.vim_type,"},{"line_number":1175,"context_line":"                \u0027get_rollback_ids\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_34eac0ab","line":1172,"updated":"2020-09-01 09:48:02.000000000","message":"It seems that there is no logics when vnf_lcm_op_occs.error_point \u003e\u003d 4 and vnf_lcm_op_occs.operation \u003d\u003d\u0027INSTANTIATION\u0027.\nIs it right?","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5932c14770e9e9087ffd36874bc9c33a2d4f61c2","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"                    vnf_info[\u0027after_scale_level\u0027] \u003d scale.scale_level"},{"line_number":1170,"context_line":"                    break"},{"line_number":1171,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027 \\"},{"line_number":1172,"context_line":"                and vnf_lcm_op_occs.error_point \u003e\u003d 4:"},{"line_number":1173,"context_line":"            scale_id_list, scale_name_list, grp_id \u003d self._vnf_manager.invoke("},{"line_number":1174,"context_line":"                vim_connection_info.vim_type,"},{"line_number":1175,"context_line":"                \u0027get_rollback_ids\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_78516662","line":1172,"in_reply_to":"9f560f44_2e709f40","updated":"2020-09-22 16:03:45.000000000","message":"Instantiation doesn\u0027t need to get that ID, so it doesn\u0027t need to be executed at this error point.\nIn Instantiation, rollback is only stack delete execution of heat, and rollback of scale is stack update, so there is no processing at this timing due to the difference in processing.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"                    vnf_info[\u0027after_scale_level\u0027] \u003d scale.scale_level"},{"line_number":1170,"context_line":"                    break"},{"line_number":1171,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027 \\"},{"line_number":1172,"context_line":"                and vnf_lcm_op_occs.error_point \u003e\u003d 4:"},{"line_number":1173,"context_line":"            scale_id_list, scale_name_list, grp_id \u003d self._vnf_manager.invoke("},{"line_number":1174,"context_line":"                vim_connection_info.vim_type,"},{"line_number":1175,"context_line":"                \u0027get_rollback_ids\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_54de7d10","line":1172,"in_reply_to":"9f560f44_34eac0ab","updated":"2020-09-14 20:24:19.000000000","message":"Instantiation is a process that does not need to be executed.\nSo no modification is required.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4b2e159fcf6235a6700965850a88ff3d75fbcc41","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"                    vnf_info[\u0027after_scale_level\u0027] \u003d scale.scale_level"},{"line_number":1170,"context_line":"                    break"},{"line_number":1171,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027 \\"},{"line_number":1172,"context_line":"                and vnf_lcm_op_occs.error_point \u003e\u003d 4:"},{"line_number":1173,"context_line":"            scale_id_list, scale_name_list, grp_id \u003d self._vnf_manager.invoke("},{"line_number":1174,"context_line":"                vim_connection_info.vim_type,"},{"line_number":1175,"context_line":"                \u0027get_rollback_ids\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2e709f40","line":1172,"in_reply_to":"9f560f44_54de7d10","updated":"2020-09-17 07:31:52.000000000","message":"Does your answer mean that instantiate never rollback?\nIs it right?","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":1314,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027:"},{"line_number":1315,"context_line":"            scale_vnf_request \u003d objects.ScaleVnfRequest.obj_from_primitive("},{"line_number":1316,"context_line":"                operation_params, context\u003dcontext)"},{"line_number":1317,"context_line":"            scale_vnf_request2 \u003d copy.deepcopy(scale_vnf_request)"},{"line_number":1318,"context_line":"            scale_vnf_request2.type \u003d \u0027SCALE_IN\u0027"},{"line_number":1319,"context_line":"            resource_changes \u003d self._scale_resource_update(context, vnf_info,"},{"line_number":1320,"context_line":"                                    vnf_instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_996ae518","line":1317,"updated":"2020-09-01 09:48:02.000000000","message":"Why are you using deepcopy to create new objects?","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1314,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027:"},{"line_number":1315,"context_line":"            scale_vnf_request \u003d objects.ScaleVnfRequest.obj_from_primitive("},{"line_number":1316,"context_line":"                operation_params, context\u003dcontext)"},{"line_number":1317,"context_line":"            scale_vnf_request2 \u003d copy.deepcopy(scale_vnf_request)"},{"line_number":1318,"context_line":"            scale_vnf_request2.type \u003d \u0027SCALE_IN\u0027"},{"line_number":1319,"context_line":"            resource_changes \u003d self._scale_resource_update(context, vnf_info,"},{"line_number":1320,"context_line":"                                    vnf_instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b4e399d8","line":1317,"in_reply_to":"9f560f44_996ae518","updated":"2020-09-14 20:24:19.000000000","message":"This is because the next line partially rewrites the request content (used only in this logic).","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":1346,"context_line":"        if resource_dict.get(\u0027affected_virtual_storages\u0027):"},{"line_number":1347,"context_line":"            notification[\u0027affectedVirtualStorages\u0027] \u003d \\"},{"line_number":1348,"context_line":"                resource_dict.get(\u0027affected_virtual_storages\u0027)"},{"line_number":1349,"context_line":"        self.rpc_api.sendNotification(context, notification)"},{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"    @log.log"},{"line_number":1352,"context_line":"    @revert_to_error_rollback"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6850260b","line":1349,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1346,"context_line":"        if resource_dict.get(\u0027affected_virtual_storages\u0027):"},{"line_number":1347,"context_line":"            notification[\u0027affectedVirtualStorages\u0027] \u003d \\"},{"line_number":1348,"context_line":"                resource_dict.get(\u0027affected_virtual_storages\u0027)"},{"line_number":1349,"context_line":"        self.rpc_api.sendNotification(context, notification)"},{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"    @log.log"},{"line_number":1352,"context_line":"    @revert_to_error_rollback"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d4c9ed51","line":1349,"in_reply_to":"9f560f44_6850260b","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake case","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":1351,"context_line":"    @log.log"},{"line_number":1352,"context_line":"    @revert_to_error_rollback"},{"line_number":1353,"context_line":"    def rollback_vnf(self, context, vnf_info, vnf_instance, operation_params):"},{"line_number":1354,"context_line":"        LOG.info(\"Request received for scale vnf \u0027%s\u0027\", vnf_instance.id)"},{"line_number":1355,"context_line":"        vnf_lcm_op_occs \u003d vnf_info[\u0027vnf_lcm_op_occ\u0027]"},{"line_number":1356,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027:"},{"line_number":1357,"context_line":"            scale_vnf_request \u003d objects.ScaleVnfRequest.obj_from_primitive("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b417f045","line":1354,"updated":"2020-09-01 09:48:02.000000000","message":"I think the contents of the log are incorrect.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1351,"context_line":"    @log.log"},{"line_number":1352,"context_line":"    @revert_to_error_rollback"},{"line_number":1353,"context_line":"    def rollback_vnf(self, context, vnf_info, vnf_instance, operation_params):"},{"line_number":1354,"context_line":"        LOG.info(\"Request received for scale vnf \u0027%s\u0027\", vnf_instance.id)"},{"line_number":1355,"context_line":"        vnf_lcm_op_occs \u003d vnf_info[\u0027vnf_lcm_op_occ\u0027]"},{"line_number":1356,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027:"},{"line_number":1357,"context_line":"            scale_vnf_request \u003d objects.ScaleVnfRequest.obj_from_primitive("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_54079d82","line":1354,"in_reply_to":"9f560f44_b417f045","updated":"2020-09-14 20:24:19.000000000","message":"Since it is scale, log message is corrected.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"        timestamp \u003d datetime.datetime.utcnow()"},{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"        vnf_lcm_op_occs.operation_state \u003d \u0027PROCESSING\u0027"},{"line_number":1367,"context_line":"        vnf_lcm_op_occs.state_entered_time \u003d timestamp"},{"line_number":1368,"context_line":"        LOG.debug(\"vnf_lcm_op_occs %s\", vnf_lcm_op_occs)"},{"line_number":1369,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_546e54c9","line":1366,"updated":"2020-09-01 09:48:02.000000000","message":"I think you should set \u0027ROLLING_BACK\u0027.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"        timestamp \u003d datetime.datetime.utcnow()"},{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"        vnf_lcm_op_occs.operation_state \u003d \u0027PROCESSING\u0027"},{"line_number":1367,"context_line":"        vnf_lcm_op_occs.state_entered_time \u003d timestamp"},{"line_number":1368,"context_line":"        LOG.debug(\"vnf_lcm_op_occs %s\", vnf_lcm_op_occs)"},{"line_number":1369,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_34f02992","line":1366,"in_reply_to":"9f560f44_546e54c9","updated":"2020-09-14 20:24:19.000000000","message":"Fixed to ROLLING_BACK","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":1367,"context_line":"        vnf_lcm_op_occs.state_entered_time \u003d timestamp"},{"line_number":1368,"context_line":"        LOG.debug(\"vnf_lcm_op_occs %s\", vnf_lcm_op_occs)"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"        instaUrl \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":1371,"context_line":"            \"/vnflcm/v1/vnf_instances/\" + \\"},{"line_number":1372,"context_line":"            vnf_instance.id"},{"line_number":1373,"context_line":"        vnflcmUrl \u003d CONF.vnf_lcm.endpoint_url + \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_746438e6","line":1370,"updated":"2020-09-01 09:48:02.000000000","message":"Should be a snake_case.\nSame for others.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1367,"context_line":"        vnf_lcm_op_occs.state_entered_time \u003d timestamp"},{"line_number":1368,"context_line":"        LOG.debug(\"vnf_lcm_op_occs %s\", vnf_lcm_op_occs)"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"        instaUrl \u003d CONF.vnf_lcm.endpoint_url + \\"},{"line_number":1371,"context_line":"            \"/vnflcm/v1/vnf_instances/\" + \\"},{"line_number":1372,"context_line":"            vnf_instance.id"},{"line_number":1373,"context_line":"        vnflcmUrl \u003d CONF.vnf_lcm.endpoint_url + \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_14ed25b7","line":1370,"in_reply_to":"9f560f44_746438e6","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"3d866df20c24cfa7a7b6c6c6a8b311f097e46293","unresolved":false,"context_lines":[{"line_number":1393,"context_line":"        notification[\u0027_links\u0027][\u0027vnfLcmOpOcc\u0027][\u0027href\u0027] \u003d vnflcmUrl"},{"line_number":1394,"context_line":"        vnf_info[\u0027notification\u0027] \u003d notification"},{"line_number":1395,"context_line":"        vnf_lcm_op_occs.save()"},{"line_number":1396,"context_line":"        self.rpc_api.sendNotification(context, notification)"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"        vim_info \u003d vnflcm_utils._get_vim(context,"},{"line_number":1399,"context_line":"            vnf_instance.vim_connection_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e83b96c4","line":1396,"updated":"2020-09-11 16:06:48.000000000","message":"Function names should be implemented in the snake case.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1393,"context_line":"        notification[\u0027_links\u0027][\u0027vnfLcmOpOcc\u0027][\u0027href\u0027] \u003d vnflcmUrl"},{"line_number":1394,"context_line":"        vnf_info[\u0027notification\u0027] \u003d notification"},{"line_number":1395,"context_line":"        vnf_lcm_op_occs.save()"},{"line_number":1396,"context_line":"        self.rpc_api.sendNotification(context, notification)"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"        vim_info \u003d vnflcm_utils._get_vim(context,"},{"line_number":1399,"context_line":"            vnf_instance.vim_connection_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_542cbd00","line":1396,"in_reply_to":"9f560f44_e83b96c4","updated":"2020-09-14 20:24:19.000000000","message":"changed to snake_case","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":1401,"context_line":"        vim_connection_info \u003d objects.VimConnectionInfo.obj_from_primitive("},{"line_number":1402,"context_line":"            vim_info, context)"},{"line_number":1403,"context_line":""},{"line_number":1404,"context_line":"        scale_id_list, scale_name_list, grp_id \u003d self._rollback_vnf_pre("},{"line_number":1405,"context_line":"            context, vnf_info, vnf_instance,"},{"line_number":1406,"context_line":"            operation_params, vim_connection_info)"},{"line_number":1407,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_540c9493","line":1404,"updated":"2020-09-01 09:48:02.000000000","message":"\"scale_id_list\" seems to be unused, is it unnecessary?","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":1401,"context_line":"        vim_connection_info \u003d objects.VimConnectionInfo.obj_from_primitive("},{"line_number":1402,"context_line":"            vim_info, context)"},{"line_number":1403,"context_line":""},{"line_number":1404,"context_line":"        scale_id_list, scale_name_list, grp_id \u003d self._rollback_vnf_pre("},{"line_number":1405,"context_line":"            context, vnf_info, vnf_instance,"},{"line_number":1406,"context_line":"            operation_params, vim_connection_info)"},{"line_number":1407,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d4372d4b","line":1404,"in_reply_to":"9f560f44_540c9493","updated":"2020-09-14 20:24:19.000000000","message":"removed because it is unnecessary","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"7d08fe0cfca00308457e2372bc7e100b0de334b9","unresolved":false,"context_lines":[{"line_number":1363,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027:"},{"line_number":1364,"context_line":"            scale_vnf_request \u003d objects.ScaleVnfRequest.obj_from_primitive("},{"line_number":1365,"context_line":"                operation_params, context\u003dcontext)"},{"line_number":1366,"context_line":"            scale_vnf_request2 \u003d copy.deepcopy(scale_vnf_request)"},{"line_number":1367,"context_line":"            scale_vnf_request2.type \u003d \u0027SCALE_IN\u0027"},{"line_number":1368,"context_line":"            resource_changes \u003d self._scale_resource_update(context, vnf_info,"},{"line_number":1369,"context_line":"                                    vnf_instance,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_8954e9c7","line":1366,"range":{"start_line":1366,"start_character":12,"end_line":1366,"end_character":30},"updated":"2020-09-23 00:10:29.000000000","message":"maybe post_scale_vnf_request will be a better name here?","commit_id":"14d2064c6833c15a1b5e8984ebec1196c993b658"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"89446246dd862b90be650c69d88b9df0c46eb1c6","unresolved":false,"context_lines":[{"line_number":1363,"context_line":"        if vnf_lcm_op_occs.operation \u003d\u003d \u0027SCALE\u0027:"},{"line_number":1364,"context_line":"            scale_vnf_request \u003d objects.ScaleVnfRequest.obj_from_primitive("},{"line_number":1365,"context_line":"                operation_params, context\u003dcontext)"},{"line_number":1366,"context_line":"            scale_vnf_request2 \u003d copy.deepcopy(scale_vnf_request)"},{"line_number":1367,"context_line":"            scale_vnf_request2.type \u003d \u0027SCALE_IN\u0027"},{"line_number":1368,"context_line":"            resource_changes \u003d self._scale_resource_update(context, vnf_info,"},{"line_number":1369,"context_line":"                                    vnf_instance,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_4041c035","line":1366,"range":{"start_line":1366,"start_character":12,"end_line":1366,"end_character":30},"in_reply_to":"9f560f44_8954e9c7","updated":"2020-09-25 17:02:12.000000000","message":"The name is modified but not according to your suggestion (sorry).","commit_id":"14d2064c6833c15a1b5e8984ebec1196c993b658"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"7d08fe0cfca00308457e2372bc7e100b0de334b9","unresolved":false,"context_lines":[{"line_number":1444,"context_line":"        vnf_lcm_op_occs.save()"},{"line_number":1445,"context_line":"        self.rpc_api.send_notification(context, notification)"},{"line_number":1446,"context_line":""},{"line_number":1447,"context_line":"        vim_info \u003d vnflcm_utils._get_vim(context,"},{"line_number":1448,"context_line":"            vnf_instance.vim_connection_info)"},{"line_number":1449,"context_line":""},{"line_number":1450,"context_line":"        vim_connection_info \u003d objects.VimConnectionInfo.obj_from_primitive("},{"line_number":1451,"context_line":"            vim_info, context)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_293afd96","line":1448,"range":{"start_line":1447,"start_character":6,"end_line":1448,"end_character":45},"updated":"2020-09-23 00:10:29.000000000","message":"Maybe we should avoid to access an internal method directly?","commit_id":"14d2064c6833c15a1b5e8984ebec1196c993b658"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"399a7b5e978d1af2967c199de8b6f0280d87007b","unresolved":false,"context_lines":[{"line_number":1444,"context_line":"        vnf_lcm_op_occs.save()"},{"line_number":1445,"context_line":"        self.rpc_api.send_notification(context, notification)"},{"line_number":1446,"context_line":""},{"line_number":1447,"context_line":"        vim_info \u003d vnflcm_utils._get_vim(context,"},{"line_number":1448,"context_line":"            vnf_instance.vim_connection_info)"},{"line_number":1449,"context_line":""},{"line_number":1450,"context_line":"        vim_connection_info \u003d objects.VimConnectionInfo.obj_from_primitive("},{"line_number":1451,"context_line":"            vim_info, context)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_a7d44848","line":1448,"range":{"start_line":1447,"start_character":6,"end_line":1448,"end_character":45},"in_reply_to":"9f560f44_293afd96","updated":"2020-09-24 18:53:36.000000000","message":"This is used this way by Ussuri, so I think it needs to be reviewed overall. Since it should be modified together with other usage points, I would like to leave a memo as TODO and implement it as it is.","commit_id":"14d2064c6833c15a1b5e8984ebec1196c993b658"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"e90e462520d10a029e720e987f57df6899dfa25c","unresolved":false,"context_lines":[{"line_number":1444,"context_line":"        vnf_lcm_op_occs.save()"},{"line_number":1445,"context_line":"        self.rpc_api.send_notification(context, notification)"},{"line_number":1446,"context_line":""},{"line_number":1447,"context_line":"        vim_info \u003d vnflcm_utils._get_vim(context,"},{"line_number":1448,"context_line":"            vnf_instance.vim_connection_info)"},{"line_number":1449,"context_line":""},{"line_number":1450,"context_line":"        vim_connection_info \u003d objects.VimConnectionInfo.obj_from_primitive("},{"line_number":1451,"context_line":"            vim_info, context)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_aae08898","line":1448,"range":{"start_line":1447,"start_character":6,"end_line":1448,"end_character":45},"in_reply_to":"9f560f44_a7d44848","updated":"2020-09-25 03:30:30.000000000","message":"Thank you for that!","commit_id":"14d2064c6833c15a1b5e8984ebec1196c993b658"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":2306,"context_line":"        if cap_size \u003c min_size:"},{"line_number":2307,"context_line":"            cap_size \u003d min_size"},{"line_number":2308,"context_line":""},{"line_number":2309,"context_line":"        res_list2 \u003d res_list[:cap_size]"},{"line_number":2310,"context_line":"        LOG.debug(\"res_list2 reverse %s\", res_list2)"},{"line_number":2311,"context_line":""},{"line_number":2312,"context_line":"        before_list \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b9c40961","line":2309,"updated":"2020-09-01 09:48:02.000000000","message":"It is better to use meaningful variable names instead of temporary variable names.\nFor example, \"reversed_res_list\".","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":2306,"context_line":"        if cap_size \u003c min_size:"},{"line_number":2307,"context_line":"            cap_size \u003d min_size"},{"line_number":2308,"context_line":""},{"line_number":2309,"context_line":"        res_list2 \u003d res_list[:cap_size]"},{"line_number":2310,"context_line":"        LOG.debug(\"res_list2 reverse %s\", res_list2)"},{"line_number":2311,"context_line":""},{"line_number":2312,"context_line":"        before_list \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_144245ac","line":2309,"in_reply_to":"9f560f44_b9c40961","updated":"2020-09-14 20:24:19.000000000","message":"it is renamed.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9e7809979413df26e4bd730fd89c8694d6da7c02","unresolved":false,"context_lines":[{"line_number":2309,"context_line":"        res_list2 \u003d res_list[:cap_size]"},{"line_number":2310,"context_line":"        LOG.debug(\"res_list2 reverse %s\", res_list2)"},{"line_number":2311,"context_line":""},{"line_number":2312,"context_line":"        before_list \u003d []"},{"line_number":2313,"context_line":"        after_list \u003d []"},{"line_number":2314,"context_line":"        before_rs_list \u003d []"},{"line_number":2315,"context_line":"        after_rs_list \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_19db7521","line":2312,"updated":"2020-09-01 09:48:02.000000000","message":"Is it difficult to read the processing intent, so could you please add a comment?","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5fce7263061b2bfce8c6330a794571e1cd52c80b","unresolved":false,"context_lines":[{"line_number":2309,"context_line":"        res_list2 \u003d res_list[:cap_size]"},{"line_number":2310,"context_line":"        LOG.debug(\"res_list2 reverse %s\", res_list2)"},{"line_number":2311,"context_line":""},{"line_number":2312,"context_line":"        before_list \u003d []"},{"line_number":2313,"context_line":"        after_list \u003d []"},{"line_number":2314,"context_line":"        before_rs_list \u003d []"},{"line_number":2315,"context_line":"        after_rs_list \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7410e1ac","line":2312,"in_reply_to":"9f560f44_19db7521","updated":"2020-09-14 20:24:19.000000000","message":"Added comment to clarify processing intent.","commit_id":"2ecbb019c77b1ae08a40f1ccca5ab2aa9aa79834"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"7d08fe0cfca00308457e2372bc7e100b0de334b9","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"                                        if cp_resource.\\"},{"line_number":1735,"context_line":"                                            cp_instance_id \u003d\u003d \\"},{"line_number":1736,"context_line":"                                                vnfc_cp_rsc.id:"},{"line_number":1737,"context_line":"                                            p_id \u003d cp_resource.id"},{"line_number":1738,"context_line":"                                            v_id \u003d vnfc_resource.vdu_id"},{"line_number":1739,"context_line":"                                            d_id \u003d vnfc_cp_rsc.cpd_id"},{"line_number":1740,"context_line":"                                            r_hd \u003d objects.\\"},{"line_number":1741,"context_line":"                                                ResourceHandle()"},{"line_number":1742,"context_line":"                                            r_hd.\\"},{"line_number":1743,"context_line":"                                                vim_connection_id \u003d \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_29083dd7","line":1740,"range":{"start_line":1737,"start_character":44,"end_line":1740,"end_character":60},"updated":"2020-09-23 00:10:29.000000000","message":"why do you use some intermediate variable here, it seems you can parse value directly or just use original variable here.","commit_id":"14d2064c6833c15a1b5e8984ebec1196c993b658"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"89446246dd862b90be650c69d88b9df0c46eb1c6","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"                                        if cp_resource.\\"},{"line_number":1735,"context_line":"                                            cp_instance_id \u003d\u003d \\"},{"line_number":1736,"context_line":"                                                vnfc_cp_rsc.id:"},{"line_number":1737,"context_line":"                                            p_id \u003d cp_resource.id"},{"line_number":1738,"context_line":"                                            v_id \u003d vnfc_resource.vdu_id"},{"line_number":1739,"context_line":"                                            d_id \u003d vnfc_cp_rsc.cpd_id"},{"line_number":1740,"context_line":"                                            r_hd \u003d objects.\\"},{"line_number":1741,"context_line":"                                                ResourceHandle()"},{"line_number":1742,"context_line":"                                            r_hd.\\"},{"line_number":1743,"context_line":"                                                vim_connection_id \u003d \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_e023b456","line":1740,"range":{"start_line":1737,"start_character":44,"end_line":1740,"end_character":60},"in_reply_to":"9f560f44_29083dd7","updated":"2020-09-25 17:02:12.000000000","message":"It is fixed.","commit_id":"14d2064c6833c15a1b5e8984ebec1196c993b658"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"db142230bfc751ddb2b9ee14a391677983c55c55","unresolved":false,"context_lines":[{"line_number":1800,"context_line":"                                            rs.type \u003d \u0027constants.\\"},{"line_number":1801,"context_line":"                                                TYPE_LINKPORT\u0027"},{"line_number":1802,"context_line":"                                            rs.vdu_id \u003d vnfc_resource.vdu_id"},{"line_number":1803,"context_line":"                                            rs.resource_template_id \u003d vnfc_cp_rsc.cpd_id"},{"line_number":1804,"context_line":"                                            rs.resource \u003d r_hd"},{"line_number":1805,"context_line":"                                            remove_resources.append("},{"line_number":1806,"context_line":"                                                rs)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_369bfa64","line":1803,"updated":"2020-09-30 07:35:33.000000000","message":"pep8: E501 line too long (88 \u003e 79 characters)","commit_id":"2877b6c57fc28c499daaeac7a72927531c243e7b"}]}