)]}'
{"tacker/api/vnfpkgm/v1/router.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f410128d05a12529dc395540bfd29a4c4c9d60e2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                action\u003daction,"},{"line_number":41,"context_line":"                conditions\u003d{\u0027method\u0027: [method]})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            add \u003d cfg.ListOpt(\u0027vnflcm_\u0027"},{"line_number":44,"context_line":"            + action + \u0027_scope\u0027,"},{"line_number":45,"context_line":"                      default\u003d[],"},{"line_number":46,"context_line":"                      help\u003d\"OAuth2.0 api token scope for\" + action)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_cdbd7fd8","line":43,"updated":"2020-09-04 01:55:21.000000000","message":"I think it should be \u0027vnfpkgm\u0027.\nIs it right?","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6229b449603056c3c9bd095624ea596ce6c23aeb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                action\u003daction,"},{"line_number":41,"context_line":"                conditions\u003d{\u0027method\u0027: [method]})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            add \u003d cfg.ListOpt(\u0027vnflcm_\u0027"},{"line_number":44,"context_line":"            + action + \u0027_scope\u0027,"},{"line_number":45,"context_line":"                      default\u003d[],"},{"line_number":46,"context_line":"                      help\u003d\"OAuth2.0 api token scope for\" + action)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_90f6fc5c","line":43,"in_reply_to":"9f560f44_12d4f9ba","updated":"2020-09-19 11:59:33.000000000","message":"Done","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"cb1208d3e27a95f26409953a99ce9b751ef004de","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                action\u003daction,"},{"line_number":41,"context_line":"                conditions\u003d{\u0027method\u0027: [method]})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            add \u003d cfg.ListOpt(\u0027vnflcm_\u0027"},{"line_number":44,"context_line":"            + action + \u0027_scope\u0027,"},{"line_number":45,"context_line":"                      default\u003d[],"},{"line_number":46,"context_line":"                      help\u003d\"OAuth2.0 api token scope for\" + action)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_12d4f9ba","line":43,"in_reply_to":"9f560f44_5c23dbbe","updated":"2020-09-16 02:49:54.000000000","message":"I think \u0027vnfpkgm\u0027 is better than \u0027vnfpkg\u0027.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"349340ffc3eb322b94c318e23bb01a170d15561b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                action\u003daction,"},{"line_number":41,"context_line":"                conditions\u003d{\u0027method\u0027: [method]})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            add \u003d cfg.ListOpt(\u0027vnflcm_\u0027"},{"line_number":44,"context_line":"            + action + \u0027_scope\u0027,"},{"line_number":45,"context_line":"                      default\u003d[],"},{"line_number":46,"context_line":"                      help\u003d\"OAuth2.0 api token scope for\" + action)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_5c23dbbe","line":43,"in_reply_to":"9f560f44_cdbd7fd8","updated":"2020-09-04 10:48:22.000000000","message":"Corrected as pointed out.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"}],"tacker/auth.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bef6cd58ff962d8fbca9b97f8c84193f29fa61eb","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                \u0027Content-Type\u0027: \u0027application/x-www-form-urlencoded\u0027},"},{"line_number":92,"context_line":"            \u0027data\u0027: {"},{"line_number":93,"context_line":"                \u0027grant_type\u0027: self.grant_type},"},{"line_number":94,"context_line":"            \u0027timeout\u0027: cfg.CONF.authentication.timeout}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        basic_auth_request \u003d _BasicAuthSession("},{"line_number":97,"context_line":"            self.client_id, self.client_password)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_b3e50a3b","line":94,"updated":"2020-09-04 06:01:56.000000000","message":"I think it should be fixed with the 747349 patch.\nSame　for others.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"0b317164e4a22ae6f6311f3efb58715f4858b303","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                \u0027Content-Type\u0027: \u0027application/x-www-form-urlencoded\u0027},"},{"line_number":92,"context_line":"            \u0027data\u0027: {"},{"line_number":93,"context_line":"                \u0027grant_type\u0027: self.grant_type},"},{"line_number":94,"context_line":"            \u0027timeout\u0027: cfg.CONF.authentication.timeout}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        basic_auth_request \u003d _BasicAuthSession("},{"line_number":97,"context_line":"            self.client_id, self.client_password)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ed03a840","line":94,"in_reply_to":"9f560f44_7731270b","updated":"2020-09-11 15:48:03.000000000","message":"[correction] 747349 doesn\u0027t contain this description, so fixed only in this patch.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"eb571699a20dbe73d62ba1b2f47927f7040b0ec1","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                \u0027Content-Type\u0027: \u0027application/x-www-form-urlencoded\u0027},"},{"line_number":92,"context_line":"            \u0027data\u0027: {"},{"line_number":93,"context_line":"                \u0027grant_type\u0027: self.grant_type},"},{"line_number":94,"context_line":"            \u0027timeout\u0027: cfg.CONF.authentication.timeout}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        basic_auth_request \u003d _BasicAuthSession("},{"line_number":97,"context_line":"            self.client_id, self.client_password)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_7731270b","line":94,"in_reply_to":"9f560f44_b3e50a3b","updated":"2020-09-11 14:34:26.000000000","message":"Done in 747349 patch.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bef6cd58ff962d8fbca9b97f8c84193f29fa61eb","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"            self.scheduler_delete_token(response_body)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def scheduler_delete_token(self, response_body):"},{"line_number":373,"context_line":"        if not (response_body.get(\u0027expires_in\u0027)):"},{"line_number":374,"context_line":"            LOG.debug(\"\u0027expires_in\u0027 does not exist in the response body.\")"},{"line_number":375,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_b31a2a14","line":372,"updated":"2020-09-04 06:01:56.000000000","message":"I think it\u0027s better to add\u0027_\u0027 and modify it to indicate that it is an internal function.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"349340ffc3eb322b94c318e23bb01a170d15561b","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"            self.scheduler_delete_token(response_body)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def scheduler_delete_token(self, response_body):"},{"line_number":373,"context_line":"        if not (response_body.get(\u0027expires_in\u0027)):"},{"line_number":374,"context_line":"            LOG.debug(\"\u0027expires_in\u0027 does not exist in the response body.\")"},{"line_number":375,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_9c061320","line":372,"in_reply_to":"9f560f44_b31a2a14","updated":"2020-09-04 10:48:22.000000000","message":"Corrected as pointed out.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bef6cd58ff962d8fbca9b97f8c84193f29fa61eb","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            LOG.info("},{"line_number":384,"context_line":"                \"expires_in\u003d\u003c{}\u003e exist, scheduler regist.\".format(expires_in))"},{"line_number":385,"context_line":"        except (ValueError, TypeError):"},{"line_number":386,"context_line":"            pass"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def _delete_access_token(self):"},{"line_number":389,"context_line":"        self.access_token \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_132af62a","line":386,"updated":"2020-09-04 06:01:56.000000000","message":"Is it correct to \u0027pass\u0027 through this processing route?","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"349340ffc3eb322b94c318e23bb01a170d15561b","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            LOG.info("},{"line_number":384,"context_line":"                \"expires_in\u003d\u003c{}\u003e exist, scheduler regist.\".format(expires_in))"},{"line_number":385,"context_line":"        except (ValueError, TypeError):"},{"line_number":386,"context_line":"            pass"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def _delete_access_token(self):"},{"line_number":389,"context_line":"        self.access_token \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_7c017f06","line":386,"in_reply_to":"9f560f44_132af62a","updated":"2020-09-04 10:48:22.000000000","message":"It is correct in the existing implementation.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bef6cd58ff962d8fbca9b97f8c84193f29fa61eb","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        return \u0027\u0027"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def validate_scope(self, res_scope):"},{"line_number":403,"context_line":"        if res_scope is None:"},{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_931566e8","line":402,"updated":"2020-09-04 06:01:56.000000000","message":"I think it\u0027s better to add\u0027_\u0027 and modify it to indicate that it is an internal function.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"349340ffc3eb322b94c318e23bb01a170d15561b","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        return \u0027\u0027"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def validate_scope(self, res_scope):"},{"line_number":403,"context_line":"        if res_scope is None:"},{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_070bd023","line":402,"in_reply_to":"9f560f44_931566e8","updated":"2020-09-04 10:48:22.000000000","message":"Corrected as pointed out.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bef6cd58ff962d8fbca9b97f8c84193f29fa61eb","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            api_scope_name \u003d self._generate_api_scope_name() + \u0027_scope\u0027"},{"line_number":408,"context_line":"            scopes \u003d cfg.CONF.authentication.__getitem__(api_scope_name)"},{"line_number":409,"context_line":"        except Exception:"},{"line_number":410,"context_line":"            return"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if len(scopes) \u003d\u003d 0:"},{"line_number":413,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_936726b8","line":410,"updated":"2020-09-04 06:01:56.000000000","message":"Is it correct to return with this processing route?\nIsn\u0027t it better to raise an exception?","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"cb1208d3e27a95f26409953a99ce9b751ef004de","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            api_scope_name \u003d self._generate_api_scope_name() + \u0027_scope\u0027"},{"line_number":408,"context_line":"            scopes \u003d cfg.CONF.authentication.__getitem__(api_scope_name)"},{"line_number":409,"context_line":"        except Exception:"},{"line_number":410,"context_line":"            return"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if len(scopes) \u003d\u003d 0:"},{"line_number":413,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f2b4e584","line":410,"in_reply_to":"9f560f44_8716c048","updated":"2020-09-16 02:49:54.000000000","message":"It doesn\u0027t seem to be fixed.\nAlso, the commented out code has been added.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"349340ffc3eb322b94c318e23bb01a170d15561b","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            api_scope_name \u003d self._generate_api_scope_name() + \u0027_scope\u0027"},{"line_number":408,"context_line":"            scopes \u003d cfg.CONF.authentication.__getitem__(api_scope_name)"},{"line_number":409,"context_line":"        except Exception:"},{"line_number":410,"context_line":"            return"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if len(scopes) \u003d\u003d 0:"},{"line_number":413,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_8716c048","line":410,"in_reply_to":"9f560f44_936726b8","updated":"2020-09-04 10:48:22.000000000","message":"Corrected as pointed out.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6229b449603056c3c9bd095624ea596ce6c23aeb","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            api_scope_name \u003d self._generate_api_scope_name() + \u0027_scope\u0027"},{"line_number":408,"context_line":"            scopes \u003d cfg.CONF.authentication.__getitem__(api_scope_name)"},{"line_number":409,"context_line":"        except Exception:"},{"line_number":410,"context_line":"            return"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if len(scopes) \u003d\u003d 0:"},{"line_number":413,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_10a02c42","line":410,"in_reply_to":"9f560f44_f2b4e584","updated":"2020-09-19 11:59:33.000000000","message":"Fixed.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bef6cd58ff962d8fbca9b97f8c84193f29fa61eb","unresolved":false,"context_lines":[{"line_number":479,"context_line":"            return self.__manages.get(token_value)"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        match \u003d application.map.match(request.path_info)"},{"line_number":482,"context_line":"        api_name \u003d match[0].get(\"action\")"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        if token_type \u003d\u003d \u0027Bearer\u0027:"},{"line_number":485,"context_line":"            auth_obj \u003d _AuthValidateBearer("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_536d8e97","line":482,"updated":"2020-09-04 06:01:56.000000000","message":"Is the access to this \u0027match\u0027 correct?\nIs it possible to be \"None\"?","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"349340ffc3eb322b94c318e23bb01a170d15561b","unresolved":false,"context_lines":[{"line_number":479,"context_line":"            return self.__manages.get(token_value)"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        match \u003d application.map.match(request.path_info)"},{"line_number":482,"context_line":"        api_name \u003d match[0].get(\"action\")"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        if token_type \u003d\u003d \u0027Bearer\u0027:"},{"line_number":485,"context_line":"            auth_obj \u003d _AuthValidateBearer("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_c74ef86c","line":482,"in_reply_to":"9f560f44_536d8e97","updated":"2020-09-04 10:48:22.000000000","message":"There is no problem because some value is set in action for processing after _setup_route function is executed in tacker/tacker/api/vnflcm/v1/router.py.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"}],"tacker/tests/unit/test_auth.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f410128d05a12529dc395540bfd29a4c4c9d60e2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_middleware import request_id"},{"line_number":20,"context_line":"import requests"},{"line_number":21,"context_line":"from requests_mock.contrib import fixture as requests_mock_fixture"},{"line_number":22,"context_line":"from tacker.api.vnflcm.v1.router import VnflcmAPIRouter"},{"line_number":23,"context_line":"from tacker import auth"},{"line_number":24,"context_line":"from tacker.tests import base as test_base"},{"line_number":25,"context_line":"from tacker.tests.unit import base as unit_base"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_b0b7c03a","line":22,"updated":"2020-09-04 01:55:21.000000000","message":"I think you should also add a test for tacker.api.vnfpkgm.v1.router.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"349340ffc3eb322b94c318e23bb01a170d15561b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_middleware import request_id"},{"line_number":20,"context_line":"import requests"},{"line_number":21,"context_line":"from requests_mock.contrib import fixture as requests_mock_fixture"},{"line_number":22,"context_line":"from tacker.api.vnflcm.v1.router import VnflcmAPIRouter"},{"line_number":23,"context_line":"from tacker import auth"},{"line_number":24,"context_line":"from tacker.tests import base as test_base"},{"line_number":25,"context_line":"from tacker.tests.unit import base as unit_base"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_dc188b85","line":22,"in_reply_to":"9f560f44_b0b7c03a","updated":"2020-09-04 10:48:22.000000000","message":"Added the test.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f410128d05a12529dc395540bfd29a4c4c9d60e2","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def test_get_auth_client_oauth2_client_credentials_with_local(self):"},{"line_number":156,"context_line":"        cfg.CONF.set_override(\u0027auth_type\u0027, \u0027OAUTH2_CLIENT_CREDENTIALS\u0027,"},{"line_number":157,"context_line":"                              group\u003d\u0027authentication\u0027)"},{"line_number":158,"context_line":"        cfg.CONF.set_override(\u0027token_endpoint\u0027, self.url,"},{"line_number":159,"context_line":"                              group\u003d\u0027authentication\u0027)"},{"line_number":160,"context_line":"        cfg.CONF.set_override(\u0027client_id\u0027, self.user_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_50a8e4d7","line":157,"updated":"2020-09-04 01:55:21.000000000","message":"I think it should be fixed with the 747349 patch.\nSame　for others.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"eb571699a20dbe73d62ba1b2f47927f7040b0ec1","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def test_get_auth_client_oauth2_client_credentials_with_local(self):"},{"line_number":156,"context_line":"        cfg.CONF.set_override(\u0027auth_type\u0027, \u0027OAUTH2_CLIENT_CREDENTIALS\u0027,"},{"line_number":157,"context_line":"                              group\u003d\u0027authentication\u0027)"},{"line_number":158,"context_line":"        cfg.CONF.set_override(\u0027token_endpoint\u0027, self.url,"},{"line_number":159,"context_line":"                              group\u003d\u0027authentication\u0027)"},{"line_number":160,"context_line":"        cfg.CONF.set_override(\u0027client_id\u0027, self.user_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_9745db71","line":157,"in_reply_to":"9f560f44_50a8e4d7","updated":"2020-09-11 14:34:26.000000000","message":"Done in 747349 patch.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"0b317164e4a22ae6f6311f3efb58715f4858b303","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def test_get_auth_client_oauth2_client_credentials_with_local(self):"},{"line_number":156,"context_line":"        cfg.CONF.set_override(\u0027auth_type\u0027, \u0027OAUTH2_CLIENT_CREDENTIALS\u0027,"},{"line_number":157,"context_line":"                              group\u003d\u0027authentication\u0027)"},{"line_number":158,"context_line":"        cfg.CONF.set_override(\u0027token_endpoint\u0027, self.url,"},{"line_number":159,"context_line":"                              group\u003d\u0027authentication\u0027)"},{"line_number":160,"context_line":"        cfg.CONF.set_override(\u0027client_id\u0027, self.user_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_4d98d419","line":157,"in_reply_to":"9f560f44_9745db71","updated":"2020-09-11 15:48:03.000000000","message":"[correction] 747349 doesn\u0027t contain this description, so fixed only in this patch.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"2606eba15fa59efbadd1cc2928e2df1f5a3114fe","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_middleware import request_id"},{"line_number":20,"context_line":"import requests"},{"line_number":21,"context_line":"from requests_mock.contrib import fixture as requests_mock_fixture"},{"line_number":22,"context_line":"from tacker.api.vnflcm.v1.router import VnflcmAPIRouter"},{"line_number":23,"context_line":"from tacker.api.vnfpkgm.v1.router import VnfpkgmAPIRouter"},{"line_number":24,"context_line":"from tacker import auth"},{"line_number":25,"context_line":"from tacker.tests import base as test_base"},{"line_number":26,"context_line":"from tacker.tests.unit import base as unit_base"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_3a8af9ba","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":57},"updated":"2020-09-11 11:19:44.000000000","message":"Only modules can be imported, objects cannot be imported.","commit_id":"e62f524a06f47535cbd60f5a3000b941166b90f6"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"bef06a77a1282b41b987bd8fefcf66e1d6ba1890","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_middleware import request_id"},{"line_number":20,"context_line":"import requests"},{"line_number":21,"context_line":"from requests_mock.contrib import fixture as requests_mock_fixture"},{"line_number":22,"context_line":"from tacker.api.vnflcm.v1.router import VnflcmAPIRouter"},{"line_number":23,"context_line":"from tacker.api.vnfpkgm.v1.router import VnfpkgmAPIRouter"},{"line_number":24,"context_line":"from tacker import auth"},{"line_number":25,"context_line":"from tacker.tests import base as test_base"},{"line_number":26,"context_line":"from tacker.tests.unit import base as unit_base"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_50a4d706","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":57},"in_reply_to":"9f560f44_3a8af9ba","updated":"2020-09-14 00:14:54.000000000","message":"Fixed.","commit_id":"e62f524a06f47535cbd60f5a3000b941166b90f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"cb1208d3e27a95f26409953a99ce9b751ef004de","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import requests"},{"line_number":21,"context_line":"from requests_mock.contrib import fixture as requests_mock_fixture"},{"line_number":22,"context_line":"import tacker.api.vnflcm.v1.router as vnflcm_router"},{"line_number":23,"context_line":"import tacker.api.vnfpkgm.v1.router as vnf_pkg_router"},{"line_number":24,"context_line":"from tacker import auth"},{"line_number":25,"context_line":"from tacker.tests import base as test_base"},{"line_number":26,"context_line":"from tacker.tests.unit import base as unit_base"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_92f1296e","line":23,"updated":"2020-09-16 02:49:54.000000000","message":"\u0027vnfpkgm_router\u0027 is better.","commit_id":"254ed24f4db46b708432fe29ee652b4813a92f6a"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"6229b449603056c3c9bd095624ea596ce6c23aeb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import requests"},{"line_number":21,"context_line":"from requests_mock.contrib import fixture as requests_mock_fixture"},{"line_number":22,"context_line":"import tacker.api.vnflcm.v1.router as vnflcm_router"},{"line_number":23,"context_line":"import tacker.api.vnfpkgm.v1.router as vnf_pkg_router"},{"line_number":24,"context_line":"from tacker import auth"},{"line_number":25,"context_line":"from tacker.tests import base as test_base"},{"line_number":26,"context_line":"from tacker.tests.unit import base as unit_base"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_7086c8bc","line":23,"in_reply_to":"9f560f44_92f1296e","updated":"2020-09-19 11:59:33.000000000","message":"Fixed.","commit_id":"254ed24f4db46b708432fe29ee652b4813a92f6a"}],"tacker/tests/unit/vnfm/test_nfvo_client.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f410128d05a12529dc395540bfd29a4c4c9d60e2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.auth_password \u003d \u0027test_password\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        cfg.CONF.set_override(\u0027auth_type\u0027, None,"},{"line_number":56,"context_line":"                              group\u003d\u0027authentication\u0027)"},{"line_number":57,"context_line":"        auth.auth_manager \u003d auth._AuthManager()"},{"line_number":58,"context_line":"        VnfPackageRequest._connector \u003d _Connect(2, 1, 20)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_8ded47b9","line":56,"updated":"2020-09-04 01:55:21.000000000","message":"I think it should be fixed with the 747349 patch.\nSame　for others.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"eb571699a20dbe73d62ba1b2f47927f7040b0ec1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.auth_password \u003d \u0027test_password\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        cfg.CONF.set_override(\u0027auth_type\u0027, None,"},{"line_number":56,"context_line":"                              group\u003d\u0027authentication\u0027)"},{"line_number":57,"context_line":"        auth.auth_manager \u003d auth._AuthManager()"},{"line_number":58,"context_line":"        VnfPackageRequest._connector \u003d _Connect(2, 1, 20)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_d75ab34d","line":56,"in_reply_to":"9f560f44_8ded47b9","updated":"2020-09-11 14:34:26.000000000","message":"Done in 747349 patch.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"0b317164e4a22ae6f6311f3efb58715f4858b303","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.auth_password \u003d \u0027test_password\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        cfg.CONF.set_override(\u0027auth_type\u0027, None,"},{"line_number":56,"context_line":"                              group\u003d\u0027authentication\u0027)"},{"line_number":57,"context_line":"        auth.auth_manager \u003d auth._AuthManager()"},{"line_number":58,"context_line":"        VnfPackageRequest._connector \u003d _Connect(2, 1, 20)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_cd8344a8","line":56,"in_reply_to":"9f560f44_d75ab34d","updated":"2020-09-11 15:48:03.000000000","message":"[correction] 747349 doesn\u0027t contain this description, so fixed only in this patch.","commit_id":"f5d33410887da4936bdb59052ea1db68c02e53de"}]}