)]}'
{".zuul.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":179,"context_line":"          post-config:"},{"line_number":180,"context_line":"            $NOVA_CONF:"},{"line_number":181,"context_line":"              DEFAULT:"},{"line_number":182,"context_line":"                vif_plugging_is_fatal: False"},{"line_number":183,"context_line":"        devstack_services:"},{"line_number":184,"context_line":"          q-agt: true"},{"line_number":185,"context_line":"          n-api: false"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"faadb100_bfe7378d","line":182,"updated":"2020-12-18 08:37:29.000000000","message":"What is the purpose of this change?","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":179,"context_line":"          post-config:"},{"line_number":180,"context_line":"            $NOVA_CONF:"},{"line_number":181,"context_line":"              DEFAULT:"},{"line_number":182,"context_line":"                vif_plugging_is_fatal: False"},{"line_number":183,"context_line":"        devstack_services:"},{"line_number":184,"context_line":"          q-agt: true"},{"line_number":185,"context_line":"          n-api: false"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"fd7392ee_9774d7ef","line":182,"in_reply_to":"faadb100_bfe7378d","updated":"2020-12-22 06:21:16.000000000","message":"The explanation of this change has been added in the parent 751176.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"}],"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added Scale Functional tests for Tacker (Victoria)."},{"line_number":10,"context_line":"Added Rollback Functional tests for Tacker (Victoria)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint support-etsi-nfv-specs"},{"line_number":13,"context_line":"Change-Id: I9c25cbdf642e73c791a565abda066ce8e98bf802"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":47,"id":"8364f7c6_d2001f8a","line":11,"updated":"2020-12-18 08:37:29.000000000","message":"Could you add some more explanations for your change for helping reviewers because your update is just a bit huge?","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added Scale Functional tests for Tacker (Victoria)."},{"line_number":10,"context_line":"Added Rollback Functional tests for Tacker (Victoria)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint support-etsi-nfv-specs"},{"line_number":13,"context_line":"Change-Id: I9c25cbdf642e73c791a565abda066ce8e98bf802"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":47,"id":"dac30d0c_59c0c736","line":11,"in_reply_to":"8364f7c6_d2001f8a","updated":"2020-12-22 06:21:16.000000000","message":"The explanations of changes are added.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"}],"tacker/tests/functional/common/fake_server.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":21,"context_line":"import time"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"from urllib.parse import urlparse"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"3ee9d1f9_26fabfba","line":24,"updated":"2020-12-18 08:37:29.000000000","message":"It should be listed in above block of standard libraries.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import time"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"from urllib.parse import urlparse"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"97cc9d88_b2c93c60","line":24,"in_reply_to":"3ee9d1f9_26fabfba","updated":"2020-12-22 06:21:16.000000000","message":"Done","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":122,"context_line":"        This method do not handle message when error is occured."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        Args:"},{"line_number":125,"context_line":"            mock_info (tuple): callback informations from caller."},{"line_number":126,"context_line":"        \"\"\""},{"line_number":127,"context_line":"        request_headers \u003d dict(self.headers._headers)"},{"line_number":128,"context_line":"        request_body \u003d self._parse_request_body()"}],"source_content_type":"text/x-python","patch_set":47,"id":"8e66fc2d_ed52db20","line":125,"updated":"2020-12-18 08:37:29.000000000","message":"You should also update docstring for added arg `path`.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        This method do not handle message when error is occured."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        Args:"},{"line_number":125,"context_line":"            mock_info (tuple): callback informations from caller."},{"line_number":126,"context_line":"        \"\"\""},{"line_number":127,"context_line":"        request_headers \u003d dict(self.headers._headers)"},{"line_number":128,"context_line":"        request_body \u003d self._parse_request_body()"}],"source_content_type":"text/x-python","patch_set":47,"id":"61d349e7_99fc4d0a","line":125,"in_reply_to":"8e66fc2d_ed52db20","updated":"2020-12-22 06:21:16.000000000","message":"Done","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":208,"context_line":"        # Check URI in request."},{"line_number":209,"context_line":"        if self._is_match_with_list():"},{"line_number":210,"context_line":"            # Request is registered in our list."},{"line_number":211,"context_line":"            o \u003d urlparse(self.path)"},{"line_number":212,"context_line":"            self._returned_callback(o.path,"},{"line_number":213,"context_line":"                FakeServerManager.get_instance()._funcs_gets[o.path])"},{"line_number":214,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":47,"id":"540f5699_7eda80a9","line":211,"range":{"start_line":211,"start_character":12,"end_line":211,"end_character":13},"updated":"2020-12-18 08:37:29.000000000","message":"You shouldn\u0027t use such a very short name of variable without in a short statement of `for`, `with` or so.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        # Check URI in request."},{"line_number":209,"context_line":"        if self._is_match_with_list():"},{"line_number":210,"context_line":"            # Request is registered in our list."},{"line_number":211,"context_line":"            o \u003d urlparse(self.path)"},{"line_number":212,"context_line":"            self._returned_callback(o.path,"},{"line_number":213,"context_line":"                FakeServerManager.get_instance()._funcs_gets[o.path])"},{"line_number":214,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":47,"id":"1994baad_5b758515","line":211,"range":{"start_line":211,"start_character":12,"end_line":211,"end_character":13},"in_reply_to":"540f5699_7eda80a9","updated":"2020-12-22 06:21:16.000000000","message":"The name is changed.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        # URI might have trailing uuid or not."},{"line_number":232,"context_line":"        if self._is_match_with_list():"},{"line_number":233,"context_line":"            # Request is registered in our list."},{"line_number":234,"context_line":"            o \u003d urlparse(self.path)"},{"line_number":235,"context_line":"            self._returned_callback(o.path,"},{"line_number":236,"context_line":"                FakeServerManager.get_instance()._funcs_posts[o.path])"},{"line_number":237,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":47,"id":"89cf7de0_862c3278","line":234,"range":{"start_line":234,"start_character":12,"end_line":234,"end_character":13},"updated":"2020-12-18 08:37:29.000000000","message":"ditto","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        # URI might have trailing uuid or not."},{"line_number":232,"context_line":"        if self._is_match_with_list():"},{"line_number":233,"context_line":"            # Request is registered in our list."},{"line_number":234,"context_line":"            o \u003d urlparse(self.path)"},{"line_number":235,"context_line":"            self._returned_callback(o.path,"},{"line_number":236,"context_line":"                FakeServerManager.get_instance()._funcs_posts[o.path])"},{"line_number":237,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":47,"id":"5b3d7c8f_974dc3f7","line":234,"range":{"start_line":234,"start_character":12,"end_line":234,"end_character":13},"in_reply_to":"89cf7de0_862c3278","updated":"2020-12-22 06:21:16.000000000","message":"The name is changed.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":400,"context_line":"                self.objHttpd \u003d http.server.HTTPServer("},{"line_number":401,"context_line":"                    (address, port), DummyRequestHander)"},{"line_number":402,"context_line":"            except OSError:"},{"line_number":403,"context_line":"                time.sleep(10)"},{"line_number":404,"context_line":"                continue"},{"line_number":405,"context_line":"            else:"},{"line_number":406,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":47,"id":"f43672b2_439a26ed","line":403,"range":{"start_line":403,"start_character":27,"end_line":403,"end_character":29},"updated":"2020-12-18 08:37:29.000000000","message":"You should avoid such a hard cording.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":400,"context_line":"                self.objHttpd \u003d http.server.HTTPServer("},{"line_number":401,"context_line":"                    (address, port), DummyRequestHander)"},{"line_number":402,"context_line":"            except OSError:"},{"line_number":403,"context_line":"                time.sleep(10)"},{"line_number":404,"context_line":"                continue"},{"line_number":405,"context_line":"            else:"},{"line_number":406,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":47,"id":"8a023306_37337f36","line":403,"range":{"start_line":403,"start_character":27,"end_line":403,"end_character":29},"in_reply_to":"f43672b2_439a26ed","updated":"2020-12-22 06:21:16.000000000","message":"Changed not to use the magic number.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"}],"tacker/tests/functional/vnflcm/base.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"db579322801c461ba2bdff1fdf3ddcfac5043437","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        self.assert_vnf_state(vnf_instance)"},{"line_number":836,"context_line":"        self.assert_instantiation_state(vnf_instance)"},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"        # TODO(eto.aln) : check scaleStatus"},{"line_number":839,"context_line":"        scale_status \u003d vnf_instance[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"},{"line_number":840,"context_line":"        self.assertTrue(len(scale_status) \u003e 0)"},{"line_number":841,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_28b8970f","line":838,"range":{"start_line":838,"start_character":10,"end_line":838,"end_character":24},"updated":"2020-09-17 05:05:46.000000000","message":"Did you forget to delete this TODO comment?","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"929988d858c6de519d15e86ce8ebb1bbff7c1fc7","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        self.assert_vnf_state(vnf_instance)"},{"line_number":836,"context_line":"        self.assert_instantiation_state(vnf_instance)"},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"        # TODO(eto.aln) : check scaleStatus"},{"line_number":839,"context_line":"        scale_status \u003d vnf_instance[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"},{"line_number":840,"context_line":"        self.assertTrue(len(scale_status) \u003e 0)"},{"line_number":841,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_9c44a5ba","line":838,"range":{"start_line":838,"start_character":10,"end_line":838,"end_character":24},"in_reply_to":"9f560f44_28b8970f","updated":"2020-09-30 10:58:11.000000000","message":"TODO is deleted.","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":425,"context_line":"        return resp, body"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def _scale_vnf_instance(self, vnf_instance_id, request_body):"},{"line_number":428,"context_line":"        url \u003d \\"},{"line_number":429,"context_line":"            os.path.join(self.base_vnf_instances_url, vnf_instance_id, \"scale\")"},{"line_number":430,"context_line":"        resp, body \u003d self.http_client.do_request(url, \"POST\","},{"line_number":431,"context_line":"                body\u003djsonutils.dumps(request_body))"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"2eed98f4_f9a5825d","line":429,"range":{"start_line":428,"start_character":0,"end_line":429,"end_character":25},"updated":"2020-12-18 08:37:29.000000000","message":"Please remove the backslash.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        return resp, body"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def _scale_vnf_instance(self, vnf_instance_id, request_body):"},{"line_number":428,"context_line":"        url \u003d \\"},{"line_number":429,"context_line":"            os.path.join(self.base_vnf_instances_url, vnf_instance_id, \"scale\")"},{"line_number":430,"context_line":"        resp, body \u003d self.http_client.do_request(url, \"POST\","},{"line_number":431,"context_line":"                body\u003djsonutils.dumps(request_body))"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"692eeffa_cbcde353","line":429,"range":{"start_line":428,"start_character":0,"end_line":429,"end_character":25},"in_reply_to":"2eed98f4_f9a5825d","updated":"2020-12-22 06:21:16.000000000","message":"Fixed together with the other similar lines.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"}],"tacker/tests/functional/vnflcm/fake_vnflcm.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"db579322801c461ba2bdff1fdf3ddcfac5043437","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    VIM_CONNECTION_INFO \u003d ["},{"line_number":22,"context_line":"        {"},{"line_number":23,"context_line":"            # TODO(esto.aln): set is default vim_id."},{"line_number":24,"context_line":"            \"id\": uuidsentinel.vim_connection_id,"},{"line_number":25,"context_line":"            \"vimType\": \"ETSINFV.OPENSTACK_KEYSTONE.v_2\","},{"line_number":26,"context_line":"            \"interfaceInfo\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_88d0c32d","line":23,"range":{"start_line":23,"start_character":14,"end_line":23,"end_character":30},"updated":"2020-09-17 05:05:46.000000000","message":"Did you forget to delete this TODO comment?","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"929988d858c6de519d15e86ce8ebb1bbff7c1fc7","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    VIM_CONNECTION_INFO \u003d ["},{"line_number":22,"context_line":"        {"},{"line_number":23,"context_line":"            # TODO(esto.aln): set is default vim_id."},{"line_number":24,"context_line":"            \"id\": uuidsentinel.vim_connection_id,"},{"line_number":25,"context_line":"            \"vimType\": \"ETSINFV.OPENSTACK_KEYSTONE.v_2\","},{"line_number":26,"context_line":"            \"interfaceInfo\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_dc0f3d89","line":23,"range":{"start_line":23,"start_character":14,"end_line":23,"end_character":30},"in_reply_to":"9f560f44_88d0c32d","updated":"2020-09-30 10:58:11.000000000","message":"TODO is deleted.","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"db579322801c461ba2bdff1fdf3ddcfac5043437","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                \"username\": \"nfv_user\","},{"line_number":31,"context_line":"                \"region\": \"RegionOne\","},{"line_number":32,"context_line":"                \"password\": \"devstack\","},{"line_number":33,"context_line":"                # TODO(esto.aln): auto create uuid?"},{"line_number":34,"context_line":"                \"tenant\": uuidsentinel.tenant_id"},{"line_number":35,"context_line":"            }"},{"line_number":36,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_68d3af38","line":33,"range":{"start_line":33,"start_character":18,"end_line":33,"end_character":34},"updated":"2020-09-17 05:05:46.000000000","message":"Did you forget to delete this TODO comment?","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"929988d858c6de519d15e86ce8ebb1bbff7c1fc7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                \"username\": \"nfv_user\","},{"line_number":31,"context_line":"                \"region\": \"RegionOne\","},{"line_number":32,"context_line":"                \"password\": \"devstack\","},{"line_number":33,"context_line":"                # TODO(esto.aln): auto create uuid?"},{"line_number":34,"context_line":"                \"tenant\": uuidsentinel.tenant_id"},{"line_number":35,"context_line":"            }"},{"line_number":36,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_bc1409a1","line":33,"range":{"start_line":33,"start_character":18,"end_line":33,"end_character":34},"in_reply_to":"9f560f44_68d3af38","updated":"2020-09-30 10:58:11.000000000","message":"TODO is deleted.","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"41366cef0c9423ffb4ac94a178e8917671c45330","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class Grant:"},{"line_number":20,"context_line":"    GRANT_REQ_PATH \u003d \u0027/grant/v1/grants\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    ZONES \u003d ["},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"id\": uuidsentinel.zone_id,"},{"line_number":25,"context_line":"            \"zoneId\": \"nova\","},{"line_number":26,"context_line":"            \"vimConnectionId\": uuidsentinel.vim_connection_id"},{"line_number":27,"context_line":"        }"},{"line_number":28,"context_line":"    ]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    ADDITIONAL_PARAMS \u003d {"},{"line_number":31,"context_line":"        \"key\": \"value\""},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @staticmethod"},{"line_number":35,"context_line":"    def _make_vim_connection_info(tenant_id):"},{"line_number":36,"context_line":"        access_info \u003d {"},{"line_number":37,"context_line":"            \"username\": \"nfv_user\","},{"line_number":38,"context_line":"            \"region\": \"RegionOne\","},{"line_number":39,"context_line":"            \"password\": \"devstack\","},{"line_number":40,"context_line":"            \"tenant\": tenant_id"},{"line_number":41,"context_line":"        }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        return [{"},{"line_number":44,"context_line":"            \"id\": uuidsentinel.vim_connection_id,"},{"line_number":45,"context_line":"            \"vimType\": \"ETSINFV.OPENSTACK_KEYSTONE.v_2\","},{"line_number":46,"context_line":"            \"interfaceInfo\": {"},{"line_number":47,"context_line":"                \"endpoint\": \"http://127.0.0.1/identity\""},{"line_number":48,"context_line":"            },"},{"line_number":49,"context_line":"            \"accessInfo\": access_info"},{"line_number":50,"context_line":"        }]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @staticmethod"},{"line_number":53,"context_line":"    def _make_add_resources(req_add_resources):"},{"line_number":54,"context_line":"        add_resources \u003d []"},{"line_number":55,"context_line":"        for req_add_resource in req_add_resources:"},{"line_number":56,"context_line":"            res_add_resource \u003d {"},{"line_number":57,"context_line":"                \"resourceDefinitionId\": req_add_resource[\u0027id\u0027],"},{"line_number":58,"context_line":"                \"vimConnectionId\": uuidsentinel.vim_connection_id"},{"line_number":59,"context_line":"            }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"            if req_add_resource[\u0027type\u0027] \u003d\u003d \u0027COMPUTE\u0027:"},{"line_number":62,"context_line":"                res_add_resource[\"zoneId\"] \u003d uuidsentinel.zone_id"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"            add_resources.append(res_add_resource)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return add_resources"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @staticmethod"},{"line_number":69,"context_line":"    def _make_remove_resources(req_remove_resources):"},{"line_number":70,"context_line":"        res_remove_resources \u003d []"},{"line_number":71,"context_line":"        for req_remove_resource in req_remove_resources:"},{"line_number":72,"context_line":"            res_remove_resource \u003d {"},{"line_number":73,"context_line":"                \"resourceDefinitionId\": req_remove_resource[\u0027id\u0027]"},{"line_number":74,"context_line":"            }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"            res_remove_resources.append(res_remove_resource)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return res_remove_resources"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @staticmethod"},{"line_number":81,"context_line":"    def _make_vim_assets(image_id, flavour_id\u003d\"1\"):"},{"line_number":82,"context_line":"        # set m1.tiny\u003d\"1\" for flavour_id"},{"line_number":83,"context_line":"        vim_assets \u003d {"},{"line_number":84,"context_line":"            \"computeResourceFlavours\": ["},{"line_number":85,"context_line":"                {"},{"line_number":86,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":87,"context_line":"                    \"vnfdVirtualComputeDescId\": \"VDU1\","},{"line_number":88,"context_line":"                    \"vimFlavourId\": flavour_id"},{"line_number":89,"context_line":"                },"},{"line_number":90,"context_line":"                {"},{"line_number":91,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":92,"context_line":"                    \"vnfdVirtualComputeDescId\": \"VDU2\","},{"line_number":93,"context_line":"                    \"vimFlavourId\": flavour_id"},{"line_number":94,"context_line":"                }"},{"line_number":95,"context_line":"            ],"},{"line_number":96,"context_line":"            \"softwareImages\": ["},{"line_number":97,"context_line":"                {"},{"line_number":98,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":99,"context_line":"                    \"vnfdSoftwareImageId\": \"cirros-0.4.0-x86_64-disk\","},{"line_number":100,"context_line":"                    \"vimSoftwareImageId\": image_id"},{"line_number":101,"context_line":"                },"},{"line_number":102,"context_line":"                {"},{"line_number":103,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":104,"context_line":"                    \"vnfdSoftwareImageId\": \"VirtualStorage\","},{"line_number":105,"context_line":"                    \"vimSoftwareImageId\": image_id"},{"line_number":106,"context_line":"                }"},{"line_number":107,"context_line":"            ]"},{"line_number":108,"context_line":"        }"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        return vim_assets"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @staticmethod"},{"line_number":113,"context_line":"    def _make_response_template(request_body):"},{"line_number":114,"context_line":"        res \u003d {"},{"line_number":115,"context_line":"            \"id\": uuidsentinel.__getattr__(request_body[\u0027vnfLcmOpOccId\u0027]),"},{"line_number":116,"context_line":"            \"vnfInstanceId\": request_body[\u0027vnfInstanceId\u0027],"},{"line_number":117,"context_line":"            \"vnfLcmOpOccId\": request_body[\u0027vnfLcmOpOccId\u0027],"},{"line_number":118,"context_line":"        }"},{"line_number":119,"context_line":"        res[\"_links\"] \u003d {"},{"line_number":120,"context_line":"            \"self\": {"},{"line_number":121,"context_line":"                # set fake server port."},{"line_number":122,"context_line":"                \"href\": os.path.join("},{"line_number":123,"context_line":"                    \u0027http://localhost:9990\u0027,"},{"line_number":124,"context_line":"                    Grant.GRANT_REQ_PATH)},"},{"line_number":125,"context_line":"            \"vnfLcmOpOcc\": {"},{"line_number":126,"context_line":"                \"href\": os.path.join("},{"line_number":127,"context_line":"                    \u0027http://localhost:9890/vnflcm/v1/vnf_lcm_op_occs\u0027,"},{"line_number":128,"context_line":"                    request_body[\u0027vnfLcmOpOccId\u0027])},"},{"line_number":129,"context_line":"            \"vnfInstance\": {"},{"line_number":130,"context_line":"                \"href\": os.path.join("},{"line_number":131,"context_line":"                    \u0027http://localhost:9890/vnflcm/v1/vnf_instances\u0027,"},{"line_number":132,"context_line":"                    request_body[\u0027vnfInstanceId\u0027])}}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        return res"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @staticmethod"},{"line_number":137,"context_line":"    def _convert_body_to_dict(body):"},{"line_number":138,"context_line":"        if isinstance(body, str):"},{"line_number":139,"context_line":"            return jsonutils.loads(body)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        return body"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @staticmethod"},{"line_number":144,"context_line":"    def make_inst_response_body(request_body, tenant_id, image_id):"},{"line_number":145,"context_line":"        request_body \u003d Grant._convert_body_to_dict(request_body)"},{"line_number":146,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":147,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":148,"context_line":"        res[\"zones\"] \u003d Grant.ZONES"},{"line_number":149,"context_line":"        res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":150,"context_line":"            request_body[\u0027addResources\u0027])"},{"line_number":151,"context_line":"        res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":152,"context_line":"            image_id)"},{"line_number":153,"context_line":"        res[\"additionalParams\"] \u003d Grant.ADDITIONAL_PARAMS"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        return res"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @staticmethod"},{"line_number":158,"context_line":"    def make_heal_response_body(request_body, tenant_id, image_id):"},{"line_number":159,"context_line":"        request_body \u003d Grant._convert_body_to_dict(request_body)"},{"line_number":160,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":161,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":162,"context_line":"        res[\"zones\"] \u003d Grant.ZONES"},{"line_number":163,"context_line":"        res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":164,"context_line":"            request_body[\u0027addResources\u0027])"},{"line_number":165,"context_line":"        res[\"removeResources\"] \u003d Grant._make_remove_resources("},{"line_number":166,"context_line":"            request_body[\u0027removeResources\u0027])"},{"line_number":167,"context_line":"        res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":168,"context_line":"            image_id)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        return res"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @staticmethod"},{"line_number":173,"context_line":"    def make_scaleout_response_body(request_body, tenant_id, image_id):"},{"line_number":174,"context_line":"        request_body \u003d Grant._convert_body_to_dict(request_body)"},{"line_number":175,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":176,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":177,"context_line":"        res[\"zones\"] \u003d Grant.ZONES"},{"line_number":178,"context_line":"        res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":179,"context_line":"            request_body[\u0027addResources\u0027])"},{"line_number":180,"context_line":"        res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":181,"context_line":"            image_id)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        return res"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @staticmethod"},{"line_number":186,"context_line":"    def make_scalein_response_body(request_body):"},{"line_number":187,"context_line":"        request_body \u003d Grant._convert_body_to_dict(request_body)"},{"line_number":188,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":189,"context_line":"        res[\"removeResources\"] \u003d Grant._make_remove_resources("},{"line_number":190,"context_line":"            request_body[\u0027removeResources\u0027])"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        return res"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    @staticmethod"},{"line_number":195,"context_line":"    def make_term_response_body(request_body):"},{"line_number":196,"context_line":"        request_body \u003d Grant._convert_body_to_dict(request_body)"},{"line_number":197,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":198,"context_line":"        res[\"removeResources\"] \u003d Grant._make_remove_resources("},{"line_number":199,"context_line":"            request_body[\u0027removeResources\u0027])"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        return res"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"class Subscription:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_18e6984b","line":201,"range":{"start_line":19,"start_character":0,"end_line":201,"end_character":18},"updated":"2020-10-06 02:47:49.000000000","message":"Since this file is related to vnflcm, it\u0027s better to create a new \u0027fake_grant.py\u0027 to define the class definition related to \u0027grant\u0027.","commit_id":"bc44f28a42ba1172f2f8756271adddea9881e603"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"a07a311ca089606503938e3ecb28ded158569031","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class Grant:"},{"line_number":20,"context_line":"    GRANT_REQ_PATH \u003d \u0027/grant/v1/grants\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    ZONES \u003d ["},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"id\": uuidsentinel.zone_id,"},{"line_number":25,"context_line":"            \"zoneId\": \"nova\","},{"line_number":26,"context_line":"            \"vimConnectionId\": uuidsentinel.vim_connection_id"},{"line_number":27,"context_line":"        }"},{"line_number":28,"context_line":"    ]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    ADDITIONAL_PARAMS \u003d {"},{"line_number":31,"context_line":"        \"key\": \"value\""},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @staticmethod"},{"line_number":35,"context_line":"    def _make_vim_connection_info(tenant_id):"},{"line_number":36,"context_line":"        access_info \u003d {"},{"line_number":37,"context_line":"            \"username\": \"nfv_user\","},{"line_number":38,"context_line":"            \"region\": \"RegionOne\","},{"line_number":39,"context_line":"            \"password\": \"devstack\","},{"line_number":40,"context_line":"            \"tenant\": tenant_id"},{"line_number":41,"context_line":"        }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        return [{"},{"line_number":44,"context_line":"            \"id\": uuidsentinel.vim_connection_id,"},{"line_number":45,"context_line":"            \"vimType\": \"ETSINFV.OPENSTACK_KEYSTONE.v_2\","},{"line_number":46,"context_line":"            \"interfaceInfo\": {"},{"line_number":47,"context_line":"                \"endpoint\": \"http://127.0.0.1/identity\""},{"line_number":48,"context_line":"            },"},{"line_number":49,"context_line":"            \"accessInfo\": access_info"},{"line_number":50,"context_line":"        }]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @staticmethod"},{"line_number":53,"context_line":"    def _make_add_resources(req_add_resources):"},{"line_number":54,"context_line":"        add_resources \u003d []"},{"line_number":55,"context_line":"        for req_add_resource in req_add_resources:"},{"line_number":56,"context_line":"            res_add_resource \u003d {"},{"line_number":57,"context_line":"                \"resourceDefinitionId\": req_add_resource[\u0027id\u0027],"},{"line_number":58,"context_line":"                \"vimConnectionId\": uuidsentinel.vim_connection_id"},{"line_number":59,"context_line":"            }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"            if req_add_resource[\u0027type\u0027] \u003d\u003d \u0027COMPUTE\u0027:"},{"line_number":62,"context_line":"                res_add_resource[\"zoneId\"] \u003d uuidsentinel.zone_id"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"            add_resources.append(res_add_resource)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return add_resources"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @staticmethod"},{"line_number":69,"context_line":"    def _make_remove_resources(req_remove_resources):"},{"line_number":70,"context_line":"        res_remove_resources \u003d []"},{"line_number":71,"context_line":"        for req_remove_resource in req_remove_resources:"},{"line_number":72,"context_line":"            res_remove_resource \u003d {"},{"line_number":73,"context_line":"                \"resourceDefinitionId\": req_remove_resource[\u0027id\u0027]"},{"line_number":74,"context_line":"            }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"            res_remove_resources.append(res_remove_resource)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return res_remove_resources"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @staticmethod"},{"line_number":81,"context_line":"    def _make_vim_assets(image_id, flavour_id\u003d\"1\"):"},{"line_number":82,"context_line":"        # set m1.tiny\u003d\"1\" for flavour_id"},{"line_number":83,"context_line":"        vim_assets \u003d {"},{"line_number":84,"context_line":"            \"computeResourceFlavours\": ["},{"line_number":85,"context_line":"                {"},{"line_number":86,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":87,"context_line":"                    \"vnfdVirtualComputeDescId\": \"VDU1\","},{"line_number":88,"context_line":"                    \"vimFlavourId\": flavour_id"},{"line_number":89,"context_line":"                },"},{"line_number":90,"context_line":"                {"},{"line_number":91,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":92,"context_line":"                    \"vnfdVirtualComputeDescId\": \"VDU2\","},{"line_number":93,"context_line":"                    \"vimFlavourId\": flavour_id"},{"line_number":94,"context_line":"                }"},{"line_number":95,"context_line":"            ],"},{"line_number":96,"context_line":"            \"softwareImages\": ["},{"line_number":97,"context_line":"                {"},{"line_number":98,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":99,"context_line":"                    \"vnfdSoftwareImageId\": \"cirros-0.4.0-x86_64-disk\","},{"line_number":100,"context_line":"                    \"vimSoftwareImageId\": image_id"},{"line_number":101,"context_line":"                },"},{"line_number":102,"context_line":"                {"},{"line_number":103,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":104,"context_line":"                    \"vnfdSoftwareImageId\": \"VirtualStorage\","},{"line_number":105,"context_line":"                    \"vimSoftwareImageId\": image_id"},{"line_number":106,"context_line":"                }"},{"line_number":107,"context_line":"            ]"},{"line_number":108,"context_line":"        }"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        return vim_assets"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @staticmethod"},{"line_number":113,"context_line":"    def _make_response_template(request_body):"},{"line_number":114,"context_line":"        res \u003d {"},{"line_number":115,"context_line":"            \"id\": uuidsentinel.__getattr__(request_body[\u0027vnfLcmOpOccId\u0027]),"},{"line_number":116,"context_line":"            \"vnfInstanceId\": request_body[\u0027vnfInstanceId\u0027],"},{"line_number":117,"context_line":"            \"vnfLcmOpOccId\": request_body[\u0027vnfLcmOpOccId\u0027],"},{"line_number":118,"context_line":"        }"},{"line_number":119,"context_line":"        res[\"_links\"] \u003d {"},{"line_number":120,"context_line":"            \"self\": {"},{"line_number":121,"context_line":"                # set fake server port."},{"line_number":122,"context_line":"                \"href\": os.path.join("},{"line_number":123,"context_line":"                    \u0027http://localhost:9990\u0027,"},{"line_number":124,"context_line":"                    Grant.GRANT_REQ_PATH)},"},{"line_number":125,"context_line":"            \"vnfLcmOpOcc\": {"},{"line_number":126,"context_line":"                \"href\": os.path.join("},{"line_number":127,"context_line":"                    \u0027http://localhost:9890/vnflcm/v1/vnf_lcm_op_occs\u0027,"},{"line_number":128,"context_line":"                    request_body[\u0027vnfLcmOpOccId\u0027])},"},{"line_number":129,"context_line":"            \"vnfInstance\": {"},{"line_number":130,"context_line":"                \"href\": os.path.join("},{"line_number":131,"context_line":"                    \u0027http://localhost:9890/vnflcm/v1/vnf_instances\u0027,"},{"line_number":132,"context_line":"                    request_body[\u0027vnfInstanceId\u0027])}}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        return res"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @staticmethod"},{"line_number":137,"context_line":"    def _convert_body_to_dict(body):"},{"line_number":138,"context_line":"        if isinstance(body, str):"},{"line_number":139,"context_line":"            return jsonutils.loads(body)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        return body"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @staticmethod"},{"line_number":144,"context_line":"    def make_inst_response_body(request_body, tenant_id, image_id):"},{"line_number":145,"context_line":"        request_body \u003d Grant._convert_body_to_dict(request_body)"},{"line_number":146,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":147,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":148,"context_line":"        res[\"zones\"] \u003d Grant.ZONES"},{"line_number":149,"context_line":"        res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":150,"context_line":"            request_body[\u0027addResources\u0027])"},{"line_number":151,"context_line":"        res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":152,"context_line":"            image_id)"},{"line_number":153,"context_line":"        res[\"additionalParams\"] \u003d Grant.ADDITIONAL_PARAMS"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        return res"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @staticmethod"},{"line_number":158,"context_line":"    def make_heal_response_body(request_body, tenant_id, image_id):"},{"line_number":159,"context_line":"        request_body \u003d Grant._convert_body_to_dict(request_body)"},{"line_number":160,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":161,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":162,"context_line":"        res[\"zones\"] \u003d Grant.ZONES"},{"line_number":163,"context_line":"        res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":164,"context_line":"            request_body[\u0027addResources\u0027])"},{"line_number":165,"context_line":"        res[\"removeResources\"] \u003d Grant._make_remove_resources("},{"line_number":166,"context_line":"            request_body[\u0027removeResources\u0027])"},{"line_number":167,"context_line":"        res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":168,"context_line":"            image_id)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        return res"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @staticmethod"},{"line_number":173,"context_line":"    def make_scaleout_response_body(request_body, tenant_id, image_id):"},{"line_number":174,"context_line":"        request_body \u003d Grant._convert_body_to_dict(request_body)"},{"line_number":175,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":176,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":177,"context_line":"        res[\"zones\"] \u003d Grant.ZONES"},{"line_number":178,"context_line":"        res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":179,"context_line":"            request_body[\u0027addResources\u0027])"},{"line_number":180,"context_line":"        res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":181,"context_line":"            image_id)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        return res"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @staticmethod"},{"line_number":186,"context_line":"    def make_scalein_response_body(request_body):"},{"line_number":187,"context_line":"        request_body \u003d Grant._convert_body_to_dict(request_body)"},{"line_number":188,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":189,"context_line":"        res[\"removeResources\"] \u003d Grant._make_remove_resources("},{"line_number":190,"context_line":"            request_body[\u0027removeResources\u0027])"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        return res"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    @staticmethod"},{"line_number":195,"context_line":"    def make_term_response_body(request_body):"},{"line_number":196,"context_line":"        request_body \u003d Grant._convert_body_to_dict(request_body)"},{"line_number":197,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":198,"context_line":"        res[\"removeResources\"] \u003d Grant._make_remove_resources("},{"line_number":199,"context_line":"            request_body[\u0027removeResources\u0027])"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        return res"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"class Subscription:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_dcec0b94","line":201,"range":{"start_line":19,"start_character":0,"end_line":201,"end_character":18},"in_reply_to":"9f560f44_18e6984b","updated":"2020-10-06 14:33:24.000000000","message":"Since it is used in VNF LCM, I think that there is no problem by defining it in fake_vnflcm.py and not separating it in a new file.","commit_id":"bc44f28a42ba1172f2f8756271adddea9881e603"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"41366cef0c9423ffb4ac94a178e8917671c45330","unresolved":false,"context_lines":[{"line_number":428,"context_line":"class VnfPackage:"},{"line_number":429,"context_line":"    VNF_PACKAGE_REQ_PATH \u003d \"/vnfpkgm/v1/vnf_packages\""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    # @staticmethod"},{"line_number":432,"context_line":"    # def make_list_response(file):"},{"line_number":433,"context_line":"    #     return file_path"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    @staticmethod"},{"line_number":436,"context_line":"    def make_list_response_body():"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_ddeff283","line":433,"range":{"start_line":431,"start_character":0,"end_line":433,"end_character":26},"updated":"2020-10-06 02:47:49.000000000","message":"I think it is an unnecessary comment out, so please delete it.","commit_id":"bc44f28a42ba1172f2f8756271adddea9881e603"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"a07a311ca089606503938e3ecb28ded158569031","unresolved":false,"context_lines":[{"line_number":428,"context_line":"class VnfPackage:"},{"line_number":429,"context_line":"    VNF_PACKAGE_REQ_PATH \u003d \"/vnfpkgm/v1/vnf_packages\""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    # @staticmethod"},{"line_number":432,"context_line":"    # def make_list_response(file):"},{"line_number":433,"context_line":"    #     return file_path"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    @staticmethod"},{"line_number":436,"context_line":"    def make_list_response_body():"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_fce90f7f","line":433,"range":{"start_line":431,"start_character":0,"end_line":433,"end_character":26},"in_reply_to":"9f560f44_ddeff283","updated":"2020-10-06 14:33:24.000000000","message":"It is deleted","commit_id":"bc44f28a42ba1172f2f8756271adddea9881e603"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"41366cef0c9423ffb4ac94a178e8917671c45330","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        }"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"class VnfPackage:"},{"line_number":429,"context_line":"    VNF_PACKAGE_REQ_PATH \u003d \"/vnfpkgm/v1/vnf_packages\""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    # @staticmethod"},{"line_number":432,"context_line":"    # def make_list_response(file):"},{"line_number":433,"context_line":"    #     return file_path"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    @staticmethod"},{"line_number":436,"context_line":"    def make_list_response_body():"},{"line_number":437,"context_line":"        return [VnfPackage.make_individual_response]"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    @staticmethod"},{"line_number":440,"context_line":"    def make_individual_response_body(vnfd_id, vnf_package_hash):"},{"line_number":441,"context_line":"        add_artifact_hash \u003d ("},{"line_number":442,"context_line":"            \"6513f21e44aa3da349f248188a44\" +"},{"line_number":443,"context_line":"            \"bc304a3653a04122d8fb4535423c8\" +"},{"line_number":444,"context_line":"            \"e1d14cd6a153f735bb0982e2\" +"},{"line_number":445,"context_line":"            \"161b5b5186106570c17a9\" +"},{"line_number":446,"context_line":"            \"e58b64dd39390617cd5a350f78\")"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        sw_image_hash \u003d ("},{"line_number":449,"context_line":"            \"6513f21e44aa3da349\" +"},{"line_number":450,"context_line":"            \"f248188a44bc304a3653a04\" +"},{"line_number":451,"context_line":"            \"122d8fb4535423c8e1d14c\" +"},{"line_number":452,"context_line":"            \"d6a153f735bb0982e2161b5\" +"},{"line_number":453,"context_line":"            \"b5186106570c17a9e58b6\" +"},{"line_number":454,"context_line":"            \"4dd39390617cd5a350f78\")"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        data \u003d {"},{"line_number":457,"context_line":"            \"id\": uuidutils.generate_uuid(),"},{"line_number":458,"context_line":"            \"vnfdId\": vnfd_id,"},{"line_number":459,"context_line":"            \"vnfProvider\": \"Company\","},{"line_number":460,"context_line":"            \"vnfProductName\": \"Sample VNF\","},{"line_number":461,"context_line":"            \"vnfSoftwareVersion\": \"1.0\","},{"line_number":462,"context_line":"            \"vnfdVersion\": \"1.0\","},{"line_number":463,"context_line":"            \"checksum\": {"},{"line_number":464,"context_line":"                \"algorithm\": \"SHA-512\","},{"line_number":465,"context_line":"                \"hash\": vnf_package_hash"},{"line_number":466,"context_line":"            },"},{"line_number":467,"context_line":"            \"softwareImages\": ["},{"line_number":468,"context_line":"                {"},{"line_number":469,"context_line":"                    \"id\": \"sw_image\","},{"line_number":470,"context_line":"                    \"name\": \"cirros-0.4.0-x86_64-disk\","},{"line_number":471,"context_line":"                    \"provider\": \"Company\","},{"line_number":472,"context_line":"                    \"version\": \"0.4.0\","},{"line_number":473,"context_line":"                    \"checksum\": {"},{"line_number":474,"context_line":"                        \"algorithm\": \"SHA-512\","},{"line_number":475,"context_line":"                        \"hash\": sw_image_hash"},{"line_number":476,"context_line":"                    },"},{"line_number":477,"context_line":"                    \"containerFormat\": \"BARE\","},{"line_number":478,"context_line":"                    \"diskFormat\": \"QCOW2\","},{"line_number":479,"context_line":"                    \"createdAt\": \"2020-09-01T12:34:56Z\","},{"line_number":480,"context_line":"                    \"minDisk\": \"2147483648\","},{"line_number":481,"context_line":"                    \"minRam\": \"268435456\","},{"line_number":482,"context_line":"                    \"size\": \"1073741824\","},{"line_number":483,"context_line":"                    \"userMetadata\": {"},{"line_number":484,"context_line":"                        \"key\": \"value\""},{"line_number":485,"context_line":"                    },"},{"line_number":486,"context_line":"                    \"imagePath\": \"Files/images/cirros-0.4.0-x86_64-disk.img\""},{"line_number":487,"context_line":"                }"},{"line_number":488,"context_line":"            ],"},{"line_number":489,"context_line":"            \"additionalArtifacts\": ["},{"line_number":490,"context_line":"                {"},{"line_number":491,"context_line":"                    \"artifactPath\":"},{"line_number":492,"context_line":"                        \"Files/images/cirros-0.4.0-x86_64-disk.img\","},{"line_number":493,"context_line":"                    \"checksum\": {"},{"line_number":494,"context_line":"                        \"algorithm\": \"SHA-512\","},{"line_number":495,"context_line":"                        \"hash\": add_artifact_hash"},{"line_number":496,"context_line":"                    },"},{"line_number":497,"context_line":"                    \"metadata\": {"},{"line_number":498,"context_line":"                        \"key\": \"value\""},{"line_number":499,"context_line":"                    }"},{"line_number":500,"context_line":"                }"},{"line_number":501,"context_line":"            ],"},{"line_number":502,"context_line":"            \"onboardingState\": \"ONBOARDED\","},{"line_number":503,"context_line":"            \"operationalState\": \"ENABLED\","},{"line_number":504,"context_line":"            \"usageState\": \"NOT_IN_USE\","},{"line_number":505,"context_line":"            \"userDefinedData\": {"},{"line_number":506,"context_line":"                \"key\": \"value\""},{"line_number":507,"context_line":"            },"},{"line_number":508,"context_line":"            \"_links\": {"},{"line_number":509,"context_line":"                \"self\": {"},{"line_number":510,"context_line":"                    \"href\": \"GetPackageのURI\""},{"line_number":511,"context_line":"                },"},{"line_number":512,"context_line":"                \"vnfd\": {"},{"line_number":513,"context_line":"                    \"href\": \"GetVNFDのURI\""},{"line_number":514,"context_line":"                },"},{"line_number":515,"context_line":"                \"packageContent\": {"},{"line_number":516,"context_line":"                    \"href\": \"GetPackageContentのURI\""},{"line_number":517,"context_line":"                }"},{"line_number":518,"context_line":"            }"},{"line_number":519,"context_line":"        }"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_58f010fe","line":521,"range":{"start_line":428,"start_character":0,"end_line":521,"end_character":19},"updated":"2020-10-06 02:47:49.000000000","message":"Since this file is related to vnflcm, it\u0027s better to create a new \u0027fake_vnfpkgm.py\u0027 to define the class definition related to \u0027vnfpkgm\u0027.","commit_id":"bc44f28a42ba1172f2f8756271adddea9881e603"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"a07a311ca089606503938e3ecb28ded158569031","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        }"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"class VnfPackage:"},{"line_number":429,"context_line":"    VNF_PACKAGE_REQ_PATH \u003d \"/vnfpkgm/v1/vnf_packages\""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    # @staticmethod"},{"line_number":432,"context_line":"    # def make_list_response(file):"},{"line_number":433,"context_line":"    #     return file_path"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    @staticmethod"},{"line_number":436,"context_line":"    def make_list_response_body():"},{"line_number":437,"context_line":"        return [VnfPackage.make_individual_response]"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    @staticmethod"},{"line_number":440,"context_line":"    def make_individual_response_body(vnfd_id, vnf_package_hash):"},{"line_number":441,"context_line":"        add_artifact_hash \u003d ("},{"line_number":442,"context_line":"            \"6513f21e44aa3da349f248188a44\" +"},{"line_number":443,"context_line":"            \"bc304a3653a04122d8fb4535423c8\" +"},{"line_number":444,"context_line":"            \"e1d14cd6a153f735bb0982e2\" +"},{"line_number":445,"context_line":"            \"161b5b5186106570c17a9\" +"},{"line_number":446,"context_line":"            \"e58b64dd39390617cd5a350f78\")"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        sw_image_hash \u003d ("},{"line_number":449,"context_line":"            \"6513f21e44aa3da349\" +"},{"line_number":450,"context_line":"            \"f248188a44bc304a3653a04\" +"},{"line_number":451,"context_line":"            \"122d8fb4535423c8e1d14c\" +"},{"line_number":452,"context_line":"            \"d6a153f735bb0982e2161b5\" +"},{"line_number":453,"context_line":"            \"b5186106570c17a9e58b6\" +"},{"line_number":454,"context_line":"            \"4dd39390617cd5a350f78\")"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        data \u003d {"},{"line_number":457,"context_line":"            \"id\": uuidutils.generate_uuid(),"},{"line_number":458,"context_line":"            \"vnfdId\": vnfd_id,"},{"line_number":459,"context_line":"            \"vnfProvider\": \"Company\","},{"line_number":460,"context_line":"            \"vnfProductName\": \"Sample VNF\","},{"line_number":461,"context_line":"            \"vnfSoftwareVersion\": \"1.0\","},{"line_number":462,"context_line":"            \"vnfdVersion\": \"1.0\","},{"line_number":463,"context_line":"            \"checksum\": {"},{"line_number":464,"context_line":"                \"algorithm\": \"SHA-512\","},{"line_number":465,"context_line":"                \"hash\": vnf_package_hash"},{"line_number":466,"context_line":"            },"},{"line_number":467,"context_line":"            \"softwareImages\": ["},{"line_number":468,"context_line":"                {"},{"line_number":469,"context_line":"                    \"id\": \"sw_image\","},{"line_number":470,"context_line":"                    \"name\": \"cirros-0.4.0-x86_64-disk\","},{"line_number":471,"context_line":"                    \"provider\": \"Company\","},{"line_number":472,"context_line":"                    \"version\": \"0.4.0\","},{"line_number":473,"context_line":"                    \"checksum\": {"},{"line_number":474,"context_line":"                        \"algorithm\": \"SHA-512\","},{"line_number":475,"context_line":"                        \"hash\": sw_image_hash"},{"line_number":476,"context_line":"                    },"},{"line_number":477,"context_line":"                    \"containerFormat\": \"BARE\","},{"line_number":478,"context_line":"                    \"diskFormat\": \"QCOW2\","},{"line_number":479,"context_line":"                    \"createdAt\": \"2020-09-01T12:34:56Z\","},{"line_number":480,"context_line":"                    \"minDisk\": \"2147483648\","},{"line_number":481,"context_line":"                    \"minRam\": \"268435456\","},{"line_number":482,"context_line":"                    \"size\": \"1073741824\","},{"line_number":483,"context_line":"                    \"userMetadata\": {"},{"line_number":484,"context_line":"                        \"key\": \"value\""},{"line_number":485,"context_line":"                    },"},{"line_number":486,"context_line":"                    \"imagePath\": \"Files/images/cirros-0.4.0-x86_64-disk.img\""},{"line_number":487,"context_line":"                }"},{"line_number":488,"context_line":"            ],"},{"line_number":489,"context_line":"            \"additionalArtifacts\": ["},{"line_number":490,"context_line":"                {"},{"line_number":491,"context_line":"                    \"artifactPath\":"},{"line_number":492,"context_line":"                        \"Files/images/cirros-0.4.0-x86_64-disk.img\","},{"line_number":493,"context_line":"                    \"checksum\": {"},{"line_number":494,"context_line":"                        \"algorithm\": \"SHA-512\","},{"line_number":495,"context_line":"                        \"hash\": add_artifact_hash"},{"line_number":496,"context_line":"                    },"},{"line_number":497,"context_line":"                    \"metadata\": {"},{"line_number":498,"context_line":"                        \"key\": \"value\""},{"line_number":499,"context_line":"                    }"},{"line_number":500,"context_line":"                }"},{"line_number":501,"context_line":"            ],"},{"line_number":502,"context_line":"            \"onboardingState\": \"ONBOARDED\","},{"line_number":503,"context_line":"            \"operationalState\": \"ENABLED\","},{"line_number":504,"context_line":"            \"usageState\": \"NOT_IN_USE\","},{"line_number":505,"context_line":"            \"userDefinedData\": {"},{"line_number":506,"context_line":"                \"key\": \"value\""},{"line_number":507,"context_line":"            },"},{"line_number":508,"context_line":"            \"_links\": {"},{"line_number":509,"context_line":"                \"self\": {"},{"line_number":510,"context_line":"                    \"href\": \"GetPackageのURI\""},{"line_number":511,"context_line":"                },"},{"line_number":512,"context_line":"                \"vnfd\": {"},{"line_number":513,"context_line":"                    \"href\": \"GetVNFDのURI\""},{"line_number":514,"context_line":"                },"},{"line_number":515,"context_line":"                \"packageContent\": {"},{"line_number":516,"context_line":"                    \"href\": \"GetPackageContentのURI\""},{"line_number":517,"context_line":"                }"},{"line_number":518,"context_line":"            }"},{"line_number":519,"context_line":"        }"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_fc9e2f04","line":521,"range":{"start_line":428,"start_character":0,"end_line":521,"end_character":19},"in_reply_to":"9f560f44_58f010fe","updated":"2020-10-06 14:33:24.000000000","message":"Since it is used in VNF LCM, I think that there is no problem by defining it in fake_vnflcm.py and not separating it in a new file.","commit_id":"bc44f28a42ba1172f2f8756271adddea9881e603"}],"tacker/tests/functional/vnflcm/test_vnf_instance_with_user_data.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"db579322801c461ba2bdff1fdf3ddcfac5043437","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        \"\"\"Test basic life cycle operations with sample VNFD."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        In this test case, we do following steps."},{"line_number":65,"context_line":"            - Create subscription."},{"line_number":66,"context_line":"            - Register subscription."},{"line_number":67,"context_line":"            - Create VNF package."},{"line_number":68,"context_line":"            - Upload VNF package."},{"line_number":69,"context_line":"            - Create VNF instance."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_48486b5b","line":66,"range":{"start_line":65,"start_character":14,"end_line":66,"end_character":36},"updated":"2020-09-17 05:05:46.000000000","message":"Since \u0027Create\u0027 and \u0027Register\u0027 are single API operations, I think it\u0027s better to remove\u0027Register subscription\u0027.","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"929988d858c6de519d15e86ce8ebb1bbff7c1fc7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        \"\"\"Test basic life cycle operations with sample VNFD."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        In this test case, we do following steps."},{"line_number":65,"context_line":"            - Create subscription."},{"line_number":66,"context_line":"            - Register subscription."},{"line_number":67,"context_line":"            - Create VNF package."},{"line_number":68,"context_line":"            - Upload VNF package."},{"line_number":69,"context_line":"            - Create VNF instance."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_1c0a5578","line":66,"range":{"start_line":65,"start_character":14,"end_line":66,"end_character":36},"in_reply_to":"9f560f44_48486b5b","updated":"2020-09-30 10:58:11.000000000","message":"It is fixed.","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"db579322801c461ba2bdff1fdf3ddcfac5043437","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            - Scale-In VNF"},{"line_number":74,"context_line":"            - Terminate VNF"},{"line_number":75,"context_line":"            - Delete VNF"},{"line_number":76,"context_line":"            - Unregister subscription"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        # Create subscription and register it."},{"line_number":79,"context_line":"        request_body \u003d fake_vnflcm.Subscription.make_create_request_body("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a822e7a1","line":76,"range":{"start_line":76,"start_character":14,"end_line":76,"end_character":37},"updated":"2020-09-17 05:05:46.000000000","message":"I think \u0027Delete subscription\u0027 is better.","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"929988d858c6de519d15e86ce8ebb1bbff7c1fc7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            - Scale-In VNF"},{"line_number":74,"context_line":"            - Terminate VNF"},{"line_number":75,"context_line":"            - Delete VNF"},{"line_number":76,"context_line":"            - Unregister subscription"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        # Create subscription and register it."},{"line_number":79,"context_line":"        request_body \u003d fake_vnflcm.Subscription.make_create_request_body("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_7c1a71c6","line":76,"range":{"start_line":76,"start_character":14,"end_line":76,"end_character":37},"in_reply_to":"9f560f44_a822e7a1","updated":"2020-09-30 10:58:11.000000000","message":"It is fixed.","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1fef5d90fc862a6901a7dbed62d310b6ec59bf29","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        resp, vnf_instance \u003d self._show_vnf_instance(vnf_instance_id)"},{"line_number":130,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Scale-out vnf instance"},{"line_number":133,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances.make_scale_request_body("},{"line_number":134,"context_line":"            \u0027SCALE_OUT\u0027)"},{"line_number":135,"context_line":"        resp, _ \u003d self._scale_vnf_instance(vnf_instance_id, request_body)"},{"line_number":136,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027)"},{"line_number":137,"context_line":"        self.assert_scale_vnf(resp, vnf_instance_id, vnf_package_id)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Scale-in vnf instance"},{"line_number":140,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances.make_scale_request_body("},{"line_number":141,"context_line":"            \u0027SCALE_IN\u0027)"},{"line_number":142,"context_line":"        resp, _ \u003d self._scale_vnf_instance(vnf_instance_id, request_body)"},{"line_number":143,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027)"},{"line_number":144,"context_line":"        self.assert_scale_vnf(resp, vnf_instance_id, vnf_package_id)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Terminate VNF"},{"line_number":147,"context_line":"        stack \u003d self._get_heat_stack(vnf_instance_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_141faa09","line":144,"range":{"start_line":132,"start_character":8,"end_line":144,"end_character":68},"updated":"2020-09-17 08:59:41.000000000","message":"In order to confirm whether Scale-out / Scale-in is successful from the viewpoint of Heat, it is better to add a process to assert that the number of child-stacks increases or decreases.","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"929988d858c6de519d15e86ce8ebb1bbff7c1fc7","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        resp, vnf_instance \u003d self._show_vnf_instance(vnf_instance_id)"},{"line_number":130,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Scale-out vnf instance"},{"line_number":133,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances.make_scale_request_body("},{"line_number":134,"context_line":"            \u0027SCALE_OUT\u0027)"},{"line_number":135,"context_line":"        resp, _ \u003d self._scale_vnf_instance(vnf_instance_id, request_body)"},{"line_number":136,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027)"},{"line_number":137,"context_line":"        self.assert_scale_vnf(resp, vnf_instance_id, vnf_package_id)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Scale-in vnf instance"},{"line_number":140,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances.make_scale_request_body("},{"line_number":141,"context_line":"            \u0027SCALE_IN\u0027)"},{"line_number":142,"context_line":"        resp, _ \u003d self._scale_vnf_instance(vnf_instance_id, request_body)"},{"line_number":143,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027)"},{"line_number":144,"context_line":"        self.assert_scale_vnf(resp, vnf_instance_id, vnf_package_id)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Terminate VNF"},{"line_number":147,"context_line":"        stack \u003d self._get_heat_stack(vnf_instance_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c7e92a1a","line":144,"range":{"start_line":132,"start_character":8,"end_line":144,"end_character":68},"in_reply_to":"9f560f44_141faa09","updated":"2020-09-30 10:58:11.000000000","message":"Process to check the number of child-stacks is added in def assert_scale_vnf() in tests/functional/vnflcm/base.py","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"db579322801c461ba2bdff1fdf3ddcfac5043437","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        \"\"\"Test rollback operation for instantiation."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        In this test case, we do following steps."},{"line_number":178,"context_line":"            - Create subscription."},{"line_number":179,"context_line":"            - Register subscription."},{"line_number":180,"context_line":"            - Create VNF package."},{"line_number":181,"context_line":"            - Upload VNF package."},{"line_number":182,"context_line":"            - Create VNF instance."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_68760fa6","line":179,"range":{"start_line":178,"start_character":14,"end_line":179,"end_character":36},"updated":"2020-09-17 05:05:46.000000000","message":"ditto","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"929988d858c6de519d15e86ce8ebb1bbff7c1fc7","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        \"\"\"Test rollback operation for instantiation."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        In this test case, we do following steps."},{"line_number":178,"context_line":"            - Create subscription."},{"line_number":179,"context_line":"            - Register subscription."},{"line_number":180,"context_line":"            - Create VNF package."},{"line_number":181,"context_line":"            - Upload VNF package."},{"line_number":182,"context_line":"            - Create VNF instance."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_9c2ae58e","line":179,"range":{"start_line":178,"start_character":14,"end_line":179,"end_character":36},"in_reply_to":"9f560f44_68760fa6","updated":"2020-09-30 10:58:11.000000000","message":"same as above.","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"db579322801c461ba2bdff1fdf3ddcfac5043437","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            - Get vnflcmOpOccId to rollback."},{"line_number":185,"context_line":"            - Rollback instantiation opration."},{"line_number":186,"context_line":"            - Get opOccs information."},{"line_number":187,"context_line":"            - Unregister subscription."},{"line_number":188,"context_line":"        \"\"\""},{"line_number":189,"context_line":"        # Create subscription and register it."},{"line_number":190,"context_line":"        request_body \u003d fake_vnflcm.Subscription.make_create_request_body("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c86d9bcd","line":187,"range":{"start_line":187,"start_character":14,"end_line":187,"end_character":38},"updated":"2020-09-17 05:05:46.000000000","message":"ditto","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"929988d858c6de519d15e86ce8ebb1bbff7c1fc7","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            - Get vnflcmOpOccId to rollback."},{"line_number":185,"context_line":"            - Rollback instantiation opration."},{"line_number":186,"context_line":"            - Get opOccs information."},{"line_number":187,"context_line":"            - Unregister subscription."},{"line_number":188,"context_line":"        \"\"\""},{"line_number":189,"context_line":"        # Create subscription and register it."},{"line_number":190,"context_line":"        request_body \u003d fake_vnflcm.Subscription.make_create_request_body("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_7c2711c9","line":187,"range":{"start_line":187,"start_character":14,"end_line":187,"end_character":38},"in_reply_to":"9f560f44_c86d9bcd","updated":"2020-09-30 10:58:11.000000000","message":"same as above.","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"db579322801c461ba2bdff1fdf3ddcfac5043437","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        \"\"\"Test rollback operation for Scale-Out operaation."},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        In this test case, we do following steps."},{"line_number":266,"context_line":"            - Create subscription."},{"line_number":267,"context_line":"            - Register subscription."},{"line_number":268,"context_line":"            - Create VNF package."},{"line_number":269,"context_line":"            - Upload VNF package."},{"line_number":270,"context_line":"            - Create VNF instance."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e8617fd6","line":267,"range":{"start_line":266,"start_character":14,"end_line":267,"end_character":36},"updated":"2020-09-17 05:05:46.000000000","message":"ditto","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"929988d858c6de519d15e86ce8ebb1bbff7c1fc7","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        \"\"\"Test rollback operation for Scale-Out operaation."},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        In this test case, we do following steps."},{"line_number":266,"context_line":"            - Create subscription."},{"line_number":267,"context_line":"            - Register subscription."},{"line_number":268,"context_line":"            - Create VNF package."},{"line_number":269,"context_line":"            - Upload VNF package."},{"line_number":270,"context_line":"            - Create VNF instance."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_dc157d4e","line":267,"range":{"start_line":266,"start_character":14,"end_line":267,"end_character":36},"in_reply_to":"9f560f44_e8617fd6","updated":"2020-09-30 10:58:11.000000000","message":"same as above.","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"db579322801c461ba2bdff1fdf3ddcfac5043437","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            - Rollback Scale-Out opration."},{"line_number":275,"context_line":"            - Get opOccs information."},{"line_number":276,"context_line":"            - Terminate VNF."},{"line_number":277,"context_line":"            - Unregister subscription."},{"line_number":278,"context_line":"        \"\"\""},{"line_number":279,"context_line":"        # Create subscription and register it."},{"line_number":280,"context_line":"        request_body \u003d fake_vnflcm.Subscription.make_create_request_body("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_48618bd3","line":277,"range":{"start_line":277,"start_character":14,"end_line":277,"end_character":38},"updated":"2020-09-17 05:05:46.000000000","message":"ditto","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"929988d858c6de519d15e86ce8ebb1bbff7c1fc7","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            - Rollback Scale-Out opration."},{"line_number":275,"context_line":"            - Get opOccs information."},{"line_number":276,"context_line":"            - Terminate VNF."},{"line_number":277,"context_line":"            - Unregister subscription."},{"line_number":278,"context_line":"        \"\"\""},{"line_number":279,"context_line":"        # Create subscription and register it."},{"line_number":280,"context_line":"        request_body \u003d fake_vnflcm.Subscription.make_create_request_body("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_1c109559","line":277,"range":{"start_line":277,"start_character":14,"end_line":277,"end_character":38},"in_reply_to":"9f560f44_48618bd3","updated":"2020-09-30 10:58:11.000000000","message":"same as above.","commit_id":"06ef8af3e692cca0b2d392b6b0fce1f2502f26f6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"56c5efa96c2accaa706e1bec28f96833f72d6a74","unresolved":true,"context_lines":[{"line_number":903,"context_line":"        self.assertIsNotNone(vnflcm_op_occ_id)"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"        # rollback"},{"line_number":906,"context_line":"        resp, _ \u003d self._rollback_op_occs(vnflcm_op_occ_id)"},{"line_number":907,"context_line":"        self._wait_lcm_done(\u0027ROLLED_BACK\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":908,"context_line":"        self.assert_rollback_vnf(resp, vnf_instance_id)"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        # occ-show"},{"line_number":911,"context_line":"        resp, op_occs_info \u003d self._show_op_occs(vnflcm_op_occ_id)"}],"source_content_type":"text/x-python","patch_set":43,"id":"61a08cba_087bf109","line":908,"range":{"start_line":906,"start_character":8,"end_line":908,"end_character":55},"updated":"2020-12-15 04:50:00.000000000","message":"Please add confirmation for ROLLING_BACK.","commit_id":"78ea5c5866fda92f2230d6f26536adf6e22b5d1a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4f6020409cf836cad702ea9e44b57088e3cc3435","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        self.assertIsNotNone(vnflcm_op_occ_id)"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"        # rollback"},{"line_number":906,"context_line":"        resp, _ \u003d self._rollback_op_occs(vnflcm_op_occ_id)"},{"line_number":907,"context_line":"        self._wait_lcm_done(\u0027ROLLED_BACK\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":908,"context_line":"        self.assert_rollback_vnf(resp, vnf_instance_id)"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        # occ-show"},{"line_number":911,"context_line":"        resp, op_occs_info \u003d self._show_op_occs(vnflcm_op_occ_id)"}],"source_content_type":"text/x-python","patch_set":43,"id":"04a7e6ae_44045e5a","line":908,"range":{"start_line":906,"start_character":8,"end_line":908,"end_character":55},"in_reply_to":"169d26b9_c7d2f9a3","updated":"2020-12-22 04:34:37.000000000","message":"I\u0027ve confirmed.","commit_id":"78ea5c5866fda92f2230d6f26536adf6e22b5d1a"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"e143f1e5e84e56e38ab37d226b0d19886d94e0a9","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        self.assertIsNotNone(vnflcm_op_occ_id)"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"        # rollback"},{"line_number":906,"context_line":"        resp, _ \u003d self._rollback_op_occs(vnflcm_op_occ_id)"},{"line_number":907,"context_line":"        self._wait_lcm_done(\u0027ROLLED_BACK\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":908,"context_line":"        self.assert_rollback_vnf(resp, vnf_instance_id)"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        # occ-show"},{"line_number":911,"context_line":"        resp, op_occs_info \u003d self._show_op_occs(vnflcm_op_occ_id)"}],"source_content_type":"text/x-python","patch_set":43,"id":"169d26b9_c7d2f9a3","line":908,"range":{"start_line":906,"start_character":8,"end_line":908,"end_character":55},"in_reply_to":"61a08cba_087bf109","updated":"2020-12-16 09:36:18.000000000","message":"Done","commit_id":"78ea5c5866fda92f2230d6f26536adf6e22b5d1a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"56c5efa96c2accaa706e1bec28f96833f72d6a74","unresolved":true,"context_lines":[{"line_number":921,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"    def test_rollback_scale_out(self):"},{"line_number":924,"context_line":"        \"\"\"Test rollback operation for Scale-Out operaation."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        In this test case, we do following steps."},{"line_number":927,"context_line":"            - Create subscription."}],"source_content_type":"text/x-python","patch_set":43,"id":"3623c9e3_b6fdec3b","line":924,"range":{"start_line":924,"start_character":49,"end_line":924,"end_character":59},"updated":"2020-12-15 04:50:00.000000000","message":"Typo: operation","commit_id":"78ea5c5866fda92f2230d6f26536adf6e22b5d1a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4f6020409cf836cad702ea9e44b57088e3cc3435","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"    def test_rollback_scale_out(self):"},{"line_number":924,"context_line":"        \"\"\"Test rollback operation for Scale-Out operaation."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        In this test case, we do following steps."},{"line_number":927,"context_line":"            - Create subscription."}],"source_content_type":"text/x-python","patch_set":43,"id":"e3580dd6_6354f207","line":924,"range":{"start_line":924,"start_character":49,"end_line":924,"end_character":59},"in_reply_to":"10d19999_022c94f0","updated":"2020-12-22 04:34:37.000000000","message":"I\u0027ve confirmed.","commit_id":"78ea5c5866fda92f2230d6f26536adf6e22b5d1a"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"e143f1e5e84e56e38ab37d226b0d19886d94e0a9","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"    def test_rollback_scale_out(self):"},{"line_number":924,"context_line":"        \"\"\"Test rollback operation for Scale-Out operaation."},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        In this test case, we do following steps."},{"line_number":927,"context_line":"            - Create subscription."}],"source_content_type":"text/x-python","patch_set":43,"id":"10d19999_022c94f0","line":924,"range":{"start_line":924,"start_character":49,"end_line":924,"end_character":59},"in_reply_to":"3623c9e3_b6fdec3b","updated":"2020-12-16 09:36:18.000000000","message":"Fixed together with the other line.","commit_id":"78ea5c5866fda92f2230d6f26536adf6e22b5d1a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"56c5efa96c2accaa706e1bec28f96833f72d6a74","unresolved":true,"context_lines":[{"line_number":1013,"context_line":"        self.assertIsNotNone(vnflcm_op_occ_id)"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"        # rollback"},{"line_number":1016,"context_line":"        resp, _ \u003d self._rollback_op_occs(vnflcm_op_occ_id)"},{"line_number":1017,"context_line":"        self._wait_lcm_done(\u0027ROLLED_BACK\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":1018,"context_line":"        self.assert_rollback_vnf(resp, vnf_instance_id)"},{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"        # occ-show"},{"line_number":1021,"context_line":"        resp, op_occs_info \u003d self._show_op_occs(vnflcm_op_occ_id)"}],"source_content_type":"text/x-python","patch_set":43,"id":"2cdddbd9_e71facc8","line":1018,"range":{"start_line":1016,"start_character":8,"end_line":1018,"end_character":55},"updated":"2020-12-15 04:50:00.000000000","message":"Please add confirmation for ROLLING_BACK.","commit_id":"78ea5c5866fda92f2230d6f26536adf6e22b5d1a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4f6020409cf836cad702ea9e44b57088e3cc3435","unresolved":false,"context_lines":[{"line_number":1013,"context_line":"        self.assertIsNotNone(vnflcm_op_occ_id)"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"        # rollback"},{"line_number":1016,"context_line":"        resp, _ \u003d self._rollback_op_occs(vnflcm_op_occ_id)"},{"line_number":1017,"context_line":"        self._wait_lcm_done(\u0027ROLLED_BACK\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":1018,"context_line":"        self.assert_rollback_vnf(resp, vnf_instance_id)"},{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"        # occ-show"},{"line_number":1021,"context_line":"        resp, op_occs_info \u003d self._show_op_occs(vnflcm_op_occ_id)"}],"source_content_type":"text/x-python","patch_set":43,"id":"986370a9_3af9a15f","line":1018,"range":{"start_line":1016,"start_character":8,"end_line":1018,"end_character":55},"in_reply_to":"05bc213c_3e6b0694","updated":"2020-12-22 04:34:37.000000000","message":"I\u0027ve confirmed.","commit_id":"78ea5c5866fda92f2230d6f26536adf6e22b5d1a"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"e143f1e5e84e56e38ab37d226b0d19886d94e0a9","unresolved":false,"context_lines":[{"line_number":1013,"context_line":"        self.assertIsNotNone(vnflcm_op_occ_id)"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"        # rollback"},{"line_number":1016,"context_line":"        resp, _ \u003d self._rollback_op_occs(vnflcm_op_occ_id)"},{"line_number":1017,"context_line":"        self._wait_lcm_done(\u0027ROLLED_BACK\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":1018,"context_line":"        self.assert_rollback_vnf(resp, vnf_instance_id)"},{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"        # occ-show"},{"line_number":1021,"context_line":"        resp, op_occs_info \u003d self._show_op_occs(vnflcm_op_occ_id)"}],"source_content_type":"text/x-python","patch_set":43,"id":"05bc213c_3e6b0694","line":1018,"range":{"start_line":1016,"start_character":8,"end_line":1018,"end_character":55},"in_reply_to":"2cdddbd9_e71facc8","updated":"2020-12-16 09:36:18.000000000","message":"Done","commit_id":"78ea5c5866fda92f2230d6f26536adf6e22b5d1a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":138,"context_line":"                \"key\": sample_name}, temp_csar_path\u003dtempname)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Post Setting: Reserve deleting vnf package."},{"line_number":141,"context_line":"        self.addCleanup("},{"line_number":142,"context_line":"            vnflcm_base._delete_vnf_package,"},{"line_number":143,"context_line":"            self.tacker_client,"},{"line_number":144,"context_line":"            vnf_package_id)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Create vnf instance"},{"line_number":147,"context_line":"        resp, vnf_instance \u003d self._create_vnf_instance_from_body("}],"source_content_type":"text/x-python","patch_set":47,"id":"6e7433a8_1eb39226","line":144,"range":{"start_line":141,"start_character":0,"end_line":144,"end_character":27},"updated":"2020-12-18 08:37:29.000000000","message":"Why don\u0027t you reduce the number of lines? No need to put each param on each line.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                \"key\": sample_name}, temp_csar_path\u003dtempname)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Post Setting: Reserve deleting vnf package."},{"line_number":141,"context_line":"        self.addCleanup("},{"line_number":142,"context_line":"            vnflcm_base._delete_vnf_package,"},{"line_number":143,"context_line":"            self.tacker_client,"},{"line_number":144,"context_line":"            vnf_package_id)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Create vnf instance"},{"line_number":147,"context_line":"        resp, vnf_instance \u003d self._create_vnf_instance_from_body("}],"source_content_type":"text/x-python","patch_set":47,"id":"2f975631_d009339c","line":144,"range":{"start_line":141,"start_character":0,"end_line":144,"end_character":27},"in_reply_to":"6e7433a8_1eb39226","updated":"2020-12-22 06:21:16.000000000","message":"Fixed together with the other similar lines.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Instantiate vnf instance"},{"line_number":157,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances.make_inst_request_body("},{"line_number":158,"context_line":"            self.vim[\u0027tenant_id\u0027],"},{"line_number":159,"context_line":"            self.ext_networks,"},{"line_number":160,"context_line":"            self.ext_mngd_networks,"},{"line_number":161,"context_line":"            self.ext_link_ports,"},{"line_number":162,"context_line":"            self.ext_subnets)"},{"line_number":163,"context_line":"        resp, _ \u003d self._instantiate_vnf_instance(vnf_instance_id, request_body)"},{"line_number":164,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":165,"context_line":"        self.assert_instantiate_vnf(resp, vnf_instance_id, vnf_package_id)"}],"source_content_type":"text/x-python","patch_set":47,"id":"0002fe49_edf20580","line":162,"range":{"start_line":158,"start_character":0,"end_line":162,"end_character":29},"updated":"2020-12-18 08:37:29.000000000","message":"Why don\u0027t you reduce the number of lines? No need to put each param on each line.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Instantiate vnf instance"},{"line_number":157,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances.make_inst_request_body("},{"line_number":158,"context_line":"            self.vim[\u0027tenant_id\u0027],"},{"line_number":159,"context_line":"            self.ext_networks,"},{"line_number":160,"context_line":"            self.ext_mngd_networks,"},{"line_number":161,"context_line":"            self.ext_link_ports,"},{"line_number":162,"context_line":"            self.ext_subnets)"},{"line_number":163,"context_line":"        resp, _ \u003d self._instantiate_vnf_instance(vnf_instance_id, request_body)"},{"line_number":164,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":165,"context_line":"        self.assert_instantiate_vnf(resp, vnf_instance_id, vnf_package_id)"}],"source_content_type":"text/x-python","patch_set":47,"id":"d790d128_cadcff8c","line":162,"range":{"start_line":158,"start_character":0,"end_line":162,"end_character":29},"in_reply_to":"0002fe49_edf20580","updated":"2020-12-22 06:21:16.000000000","message":"Fixed together with the other similar lines.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        post_stack_resource_list \u003d self._get_heat_resource_list(stack.id, 2)"},{"line_number":181,"context_line":"        self.assert_scale_vnf("},{"line_number":182,"context_line":"            resp,"},{"line_number":183,"context_line":"            vnf_instance_id,"},{"line_number":184,"context_line":"            vnf_package_id,"},{"line_number":185,"context_line":"            pre_stack_resource_list,"},{"line_number":186,"context_line":"            post_stack_resource_list)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # Scale-in vnf instance"},{"line_number":189,"context_line":"        stack \u003d self._get_heat_stack(vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":47,"id":"92adb200_cf9ed26c","line":186,"range":{"start_line":182,"start_character":0,"end_line":186,"end_character":37},"updated":"2020-12-18 08:37:29.000000000","message":"Why don\u0027t you reduce the number of lines? No need to put each param on each line.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        post_stack_resource_list \u003d self._get_heat_resource_list(stack.id, 2)"},{"line_number":181,"context_line":"        self.assert_scale_vnf("},{"line_number":182,"context_line":"            resp,"},{"line_number":183,"context_line":"            vnf_instance_id,"},{"line_number":184,"context_line":"            vnf_package_id,"},{"line_number":185,"context_line":"            pre_stack_resource_list,"},{"line_number":186,"context_line":"            post_stack_resource_list)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # Scale-in vnf instance"},{"line_number":189,"context_line":"        stack \u003d self._get_heat_stack(vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":47,"id":"566771d3_219e8721","line":186,"range":{"start_line":182,"start_character":0,"end_line":186,"end_character":37},"in_reply_to":"92adb200_cf9ed26c","updated":"2020-12-22 06:21:16.000000000","message":"Fixed together with the other similar lines.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        post_stack_resource_list \u003d self._get_heat_resource_list(stack.id, 2)"},{"line_number":198,"context_line":"        self.assert_scale_vnf("},{"line_number":199,"context_line":"            resp,"},{"line_number":200,"context_line":"            vnf_instance_id,"},{"line_number":201,"context_line":"            vnf_package_id,"},{"line_number":202,"context_line":"            pre_stack_resource_list,"},{"line_number":203,"context_line":"            post_stack_resource_list,"},{"line_number":204,"context_line":"            scale_type\u003d\u0027SCALE_IN\u0027)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        # Terminate VNF"},{"line_number":207,"context_line":"        stack \u003d self._get_heat_stack(vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":47,"id":"7de53fc7_9a9cfb8c","line":204,"range":{"start_line":198,"start_character":1,"end_line":204,"end_character":34},"updated":"2020-12-18 08:37:29.000000000","message":"Why don\u0027t you reduce the number of lines? No need to put each param on each line.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        post_stack_resource_list \u003d self._get_heat_resource_list(stack.id, 2)"},{"line_number":198,"context_line":"        self.assert_scale_vnf("},{"line_number":199,"context_line":"            resp,"},{"line_number":200,"context_line":"            vnf_instance_id,"},{"line_number":201,"context_line":"            vnf_package_id,"},{"line_number":202,"context_line":"            pre_stack_resource_list,"},{"line_number":203,"context_line":"            post_stack_resource_list,"},{"line_number":204,"context_line":"            scale_type\u003d\u0027SCALE_IN\u0027)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        # Terminate VNF"},{"line_number":207,"context_line":"        stack \u003d self._get_heat_stack(vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":47,"id":"e836c638_1464163f","line":204,"range":{"start_line":198,"start_character":1,"end_line":204,"end_character":34},"in_reply_to":"7de53fc7_9a9cfb8c","updated":"2020-12-22 06:21:16.000000000","message":"Fixed together with the other similar lines.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":215,"context_line":"        resp, _ \u003d self._terminate_vnf_instance("},{"line_number":216,"context_line":"            vnf_instance_id, terminate_req_body)"},{"line_number":217,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":218,"context_line":"        self.assert_terminate_vnf("},{"line_number":219,"context_line":"            resp,"},{"line_number":220,"context_line":"            vnf_instance_id,"},{"line_number":221,"context_line":"            stack.id,"},{"line_number":222,"context_line":"            resource_name_list,"},{"line_number":223,"context_line":"            glance_image_id_list,"},{"line_number":224,"context_line":"            vnf_package_id)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        # Delete VNF"},{"line_number":227,"context_line":"        resp, _ \u003d self._delete_vnf_instance(vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":47,"id":"4022b6f1_71a4264c","line":224,"range":{"start_line":218,"start_character":0,"end_line":224,"end_character":27},"updated":"2020-12-18 08:37:29.000000000","message":"Why don\u0027t you reduce the number of lines? No need to put each param on each line.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        resp, _ \u003d self._terminate_vnf_instance("},{"line_number":216,"context_line":"            vnf_instance_id, terminate_req_body)"},{"line_number":217,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":218,"context_line":"        self.assert_terminate_vnf("},{"line_number":219,"context_line":"            resp,"},{"line_number":220,"context_line":"            vnf_instance_id,"},{"line_number":221,"context_line":"            stack.id,"},{"line_number":222,"context_line":"            resource_name_list,"},{"line_number":223,"context_line":"            glance_image_id_list,"},{"line_number":224,"context_line":"            vnf_package_id)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        # Delete VNF"},{"line_number":227,"context_line":"        resp, _ \u003d self._delete_vnf_instance(vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":47,"id":"3d94dc2b_8e4c683a","line":224,"range":{"start_line":218,"start_character":0,"end_line":224,"end_character":27},"in_reply_to":"4022b6f1_71a4264c","updated":"2020-12-22 06:21:16.000000000","message":"Fixed together with the other similar lines.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":813,"context_line":"        # Reserve deleting vnf instance"},{"line_number":814,"context_line":"        self.addCleanup(self._delete_vnf_instance, vnf_instance[\u0027id\u0027])"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"        request_body \u003d \\"},{"line_number":817,"context_line":"            vnflcm_base._create_instantiate_vnf_request_body(\"simple\","},{"line_number":818,"context_line":"                vim_id\u003dself.vim[\u0027id\u0027],"},{"line_number":819,"context_line":"                ext_vl\u003dself.ext_vl,"},{"line_number":820,"context_line":"                add_params\u003dadd_params)"}],"source_content_type":"text/x-python","patch_set":47,"id":"bc990661_d14488d4","line":817,"range":{"start_line":816,"start_character":0,"end_line":817,"end_character":70},"updated":"2020-12-18 08:37:29.000000000","message":"Although it\u0027s not a change of this update, could you remove this backslash as following because it\u0027s also your change.\n\n        request_body \u003d vnflcm_base._create_instantiate_vnf_request_body(","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        # Reserve deleting vnf instance"},{"line_number":814,"context_line":"        self.addCleanup(self._delete_vnf_instance, vnf_instance[\u0027id\u0027])"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"        request_body \u003d \\"},{"line_number":817,"context_line":"            vnflcm_base._create_instantiate_vnf_request_body(\"simple\","},{"line_number":818,"context_line":"                vim_id\u003dself.vim[\u0027id\u0027],"},{"line_number":819,"context_line":"                ext_vl\u003dself.ext_vl,"},{"line_number":820,"context_line":"                add_params\u003dadd_params)"}],"source_content_type":"text/x-python","patch_set":47,"id":"159eb984_4e2cf5c2","line":817,"range":{"start_line":816,"start_character":0,"end_line":817,"end_character":70},"in_reply_to":"bc990661_d14488d4","updated":"2020-12-22 06:21:16.000000000","message":"Fixed together with the other similar lines.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":881,"context_line":""},{"line_number":882,"context_line":"        # Failed instantiate VNF"},{"line_number":883,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances.make_inst_request_body("},{"line_number":884,"context_line":"            self.vim[\u0027tenant_id\u0027],"},{"line_number":885,"context_line":"            self.ext_networks,"},{"line_number":886,"context_line":"            self.ext_mngd_networks,"},{"line_number":887,"context_line":"            self.ext_link_ports,"},{"line_number":888,"context_line":"            self.ext_subnets)"},{"line_number":889,"context_line":"        resp, _ \u003d self._instantiate_vnf_instance(vnf_instance_id, request_body)"},{"line_number":890,"context_line":"        self._wait_lcm_done(\u0027FAILED_TEMP\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":891,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"304d72a8_49205c3c","line":888,"range":{"start_line":884,"start_character":1,"end_line":888,"end_character":29},"updated":"2020-12-18 08:37:29.000000000","message":"Why don\u0027t you reduce the number of lines? No need to put each param on each line.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"74e5d83ca6cbd78e4bfd4fdd0aefcfadb766e23b","unresolved":false,"context_lines":[{"line_number":881,"context_line":""},{"line_number":882,"context_line":"        # Failed instantiate VNF"},{"line_number":883,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances.make_inst_request_body("},{"line_number":884,"context_line":"            self.vim[\u0027tenant_id\u0027],"},{"line_number":885,"context_line":"            self.ext_networks,"},{"line_number":886,"context_line":"            self.ext_mngd_networks,"},{"line_number":887,"context_line":"            self.ext_link_ports,"},{"line_number":888,"context_line":"            self.ext_subnets)"},{"line_number":889,"context_line":"        resp, _ \u003d self._instantiate_vnf_instance(vnf_instance_id, request_body)"},{"line_number":890,"context_line":"        self._wait_lcm_done(\u0027FAILED_TEMP\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":891,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"d4a653a7_77959738","line":888,"range":{"start_line":884,"start_character":1,"end_line":888,"end_character":29},"in_reply_to":"304d72a8_49205c3c","updated":"2020-12-22 08:38:50.000000000","message":"Fixed.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":889,"context_line":"        resp, _ \u003d self._instantiate_vnf_instance(vnf_instance_id, request_body)"},{"line_number":890,"context_line":"        self._wait_lcm_done(\u0027FAILED_TEMP\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"        callback_url \u003d \\"},{"line_number":893,"context_line":"            os.path.join(vnflcm_base.MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":894,"context_line":"                self._testMethodName)"},{"line_number":895,"context_line":"        notify_mock_responses \u003d vnflcm_base.FAKE_SERVER_MANAGER.get_history("},{"line_number":896,"context_line":"            callback_url)"}],"source_content_type":"text/x-python","patch_set":47,"id":"d80039a6_f30403e9","line":893,"range":{"start_line":892,"start_character":0,"end_line":893,"end_character":62},"updated":"2020-12-18 08:37:29.000000000","message":"Could you remove the backslash as following?\n\n        callback_url \u003d os.path.join(","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":889,"context_line":"        resp, _ \u003d self._instantiate_vnf_instance(vnf_instance_id, request_body)"},{"line_number":890,"context_line":"        self._wait_lcm_done(\u0027FAILED_TEMP\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"        callback_url \u003d \\"},{"line_number":893,"context_line":"            os.path.join(vnflcm_base.MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":894,"context_line":"                self._testMethodName)"},{"line_number":895,"context_line":"        notify_mock_responses \u003d vnflcm_base.FAKE_SERVER_MANAGER.get_history("},{"line_number":896,"context_line":"            callback_url)"}],"source_content_type":"text/x-python","patch_set":47,"id":"54d46792_33931c14","line":893,"range":{"start_line":892,"start_character":0,"end_line":893,"end_character":62},"in_reply_to":"d80039a6_f30403e9","updated":"2020-12-22 06:21:16.000000000","message":"Fixed together with the other similar lines.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":983,"context_line":""},{"line_number":984,"context_line":"        # instantiate VNF"},{"line_number":985,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances.make_inst_request_body("},{"line_number":986,"context_line":"            self.vim[\u0027tenant_id\u0027],"},{"line_number":987,"context_line":"            self.ext_networks,"},{"line_number":988,"context_line":"            self.ext_mngd_networks,"},{"line_number":989,"context_line":"            self.ext_link_ports,"},{"line_number":990,"context_line":"            self.ext_subnets)"},{"line_number":991,"context_line":"        self._instantiate_vnf_instance(vnf_instance_id, request_body)"},{"line_number":992,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":993,"context_line":"        vnflcm_base.FAKE_SERVER_MANAGER.clear_history("}],"source_content_type":"text/x-python","patch_set":47,"id":"1df94a13_adae2cce","line":990,"range":{"start_line":986,"start_character":0,"end_line":990,"end_character":29},"updated":"2020-12-18 08:37:29.000000000","message":"Why don\u0027t you reduce the number of lines? No need to put each param on each line.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":983,"context_line":""},{"line_number":984,"context_line":"        # instantiate VNF"},{"line_number":985,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances.make_inst_request_body("},{"line_number":986,"context_line":"            self.vim[\u0027tenant_id\u0027],"},{"line_number":987,"context_line":"            self.ext_networks,"},{"line_number":988,"context_line":"            self.ext_mngd_networks,"},{"line_number":989,"context_line":"            self.ext_link_ports,"},{"line_number":990,"context_line":"            self.ext_subnets)"},{"line_number":991,"context_line":"        self._instantiate_vnf_instance(vnf_instance_id, request_body)"},{"line_number":992,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":993,"context_line":"        vnflcm_base.FAKE_SERVER_MANAGER.clear_history("}],"source_content_type":"text/x-python","patch_set":47,"id":"f8bf07ad_838574db","line":990,"range":{"start_line":986,"start_character":0,"end_line":990,"end_character":29},"in_reply_to":"1df94a13_adae2cce","updated":"2020-12-22 06:21:16.000000000","message":"Fixed together with the other similar lines.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":1035,"context_line":"        resp, _ \u003d self._terminate_vnf_instance("},{"line_number":1036,"context_line":"            vnf_instance_id, terminate_req_body)"},{"line_number":1037,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":1038,"context_line":"        self.assert_terminate_vnf("},{"line_number":1039,"context_line":"            resp,"},{"line_number":1040,"context_line":"            vnf_instance_id,"},{"line_number":1041,"context_line":"            stack.id,"},{"line_number":1042,"context_line":"            resource_name_list,"},{"line_number":1043,"context_line":"            glance_image_id_list,"},{"line_number":1044,"context_line":"            vnf_package_id)"},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"        # Delete VNF"},{"line_number":1047,"context_line":"        resp, _ \u003d self._delete_vnf_instance(vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":47,"id":"46b6126d_ac2fdbcc","line":1044,"range":{"start_line":1038,"start_character":0,"end_line":1044,"end_character":27},"updated":"2020-12-18 08:37:29.000000000","message":"Why don\u0027t you reduce the number of lines? No need to put each param on each line.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"74e5d83ca6cbd78e4bfd4fdd0aefcfadb766e23b","unresolved":false,"context_lines":[{"line_number":1035,"context_line":"        resp, _ \u003d self._terminate_vnf_instance("},{"line_number":1036,"context_line":"            vnf_instance_id, terminate_req_body)"},{"line_number":1037,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027, vnf_instance_id\u003dvnf_instance_id)"},{"line_number":1038,"context_line":"        self.assert_terminate_vnf("},{"line_number":1039,"context_line":"            resp,"},{"line_number":1040,"context_line":"            vnf_instance_id,"},{"line_number":1041,"context_line":"            stack.id,"},{"line_number":1042,"context_line":"            resource_name_list,"},{"line_number":1043,"context_line":"            glance_image_id_list,"},{"line_number":1044,"context_line":"            vnf_package_id)"},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"        # Delete VNF"},{"line_number":1047,"context_line":"        resp, _ \u003d self._delete_vnf_instance(vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":47,"id":"a6f8e2dd_19178736","line":1044,"range":{"start_line":1038,"start_character":0,"end_line":1044,"end_character":27},"in_reply_to":"46b6126d_ac2fdbcc","updated":"2020-12-22 08:38:50.000000000","message":"Fixed.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":1111,"context_line":"            self.tacker_client, vnf_pkg_id)"},{"line_number":1112,"context_line":"        self.assert_vnf_package_usage_state(vnf_pkg_info)"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"    def assert_scale_vnf("},{"line_number":1115,"context_line":"            self,"},{"line_number":1116,"context_line":"            resp,"},{"line_number":1117,"context_line":"            vnf_instance_id,"}],"source_content_type":"text/x-python","patch_set":47,"id":"c2788b01_8fb3325b","line":1114,"range":{"start_line":1114,"start_character":8,"end_line":1114,"end_character":24},"updated":"2020-12-18 08:37:29.000000000","message":"It\u0027s better to add prefix `_` if it\u0027s a private method. It can be confusing with inherited methods.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"            self.tacker_client, vnf_pkg_id)"},{"line_number":1112,"context_line":"        self.assert_vnf_package_usage_state(vnf_pkg_info)"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"    def assert_scale_vnf("},{"line_number":1115,"context_line":"            self,"},{"line_number":1116,"context_line":"            resp,"},{"line_number":1117,"context_line":"            vnf_instance_id,"}],"source_content_type":"text/x-python","patch_set":47,"id":"20143fbd_be9b632d","line":1114,"range":{"start_line":1114,"start_character":8,"end_line":1114,"end_character":24},"in_reply_to":"c2788b01_8fb3325b","updated":"2020-12-22 06:21:16.000000000","message":"Done","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":1118,"context_line":"            vnf_pkg_id,"},{"line_number":1119,"context_line":"            pre_stack_resource_list,"},{"line_number":1120,"context_line":"            post_stack_resource_list,"},{"line_number":1121,"context_line":"            scale_type\u003d\u0027SCALE_OUT\u0027):"},{"line_number":1122,"context_line":"        super().assert_scale_vnf("},{"line_number":1123,"context_line":"            resp,"},{"line_number":1124,"context_line":"            vnf_instance_id,"}],"source_content_type":"text/x-python","patch_set":47,"id":"4c156a61_ccbb2b64","line":1121,"updated":"2020-12-18 08:37:29.000000000","message":"Could you tell me why only it\u0027s set the default value?","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"74e5d83ca6cbd78e4bfd4fdd0aefcfadb766e23b","unresolved":false,"context_lines":[{"line_number":1118,"context_line":"            vnf_pkg_id,"},{"line_number":1119,"context_line":"            pre_stack_resource_list,"},{"line_number":1120,"context_line":"            post_stack_resource_list,"},{"line_number":1121,"context_line":"            scale_type\u003d\u0027SCALE_OUT\u0027):"},{"line_number":1122,"context_line":"        super().assert_scale_vnf("},{"line_number":1123,"context_line":"            resp,"},{"line_number":1124,"context_line":"            vnf_instance_id,"}],"source_content_type":"text/x-python","patch_set":47,"id":"f0982d89_e37d8685","line":1121,"in_reply_to":"4c156a61_ccbb2b64","updated":"2020-12-22 08:38:50.000000000","message":"It is not necessarily need to be set here.\nRemoved from here and also modified to be set in the function calling this one.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"260a2deb34ab0082623604e9e597fadd637c09a9","unresolved":true,"context_lines":[{"line_number":1166,"context_line":"            expected_usage_state,"},{"line_number":1167,"context_line":"            vnf_package_info[\u0027usageState\u0027])"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":"    def assert_occ_show(self, resp, op_occs_info):"},{"line_number":1170,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        # Only check required parameters."}],"source_content_type":"text/x-python","patch_set":47,"id":"69361418_f5300dfa","line":1169,"range":{"start_line":1169,"start_character":8,"end_line":1169,"end_character":23},"updated":"2020-12-18 08:37:29.000000000","message":"It\u0027s better to add prefix `_` if it\u0027s a private method. It can be confusing with inherited methods.","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"5b3603503711ebee76fbb47228f013cfb4551e0a","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"            expected_usage_state,"},{"line_number":1167,"context_line":"            vnf_package_info[\u0027usageState\u0027])"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":"    def assert_occ_show(self, resp, op_occs_info):"},{"line_number":1170,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        # Only check required parameters."}],"source_content_type":"text/x-python","patch_set":47,"id":"d1aa9e52_92c625d0","line":1169,"range":{"start_line":1169,"start_character":8,"end_line":1169,"end_character":23},"in_reply_to":"69361418_f5300dfa","updated":"2020-12-22 06:21:16.000000000","message":"Done","commit_id":"efb3b633d5f49848a88fc86d82e8f0dc30555953"}],"tacker/tests/functional/vnflcm/test_vnf_instance_with_user_data_nfvo_separat.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"41366cef0c9423ffb4ac94a178e8917671c45330","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_9da3ba43","line":1,"updated":"2020-10-06 02:47:49.000000000","message":"I think the file name should be `test_vnf_instance_with_user_data_nfvo_separate.py`.","commit_id":"bc44f28a42ba1172f2f8756271adddea9881e603"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"a07a311ca089606503938e3ecb28ded158569031","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_3c80a79c","line":1,"in_reply_to":"9f560f44_9da3ba43","updated":"2020-10-06 14:33:24.000000000","message":"The file is renamed.","commit_id":"bc44f28a42ba1172f2f8756271adddea9881e603"}]}
