)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"35c439f5c8ecd00c9f40e1e166e9237adb911447","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Fix is also added for server shutdown since it has"},{"line_number":11,"context_line":"a case where it is stopped unsafely."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic424445ec9b836d83ffe4184d5b848fd17590606"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":42,"id":"2efb7c62_bb85f5c1","line":13,"updated":"2020-12-16 03:16:02.000000000","message":"Could you add `Implements` tag for blueprint, and it\u0027s more helpful if you also add the link of spec you implemented.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3855e68a22352d88a66813589ce125678afdb584","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Fix is also added for server shutdown since it has"},{"line_number":11,"context_line":"a case where it is stopped unsafely."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic424445ec9b836d83ffe4184d5b848fd17590606"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":42,"id":"ad72d1bb_1e381f24","line":13,"in_reply_to":"2efb7c62_bb85f5c1","updated":"2020-12-21 09:11:41.000000000","message":"The tag is added.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"}],"tacker/tests/etc/samples/etsi/nfv/functional2/UserData/lcm_user_data.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"35c439f5c8ecd00c9f40e1e166e9237adb911447","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#\r"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain\r"},{"line_number":4,"context_line":"# a copy of the License at\r"}],"source_content_type":"text/x-python","patch_set":42,"id":"7f4b97ac_a9a3f208","line":1,"updated":"2020-12-16 03:16:02.000000000","message":"All newline char in this file looks wrong, `^M`,  on my host. Could you confirm for that?","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3855e68a22352d88a66813589ce125678afdb584","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#\r"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain\r"},{"line_number":4,"context_line":"# a copy of the License at\r"}],"source_content_type":"text/x-python","patch_set":42,"id":"d00872a7_76a3ac73","line":1,"in_reply_to":"7f4b97ac_a9a3f208","updated":"2020-12-21 09:11:41.000000000","message":"Those are corrected. Also done for the same file under \"functional\" directory.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"}],"tacker/tests/functional/base.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"35c439f5c8ecd00c9f40e1e166e9237adb911447","unresolved":true,"context_lines":[{"line_number":84,"context_line":"class BaseTackerTest(base.BaseTestCase):"},{"line_number":85,"context_line":"    \"\"\"Base test case class for all Tacker API tests.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    # Class specific variables"},{"line_number":88,"context_line":"    tacker_config_file \u003d \u0027/etc/tacker/tacker.conf\u0027"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":42,"id":"33469f5c_1bd74fb6","line":87,"updated":"2020-12-16 03:16:02.000000000","message":"It\u0027s useless comment.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3855e68a22352d88a66813589ce125678afdb584","unresolved":false,"context_lines":[{"line_number":84,"context_line":"class BaseTackerTest(base.BaseTestCase):"},{"line_number":85,"context_line":"    \"\"\"Base test case class for all Tacker API tests.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    # Class specific variables"},{"line_number":88,"context_line":"    tacker_config_file \u003d \u0027/etc/tacker/tacker.conf\u0027"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":42,"id":"268e5b03_d4e33f56","line":87,"in_reply_to":"33469f5c_1bd74fb6","updated":"2020-12-21 09:11:41.000000000","message":"The comment is removed.\nAlso \"tacker_config_file\" variable is useless, so removed.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"35c439f5c8ecd00c9f40e1e166e9237adb911447","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        cls.client \u003d cls.tackerclient()"},{"line_number":101,"context_line":"        cls.http_client \u003d cls.tacker_http_client()"},{"line_number":102,"context_line":"        cls.h_client \u003d cls.heatclient()"},{"line_number":103,"context_line":"        cls.glance_client \u003d cls.glanceclient()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":42,"id":"7472c576_80e7955a","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":20},"updated":"2020-12-16 03:16:02.000000000","message":"Could you revise it to `heat_client` as `glance_client` you added? Thanks!","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3855e68a22352d88a66813589ce125678afdb584","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        cls.client \u003d cls.tackerclient()"},{"line_number":101,"context_line":"        cls.http_client \u003d cls.tacker_http_client()"},{"line_number":102,"context_line":"        cls.h_client \u003d cls.heatclient()"},{"line_number":103,"context_line":"        cls.glance_client \u003d cls.glanceclient()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":42,"id":"1932affb_4e6e4bcb","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":20},"in_reply_to":"7472c576_80e7955a","updated":"2020-12-21 09:11:41.000000000","message":"This name is already used also in other files, so I think it should not be renamed. Left as it is.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"}],"tacker/tests/functional/common/fake_server.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"35c439f5c8ecd00c9f40e1e166e9237adb911447","unresolved":true,"context_lines":[{"line_number":395,"context_line":"            try:"},{"line_number":396,"context_line":"                self.objHttpd \u003d http.server.HTTPServer("},{"line_number":397,"context_line":"                    (address, port), DummyRequestHander)"},{"line_number":398,"context_line":"            except OSError:"},{"line_number":399,"context_line":"                continue"},{"line_number":400,"context_line":"            else:"},{"line_number":401,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":42,"id":"a8db0130_7f1d8d37","line":398,"updated":"2020-12-16 03:16:02.000000000","message":"Although I\u0027m not sure the situation, don\u0027t we need to consider infinite loop?","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3855e68a22352d88a66813589ce125678afdb584","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            try:"},{"line_number":396,"context_line":"                self.objHttpd \u003d http.server.HTTPServer("},{"line_number":397,"context_line":"                    (address, port), DummyRequestHander)"},{"line_number":398,"context_line":"            except OSError:"},{"line_number":399,"context_line":"                continue"},{"line_number":400,"context_line":"            else:"},{"line_number":401,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":42,"id":"39628e13_c276f0c3","line":398,"in_reply_to":"a8db0130_7f1d8d37","updated":"2020-12-21 09:11:41.000000000","message":"This behavior is needed for resident process. Since it is removed with tearDown, so there is no problem.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"}],"tacker/tests/functional/vnflcm/base.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5e12afb6e53405628517fc5cb3f55441cf3527bd","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    vnfd_id \u003d None"},{"line_number":123,"context_line":"    while True:"},{"line_number":124,"context_line":"        resp, body \u003d tacker_client.do_request(show_url, \"GET\")"},{"line_number":125,"context_line":"        if (200 \u003c\u003d resp.status_code \u003c 300) and ("},{"line_number":126,"context_line":"                body[\u0027onboardingState\u0027] \u003d\u003d \"ONBOARDED\"):"},{"line_number":127,"context_line":"            vnfd_id \u003d body[\u0027vnfdId\u0027]"},{"line_number":128,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":42,"id":"ff9e2d12_0b07567e","line":125,"updated":"2020-12-15 03:00:17.000000000","message":"Is this fix required for this patch?","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e406fc4ab089e2ff93a91af083d20765bb9dd1e1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    vnfd_id \u003d None"},{"line_number":123,"context_line":"    while True:"},{"line_number":124,"context_line":"        resp, body \u003d tacker_client.do_request(show_url, \"GET\")"},{"line_number":125,"context_line":"        if (200 \u003c\u003d resp.status_code \u003c 300) and ("},{"line_number":126,"context_line":"                body[\u0027onboardingState\u0027] \u003d\u003d \"ONBOARDED\"):"},{"line_number":127,"context_line":"            vnfd_id \u003d body[\u0027vnfdId\u0027]"},{"line_number":128,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":42,"id":"c825be88_3cccd07b","line":125,"in_reply_to":"c1c62daf_7594f54a","updated":"2020-12-22 04:32:34.000000000","message":"I\u0027ve confirmed.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3855e68a22352d88a66813589ce125678afdb584","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    vnfd_id \u003d None"},{"line_number":123,"context_line":"    while True:"},{"line_number":124,"context_line":"        resp, body \u003d tacker_client.do_request(show_url, \"GET\")"},{"line_number":125,"context_line":"        if (200 \u003c\u003d resp.status_code \u003c 300) and ("},{"line_number":126,"context_line":"                body[\u0027onboardingState\u0027] \u003d\u003d \"ONBOARDED\"):"},{"line_number":127,"context_line":"            vnfd_id \u003d body[\u0027vnfdId\u0027]"},{"line_number":128,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":42,"id":"c1c62daf_7594f54a","line":125,"in_reply_to":"ff9e2d12_0b07567e","updated":"2020-12-21 09:11:41.000000000","message":"If there is no body in an illegal response, it is unable to continue re-sending process due to the exception.\nIn order to avoid this behavior, the fix is required.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5e12afb6e53405628517fc5cb3f55441cf3527bd","unresolved":true,"context_lines":[{"line_number":461,"context_line":"        try:"},{"line_number":462,"context_line":"            stacks \u003d self.h_client.stacks.list()"},{"line_number":463,"context_line":"        except Exception:"},{"line_number":464,"context_line":"            print(\"heat-stacks does not exists.\", flush\u003dTrue)"},{"line_number":465,"context_line":"            return None"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        target_stack_name \u003d prefix_id + vnf_instance_id"}],"source_content_type":"text/x-python","patch_set":42,"id":"f09d0ca4_542be2ff","line":464,"updated":"2020-12-15 03:00:17.000000000","message":"Is this print statement the output you expected?","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e406fc4ab089e2ff93a91af083d20765bb9dd1e1","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        try:"},{"line_number":462,"context_line":"            stacks \u003d self.h_client.stacks.list()"},{"line_number":463,"context_line":"        except Exception:"},{"line_number":464,"context_line":"            print(\"heat-stacks does not exists.\", flush\u003dTrue)"},{"line_number":465,"context_line":"            return None"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        target_stack_name \u003d prefix_id + vnf_instance_id"}],"source_content_type":"text/x-python","patch_set":42,"id":"77f5ff48_5a47ac7a","line":464,"in_reply_to":"0e4e4374_8d286d07","updated":"2020-12-22 04:32:34.000000000","message":"I\u0027ve confirmed.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3855e68a22352d88a66813589ce125678afdb584","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        try:"},{"line_number":462,"context_line":"            stacks \u003d self.h_client.stacks.list()"},{"line_number":463,"context_line":"        except Exception:"},{"line_number":464,"context_line":"            print(\"heat-stacks does not exists.\", flush\u003dTrue)"},{"line_number":465,"context_line":"            return None"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        target_stack_name \u003d prefix_id + vnf_instance_id"}],"source_content_type":"text/x-python","patch_set":42,"id":"0e4e4374_8d286d07","line":464,"in_reply_to":"60174d0a_12e79c22","updated":"2020-12-21 09:11:41.000000000","message":"This modification is not the mandatory one, so removed.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f25c9d972a25af4a4ed8dc98c601b38381ba80f8","unresolved":true,"context_lines":[{"line_number":461,"context_line":"        try:"},{"line_number":462,"context_line":"            stacks \u003d self.h_client.stacks.list()"},{"line_number":463,"context_line":"        except Exception:"},{"line_number":464,"context_line":"            print(\"heat-stacks does not exists.\", flush\u003dTrue)"},{"line_number":465,"context_line":"            return None"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        target_stack_name \u003d prefix_id + vnf_instance_id"}],"source_content_type":"text/x-python","patch_set":42,"id":"60174d0a_12e79c22","line":464,"in_reply_to":"f09d0ca4_542be2ff","updated":"2020-12-15 06:51:12.000000000","message":"I understand that \u0027flush\u003dTrue\u0027 was added for the purpose of forcibly outputting.\nHowever, is this fix necessary to pass the functional-test?","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5e12afb6e53405628517fc5cb3f55441cf3527bd","unresolved":true,"context_lines":[{"line_number":480,"context_line":"            resources \u003d self.h_client.resources.list("},{"line_number":481,"context_line":"                stack_id, nested_depth\u003dnested_depth)"},{"line_number":482,"context_line":"        except Exception:"},{"line_number":483,"context_line":"            print(\"heat-stacks-resources does not exists.\","},{"line_number":484,"context_line":"                stack_id,"},{"line_number":485,"context_line":"                flush\u003dTrue)"},{"line_number":486,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":42,"id":"ed40fd37_2a9fb37c","line":483,"updated":"2020-12-15 03:00:17.000000000","message":"ditto","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e406fc4ab089e2ff93a91af083d20765bb9dd1e1","unresolved":false,"context_lines":[{"line_number":480,"context_line":"            resources \u003d self.h_client.resources.list("},{"line_number":481,"context_line":"                stack_id, nested_depth\u003dnested_depth)"},{"line_number":482,"context_line":"        except Exception:"},{"line_number":483,"context_line":"            print(\"heat-stacks-resources does not exists.\","},{"line_number":484,"context_line":"                stack_id,"},{"line_number":485,"context_line":"                flush\u003dTrue)"},{"line_number":486,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":42,"id":"25011d44_dd923502","line":483,"in_reply_to":"c11704a3_4025420d","updated":"2020-12-22 04:32:34.000000000","message":"I\u0027ve confirmed.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3855e68a22352d88a66813589ce125678afdb584","unresolved":false,"context_lines":[{"line_number":480,"context_line":"            resources \u003d self.h_client.resources.list("},{"line_number":481,"context_line":"                stack_id, nested_depth\u003dnested_depth)"},{"line_number":482,"context_line":"        except Exception:"},{"line_number":483,"context_line":"            print(\"heat-stacks-resources does not exists.\","},{"line_number":484,"context_line":"                stack_id,"},{"line_number":485,"context_line":"                flush\u003dTrue)"},{"line_number":486,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":42,"id":"c11704a3_4025420d","line":483,"in_reply_to":"ed40fd37_2a9fb37c","updated":"2020-12-21 09:11:41.000000000","message":"Removed.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5e12afb6e53405628517fc5cb3f55441cf3527bd","unresolved":true,"context_lines":[{"line_number":492,"context_line":"            resource \u003d self.h_client.resources.get("},{"line_number":493,"context_line":"                stack_id, resource_name)"},{"line_number":494,"context_line":"        except Exception:"},{"line_number":495,"context_line":"            print(\"heat-stacks-resource does not exists.\","},{"line_number":496,"context_line":"                stack_id, resource_name,"},{"line_number":497,"context_line":"                flush\u003dTrue)"},{"line_number":498,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":42,"id":"8374f0b6_19a62b4f","line":495,"updated":"2020-12-15 03:00:17.000000000","message":"ditto","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3855e68a22352d88a66813589ce125678afdb584","unresolved":false,"context_lines":[{"line_number":492,"context_line":"            resource \u003d self.h_client.resources.get("},{"line_number":493,"context_line":"                stack_id, resource_name)"},{"line_number":494,"context_line":"        except Exception:"},{"line_number":495,"context_line":"            print(\"heat-stacks-resource does not exists.\","},{"line_number":496,"context_line":"                stack_id, resource_name,"},{"line_number":497,"context_line":"                flush\u003dTrue)"},{"line_number":498,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":42,"id":"c70f5fc8_e4f7099f","line":495,"in_reply_to":"8374f0b6_19a62b4f","updated":"2020-12-21 09:11:41.000000000","message":"Removed.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e406fc4ab089e2ff93a91af083d20765bb9dd1e1","unresolved":false,"context_lines":[{"line_number":492,"context_line":"            resource \u003d self.h_client.resources.get("},{"line_number":493,"context_line":"                stack_id, resource_name)"},{"line_number":494,"context_line":"        except Exception:"},{"line_number":495,"context_line":"            print(\"heat-stacks-resource does not exists.\","},{"line_number":496,"context_line":"                stack_id, resource_name,"},{"line_number":497,"context_line":"                flush\u003dTrue)"},{"line_number":498,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":42,"id":"9307f76a_f37d3da5","line":495,"in_reply_to":"c70f5fc8_e4f7099f","updated":"2020-12-22 04:32:34.000000000","message":"I\u0027ve confirmed.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"35c439f5c8ecd00c9f40e1e166e9237adb911447","unresolved":true,"context_lines":[{"line_number":981,"context_line":"        self.assertIsNotNone(_links.get(\u0027self\u0027).get(\u0027href\u0027))"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"    def _filter_notify_history(self, callback_url, vnf_instance_id):"},{"line_number":984,"context_line":"        notify_historys \u003d FAKE_SERVER_MANAGER.get_history("},{"line_number":985,"context_line":"            callback_url)"},{"line_number":986,"context_line":"        FAKE_SERVER_MANAGER.clear_history(callback_url)"},{"line_number":987,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"7548a14a_471e9937","line":984,"range":{"start_line":984,"start_character":15,"end_line":984,"end_character":23},"updated":"2020-12-16 03:16:02.000000000","message":"`histories`, correctly?","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3855e68a22352d88a66813589ce125678afdb584","unresolved":false,"context_lines":[{"line_number":981,"context_line":"        self.assertIsNotNone(_links.get(\u0027self\u0027).get(\u0027href\u0027))"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"    def _filter_notify_history(self, callback_url, vnf_instance_id):"},{"line_number":984,"context_line":"        notify_historys \u003d FAKE_SERVER_MANAGER.get_history("},{"line_number":985,"context_line":"            callback_url)"},{"line_number":986,"context_line":"        FAKE_SERVER_MANAGER.clear_history(callback_url)"},{"line_number":987,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"2c7c036b_417de089","line":984,"range":{"start_line":984,"start_character":15,"end_line":984,"end_character":23},"in_reply_to":"7548a14a_471e9937","updated":"2020-12-21 09:11:41.000000000","message":"Fixed.","commit_id":"0fd75d5fd4c38015f158d3b7b8707dfa43dcd701"}],"tacker/tests/functional/vnflcm/test_vnf_instance_with_user_data.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"64fdb6e13a0267ed313dc3dc1af8256c5822df14","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        self.assert_instantiate_vnf(resp, vnf_instance_id, vnf_package_id)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # Heal vnf (do not specify vnfc_instace_id)"},{"line_number":314,"context_line":"        # TODO(esto.aln): pre check heat status."},{"line_number":315,"context_line":"        self.assert_heat_stack_status("},{"line_number":316,"context_line":"            vnf_instance[\u0027vnfInstanceName\u0027],"},{"line_number":317,"context_line":"            expected_stack_status\u003d\u0027UPDATE_COMPLETE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_2815373e","line":314,"range":{"start_line":314,"start_character":10,"end_line":314,"end_character":24},"updated":"2020-09-17 05:05:27.000000000","message":"Did you forget to delete this TODO comment?","commit_id":"b1ff30fd8587f27be07e1f6ee11bd66e574f66e9"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"36d0be5171547a373cbe33522725827d92ef42e1","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        self.assert_instantiate_vnf(resp, vnf_instance_id, vnf_package_id)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # Heal vnf (do not specify vnfc_instace_id)"},{"line_number":314,"context_line":"        # TODO(esto.aln): pre check heat status."},{"line_number":315,"context_line":"        self.assert_heat_stack_status("},{"line_number":316,"context_line":"            vnf_instance[\u0027vnfInstanceName\u0027],"},{"line_number":317,"context_line":"            expected_stack_status\u003d\u0027UPDATE_COMPLETE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_1ce6d5b1","line":314,"range":{"start_line":314,"start_character":10,"end_line":314,"end_character":24},"in_reply_to":"9f560f44_2815373e","updated":"2020-09-30 10:00:35.000000000","message":"TODO is removed.","commit_id":"b1ff30fd8587f27be07e1f6ee11bd66e574f66e9"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"64fdb6e13a0267ed313dc3dc1af8256c5822df14","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        resp, _ \u003d self._heal_vnf_instance(vnf_instance_id, request_body)"},{"line_number":321,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        # TODO(esto.aln): post check heat status."},{"line_number":324,"context_line":"        self.assert_heal_vnf("},{"line_number":325,"context_line":"            resp,"},{"line_number":326,"context_line":"            vnf_instance_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_481a2b6f","line":323,"range":{"start_line":323,"start_character":10,"end_line":323,"end_character":25},"updated":"2020-09-17 05:05:27.000000000","message":"Did you forget to delete this TODO comment?","commit_id":"b1ff30fd8587f27be07e1f6ee11bd66e574f66e9"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"36d0be5171547a373cbe33522725827d92ef42e1","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        resp, _ \u003d self._heal_vnf_instance(vnf_instance_id, request_body)"},{"line_number":321,"context_line":"        self._wait_lcm_done(\u0027COMPLETED\u0027)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        # TODO(esto.aln): post check heat status."},{"line_number":324,"context_line":"        self.assert_heal_vnf("},{"line_number":325,"context_line":"            resp,"},{"line_number":326,"context_line":"            vnf_instance_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_fcea0172","line":323,"range":{"start_line":323,"start_character":10,"end_line":323,"end_character":25},"in_reply_to":"9f560f44_481a2b6f","updated":"2020-09-30 10:00:35.000000000","message":"TODO is removed.","commit_id":"b1ff30fd8587f27be07e1f6ee11bd66e574f66e9"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"35c439f5c8ecd00c9f40e1e166e9237adb911447","unresolved":true,"context_lines":[{"line_number":739,"context_line":"        self.assert_vnf_package_usage_state(vnf_pkg_info)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"    def assert_update_vnf("},{"line_number":742,"context_line":"            self,"},{"line_number":743,"context_line":"            resp,"},{"line_number":744,"context_line":"            vnf_instance_id,"},{"line_number":745,"context_line":"            is_vnfd\u003dTrue,"},{"line_number":746,"context_line":"            after_id\u003dNone,"},{"line_number":747,"context_line":"            old_id\u003dNone,"},{"line_number":748,"context_line":"            expected_stack_status\u003d\u0027CREATE_COMPLETE\u0027):"},{"line_number":749,"context_line":"        super().assert_update_vnf("},{"line_number":750,"context_line":"            resp, vnf_instance_id, expected_stack_status\u003dexpected_stack_status)"},{"line_number":751,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"3f6cbcb5_9c5ca7af","line":748,"range":{"start_line":742,"start_character":0,"end_line":748,"end_character":51},"updated":"2020-12-16 03:16:02.000000000","message":"Could you add docstring to avoid to listing up each params in each line. It can be readable without writing params like that if you add docstring to explain.","commit_id":"f62c7d78c7496fc6f6dfb75fc41f80aa71da6156"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"3855e68a22352d88a66813589ce125678afdb584","unresolved":true,"context_lines":[{"line_number":739,"context_line":"        self.assert_vnf_package_usage_state(vnf_pkg_info)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"    def assert_update_vnf("},{"line_number":742,"context_line":"            self,"},{"line_number":743,"context_line":"            resp,"},{"line_number":744,"context_line":"            vnf_instance_id,"},{"line_number":745,"context_line":"            is_vnfd\u003dTrue,"},{"line_number":746,"context_line":"            after_id\u003dNone,"},{"line_number":747,"context_line":"            old_id\u003dNone,"},{"line_number":748,"context_line":"            expected_stack_status\u003d\u0027CREATE_COMPLETE\u0027):"},{"line_number":749,"context_line":"        super().assert_update_vnf("},{"line_number":750,"context_line":"            resp, vnf_instance_id, expected_stack_status\u003dexpected_stack_status)"},{"line_number":751,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"28e52b5c_753b9308","line":748,"range":{"start_line":742,"start_character":0,"end_line":748,"end_character":51},"in_reply_to":"3f6cbcb5_9c5ca7af","updated":"2020-12-21 09:11:41.000000000","message":"Modified according to your suggestion. Is this the same as your expectation?","commit_id":"f62c7d78c7496fc6f6dfb75fc41f80aa71da6156"}]}